[PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

2012-11-06 Thread Vivek Gautam
Adding base address information and required platform data support for enabling USB DRD phy on exynos5250 SOC. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi|3 ++- arch/arm/mach-exynos/include/mach/regs-pmu.h |4 arch/arm/mach-exynos/setup-usb-phy.c

Re: [PATCH v7 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-07 Thread Vivek Gautam
> Signed-off-by: Praveen Paneri > Acked-by: Heiko Stuebner > Acked-by: Kyungmin Park I have tested this patch-series for S3C6410 and S5PV310 for gadget functioning. Looks good to me. Tested-by: Vivek Gautam > --- > .../devicetree/bindings/usb/samsung-usbphy.txt | 1

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Vivek Gautam
Hi, On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi wrote: > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: >> Adding DWC3 device tree node for Exynos5250 along with the >> device address and clock support needed for the controller. >> >>

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Vivek Gautam
Hi, On Wed, Nov 7, 2012 at 5:10 AM, Sylwester Nawrocki wrote: > > Hi, > > I have a few comments. Please see below... > > > On 11/06/2012 04:36 PM, Vivek Gautam wrote: >> >> Adding support for USB3.0 phy for dwc3 controller on >> exynso5250 SOC. > >

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Vivek Gautam
Hi, On Wed, Nov 7, 2012 at 10:48 PM, Tomasz Figa wrote: > Hi Vivek, Felipe, > > On Wednesday 07 of November 2012 18:43:22 Felipe Balbi wrote: >> Hi, >> >> On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: >> > Hi, >> > >> >

[PATCH v2 0/2] Enable ehci and ohci devices for exynos5250

2012-11-07 Thread Vivek Gautam
Changes from v1: - Changed the device node names from 'ehci' and 'ohci' to 'usb@1211' and 'usb@1212' as per discussion for the change 'http://www.spinics.net/lists/linux-usb/msg73993.html' - Rebased on for-next branch of linux-samsu

[PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-11-07 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- .../devicetree/bindings/usb/exynos-usb.txt | 25 arch/arm/boot/dts/exynos5250-smdk5250.dts |4

[PATCH v2 2/2] ARM: Exynos5250: Enabling ohci-exynos driver

2012-11-07 Thread Vivek Gautam
Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- .../devicetree/bindings/usb/exynos-usb.txt | 15 +++ arch/arm/boot/dts/exynos5250.dtsi |6 ++ arch/arm/mach-exynos

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-11-08 Thread Vivek Gautam
Hi all, On Thu, Nov 8, 2012 at 12:24 PM, Vivek Gautam wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > .../devicetree/bindings/usb/exynos-u

Re: [PATCH v2 2/2] ARM: Exynos5250: Enabling ohci-exynos driver

2012-11-08 Thread Vivek Gautam
Hi all, On Thu, Nov 8, 2012 at 12:24 PM, Vivek Gautam wrote: > Adding OHCI device tree node for Exynos5250 along with > the device base address. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > .../devicetree/bindings/usb/exynos-usb.txt | 15 ++

[PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-11-08 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- .../devicetree/bindings/usb/exynos-usb.txt | 25 arch/arm/boot/dts/exynos5250-smdk5250.dts |4

[PATCH v2 2/2] ARM: Exynos5250: Enabling ohci-exynos driver

2012-11-08 Thread Vivek Gautam
Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- .../devicetree/bindings/usb/exynos-usb.txt | 15 +++ arch/arm/boot/dts/exynos5250.dtsi |6 ++ arch/arm/mach-exynos

[PATCH v2] ARM: EXYNOS5250: Add support for USB 3.0 dwc3 controller

2012-11-08 Thread Vivek Gautam
Tested with required driver DT patches for dwc3-exynos: http://www.spinics.net/lists/linux-usb/msg73857.html and USB 3.0 phy support patches: https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/021926.html Vivek Gautam (1): ARM: Exynos5250: Enabling dwc3-exynos driver .../

[PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-08 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/exynos-usb.txt | 14 +++ arch/arm/boot/dts/exynos5250.dtsi |6 + arch/arm

[PATCH v3 00/11] usb: dwc3/xhci/phy: Enable runtime power management

2013-04-01 Thread Vivek Gautam
d of in any glue layer. - Splitting the patch: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb into required number to bifurcate functionality. Vivek Gautam (11): usb: phy: Add APIs for runtime power management USB: dwc3: Adjust runtime pm to allow autosuspend

[PATCH v3 06/11] usb: xhci: Enable runtime pm in xhci-plat

2013-04-01 Thread Vivek Gautam
By enabling runtime pm in this driver allows users of xhci-plat to enter into runtime pm. This is not full runtime pm support (AKA xhci-plat doesn't actually power anything off when in runtime suspend mode) but, just basic enablement. Signed-off-by: Vivek Gautam CC: Doug Anderson --- dr

[PATCH v3 07/11] usb: phy: samsung: Enable runtime power management on usb2phy

2013-04-01 Thread Vivek Gautam
Enable autosuspending of Samsung usb2.0 PHY Signed-off-by: Vivek Gautam --- drivers/usb/phy/phy-samsung-usb2.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-samsung-usb2.c b/drivers/usb/phy/phy-samsung-usb2.c index 45ffe03..d378fe9 100644

[PATCH v3 09/11] usb: phy: samsung: Add support for external reference clock

2013-04-01 Thread Vivek Gautam
The PHY controller can choose between ref_pad_clk (XusbXTI-external PLL), or EXTREFCLK (XXTI-internal clock crystal) to generate the required clock. Adding the provision for ref_pad_clk here. Signed-off-by: Vivek Gautam --- drivers/usb/phy/phy-samsung-usb3.c | 46

[PATCH v3 08/11] usb: phy: samsung: Enable runtime power management on usb3phy

2013-04-01 Thread Vivek Gautam
Enable autosuspending of Samsung usb3.0 PHY Signed-off-by: Vivek Gautam --- drivers/usb/phy/phy-samsung-usb3.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-samsung-usb3.c b/drivers/usb/phy/phy-samsung-usb3.c index 54f6418..a713585 100644

[PATCH v3 05/11] usb: dwc3: exynos: Enable runtime power management

2013-04-01 Thread Vivek Gautam
Enabling runtime power management on dwc3-exynos letting dwc3 controller to be autosuspended on exynos platform when not in use. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/dwc3-exynos.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3

[PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-01 Thread Vivek Gautam
Right now it doesn't handle full runtime suspend/resume functionality. However it allows to handle PHYs' sleep and wakeup across runtime suspend/resume. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c | 43 +++ 1 files changed, 43

[PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-01 Thread Vivek Gautam
Adding APIs to handle runtime power management on PHY devices. PHY consumers may need to wake-up/suspend PHYs when they work across autosuspend. Signed-off-by: Vivek Gautam --- include/linux/usb/phy.h | 141 +++ 1 files changed, 141 insertions(+), 0

[PATCH v3 03/11] usb: dwc3: Enable runtime pm only after PHYs are initialized

2013-04-01 Thread Vivek Gautam
Allow dwc3 to enable auto power management only after its PHYs are initialized so that any further PHY handling by dwc3's runtime power management callbacks is fine. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c | 18 +- 1 files changed, 9 insertions(+), 9 dele

[PATCH v3 02/11] USB: dwc3: Adjust runtime pm to allow autosuspend

2013-04-01 Thread Vivek Gautam
The current code in the dwc3 probe effectively disables runtime pm from ever working because it calls a get() that was never put() until device removal. Change the runtime pm code to match the standard formula and allow runtime pm to function. Signed-off-by: Vivek Gautam CC: Doug Anderson

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Vivek Gautam
Hi, On Tue, Apr 2, 2013 at 1:53 PM, Felipe Balbi wrote: > On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: >> Adding APIs to handle runtime power management on PHY >> devices. PHY consumers may need to wake-up/suspend PHYs >> when they work across autosuspend

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Vivek Gautam
Hi, On Tue, Apr 2, 2013 at 5:40 PM, Felipe Balbi wrote: > Hi, > > On Tue, Apr 02, 2013 at 04:04:01PM +0530, Vivek Gautam wrote: >> > On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: >> >> Adding APIs to handle runtime power management on PHY >>

Re: [PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-02 Thread Vivek Gautam
Hi Balbi, On Tue, Apr 2, 2013 at 2:02 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 01, 2013 at 07:24:03PM +0530, Vivek Gautam wrote: >> +#else >> +#define dwc3_runtime_suspend NULL >> +#define dwc3_runtime_resume NULL > > this #else b

Re: [PATCH v3 02/11] USB: dwc3: Adjust runtime pm to allow autosuspend

2013-04-02 Thread Vivek Gautam
Hi Felipe, On Tue, Apr 2, 2013 at 1:59 PM, Felipe Balbi wrote: > On Mon, Apr 01, 2013 at 07:24:01PM +0530, Vivek Gautam wrote: >> The current code in the dwc3 probe effectively disables runtime pm >> from ever working because it calls a get() that was never put() until &g

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Vivek Gautam
Hi Kishon, On Wed, Apr 3, 2013 at 10:38 AM, Kishon Vijay Abraham I wrote: > Hi, > > > On Monday 01 April 2013 07:24 PM, Vivek Gautam wrote: >> >> Adding APIs to handle runtime power management on PHY >> devices. PHY consumers may need to wake-up/suspend

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Vivek Gautam
Hi Felipe, On Wed, Apr 3, 2013 at 1:45 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 11:48:39AM +0530, Vivek Gautam wrote: >> >> Adding APIs to handle runtime power management on PHY >> >> devices. PHY consumers may need to wake-up/suspend

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Vivek Gautam
Hi, On Wed, Apr 3, 2013 at 7:26 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 04:54:14PM +0300, Felipe Balbi wrote: >> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x) >> > >> >> +{ >> > >> >> + if (!x || !x->dev) { >> > >> >> + dev_err(x->dev,

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Vivek Gautam
On Wed, Apr 3, 2013 at 7:48 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 07:40:44PM +0530, Vivek Gautam wrote: >> >> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x) >> >> > >> >> +{ >> >>

Re: [PATCH v3 00/11] usb: dwc3/xhci/phy: Enable runtime power management

2013-04-03 Thread Vivek Gautam
es for 3.10, sorry. > > Sarah Sharp > > On Mon, Apr 01, 2013 at 07:23:59PM +0530, Vivek Gautam wrote: >> This patch-series enables runtime power management on xhci-plat, >> dwc3-core, dwc3-exynos as well as on Samsung's USB 2.0 type and >> USB 3.0 type PHYs. &g

Re: [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-04-03 Thread Vivek Gautam
Hi Kukjin, On Fri, Mar 15, 2013 at 1:26 PM, Vivek Gautam wrote: > Based on 'for-next' of linux-samsung tree with following patches > from Doug on top: > usb: Document clocks in samsung, exynos4210-ehci/ohci bindings > ARM: dts: add usb 2.0 clock references to exynos525

Re: [PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-04-03 Thread Vivek Gautam
Hi Kukjin, On Fri, Mar 15, 2013 at 1:32 PM, Vivek Gautam wrote: > This patch-set is in continuation with patch-series: > [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 > out of which follwowing patches have been picked up: > ARM: Exynos5250: Enabling ehci-s5p

Re: [PATCH v3 00/11] usb: dwc3/xhci/phy: Enable runtime power management

2013-04-04 Thread Vivek Gautam
On Thu, Apr 4, 2013 at 12:40 PM, Felipe Balbi wrote: > On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote: >> Hi Sarah, >> >> >> On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp >> wrote: >> > Question: Do you still need this patch for 3.10? &g

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-04 Thread Vivek Gautam
Hi, On Thu, Apr 4, 2013 at 12:48 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 02:14:02PM -0400, Alan Stern wrote: >> > > Lets suppose DWC3 enables runtime_pm on USB 2 type phy, >> > > it will try to go into suspend state and thereby call runtime_suspend(), >> > > if any. >> > > And

[PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Vivek Gautam
xes issues with null pointer dereferencing in s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume(). Signed-off-by: Vivek Gautam CC: Manjunath Goudar CC: Arnd Bergmann CC: Jingoo Han --- drivers/usb/host/ehci-s5p.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/d

Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Vivek Gautam
Hi, On Tue, Apr 9, 2013 at 6:01 PM, Sergei Shtylyov wrote: > Hello. > > > On 09-04-2013 13:21, Vivek Gautam wrote: > >> 7edb3da makes ehci-s5p as a separate driver. But, > > >Please also provide the summary line of that commit in parens. Sure, will add

[PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Vivek Gautam
is fixes issues with null pointer dereferencing in s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume(). Signed-off-by: Vivek Gautam CC: Manjunath Goudar CC: Arnd Bergmann CC: Jingoo Han --- Based on 'usb-next' drivers/usb/host/ehci-s5p.c |2 +- 1 files changed, 1

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-23 Thread Vivek Gautam
Hi, On Thu, Apr 4, 2013 at 8:16 PM, Alan Stern wrote: Apologies for delay in replying. > On Thu, 4 Apr 2013, Felipe Balbi wrote: > >> > >> Some subsystems handle this issue by calling pm_runtime_get_sync() >> > >> before probing a driver and pm_runtime_put_sync() after unbinding the >> > >> dr

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-23 Thread Vivek Gautam
Hi, On Tue, Apr 23, 2013 at 10:23 PM, Alan Stern wrote: > On Tue, 23 Apr 2013, Vivek Gautam wrote: > >> >> Alright, so here's my understanding: >> >> >> >> I suggested letting e.g. DWC3 enable the PHY's runtime_pm; Alan said >> >>

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-24 Thread Vivek Gautam
On Tue, Apr 23, 2013 at 11:42 PM, Alan Stern wrote: > On Tue, 23 Apr 2013, Vivek Gautam wrote: > >> Hi, >> >> >> On Tue, Apr 23, 2013 at 10:23 PM, Alan Stern >> wrote: >> > On Tue, 23 Apr 2013, Vivek Gautam wrote: >> > >> >> >

undefined reference to `usb_gadget_unmap_request' regression

2013-05-08 Thread Vivek Gautam
Hi Felipe, Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove dwc3 dependency on host AND gadget by me breaks compilation when USB_DWC3=y, USB=y but USB_GADGET=m, additionally when either of USB_DWC3_GADGET=y or USB_DWC3_DUAL_ROLE=y :-( I had some confusion with this actually

Re: undefined reference to `usb_gadget_unmap_request' regression

2013-05-10 Thread Vivek Gautam
in certain direction. > > On Thu, May 9, 2013 at 12:34 AM, Vivek Gautam > wrote: >> Hi Felipe, >> >> Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove dwc3 >> dependency on host AND gadget >> by me breaks compilation when USB_DWC

Re: undefined reference to `usb_gadget_unmap_request' regression

2013-05-10 Thread Vivek Gautam
Hi Felipe, On Thu, May 9, 2013 at 8:18 PM, Felipe Balbi wrote: > Hi, > > On Wed, May 08, 2013 at 10:04:56PM +0530, Vivek Gautam wrote: >> Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove >> dwc3 dependency on host AND gadget >> by me breaks compila

Re: [PATCH] usb: phy: samsung: adding usbphy for Exynos4X12

2013-05-13 Thread Vivek Gautam
Hi Dongjin, On Mon, May 13, 2013 at 11:55 PM, Dongjin Kim wrote: > This patch adds usb host phy (USB 2.0 PHY) support for Samsung Exynos4X12 SoC. > New functions, samsung_exynos4x12_usb2phy_enable/_disable and selecting > reference clock, for Exynos4X12 are added. Since it has different register

Re: undefined reference to `usb_gadget_unmap_request' regression

2013-05-14 Thread Vivek Gautam
Hi, On Fri, May 10, 2013 at 8:35 PM, Vivek Gautam wrote: > Hi Felipe, > > > On Thu, May 9, 2013 at 8:18 PM, Felipe Balbi wrote: >> Hi, >> >> On Wed, May 08, 2013 at 10:04:56PM +0530, Vivek Gautam wrote: >>> Commit 388e5c51135f817f01177c42261f1116a6d7f2a

[PATCH] usb: dwc3: Fix compilation break when building with USB_DWC3_DUAL_ROLE=y

2013-05-14 Thread Vivek Gautam
71a5e61 usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module Let us limit the DWC3 mode to depend on corresponding usb-subsystem and USB_DWC3. Signed-off-by: Vivek Gautam Cc: Felipe Balbi Cc: Fengguang Wu --- drivers/usb/dwc3/Kconfig |6 +++--- 1 fi

[PATCH v2 3/4] dt: exynos5420: Enable support for USB 3.0 PHY controller

2013-12-04 Thread Vivek Gautam
Add device tree nodes for USB 3.0 PHY present alongwith USB 3.0 controller Exynos 5420 SoC. This phy driver is based on generic phy framework. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420.dtsi | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff

[PATCH v2 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy

2013-12-04 Thread Vivek Gautam
Update device tree bindings for DWC3 controller and USB 3.0 phy present on Exynos 5250 SoC, to start using the phy driver based on generic phy framework. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions

[PATCH v2 0/4] Add Exynos5 USB 3.0 phy driver based on generic PHY framework

2013-12-04 Thread Vivek Gautam
nd using them for one time PHY-initialization and deinitialization. - Filtering out the PHY 'power-on' and 'power-off' sequence to '.power_on" and ".power_off" callbacks. - Removed drivers/usb/phy/phy-samsung-usb3.c driver and related code. 3) fixes

[PATCH v2 4/4] dt: exynos5420: Enable support for DWC3 controller

2013-12-04 Thread Vivek Gautam
Add device tree nodes for DWC3 controller present on Exynos 5420 SoC, to enable support for USB 3.0. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420.dtsi | 38 +++- 1 files changed, 36 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v2 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-04 Thread Vivek Gautam
framework. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/phy/samsung-phy.txt| 43 ++ drivers/phy/Kconfig|8 + drivers/phy/Makefile |1 + drivers/phy/phy-exynos5-usb3.c | 545

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-05 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 4, 2013 at 7:58 PM, Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Wednesday 20 November 2013 09:14 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 20 November 2013 03:02 PM, Vivek Gautam wrote: >>> On Wed, Nov 20, 201

Re: [PATCH v2 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy

2013-12-05 Thread Vivek Gautam
l on Exynos5250 currently. Ok, will merge it with patch #1 [PATCH v2 1/4] phy: Add new Exynos5 USB 3.0 PHY driver Thanks for pointing out. > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > On Wednesday, Decem

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-09 Thread Vivek Gautam
unsigned int delay, bool > warm); > - > /* Is a USB 3.0 port in the Inactive or Complinance Mode state? > * Port worm reset is required to recover > */ > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc&qu

[PATCH RFC 0/4] Fine tune USB 3.0 PHY on exynos5420

2013-12-10 Thread Vivek Gautam
generic PHY framework http://lwn.net/Articles/575586/ Vivek Gautam (4): phy: Add provision for tuning phy. xhci: Add quirk for DWC3-Exynos controller xhci: Tune PHY for the DWC3-Exynos host controller phy-exynos-usb3: Fine tune LOS levels for exynos5420 drivers/phy/phy-core.c

[PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Vivek Gautam
Some PHY controllers may need to tune PHY post-initialization, so that the PHY consumers can call phy-tuning at appropriate point of time. Signed-off-by: vivek Gautam --- drivers/phy/phy-core.c | 20 include/linux/phy/phy.h |7 +++ 2 files changed, 27 insertions

[PATCH RFC 3/4] xhci: Tune PHY for the DWC3-Exynos host controller

2013-12-10 Thread Vivek Gautam
ndary HCD of XHCI. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/host.c |7 ++ drivers/usb/host/xhci-plat.c | 43 - include/linux/usb/hcd.h |1 + 3 files changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/hos

[PATCH RFC 4/4] phy-exynos-usb3: Fine tune LOS levels for exynos5420

2013-12-10 Thread Vivek Gautam
-off-by: Vivek Gautam --- drivers/phy/phy-exynos5-usb3.c | 107 1 files changed, 107 insertions(+), 0 deletions(-) diff --git a/drivers/phy/phy-exynos5-usb3.c b/drivers/phy/phy-exynos5-usb3.c index 2bafc9d..669f998 100644 --- a/drivers/phy/phy-exynos5-usb3

[PATCH RFC 2/4] xhci: Add quirk for DWC3-Exynos controller

2013-12-10 Thread Vivek Gautam
controller has been reset. Adding a xHCI quirk for this purpose. Signed-off-by: Vivek Gautam --- drivers/usb/host/xhci-plat.c | 19 +++ drivers/usb/host/xhci.h |1 + 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Vivek Gautam
Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus wrote: > Hi, Thanks for reviewing this. > > On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: >> Some PHY controllers may need to tune PHY post-initialization, >> so that the PHY consumers can call phy-

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi, On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus wrote: > Hi, > > On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus >> > I think "setup" instead of "tune" is much more clear and re

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 11, 2013 at 1:47 PM, Kishon Vijay Abraham I wrote: > On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: >> Hi, >> >> >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus >> wrote: >>> Hi, >> >> Thanks for re

Re: [PATCH v2 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-23 Thread Vivek Gautam
Hi All, On Wed, Dec 4, 2013 at 3:39 PM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-

Re: [PATCH v2 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-23 Thread Vivek Gautam
Hi Felipe, On Mon, Dec 23, 2013 at 10:18 PM, Felipe Balbi wrote: > Hi, > > On Mon, Dec 23, 2013 at 02:41:15PM +0530, Vivek Gautam wrote: >> On Wed, Dec 4, 2013 at 3:39 PM, Vivek Gautam >> wrote: >> > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs

Re: [PATCH v5 4/9] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-12-26 Thread Vivek Gautam
>otg) > - exynos_ehci->otg->set_host(exynos_ehci->otg, &hcd->self); > - > - if (exynos_ehci->phy) > - usb_phy_shutdown(exynos_ehci->phy); > + exynos_phys_off(exynos_ehci->phy); > > clk_disable_unpre

Re: [PATCH v2 9/9] dts: Add usb2phy to Exynos 5250

2013-12-26 Thread Vivek Gautam
+ EXYNOS_5250_HOSTPHYCTRL0_PHYSWRSTALL); > + writel(ctrl0, drv->reg_phy + EXYNOS_5250_HOSTPHYCTRL0); > + break; > + case EXYNOS5250_HSIC0: > + case EXYNOS5250_HSIC1: > + hsic = (EXYNOS_52

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-30 Thread Vivek Gautam
Hi Kishon, On Tue, Dec 24, 2013 at 11:15 PM, Kishon Vijay Abraham I wrote: > Hi, > > > On Thursday 05 December 2013 01:44 PM, Vivek Gautam wrote: >> >> Hi Kishon, >> >> >> On Wed, Dec 4, 2013 at 7:58 PM, Kishon Vijay Abraham I >> wrote: >>

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-07 Thread Vivek Gautam
HI Kishon On Tue, Jan 7, 2014 at 3:19 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 30 December 2013 03:13 PM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Tue, Dec 24, 2013 at 11:15 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >>

[PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-20 Thread Vivek Gautam
framework. Signed-off-by: Vivek Gautam --- Changes from v2: 1) Added support for multiple PHYs (UTMI+ and PIPE3) and related changes in the driver structuring. 2) Added a xlate function to get the required phy out of number of PHYs in mutiple PHY scenerio. 3) Changed the names of few structures and

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-20 Thread Vivek Gautam
ons of the IP we'll have separate bits to control usb3 and usb2. > > Ok, i will prepare the next patchset for separating out the possible > code based on > the UTMI+ or PIPE3 phys. Though when experimenting with the PHY > settings i can see > there's little of such code :-) &

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-20 Thread Vivek Gautam
On Mon, Jan 20, 2014 at 7:12 PM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb

Re: [PATCH v4 2/2] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2014-01-21 Thread Vivek Gautam
usb_phy_set_suspend(dwc->usb2_phy, 0); >> usb_phy_set_suspend(dwc->usb3_phy, 0); >> >> + if (dwc->usb2_generic_phy) >> + phy_power_on(dwc->usb2_generic_phy); >> + if (dwc->usb3_generic_phy) >> + phy_power_on(dwc->us

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-29 Thread Vivek Gautam
Hi Kishon, On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I wrote: > Hi, Thanks for review. Please find my answers inline below. > > On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> Th

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-01-29 Thread Vivek Gautam
Hi, On Thu, Jan 30, 2014 at 11:48 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 30 January 2014 09:49 AM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >> >

Re: [PATCHv4 2/6] phy: improved lookup method

2014-10-31 Thread Vivek Gautam
Hi Heikki, On Fri, Oct 17, 2014 at 8:09 PM, Heikki Krogerus wrote: > Removes the need for the phys to be aware of their users > even when not using DT. The method is copied from clkdev.c. > > Signed-off-by: Heikki Krogerus > Tested-by: Vivek Gautam > --- > Document

[PATCH v7 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-10-31 Thread Vivek Gautam
extra lines in the register macro definitions] Signed-off-by: Vivek Gautam --- drivers/phy/phy-exynos5-usbdrd.c | 219 +++--- 1 file changed, 203 insertions(+), 16 deletions(-) diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c index

[PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-10-31 Thread Vivek Gautam
. Signed-off-by: Vivek Gautam --- drivers/usb/host/xhci-plat.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 3d78b0c..5207d5b 100644 --- a/drivers/usb/host/xhci-plat.c +++ b

[PATCH v7 0/2] Fine tune USB 3.0 PHY on exynos5420

2014-10-31 Thread Vivek Gautam
ng this controller operates at High-Speed by default, so it detects even Super-speed devices as high-speed ones. Certain PHY parameters like Tx LOS levels and Boost levels need to be calibrated further post initialization of xHCI controller, to get SuperSpeed operations working." [1] http

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-11 Thread Vivek Gautam
On Tue, Nov 11, 2014 at 12:12 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 31 October 2014 06:03 PM, Vivek Gautam wrote: >> Hi Heikki, >> >> >> On Fri, Oct 17, 2014 at 8:09 PM, Heikki Krogerus >> wrote: >>> Removes the need for the phys to

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-11 Thread Vivek Gautam
Hi Kishon, On Tue, Nov 11, 2014 at 2:20 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 11 November 2014 02:07 PM, Vivek Gautam wrote: >> On Tue, Nov 11, 2014 at 12:12 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >>> >>> On Friday 31 Oc

[PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure

2014-11-12 Thread Vivek Gautam
Using the same driver name for platform driver and a globally defined, structure used throughout the file, looks a bit unpleasing. So changing the driver name from "samsung_usb2_phy_driver" to "samsung_usb2_phy" Signed-off-by: Vivek Gautam Cc: Kamil Debski Cc: Ki

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-13 Thread Vivek Gautam
Hi Heikki, Kishon, On Tue, Nov 11, 2014 at 2:23 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Tue, Nov 11, 2014 at 2:20 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 11 November 2014 02:07 PM, Vivek Gautam wrote: >>> On Tue, Nov 11, 2

Re: [PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-11-16 Thread Vivek Gautam
Hi, On Fri, Oct 31, 2014 at 7:21 PM, Sergei Shtylyov wrote: > Hello. > > On 10/31/2014 4:26 PM, Vivek Gautam wrote: > >> The host controller by itself may sometimes need to handle PHY >> and re-initialize it to re-configure some of the PHY parameters >> to g

Re: [PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-11-16 Thread Vivek Gautam
Hi Felipe, On Fri, Oct 31, 2014 at 6:56 PM, Vivek Gautam wrote: > The host controller by itself may sometimes need to handle PHY > and re-initialize it to re-configure some of the PHY parameters > to get full support out of the PHY controller. > Therefore, facilitate getting the

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-17 Thread Vivek Gautam
On Fri, Nov 14, 2014 at 7:45 PM, Heikki Krogerus wrote: > Hi Vivek, > > On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: >> Hi Heikki, Kishon, >> >> How about adding the change in attached patch [1] on top of this patch. >> Just introduced the phy

Re: [PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-11-18 Thread Vivek Gautam
On Mon, Nov 17, 2014 at 9:46 PM, Sergei Shtylyov wrote: > Hello. > > On 11/17/2014 9:36 AM, Vivek Gautam wrote: > >>>> The host controller by itself may sometimes need to handle PHY >>>> and re-initialize it to re-configure some of the PHY parameters >

Re: [PATCHv5 0/7] phy: simplified phy lookup

2014-11-20 Thread Vivek Gautam
/10/31/266 If you want here's my tested-by, again for entire series. Tested-by: Vivek Gautam > > Changes since v4: > - Support for static lookups is dropped. The lookups can be now only > be created with phy_create_lookup() > > Changes since v3: > - We can't

[PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-11-21 Thread Vivek Gautam
is series only so as to avoid having 'n' number of dependencies. The USB driver patches in this series were part of [1] sent earlier. [1] [PATCH v2 0/4] usb: dwc3/phy-exynos5-usbdrd: Extend support to Exynos7 https://lkml.org/lkml/2014/10/7/191 Vivek Gautam (11): pinctrl: exynos: Add

[PATCH 01/11] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-11-21 Thread Vivek Gautam
USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch Signed-off-by: Vivek Gautam Cc: Linus Walleij --- drivers/pinctrl/samsung/pinctrl-exynos.c | 12 1 file changed, 12

[PATCH 02/11] dwc3: exynos: Remove local variable for clock from probe

2014-11-21 Thread Vivek Gautam
There's no need to keep one local variable for clock, and then assign the same to 'clk' member of dwc3_exynos. Just cleaning it up. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/dwc3-exynos.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/d

[PATCH 03/11] dwc3: exynos: Add provision for suspend clock

2014-11-21 Thread Vivek Gautam
DWC3 controller on Exynos SoC series have separate control for suspend clock which replaces pipe3_rx_pclk as clock source to a small part of DWC3 core that operates when SS PHY is in its lowest power state (P3) in states SS.disabled and U3. Suggested-by: Anton Tikhomirov Signed-off-by: Vivek

[PATCH 04/11] dwc3: exynos: Add provision for AXI UpScaler clock on exynos7

2014-11-21 Thread Vivek Gautam
DWC3 controller on Exynos7 SoC has separate control for AXI UpScaler which connects DWC3 DRD controller to AXI bus. Get the gate clock for the same to control it across power cycles. Suggested-by: Anton Tikhomirov Signed-off-by: Vivek Gautam --- Documentation/devicetree/bindings/usb/exynos

[PATCH 05/11] phy: exynos5-usbdrd: Add pipe-clk, utmi-clk and itp-clk support

2014-11-21 Thread Vivek Gautam
: Anton Tikhomirov Signed-off-by: Vivek Gautam --- .../devicetree/bindings/phy/samsung-phy.txt|6 ++ drivers/phy/phy-exynos5-usbdrd.c | 104 2 files changed, 92 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/phy

[PATCH 06/11] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply

2014-11-21 Thread Vivek Gautam
Some Exynos boards have a separate regulator controlling a Boost 5V supply which goes as input for VBUS regulator. So adding a control for the same in driver, to enable vbus supply on the port. Signed-off-by: Vivek Gautam --- drivers/phy/phy-exynos5-usbdrd.c | 32

[PATCH 07/11] phy: exynos7-usbdrd: Update dependency for ARCH_EXYNOS

2014-11-21 Thread Vivek Gautam
This PHY controller is also present on Exynos7 platform in arch-exynos family. So PHY_EXYNOS5_USBDRD should now depend on ARCH_EXYNOS. Signed-off-by: Vivek Gautam --- drivers/phy/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/Kconfig b/drivers/phy

[PATCH 08/11] clk: exynos7: Add required clock tree for USB

2014-11-21 Thread Vivek Gautam
Adding required gate clocks for USB3.0 DRD controller present on Exynos7. Signed-off-by: Vivek Gautam --- drivers/clk/samsung/clk-exynos7.c | 64 +++ include/dt-bindings/clock/exynos7-clk.h |9 - 2 files changed, 72 insertions(+), 1 deletion(-) diff

[PATCH 09/11] arm64: exynos: Add bus1 pinctrl node on exynos7

2014-11-21 Thread Vivek Gautam
BUS1 pinctrl provides gpios for usb and power regulator available on exynos7-espresso board. So add relevant device node for pinctrl-bus1. Signed-off-by: Naveen Krishna Ch Signed-off-by: Vivek Gautam --- arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 26 +++ arch/arm64

<    1   2   3   4   5   6   7   8   9   >