[PATCH V7 1/4] dt-bindings: phy: Add support for QUSB2 phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Acked-by: Rob Herring --- Changes since v6: - Dropped 'vdd-phy-supply' that used pm8994_s2 regulator, fro

[PATCH V7 2/4] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips

2017-04-05 Thread Vivek Gautam
PHY transceiver driver for QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller present on Qualcomm chipsets. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd --- Changes since v6: - Dropped 'vdd-phy' from list of regulators. - Rebased on phy/nex

[PATCH V7 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets

2017-04-05 Thread Vivek Gautam
Qualcomm SOCs have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Add a new driver, based on generic phy framework, for this phy controller. Signed-off-by: Vivek Gautam Tested-by: Srinivas Kandagatla --- Changes since v6: - Rebased on phy/next and

[PATCH V7 3/4] dt-bindings: phy: Add support for QMP phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Acked-by: Rob Herring --- Changes since v6: - none. Changes since v5: - Added Rob's 'Ack&#x

Re: [PATCH V7 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Vivek Gautam
Hi Kishon, On Wed, Apr 5, 2017 at 7:08 PM, Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Wednesday 05 April 2017 06:02 PM, Vivek Gautam wrote: >> This patch series adds couple of PHY drivers for Qualcomm chipsets. >> a) qcom-qusb2 phy driver: that provides High Speed US

[PATCH V8 3/4] dt-bindings: phy: Add support for QMP phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Changes since v7: - None, just added Stephen&#

[PATCH V8 2/4] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips

2017-04-05 Thread Vivek Gautam
PHY transceiver driver for QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller present on Qualcomm chipsets. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd --- Changes since v7: - Fixed 'checkpatch --strict' alignment warnings/checks. Change

[PATCH V8 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets

2017-04-05 Thread Vivek Gautam
Qualcomm SOCs have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Add a new driver, based on generic phy framework, for this phy controller. Signed-off-by: Vivek Gautam Tested-by: Srinivas Kandagatla Reviewed-by: Stephen Boyd --- Changes since v7

[PATCH V8 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Vivek Gautam
for detailed changelogs. [1] https://patchwork.kernel.org/patch/9567767/ [2] https://patchwork.kernel.org/patch/9567779/ [3] https://github.com/vivekgautam1/linux/tree/linux-v4.11-rc5-qmp-phy-db820c [4] https://lkml.org/lkml/2017/3/20/407 Vivek Gautam (4): dt-bindings: phy: Add support for QUSB2 ph

[PATCH V8 1/4] dt-bindings: phy: Add support for QUSB2 phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Changes since v7: - None, just added Stephen's Reviewed-b

[PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-28 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- Changes from v3: - U

[PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- Changes from v3: - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since dwc3 controller also looks for USB2 type PHY. driver

[PATCH 0/4] usb: dwc3/xhci: Enable runtime power management

2013-01-28 Thread Vivek Gautam
2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller Vivek Gautam (4): usb: xhci: Enable runtime pm in xhci-plat USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend usb: dwc3: exynos: Enable runtime power management usb: phy: samsung: Enable runtime power management o

[PATCH 1/4] usb: xhci: Enable runtime pm in xhci-plat

2013-01-28 Thread Vivek Gautam
By enabling runtime pm in this driver is allows users of xhci-plat to enter into runtime pm. This is not full runtime pm support (AKA xhci-plat doesn't actually power anything off when in runtime suspend mode) but just basic enablement. Signed-off-by: Vivek Gautam Signed-off-by: Doug And

[PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Vivek Gautam
n the DWC3 device in that the port isn't put into a lower power mode when not used. However it does allow users of dwc3 (like dwc3-exynos) to do some amount of runtime power management. Signed-off-by: Vivek Gautam Signed-off-by: Doug Anderson --- drivers/usb/dwc3/core.c |4 +++- 1 fil

[PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
Enabling runtime power management on dwc3-exynos to save power and allow its PHY's power to be managed at runtime. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/dwc3-exynos.c | 47 1 files changed, 47 insertions(+), 0 deletions(-) diff --

[PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Enabling runtime power management support on samsung-usb3 phy and further adding support to turn off the PHY ref_clk PLL. It thereby requires PHY ref_clk to be switched between internal core clock and external PLL clock. Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usb3.c | 107

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
Hi Balbi, On Mon, Jan 28, 2013 at 5:17 PM, Felipe Balbi wrote: > On Mon, Jan 28, 2013 at 05:12:27PM +0530, Vivek Gautam wrote: >> Enabling runtime power management on dwc3-exynos to save >> power and allow its PHY's power to be managed at runtime. >> >

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
On Mon, Jan 28, 2013 at 5:42 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote: >> >> +static int dwc3_exynos_runtime_resume(struct device *dev) >> >> +{ >> >> + struct dwc3_exynos *exyn

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 5:39 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 28, 2013 at 05:12:28PM +0530, Vivek Gautam wrote: >> Enabling runtime power management support on samsung-usb3 phy >> and further adding support to turn off the PHY ref_clk PLL. >&

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 6:37 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote: >> >> @@ -65,7 +67,22 @@ static u32 samsung_usb3_phy_set_refclk(struct >> >> samsung_usbphy *sphy) >> >>

Re: [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balbi wrote: > On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote: >> The current code in the dwc3 probe effectively disables runtime pm >> from ever working because it calls a get() that was never put() until &g

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
CC: Doug Anderson On Mon, Jan 28, 2013 at 3:56 PM, Vivek Gautam wrote: > Adding PHY driver support for USB 3.0 controller for Samsung's > SoCs. > > Signed-off-by: Vivek Gautam > --- > > Changes from v3: > - Making SAMSUNG_USB3PHY dependent on SAMSUNG_US

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-28 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Don't you need also some clkdev lookup entry to make the clock available >> in the driver? >&g

[PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Vivek Gautam
This change de-asserts vbus_gpio on suspend and re-asserts on resume in order to save power. NOTE, this change means no USB charging in suspend mode. Signed-off-by: Vivek Gautam CC: Doug Anderson --- Based on 'usb-next'. drivers/usb/host/ehci-s5p.c | 29 ++

Re: [PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Vivek Gautam
Hi Oliver, On Tue, Jan 29, 2013 at 5:07 PM, Oliver Neukum wrote: > On Tuesday 29 January 2013 16:22:45 Vivek Gautam wrote: >> This change de-asserts vbus_gpio on suspend and >> re-asserts on resume in order to save power. >> NOTE, this change means no USB charging in susp

Re: [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-29 Thread Vivek Gautam
On Tue, Jan 22, 2013 at 9:01 PM, Vivek Gautam wrote: > Changes from v1: > - Putting separate device nodes for usb 2.0 phy and usb 3.0 phy >based on separate driver for samsung usb 3.0 phy and >samsung usb 2.0 phy: >[PATCH v3 0/2] Adding USB 3.0 DRD-phy support

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-30 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 10:36 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding usbphy node for Exynos5250 along with the >> necessary device data to be parsed. >> >> Signed-off-by: Vivek Gautam >> --- >> arch/arm/boot/dts/exyno

[PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
sion for getting PHY from platform specific device tree node. Signed-off-by: Vivek Gautam --- Based on 'usb-next'. drivers/usb/dwc3/core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 094..75

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Kishon, On Thu, Jan 31, 2013 at 5:04 PM, kishon wrote: > Hi, > Thanks for your quick help. > > On Thursday 31 January 2013 04:50 PM, Vivek Gautam wrote: >> >> With device tree support in place for dwc3-core layer, >> it gets PHY from "synopsis-dwc3"

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Felipe, On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote: > Hi, > > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote: >> >> Moreover, SoCs having multiple dwc3 controllers will have multiple >> >> PHYs, which eventually be added using usb_a

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Kishon, On Fri, Feb 1, 2013 at 10:51 AM, kishon wrote: > Hi, > > > On Thursday 31 January 2013 09:08 PM, Felipe Balbi wrote: >> >> On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: >>> >>> Hi Felipe, >>> >>> >>&g

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Balbi, On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam wrote: > Hi Kishon, > > > On Fri, Feb 1, 2013 at 10:51 AM, kishon wrote: >> Hi, >> >> >> On Thursday 31 January 2013 09:08 PM, Felipe Balbi wrote: >>> >>> On Thu, Jan 31, 2013 at 09:

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-01 Thread Vivek Gautam
On Fri, Feb 1, 2013 at 2:20 PM, Felipe Balbi wrote: > On Fri, Feb 01, 2013 at 11:54:01AM +0530, Vivek Gautam wrote: >> Hi Balbi, >> >> >> On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam >> wrote: >> > Hi Kishon, >> > >> > &

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Fri, Feb 1, 2013 at 3:56 AM, Kukjin Kim wrote: > Tomasz Figa wrote: >> >> Hi Vivek, > > [...] > >> > + usb@1212 { >> > + compatible = "samsung,exynos4210-ohci"; >> > + reg = <0x1212 0x100>; >> > + interrupts = <0 71 0>; >> >> For Samsung plat

Re: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:26 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Moving register and structure definitions to header file, >> and keeping the generic functions to be used across >> multiple PHYs in common file "samsung-usbphy.c". &g

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:31 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding PHY driver support for USB 3.0 controller for Samsung's >> SoCs. >> >> Signed-off-by: Vivek Gautam >> --- >> >> Changes from v3:

[PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-05 Thread Vivek Gautam
quot;samsung-usb2phy.c" and, "samsung-usb3.c" to "samsung-usb3phy.c" - Removing dependencies for SAMSUNG_USB2PHY and SAMSUNG_USB3PHY. - Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select SAMSUNG_USBPHY, which is the usb-phy helper driver. Vivek Gautam (2): us

[PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-05 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common phy helper driver under SAMSUNG_USBPHY, and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig

[PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-05 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3phy.c | 349 + drivers/usb/phy/sa

[PATCH v3 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-02-05 Thread Vivek Gautam
TCH v8 0/4] Adding usb2.0 host-phy support for exynos5250 - Aligning as per the patch: usb: phy: samsung: Add support to set pmu isolation - Replaced phy-handle approach for PHY CONTROL registers to child nodes. - Removing AUX data entry from exynos5250 dt file. Vivek Gautam (2): ARM:

[PATCH v3 1/2] ARM: Exynos5250: Enabling samsung-usb2phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 2.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v3 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 3.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH RFC] usb: dwc3: Set GCTL.PrtCapDir based on selected mode.

2013-02-05 Thread Vivek Gautam
Now that machines may select the mode of working of DWC3, we can set the Port capability direction based on selected mode. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers

Re: MUSB regression in linux next at least for pandboard

2013-02-06 Thread Vivek Gautam
Hi Tony, On Fri, Oct 5, 2012 at 9:57 PM, Tony Lindgren wrote: > * Tony Lindgren [121004 18:41]: >> > >> > > Also on the EHCI port, I've seen issues where unplugging >> > > the cable hangs kernel with an infinite loop. But that happens >> > > only occasionally, sorry does not seem to happen righ

Re: [PATCH v3 05/11] usb: dwc3: core: add power management support

2013-02-12 Thread Vivek Gautam
Hi Felipe, Sorry for coming so late on this series :-(, was away actually. Just trying with patches in 'dwc3-dev-pm-ops' branch of your tree. On Mon, Feb 11, 2013 at 3:22 PM, Felipe Balbi wrote: > Add support for basic power management on > the dwc3 driver. While there is still lots > to improv

Re: [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-13 Thread Vivek Gautam
On Wed, Feb 13, 2013 at 2:02 PM, Felipe Balbi wrote: > On Tue, Feb 12, 2013 at 10:31:00PM -0800, kg...@kernel.org wrote: >> Vivek Gautam wrote: >> > >> > Based on 'usb-next' >> > >> > Changes from v4: >> > - Modifying function nam

Re: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-02-14 Thread Vivek Gautam
On Sat, Feb 9, 2013 at 4:05 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam >> Acked-by: Jingoo Han >> Acke

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Vivek Gautam
Hi Felipe, On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: > Add support for basic power management on > the dwc3 driver. While there is still lots > to improve for full PM support, this minimal > patch will already make sure that we survive > suspend-to-ram and suspend-to-disk without > ma

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Vivek Gautam
On Fri, Feb 15, 2013 at 6:45 PM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 15, 2013 at 04:40:43PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: >> > Add support for basic power management on >&

Re: [PATCH v4 00/11] usb: dwc3: PM support patchset

2013-02-16 Thread Vivek Gautam
8,10 @@ static int dwc3_resume(struct device *dev) dwc3_writel(dwc->regs, DWC3_GCTL, dwc->gctl); + usb_phy_init(dwc->usb2_phy); + usb_phy_init(dwc->usb3_phy); + mdelay(100); + switch (dwc->mode) { case DWC3_MODE_DEVICE: case DWC3_MODE_DRD:

Re: [PATCH RFC] usb: dwc3: Set GCTL.PrtCapDir based on selected mode.

2013-02-25 Thread Vivek Gautam
Hi Balbi, On Mon, Feb 25, 2013 at 1:47 PM, Felipe Balbi wrote: > Hi, > > On Tue, Feb 05, 2013 at 07:15:58PM +0530, Vivek Gautam wrote: >> Now that machines may select the mode of working of DWC3, >> we can set the Port capability direction based on selected mode. >&

Re: [PATCH RFC] usb: dwc3: Set GCTL.PrtCapDir based on selected mode.

2013-02-25 Thread Vivek Gautam
On Mon, Feb 25, 2013 at 2:49 PM, Felipe Balbi wrote: > Hi, > > On Mon, Feb 25, 2013 at 02:21:46PM +0530, Vivek Gautam wrote: >> >> @@ -514,6 +511,14 @@ static int dwc3_probe(struct platform_device *pdev) >> >> } >> >> dwc->mode = mode;

Re: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2013-02-27 Thread Vivek Gautam
Hi Balbi, On Wed, Feb 27, 2013 at 1:45 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote: >> Changes from v8: >> Resending this patch series after rebasing to the latest usb-next branch. >> Rewording inline comments for better readability. >> Remove

Re: [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-02-27 Thread Vivek Gautam
Hi Felipe, On Wed, Feb 27, 2013 at 1:36 PM, Felipe Balbi wrote: > Hi, > > sorry for the delay > That's alright ;-) > On Mon, Jan 28, 2013 at 07:06:56PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balb

Re: [PATCH] usb: phy: samsung: let it be built as a module

2013-02-27 Thread Vivek Gautam
Hi Felipe, On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote: > There's no reason not to allow samsung PHY > drivers be built as modules. This patch changes > Kconfig to allow that. > > Signed-off-by: Felipe Balbi > --- > > Hi, > > I will take your patches but I'm planning to add this on top

Re: [PATCH] usb: phy: samsung: let it be built as a module

2013-02-27 Thread Vivek Gautam
On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi wrote: > Hi, > > On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote: >> > There's no reason not to allow samsung P

Build break on usb-next with exynos_defconfig

2013-02-27 Thread Vivek Gautam
Hi, Trying to compile 'usb-next' branch with exynos_defconfig, but hit upon compilation error. arch/arm/plat-samsung/dma-ops.c: In function 'samsung_dmadev_request': arch/arm/plat-samsung/dma-ops.c:39: error: implicit declaration of function 'dma_request_slave_channel' make[1]: *** [arch/arm/pla

[PATCH v6 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-27 Thread Vivek Gautam
Based on 'usb-next' Changes from v5: - Squashed the following change from Felipe in this patch-set: [PATCH] usb: phy: samsung: let it be built as a module - Using EXPORT_SYMBOL_GPL() to export symbols in "samsung-usbphy.c" to allow module builds of these samsung PHY dr

[PATCH v6 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-27 Thread Vivek Gautam
: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- drivers/usb/phy/Kconfig | 17 +- drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb2phy.c | 511 ++ drivers/usb/phy/samsung-usbphy.c | 722

[PATCH v6 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-27 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3phy.c |

Re: Build break on usb-next with exynos_defconfig

2013-02-27 Thread Vivek Gautam
Hi, On Wed, Feb 27, 2013 at 8:36 PM, Greg KH wrote: > On Wed, Feb 27, 2013 at 07:45:56PM +0530, Vivek Gautam wrote: >> Hi, >> >> >> Trying to compile 'usb-next' branch with exynos_defconfig, but hit >> upon compilation error. >>

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-28 Thread Vivek Gautam
Hi, On Thu, Jan 31, 2013 at 9:08 PM, Felipe Balbi wrote: > On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Jan 31, 2013 at 0

[PATCH v2 01/10] usb: phy: Add APIs for runtime power management

2013-03-02 Thread Vivek Gautam
Adding APIs to handle runtime power management on PHY devices. PHY consumers may need to wake-up/suspend PHYs when they work across autosuspend. Signed-off-by: Vivek Gautam --- include/linux/usb/phy.h | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff

[PATCH v2 06/10] usb: xhci: Enable runtime pm in xhci-plat

2013-03-02 Thread Vivek Gautam
By enabling runtime pm in this driver allows users of xhci-plat to enter into runtime pm. This is not full runtime pm support (AKA xhci-plat doesn't actually power anything off when in runtime suspend mode) but, just basic enablement. Signed-off-by: Vivek Gautam CC: Doug Anderson --- dr

[PATCH v2 09/10] usb: phy: samsung: Add support for PHY ref_clk gpio

2013-03-02 Thread Vivek Gautam
Exynos5250 has external PLL (XusbXTI) for USB 3.0 PHY's ref_pad_clk. So use this clock based on availability of gpio to power control this PLL, otherwise use internal clock only from XXTI. Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usb3phy.c | 14 ++ drivers/us

[PATCH v2 03/10] usb: dwc3: Enable runtime pm only after PHYs are initialized

2013-03-02 Thread Vivek Gautam
Allow dwc3 to enable auto power management only after its PHYs are initialized so that any further PHY handling by dwc3's runtime power management callbacks is fine. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c |8 1 files changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 05/10] usb: dwc3: exynos: Enable runtime power management

2013-03-02 Thread Vivek Gautam
Enabling runtime power management on dwc3-exynos letting dwc3 controller to be autosuspended on exynos platform when not in use. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/dwc3-exynos.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3

[PATCH v2 07/10] usb: phy: samsung: Enable runtime power management on usb3phy

2013-03-02 Thread Vivek Gautam
Enable autosuspending of Samsung usb3.0 PHY Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usb3phy.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/samsung-usb3phy.c b/drivers/usb/phy/samsung-usb3phy.c index 70e2c7b..7594cc7 100644 --- a

[PATCH v2 08/10] usb: phy: samsung: Add support for external reference clock

2013-03-02 Thread Vivek Gautam
The PHY controller can choose between ref_pad_clk (XusbXTI-external PLL), or EXTREFCLK (XXTI-internal clock crystal) to generate the required clock. Adding the provision for ref_pad_clk here. Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usb3phy.c | 46

[PATCH v2 04/10] usb: dwc3: Add runtime power management callbacks

2013-03-02 Thread Vivek Gautam
Right now it doesn't handle full runtime suspend/resume functionality. However it allows to handle PHYs' sleep and wakeup across runtime suspend/resume. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c | 27 +++ 1 files changed, 27 insertions(+), 0

[PATCH v2 00/10] usb: dwc3/xhci/phy: Enable runtime power management

2013-03-02 Thread Vivek Gautam
runtime power management of usb PHYs in dwc3 core driver instead of in any glue layer. - Splitting the patch "[PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb" to required number to bifurcate functionality. Vivek Gautam (10): usb: phy: Add APIs for r

[PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

2013-03-02 Thread Vivek Gautam
-off-by: Vivek Gautam --- Changes from RFC patch "usb: dwc3: Set GCTL.PrtCapDir based on selected mode" - Setting the mode in dwc3 context structure based on selected mode in machine, rather than programming PrtCapDir drivers/usb/dwc3/core.c |7 ++- 1 files changed, 6

[PATCH v2 02/10] USB: dwc3: Adjust runtime pm to allow autosuspend

2013-03-02 Thread Vivek Gautam
The current code in the dwc3 probe effectively disables runtime pm from ever working because it calls a get() that was never put() until device removal. Change the runtime pm code to match the standard formula and allow runtime pm to function. Signed-off-by: Vivek Gautam CC: Doug Anderson

Re: [PATCH v2 06/10] usb: xhci: Enable runtime pm in xhci-plat

2013-03-04 Thread Vivek Gautam
Hi, On Sat, Mar 2, 2013 at 9:23 PM, Alan Stern wrote: > On Sat, 2 Mar 2013, Vivek Gautam wrote: > >> By enabling runtime pm in this driver allows users of >> xhci-plat to enter into runtime pm. This is not full >> runtime pm support (AKA xhci-plat doesn't actually

Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

2013-03-13 Thread Vivek Gautam
Hi Balbi, On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam wrote: > Now that machines may select the mode of working of DWC3 (HOST only, > GADGET only or DUAL_ROLE), lets set DWC3 mode based on that > rather than fixing it to whatever DWC3 hardware says. > This way we can skip initial

Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

2013-03-13 Thread Vivek Gautam
On Wed, Mar 13, 2013 at 2:44 PM, Felipe Balbi wrote: > On Wed, Mar 13, 2013 at 02:42:22PM +0530, Vivek Gautam wrote: >> Hi Balbi, >> >> >> On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam >> wrote: >> > Now that machines may select the mode of worki

Re: [PATCH v6 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-03-13 Thread Vivek Gautam
Hi Felipe, On Wed, Feb 27, 2013 at 8:13 PM, Vivek Gautam wrote: > Based on 'usb-next' > > Changes from v5: > - Squashed the following change from Felipe in this patch-set: >[PATCH] usb: phy: samsung: let it be built as a module > - Using EXPORT_SYMBOL_GPL() t

[PATCH v7 1/2] usb: phy: samsung: Common out the generic stuff

2013-03-14 Thread Vivek Gautam
: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- .../devicetree/bindings/usb/samsung-usbphy.txt | 22 +- drivers/usb/phy/Kconfig| 15 +- drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy-samsung-usb.c

[PATCH v7 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-03-14 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- .../devicetree/bindings/usb/samsung-usbphy.txt | 54 +++ drivers/usb/phy/Kconfig|7 + drivers/us

[PATCH v7 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-03-14 Thread Vivek Gautam
d on 'usb-next' plus Felipe's 'testing' branch patches; (some 194 patches in fact ;-), on top of 3.9rc2 tag). Tested after merging linux-samsung's 'for-next' into 'usb-next' to verify things with recently merged common clock framework for samsung&

[PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

2013-03-14 Thread Vivek Gautam
Used of_platform_populate() to create dwc3 core platform_device from device tree data. Additionally some cleanup is also done. Signed-off-by: Vivek Gautam CC: Felipe Balbi CC: Kukjin Kim --- drivers/usb/dwc3/dwc3-exynos.c | 46 +--- 1 files changed, 15

[PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare

2013-03-14 Thread Vivek Gautam
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Vivek Gautam CC: Felipe Balbi CC: Kukjin Kim --- drivers/usb/dwc3/dwc3-exynos.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 0/2] dwc3: exynos: Device tree fixes

2013-03-14 Thread Vivek Gautam
patches in fact ;-), on top of 3.9rc2 tag). Also based on: "usb: dwc3: set dma_mask for dwc3_omap device" by Kishon in which DMA mask for dwc3-core is being set from its parent. Vivek Gautam (2): usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev usb: dwc3: exynos: use clk_

Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

2013-03-14 Thread Vivek Gautam
On Thu, Mar 14, 2013 at 4:21 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote: >> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device >> *pdev) >> { >> struct dwc3_exynos *e

[PATCH v2 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

2013-03-14 Thread Vivek Gautam
Used of_platform_populate() to create dwc3 core platform_device from device tree data. Additionally some cleanup is also done. Signed-off-by: Vivek Gautam CC: Felipe Balbi CC: Kukjin Kim --- Changes from v1: - Added method to unregister dwc3 core from dwc3_exynos_remove() using

Re: [PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare

2013-03-14 Thread Vivek Gautam
Hi, On Thu, Mar 14, 2013 at 4:23 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 14, 2013 at 04:14:58PM +0530, Vivek Gautam wrote: >> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare >> calls as required by common clock framework. >> >> S

[PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-03-15 Thread Vivek Gautam
TCH v7 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Changes from v3: Added 'clocks' and 'clock-names' entry also in device nodes, aligning with common clock framework for Samsung's SoCs. Vivek Gautam (2): ARM: Exynos5250: Enabling samsung-usb2phy driver ARM: E

[PATCH v4 1/2] ARM: Exynos5250: Enabling samsung-usb2phy driver

2013-03-15 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH v4 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-03-15 Thread Vivek Gautam
Adding usb3.0 phy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot

[PATCH v5 3/3] ARM: exynos5: Enable XHCI support on exynos5

2013-03-15 Thread Vivek Gautam
This patch enables support for XHCI on exynos5 series of SOCs, to support host side USB 3.0 support. Signed-off-by: Vivek Gautam --- arch/arm/mach-exynos/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig

[PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-03-15 Thread Vivek Gautam
anges. ;-) - Adding proper binding documentation as per latest bindings changes in dwc3 driver (dwc3/core.c as well as for dwc3-exynos.c change reflected by above patch-set. - Bifurcating the patch to separate our Documentation, arch and dts changes. Vivek Gautam (3): usb: Add device

[PATCH v5 2/3] ARM: exynos5250: dts: Enabling dwc3-exynos driver

2013-03-15 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 needed to parse device tree data. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH v5 1/3] usb: Add device tree bindings for dwc3-exynos

2013-03-15 Thread Vivek Gautam
Document device tree binding information as required by the Samsung' USB 3.0 controller. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/exynos-usb.txt | 34 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/Documentation/devic

Re: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-18 Thread Vivek Gautam
_OUT_INIT_HIGH, >> + "ehci_vbus_gpio"); >> if (err) >> - dev_err(&pdev->dev, "can't request ehci vbus gpio %d", gpio); >> + dev_err(dev, "can't request ehci vbus gpio

[PATCH] usb: phy: samsung-usb2: Fix sparse warning

2013-03-19 Thread Vivek Gautam
.c:73:35:got void [noderef] *regs Signed-off-by: Vivek Gautam CC: Fengguang Wu CC: Christopher Li CC: Felipe Balbi --- Based on 'next' branch of Felipe's usb tree. Tested using make C=2 drivers/usb/phy/phy-samsung-usb2.o Hi Felipe, Sorry to bug you for this small change, i t

Re: Mismatch in TRB_LEN bit mask for Transfer Event TRBs

2013-03-19 Thread Vivek Gautam
Hi, On Wed, Mar 20, 2013 at 12:51 AM, Sarah Sharp wrote: > On Thu, Mar 07, 2013 at 03:38:46PM +0530, Vivek Gautam wrote: >> Hi Sarah, >> >> >> While going through the code for Handling Transfer Events >> (drivers/usb/host/xhci-ring.c), i hit upon this problem. &

[PATCH] usb: xhci: Fix TRB transfer length macro used for Event TRB.

2013-03-20 Thread Vivek Gautam
Use proper macro while extracting TRB transfer length from Transfer event TRBs. Adding a macro EVENT_TRB_LEN (bits 0:23) for the same, and use it instead of TRB_LEN (bits 0:16) in case of event TRBs. Signed-off-by: Vivek gautam --- drivers/usb/host/xhci-ring.c | 45

Re: Mismatch in TRB_LEN bit mask for Transfer Event TRBs

2013-03-20 Thread Vivek Gautam
Hi Sarah, On Wed, Mar 20, 2013 at 10:17 AM, Vivek Gautam wrote: > Hi, > > > On Wed, Mar 20, 2013 at 12:51 AM, Sarah Sharp > wrote: >> On Thu, Mar 07, 2013 at 03:38:46PM +0530, Vivek Gautam wrote: >>> Hi Sarah, >>> >>> >>> While going t

Re: [PATCH] usb: xhci: Fix TRB transfer length macro used for Event TRB.

2013-03-20 Thread Vivek Gautam
Hi, On Wed, Mar 20, 2013 at 11:19 PM, Sarah Sharp wrote: > On Wed, Mar 20, 2013 at 03:48:40PM +0530, Vivek Gautam wrote: >> Use proper macro while extracting TRB transfer length from >> Transfer event TRBs. Adding a macro EVENT_TRB_LEN (bits 0:23) >> for the same, and use

<    1   2   3   4   5   6   7   8   9   >