:6211)
2-1 -> usbip://192.168.122.152:3240/1-1 (remote devid 00010002 (bus/dev
001/002))
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/vhci_driver.c | 59 ++
.../staging/usbip/userspace/libsrc/vhci_driver.h | 2 +
drivers/staging/usbip/u
:6211)
2-1 -> usbip://192.168.122.152:3240/1-1
-> remote bus/dev 001/002
Signed-off-by: Valentina Manea
---
Changes since v1:
* remove devid from the printed info
* arrange formatting a bit
* don't bail out when port file doesn't exist, jus
:6211)
2-1 -> usbip://192.168.122.152:3240/1-1
-> remote bus/dev 001/002
Signed-off-by: Valentina Manea
---
Changes since v2:
* fix trailing whitespace error
* change commit title to reflect that this is a userspace patch
.../staging/usbip/userspace/libsrc/vh
:6211)
2-1 -> usbip://192.168.122.152:3240/1-1
-> remote bus/dev 001/002
Signed-off-by: Valentina Manea
Reviewed-by: Ilija Hadzic
---
Resubmitting this patch as I still didn't get any reply from Greg
after 2 weeks.
.../staging/usbip/userspace/libsrc/vhci
: Valentina Manea
---
drivers/staging/usbip/stub.h | 2 +-
drivers/staging/usbip/stub_dev.c | 150 -
drivers/staging/usbip/stub_main.c | 6 +-
drivers/staging/usbip/stub_rx.c| 2 +-
.../usbip/userspace
On Thu, Jan 23, 2014 at 9:09 PM, Greg KH wrote:
> On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote:
>> This driver was previously an interface driver. Since USB/IP
>> exports a whole device, not just an interface, it would make
>> sense to be a device driver.
,
there is no need to bind/unbind each interface, just the device as a
whole.
Signed-off-by: Valentina Manea
---
Changes since v1:
* add extra information to the commit message
* remove a comment that was no longer available
* export USB functions as GPL
drivers/staging
> If you don't bind the interfaces, they will naturally bind to their
> normal drivers on the host. You probably don't want that to happen.
> (Although, at the moment, I don't see how you can prevent it.)
>
That's true but, the way I see USB/IP general use case, the drivers
from the host the devi
,
there is no need to bind/unbind each interface, just the device as a
whole.
Signed-off-by: Valentina Manea
---
Changes since v2:
* re-add check for empty device list
drivers/staging/usbip/stub.h | 2 +-
drivers/staging/usbip/stub_dev.c | 150
t;dev);
> goto out;
>
> @@ -831,8 +829,7 @@ static void vhci_device_reset(struct usbip_device *ud)
> vdev->speed = 0;
> vdev->devid = 0;
>
> - if (vdev->udev)
> - usb_put_dev(vdev->udev);
> + usb
portnum,
> +(struct usb_dev_state *) udev);
> +err_port:
> + dev_set_drvdata(&udev->dev, NULL);
> + usb_put_dev(udev);
> + kthread_stop_put(sdev->ud.eh);
> +
> + busid_priv->sdev = NULL;
> + stub_devi
memset(&req, 0, sizeof(req));
> - memset(&reply, 0, sizeof(reply));
>
> rc = usbip_net_recv(sockfd, &req, sizeof(req));
> if (rc < 0) {
>
Acked-by: Valentina Manea
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 14, 2014 at 8:21 PM, Greg KH wrote:
>
> Also, the kernel is the one now responsible for managing the /dev node
> creation/removal, through devtmpfs, there shouldn't be any "hotplug"
> scripts involved in this process, so I doubt it's a userspace issue.
>
> you do have CONFIG_DEVTMPFS e
On Sat, Feb 1, 2014 at 12:00 AM, Alan Stern wrote:
> On Fri, 31 Jan 2014, Sarah Sharp wrote:
>
>> Why exactly do you want the device to not show up in /dev? I would
>> think what you really want is for the device drivers on the server side
>> to not bind to the device, since the client side drive
Hi,
On Sun, Feb 16, 2014 at 12:42 AM, Alan Stern wrote:
>
> That's true when it is invoked from userspace. It can also be invoked
> directly by a kernel driver; in that case no file is needed.
>
I managed to get it working but I think what I did is rather flawed.
The problem is where I get tha
Add libudev as dependency and remove libsysfs.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/userspace/README
b/drivers/staging/usbip/userspace/README
index 00a1658
Add a new list API from CCAN.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +-
.../staging/usbip/userspace/libsrc/build_assert.h | 40 ++
.../staging/usbip/userspace/libsrc/check_type.h| 64 +++
.../staging/usbip/userspace/libsrc
The class device lists were used only when being initialized,
being populated and being destroyed. They had no real meaning
and thus the code was useless.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/vhci_driver.c | 178 -
.../staging/usbip
This patch modifies usbip_host_driver to use libudev.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/usbip_common.c | 74 ++
.../staging/usbip/userspace/libsrc/usbip_common.h | 5 +-
.../usbip/userspace/libsrc/usbip_host_driver.c | 282
This patch migrates vhci_driver to libudev.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 1 -
.../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++---
.../staging/usbip/userspace/libsrc/vhci_driver.h | 5 +-
3 files changed
libsysfs is now completely removed from USB/IP.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index a5193c6
Since it offers a API to both usbip tools and libusbip,
it is more appropriate to be place in the library.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +-
.../staging/usbip/userspace/libsrc/sysfs_utils.c | 36 ++
.../staging
with sysfs.
Valentina Manea (12):
staging: usbip: userspace: migrate usbip_bind to libudev
staging: usbip: userspace: remove useless libsysfs includes
staging: usbip: userspace: migrate usbip_unbind to libudev
staging: usbip: userspace: migrate usbip_list to libudev
staging: usbip
This patch modifies usbip_unbind to use libudev.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_unbind.c | 92 +++---
1 file changed, 29 insertions(+), 63 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip_unbind.c
b/drivers
This patch removes useless libsysfs.h includes in various
userspace files.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 1 -
drivers/staging/usbip/userspace/src/usbip_detach.c | 2 --
drivers/staging/usbip/userspace/src/usbip_network.h | 1 -
3 files
This was deleted in the driver conversion patch. It didn't need
to be deleted; showing more information is ok.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++-
drivers/staging/usbip/userspace/src/usbipd.c | 16 ++
This patch adds autoconf check for libudev and migrates
usbip_bind to the new library.
libsysfs will still be used until all userspace is modified.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 6 +
.../staging/usbip/userspace/libsrc/usbip_common.h
This patch modifies usbip_list to use libudev.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_list.c | 137 +--
1 file changed, 51 insertions(+), 86 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip_list.c
b/drivers/staging
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index 25bf160..607d05c 100644
--- a/drivers/staging
Since usbip-host is now a device driver and the client
has full access to the shared device, it makes sense to
let the client choose device configuration.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/stub_dev.c | 10 +-
drivers/staging/usbip/stub_rx.c | 26
A sysfs attribute is used to announce kernel space that a
new driver probing session should be triggered for the just
unbinded device.
In order to have the address of struct device associated to this
USB device, a new member has been added to struct bus_id_priv.
Signed-off-by: Valentina Manea
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/stub_dev.c | 22 ++
drivers/usb/core/devio.c | 17 -
drivers/usb/core/hub.c | 2 ++
drivers/usb/core/usb.h | 6 +-
include/linux/usb.h | 23
When a device has just been bound to usbip-host but the client hasn't
set a configuration on it, certain attributes will not exist. Don't
treat this as an error.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17 +++--
1 file c
This is an optional dependency since USB/IP can fully work without
it. However, it is needed to display device information such as
vendor.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/README | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/usbip
A device should not be able to be used concurrently both by
the server and the client. Claiming the port used by the
shared device ensures no interface drivers bind to it and
that it is not usable from the server.
Signed-off-by: Valentina Manea
---
Changes since v1:
* add commit description
On Wed, Mar 5, 2014 at 12:15 PM, Dan Carpenter wrote:
> On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote:
>> On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote:
>> > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h
>> &
On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote:
> On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote:
>> Signed-off-by: Valentina Manea
>> ---
>> drivers/staging/usbip/userspace/configure.ac | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index 25bf160..607d05c 100644
--- a/drivers/staging
This is an optional dependency since USB/IP can fully work without
it. However, it is needed to display device information such as
vendor.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/README | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/usbip
A sysfs attribute is used to announce kernel space that a
new driver probing session should be triggered for the just
unbinded device.
In order to have the address of struct device associated to this
USB device, a new member has been added to struct bus_id_priv.
Signed-off-by: Valentina Manea
When a device has just been bound to usbip-host but the client hasn't
set a configuration on it, certain attributes will not exist. Don't
treat this as an error.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17 +++--
1 file c
A device should not be able to be used concurrently both by
the server and the client. Claiming the port used by the
shared device ensures no interface drivers bind to it and
that it is not usable from the server.
Signed-off-by: Valentina Manea
Acked-by: Alan Stern
---
drivers/staging/usbip
Since usbip-host is now a device driver and the client
has full access to the shared device, it makes sense to
let the client choose device configuration.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/stub_dev.c | 10 +-
drivers/staging/usbip/stub_rx.c | 26
Add libudev as dependency and remove libsysfs.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/userspace/README
b/drivers/staging/usbip/userspace/README
index 00a1658
libsysfs is now completely removed from USB/IP.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index a5193c6
Since it offers a API to both usbip tools and libusbip,
it is more appropriate to be place in the library.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 ++-
.../staging/usbip/userspace/libsrc/sysfs_utils.c | 31 ++
.../staging
This was deleted in the driver conversion patch. It didn't need
to be deleted; showing more information is ok.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++-
drivers/staging/usbip/userspace/src/usb
This patch modifies usbip_host_driver to use libudev.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
.../staging/usbip/userspace/libsrc/usbip_common.c | 76 ++
.../staging/usbip/userspace/libsrc/usbip_common.h | 5 +-
.../usbip/userspace/libsrc/usbip_host_driver.c
This patch migrates vhci_driver to libudev.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 1 -
.../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++---
.../staging/usbip/userspace/libsrc/vhci_driver.h
This patch modifies usbip_unbind to use libudev.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
drivers/staging/usbip/userspace/src/usbip_unbind.c | 93 +++---
1 file changed, 29 insertions(+), 64 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src
The class device lists were used only when being initialized,
being populated and being destroyed. They had no real meaning
and thus the code was useless.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/vhci_driver.c | 178 -
.../staging/usbip
Take the linked list implementation from the Linux Kernel
and strip it down to what it is needed.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/list.h | 136 ++
1 file changed, 136 insertions(+)
create mode 100644 drivers/staging/usbip
This patch modifies usbip_list to use libudev.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_list.c | 133 +--
1 file changed, 50 insertions(+), 83 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip_list.c
b/drivers/staging
This patch adds autoconf check for libudev and migrates
usbip_bind to the new library.
libsysfs will still be used until all userspace is modified.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
drivers/staging/usbip/userspace/configure.ac | 6 +
.../staging/usbip
This patch removes useless libsysfs.h includes in various
userspace files.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 1 -
drivers/staging/usbip/userspace/src/usbip_detach.c | 2 --
drivers/staging/usbip/userspace/src/usbip_network.h | 1 -
3 files
This is a resend of the patches sent a few days ago, including
the migration of USB/IP userspace side to use libudev instead
of libsysfs and various other fixes, all ordered in a big patch
series.
The patches have been modified according to received feedback.
Valentina Manea (18):
staging
I was notified that one of the patches in the series (staging: usbip:
claim ports used by shared devices) breaks the build.
I take full responsability for this as I haven't compiled the kernel
with allyesconfig and I am sorry.
This can be fixed by moving struct dev_state, usb_hub_claim_port() and
Since it is needed outside usbcore and exposed in include/linux/usb.h,
it conflicts with enum dev_state in rt2x00 wireless driver and breaks
the build.
Mark it as usb specific to avoid conflicts in the future and update
USB/IP to use the new name.
Valentina Manea (2):
usbcore: rename struct
Since it is needed outside usbcore and exposed in include/linux/usb.h,
it conflicts with enum dev_state in rt2x00 wireless driver.
Mark it as usb specific to avoid conflicts in the future.
Signed-off-by: Valentina Manea
---
drivers/usb/core/devio.c | 112
struct dev_state definition in usbcore conflicted with
enum dev_state definition in rt2x00 driver so it was
renamed to usb_dev_state.
Update usbip for this change.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/stub_dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Besides this, a warning generated in the kernel code is solved.
Valentina Manea (3):
usbip: move usbip userspace code out of staging
usbip: move usbip kernel code out of staging
usbip: remove struct usb_device_id table
drivers/staging/Kconfig|2 -
drivers
This was used back when usbip-host was an interface device driver;
after the conversion to device driver, the table remained unused.
Remove it in order to stop receiving a warning about it.
Signed-off-by: Valentina Manea
---
drivers/usb/usbip/stub_dev.c | 27 ---
1 file
On Thu, Sep 4, 2014 at 2:41 AM, Greg KH wrote:
>
> Shouldn't you be able to use the same "path" as ch9.h uses? It's a uapi
> .h file, no relative paths should be needed.
>
For the userspace tool, the build system only looks for headers in the
system default locations, such as /usr/include. Hence
On Thu, Sep 4, 2014 at 5:14 AM, Greg KH wrote:
>
>> This patch is a pretty nasty hack to get it to compile within the
>> kernel tree. I wonder whether we can make this self-contained by
>> duplicating the header's content inside usbip_common.h.
>
> Ick, no, don't do that, use the .h file, that is
On Fri, Sep 5, 2014 at 1:58 AM, Piotr Król wrote:
> Fixes: 588b48caf65c ("usbip: move usbip userspace code out of staging")
> which introduced build failure by not changing uapi/usbip.h include path
> according to new location.
>
> Signed-off-by: Piotr Król
> ---
> include/uapi/linux/Kbuild
This was used back when usbip-host was an interface device driver;
after the conversion to device driver, the table remained unused.
Remove it in order to stop receiving a warning about it.
Signed-off-by: Valentina Manea
---
drivers/usb/usbip/stub_dev.c | 27 ---
1 file
At this point, USB/IP userspace code is fully functional
and can be moved out of staging.
Signed-off-by: Valentina Manea
---
{drivers/staging/usbip/userspace => tools/usb/usbip}/.gitignore | 0
{drivers/staging/usbip/userspace => tools/usb/usbip}/AUTHORS | 0
{d
Besides this, a warning generated in the kernel code is solved.
Valentina Manea (3):
usbip: move usbip userspace code out of staging
usbip: move usbip kernel code out of staging
usbip: remove struct usb_device_id table
drivers/staging/Kconfig| 2 --
drivers
At this point, USB/IP kernel code is fully functional
and can be moved out of staging.
Signed-off-by: Valentina Manea
---
drivers/staging/Kconfig| 2 --
drivers/staging/Makefile | 1 -
drivers/{staging => usb}/usbip/Kcon
tools/usb/usbip
* kernel code to drivers/usb/usbip
Besides this, a warning generated in the kernel code is solved.
Valentina Manea (3):
usbip: move usbip userspace code out of staging
usbip: move usbip kernel code out of staging
usbip: remove struct usb_device_id table
drivers/staging
On Wed, Aug 6, 2014 at 10:33 PM, Greg KH wrote:
> On Thu, Aug 07, 2014 at 08:10:25AM +0300, Valentina Manea wrote:
>> This is a resend of the patch series from March.
>>
>> After migrating userspace code to libudev, converting usbip-host
>> to a device drive
On Thu, Aug 7, 2014 at 1:16 PM, Greg KH wrote:
>
> The top of the MAINTAINERS should have this information, look in the S:
> Status section about what type of category you are in.
>
> Basically I'd like you to be the one to handle patches that are sent in
> for the code, just by reviewing them, yo
On Tue, Aug 19, 2014 at 11:38 AM, Greg KH wrote:
>
> This patch moves the code, but now it's "gone" from the build system as
> it is not hooked up and can not be built at all.
>
> So while I really wanted to apply this series right now, I can't, as
> this is a regression (working driver -> no driv
This was used back when usbip-host was an interface device driver;
after the conversion to device driver, the table remained unused.
Remove it in order to stop receiving a warning about it.
Signed-off-by: Valentina Manea
---
drivers/usb/usbip/stub_dev.c | 27 ---
1 file
At this point, USB/IP kernel code is fully functional
and can be moved out of staging.
Signed-off-by: Valentina Manea
---
drivers/staging/Kconfig| 2 --
drivers/staging/Makefile | 1 -
drivers/usb/Kconfig
This patch adds an entry in MAINTAINERS file for USB/IP
driver.
Signed-off-by: Valentina Manea
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index aefa948..76ac03d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9515,6 +9515,14 @@ S
A warning generated in the kernel code is also solved and an entry
in MAINTAINERS file is created for this driver.
Valentina Manea (4):
usbip: move usbip userspace code out of staging
usbip: move usbip kernel code out of staging
usbip: remove struct usb_device_id table
MAINTAINERS: Add an
At this point, USB/IP userspace code is fully functional
and can be moved out of staging.
Signed-off-by: Valentina Manea
---
{drivers/staging/usbip/userspace => tools/usb/usbip}/.gitignore | 0
{drivers/staging/usbip/userspace => tools/usb/usbip}/AUTHORS | 0
{d
On Tue, Aug 19, 2014 at 9:30 PM, Valentina Manea
wrote:
> At this point, USB/IP userspace code is fully functional
> and can be moved out of staging.
>
> Signed-off-by: Valentina Manea
Bumping this in case Greg missed the patch series.
Valentina
--
To unsubscribe from this list: s
On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter wrote:
> This was promoted out of staging and there wasn't an email to the
> staging list. Normally I like to go through any remaining questions
> before the code is moved. The code looks pretty good, I just had one
> question.
>
I didn't know I sho
On Tue, Aug 26, 2014 at 11:47 AM, Dan Carpenter
wrote:
> On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote:
>> On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter
>> wrote:
>> >707 /*
>> >708 * loop over all packe
gt;wHubCharacteristics = __constant_cpu_to_le16(
> HUB_CHAR_INDV_PORT_LPSM | HUB_CHAR_COMMON_OCPM);
>
Acked-by: Valentina Manea
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Sorry for the lack of review on this series; will take care of this tomorrow.
Valentina
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Fri, Apr 3, 2015 at 3:33 AM, Nobuo Iwata wrote:
>
> For this, export function, connection is established from device-side machine
> to application-side machine.
>
> Following use cases are supposed for the export function.
> 1) Server application or cloud service serves distributed ubiqui
Hi,
I looked around your patch and tested it and looks good.
However, I do have 2 nit-picks:
* I noticed in some places you've used labels such as err0 and err1.
Please replace them with something more relevant to their
functionality, such as what you're cleaning up after. There are
examples of t
On Tue, Apr 14, 2015 at 10:00 AM, Nobuo Iwata
wrote:
> -server:# usbip bind --busid=1-2
> +dev:# usbip bind --busid=1-2
> - Bind usbip-host.ko to the device of busid 1-2.
> -- A usb device 1-2 is now exportable to other hosts!
> -- Use 'usbip unbind --busid=1-2' w
On Tue, Apr 14, 2015 at 10:00 AM, Nobuo Iwata
wrote:
> stub_shutdown_connection() : drivers/usb/usbip/stub_dev.c
> stub_device_cleanup_urbs() : drivers/usb/usbip/stub_main.c
> requests to kill pending URBs and clears priv lists.
>
> stub_complete() : drivers/usb/usbip/stub_tx.c might be calle
Looks ok.
Valentina
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 14, 2015 at 10:00 AM, Nobuo Iwata
wrote:
> diff --git a/tools/usb/usbip/libsrc/usbip_ux.h
> b/tools/usb/usbip/libsrc/usbip_ux.h
> new file mode 100644
> index 000..7506a1c
> --- /dev/null
> +++ b/tools/usb/usbip/libsrc/usbip_ux.h
> +#include "../../../../include/uapi/linux/usbip_
Looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Managed to go through your series and looks like you've spent some
time on this. Good job!
However, given the density of the patches, I haven't really been able
to go through every line of code.
I did do some basic testing and made some comments where needed.
Shuah, Greg, do you think more th
On Mon, Jan 19, 2015 at 1:00 AM, Sergei Shtylyov
wrote:
> Fix using the bare number to set the 'wHubCharacteristics' field of the Hub
> Descriptor while the values are #define'd in .
>
> Signed-off-by: Sergei Shtylyov
>
> ---
> drivers/usb/usbip/vhci_hcd.c |3 ++-
> 1 file changed, 2 inse
92 matches
Mail list logo
