Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-23 Thread Tomi Valkeinen
On 10/11/16 23:25, Laurent Pinchart wrote: [2.766174] musb_bus_suspend 2586: trying to suspend as a_idle while active printed in a loop at boot time. I've traced musb->is_active being set to 1 in musb_start() with > Actually disabling CONFIG_USB_MUSB_HDRC gets rid of

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-23 Thread Tomi Valkeinen
On 23/11/16 17:49, Laurent Pinchart wrote: > Hi Tomi, > > On Wednesday 23 Nov 2016 12:14:17 Tomi Valkeinen wrote: >> On 10/11/16 23:25, Laurent Pinchart wrote: >>>>>> [2.766174] musb_bus_suspend 2586: trying to suspend as a_idle while >>>>>

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-23 Thread Tomi Valkeinen
On 23/11/16 18:34, Tony Lindgren wrote: > OK. And what changes to your current .config make the musb_bus_suspend() > issues show up? > > If it happens with USB-B cable from host to musb with musb set to host > only mode I'm not suprised there are errors :) I have no USB cables connected. I have

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-13 Thread Tomi Valkeinen
Hi, On 28/05/13 08:18, Kishon Vijay Abraham I wrote: > Hi Tony, > > On Friday 17 May 2013 06:52 PM, Kishon Vijay Abraham I wrote: >> In order for controllers to get PHY in case of non dt boot, the phy >> binding information (phy label) should be added in the platform >> data of the controller. >

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-13 Thread Tomi Valkeinen
On 14/06/13 08:47, Tony Lindgren wrote: > * Kishon Vijay Abraham I [130613 22:41]: >> Hi, >> >> On Thursday 13 June 2013 06:35 PM, Tomi Valkeinen wrote: >>> Hi, >>> >>> On 28/05/13 08:18, Kishon Vijay Abraham I wrote: >>>> Hi Tony, >

Re: [RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-06-14 Thread Tomi Valkeinen
On 14/06/13 10:33, Tony Lindgren wrote: > If we want to fix something this late in the merge window, the patches > must have a clear description what caused the regression and what happens > without the patches. These patches don't have that. And they are marked > RFC also. So actually I'm not app

Re: [PATCH] build some drivers only when compile-testing

2013-06-18 Thread Tomi Valkeinen
On 18/06/13 07:51, Michal Marek wrote: >> Sam Ravnborg (the kconfig ex-maintainer) once wrote that he doesn't want >> to extend the kconfig language for this purpose (which I support). That >> a config option is fine and sufficient in this case [1]. Except he >> called the config option "SHOW_ALL_

Re: [PATCH] build some drivers only when compile-testing

2013-06-19 Thread Tomi Valkeinen
On 17/06/13 23:05, Jiri Slaby wrote: > The last point I inclined to the Greg's argument to remove the EXPERT > dependency. > > So currently I have what is attached... Comments? The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're not adding COMPILE_TEST there, but you're adding a to

Re: [PATCH] build some drivers only when compile-testing

2013-06-19 Thread Tomi Valkeinen
On 19/06/13 10:12, Jiri Slaby wrote: > On 06/19/2013 09:10 AM, Tomi Valkeinen wrote: >> On 17/06/13 23:05, Jiri Slaby wrote: >> >>> The last point I inclined to the Greg's argument to remove the >>> EXPERT dependency. >>> >>> So currently I

Re: [PATCH] build some drivers only when compile-testing

2013-05-23 Thread Tomi Valkeinen
Hi, On 22/05/13 12:18, Jiri Slaby wrote: > Some drivers can be built on more platforms than they run on. This > causes users and distributors packaging burden when they have to > manually deselect some drivers from their allmodconfigs. Or sometimes > it is even impossible to disable the drivers wi

Re: [PATCH v2 0/3] ARM: OMAP2+: USB Host bug fixes for 3.13 rc

2013-12-04 Thread Tomi Valkeinen
On 2013-12-03 16:25, Roger Quadros wrote: > Hi, > > This is a follow up solution to the original series in [1] > > The first patch fixes the OMAP4 Panda USB detection problems on 3.13-rc1 > with u-boot v2013.10. > > The remaining 2 patches are required if SOFTRESET needs to be done for the > USB

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-22 Thread Tomi Valkeinen
On 18/10/14 00:13, Jani Nikula wrote: > Documentation/kbuild/kconfig-language.txt warns to use select with care, > and in general use select only for non-visible symbols and for symbols > with no dependencies, because select will force a symbol to a value > without visiting the dependencies. > > S

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-23 Thread Tomi Valkeinen
On 23/10/14 11:10, Daniel Vetter wrote: > If we want to make BACKLIGHT_CLASS_DEVICE into a library thing then I > guess we could do that, but we must then also drag it out of all the other > meta options to make sure it's always available. No need I think to ditch BACKLIGHT_CLASS_DEVICE only depe

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-27 Thread Tomi Valkeinen
On 27/10/14 13:59, Jani Nikula wrote: >> While doing 'depends on' instead of 'select' is an "easy" fix for this, >> I do dislike it quite a bit. It's a major pain to go around the kernel >> config, trying to find all the dependencies that a particular driver >> wants. If I need fb-foobar, I should