From: Thang Nguyen
As per USB 2.0 link power management addendum ECN, table 1-2, page 4,
device or host initiated via resume signaling; device-initiated resumes
can be optionally enabled/disabled by software. This patch adds support
to control enabling the USB2 RWE feature via DT/ACPI attribute.
Hi,
Do you have any feedback on this?
Thanks,
Thang Q. Nguyen
On Sun, Dec 4, 2016 at 7:42 PM, Thang Q. Nguyen wrote:
> From: Thang Nguyen
>
> As per USB 2.0 link power management addendum ECN, table 1-2, page 4,
> device or host initiated via resume signaling; device-initiated resu
On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote:
> On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote:
>> From: Thang Nguyen
>>
>> As per USB 2.0 link power management addendum ECN, table 1-2, page 4,
>> device or host initiated via resume signalin
Hi,
On Mon, Dec 12, 2016 at 3:37 PM, Felipe Balbi
wrote:
>
> Hi,
>
> "Thang Q. Nguyen" writes:
>> On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote:
>>> On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote:
>>>> From: Thang Nguye
On Mon, Dec 12, 2016 at 8:00 PM, Mathias Nyman
wrote:
> On 12.12.2016 06:00, Thang Q. Nguyen wrote:
>>
>> On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote:
>>>
>>> On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote:
>>>>
>>>>
Add 64-bit DMA operation support to the USB DWC3 driver.
First attempt to set the coherent DMA mask for 64-bit DMA.
If that failed, attempt again with 32-bit DMA.
Signed-off-by: Thang Q. Nguyen
---
Changes from v1:
- Remove WARN_ON if dma_mask is NULL
drivers/usb/dwc3/core.c | 15
The xhci-hcd child node needs to inherit archdata attribute to use
dma_ops functions and attributes. This patch enables the USB DWC3
driver to pass archdata attributes to its xhci-hcd child node.
Signed-off-by: Thang Q. Nguyen
---
Changes from v1:
- None
drivers/usb/dwc3/host.c | 1
Hi,
Do you have any feedback on this change?
Regards,
Thang Q. Nguyen -
-Original Message-
From: Thang Q. Nguyen [mailto:tqngu...@apm.com]
Sent: Monday, January 25, 2016 9:26 PM
To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org;
linux-o...@vger.kernel.org; linux-ker
Hi,
Do you have any more feedback on this patch?
Thanks,
Thang Q. Nguyen -
-Original Message-
From: Thang Q. Nguyen [mailto:tqngu...@apm.com]
Sent: Monday, January 25, 2016 9:26 PM
To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org;
linux-o...@vger.kernel.org; linux-ker
Hi,
I would like to ask if I need to update anything else for this change?
Thanks,
Thang Q. Nguyen -
-Original Message-
From: Thang Q. Nguyen [mailto:tqngu...@apm.com]
Sent: Monday, January 25, 2016 9:26 PM
To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org;
linux-o
Hi,
I would like to ask if I need to update anything else for this change?
Thanks,
Thang Q. Nguyen -
-Original Message-
From: Thang Q. Nguyen [mailto:tqngu...@apm.com]
Sent: Monday, January 25, 2016 9:26 PM
To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org;
linux-o
Thanks Felipe for your feedback.
I will re-generate patches and resend.
Regards,
Thang Q. Nguyen -
-Original Message-
From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com]
Sent: Thursday, March 10, 2016 3:15 PM
To: Thang Q. Nguyen; Thang Q. Nguyen; Felipe Balbi; Greg Kroah-Hartman
From: "Thang Q. Nguyen"
Add 64-bit DMA operation support to the USB DWC3 driver.
First attempt to set the coherent DMA mask for 64-bit DMA.
If that failed, attempt again with 32-bit DMA.
Changes from v2:
- None.
Changes from v1:
- Remove WARN_ON if dma_mask is NULL
From: "Thang Q. Nguyen"
The xhci-hcd child node needs to inherit archdata attribute to use
dma_ops functions and attributes. This patch enables the USB DWC3
driver to pass archdata attributes to its xhci-hcd child node.
Changes from v2:
- None
Changes from v1:
- No
From: "Thang Q. Nguyen"
When CONFIG_DMA_CMA is not set, the coherent mask is not set.
These patches enable the USB DWC3 driver to set the coherent mask
correctly by first set coherent DMA mask to 64-bit. If this
failed, attempt again with 32-bit.
In addition, pass the archdata to th
gt; Hi,
>
> "Thang Q. Nguyen" writes:
>> From: "Thang Q. Nguyen"
>>
>> Add 64-bit DMA operation support to the USB DWC3 driver.
>> First attempt to set the coherent DMA mask for 64-bit DMA.
>> If that failed, attempt again with 32-bit DMA.
Thanks Grygorii for information.
I checked but do not see dma_init_dev_from_parent is used in
linux-next repository. Can you give me more information for what
branch I can checkout to use it for USB DWC3?
Thanks,
Thang --
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
t
On Mon, Mar 5, 2018 at 5:22 PM, Thang Q. Nguyen wrote:
> On Mon, Jan 29, 2018 at 5:24 PM, Thang Q. Nguyen wrote:
>> From: Tung Nguyen
>>
>> Currently, hcd->shared_hcd always creates and registers to the usb-core.
>> If, for some reasons, USB3 downstream port is
review and suggest what approach should be used to fix this
issue?
Thanks,
Thang Q. Nguyen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Mon, Oct 23, 2017 at 5:27 PM, Mathias Nyman
wrote:
> On 23.10.2017 12:37, Thang Q. Nguyen wrote:
>>
>> Hi,
>> In our latest ARM64-based CPU, we use the DesignWare USB which is
>> xHCI-compatible. For some reasons, we disable USB3.0 support so remove the
>&
On Wed, Nov 1, 2017 at 4:17 PM, Thang Q. Nguyen wrote:
> Hi,
>
> On Mon, Oct 23, 2017 at 5:27 PM, Mathias Nyman
> wrote:
>> On 23.10.2017 12:37, Thang Q. Nguyen wrote:
>>>
>>> Hi,
>>> In our latest ARM64-based CPU, we use the DesignWare USB which
19)
This patch checks, creates and registers shared_hcd if USB3.0 downstream
port is available.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
---
drivers/usb/host/xhci-mem.c | 2 +-
drivers/usb/host/xhci-plat.c | 26 +++--
drivers/usb/host/xhci.c
Hi,
On Sat, Dec 16, 2017 at 10:45 AM, Thang Q. Nguyen wrote:
> From: Tung Nguyen
>
> Currently, hcd->shared_hcd always creates and registers to the usb-core.
> If, for some reasons, USB3 downstream port is disabled, no roothub port for
> USB3.0 is found. This causes kernel t
From: Tung Nguyen
Currently, hcd->shared_hcd always creates and registers to the usb-core.
If, for some reasons, USB3 downstream port is disabled, no roothub port for
USB3.0 is found. This causes kernel to display an error:
hub 2-0:1.0: config failed, hub doesn't have any ports! (err -19)
This pa
On Mon, Jan 29, 2018 at 5:24 PM, Thang Q. Nguyen wrote:
> From: Tung Nguyen
>
> Currently, hcd->shared_hcd always creates and registers to the usb-core.
> If, for some reasons, USB3 downstream port is disabled, no roothub port for
> USB3.0 is found. This causes kernel to displ
disable this feature.
This patch adds support to control disabling USB2 Hardware LPM via
DT/ACPI attribute.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
---
Documentation/devicetree/bindings/usb/usb-xhci.txt |1 +
drivers/usb/host/xhci-plat.c |3 +++
drivers
On Fri, May 19, 2017 at 5:30 AM, Rob Herring wrote:
> On Sat, May 13, 2017 at 07:13:14AM +0700, Thang Q. Nguyen wrote:
>> XHCI specification 1.1 does not require xHCI 1.0 compliant controllers
>> to always enable hardware USB2 LPM.
>> However, the current xHCI driver always
disable this feature.
This patch adds support to control disabling USB2 Hardware LPM via
DT/ACPI attribute.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
---
Changes since v1:
- Update DT/ACPI attribute and corresponding codes from HLE to LPM to
be consistent with other attribute names
On Mon, Jun 5, 2017 at 6:14 PM, Mathias Nyman
wrote:
> On 20.05.2017 10:24, Thang Q. Nguyen wrote:
>>
>> XHCI specification 1.1 does not require xHCI 1.0 compliant controllers
>> to always enable hardware USB2 LPM.
>> However, the current xHCI driver always enab
On Mon, Jun 5, 2017 at 9:33 PM, Mathias Nyman wrote:
> On 05.06.2017 15:57, Thang Q. Nguyen wrote:
>>
>> On Mon, Jun 5, 2017 at 6:14 PM, Mathias Nyman
>> wrote:
>>>
>>> On 20.05.2017 10:24, Thang Q. Nguyen wrote:
>>>>
>>>>
h updates the formulation
to check this case in both DT and ACPI.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
---
drivers/usb/host/xhci-plat.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
On Tue, Jun 13, 2017 at 8:12 PM, Mathias Nyman
wrote:
> On 06.06.2017 09:33, Thang Q. Nguyen wrote:
>>
>> On Mon, Jun 5, 2017 at 9:33 PM, Mathias Nyman
>> wrote:
>>>
>>> On 05.06.2017 15:57, Thang Q. Nguyen wrote:
>>>>
>>>>
case user would like to disable this
feature. For example, their xHCI controller has its USB2 HW LPM
broken.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
---
Changes since v2:
- Change code to disable HW LPM as an option for user which
is set via ACPI/DT.
Changes since v1
On Tue, Jun 6, 2017 at 2:11 PM, Thang Q. Nguyen wrote:
> For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA
> configuration"), sysdev points to devices known to the system firmware
> or hardware for DMA parameters.
> However, the parent of the system firmware
On Fri, Jun 23, 2017 at 10:02 AM, Thang Q. Nguyen wrote:
> XHCI specification 1.1 does not require xHCI-compliant controllers
> to always enable hardware USB2 LPM. However, the current xHCI
> driver always enable it when seeing HLC=1.
> This patch supports an option for users to contr
case user would like to disable this
feature. For example, their xHCI controller has its USB2 HW LPM
broken.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
---
Changes since v3:
- Bypass updating LPM parameters when HW LPM is optionally disabled.
Changes since v2:
- Change code to
case user would like to disable this
feature. For example, their xHCI controller has its USB2 HW LPM
broken.
Signed-off-by: Tung Nguyen
Signed-off-by: Thang Q. Nguyen
Acked-by: Rob Herring
---
Changes since v4:
- When HW LPM is optionally disabled, explicitly disable HLE, RWE, ...
- Update
On Tue, Aug 8, 2017 at 11:27 AM, Thang Q. Nguyen wrote:
> XHCI specification 1.1 does not require xHCI-compliant controllers
> to always enable hardware USB2 LPM. However, the current xHCI
> driver always enable it when seeing HLC=1.
> This patch supports an option for users to contr
From: "Thang Q. Nguyen"
For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA
configuration"), sysdev points to devices known to the system firmware
or hardware for DMA parameters.
However, the parent of the system firmware/hardware device checking
logic does not
On Sat, Aug 19, 2017 at 10:43 AM, Thang Q. Nguyen wrote:
> From: "Thang Q. Nguyen"
>
> For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA
> configuration"), sysdev points to devices known to the system firmware
> or hardware for DMA parameter
40 matches
Mail list logo
