Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-21 Thread Ivan T. Ivanov
On Tue, 2013-08-20 at 18:01 +0100, Pawel Moll wrote: > On Tue, 2013-08-20 at 16:06 +0100, Pawel Moll wrote: > > On Tue, 2013-08-20 at 16:01 +0100, Kumar Gala wrote: > > > On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > > > > > > > > > >

[PATCH v5 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-21 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov --- drivers/usb/dwc3/Kconfig|8 +++ d

[PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-21 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov --- .../devicetree/b

[PATCH v5 0/3] DWC3 USB support for Qualcomm platform

2013-08-21 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, Here is fifth version of MSM USB3 drivers patches. Changes since v4: * Substitute references to "wc3" with just "dw" in USB PHY drivers and file names. This is to indicate that the PHY's are DesignWare, but not necessarily relat

[PATCH v5 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-08-21 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-29 Thread Ivan T. Ivanov
On Thu, 2013-08-22 at 15:41 -0500, Felipe Balbi wrote: > On Wed, Aug 21, 2013 at 10:13:28AM -0500, Kumar Gala wrote: > > > > On Aug 21, 2013, at 8:06 AM, Ivan T. Ivanov wrote: > > > > > On Tue, 2013-08-20 at 18:01 +0100, Pawel Moll wrote: > > >> On

Re: [PATCH v4 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-01 Thread Ivan T. Ivanov
Hi, I am sorry for delay answer. On Thu, 2013-09-26 at 10:46 +0100, Mark Rutland wrote: > On Mon, Sep 23, 2013 at 08:31:48PM +0100, Felipe Balbi wrote: > > Hi, > > > > On Tue, Aug 20, 2013 at 12:56:03PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Iv

Re: [PATCH v4 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-01 Thread Ivan T. Ivanov
Hi, On Mon, 2013-09-23 at 14:31 -0500, Felipe Balbi wrote: > Hi, > > On Tue, Aug 20, 2013 at 12:56:03PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > > (SNPS) and HS, S

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-01 Thread Ivan T. Ivanov
Hi, On Mon, 2013-09-23 at 16:03 -0600, Stephen Warren wrote: > On 09/23/2013 01:32 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: > >> From: "Ivan T. Ivanov" > >> > >> MSM US

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-01 Thread Ivan T. Ivanov
Hi, On Mon, 2013-09-23 at 14:32 -0500, Felipe Balbi wrote: > Hi, > > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > > (SNPS) and HS, S

[PATCH v6 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-07 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov Acked-by:

[PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-10-07 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig

[PATCH v6 0/3] DWC3 USB support for Qualcomm platform

2013-10-07 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is sixth version of MSM USB3 drivers patches. Changes since v5: * devicetree bindings descriptions fixes * Fixed NULL pointer dereferences in dev_prink's * Removed extra space in "sleep " clock name Changes since v4: * Substitute refe

[PATCH v6 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-10-07 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov --- drivers/usb/dwc3/Kconfig|8 +++ d

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-07 Thread Ivan T. Ivanov
Hi Felipe, On Fri, 2013-10-04 at 09:31 -0500, Felipe Balbi wrote: > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > > (SNPS) and HS, SS PHY&

Re: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-10-08 Thread Ivan T. Ivanov
Hi Stan, On Mon, 2013-10-07 at 12:22 +0300, Stanimir Varbanov wrote: > Hi Ivan, > > Few comments below. > > On 10/07/2013 10:44 AM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > These drivers handles control and configuration of the H

Re: [PATCH v6 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-10-08 Thread Ivan T. Ivanov
Hi Stan, On Mon, 2013-10-07 at 12:28 +0300, Stanimir Varbanov wrote: > Hi Ivan, > > Minor comments below. > > On 10/07/2013 10:44 AM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > DWC3 glue layer is hardware layer around Synopsys

[PATCH 2/2] USB: ehci-msm: Add device tree support and binding information

2013-10-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows MSM EHCI controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 17 + drivers/usb/host/ehci-msm.c| 15 +-- 2 files c

[PATCH 1/2] ehci-msm: Remove global struct usb_phy variable

2013-10-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use struct usb_hcd::phy to hold USB PHY instance. Signed-off-by: Ivan T. Ivanov --- drivers/usb/host/ehci-msm.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 0f717d

[PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch fix compilation error and is an intermediate step before the addition of DeviceTree support for newer targets. Cc: David Brown Cc: Daniel Walker Cc: Felipe Balbi Cc: Greg Kroah-Hartman Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-msm/board

[PATCH v3 04/13] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v3 09/13] usb: phy: msm: Remove unused pclk_src_name

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h |5 - 2 files changed, 1 insert

[PATCH v3 11/13] usb: phy: msm: Remove HSUSB prefix from requlator names

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 0bd3ba

[PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" IRQ with number 0 is valid case, so check for negative numbers instead. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy

[PATCH v3 10/13] usb: phy: msm: Switch clock consumer strings

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Replace the USB specific clock names in driver with the more standard 'core' and 'iface' ... names. Cc: David Brown Cc: Stephen Boyd Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-msm/devices-msm7x00.c |4 +- arch/arm/mach-msm/devic

[PATCH v3 08/13] usb: phy: msm: Drop default usb_dr_mode from platform data.

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" USB DT bindings states: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |7 --- include/linux/usb/

[PATCH v3 06/13] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 28cab03..4680

[PATCH v3 03/13] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 192 - 1 file changed, 74 insertions(+), 118

[PATCH v3 07/13] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-msm/board-msm7x30.c |2 +- arch/arm/mach-msm/board-qsd8x50.c |2 +- drivers/usb/phy/phy-msm-usb.c | 40 ++--- include/linux/usb/msm_hsusb.h | 19 ++-

[PATCH v3 05/13] usb: phy: msm: Fix WARNING: quoted string split across lines

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy

[PATCH v3 00/13] usb: phy: msm: Fixes, cleanups and DT support

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is third version of MSM OTG clean up patches. v3 -- * In patch 1 - functions for reseting PHY and LINK controller just call platform code if available. * New stuff is: cleaning up unneeded/unused driver state variables * Simplified regulator names

[PATCH v3 13/13] usb: phy: msm: Add device tree support and binding information

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows MSM OTG controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 58 +++ drivers/usb/phy/phy-msm-usb.c | 59 ++-- 2 fil

[PATCH v3 02/13] usb: phy: msm: Move global regulators variables to driver state

2013-10-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 - include/linux/usb/msm_hsusb.h |3 ++ 2 files changed, 42 insertions(+), 43 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/u

Re: [PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data

2013-10-15 Thread Ivan T. Ivanov
On Mon, 2013-10-14 at 17:52 -0500, Felipe Balbi wrote: > Hi, > > On Mon, Oct 14, 2013 at 06:24:28PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This patch fix compilation error and is an intermediate step > > before the addit

Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-15 Thread Ivan T. Ivanov
On Mon, 2013-10-14 at 17:59 -0500, Felipe Balbi wrote: > On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > IRQ with number 0 is valid case, so check for negative > > not entirelly correct... IRQ 0 isn

Re: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-10-22 Thread Ivan T. Ivanov
Hi, On Tue, 2013-10-22 at 15:32 +0100, Mark Rutland wrote: > [...] > > > > > + phy->sleep_a_clk = devm_clk_get(phy->dev, "sleep_a"); > > > > > > What means the "_a" in clock name? > > > > They are 2 PHY's on 8074 chip. This drivers is supposed to > > operate on PHY 0, thus sleep_a. PHY 1 is

Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-30 Thread Balaji T K
On Friday 18 October 2013 09:27 PM, Daniel Mack wrote: On 10/09/2013 10:14 PM, Joel Fernandes wrote: On 10/09/2013 09:12 AM, Joel Fernandes wrote: On 10/09/2013 02:38 AM, Daniel Mack wrote: [..] (And the 'v3' in the subject is really my bad, sorry - I only sent one version of this patch ever)

[PATCH 1/4] usb: chipidea: msm: Add device tree binding information

2013-11-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/usb/msm-hsusb.txt | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/

[PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver

2013-11-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This series intend to fixup driver, which was broken for a while. It is used to create peripheral role device, which in coordination with phy-usb-msm driver (still some cleanups pending) will provide again USB2.0 gadget support for MSM targets. Generated

[PATCH 3/4] usb: chipidea: msm: Initialize offset of the capability registers

2013-11-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 747d6c1..e9624f3 100644 --- a/drivers/usb/chipidea/ci_

[PATCH 2/4] usb: chipidea: msm: Add device tree support

2013-11-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov Cc: devicet...@vger.kernel.org --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1 file changed, 22 insert

[PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-11-11 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drive

Re: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-11-11 Thread Ivan T. Ivanov
Hi Peter, On Mon, 2013-11-11 at 21:59 +0800, Peter Chen wrote: > On Mon, Nov 11, 2013 at 03:35:37PM +0200, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > PHY drivers keep track of the current state of the hardware, > > so don't change PHY

Re: [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver

2013-11-11 Thread Ivan T. Ivanov
Hi Peter, On Mon, 2013-11-11 at 22:02 +0800, Peter Chen wrote: > On Mon, Nov 11, 2013 at 03:35:33PM +0200, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Hi, > > > > This series intend to fixup driver, which was broken for a while. It is

[PATCH v4 13/15] usb: phy: msm: Correct USB PHY Reset sequence for newer platform

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" On few legacy platforms, USB PHY is having dedicated reset clk. It is used to reset USB PHY after putting USB PHY into low power mode and for calibration of USB PHY. Putting USB PHY into low power mode is causing ulpi read/write timeout as expected. USB PHY re

[PATCH v4 15/15] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" New platform uses RBCPR hardware feature, with that voting for absolute voltage of VDD CX is not required. Hence vote for corner of VDD CX which uses nominal corner voltage on VDD CX. Signed-off-by: Ivan T. Ivanov Cc: Mayank Rana Cc: devicet...@vger.

[PATCH v4 09/15] usb: phy: msm: Properly check result from platform_get_irq()

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Function return negative code on error. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 258bca2..fa8e6

[PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work with any of the two HSPHYs present. By default driver configures USB core to use primary HSPHY. Add support to allow user select 2nd HSPHY using DT

[PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch fix compilation error when driver is compiled in multi-platform builds. drivers/built-in.o: In function `msm_otg_link_clk_reset': ./drivers/usb/phy/phy-msm-usb.c:314: undefined reference to `clk_reset' ./drivers/usb/phy/phy-msm-usb.c:318: un

[PATCH v4 05/15] usb: phy: msm: Fix checkpatch.pl warnings

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: quoted string split across lines WARNING: Prefer seq_puts to seq_printf Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 39 ++- 1 file changed, 14 insertions(+), 25

[PATCH v4 14/15] usb: phy: msm: Handle disconnect events

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Put the transceiver in non-driving mode. Otherwise host may not detect soft-disconnection. Signed-off-by: Ivan T. Ivanov Cc: Pavankumar Kondeti --- drivers/usb/phy/phy-msm-usb.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drive

[PATCH v4 11/15] usb: phy: msm: Use reset framework for LINK and PHY resets

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/usb/msm-hsusb.txt |9 ++ drivers/usb/phy/phy-msm-usb.c | 30 ++-- include/linux/usb/msm_hsusb.h

[PATCH v4 02/15] usb: phy: msm: Move global regulators variables to driver state

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 - include/linux/usb/msm_hsusb.h |3 ++ 2 files changed, 42 insertions(+), 43 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/u

[PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, Patches have been tested on top of Stephen's clock controller patches[1] and recent fixes for chipidea msm glue layer driver posted here[2]. Hardware platform AP8074 DragonBoard. Only gadget mode utilized for now. CV Test Suite engine "Chapter

[PATCH v4 08/15] usb: phy: msm: Remove HSUSB prefix from regulator names

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Currently none of the MSM platforms define these regulators, so it is safe to rename them. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH v4 04/15] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v4 10/15] usb: phy: msm: Add device tree support and binding information

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows MSM OTG controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/usb/msm-hsusb.txt | 57 +- drivers/usb/phy/phy-msm-usb.c

[PATCH v4 06/15] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan

[PATCH v4 03/15] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 192 - 1 file changed, 74 insertions(+), 118

[PATCH v4 07/15] usb: phy: msm: Remove unused pclk_src_name

2013-11-12 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h |5 - 2 files changed, 1 insert

Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

2013-11-12 Thread Ivan T. Ivanov
Hi Christopher, On Tue, 2013-11-12 at 13:27 -0500, Christopher Covington wrote: > Hi Ivan, > > On 11/12/2013 09:51 AM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This patch fix compilation error when driver is compiled > > in multi-p

Re: [PATCH v4 10/15] usb: phy: msm: Add device tree support and binding information

2013-11-18 Thread Ivan T. Ivanov
Hi Mark, On Fri, 2013-11-15 at 16:38 +, Mark Rutland wrote: > On Tue, Nov 12, 2013 at 02:51:45PM +, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Allows MSM OTG controller to be specified via device tree. > > > > Sig

Re: [PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control

2013-11-18 Thread Ivan T. Ivanov
Hi Mark, On Fri, 2013-11-15 at 16:42 +, Mark Rutland wrote: > On Tue, Nov 12, 2013 at 02:51:47PM +, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Allow support to use 2nd HSPHY with USB2 Core. > > Some platforms may have configuration

Re: [PATCH 1/4] usb: chipidea: msm: Add device tree binding information

2013-12-04 Thread Ivan T. Ivanov
Hi Peter, Thank you for reviewing this patch. On Wed, 2013-12-04 at 13:40 +0800, Peter Chen wrote: > On Mon, Nov 11, 2013 at 03:35:34PM +0200, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Please add something in commit log > > > Signed

Re: [PATCH 3/4] usb: chipidea: msm: Initialize offset of the capability registers

2013-12-04 Thread Ivan T. Ivanov
On Wed, 2013-12-04 at 13:43 +0800, Peter Chen wrote: > On Mon, Nov 11, 2013 at 03:35:36PM +0200, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > The commit log is needed. Will fix it. Regards, Ivan > > > Signed-off-by: Ivan T. I

Re: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-12-04 Thread Ivan T. Ivanov
Hi Peter, On Wed, 2013-12-04 at 13:37 +0800, Peter Chen wrote: > On Mon, Nov 11, 2013 at 04:36:09PM +0200, Ivan T. Ivanov wrote: > > > > Hi Peter, > > > > On Mon, 2013-11-11 at 21:59 +0800, Peter Chen wrote: > > > On Mon, Nov 11, 2013 at 03:35:37PM +0200

Re: [PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control

2013-12-11 Thread Ivan T. Ivanov
Hi, On Thu, 2013-12-05 at 10:42 +, Mark Rutland wrote: > On Mon, Nov 18, 2013 at 12:57:42PM +, Ivan T. Ivanov wrote: > > > > Hi Mark, > > > > On Fri, 2013-11-15 at 16:42 +, Mark Rutland wrote: > > > On Tue, Nov 12, 2013 at 02:51:47PM +

Re: [PATCH v4 10/15] usb: phy: msm: Add device tree support and binding information

2013-12-11 Thread Ivan T. Ivanov
Hi, On Thu, 2013-12-05 at 10:41 +, Mark Rutland wrote: > On Mon, Nov 18, 2013 at 12:54:37PM +, Ivan T. Ivanov wrote: > > Hi Mark, > > > > On Fri, 2013-11-15 at 16:38 +, Mark Rutland wrote: > > > On Tue, Nov 12, 2013 at 02:51:45PM +, Ivan T. Ivano

Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

2013-12-11 Thread Ivan T. Ivanov
On Tue, 2013-11-12 at 16:51 +0200, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This patch fix compilation error when driver is compiled > in multi-platform builds. > > drivers/built-in.o: In function `msm_otg_link_clk_reset': > ./drivers/usb/phy/ph

Re: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-12-11 Thread Ivan T. Ivanov
Hi, On Wed, 2013-12-04 at 21:38 +0800, Peter Chen wrote: > On Wed, Dec 04, 2013 at 11:35:54AM +0200, Ivan T. Ivanov wrote: > > > > Hi Peter, > > > > On Wed, 2013-12-04 at 13:37 +0800, Peter Chen wrote: > > > On Mon, Nov 11, 2013 at 04:36:09PM +0200, Ivan

Re: usb sound issue - any ideas?

2012-07-09 Thread dieter.jurzi...@t-online.de
Dear Sarah, dear Andiry, thank you very much for your inputs. If you, Sarah, could be a little more precise for a (nearly ) non programmer what you'd like to see in terms of code lines (WARN_ON(), but where ...) I could apply a corresponding patch and would gladly provide anything my kernel

[PATCH v2 3/3] usb: chipidea: msm: Initialize offset of the capability registers

2014-02-18 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Since commit 62bb84e (usb: gadget: ci13xxx: convert to platform device) start address of the capability registers is not passed correctly to udc_probe(). Fix this. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c |1 + 1 file changed, 1

[PATCH v2 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-02-18 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This series intend to fix driver, which was broken for a while. It is used to create peripheral role device, which in coordination with phy-usb-msm driver will provide USB2.0 gadget support for Qualcomm targets. Changes since initial version. - Addres

[PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Ivan T. Ivanov
Hi, On Tue, 2014-02-18 at 20:53 +0300, Sergei Shtylyov wrote: > Hello. > > On 02/18/2014 04:21 PM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > Allows controller to be specified via device tree. > > Pass PHY phandle specified in DT t

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Ivan T. Ivanov
On Tue, 2014-02-18 at 08:08 -0600, Josh Cartwright wrote: > Hey Ivan- > > Nit below. > > On Tue, Feb 18, 2014 at 03:21:20PM +0200, Ivan T. Ivanov wrote: > > > > +static struct of_device_id msm_ci_dt_match[] = { > > const? > Thanks, will do. Regards, Iv

Re: [PATCH v2 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-02-19 Thread Ivan T. Ivanov
Hi, I will need some time to recreate USB test environment. I will come back when I am ready. Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: [PATCH v2 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-02-19 Thread Ivan T. Ivanov
Hi Tim, On Tue, 2014-02-18 at 22:21 -0800, Tim Bird wrote: > Ivan, > > I'm having tremendous problems getting this driver to initialize. For > some reason, I can't get the driver to actually transition the > hardware into peripheral mode. At first I was getting a lot of probe > deferrals, ba

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-19 Thread Ivan T. Ivanov
Hi, On Tue, 2014-02-18 at 21:31 +0300, Sergei Shtylyov wrote: > On 02/18/2014 08:14 PM, Ivan T. Ivanov wrote: > > >>> From: "Ivan T. Ivanov" > > >>> Allows controller to be specified via device tree. > >>> Pass PHY phandle specifi

[PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Document device tree binding information as required by the Qualcomm USB controller. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/

RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Ivan T. Ivanov
On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote: > > +CI13xxx (Chipidea) USB controllers > > + > > +Required properties: > > +- compatible: should contain "qcom,ci-hdrc" > > +- reg: offset and length of the register set in the memory map > > +- interrupts: interrupt-specifier for

[PATCH v5 04/14] usb: phy: msm: Fix checkpatch.pl warnings

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: quoted string split across lines WARNING: Prefer seq_puts to seq_printf Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 39 ++- 1 file changed, 14 insertions(+), 25

[PATCH v5 01/14] usb: phy: msm: Move global regulators variables to driver state

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 - include/linux/usb/msm_hsusb.h |3 ++ 2 files changed, 42 insertions(+), 43 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/u

[PATCH v5 13/14] usb: phy: msm: Handle disconnect events

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Put the transceiver in non-driving mode. Otherwise host may not detect soft-disconnection. Signed-off-by: Ivan T. Ivanov Cc: Pavankumar Kondeti --- drivers/usb/phy/phy-msm-usb.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drive

[PATCH v5 14/14] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" New platform uses RBCPR hardware feature, with that voting for absolute voltage of VDD CX is not required. Hence vote for corner of VDD CX which uses nominal corner voltage on VDD CX. Signed-off-by: Ivan T. Ivanov Cc: Mayank Rana --- .../devicetree/bindin

[PATCH v5 03/14] usb: phy: msm: Remove unnecessarily check for valid regulators.

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v5 09/14] usb: phy: msm: Add device tree support and binding information

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows MSM OTG controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 67 drivers/usb/phy/phy-msm-usb.c | 108 include

[PATCH v5 12/14] usb: phy: msm: Correct USB PHY Reset sequence for newer platform

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" On few legacy platforms, USB PHY is having dedicated reset clk. It is used to reset USB PHY after putting USB PHY into low power mode and for calibration of USB PHY. Putting USB PHY into low power mode is causing ulpi read/write timeout as expected. USB PHY re

[PATCH v5 11/14] usb: phy: msm: Add support for secondary PHY control

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work with any of the two HSPHYs present. By default driver configures USB core to use primary HSPHY. Add support to allow user select 2nd HSPHY using DT

[PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is a fifth version of patches posted earlier here [1]. They have been tested on AP8074 DragonBoard. Only gadget mode utilized for now. CV Test Suite engine "Chapter 9 tests" are passing except "Halt Endpoint Test". usbtest driver

[PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 30 ++ include/linux/usb/msm_hsusb.h |3 +++ 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy

[PATCH v5 02/14] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 192 - 1 file changed, 74 insertions(+), 118

[PATCH v5 05/14] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T

[PATCH v5 06/14] usb: phy: msm: Remove unused pclk_src_name

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h |5 - 2 files changed, 1 insert

[PATCH v5 07/14] usb: phy: msm: Remove HSUSB prefix from regulator names

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Currently none of the MSM platforms define these regulators, so it is safe to rename them. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH v5 08/14] usb: phy: msm: Properly check result from platform_get_irq()

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Function return negative code on error. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index c2048c7..31fb

Re: [PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-03-06 Thread Ivan T. Ivanov
On 03/05/14 14:34, Sergei Shtylyov wrote: > Hello. > >> --- a/drivers/usb/phy/phy-msm-usb.c >> +++ b/drivers/usb/phy/phy-msm-usb.c > [...] >> @@ -235,12 +236,16 @@ static void ulpi_init(struct msm_otg *motg) >> >> static int msm_otg_link_clk_reset(struct msm_otg *motg, bool assert) >> { >>

Re: [PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support

2014-03-08 Thread Ivan T. Ivanov
Hi, On 03/08/2014 02:15 AM, Felipe Balbi wrote: > On Wed, Mar 05, 2014 at 05:54:03PM -0800, Tim Bird wrote: >> Ivan, >> >> I'm still unsuccessful at getting this patch set to work on my kernel. >> See regs in dmesg log > > never got any reply to this, nor got a response to Sergei's comments. >

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Ivan T. Ivanov
Hi, On Wed, 2014-03-26 at 12:15 -0500, Felipe Balbi wrote: > > > ps: can you guys, please, just send your dwc3 glue layer ? :-) > > > > Ivan Ivanov (cc'ed) had sent a number of patches for our "dwc3-msm" > > layer to the list for review, but I think they were still held up in the > > feedback p

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Ivan T. Ivanov
On Thu, 2014-03-27 at 09:58 -0500, Felipe Balbi wrote: > On Thu, Mar 27, 2014 at 04:03:08PM +0200, Ivan T. Ivanov wrote: > > > > Hi, > > > > On Wed, 2014-03-26 at 12:15 -0500, Felipe Balbi wrote: > > > > > ps: can you guys, please, just send your d

<    1   2   3   4   >