Re: Ehci-hcd kernel driver and ALi chipset doesn't work.

2008-01-11 Thread T.
5253 P1394 OHCI 1.1 Controller More detailed 00:00.0 Host bridge: Intel Corporation 82830 830 Chipset Host Bridge (rev 02) Subsystem: IBM ThinkPad A/T/X Series Flags: bus master, fast devsel, latency 0 Memory at d000 (32-bit, prefetchable) [size=256M] Capabil

Re: Ehci-hcd kernel driver and ALi chipset doesn't work.

2008-01-12 Thread T.
--- David Brownell <[EMAIL PROTECTED]> wrote: > So ... did you verify that not using the external > power > supply *was* causing the problem? > ... > > In this case I can only report what I observed: > that > EHCI in a CardBus format needed extra power. > ... I have attached the power supp

"Buggy kernel device driver?" for Super Top M6116 SATA Bridge (14cd:6116)

2013-12-02 Thread Jaime T
Hi folks. When I run "hdparm -N /dev/sdb" on my cheapo usb-connect sata bridge (Super Top M6116 SATA Bridge , device id 14cd:6116), it returns: /dev/sdb: max sectors = 1953525168/1(1953525168?), HPA setting seems invalid (buggy kernel device driver?) FWIW, I'm running Debian Testing - I origi

Linux xHCI driver problems

2012-09-24 Thread Yuliya T
Dear Sarah, We noticed a couple of problems with the Linux xHCI driver: 1. There is a problem with URB cancellation for USB 2.0 device on USB 3.0 host. When we disable our device, we cancel all pending URBs by calling ioctl with the request code of USBDEVFS_DISCARDURB. When we re-enable our devi

Re: Linux xHCI driver problems (reset ep)

2012-10-02 Thread Yuliya T
Hi Sarah, >> 2. Clear Halt of EP > > Also note that the xHCI hardware will only allow the Reset Endpoint to > complete if the endpoint was actually halted due to a stall, babble, > transfer error, etc. It won't reset the endpoint toggles or sequence > number at arbitrary points, so we can't reset

Re: Linux xHCI driver problems (reset ep)

2012-10-12 Thread Yuliya T
u are releasing access to the device just to keep using it. While it is unlikely that we will have some other process come in and grab the interface, it still just strikes us as unclean. Yuliya On Wed, Oct 3, 2012 at 8:13 AM, Alan Stern wrote: > On Tue, 2 Oct 2012, Yuliya T wrote: > >&

Re: Linux xHCI driver problems (reset ep)

2012-10-17 Thread Yuliya T
Hi Alan and Sarah, I confirmed that simply calling usb_set_altinterface (which via libusb calls the kernel function usb_set_interface) does correctly clear the toggle bits for USB2 or sequence number for USB3 on an XHCI host controller, even when the alternate interface setting is the same as the

Re: Sequence number not incremented for large control transfer

2012-10-17 Thread Yuliya T
l for these transactions. Thanks. Yuliya On Tue, Oct 2, 2012 at 5:23 PM, Yuliya T wrote: > We ran into a problem when using ASMedia Technology Inc. ASM1042 > SuperSpeed USB Host Controller (integrated on the desktop's > motherboard) with Linux xHCI driver. The host is sending the &g

Re: Linux xHCI driver problems (URB cancellation)

2012-10-17 Thread Yuliya T
ernel debugging turned on). Thanks, Yuliya On Tue, Oct 2, 2012 at 5:09 PM, Yuliya T wrote: > Hi Sarah, > >>> Re: URB Cancellation for USB 2.0 device on xHCI host >> >> Which host controller are you running under? Please send the output of >> `sudo lspci -vvv` and `sudo

Re: UAS errors with Jmicron

2014-09-07 Thread Laszlo T.
2014-08-04 20:07 GMT+02:00 Hans de Goede : > Hi Laszlo, > > On 08/03/2014 12:40 AM, Laszlo T. wrote: >>>>>>> *) usb devices return different descriptors at different speeds >>>>>> >>>>>> All tests were on usb2. >>>&g

UAS errors with Jmicron

2014-07-28 Thread Laszlo T.
Hello, I have some problems with Jmicron JMS567 (Sata 6 Gb/s -> USB3.0) mobile rack. I tried on different kernels: 3.15.5 3.16.rc6 I got the following errors when I ran a mkfs.ext4 command and then the device disappeared. Jul 26 19:54:37 debian kernel: [ 118.060026] usb 8-3: new high-speed USB

Re: UAS errors with Jmicron

2014-07-28 Thread Laszlo T.
I have some problems with Jmicron JMS567 (Sata 6 Gb/s -> USB3.0) >>> mobile rack. I tried on different kernels: 3.15.5 3.16.rc6 I got the following errors when I ran a mkfs.ext4 command and then >>> the device disappeared. Jul 26 19:54:37 debian ker

Re: UAS errors with Jmicron

2014-07-28 Thread Laszlo T.
> Laszlo, you can try specifying the "quirks=152d:0567:u" module > parameter for usb-storage. I don't know if that will help, but it > might. > >> What can the problem be? > > There's no way to tell from just this information. > Unfortunately it did not help. Is there any other information you ne

Re: UAS errors with Jmicron

2014-07-29 Thread Laszlo T.
Hello, >> I don't think it is a power issue. >> I'm using on desktop PC on usb2 port with just a simple cable but the >> disk (WD5000LPVX) only consumes 1.4 Watts (read/write) and it is >> stable on Windows. > > http://www.wdc.com/wdproducts/library/SpecSheet/ENG/2879-771437.pdf > > Says it uses 1

Re: UAS errors with Jmicron

2014-07-29 Thread Laszlo T.
> > A usbmon trace might be useful. See Documentation/usb/usbmon.txt in > the kernel source for instructions. > > Alan Stern > Hello, I ran some commands and recorded them: -checking with cfdisk -mounting the ntfs partition -some reading on it -unmounting -and the unsuccessful ext4 filesystem cr

Re: UAS errors with Jmicron

2014-07-30 Thread Laszlo T.
>> > Disconnection issues like you are seeing are typical for drawing >> > too much power from the port. Using uas as the dmesg shows you >> > are will allow us to send more commands to the disk at once >> > (which is a good thing, it is faster) and as such will increase >> > power consumption. >>

Re: UAS errors with Jmicron

2014-07-31 Thread Laszlo T.
2014-07-31 9:54 GMT+02:00 Oliver Neukum : > On Thu, 2014-07-31 at 00:39 +0200, Laszlo T. wrote: >> >> > Disconnection issues like you are seeing are typical for drawing >> >> > too much power from the port. Using uas as the dmesg shows you >> >> >

Re: UAS errors with Jmicron

2014-07-31 Thread Laszlo T.
2014-07-31 12:53 GMT+02:00 Hans de Goede : > Hi, > > On 07/31/2014 12:39 AM, Laszlo T. wrote: >>>>> Disconnection issues like you are seeing are typical for drawing >>>>> too much power from the port. Using uas as the dmesg shows you >>>>>

Re: UAS errors with Jmicron

2014-07-31 Thread Laszlo T.
I tested with lot of values. I'm not totally sure but it looks the 31 is max number where it is still stable to create an ext4 filesystem. >>> >>> Thanks, that is good to know. Can you try the following patch instead >>> of changing can_queue ? : >>> >>> diff --git a/drivers/usb/sto

Re: UAS errors with Jmicron

2014-07-31 Thread Laszlo T.
2014-07-31 16:16 GMT+02:00 Hans de Goede : > Hi, > > On 07/31/2014 03:51 PM, Laszlo T. wrote: >>>>>> >>>>>> I tested with lot of values. I'm not totally sure but it looks the 31 >>>>>> is max number where it is still stable to

Re: UAS errors with Jmicron

2014-08-02 Thread Laszlo T.
> *) usb devices return different descriptors at different speeds All tests were on usb2. I don't have usb3 ports but I will try that at weekend. I'm curious now, am I the first one who has ever tested uas on usb2? >>> >>> Ni, I've tested it myself too, including runnin

USB kernel debug

2016-05-16 Thread Brian T. McKee
I sent a message to the group yesterday, but I suspect it was too big for it's own good and didn't make it to the list. I'm attempting to debug a USB problem where multiple UVC camera causes the USB driver to crash and shut down. All *HCI devices stop working. I managed to get a USB serial port u

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
gdb access? Thanks again, Brian On 05/16/16 12:52, Alan Stern wrote: > On Mon, 16 May 2016, Brian T. McKee wrote: > >> I sent a message to the group yesterday, but I suspect it was too big >> for it's own good and didn't make it to the list. > It did; I saw it. >

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
[ 8071.052467] RSP [ 8071.052468] ---[ end trace 61566651c88f6b62 ]--- If you think of any more information I should look at, just mention it. Thanks. Brian On 05/16/16 12:52, Alan Stern wrote: > On Mon, 16 May 2016, Brian T. McKee wrote: > >> I sent a message to the group yesterday

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
the bad behavior to a single cause. I can still get good captures, albeit randomly after many crashes and segfaults of gstreamer. On 05/16/16 14:20, Greg KH wrote: > On Mon, May 16, 2016 at 02:09:03PM -0700, Brian T. McKee wrote: >> I just noticed that timing matters. If I bring the US

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Here's another crash. I include discovery of the hubs, cameras and even the logitech keyboard and mouse wireless dongle. [ 2158.726264] usb 1-1: new full-speed USB device number 48 using xhci_hcd [ 2158.893384] usb 1-1: New USB device found, idVendor=046d, idProduct=c52b [ 2158.893386] usb 1-1: Ne

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Can you make a recommendation? Is there one you trust? On 05/16/16 16:19, Greg KH wrote: > On Mon, May 16, 2016 at 03:49:55PM -0700, Brian T. McKee wrote: >> Thanks Greg. It is a powered USB hub. The supplies have 2.5 amps to >> spread across three cameras. One of the hub'

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
On 05/16/16 17:56, Greg KH wrote: > I recommend any of the hubs recommended here: > http://thewirecutter.com/reviews/best-usb-hubs/ > > Thanks Greg. I'm using the Sabrent HB-UMP3 which I would hope is related to or derived from the Sabrent they mention in thewirecutter article. -- To un

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
gt; On Mon, May 16, 2016 at 04:58:46PM -0700, Brian T. McKee wrote: >> Can you make a recommendation? Is there one you trust? > I recommend any of the hubs recommended here: > http://thewirecutter.com/reviews/best-usb-hubs/ > > and have both the 7 and 10 port recomm

[PATCH] usb: storage: onetouch: Fixed two space related coding style issues

2016-01-22 Thread Tapan Prakash T
This patch fixes checkpatch.pl warning in file onetouch.c Signed-off-by: Tapan Prakash T --- drivers/usb/storage/onetouch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c index acc3d03..9097bd4 100644 --- a

unable to handle kernel NULL pointer dereference at usb_audio_probe

2016-03-24 Thread Ian T. Jacobsen
[ 21.434822] BUG: unable to handle kernel NULL pointer dereference at 0014 [ 21.435516] IP: [] usb_audio_probe+0x2ca/0x9a0 [snd_usb_audio] I have a PreSonus AudioBox iTwo causing this issue. I updated from torvalds git yesterday dmesg.output Description: Binary data

Re: unable to handle kernel NULL pointer dereference at usb_audio_probe

2016-03-25 Thread Ian T. Jacobsen
check in the patch now never passes, media_snd_device_create is never reached. On Thu, Mar 24, 2016 at 1:45 PM, Greg KH wrote: > On Thu, Mar 24, 2016 at 01:34:32PM +, Ian T. Jacobsen wrote: >> [ 21.434822] BUG: unable to handle kernel NULL pointer dereference at >> 001

[PATCH] usb: phy: msm: Move mach depndend code to platform data

2013-06-21 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch fix compilation error and is an intermediate step before the addition of DeviceTree support for newer targets. Fix suggested here: https://lkml.org/lkml/2013/6/19/381 Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman Cc: Felipe Balbi Cc:

[PATCH 7/7] usb: phy: msm: Lindent the code

2013-06-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 99 ++--- 1 file changed, 52 insertions(+), 47

[PATCH 6/7] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf

2013-06-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-06-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch move global regulators variables to driver state structire and move allocation of the regulators to be devm managed. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan

[PATCH 5/7] usb: phy: msm: Fix WARNING: quoted string split across lines

2013-06-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 33 +++-- 1 file c

[PATCH 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-06-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 78 +++-- 1 file changed, 20 insertions(+), 58

[PATCH 4/7] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-06-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org

[PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use managed device resources to clean up the probe/remove and get DT support for free. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 78 +++-- 1 file changed, 20 insertions(+), 58 deletions(-) di

[PATCH v2 7/7] usb: phy: msm: Lindent the code

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 99 ++--- 1 file changed, 52 insertions(+), 47 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 6d05085..111f

[PATCH v2 4/7] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v2 0/7] usb: phy: msm: Fixes and cleanups

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Changes since first version. * Extend commit messages a little bit. Following patches make initial cleanup of usb phy found in the Qualcomm chipsets. Changes include: * Build time error fix. * Move driver to Managed Device Resource allocation. * Checkpatch wa

[PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch move global regulators variables to driver state structire and move allocation of the regulators to be devm managed. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 111 +++-- include

[PATCH v2 5/7] usb: phy: msm: Fix WARNING: quoted string split across lines

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy

[PATCH v2 6/7] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 41938e6..6d05

[PATCH v2 1/7] usb: phy: msm: Move mach depndend code to platform data

2013-07-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch fix compilation error and is an intermediate step before the addition of DeviceTree support for newer targets. Fix suggested here: https://lkml.org/lkml/2013/6/19/381 Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman Cc: Stephen Boyd Signed-of

Re: [PATCH v2 0/7] usb: phy: msm: Fixes and cleanups

2013-07-16 Thread Ivan T. Ivanov
Hi Felipe, On Tue, 2013-07-09 at 18:47 +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Changes since first version. > * Extend commit messages a little bit. > > Following patches make initial cleanup of usb phy found in the Qualcomm > chipsets. Change

Re: [PATCH 7/7] usb: phy: msm: Lindent the code

2013-07-25 Thread Ivan T. Ivanov
Hi, On Wed, 2013-07-24 at 15:22 +0300, Felipe Balbi wrote: > On Mon, Jun 24, 2013 at 06:27:44PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Cc: Felipe Balbi > > Cc: Greg Kroah-Hartman > > Cc: linux-usb@vger.kernel.org > >

Re: [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-07-25 Thread Ivan T. Ivanov
Hi, On Wed, 2013-07-24 at 15:38 +0300, Felipe Balbi wrote: > Hi, > > On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Use managed device resources to clean up the probe/remove > > and get DT suppo

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-25 Thread Ivan T. Ivanov
On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi wrote: > On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This patch move global regulators variables to driver state > > structire and move allocation

[PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving the above operations after driver hold al

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
On Thu, 2013-07-25 at 21:21 +0400, Sergei Shtylyov wrote: > On 07/25/2013 08:26 PM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > When deferred probe happens driver will try to ioremap multiple times > > and will fail. Memory resourc

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
Hi, On Fri, 2013-07-26 at 02:06 +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Thursday, July 25, 2013 1:52 PM > > > > On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > >

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-26 Thread Ivan T. Ivanov
Hi Felipe, On Thu, 2013-07-25 at 16:43 +0300, Ivan T. Ivanov wrote: > On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi wrote: > > On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > > > This patch mo

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-26 Thread Ivan T. Ivanov
On Fri, 2013-07-26 at 23:28 +0300, Felipe Balbi wrote: > On Fri, Jul 26, 2013 at 03:31:34PM +0300, Ivan T. Ivanov wrote: > > > > Hi Felipe, > > > > On Thu, 2013-07-25 at 16:43 +0300, Ivan T. Ivanov wrote: > > > On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi

[PATCH v2 2/6] usb: phy: msm: move global regulators variables to driver state

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 - include/linux/usb/msm_hsusb.h |3 ++ 2 files changed, 42 insertions(+), 43 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/u

[PATCH v2 4/6] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v2 0/6] usb: phy: msm: Fixes and cleanups

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" v2 -- * Fix compilation issue in patch 1 * Separate regulator changes * Merge devm_ related changes to one commit * Drop Lindent patch v1 -- Following patches make initial cleanup of usb phy found in the Qualcomm chipsets. Changes include: * Build time error f

[PATCH v2 5/6] usb: phy: msm: Fix WARNING: quoted string split across lines

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy

[PATCH v2 3/6] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 188 - 1 file changed, 71 insertions(+), 117

[PATCH v2 6/6] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes checkpatch.pl warnings. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 118bd0a..e370

[PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This patch fix compilation error and is an intermediate step before the addition of DeviceTree support for newer targets. Fix suggested here: https://lkml.org/lkml/2013/6/19/381 Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman Cc: Felipe Balbi Cc:

[PATCH v2] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-29 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving the above operations after driver hold al

Re: [PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data

2013-07-29 Thread Ivan T. Ivanov
Hi, > > Cc: Bryan Huntsman > > Cc: Felipe Balbi > > Cc: Greg Kroah-Hartman > > Cc: linux-arm-ker...@lists.infradead.org > > Cc: linux-ker...@vger.kernel.org > > Cc: linux-usb@vger.kernel.org > > > > Signed-off-by: Ivan T. Ivanov >

[RFC 0/2] DWC3 USB support for Qualcomm platform

2013-08-06 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, These patches add basic support for USB3.0 controllers found on MSM platforms. First patch add 2 USB PHY drivers and second one add support for Qualcomm wrapper IP over DWC3 controller. Patches are just skeletons, no power management. DWC3 IP in MSM al

[RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-ssusb.txt | 39 + drivers/usb/dwc3/Kconfig |8 + drivers/usb/dwc3/Makefile |1 + drivers/usb/dwc3/

[RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-ssusb.txt | 49 +++ drivers/usb/phy/Kconfig| 11 + drivers/usb/phy/Makefile |2 + drivers/usb/phy/phy-msm-d

Re: [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-06 at 13:12 +0100, Pawel Moll wrote: > On Tue, 2013-08-06 at 12:53 +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Signed-off-by: Ivan T. Ivanov > > I am sure that the information in the subject is more than enough

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
On Tue, 2013-08-06 at 13:21 +0100, Pawel Moll wrote: > On Tue, 2013-08-06 at 12:53 +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Signed-off-by: Ivan T. Ivanov > > The same comment as for the RFC 1/2 here... Will fix this. > > &

Re: [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-06 at 15:03 +0100, Mark Rutland wrote: > On Tue, Aug 06, 2013 at 12:53:10PM +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Signed-off-by: Ivan T. Ivanov > > --- > > .../devicetree/bindings/usb/msm-ssusb.txt

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-06 at 15:07 +0100, Mark Rutland wrote: > On Tue, Aug 06, 2013 at 12:53:11PM +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > What does the "glue layer" do? Is it an actual piece of hardware, or > just some platform-specific

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
On Tue, 2013-08-06 at 16:15 +0100, Pawel Moll wrote: > On Tue, 2013-08-06 at 14:46 +0100, Ivan T. Ivanov wrote: > > > > + reg = <0xf920 0xcd00>; > > > > + interrupts = <0 131 0>; > > >

[RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov --- drivers/usb/dwc3/Kconfig|8 ++ d

[RFC PATCH v2 0/3] DWC3 USB support for Qualcomm platform

2013-08-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, These patches add basic support for USB3.0 controllers found on MSM platforms. USB3.0 core is based on Synopsys DesignWare SuperSpeed IP. Changes since first version: * Split devicetree bindings description file to separate patch * Address comments

[RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) and HS, SS PHY's controll and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/us

[RFC PATCH v2 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-09 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig

Re: [RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-09 at 16:32 +0300, Felipe Balbi wrote: > On Fri, Aug 09, 2013 at 12:53:47PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > DWC3 glue layer is hardware layer around Synopsys DesignWare > > USB3 core. Its purpose i

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: > Hi, > > On Tue, Aug 06, 2013 at 02:53:11PM +0300, Ivan T. Ivanov wrote: > > diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c > > new file mode 100644 > > index 000..e509abc > >

Re: [PATCH v2 3/6] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-08-12 Thread Ivan T. Ivanov
Hi, On Mon, 2013-07-29 at 15:25 +0300, Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 10:04:21AM +0300, Ivan T. Ivanov wrote: > > motg->irq = platform_get_irq(pdev, 0); > > - if (!motg->irq) { > > + if (motg->irq < 0) { > > looks lik

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-13 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-09 at 10:31 -0500, Kumar Gala wrote: > On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) > > probably good to spell out Synopsys rather t

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-13 Thread Ivan T. Ivanov
Hi, On Mon, 2013-08-12 at 13:04 -0500, Felipe Balbi wrote: > On Fri, Aug 09, 2013 at 10:31:58AM -0500, Kumar Gala wrote: > > > > On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote: > > > > > From: "Ivan T. Ivanov" > > > > &g

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-14 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-13 at 13:57 -0600, Stephen Warren wrote: > On 08/09/2013 03:53 AM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) > > and HS, SS PHY's controll and configuration regi

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-14 Thread Ivan T. Ivanov
Hi, On Mon, 2013-08-12 at 13:24 -0500, Felipe Balbi wrote: > On Fri, Aug 09, 2013 at 07:09:18PM +0300, Ivan T. Ivanov wrote: > > Hi, > > > > On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Aug 06

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-14 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: > > > + /* > > +* DWC3 Core requires its CORE CLK (aka master / bus clk) to > > +* run at 125Mhz in SSUSB mode and >60MHZ for HSUSB mode. > > +*/ > > + clk_set_rate(mdwc->core_clk, 12500); > > if this is dwc3's co

[PATCH v3 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov --- drivers/usb/dwc3/Kconfig|8 ++ d

[PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov --- .../devicetree/b

[PATCH v3 0/3] DWC3 USB support for Qualcomm platform

2013-08-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, These patches add basic support for USB3.0 controllers found on MSM platforms. USB3.0 core is based on Synopsys DesignWare SuperSpeed IP. Changes since v2: * Several improvements in devicetree bindings description * Disable regulators in glue layer i

[PATCH v3 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-14 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig

Re: [PATCH v3 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-14 Thread Ivan T. Ivanov
Hi, On Wed, 2013-08-14 at 09:20 -0500, Josh Cartwright wrote: > On Wed, Aug 14, 2013 at 03:59:42PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > These drivers handles control and configuration of the HS > > and SS USB PHY transceivers.

Re: [PATCH v3 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-14 Thread Ivan T. Ivanov
On Wed, 2013-08-14 at 09:06 -0700, Stephen Boyd wrote: > On 08/14/13 05:59, Ivan T. Ivanov wrote: > > +} > > + > > +static const struct of_device_id of_dwc3_matach[] = { > > match? Maybe you can make it all one line too { .compatible = "qcom,dw

Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-19 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-16 at 16:44 -0600, Stephen Warren wrote: > On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > > (SNPS) and HS, SS PHY's control and

[PATCH v4 0/3] DWC3 USB support for Qualcomm platform

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, Here is fourth version of MSM USB3 drivers patches. Changes since v3: * Remove "_clk" suffix from clock names * Clarify required child node for qcom,dwc3 * Fix comments in functions headers * Use dbg instead err in drivers probe function

[PATCH v4 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov --- .../devicetree/b

[PATCH v4 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov --- drivers/usb/dwc3/Kconfig|8 +++ d

[PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-20 at 07:29 -0500, Felipe Balbi wrote: > Hi, > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > These drivers handles control and configuration of the HS > > and SS USB PH

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: > Hi, > > On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" > >

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > > Hi, > > > > On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Aug 20

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
On Tue, 2013-08-20 at 10:01 -0500, Kumar Gala wrote: > On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > > > > Hi, > > > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > >> On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote:

  1   2   3   4   >