Re: [RFC PATCH 3/6] usb: otg: utils: change the phy lib to support multiple PHYs of same type

2013-01-16 Thread Simon Horman
jay Abraham I > --- > arch/arm/mach-shmobile/board-marzen.c |2 +- Modification to the above file: Acked-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy: Remove unused Renesas R-Car (Gen1) USB PHY driveer

2015-12-06 Thread Simon Horman
1 SoCs, but that would > require adding DT support to the driver. Instead, a new driver using the > generic PHY framework should be written, as was done for R-Car Gen2. > > Remove the driver for good. > > Signed-off-by: Geert Uytterhoeven There is a typo in the subject, but tha

[PATCH 0/2] usb: renesas_usbhs: More compat strings

2015-12-07 Thread Simon Horman
Hi, this short series adds generic, and soc-specific r8a7792 and r8a7793 compat strings to the Renesas USBHS driver. The intention is to provide a complete set of compat strings for known R-Car SoCs. Simon Horman (2): usb: renesas_usbhs: add fallback compatibility string usb: renesas_usbhs

[PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

2015-12-07 Thread Simon Horman
Add fallback compatibility string. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- drivers/usb/renesas_usbhs/common.c

[PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-07 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Also add names for SoCs. Signed-off-by: Simon Horman --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++ 1

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 06:05:51AM +, Kuninori Morimoto wrote: > > Hi Simon > > > Add fallback compatibility string. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Signe

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

2015-12-08 Thread Simon Horman
On Tue, Dec 08, 2015 at 05:35:28PM +0300, Sergei Shtylyov wrote: > On 12/08/2015 08:51 AM, Simon Horman wrote: > > >Add fallback compatibility string. > >This is in keeping with the fallback scheme being adopted wherever > >appropriate for drivers for Renesas SoCs. >

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

2015-12-08 Thread Simon Horman
On Tue, Dec 08, 2015 at 08:32:49AM +, Kuninori Morimoto wrote: > > Hi Simon > > > > > Add fallback compatibility string. > > > > This is in keeping with the fallback scheme being adopted wherever > > > > appropriate for drivers for Renesas SoCs.

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

2015-12-08 Thread Simon Horman
On Wed, Dec 09, 2015 at 04:48:47AM +, Kuninori Morimoto wrote: > > Hi Simon > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > with what I documented elsewhere in the patch) > > "renesas,rcar-usbhs" is better, > but I guess you want to have "renesas,rcar-gen2-usbhs" ?

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

2015-12-08 Thread Simon Horman
On Wed, Dec 09, 2015 at 06:29:07AM +, Kuninori Morimoto wrote: > > Hi Simon > > > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > > > with what I documented elsewhere in the patch) > > > > > > "renesas,rcar-usbhs" is better, > > > but I guess you want to have "renesas

[PATCH v2 0/2] usb: renesas_usbhs: More compat strings

2015-12-09 Thread Simon Horman
single compatibility string for all of R-Car. *** BLURB HERE *** Simon Horman (2): usb: renesas_usbhs: add fallback compatibility strings usb: renesas_usbhs: add device tree support for r8a779[23] .../devicetree/bindings/usb/renesas_usbhs.txt| 20 +++- drivers/usb

[PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-09 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ 1 file changed, 2

[PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings

2015-12-09 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Also add SoC names. Signed-off-by: Simon Horman --- v2 * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than

Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings

2015-12-10 Thread Simon Horman
iate for drivers for Renesas SoCs. > > > > Also add SoC names. > > > > Signed-off-by: Simon Horman > > --- > (snip) > > Required properties: > >- compatible: Must contain one of the following: > > - - "renesas,usbhs-r8a7790" > &

[PATCH v3 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

2015-12-10 Thread Simon Horman
This extends the documentation of compatibility strings a little to include the SoC names. Signed-off-by: Simon Horman --- v3 * Split into separate patch --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH v3 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-10 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ 1 file changed, 2

[PATCH v3 0/3] usb: renesas_usbhs: More compat strings

2015-12-10 Thread Simon Horman
compatibility string in example Changes since v1: * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. Simon Horman (3): usb: renesas_usbhs: add SoC names to compatibility string documentation usb: renesas_usbhs: add

[PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-10 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman --- v3 * Moved documentation of SoC names to a separate patch * Use correct fallback compatibility

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-10 Thread Simon Horman
On Thu, Dec 10, 2015 at 09:56:24PM -0600, Rob Herring wrote: > On Fri, Dec 11, 2015 at 11:12:26AM +0900, Simon Horman wrote: > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > approp

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-14 Thread Simon Horman
On Fri, Dec 11, 2015 at 03:24:27PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/11/2015 5:12 AM, Simon Horman wrote: > > >Add fallback compatibility strings for R-Car Gen2 and Gen3. > >This is in keeping with the fallback scheme being adopted wherever > >appro

[PATCH v4 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-15 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman Acked-by: Kuninori Morimoto --- v4 * State that one or more compat string should be used v3

[PATCH v4 0/3] usb: renesas_usbhs: More compat strings

2015-12-15 Thread Simon Horman
: * Split documentation of SoC names into separate patch * Use correct fallback compatibility string in example Changes since v1: * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. Simon Horman (3): usb: renesas_usbhs: add SoC names to

[PATCH v4 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-15 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman Acked-by: Rob Herring Acked-by: Kuninori Morimoto --- Documentation/devicetree/bindings/usb

[PATCH v4 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

2015-12-15 Thread Simon Horman
This extends the documentation of compatibility strings a little to include the SoC names. Signed-off-by: Simon Horman Acked-by: Kuninori Morimoto --- v3 * Split into separate patch --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 1 file changed, 4 insertions(+), 4

[PATCH 0/2] usb: Use ARCH_RENESAS

2016-02-18 Thread Simon Horman
. Simon Horman (2): usb: renesas_usbhs: Use ARCH_RENESAS usb: host: xhci-rcar: Use ARCH_RENESAS drivers/usb/host/Kconfig | 2 +- drivers/usb/renesas_usbhs/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line

[PATCH 1/2] usb: renesas_usbhs: Use ARCH_RENESAS

2016-02-18 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

[PATCH 2/2] usb: host: xhci-rcar: Use ARCH_RENESAS

2016-02-18 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

[PATCH] usb: gadget: renesas_usb3: Use ARCH_RENESAS

2016-03-01 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

Re: [RFC][PATCH 1/4 v3] usb: host: ehci-platform: BUG_ON() to WARN_ON() on probe

2012-08-06 Thread Simon Horman
On Sun, Aug 05, 2012 at 06:51:34PM -0700, kuninori.morimoto...@renesas.com wrote: > We should avoid using BUG_ON() in drivers. > This patch switch to use WARN_ON() from BUG_ON(), > and avoid NULL pointer access by new macro. > > Signed-off-by: Kuninori Morimoto > --- > v2 -> v3 > > - BUG_ON ->

Re: [PATCH v4] usb: phy: add R-Car USB phy driver

2012-09-11 Thread Simon Horman
-san, below is an incremental patch to add some workarounds that were made available to me. I wonder if you have some documentation available to replace the hex values with #defines? From: Kouei Abe arm: mach-rcar: Add USB-PHY workaround Signed-off-by: Kouei Abe Signed-off-by: Simon Horman

Re: [PATCH v8 0/9] Reorganize R8A7779/Marzen USB code

2013-06-07 Thread Simon Horman
On Sun, Jun 02, 2013 at 01:28:05AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, > 'renesas-next-20130528' tag. It was created to fix the shortcomings in the > R8A7779/Marzen USB platform code and R8A7779 USB common PHY dr

Re: [PATCH v9 0/3] Add USB support to R8A7778/BOCK-W

2013-06-09 Thread Simon Horman
On Sun, Jun 09, 2013 at 12:24:04AM +0400, Sergei Shtylyov wrote: > On 06/09/2013 12:12 AM, Sergei Shtylyov wrote: > > >Here's the set of 3 patches against the Simon Horman's 'renesas.git' > > repo, > >'renesas-next-20130607' tag, and the R8A7779/Marzen USB patchset I've posted. > >It was crea

Re: [PATCH v9 resend 0/3] Add USB support to R8A7778/BOCK-W

2013-06-11 Thread Simon Horman
On Sun, Jun 09, 2013 at 12:32:34AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 3 patches against the Simon Horman's 'renesas.git' repo, > 'renesas-next-20130607' tag, and the R8A7779/Marzen USB patchset I've posted. > It was created to add support of R8A7778/BOCK-W USB to the p

Re: [PATCH v8 0/9] Reorganize R8A7779/Marzen USB code

2013-06-11 Thread Simon Horman
On Fri, Jun 07, 2013 at 02:45:45PM +0400, Sergei Shtylyov wrote: > Hello. > > On 07-06-2013 12:06, Simon Horman wrote: > > >>Here's the set of 9 patches against the Simon Horman's 'renesas.git' > >> repo, > >>'renesas-ne

Re: [PATCH v8 0/9] Reorganize R8A7779/Marzen USB code

2013-06-11 Thread Simon Horman
On Tue, Jun 11, 2013 at 04:49:43PM +0900, Simon Horman wrote: > On Fri, Jun 07, 2013 at 02:45:45PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 07-06-2013 12:06, Simon Horman wrote: > > > > >>Here's the set of 9 patches against t

Re: [PATCH v9 resend 0/3] Add USB support to R8A7778/BOCK-W

2013-06-11 Thread Simon Horman
On Tue, Jun 11, 2013 at 04:49:59PM +0900, Simon Horman wrote: > On Sun, Jun 09, 2013 at 12:32:34AM +0400, Sergei Shtylyov wrote: > > Hello. > > > >Here's the set of 3 patches against the Simon Horman's 'renesas.git' > > repo, > > &#

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-22 Thread Simon Horman
On Wed, Aug 21, 2013 at 06:02:45PM +0800, liujunliang_ljl wrote: > Dear Ben : > > 1, please give me email address of David Miller, and Thanks a > lot. You can find him in the MAINTAINERS file. He should also show up if you use scripts/get_maintainer.pl -- To unsubscribe from this

Re: [PATCH 0/3] Add USBHS support to Lager

2013-10-07 Thread Simon Horman
On Tue, Oct 08, 2013 at 03:27:00AM +0400, Valentine Barshak wrote: > This patch set adds internal USB PHY support to RCAR Gen2 SoC, and > also enables USBHS for the Lager board. > > The patches apply fine to the renesas-devel-20131004 tag of the renesas.git. > > The first patch also applies fine

Re: [PATCH 0/3] Add USBHS support to Lager (take 2)

2013-10-08 Thread Simon Horman
On Tue, Oct 08, 2013 at 11:43:24PM +0400, Valentine Barshak wrote: > This patch set adds internal USB PHY support to RCAR Gen2 SoC, and > also enables USBHS for the Lager board. It has been updated, based > on the comments to the previous version. > > The patches apply fine to the renesas-devel-20

Re: [PATCH 0/3] Add USBHS support to Lager (take 2)

2013-10-08 Thread Simon Horman
On Tue, Oct 08, 2013 at 07:09:36PM -0700, Kuninori Morimoto wrote: > > Hi > > > This patch set adds internal USB PHY support to RCAR Gen2 SoC, and > > also enables USBHS for the Lager board. It has been updated, based > > on the comments to the previous version. > > > > The patches apply fine to

Re: [PATCH 2/3] arm: shmobile: r8a7790: Add USBHS clock support

2013-10-28 Thread Simon Horman
On Thu, Oct 10, 2013 at 02:14:46AM +0400, Valentine Barshak wrote: > This adds USBHS clock support. > > Signed-off-by: Valentine Barshak > Acked-by: Kuninori Morimoto > --- > arch/arm/mach-shmobile/clock-r8a7790.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/mach-shmob

Re: [PATCH 3/3] arm: shmobile: lager: Add USBHS support

2013-10-28 Thread Simon Horman
On Thu, Oct 10, 2013 at 02:14:47AM +0400, Valentine Barshak wrote: > This adds USBHS PHY and registers USBHS device if the driver is enabled. > > Signed-off-by: Valentine Barshak > Acked-by: Kuninori Morimoto Thanks, I notice that Felipe Balbi's has merged the first patch of this series and th

Re: [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization

2013-10-28 Thread Simon Horman
On Fri, Oct 25, 2013 at 09:07:12PM +0400, Valentine Barshak wrote: > Add missing USB UGCTRL2 register offset. > > Signed-off-by: Valentine Barshak This seems reasonable to me. Acked-by: Simon Horman Felipe, please consider applying this change. > --- > drivers/usb/phy/phy-

Re: [PATCH 3/9] usb: hcd: Initialize USB phy if needed

2013-11-20 Thread Simon Horman
On Thu, Nov 21, 2013 at 01:26:19AM +0400, Valentine wrote: > On 11/20/2013 09:46 PM, Fabio Estevam wrote: > >On Wed, Nov 20, 2013 at 3:38 PM, Ulrich Hecht wrote: > >>From: Valentine Barshak > >> > >>This adds external USB phy support to USB HCD driver that > >>allows to find and initialize extern

Re: [PATCH 10/12] usb: r8a66597-hcd: Convert to clk_prepare/unprepare

2013-11-28 Thread Simon Horman
On Tue, Nov 26, 2013 at 03:08:27PM +0100, Laurent Pinchart wrote: > Hi Greg, > > On Monday 25 November 2013 18:36:08 Greg Kroah-Hartman wrote: > > On Tue, Nov 26, 2013 at 03:00:30AM +0100, Laurent Pinchart wrote: > > > On Saturday 09 November 2013 08:10:59 Greg Kroah-Hartman wrote: > > > > On Sat,

Re: [PATCH 4/8] rcar-phy: remove EHCI internal buffer setup

2013-04-04 Thread Simon Horman
On Fri, Apr 05, 2013 at 03:03:55AM +0400, Sergei Shtylyov wrote: > Now that the EHCI internal buffer setup is done by the platform code, we can > remove such code from this driver as it never really belonged here. We also > no longer need the 2nd memory region now (2nd EHCI controller is simply

Re: [PATCH 5/8] rcar-phy: correct base address

2013-04-04 Thread Simon Horman
On Fri, Apr 05, 2013 at 03:05:14AM +0400, Sergei Shtylyov wrote: > The memory region that is used by the driver overlaps EHCI and OHCI register > regions for absolutely no reason now -- fix it by adding offset of 0x800 to > the base address, changing the register #define's accordingly. This has ex

Re: [PATCH 7/8] ARM: shmobile: Marzen: pass platform data to USB PHY device

2013-04-04 Thread Simon Horman
On Fri, Apr 05, 2013 at 03:10:38AM +0400, Sergei Shtylyov wrote: > Since we're now going to setup the USBPCTRL0 register using the USB PHY > device's > platform data, we now need a way to pass those platform data from the board > file > to the device which is situated in setup-r8a7779.c -- and wh

Re: [PATCH 0/8] Reorganize R8A7779/Marzen USB code

2013-04-07 Thread Simon Horman
On Sat, Apr 06, 2013 at 02:35:34AM +0400, Sergei Shtylyov wrote: > Hello. > > On 04/05/2013 08:40 PM, Sergei Shtylyov wrote: > > > > >>>Here's the set of 4 patches against the Simon Horman's > >>>'renesas.git' repo, > >>>'renesas-next-20130404v2' tag and the 2 Ether patches I've > >>>reposted

Re: [PATCH v2 0/9] Reorganize R8A7779/Marzen USB code

2013-04-09 Thread Simon Horman
On Tue, Apr 09, 2013 at 01:10:49AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, > 'renesas-next-20130405v2' tag. It was created to fix the shortcomings in the > R8A7779/Marzen USB platform code and R8A7779 USB common PHY

Re: [PATCH 0/8] Reorganize R8A7779/Marzen USB code

2013-04-09 Thread Simon Horman
"this patch is tested on > >bard" > >on each patch's comment area ? > >I thought adding it to each patch (BTW, I didn't get what you > meant: changelog or the area below ---) was a bit too much and just > mentioned it in the cover letter. >

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

2013-04-09 Thread Simon Horman
On Wed, Apr 10, 2013 at 02:26:08AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, > 'renesas-next-20130410' tag. It was created to fix the shortcomings in the > R8A7779/Marzen USB platform code and R8A7779 USB common PHY dr

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

2013-04-10 Thread Simon Horman
On Wed, Apr 10, 2013 at 11:50:33AM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 10, 2013 at 01:49:23PM +0900, Simon Horman wrote: > > On Wed, Apr 10, 2013 at 02:26:08AM +0400, Sergei Shtylyov wrote: > > > Hello. > > > > > >Here's

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

2013-04-10 Thread Simon Horman
On Wed, Apr 10, 2013 at 06:05:43PM +0900, Simon Horman wrote: > On Wed, Apr 10, 2013 at 11:50:33AM +0300, Felipe Balbi wrote: > > Hi, > > > > On Wed, Apr 10, 2013 at 01:49:23PM +0900, Simon Horman wrote: > > > On Wed, Apr 10, 2013 at 02:26:08AM +0400, Sergei

Re: [PATCH 0/4] Add USB support to R8A7778/BOCK-W

2013-04-10 Thread Simon Horman
On Wed, Apr 10, 2013 at 04:46:31PM +0400, Sergei Shtylyov wrote: > Hello. > > On 10-04-2013 2:47, Sergei Shtylyov wrote: > > >Here's the set of 4 patches against the Simon Horman's 'renesas.git' > > repo, > >'renesas-next-20130410' tag. > >Sorry, forgot to mention that it is atop the pr

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

2013-04-11 Thread Simon Horman
On Thu, Apr 11, 2013 at 04:02:33PM +0400, Sergei Shtylyov wrote: > Hello. > > On 11-04-2013 4:51, Simon Horman wrote: > > >>>>>Here's the set of 9 patches against the Simon Horman's 'renesas.git' > >>>>> repo, > >&

Re: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig

2013-04-18 Thread Simon Horman
On Wed, Apr 17, 2013 at 01:35:09AM +0400, Sergei Shtylyov wrote: > Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'. > Enable USB storage driver and SCSI disk driver that it needs as well... > > Signed-off-by: Sergei Shtylyov I realise that this is not going to be useful

Re: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig

2013-04-18 Thread Simon Horman
On Fri, Apr 19, 2013 at 02:50:05AM +0400, Sergei Shtylyov wrote: > Hello. > > On 04/18/2013 06:05 PM, Simon Horman wrote: > > > > >>Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'. > >>Enable USB storage dri

Re: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

2013-04-21 Thread Simon Horman
t; >bisectable... > > > >The patch has been tested on the Marzen board. > > > >Signed-off-by: Sergei Shtylyov > >Acked-by: Kuninori Morimoto > >Acked-by: Simon Horman > > WBR, Sergei > > -- > To unsubscribe from this list: send the line &qu

Re: [PATCH v4 0/4] Add USB support to R8A7778/BOCK-W

2013-04-21 Thread Simon Horman
On Sat, Apr 20, 2013 at 02:27:32AM +0400, Sergei Shtylyov wrote: > Hello. > > On 04/20/2013 02:07 AM, Sergei Shtylyov wrote: > > >Here's the set of 3 patches against the Simon Horman's 'renesas.git' > > repo, > >'renesas-next-20130416' tag and the R8A7779/Marzen patchset I've posted. > >

Re: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig

2013-04-21 Thread Simon Horman
On Sat, Apr 20, 2013 at 12:23:52AM +0400, Sergei Shtylyov wrote: > On 04/19/2013 06:14 AM, Simon Horman wrote: > >On Fri, Apr 19, 2013 at 02:50:05AM +0400, Sergei Shtylyov wrote: > >>Hello. > >> > >>On 04/18/2013 06:05 PM, Simon Horman wrote: > >> >

Re: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

2013-04-22 Thread Simon Horman
On Mon, Apr 22, 2013 at 05:34:05PM +0400, Sergei Shtylyov wrote: > Hello. > > On 22-04-2013 5:09, Simon Horman wrote: > > >>>USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined > >>>and > >>>registered in the Mar

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-28 Thread Simon Horman
On Mon, Jan 27, 2014 at 07:06:26PM +, Ben Dooks wrote: > On 27/01/14 18:23, Sergei Shtylyov wrote: > >Hello. > > > >On 01/26/2014 08:05 PM, Ben Dooks wrote: > > [snip] > > >> > >>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>+{ .compatible = "renesas,usb-phy-r8a7790", },

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-29 Thread Simon Horman
On Wed, Jan 29, 2014 at 02:41:58PM +0400, Sergei Shtylyov wrote: > Hello. > > On 29-01-2014 10:22, Simon Horman wrote: > > >>[snip] > > >>>>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>>>+{ .compatible = "renes

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-29 Thread Simon Horman
On Wed, Jan 29, 2014 at 04:26:55PM +0400, Sergei Shtylyov wrote: > Hello. > > On 29-01-2014 16:22, Simon Horman wrote: > > >>>>[snip] > > >>>>>>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>>>>>+

Re: [PATCH v2 2/2] ARM: shmobile: lager: enable USB3.0

2014-10-30 Thread Simon Horman
On Fri, Oct 31, 2014 at 02:06:14AM +, yoshihiro shimoda wrote: > Hi Simon-san, > > > On Wed, Oct 29, 2014 at 08:19:30PM +0900, Yoshihiro Shimoda wrote: > > > Hi Magnus-san, > > > > > > (2014/10/29 15:53), Magnus Damm wrote: > < snip > > > > > > > > > Hi Shimoda-san, > > > > > > > > Thanks for

Re: [PATCH v2 2/2] ARM: shmobile: lager: enable USB3.0

2014-11-03 Thread Simon Horman
On Fri, Oct 31, 2014 at 01:22:22PM +, yoshihiro shimoda wrote: > Hi Simon-san, > > > On Fri, Oct 31, 2014 at 02:06:14AM +, yoshihiro shimoda wrote: > > > Hi Simon-san, > > > > > > > On Wed, Oct 29, 2014 at 08:19:30PM +0900, Yoshihiro Shimoda wrote: > > > > > Hi Magnus-san, > > > > > > > >

Re: [PATCH v2] usb: renesas_usbhs: fix driver dependencies

2014-09-01 Thread Simon Horman
-by: Bartlomiej Zolnierkiewicz > > Acked-by: Kyungmin Park > > Cc: Simon Horman > > Cc: Magnus Damm > > --- > > v2: > > - s/ARCH_SH/SUPERH/ (thanks to Sergei Shtylyov) > > Acked-by: Geert Uytterhoeven Acked-by: Simon Horman -- To unsubscribe from t

Re: [PATCH v4 0/2] Add USB PHY device tree support for R8A7790/Lager board

2014-09-29 Thread Simon Horman
On Fri, Sep 26, 2014 at 01:58:01PM -0700, Sergei Shtylyov wrote: > Hello. > >Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, > 'renesas-devel-20140924-v3.17-rc6' tag. Here we add the USB PHY device tree > support on the R8A7790/Lager reference board. The patchset require

Re: [PATCH v4 0/3] Add USB PHY device tree support for R8A7791/Koelsch/Henninger board

2014-09-29 Thread Simon Horman
On Sat, Sep 27, 2014 at 01:05:41AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 3 patches against Simon Horman's 'renesas.git' repo, > 'renesas-devel-20140924-v3.17-rc6' tag. Here we add the USB PHY device tree > support on the R8A7791/Koelsch/Henninger boards. The patchset requ

Re: [PATCH v4] ARM: shmobile: r8a7790: link PCI USB devices to USB PHY

2014-09-29 Thread Simon Horman
On Mon, Sep 29, 2014 at 10:21:59PM +0400, Sergei Shtylyov wrote: > Describe the PCI USB devices that are behind the PCI bridges, adding necessary > links to the USB PHY device. > > Based on the original work by Ben Dooks . > > Signed-off-by: Sergei Shtylyov Thanks, I have queued this up. > >

Re: [PATCH v4] ARM: shmobile: r8a7791: link PCI USB devices to USB PHY

2014-09-29 Thread Simon Horman
On Mon, Sep 29, 2014 at 10:23:11PM +0400, Sergei Shtylyov wrote: > Describe the PCI USB devices that are behind the PCI bridges, adding necessary > links to the USB PHY device. > > Signed-off-by: Sergei Shtylyov Thanks, I have queued this up. > > --- > This patch is against 'renesas-devel-2014

Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB

2014-10-05 Thread Simon Horman
On Mon, Oct 06, 2014 at 09:59:48AM +0900, Yoshihiro Shimoda wrote: > Hello. > > (2014/10/04 4:50), Sergei Shtylyov wrote: > > On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: > > > >> Signed-off-by: Yoshihiro Shimoda > >> --- > >> arch/arm/boot/dts/r8a7790-lager.dts |5 + > >> 1 file

Re: [PATCH] ARM: shmobile: add USB3.0 device node on r8a7791

2014-10-23 Thread Simon Horman
On Wed, Oct 08, 2014 at 03:27:55PM +0900, Yoshihiro Shimoda wrote: > (2014/10/08 15:24), Yoshihiro Shimoda wrote: > > This patch is based on Simon's renesas.git branch and > > renesas-devel-20141007-v3.17 tag. > > Since koelsch and henninger doesn't have a USB3.0 connector, > > I submit a patch fo

Re: [PATCH 0/2] ARM: shmobile: add USB3.0 device node on r8a7790

2014-10-23 Thread Simon Horman
On Wed, Oct 08, 2014 at 03:24:28PM +0900, Yoshihiro Shimoda wrote: > This series is based on Simon's renesas.git branch and > renesas-devel-20141007-v3.17 tag. If we use the generic phy > driver for R-Car Gen2 (drivers/phy/phy-rcar-gen2.c), we can use > the USB3.0 on lager. > > Yoshihiro Shimoda

Re: [PATCH 0/2] ARM: shmobile: add USB3.0 device node on r8a7790

2014-10-23 Thread Simon Horman
On Fri, Oct 24, 2014 at 04:44:28AM +, yoshihiro shimoda wrote: > Hi Simon-san, > > > On Wed, Oct 08, 2014 at 03:24:28PM +0900, Yoshihiro Shimoda wrote: > > > This series is based on Simon's renesas.git branch and > > > renesas-devel-20141007-v3.17 tag. If we use the generic phy driver for > >

Re: [PATCH] ARM: shmobile: add USB3.0 device node on r8a7791

2014-10-23 Thread Simon Horman
On Fri, Oct 24, 2014 at 04:43:55AM +, yoshihiro shimoda wrote: > Hi Simon-san, > > > On Wed, Oct 08, 2014 at 03:27:55PM +0900, Yoshihiro Shimoda wrote: > > > (2014/10/08 15:24), Yoshihiro Shimoda wrote: > > > > This patch is based on Simon's renesas.git branch and > > > > renesas-devel-201410

Re: [PATCH v4 0/2] Add HS-USB device tree support for R8A7790/Lager board

2014-10-23 Thread Simon Horman
On Wed, Oct 08, 2014 at 11:53:11PM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, > 'renesas-devel-20141007-v3.17' tag. Here we add the HS-USB device tree support > on the R8A7790/Lager reference board. The patchset requires the

Re: [PATCH v2 0/2] ARM: shmobile: add USB3.0 device node on r8a7790

2014-10-26 Thread Simon Horman
On Fri, Oct 24, 2014 at 07:41:45PM +0900, Yoshihiro Shimoda wrote: > This series is based on Simon's renesas.git branch and > renesas-devel-20141024-v3.18-rc1 tag. If we use the generic phy > driver for R-Car Gen2 (drivers/phy/phy-rcar-gen2.c), we can use > the USB3.0 on lager. Thanks, I have que

Re: [PATCH v5 0/2] Add HS-USB device tree support for R8A7790/Lager board

2014-10-26 Thread Simon Horman
On Fri, Oct 24, 2014 at 07:44:32PM +0900, Yoshihiro Shimoda wrote: > Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, > 'renesas-devel-20141024-v3.18-rc1' tag. Here we add the HS-USB device tree > support on the R8A7790/Lager reference board. The patchset requires the USB > P

Re: [PATCH v2 0/1] ARM: shmobile: add USB3.0 device node on r8a7791

2014-10-26 Thread Simon Horman
On Fri, Oct 24, 2014 at 07:43:01PM +0900, Yoshihiro Shimoda wrote: > This patch is based on Simon's renesas.git branch and > renesas-devel-20141024-v3.18-rc1 tag. > Since koelsch and henninger doesn't have a USB3.0 connector, > I submit a patch for r8a7791.dtsi only. Thanks, I have queued this up

Re: [PATCH v4 0/3] HS-USB device tree support for R8A7791/Koelsch/Henninger board

2014-10-26 Thread Simon Horman
On Fri, Oct 24, 2014 at 07:45:05PM +0900, Yoshihiro Shimoda wrote: >Here's the set of 3 patches against Simon Horman's 'renesas.git' repo, > 'renesas-devel-20141024-v3.18-rc1' tag. Here we add the HS-USB device tree > support on the R8A7791/Koelsch/Henninger reference boards. The patchset > req

Re: [PATCH v2 2/2] ARM: shmobile: lager: enable USB3.0

2014-10-29 Thread Simon Horman
On Wed, Oct 29, 2014 at 08:19:30PM +0900, Yoshihiro Shimoda wrote: > Hi Magnus-san, > > (2014/10/29 15:53), Magnus Damm wrote: > > On Fri, Oct 24, 2014 at 7:41 PM, Yoshihiro Shimoda > > wrote: > >> Since the PHY of USB3.0 and EHCI/OHCI ch2 are the same, the USB3.0 > >> driver cannot use the phy d

Re: [PATCH v2 0/2] ARM: shmobile: lager: USBHS callback elimination

2014-07-11 Thread Simon Horman
[Cc Felipe Balbi] On Thu, Jul 10, 2014 at 01:20:34AM -0700, Kuninori Morimoto wrote: > > Hi > > > Changes in v2: > > - move phy handle to struct usbhs_priv > > - add new default pipe type to driver > > - remove pipe type from Lager board code > > > > Ulrich Hecht (2): > > usb: renesas_usbhs:

Re: [PATCH v2 0/2] ARM: shmobile: lager: USBHS callback elimination

2014-07-11 Thread Simon Horman
On Fri, Jul 11, 2014 at 10:12:37AM -0500, Felipe Balbi wrote: > On Fri, Jul 11, 2014 at 11:00:07AM +0200, Simon Horman wrote: > > [Cc Felipe Balbi] > > > > On Thu, Jul 10, 2014 at 01:20:34AM -0700, Kuninori Morimoto wrote: > > > > > > Hi > > > >

Re: [PATCH v2 0/2] ARM: shmobile: lager: USBHS callback elimination

2014-07-12 Thread Simon Horman
On Fri, Jul 11, 2014 at 11:23:48AM -0500, Felipe Balbi wrote: > On Fri, Jul 11, 2014 at 05:41:52PM +0200, Simon Horman wrote: > > On Fri, Jul 11, 2014 at 10:12:37AM -0500, Felipe Balbi wrote: > > > On Fri, Jul 11, 2014 at 11:00:07AM +0200, Simon Horman wrote: > &

Re: [PATCH v2 1/2] usb: renesas_usbhs: Change USBHS_TYPE_R8A779x to USBHS_TYPE_RCAR_GEN2

2015-05-18 Thread Simon Horman
f-by: Yoshihiro Shimoda Acked-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: renesas_usbhs: avoid uninitialized variable use

2015-05-24 Thread Simon Horman
he respective > > registers. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 88a25e02f3 ("usb: renesas_usbhs: Add access control for INTSTS1 and > > INTENB1 register") > > Thank you very much for the patch! > > Acked-by: Yoshihiro Shimoda &

Re: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching

2015-07-02 Thread Simon Horman
Hi Phil, when you re-spin this patch could you change the prefix to the following? ARM: shmobile: koelsch: Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/2] usb: renesas_usbhs: add support for requesting DT DMA

2015-01-29 Thread Simon Horman
Hi Shimoda-san, On Mon, Jan 19, 2015 at 12:53:17PM +0900, Yoshihiro Shimoda wrote: > This patch adds dma_request_slave_channel_reason() calling to request > dma slave channels for multiplatform environment. > > Signed-off-by: Yoshihiro Shimoda > --- > .../devicetree/bindings/usb/renesas_usbhs.t

Re: [PATCH] usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()

2015-01-30 Thread Simon Horman
a8c76b1a8879da1dd30caa) > > The usbhsf_dma_init_dt() should set fifo->{t,r}x_chan to NULL if > dma_request_slave_channel_reason() returns IS_ERR value. > Otherwise, usbhsf_dma_quit() will call dma_release_channel(), and then > NULL pointer dereference happens. > > Reporte

Re: [PATCH 0/2] ARM: shmobile: r8a7790: add for USB-DMAC

2015-02-09 Thread Simon Horman
On Mon, Feb 09, 2015 at 08:41:18AM +, yoshihiro shimoda wrote: > > Subject: [PATCH 0/2] ARM: shmobile: r8a7790: add for USB-DMAC > > Oops, I mistook this subject of cover-letter. > However, actual patches are correct. Thanks, I think it would be best if you resubmitted this series, which is

Re: [PATCH 0/9] Add USB3.0 and TI HD3SS3220 driver support

2019-03-06 Thread Simon Horman
On Wed, Mar 06, 2019 at 09:07:17AM +, Biju Das wrote: > This series adds USB 3.0 support for the CAT874 platform, including a > new driver for the TI HD3SS3220 USB Type-C DRP port controller. > > This patch series supports: > 1) Host hotplug operation > 2) Device hot plug operation > 3) USB ty

Re: [PATCH 0/4] Add USB-HOST support to cat874

2019-03-06 Thread Simon Horman
On Fri, Mar 01, 2019 at 11:05:44AM +, Fabrizio Castro wrote: > While trying to add USB-HOST support to the cat874 board, > it came up that of_usb_get_dr_mode_by_phy was selecting > the wrong DT node to use for dr_mode. > Also, drivers/phy/renesas/phy-rcar-gen3-usb2.c was registering > IRQs, no

Re: [PATCH v2] usb: renesas_usbhs: Use specific struct instead of USBHS_TYPE_* enums

2019-05-13 Thread Simon Horman
i Shimoda-san, the minor suggestion below not withstanding this looks good to me. Reviewed-by: Simon Horman > --- > Changes from v1 [1]: > - Use sizeof(variable) instead of sizeof(type). > - Add Geert-san's reviewed-by (thanks!). > > [1] > https://patchwork.kernel.org/patch

Re: [PATCH v2 02/15] ARM: dts: rza2mevb: Add 48MHz USB clock

2019-05-13 Thread Simon Horman
On Thu, May 09, 2019 at 03:11:29PM -0500, Chris Brandt wrote: > The RZ/A2M EVB has a 48MHz clock attached to USB_X1. > > Signed-off-by: Chris Brandt Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman

Re: [PATCH v2 01/15] ARM: dts: r7s9210: Add USB clock

2019-05-13 Thread Simon Horman
On Thu, May 09, 2019 at 03:11:28PM -0500, Chris Brandt wrote: > Add USB clock node. If present, this clock input must be 48MHz. > > Signed-off-by: Chris Brandt Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman

Re: [PATCH v3 01/15] ARM: dts: r7s9210: Add USB clock

2019-05-15 Thread Simon Horman
On Wed, May 15, 2019 at 09:38:32AM +0200, Geert Uytterhoeven wrote: > On Tue, May 14, 2019 at 4:56 PM Chris Brandt wrote: > > Add USB clock node. If present, this clock input must be 48MHz. > > > > Signed-off-by: Chris Brandt > > Reviewed-by: Simon Horman > >

Re: [PATCH v3 02/15] ARM: dts: rza2mevb: Add 48MHz USB clock

2019-05-15 Thread Simon Horman
On Wed, May 15, 2019 at 09:43:02AM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Tue, May 14, 2019 at 4:57 PM Chris Brandt wrote: > > The RZ/A2M EVB has a 48MHz clock attached to USB_X1. > > > > Signed-off-by: Chris Brandt > > Reviewed-by: Simo

Re: [PATCH v3 08/15] usb: renesas_usbhs: move flags to param

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:58AM -0500, Chris Brandt wrote: > Move options from 'flags' field in private structure to param structure > where other options are already being kept. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

  1   2   >