[PATCH] USB chipidea i.MX: Fix module loading

2013-08-08 Thread Sascha Hauer
The Chipidea i.MX driver has some issues with module loading dependencies. This fixes this. It is an alternative approach to the one Peter Chen suggested that does without changing the dt binding. Sascha Sascha Hauer (2): USB

Re: [PATCH] chipidea: core: Move hw_phymode_configure() into probe

2013-08-09 Thread Sascha Hauer
y configure the PHY mode, so move this function into probe. > > After this change, USB Host1 port on mx53qsb board is functional. > > Signed-off-by: Fabio Estevam Also fixes my i.MX53 USB host mode problems. Acked-by: Sascha Hauer Sascha > --- > drivers/usb/chipidea/cor

Re: [PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-09 Thread Sascha Hauer
On Fri, Aug 09, 2013 at 06:25:29PM +0800, Peter Chen wrote: > > -void usbmisc_unset_ops(const struct usbmisc_ops *ops) > > -{ > > - usbmisc_ops = NULL; > > -} > > -EXPORT_SYMBOL_GPL(usbmisc_unset_ops); > > - > > -int usbmisc_get_init_data(struct device *dev, struct usbmisc_usb_device > > *usbdev

[PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-12 Thread Sascha Hauer
usbmisc_imx driver. Also instead of letting the usbmisc_imx driver call back into the ci_hdrc_imx driver, pass the needed data in the first place. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci_hdrc_imx.c | 71 +--- drivers/usb/chipidea/ci_hdrc_imx.h | 17 ++- drivers

[PATCH v2] USB chipidea i.MX: Fix module loading

2013-08-12 Thread Sascha Hauer
for i.MX23/28 as suggested by Peter Chen Sascha Hauer (2): USB: chipidea: i.MX: remove unused define USB: chipidea: i.MX: simplify usbmisc drivers/usb/chipidea/ci_hdrc_imx.c | 74 + drivers

[PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-12 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 14362c0..11ed423 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > Deferred probing cannot be used with platform_driver_probe as by the > time probing is retried either the driver has been unregistered or its > probe function has been set to platform_drv_probe_fail. > > With commit e9354576 ("gpiolib

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 05:20:18PM +0200, Johan Hovold wrote: > On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote: > > On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > > > Deferred probing cannot be used with platform_driver_probe as by the > > &

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: > On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > > Hi, > > > > Peter Chen wrote: > > > This commit adds runtime and system power management support for > > > chipidea core. The runtime pm support is controlled by glue >

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 05:04:21PM +0800, Peter Chen wrote: > On Mon, Oct 14, 2013 at 10:42:16AM +0200, Sascha Hauer wrote: > > On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: > > > On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: > > > > H

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-17 Thread Sascha Hauer
ks. The config should be updated with the last patch. I'm fine with the changes to mx2-camera, but Javier should give his ok to it, he has worked on it quite a lot recently. One other issue related to imx-dma, see comment to that patch. Otherwise

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-18 Thread Sascha Hauer
Hi Shawn, On Mon, Sep 17, 2012 at 01:34:29PM +0800, Shawn Guo wrote: > The series enables multi-platform support for imx. Since the required > frameworks (clk, pwm) and spare_irq have already been adopted on imx, > the series is all about cleaning up mach/* headers. Along with the > changes, arc

Re: [PATCH 0/7] update USB gadget driver fsl-usb2-udc

2012-10-19 Thread Sascha Hauer
Hi Christoph, What system are you working on? If it's i.MX you should use/work on the chipidea driver instead. Sascha On Fri, Oct 19, 2012 at 12:22:36PM +0200, Christoph Fritz wrote: > This series updates USB gadget driver fsl-usb2-udc. > > Christoph Fritz (7): > usb: gadget: fsl_udc: simplif

Re: [PATCH v2 7/7] usb: chipidea: imx: add internal vbus regulator control

2012-11-19 Thread Sascha Hauer
On Mon, Nov 19, 2012 at 05:33:05PM +0800, Peter Chen wrote: > - For host, the vbus should always be on. > - For otg, the vbus is off defaultly, the vbus needs to be > turned on/off when usb role switches. > > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/ci.h |2 + > driver

Re: [PATCH v2 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-19 Thread Sascha Hauer
Hi Peter, > @@ -139,6 +139,7 @@ struct ci13xxx { > enum ci_rolerole; > boolis_otg; > struct work_struct work; > + struct delayed_work dwork; > struct workqueue_struct *wq; > > struc

Re: [PATCH v2 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-19 Thread Sascha Hauer
On Tue, Nov 20, 2012 at 01:54:48PM +0800, Peter Chen wrote: > On Mon, Nov 19, 2012 at 08:17:34PM +0100, Sascha Hauer wrote: > > Hi Peter, > > > > > @@ -139,6 +139,7 @@ struct ci13xxx { > > > enum ci_rolerole; > > > bool

Re: [PATCH v2 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-20 Thread Sascha Hauer
On Fri, Nov 16, 2012 at 03:17:47PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Marc Kleine-Budde > > > > This patch adds support for a second and third clock to the usbmisc driver. > > On > > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks >

Re: About usbmisc_imx.c at chipidea driver

2013-05-15 Thread Sascha Hauer
On Wed, May 15, 2013 at 01:34:31PM +0300, Alexander Shishkin wrote: > Peter Chen writes: > > > Hi Michael & Marc, > > > > Recently, I have worked at i.mx USB loadable module support for chipidea > > driver, > > it needs to write non-core register during the ci13xxx_imx remove process, > > but c

Re: About usbmisc_imx.c at chipidea driver

2013-05-15 Thread Sascha Hauer
On Wed, May 15, 2013 at 01:59:39PM +0300, Alexander Shishkin wrote: > Sascha Hauer writes: > > > On Wed, May 15, 2013 at 01:34:31PM +0300, Alexander Shishkin wrote: > >> Peter Chen writes: > >> > >> > Hi Michael & Marc, > >> > > >

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Sascha Hauer
On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: > From: Michael Grzeschik > > This patch makes it possible to set the chipidea udc > into full-speed only mode. It can be set by the oftree > property "force-full-speed". [...] > +/* force full-speed operation */ > +static bool

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Sascha Hauer
On Sat, Jun 01, 2013 at 10:19:32AM +0200, Michael Grzeschik wrote: > On Sat, Jun 01, 2013 at 09:39:33AM +0200, Sascha Hauer wrote: > > On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: > > > From: Michael Grzeschik > > > > > > This patch makes

[PATCH] USB: chipidea: fix error path

2013-12-19 Thread Sascha Hauer
devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha Hauer Cc: Peter Chen Cc: linux-usb@vger.kernel.org --- drivers/usb/chipidea/ci_hdrc_imx.c | 4 ++-- 1 file changed, 2 insertions

Re: [PATCH] USB: chipidea: fix error path

2013-12-20 Thread Sascha Hauer
On Thu, Dec 19, 2013 at 04:28:54PM +0800, Peter Chen wrote: > On Thu, Dec 19, 2013 at 09:35:44AM +0100, Sascha Hauer wrote: > > devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have > > to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. > &g

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Sascha Hauer
Please add Phytec phyFLEX-i.MX6 to the subject. I assumed some SoC specific changes here. Sascha On Fri, Jan 24, 2014 at 02:58:44PM +0530, Ashutosh singh wrote: > This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module. > > Signed-off-by: Ashutosh singh > --- > arch/arm/boot/dt

Re: [PATCH] ARM: i.MX6: clk: Remove usbphy clock hacks

2014-02-28 Thread Sascha Hauer
On Fri, Feb 28, 2014 at 08:40:51AM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 03:47:45PM +0100, Sascha Hauer wrote: > > > portsc = PORTSC_PTS(PTS_UTMI) | PORTSC_PTW; > > > lpm = DEVLC_PTS(PTS_UTMI) | DEVLC_PTW; > > >

Re: i.MX6 USB OTG support is broken on linux-next

2014-05-11 Thread Sascha Hauer
On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote: > On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote: > > + Robin and David, > > > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig > > index cb8e991..9081757 100644 > > --- a/drivers/usb/core/Kconfig > > +++ b/driver

Re: i.MX6 USB OTG support is broken on linux-next

2014-05-12 Thread Sascha Hauer
On Tue, May 13, 2014 at 12:33:30AM +, Peter Chen wrote: > > > > > On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote: > > > On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote: > > > > + Robin and David, > > > > > > > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconf

Re: [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-07-09 Thread Sascha Hauer
On Wed, Jul 08, 2015 at 05:41:03PM +0800, Chunfeng Yun wrote: > add a DT binding documentation of usb3.0 phy for MT65xx > SoCs from Mediatek. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt65xx-u3phy.txt | 34 > ++ > 1 file changed, 34 insertions

Re: [PATCH v2 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs

2015-07-09 Thread Sascha Hauer
On Wed, Jul 08, 2015 at 05:41:05PM +0800, Chunfeng Yun wrote: > Signed-off-by: Chunfeng Yun > --- > drivers/usb/phy/Kconfig | 10 + > drivers/usb/phy/Makefile | 1 + > drivers/usb/phy/phy-mt65xx-usb3.c | 856 > ++ > 3 files changed, 867 i

Re: [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-07-14 Thread Sascha Hauer
On Tue, Jul 14, 2015 at 02:19:51PM +0800, chunfeng yun wrote: > hi, > On Fri, 2015-07-10 at 07:10 +0200, Sascha Hauer wrote: > > On Wed, Jul 08, 2015 at 05:41:03PM +0800, Chunfeng Yun wrote: > > > add a DT binding documentation of usb3.0 phy for MT65xx > > > SoCs from

Re: [PATCH 02/10] usb: chipidea: define stream mode disable for both roles

2015-07-28 Thread Sascha Hauer
Hi Peter, On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote: > The system bus and chipidea IP have different limitations for > both host and device mode. > For example, with below errata, we need to enable SDIS(Stream Disable Mode) > at host mode. But we don't want it for device mode at t

Re: [PATCH 02/10] usb: chipidea: define stream mode disable for both roles

2015-07-28 Thread Sascha Hauer
On Wed, Jul 29, 2015 at 07:51:55AM +0200, Sascha Hauer wrote: > Hi Peter, > > On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote: > > The system bus and chipidea IP have different limitations for > > both host and device mode. > > For example, with below err

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-07-21 Thread Sascha Hauer
omposite.c > @@ -1956,6 +1956,7 @@ void composite_dev_cleanup(struct usb_composite_dev > *cdev) > } > if (cdev->req) { > kfree(cdev->req->buf); > + usb_ep_dequeue(cdev->gadget->ep0, cdev->req); The request should be dequeued before the bu

Re: [PATCH] USB: ehci-mxc: i.MX35: add workaround for ENGcm11601

2015-03-11 Thread Sascha Hauer
On Wed, Mar 11, 2015 at 01:42:42PM +0100, Bas Vermeulen wrote: > i.MX35 has an issue that when USB DMA (SINGLE) transfers > are interrupted, the usb core can hang. > > This patch implements the workaround described in ENGcm11601 > by setting the AHB to use INCR transfers instead of SINGLE > transf

Re: [PATCH] USB: ehci-mxc: i.MX35: add workaround for ENGcm11601

2015-03-11 Thread Sascha Hauer
On Wed, Mar 11, 2015 at 04:05:31PM +0100, Bas Vermeulen wrote: > > On Wed, March 11, 2015 4:01 pm, Sascha Hauer wrote: > > On Wed, Mar 11, 2015 at 03:52:53PM +0100, Bas Vermeulen wrote: > >> Hello, > >> > >> On Wed, March 11, 2015 2:51 pm, Sascha Hauer wr

Re: [PATCH] USB: ehci-mxc: i.MX35: add workaround for ENGcm11601

2015-03-12 Thread Sascha Hauer
On Wed, Mar 11, 2015 at 03:52:53PM +0100, Bas Vermeulen wrote: > Hello, > > On Wed, March 11, 2015 2:51 pm, Sascha Hauer wrote: > > This driver normally is not used with device tree. Without additional > > kernel changes the chipidea driver is used instead. > > I'

<    1   2