Re: [PATCH v3 3/7] usb: chipidea: usbmisc: fix a potential race condition

2012-11-22 Thread Sascha Hauer
On Fri, Nov 23, 2012 at 01:36:36PM +0800, Peter Chen wrote: > On Wed, Nov 21, 2012 at 03:06:29PM +0100, Michael Grzeschik wrote: > > From: Marc Kleine-Budde > > > > This fixes a potential race condition where the ci13xxx_imx glue code > > could be fast enough to call one of the usbmisc_ops before

Re: [PATCH v3 6/7] usb: chipidea: usbmisc: add mx53 support

2012-11-22 Thread Sascha Hauer
On Fri, Nov 23, 2012 at 02:53:41PM +0800, Peter Chen wrote: > On Wed, Nov 21, 2012 at 03:06:32PM +0100, Michael Grzeschik wrote: > > This adds mx53 as the next user of the usbmisc driver and makes it > > possible to disable the overcurrent-detection of the internal phy. > > > > Signed-off-by: Mich

Re: [PATCH 2/9] usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer

2012-11-26 Thread Sascha Hauer
On Mon, Nov 26, 2012 at 05:29:31PM +0800, Peter Chen wrote: > On Wed, Nov 14, 2012 at 05:19:03PM +0100, Michael Grzeschik wrote: > > This patch adds support for a second and third clock to the chipidea > > driver. On > > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks > >

Re: [PATCH 2/9] usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer

2012-11-26 Thread Sascha Hauer
On Tue, Nov 27, 2012 at 02:50:26PM +0800, Peter Chen wrote: > On Mon, Nov 26, 2012 at 11:22:32AM +0100, Sascha Hauer wrote: > > On Mon, Nov 26, 2012 at 05:29:31PM +0800, Peter Chen wrote: > > > On Wed, Nov 14, 2012 at 05:19:03PM +0100, Michael Grzeschik wrote: > > > >

Re: [PATCH v4 2/7] usb: chipidea: add otg file

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 02:59:58PM +0800, Peter Chen wrote: > Implement struct usb_otg, In that way, calling otg_set_peripheral > will not be failed at udc.c. > > Signed-off-by: Peter Chen > --- > Changes for v4: > - Some tiny changes, like delete unused header files > > drivers/usb/chipidea/Ma

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Sascha Hauer
On Tue, Jan 22, 2013 at 03:38:55PM +, Arnd Bergmann wrote: > On Tuesday 22 January 2013, Alan Stern wrote: > > In order to prevent this, you have to make sure that each glue driver > > depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround > > the Kconfig entries for those driver

[PATCH 1/2] usb: chipidea: otg: save indention level

2016-09-19 Thread Sascha Hauer
Return early from ci_handle_id_switch() to save an indention level. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/otg.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index 03b6743

USB: chipidea: Fix VBUS valid polling when extcon is used

2016-09-19 Thread Sascha Hauer
. Sascha Sascha Hauer (2): usb: chipidea: otg: save indention level usb: chipidea: otg: fix reading otgsc register drivers/usb/chipidea/ci.h | 3 --- drivers/usb/chipidea/core.c | 32

[PATCH 2/2] usb: chipidea: otg: fix reading otgsc register

2016-09-19 Thread Sascha Hauer
since this function eventually patches the VBUS status read from extcon into the raw register value. To fix this inline the hw_wait_reg() code into its only user and use the correct function to read the OTGSC register. Since hw_wait_reg() is unused now remove it. Signed-off-by: Sascha Hauer

Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-26 Thread Sascha Hauer
On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: > This binding allow to disable the internal 60Mhz clock for USB host2 or > host3. > > Signed-off-by: Fabien Lahoudere > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > drivers/usb/chipidea/ci_hdrc_imx.c

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-07 Thread Sascha Hauer
On Tue, Dec 08, 2015 at 09:37:48AM +0800, Peter Chen wrote: > Current USB HUB driver lacks of platform interfaces to configure > external signal on HUB chip, eg, the PHY input clock and gpio reset > pin for HUB, these kinds of HUBs are usually soldered at the board, > and they are not hot-plug USB

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-08 Thread Sascha Hauer
On Tue, Dec 08, 2015 at 05:26:56PM +0800, Peter Chen wrote: > On Tue, Dec 08, 2015 at 07:19:05AM +0100, Sascha Hauer wrote: > > > + hub_data = devm_kzalloc(dev, sizeof(*hub_data), GFP_KERNEL); > > > + if (!hub_data) > > > + return -ENOMEM; &g

[PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Sascha Hauer
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde --- The properties and their values have been taken

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Sascha Hauer
On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote: > Hi, > > On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote: > >From: Michael Grzeschik > > > >This adds two little devicetree helper functions for determining the > >dr_mode (host, peripheral, otg) a

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
On Wed, Jan 30, 2013 at 11:21:35AM +0530, kishon wrote: > On Wednesday 30 January 2013 02:00 AM, Sascha Hauer wrote: > >On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote: > >>Hi, > >> > >>On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote: > >

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
On Wed, Jan 30, 2013 at 10:06:28AM +0800, Peter Chen wrote: > On Tue, Jan 29, 2013 at 01:55:04PM +0200, Alexander Shishkin wrote: > > Sascha Hauer writes: > > > > > From: Michael Grzeschik > > > > > > This adds two little devicetree helper functio

[PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Sascha Hauer
-Budde Signed-off-by: Sascha Hauer --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h|7 drivers/usb/chipidea/ci13xxx_imx.c |3 ++ drivers/usb/chipidea/core.c| 40

[PATCH 1/6] USB: move bulk of otg/otg.c to phy/phy.c

2013-01-30 Thread Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer --- drivers/usb/otg/otg.c| 423 - drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy.c| 424

[PATCH 6/6] USB chipidea i.MX: introduce dr_mode property

2013-01-30 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer --- Documentation/devicetree/bindings/usb/ci13xxx-imx.txt |1 + drivers/usb/chipidea/ci13xxx_imx.c

[PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/usb

[PATCH 5/6] USB chipidea: introduce dual role mode pdata flags

2013-01-30 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/core.c | 21 +++-- include/linux/usb

[PATCH 3/6] usb: chipidea: ci13xxx-imx: create dynamic platformdata

2013-01-30 Thread Sascha Hauer
From: Michael Grzeschik This patch removes the limitation of having only one instance of the ci13xxx-imx platformdata and makes different configurations possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/chipidea

[PATCH] Add USB of helpers and use them in the chipidea driver

2013-01-30 Thread Sascha Hauer
Michael Grzeschik (3): usb: add devicetree helpers for determining dr_mode and phy_type usb: chipidea: ci13xxx-imx: create dynamic platformdata usb: chipidea: add PTW and PTS handling Sascha Hauer (2): USB chipidea: introduce dual role mode pdata flags

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Sascha Hauer
On Wed, Jan 30, 2013 at 05:54:54PM +0100, Matthieu CASTET wrote: > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > > index 57cae1f..dcb650f 100644 > > --- a/drivers/usb/chipidea/core.c > > +++ b/drivers/usb/chipidea/core.c > > @@ -67,6 +67,8 @@ > > #include > > #includ

Re: [PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 11:44:21AM +0530, kishon wrote: > Hi, > > On Wednesday 30 January 2013 08:59 PM, Sascha Hauer wrote: > >From: Michael Grzeschik > > > >This adds two little devicetree helper functions for determining the > >dr_mode (host, peripher

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 11:08:54AM +0800, Peter Chen wrote: > On Wed, Jan 30, 2013 at 04:29:40PM +0100, Sascha Hauer wrote: > > From: Michael Grzeschik > > > > +static void hw_phymode_configure(struct ci13xxx *ci) > > +{ > > + u32 portsc; > > + > &

Re: [PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:30:36AM +0800, Peter Chen wrote: > On Wed, Jan 30, 2013 at 04:29:38PM +0100, Sascha Hauer wrote: > > From: Michael Grzeschik > > > > This adds two little devicetree helper functions for determining the > > dr_mode (host, peripheral, ot

[PATCH v2] Add USB of helpers and use them in the chipidea driver

2013-01-31 Thread Sascha Hauer
dynamic platformdata USB: chipidea: add PTW and PTS handling Sascha Hauer (3): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea i.MX: introduce dr_mode property .../devicetree/bindings/usb/ci13xxx-imx.txt|6

[PATCH 4/6] USB: chipidea: add PTW and PTS handling

2013-01-31 Thread Sascha Hauer
-Budde Signed-off-by: Sascha Hauer --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h| 14 ++- drivers/usb/chipidea/ci13xxx_imx.c |3 ++ drivers/usb/chipidea/core.c| 39

[PATCH 1/6] USB: move bulk of otg/otg.c to phy/phy.c

2013-01-31 Thread Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer Reported-by: kishon Cc: Felipe Balbi --- drivers/usb/otg/otg.c| 423 - drivers/usb/phy/Makefile |1 + drivers/usb/phy

[PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/phy

[PATCH 6/6] USB chipidea i.MX: introduce dr_mode property

2013-01-31 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer --- Documentation/devicetree/bindings/usb/ci13xxx-imx.txt |1 + drivers/usb/chipidea/ci13xxx_imx.c

[PATCH 5/6] USB chipidea: introduce dual role mode pdata flags

2013-01-31 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/core.c | 21 +++-- include/linux/usb

[PATCH 3/6] USB: chipidea: ci13xxx-imx: create dynamic platformdata

2013-01-31 Thread Sascha Hauer
From: Michael Grzeschik This patch removes the limitation of having only one instance of the ci13xxx-imx platformdata and makes different configurations possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/chipidea

Re: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:20:59AM +0100, Greg KH wrote: > On Thu, Jan 31, 2013 at 10:01:09AM +0100, Sascha Hauer wrote: > > From: Michael Grzeschik > > > > This adds two little devicetree helper functions for determining the > > dr_mode (host, peripheral, otg) and phy

Re: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 02:42:48PM +0530, kishon wrote: > Hi, > > On Thursday 31 January 2013 02:31 PM, Sascha Hauer wrote: > >From: Michael Grzeschik > > > >This adds two little devicetree helper functions for determining the > >dr_mode (host, peripheral, otg) a

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:15:54AM +0100, Matthieu CASTET wrote: > >> Why you don't implement it ? > >> > >> If you don't implement it, I believe you should add a warning in order to > >> catch > >> it when used with lpm devices. > > > > I'm against adding a warning because current users seem to

Re: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 06:01:08PM +0800, Peter Chen wrote: > On Thu, Jan 31, 2013 at 10:01:09AM +0100, Sascha Hauer wrote: > > From: Michael Grzeschik > > > > > > + for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) > > +

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:05:44AM +0800, Peter Chen wrote: > On Wed, Jan 30, 2013 at 03:00:15PM +0100, Sascha Hauer wrote: > > On Wed, Jan 30, 2013 at 10:06:28AM +0800, Peter Chen wrote: > > > On Tue, Jan 29, 2013 at 01:55:04PM +0200, Alexander Shishkin wrote: > >

[PATCH] USB chipidea i.MX: use framework phy handling

2013-01-31 Thread Sascha Hauer
Sascha Hauer (2): USB mxs-phy: Register phy with framework USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy drivers/usb/chipidea/ci13xxx_imx.c | 31 ++- drivers/usb/otg/mxs-phy.c

[PATCH 1/2] USB mxs-phy: Register phy with framework

2013-01-31 Thread Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Signed-off-by: Sascha Hauer --- drivers/usb/otg/mxs-phy.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c

[PATCH 2/2] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-01-31 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci13xxx_imx.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index b598bb8f..1df4b41 100644 --- a/drivers/usb

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Fri, Feb 01, 2013 at 09:11:54AM +0800, Peter Chen wrote: > On Thu, Jan 31, 2013 at 11:29:13AM +0100, Sascha Hauer wrote: > > On Thu, Jan 31, 2013 at 10:05:44AM +0800, Peter Chen wrote: > > > On Wed, Jan 30, 2013 at 03:00:15PM +0100, Sascha Hauer wrote: > > > > On W

Re: [PATCH] USB chipidea i.MX: use framework phy handling

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 12:32:15PM +0100, Sascha Hauer wrote: > This series switches the mxs phy and the i.MX chipidea support > from homegrew phy support to use usb_add_phy_dev/devm_usb_get_phy_by_phandle. > > Based on > > [PATCH v2] Add USB of helpers and use them in t

[PATCH 7/9] como fec wip

2013-01-31 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- Documentation/devicetree/bindings/net/fsl-fec.txt | 20 ++ drivers/net/ethernet/freescale/fec.c | 77 - drivers/net/ethernet/freescale/fec.h |1 + 3 files changed, 67 insertions(+), 31 deletions(-) diff

[PATCH 5/9] USB chipidea: introduce dual role mode pdata flags

2013-01-31 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/core.c | 21 +++-- include/linux/usb

[PATCH 3/9] USB: chipidea: ci13xxx-imx: create dynamic platformdata

2013-01-31 Thread Sascha Hauer
From: Michael Grzeschik This patch removes the limitation of having only one instance of the ci13xxx-imx platformdata and makes different configurations possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer Reviewed-by: Peter Chen

[PATCH 2/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/phy

[PATCH 8/9] USB mxs-phy: Register phy with framework

2013-01-31 Thread Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Signed-off-by: Sascha Hauer --- drivers/usb/otg/mxs-phy.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c

[PATCH v3] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
s for determining dr_mode and phy_type USB: chipidea: ci13xxx-imx: create dynamic platformdata USB: chipidea: add PTW and PTS handling Sascha Hauer (6): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea i.MX: intr

[PATCH 4/9] USB: chipidea: add PTW and PTS handling

2013-01-31 Thread Sascha Hauer
-Budde Signed-off-by: Sascha Hauer --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h| 14 ++- drivers/usb/chipidea/ci13xxx_imx.c |3 ++ drivers/usb/chipidea/core.c| 39

[PATCH 6/9] USB chipidea i.MX: introduce dr_mode property

2013-01-31 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer Reviewed-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci13xxx-imx.txt |1 + drivers/usb/chipidea

[PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-01-31 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci13xxx_imx.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index b598bb8f..1df4b41 100644 --- a/drivers/usb

[PATCH 1/9] USB: move bulk of otg/otg.c to phy/phy.c

2013-01-31 Thread Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer Reported-by: Kishon Vijay Abraham I Cc: Felipe Balbi --- drivers/usb/otg/otg.c| 423 drivers/usb/phy/Makefile |1

Re: [PATCH v3] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-01 Thread Sascha Hauer
Apparantly I was not fully awake while sending this series :( On Fri, Feb 01, 2013 at 08:52:03AM +0100, Sascha Hauer wrote: > (resend because I got the linux-usb address wrong) > > Here's another round of the dr_mode/phy_type patches. I think they should > be ready for mergin

[PATCH 6/9] USB chipidea: introduce dual role mode pdata flags

2013-02-04 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/core.c | 21 +++-- include/linux/usb

[PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-04 Thread Sascha Hauer
etree helpers for determining dr_mode and phy_type USB: chipidea: ci13xxx-imx: create dynamic platformdata USB: chipidea: add PTW and PTS handling Sascha Hauer (5): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea

[PATCH 4/9] USB: chipidea: ci13xxx-imx: create dynamic platformdata

2013-02-04 Thread Sascha Hauer
From: Michael Grzeschik This patch removes the limitation of having only one instance of the ci13xxx-imx platformdata and makes different configurations possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer Reviewed-by: Peter Chen

[PATCH 7/9] USB chipidea i.MX: introduce dr_mode property

2013-02-04 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer Reviewed-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci13xxx-imx.txt |1 + drivers/usb/chipidea

[PATCH 1/9] usb: otg: use try_module_get in all usb_get_phy functions and add missing module_put

2013-02-04 Thread Sascha Hauer
e_get() to usb_get_phy() and usb_get_phy_dev(). Further the missing module_put() is added to usb_put_phy(). Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/otg/otg.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/otg/otg.c b/drive

[PATCH 5/9] USB: chipidea: add PTW and PTS handling

2013-02-04 Thread Sascha Hauer
-Budde Signed-off-by: Sascha Hauer --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h| 14 ++- drivers/usb/chipidea/ci13xxx_imx.c |3 ++ drivers/usb/chipidea/core.c| 39

[PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-04 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci13xxx_imx.c | 39 +--- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index b598bb8f..136869b 100644 --- a/drivers

[PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-04 Thread Sascha Hauer
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Signed-off-by: Sascha Hauer --- drivers/usb/phy

[PATCH 8/9] USB mxs-phy: Register phy with framework

2013-02-04 Thread Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Signed-off-by: Sascha Hauer --- drivers/usb/otg/mxs-phy.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c

[PATCH 2/9] USB: move bulk of otg/otg.c to phy/phy.c

2013-02-04 Thread Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer Reported-by: Kishon Vijay Abraham I Cc: Felipe Balbi --- drivers/usb/otg/otg.c| 427 drivers/usb/phy/Makefile |1

Re: [PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-05 Thread Sascha Hauer
On Tue, Feb 05, 2013 at 03:45:12PM +0400, Sergei Shtylyov wrote: > Hello. > > On 04-02-2013 17:24, Sascha Hauer wrote: > > >Signed-off-by: Sascha Hauer > >--- > > drivers/usb/chipidea/ci13xxx_imx.c | 39 > > +--- >

Re: [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-07 Thread Sascha Hauer
Alexander, Did you have a chance to look at this series? Development of this driver has stalled for too long now, I don't want to miss the next merge window. Thanks Sascha On Mon, Feb 04, 2013 at 02:24:26PM +0100, Sascha Hauer wrote: > 4th round of patches. > > Peter, I would

Re: [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-12 Thread Sascha Hauer
On Thu, Feb 07, 2013 at 11:56:32AM +0100, Sascha Hauer wrote: > Alexander, > > Did you have a chance to look at this series? Development of this driver > has stalled for too long now, I don't want to miss the next merge > window. Alexander, Any comments? Thanks Sascha &

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 11:58:22AM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 14, 2013 at 10:49:44AM +0100, Marc Kleine-Budde wrote: > > >> diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c > > >> index d29503e..ad4d87d 100644 > > >> --- a/drivers/usb/usb-common.c > > >> +++ b

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 12:15:10PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 14, 2013 at 11:07:22AM +0100, Sascha Hauer wrote: > > > > >> @@ -32,4 +35,37 @@ const char *usb_speed_string(enum > > > > >> usb_device_speed speed) > > >

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 03:10:15PM +0200, Felipe Balbi wrote: > On Thu, Feb 14, 2013 at 12:24:49PM +0100, Sascha Hauer wrote: > > On Thu, Feb 14, 2013 at 12:15:10PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Feb 14, 2013 at

Re: [PATCH 1/2] USB mxs-phy: Register phy with framework

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 12:37:29PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Jan 31, 2013 at 12:32:16PM +0100, Sascha Hauer wrote: > > We now have usb_add_phy_dev(), so use it to register with the framework > > to be able to find the phy from the USB driver. > >

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 08:04:44PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 14, 2013 at 05:06:55PM +0100, Sascha Hauer wrote: > > > > > > > Maybe we can ignore dr_mode in host-only and device-only builds > > > > > > &g

Re: [PATCH 1/2] USB mxs-phy: Register phy with framework

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 08:00:11PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 14, 2013 at 05:23:37PM +0100, Sascha Hauer wrote: > > On Thu, Feb 14, 2013 at 12:37:29PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Jan 31, 2013 at 12:32:

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-15 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 09:36:26PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 14, 2013 at 07:30:26PM +0100, Sascha Hauer wrote: > > > > > yeah, this is why I said we should ignore dr_mode (or bail out) when > > > > > !OTG. > > > > > >

Re: [PATCH 2/9] USB: move bulk of otg/otg.c to phy/phy.c

2013-02-19 Thread Sascha Hauer
On Tue, Feb 19, 2013 at 11:30:19AM +0200, Felipe Balbi wrote: > On Mon, Feb 04, 2013 at 02:24:28PM +0100, Sascha Hauer wrote: > > Most of otg/otg.c is not otg specific, but phy specific, so move it > > to the phy directory. > > > > Signed-off-by: Sascha Hauer &g

Re: [PATCH v10 6/8] usb: chipidea: imx: add internal vbus regulator control

2013-02-27 Thread Sascha Hauer
On Wed, Feb 27, 2013 at 09:55:10AM +0200, Felipe Balbi wrote: > Hi, > > On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote: > > - For host, the vbus should always be on. > > - For otg, the vbus is off defaultly, the vbus needs to be > > turned on/off when usb role switches. > > > > Signed

Re: [PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-16 Thread Sascha Hauer
On Thu, Jul 12, 2012 at 03:01:52PM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver export functions needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad ove

Re: [PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-16 Thread Sascha Hauer
On Mon, Jul 16, 2012 at 04:38:38PM +0800, Richard Zhao wrote: > > > > NACK > Right, it's a bad design. I'm considering change it too. Maybe I will > move it out this patch series. As I asked you in another mail in this > thread, do you think it's good to put it here or in mach-imx/ ? I prefer it

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Sascha Hauer
On Wed, Jul 18, 2012 at 06:29:06PM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver set operations needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad over-

Re: [PATCH v2 2/2] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-18 Thread Sascha Hauer
On Wed, Jul 18, 2012 at 06:29:07PM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao > --- > arch/arm/boot/dts/imx6q-sabrelite.dts |4 > arch/arm/boot/dts/imx6q.dtsi | 19 +++ > arch/arm/mach-imx/clk-imx6q.c |1 + > 3 files changed, 20 insert

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Sascha Hauer
On Wed, Jul 18, 2012 at 07:19:17PM +0800, Richard Zhao wrote: > > > + > > > +struct imx6q_usbmisc { > > > + void __iomem *base; > > > + struct clk *clk; > > > + struct device *usb_dev[USB_DEV_MAX]; > > > + spinlock_t lock; > > > + > > > + int disable_oc:USB_DEV_MAX; > > > +}; > > > > Please add a

Re: [PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-30 Thread Sascha Hauer
On Thu, Jul 26, 2012 at 06:35:14PM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver set operations needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad over-

Re: [PATCH v4 1/3] USB: chipidea: add imx usbmisc support

2012-07-31 Thread Sascha Hauer
On Wed, Aug 01, 2012 at 10:51:07AM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver set operations needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad over-

Re: [PATCH v5 0/3] imx: add usbmisc support

2012-08-03 Thread Sascha Hauer
hink this is good enough to go now. Acked-by: Sascha Hauer > > .../devicetree/bindings/usb/ci13xxx-imx.txt|5 + > .../devicetree/bindings/usb/usbmisc-imx.txt| 14 ++ > arch/arm/boot/dts/imx6q-sabrelite.dts |1 + > arch/arm/boot/dts/imx6q.d

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-29 Thread Sascha Hauer
On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > driver set operations needed by ci13xxx_imx driver. > > > >

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-29 Thread Sascha Hauer
On Wed, Aug 29, 2012 at 01:18:10PM +0300, Alexander Shishkin wrote: > Sascha Hauer writes: > > > On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > i.MX usb controllers shares non-core regist

Re: [PATCH RFC] USB: EHCI on imx53

2012-09-03 Thread Sascha Hauer
Hi Roland, On Mon, Sep 03, 2012 at 04:27:57PM +0200, Roland Stigge wrote: > Hi, > > this is my first try on activating EHCI on imx53 (primarily via dt). However, > probe() still hangs on the first ehci_writel() l.189. I guess some > clock/enabling is still missing? > > Sascha, do you already hav

Re: [PATCH v12 02/13] usb: chipidea: imx: remove vbus regulator operation

2013-07-10 Thread Sascha Hauer
On Thu, Jul 11, 2013 at 02:27:10PM +0800, Peter Chen wrote: > Since we have added vbus reguatlor operation at common > host file (chipidea/host.c), the glue layer vbus operation > isn't needed any more. > > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 30 +++--

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sascha Hauer
On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: > On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: > > On Sat, 20 Jul 2013, Greg KH wrote: > > > > > > >>That should be passed using platform data. > > > > > > > > > >Ick, don't pass strings around, pass pointers. If you have pla

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: > At former design, both ci_hdrc_imx and usbmisc_imx are individual > module, ci_hdrc_imx is glue layer for imx usb driver. usbmisc_imx > handles non-core registers which has different register layout > for imx SoC serials, it usually supp

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 03:00:05PM +0800, Peter Chen wrote: > On Wed, Aug 07, 2013 at 10:15:22AM +0200, Sascha Hauer wrote: > > On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: > > > At former design, both ci_hdrc_imx and usbmisc_imx are individual > > >

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: > - > - reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET; > - > - if (usbdev->evdo) { > - spin_lock_irqsave(&usbmisc->lock, flags); > - val = readl(reg); > - writel(val | MX25_BM_EXTERNAL_VBUS_DIVI

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 03:54:06PM +0800, Peter Chen wrote: > On Wed, Aug 07, 2013 at 11:08:45AM +0200, Sascha Hauer wrote: > > > > > > > > - Convert imx-usb-misc from a driver into something which is called > > > > directly > > > > - add

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: > diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt > b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt > index b4b5b79..13720a2 100644 > --- a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt > +++ b/Documenta

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 05:24:45PM +0800, Peter Chen wrote: > On Wed, Aug 07, 2013 at 12:05:07PM +0200, Sascha Hauer wrote: > > > > > > We need to know controller number, like pdev->id in the past. > > > The registers at non core register is messy, the s

Re: [PATCH v2 5/5] arm: dts: imx: Delete usbmisc_imx

2013-08-08 Thread Sascha Hauer
On Thu, Aug 08, 2013 at 03:33:01PM +0800, Peter Chen wrote: > Since ci_hdrc_imx and usbmisc_imx has relationship between each other, > they can't be existed as two modules. We change the code, and make > the usbmisc_imx has no longer a driver. > > Due to above reason, we introduce non core registe

Re: [PATCH v2 5/5] arm: dts: imx: Delete usbmisc_imx

2013-08-08 Thread Sascha Hauer
On Thu, Aug 08, 2013 at 06:19:43PM +0800, Peter Chen wrote: > > > - compatible = "fsl,imx25-usbmisc"; > > > - clocks = <&clks 9>, <&clks 70>, <&clks 8>; > > > - clock-names = "ipg", "ahb", "per"; > > > -

[PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-08 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 14362c0..11ed423 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea

[PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-08 Thread Sascha Hauer
usbmisc_imx driver. Also instead of letting the usbmisc_imx driver call back into the ci_hdrc_imx driver, pass the needed data in the first place. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci_hdrc_imx.c | 74 +++-- drivers/usb/chipidea/ci_hdrc_imx.h | 17 ++- drivers

  1   2   >