[PATCH 8/8] usb: phy: phy-nop: Remove redundant use of of_match_ptr

'nop_xceiv_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-nop.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-nop.c b/drivers/usb/phy/phy-nop.c index 638cc5d

Re: [PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

On 21 May 2013 20:26, Alan Stern wrote: > On Tue, 21 May 2013, Sergei Shtylyov wrote: > >> Hello. >> >> On 21-05-2013 16:05, Ben Dooks wrote: >> >> >> 'omap_ehci_dt_ids' is always compiled in. Hence use of >> >> of_match_ptr is unnecessary. >> >> > Thought it was defined as tristate in the Kconfig

[PATCH 1/1] usb: host: ehci-spear: Fix potential NULL pointer dereferencing

'hcd' is dereferenced before NULL check. Move the assignment after the check to avoid potential NULL pointer dereferencing error. Signed-off-by: Sachin Kamat Cc: Viresh Kumar --- drivers/usb/host/ehci-spear.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

On 21 May 2013 22:10, Alan Stern wrote: > On Tue, 21 May 2013, Sachin Kamat wrote: > >> On 21 May 2013 20:26, Alan Stern wrote: >> > On Tue, 21 May 2013, Sergei Shtylyov wrote: >> > >> >> Hello. >> >> >> >> On 21-05-2013 1

Re: [PATCH 1/1] usb: host: ehci-spear: Fix potential NULL pointer dereferencing

On 22 May 2013 19:50, Alan Stern wrote: > On Wed, 22 May 2013, Sachin Kamat wrote: > >> 'hcd' is dereferenced before NULL check. Move the assignment after >> the check to avoid potential NULL pointer dereferencing error. > > Since the pointer in question can ne

[PATCH 1/1] usb: host: ehci-spear: Remove redundant checks

'hcd' can never be NULL and the spear_ehci_hcd_drv_remove routine will never be called in_interrupt. Hence remove these checks. Signed-off-by: Sachin Kamat Cc: Viresh Kumar Cc: Alan Stern --- Compile tested on linux-next (20130522). --- drivers/usb/host/ehci-spear.c |4 --

[PATCH 3/3] usb: phy-twl6030: Add missing braces

Silences the below warning: WARNING: sizeof *twl should be sizeof(*twl) Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-twl6030-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c index

[PATCH 1/3] usb: phy-keystone: Remove redundant of_match_ptr helper

'keystone_usbphy_ids' is always compiled in. Hence the helper macro is not needed. Signed-off-by: Sachin Kamat Cc: WingMan Kwok --- drivers/usb/phy/phy-keystone.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-keystone.c b/drivers/u

[PATCH 2/3] usb: phy-fsm: Staticize local symbols

Local symbols appearing only in this file are made static. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-fsm-usb.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm-usb.c index 62238726fb1c..2313b87434ad

[PATCH] usb: ehci: Cleanup usb-ehci-orion.h header

Commit c02cecb92ed4 ("ARM: orion: move platform_data definitions") moved the file to the current location but forgot to remove the pointer to its previous location. Clean it up. While at it also change the header file protection macros appropriately. Signed-off-by: Sachin Kamat --

[PATCH 2/2] usb: gadget: s3c-hsudc: Remove unused label

Fixes the following compilation warning: drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ defined but not used [-Wunused-label] Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsudc.c |1 - 1 file

[PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

dc_reinit’: drivers/usb/gadget/s3c2410_udc.c:1632:3: error: cannot take address of bit-field ‘maxpacket’ usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket); Signed-off-by: Sachin Kamat Cc: Robert Baldyga --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 file changed, 1 inser

Re: [PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

On 3 January 2014 10:58, Sachin Kamat wrote: > Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. > Fixes the following compilation error introduced by commit e117e742d310 > ("usb: gadget: add "maxpacket_limit" field to struct usb_ep"

[PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

dc_reinit’: drivers/usb/gadget/s3c2410_udc.c:1632:3: error: cannot take address of bit-field ‘maxpacket’ usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket); Signed-off-by: Sachin Kamat Reviewed-by: Robert Baldyga --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 file changed,

[PATCH Resend 2/2] usb: gadget: s3c-hsudc: Remove unused label

Fixes the following compilation warning: drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ defined but not used [-Wunused-label] Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsudc.c |1 - 1 file

Re: [PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

On 3 February 2014 13:59, Sachin Kamat wrote: > Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. > Fixes the following compilation error introduced by commit e117e742d310 > ("usb: gadget: add "maxpacket_limit" field to struc

Re: [PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

On 18 February 2014 20:58, Felipe Balbi wrote: > On Mon, Feb 03, 2014 at 01:59:38PM +0530, Sachin Kamat wrote: >> Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. >> Fixes the following compilation error introduced by commit e117e742d

Re: [PATCH Resend 2/2] usb: gadget: s3c-hsudc: Remove unused label

On 18 February 2014 20:58, Felipe Balbi wrote: > On Mon, Feb 03, 2014 at 01:59:39PM +0530, Sachin Kamat wrote: >> Fixes the following compilation warning: >> drivers/usb/gadget/s3c-hsudc.c: In function 's3c_hsudc_probe': >> drivers/usb/gadget/s3c-hsudc.c:1347:1:

Re: [PATCH 2/4] ARM: dts: Add usb2phy to Exynos 5250

Hi Vivek, On 30 April 2014 14:25, Vivek Gautam wrote: > From: Kamil Debski > > Add support to PHY of USB2 of the Exynos 5250 SoC. > > Signed-off-by: Kamil Debski > [gautam.vi...@samsung.com: Split the usb phy entries from > syscon entries from earlier patch: dts: Add usb2phy to Exynos 5250] > [

Re: [PATCH 4/4] ARM: dts: Add usb 2.0 support on exynos5420

On 30 April 2014 14:25, Vivek Gautam wrote: > Add required device node for ehci and ohci controllers to > enable USB 2.0 support. > > Signed-off-by: Vivek Gautam > --- > arch/arm/boot/dts/exynos5420.dtsi | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(

[PATCH 1/1] usb: host: max3421-hcd: Use module_spi_driver

module_spi_driver simplifies the code by eliminating boilerplate code. Signed-off-by: Sachin Kamat --- drivers/usb/host/max3421-hcd.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c index

[PATCH 1/2] usb: ohci-exynos: Use NULL instead of 0

The third argument of devm_of_phy_get expects a pointer. Hence use NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-exynos.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index

[PATCH 2/2] usb: ehci-exynos: Use NULL instead of 0

The third argument of devm_of_phy_get expects a pointer. Hence use NULL instead of 0. Fixes the following warning: drivers/usb/host/ehci-exynos.c:91:51: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/usb/host/ehci-exynos.c |2 +- 1 file changed, 1

[PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

for Exynos 5420 SoC too. Signed-off-by: Sachin Kamat Cc: Kishon Vijay Abraham I --- drivers/phy/Kconfig | 37 +++-- drivers/usb/host/Kconfig | 10 ++ 2 files changed, 13 insertions(+), 34 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers

[PATCH 2/2] usb: dwc3: Kconfig: Select PHY drivers for Exynos DWC3

ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat Cc: Kishon Vijay Abraham I --- drivers/phy/Kconfig |8 +--- drivers/usb/dwc3/Kconfig |3 ++- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

Hi Vivek, On Thu, Jun 26, 2014 at 1:39 PM, Vivek Gautam wrote: > Hi Sachin, > > > On Thu, Jun 26, 2014 at 11:09 AM, Sachin Kamat > wrote: >> EHCI and OHCI drivers on Exynos platforms do not work without their >> corresponding SoC specific phy drivers. Hence it make

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

Hi Vivek, On Thu, Jun 26, 2014 at 1:55 PM, Sachin Kamat wrote: > Hi Vivek, > > On Thu, Jun 26, 2014 at 1:39 PM, Vivek Gautam > wrote: >> Hi Sachin, >> >> >> On Thu, Jun 26, 2014 at 11:09 AM, Sachin Kamat >> wrote: >>> EHCI and OHCI dr

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

Hi Kishon, On Thu, Jun 26, 2014 at 2:19 PM, Kishon Vijay Abraham I wrote: > Hi Sachin, > > On Thursday 26 June 2014 11:09 AM, Sachin Kamat wrote: >> EHCI and OHCI drivers on Exynos platforms do not work without their >> corresponding SoC specific phy drivers. Hence it make

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

On Fri, Jun 27, 2014 at 10:23 PM, Olof Johansson wrote: > On Fri, Jun 27, 2014 at 9:32 AM, Doug Anderson wrote: >> Felipe, >> >> On Fri, Jun 27, 2014 at 8:59 AM, Felipe Balbi wrote: I'll admit to not having been involved with the previous discussions, but this seems strange to me. Are

[PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat --- drivers/usb/dwc3/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig

Re: [PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

On Mon, Jun 30, 2014 at 10:19 PM, Felipe Balbi wrote: > On Mon, Jun 30, 2014 at 02:33:14PM +0530, Sachin Kamat wrote: >> Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS >> as this IP is available only on Exynos5 platforms. >> >> Signed-off-by: Sachin Ka

Re: Re: [PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

> On Tue, Jul 01, 2014 at 08:50:19AM +0530, Sachin Kamat wrote: >> On Mon, Jun 30, 2014 at 10:19 PM, Felipe Balbi >> wrote: >>> On Mon, Jun 30, 2014 at 02:33:14PM +0530, Sachin Kamat wrote: >>>> Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS

Re: [PATCH 1/3] usb: usb3503: fix build warning

Hi Joonyoung, On Thu, Jul 10, 2014 at 9:53 AM, Joonyoung Shim wrote: > This fixes below build warning. > > drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: > drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > dev_e

Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

ue with ehci-exynos and ohci-exynos, wherein > in the absence of SAMSUNG_USB2PHY config symbol, we end up getting > the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs > are not configured properly. > > Reported-by: Sachin Kamat > Signed-off-by: Vivek Gautam >

<    1   2