Re: [PATCH 1/1] usb: musb: Remove duplicate inclusion of linux/of.h

ping On 19 November 2012 17:03, Sachin Kamat wrote: > linux/of.h was included twice. > > Signed-off-by: Sachin Kamat > --- > drivers/usb/musb/musb_dsps.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/musb_dsps.c b/driv

[PATCH 1/1] usb: dwc3: Use devm_kzalloc

devm_kzalloc is device managed and makes error handling and cleanup simpler. While at it also fixed the return value when platform_device_alloc failed in probe function. Cc: Anton Tikhomirov Signed-off-by: Sachin Kamat --- Compile tested on linux-next tree. --- drivers/usb/dwc3/dwc3-exynos.c

Re: [PATCH 1/1] usb: dwc3: Use devm_kzalloc

On 12 December 2012 16:51, Felipe Balbi wrote: > On Wed, Dec 12, 2012 at 04:13:15PM +0530, Sachin Kamat wrote: >> devm_kzalloc is device managed and makes error handling and cleanup >> simpler. While at it also fixed the return value when platform_device_alloc >> fai

[PATCH 1/1] usb: gadget: s3c-hsudc: Use devm_regulator_bulk_get

devm_regulator_bulk_get is device managed and makes exit code simpler. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsudc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index 52379b1..d2b8791

[PATCH 1/1] USB: OHCI: Fix definition overriding while registering Exynos OHCI driver

/usb/host/ohci-hcd.c:1191:0: warning: "PLATFORM_DRIVER" redefined [enabled by default] drivers/usb/host/ohci-hcd.c:1110:0: note: this is the location of the previous definition drivers/usb/host/ohci-exynos.c:276:31: warning: ‘exynos_ohci_driver’ defined but not used [-Wunused-variable

[PATCH 1/1] usb: gadget: s3c-hsotg: Use devm_regulator_bulk_get API

devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsotg.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index

[PATCH 1/3] usb: phy: samsung: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 2/3] usb: phy: omap-usb3: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 3/3] usb: phy: omap-control-usb: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/1] usb: gadget: fsl_udc_core: Use module_platform_driver_probe macro

module_platform_driver_probe() eliminates the boilerplate and simplifies the code. Signed-off-by: Sachin Kamat Cc: Li Yang --- drivers/usb/gadget/fsl_udc_core.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers

[PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

Adds header file protection macros. Signed-off-by: Sachin Kamat --- include/linux/platform_data/s3c-hsotg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/platform_data/s3c-hsotg.h b/include/linux/platform_data/s3c-hsotg.h index 97ec12c..ff5892d

Re: [PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

On 17/07/2012, Felipe Balbi wrote: > On Tue, Jul 17, 2012 at 02:40:10PM +0530, Sachin Kamat wrote: >> Adds header file protection macros. > > you need to comment if you actually ran into an issue. Is there any file > which ends up with double inclusion of this header or are yo

[PATCH Resend] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

Adds header file protection macros to avoid multiple inclusion. Signed-off-by: Sachin Kamat --- include/linux/platform_data/s3c-hsotg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/platform_data/s3c-hsotg.h b/include/linux/platform_data/s3c-hsotg.h

Re: [PATCH v2 2/5] usb: s3c-hsotg: Adding phy driver support

Hi Praveen, Some minor comments: On 7 August 2012 12:58, Praveen Paneri wrote: > Adding the transceiver to hsotg driver. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Praveen Paneri > --- > drivers/usb/gadget/s3c-hsotg.c | 3

[PATCH 0/5] usb: gadget: s3c2410_udc: Fixes and cleanup

This patch series fixes several errors and warnings related to coding style and compilation in s3c2410_udc driver. It is compile tested using s3c2410_defconfig based on linux-next tree. Sachin Kamat (5): usb: gadget: s3c2410_udc: Replace with usb: gadget: s3c2410_udc: Use pr_* functions

[PATCH 1/5] usb: gadget: s3c2410_udc: Replace with

Fixes the following warning: WARNING: Use #include instead of Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index f2e51f5..7acecc0

[PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

Replace printk with corresponding pr_* functions. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 7acecc0..7e2ce44

[PATCH 3/5] usb: gadget: s3c2410_udc: Silence checkpatch errors and warnings

Silences about 75 errors and warnings related to - Spacing - Alignment of braces - Line over 80 characters Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c | 126 ++--- 1 files changed, 61 insertions(+), 65 deletions(-) diff --git a/drivers/usb

[PATCH 4/5] usb: gadget: s3c2410_udc: Move assignment outside if condition

Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c

[PATCH 5/5] usb: gadget: s3c2410_udc: Do not use integer for NULL

'req' being a pointer shouldn't be equated with 0. Fixes the following compilation warning: drivers/usb/gadget/s3c2410_udc.c:1299:13: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 files changed, 1 i

Re: [PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

On 22 August 2012 11:43, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Wed, Aug 22, 2012 at 11:13 AM, Sachin Kamat > wrote: >> Replace printk with corresponding pr_* functions. >> >> Signed-off-by: Sachin Kamat >> --- >> drivers/usb/gadget/s3c2410_udc.c

Re: [PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

On 22 August 2012 11:48, Felipe Balbi wrote: > Hi, > > On Wed, Aug 22, 2012 at 11:13:16AM +0530, Sachin Kamat wrote: >> Replace printk with corresponding pr_* functions. >> >> Signed-off-by: Sachin Kamat >> --- >> drivers/usb/gadget/s3c2410_udc.c |

[PATCH v2 4/5] usb: gadget: s3c2410_udc: Move assignment outside if condition

Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c

[PATCH v2 5/5] usb: gadget: s3c2410_udc: Do not use integer for NULL

'req' being a pointer shouldn't be equated with 0. Fixes the following compilation warning: drivers/usb/gadget/s3c2410_udc.c:1299:13: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 files changed, 1 i

[PATCH v2 3/5] usb: gadget: s3c2410_udc: Silence checkpatch errors and warnings

Silences about 75 errors and warnings related to - Spacing - Alignment of braces - Line over 80 characters Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c | 124 ++--- 1 files changed, 60 insertions(+), 64 deletions(-) diff --git a/drivers/usb

[PATCH v2 2/5] usb: gadget: s3c2410_udc: Use pr_* and dev_err functions

Replace printk with corresponding pr_* and dev_err functions. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 7acecc0

[PATCH v2 1/5] usb: gadget: s3c2410_udc: Replace with

Fixes the following warning: WARNING: Use #include instead of Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index f2e51f5..7acecc0

[PATCH v2 0/5] usb: gadget: s3c2410_udc: Fixes and cleanup

due to this change. Sachin Kamat (5): usb: gadget: s3c2410_udc: Replace with usb: gadget: s3c2410_udc: Use pr_* and dev_err functions usb: gadget: s3c2410_udc: Silence checkpatch errors and warnings usb: gadget: s3c2410_udc: Move assignment outside if condition usb: gadget: s3c2410_udc

Re: [PATCH v2 0/5] usb: gadget: s3c2410_udc: Fixes and cleanup

Hi Felipe, Any comments on this series? On 22 August 2012 15:48, Sachin Kamat wrote: > This patch series fixes several errors and warnings related to coding style > and compilation in s3c2410_udc driver. > It is compile tested using s3c2410_defconfig based on linux-next tree. > >

[PATCH 1/3] usb: gadget: s3c-hsudc: Use devm_* functions

devm_* functions are used to replace kzalloc, request_mem_region, ioremap clk_get and request_irq functions in probe call. With the usage of devm_* functions explicit freeing and unmapping is not required. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsudc.c | 41

[PATCH 2/3] usb: gadget: s3c-hsudc: Add missing braces around sizeof

Silences the following checkpatch warning: WARNING: sizeof *hsreq should be sizeof(*hsreq) Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsudc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c

[PATCH 3/3] usb: gadget: s3c-hsudc: Replace 0 with NULL for pointers

Silences the following type of sparse warnings: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsudc.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c

[PATCH] usb: gadget: s3c-hsotg: Use devm_clk_get function

devm_* functions are already used in this file. Hence convert clk_get to devm_clk_get for completeness. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsotg.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget

Re: [PATCH 3/3] usb: gadget: s3c-hsudc: Replace 0 with NULL for pointers

Hi On 3 September 2012 16:37, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Sep 3, 2012 at 3:48 PM, Sachin Kamat wrote: >> Silences the following type of sparse warnings: >> warning: Using plain integer as NULL pointer >> >> Signed-off-by: Sachin Kamat

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

On 18 June 2013 15:24, Manjunath Goudar wrote: > > > On 14 June 2013 01:22, Alan Stern wrote: >> >> On Thu, 13 Jun 2013, Tomasz Figa wrote: >> >> > > + rc = ohci_suspend(hcd, do_wakeup); >> > > + if (rc == 0 && do_wakeup && HCD_WAKEUP_PENDING(hcd)) { >> > > + ohci_resume(hcd, false)

[PATCH 1/1] usb: phy: samsung: Fix an error message typo

The error message is common to both clk_get functions. Update it accordingly. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-samsung-usb2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-samsung-usb2.c b/drivers/usb/phy/phy-samsung-usb2.c index

[PATCH 1/1] usb: samsung: Update Exynos ehci/ohci bindings documentation

Updated the document as per the latest implementation. While at it also fixed some trivial typos. Signed-off-by: Sachin Kamat --- .../devicetree/bindings/usb/exynos-usb.txt | 38 +++- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/Documentation

[PATCH 1/1] usb: phy: samsung: Update usbphy documentation

Updated the documentation as per the latest driver implementation. While at it also fixed some trivial typos. Signed-off-by: Sachin Kamat --- .../devicetree/bindings/usb/samsung-usbphy.txt | 48 ++-- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a

[PATCH 1/1] usb: dwc3: Remove duplicate inclusion of otg.h

otg.h header file was included twice. Signed-off-by: Sachin Kamat --- drivers/usb/dwc3/core.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 577af1b..474162e 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c

[PATCH 1/1] usb: phy: omap-usb3: Fix return value

The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-omap-usb3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c index fc15694..4e8a040 100644

[PATCH 2/2] usb: gadget: f_eem: Staticize eem_alloc

'eem_alloc' is local to this file. Make it static. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/f_eem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_eem.c b/drivers/usb/gadget/f_eem.c index d00392d..d61c11d 100644 --- a/drivers/

[PATCH 1/2] usb: gadget: f_ecm: Staticize ecm_alloc

'ecm_alloc' is local to this file. Make it static. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/f_ecm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_ecm.c b/drivers/usb/gadget/f_ecm.c index edab45d..8d9e6f7 100644 --- a/drivers/

[PATCH 1/1] usb: xhci: Staticize xhci_del_comp_mod_timer

'xhci_del_comp_mod_timer' is local to this file. Signed-off-by: Sachin Kamat --- drivers/usb/host/xhci-hub.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index fae697e..2b61700 100644 --- a/driver

[PATCH 1/1] usb: host: fsl-mph-dr-of: Staticize local symbols

Local symbols used in this file are made static. Signed-off-by: Sachin Kamat Cc: Anatolij Gustschin --- drivers/usb/host/fsl-mph-dr-of.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c index

[PATCH 1/1] usb: gadget: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/amd5536udc.c |2 -- drivers/usb/gadget/goku_udc.c |1 - drivers/usb/gadget/net2280.c|1 - drivers/usb/gadget/pch_udc.c|1 - 4 files changed, 5 deletions

[PATCH 1/1] usb: dwc3: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/usb/dwc3/dwc3-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 997ebe4..f41ce36 100644 --- a/drivers/usb/dwc3/dwc3

[PATCH 1/1] USB: EHCI: tegra: Remove incorrect clk_put

tegra->clk is obtained using devm_clk_get(). Hence clk_put should not be used. Signed-off-by: Sachin Kamat Cc: Stephen Warren --- drivers/usb/host/ehci-tegra.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/e

[PATCH 1/5] usb: musb_am335x: Remove redundant of_match_ptr

The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat --- drivers/usb/musb/musb_am335x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_am335x.c b/drivers/usb/musb

[PATCH 2/5] usb: musb_dsps: Remove redundant of_match_ptr

The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat Cc: Ravi B --- drivers/usb/musb/musb_dsps.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb

[PATCH 3/5] usb: phy: am335x-control: Remove redundant of_match_ptr

The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-am335x-control.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb

[PATCH 5/5] usb: phy: tegra-usb: Remove redundant of_match_ptr

The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat Cc: Stephen Warren Cc: linux-te...@vger.kernel.org --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 4/5] usb: phy: am335x: Remove redundant of_match_ptr

The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-am335x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c

Re: [PATCH 1/5] usb: musb_am335x: Remove redundant of_match_ptr

Hi Felipe, On 30 September 2013 09:44, Sachin Kamat wrote: > The data structure of_match_ptr() protects is always compiled in. > Hence of_match_ptr() is not needed. > > Signed-off-by: Sachin Kamat > --- > drivers/usb/musb/musb_am335x.c |2 +- > 1 file changed, 1 ins

Re: [PATCH 3/5] USB: ehci-exynos: Remove non-DT support

Hi Jingoo, On 10 October 2013 12:01, Jingoo Han wrote: > The non-DT for EXYNOS SoCs is not supported from v3.11. > Thus, there is no need to support non-DT for Exynos EHCI driver. > > The 'include/linux/platform_data/usb-ehci-exynos.h' file has been > used for non-DT support. Thus, the 'usb-ehci-

[PATCH 2/5] usb: ohci-at91: Include linux/of.h header

'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-at91.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c ind

[PATCH 1/5] usb: gadget: s3c-hsotg: Include linux/of.h header

'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c-hsotg.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hso

[PATCH 4/5] usb: misc: usb3503: Include linux/of.h header

'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat --- drivers/usb/misc/usb3503.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index a31641

[PATCH 5/5] usb: phy: twl6030-usb: Include linux/of.h header

'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-twl6030-usb.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl

[PATCH 3/5] usb: ohci-pxa27x: Include linux/of.h header

'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-pxa27x.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa2

Re: [PATCH 1/5] usb: gadget: s3c-hsotg: Include linux/of.h header

On 22 October 2013 11:44, Greg KH wrote: > On Mon, Oct 21, 2013 at 07:23:11AM -0500, Felipe Balbi wrote: >> Hi, >> >> On Sat, Oct 19, 2013 at 02:17:52PM -0700, Greg KH wrote: >> > On Thu, Oct 17, 2013 at 01:55:02PM +0530, Sachin Kamat wrote: >> > > '

[PATCH 1/1] usb: musb: Remove duplicate inclusion of linux/of.h

linux/of.h was included twice. Signed-off-by: Sachin Kamat --- drivers/usb/musb/musb_dsps.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 7185eb0..96cb84a 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b

[PATCH 1/1] USB: core: Free the allocated memory before exiting on error

'new_interfaces' should be freed to avoid memory leak. Cc: Sarah Sharp Cc: Alan Stern Signed-off-by: Sachin Kamat --- drivers/usb/core/message.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c ind

[PATCH 1/1] usb: phy: samsung: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/7] usb: gadget: atmel_usba_udc: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Nicolas Ferre --- drivers/usb/gadget/atmel_usba_udc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget

[PATCH 2/7] usb: gadget: bcm63xx_udc: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Kevin Cernekee --- drivers/usb/gadget/bcm63xx_udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget

[PATCH 3/7] usb: gadget: dummy_hcd: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Alan Stern --- drivers/usb/gadget/dummy_hcd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/dummy_hcd.c b

[PATCH 4/7] usb: gadget: f_uac2: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Jaswinder Singh --- drivers/usb/gadget/f_uac2.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/f_uac2.c

[PATCH 5/7] usb: gadget: imx_udc: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Darius Augulis --- drivers/usb/gadget/imx_udc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/imx_udc.c

[PATCH 6/7] usb: gadget: pxa25x_udc: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Eric Miao --- drivers/usb/gadget/pxa25x_udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/pxa25x_udc.c

[PATCH 7/7] usb: gadget: s3c2410_udc: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers

[PATCH 1/5] usb: phy: ab8500-usb: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-ab8500-usb.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers

[PATCH 2/5] usb: phy: gpio-vbus-usb: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Philipp Zabel --- drivers/usb/phy/phy-gpio-vbus-usb.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy

[PATCH 3/5] usb: phy: mv-usb: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Chao Xie --- drivers/usb/phy/phy-mv-usb.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/phy/phy-mv-usb.c b

[PATCH 4/5] usb: phy: mxs-usb: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Marek Vasut --- drivers/usb/phy/phy-mxs-usb.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH 5/5] usb: phy: nop: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-nop.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy-nop.c b/drivers/usb/phy/phy

[PATCH 1/1] USB: quatech2: Staticize local symbol

'qt2_process_read_urb' is referenced only in this file. Make it static. Signed-off-by: Sachin Kamat --- drivers/usb/serial/quatech2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index 02b080

[PATCH Resend 2/2] net/usb: r8152: Use module_usb_driver()

module_usb_driver() eliminates boilerplate and simplifies the code. Signed-off-by: Sachin Kamat Cc: Realtek linux nic maintainers --- drivers/net/usb/r8152.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH Resend 1/2] net/usb: r8152: Remove redundant version.h header inclusion

version.h header inclusion is not necessary as detected by checkversion.pl. Signed-off-by: Sachin Kamat --- This series compile tested on linux-next (20130516). --- drivers/net/usb/r8152.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH 01/12] usb: chipidea: ci13xxx_imx: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Marek Vasut Cc: Alexander Shishkin --- drivers/usb/chipidea/ci13xxx_imx.c |2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH 02/12] usb: gadget: mv_u3d_core: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Yu Xu --- drivers/usb/gadget/mv_u3d_core.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/mv_u3d_core.c

[PATCH 03/12] usb: gadget: pxa27x_udc: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Eric Miao --- drivers/usb/gadget/pxa27x_udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/pxa27x_udc.c

[PATCH 04/12] usb: host: ehci-tilegx: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Alan Stern --- drivers/usb/host/ehci-tilegx.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ehci-tilegx.c b

[PATCH 05/12] usb: host: ohci-da8xx: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-da8xx.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host

[PATCH 06/12] usb: host: ohci-nxp: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Dmitry Chigirev --- drivers/usb/host/ohci-nxp.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/ohci-nxp.c

[PATCH 07/12] usb: host: ohci-octeon: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-octeon.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/ohci-octeon.c b/drivers/usb

[PATCH 08/12] usb: host: ohci-omap: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Tony Lindgren --- drivers/usb/host/ohci-omap.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-omap.c b

[PATCH 09/12] usb: host: ohci-tilegx: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-tilegx.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb

[PATCH 10/12] usb: host: ohci-tmio: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-tmio.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host

[PATCH 11/12] usb: host: oxu210hp-hcd: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Rodolfo Giometti --- drivers/usb/host/oxu210hp-hcd.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host

[PATCH 12/12] usb: host: uhci-platform: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Tony Prisk --- drivers/usb/host/uhci-platform.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/uhci

[PATCH 1/2] usb: host: fusbh200-hcd: Remove redundant platform_set_drvdata()

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Yuan-Hsin Chen --- drivers/usb/host/fusbh200-hcd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/fusbh200

[PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

Local symbols referenced only in this file are made static. Signed-off-by: Sachin Kamat --- drivers/usb/host/fusbh200-hcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c index b17dd3f..0855ca4

Re: [PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

Hi, On 20 May 2013 12:13, Yuan-Hsin Chen wrote: > Hi, > > On Mon, May 20, 2013 at 1:51 PM, Sachin Kamat wrote: >> Local symbols referenced only in this file are made static. >> >> Signed-off-by: Sachin Kamat > > Thank you. I believe you probably mea

[PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

'omap_ehci_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat --- Series compile tested against linux-next tree (20130521). --- drivers/usb/host/ehci-omap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH 2/8] usb: host: ehci-platform: Remove redundant use of of_match_ptr

'vt8500_ehci_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat --- drivers/usb/host/ehci-platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platfo

[PATCH 3/8] usb: host: ehci-spear: Remove redundant use of of_match_ptr

'spear_ehci_id_table' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat Cc: Viresh Kumar --- drivers/usb/host/ehci-spear.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb

[PATCH 4/8] usb: host: ehci-orion: Remove redundant use of of_match_ptr

'ehci_orion_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat Cc: Tzachi Perelstein --- drivers/usb/host/ehci-orion.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb

[PATCH 5/8] usb: host: ohci-omap3: Remove redundant use of of_match_ptr

'omap_ohci_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-omap3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-omap3.c b/drivers/usb/host/ohci-omap3.c ind

[PATCH 6/8] usb: host: ohci-spear: Remove redundant use of of_match_ptr

'spear_ohci_id_table' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat Cc: Viresh Kumar --- drivers/usb/host/ohci-spear.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb

[PATCH 7/8] usb: host: uhci-platform: Remove redundant use of of_match_ptr

'platform_uhci_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat Cc: Tony Prisk --- drivers/usb/host/uhci-platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb

  1   2   >