Hi!
On 08/15/2012 07:04 PM, Sebastian Andrzej Siewior wrote:
> The new style start/stop interface was merged in 352c2dc8b0, v3.1-rc1.
> The UDC was merged in 24a28e4, v3.5-rc1. We did not want old style udcs.
> Is anyone going to convert it to new style start/stop?
Looks like I missed that one wh
c:665: error: implicit declaration of
> function ‘i2c_smbus_read_word_data’
> | drivers/usb/gadget/lpc32xx_udc.c: In function ‘vbus_work’:
> | drivers/usb/gadget/lpc32xx_udc.c:2959: error: implicit declaration of
> function ‘i2c_smbus_read_byte_data’
>
> Cc: Alexandre Pereira
This patch adjusts the LPC32xx USB gadget driver to the new udc_start /
udc_stop interface.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc1
drivers/usb/gadget/lpc32xx_udc.c | 44 +--
1 file changed, 15 insertions(+), 29 deletions(-)
--- linux-2.6
On 08/16/2012 06:05 PM, Sebastian Andrzej Siewior wrote:
>> --- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c
>> +++ linux-2.6/drivers/usb/gadget/lpc32xx_udc.c
>> @@ -2987,14 +2986,14 @@ static irqreturn_t lpc32xx_usb_vbus_irq(
>> return IRQ_HANDLED;
>> }
>>
>> -static int lpc32xx_start(s
Hi,
On 08/16/2012 06:16 PM, Roland Stigge wrote:
> On 08/16/2012 06:05 PM, Sebastian Andrzej Siewior wrote:
>>> --- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c
>>> +++ linux-2.6/drivers/usb/gadget/lpc32xx_udc.c
>>> @@ -2987,14 +2986,14 @@ static ir
On 08/17/2012 01:02 PM, Felipe Balbi wrote:
> On Fri, Aug 17, 2012 at 01:01:44PM +0200, Sebastian Andrzej Siewior wrote:
>> On 08/17/2012 12:51 PM, Felipe Balbi wrote:
Sounds reasonable?
>>>
>>> no it doesn't. Please remove that static global. Sorry but one of the
>>> goals with udc_start/udc_
Hi!
On 08/17/2012 03:14 PM, Sebastian Andrzej Siewior wrote:
> On 08/16/2012 11:31 AM, Roland Stigge wrote:
>> USB_ISP1301 already depends on I2C.
>>
>> Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead
>> of "select USB_ISP130
This patch removes an unused statically defined array and an associated #define.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc2
drivers/usb/phy/isp1301.c |6 --
1 file changed, 6 deletions(-)
--- linux-2.6.orig/drivers/usb/phy/isp1301.c
+++ linux-2.6/drivers/usb/phy/isp1301.c
On 17/08/12 11:42, Sebastian Andrzej Siewior wrote:
> Some minor things:
> - please use to_udc() in start then
> - would it make sense to use platform_get_drvdata() in
> lpc32xx_udc_shutdown() ?
> - could you please remove struct usb_endpoint_descriptor from struct
> lpc32xx_ep? It has been rem
On 17/08/12 13:39, Sebastian Andrzej Siewior wrote:
>> .lep= 0,
>> .eptype = EP_CTL_TYPE,
>> },
>> .ep[1] = {
>> .ep = {
>> .name = "ep1-int",
>> .ops=&lp
Hi,
On 08/20/2012 09:07 AM, Sebastian Andrzej Siewior wrote:
>> I merged these changes into the patch set, and will repost it tomorrow
>> after I can test it more thoroughly.
>
> Thanks.
> While you are playing with it, I saw that you handle vbus (->pull())
> manually. This was the case in the "o
This patch adjusts the LPC32xx USB gadget driver to the new udc_start /
udc_stop interface.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc2
drivers/usb/gadget/lpc32xx_udc.c | 49 +++
1 file changed, 14 insertions(+), 35 deletions(-)
--- linux-2.6
This patch removes the utilization of struct usb_endpoint_descriptor, as done
by other drivers also. This was done on request by the USB gadget maintainers,
since this API is obsoleted.
Signed-off-by: Roland Stigge
---
drivers/usb/gadget/lpc32xx_udc.c | 23 +++
1 file
, reflecting fixed
hardware endpoint structure.
Signed-off-by: Roland Stigge
---
drivers/usb/gadget/lpc32xx_udc.c | 55 ---
1 file changed, 29 insertions(+), 26 deletions(-)
--- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c
+++ linux-2.6/drivers/usb/gadget
On 08/20/2012 10:19 AM, Sebastian Andrzej Siewior wrote:
> On 08/20/2012 10:11 AM, Roland Stigge wrote:
>> This patch removes the utilization of struct usb_endpoint_descriptor,
>> as done
>> by other drivers also. This was done on request by the USB gadget
>> mainta
This patch adjusts the LPC32xx USB gadget driver to the new udc_start /
udc_stop interface.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc2
Changes since v1:
* None
drivers/usb/gadget/lpc32xx_udc.c | 49 +++
1 file changed, 14 insertions(+), 35
This patch removes the utilization of struct usb_endpoint_descriptor, as done
by other drivers also. This was done on request by the USB gadget maintainers,
since this API is obsoleted.
Signed-off-by: Roland Stigge
---
Changes since v1:
* None
drivers/usb/gadget/lpc32xx_udc.c | 23
, reflecting fixed
hardware endpoint structure.
Signed-off-by: Roland Stigge
---
Changes since v1:
* Make controller_template const
drivers/usb/gadget/lpc32xx_udc.c | 55 ---
1 file changed, 29 insertions(+), 26 deletions(-)
--- linux-2.6.orig/drivers/usb/gadget
On 08/22/2012 01:56 PM, Sebastian Andrzej Siewior wrote:
> On 08/22/2012 01:43 PM, Felipe Balbi wrote:
>>> But now that I've seen the transceiver driver it is probably the
>>> smallest one.
>>
>> if it depends on the transceiver, why do we have i2c transfers on those
>> drivers ? They should be hid
Hi,
On 22/08/12 21:49, Alan Stern wrote:
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index c3f619b..cac3ee2 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -292,7 +292,6 @@ config USB_OHCI_HCD
>> depends on USB && USB_ARCH_HAS_OHCI
>
On 08/23/2012 09:21 AM, Sebastian Andrzej Siewior wrote:
> On 08/23/2012 12:16 AM, Roland Stigge wrote:
>> This issue could be resolved in a different way: Have you followed the
>> discussion at linux-arm-ker...@lists.infradead.org on 2012-08-20,
>> Subject "i2c: pnx
On 08/23/2012 10:29 AM, Sebastian Andrzej Siewior wrote:
>> For the PNX4008 removal - should I already post a patch to build the
>> respective changes on top of, without PNX4008 references?
>
> If nobody cares about PNX4008 and nobody tested if it actually works in
> the OHCI mode I don't see the
On 08/23/2012 09:18 AM, Sebastian Andrzej Siewior wrote:
> On 08/22/2012 09:49 PM, Alan Stern wrote:
>>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>>> index c3f619b..cac3ee2 100644
>>> --- a/drivers/usb/host/Kconfig
>>> +++ b/drivers/usb/host/Kconfig
>>> @@ -292,7 +292,6 @@ c
With "select USB_ISP1301 ...", it could happen that I2C isn't selected although
USB_ISP1301 depends on it. Fixing with "depends on ..." and emulating the
condition via "|| !()".
Signed-off-by: Roland Stigge
---
drivers/usb/host/Kconfig |2 +-
1 file
Hi,
this is my first try on activating EHCI on imx53 (primarily via dt). However,
probe() still hangs on the first ehci_writel() l.189. I guess some
clock/enabling is still missing?
Sascha, do you already have EHCI running on imx53?
Any hint would be very much appreciated.
Thanks in advance,
R
Hi Marc and Sascha,
On 09/03/2012 04:49 PM, Marc Kleine-Budde wrote:
>> On Mon, Sep 03, 2012 at 04:27:57PM +0200, Roland Stigge wrote:
>>> Hi,
>>>
>>> this is my first try on activating EHCI on imx53 (primarily via
>>> dt). However, probe() still han
With "select USB_ISP1301 ...", it could happen that I2C isn't selected although
USB_ISP1301 depends on it. Fixing with "depends on ..." and emulating the
condition via "|| !()".
Signed-off-by: Roland Stigge
Acked-by: Alan Stern
---
drivers/usb/host/K
On 12/09/12 22:33, Alexandre Pereira da Silva wrote:
> This message is an debugging message. It's useful for finding protocol
> details but it's not necessarily an error.
>
> Signed-off-by: Alexandre Pereira da Silva
Acked-by: Roland Stigge
Yes, the Kevin Wells at NXP co
is a work around for this by using the interrupt source register that
> should behave the same on both parts and has the needed information.
>
> Signed-off-by: Alexandre Pereira da Silva
Tested-by: Roland Stigge
> ---
> drivers/usb/gadget/lpc32xx_udc.c |4 ++--
>
is a work around for this by using the interrupt source register that
> should behave the same on both parts and has the needed information.
>
> Signed-off-by: Alexandre Pereira da Silva
Tested-by: Roland Stigge
> ---
>
> This patch is very important to LPC32xx users. IMHO thi
On 10/15/2012 02:47 PM, Alexandre Pereira da Silva wrote:
> This message is an debugging message. It's useful for finding protocol
> details but it's not necessarily an error.
>
> Signed-off-by: Alexandre Pereira da Silva
Acked-by: Roland Stigge
Was also confirmed b
On 10/15/2012 03:01 PM, Felipe Balbi wrote:
> On Mon, Oct 15, 2012 at 09:47:35AM -0300, Alexandre Pereira da
> Silva wrote:
>> The STOTG04 is an replacement for ISP1301.
>>
>> Most of the registers on STOTG04 are the same as on ISP1301, but
>> the register ISP1301_I2C_OTG_CONTROL_2 (address 0x10)
_udc_probe':
drivers/usb/gadget/lpc32xx_udc.c:3104: undefined reference to
`isp1301_get_client' distcc[27867] ERROR: compile (null) on localhost failed
make: *** [vmlinux] Error 1
This patch fixes this by selecting USB_OTG_UTILS in Kconfig which
causes the phy driver to be built again.
Signed-o
-BEGIN PGP SIGNED MESSAGE-
Hash: RIPEMD160
On 03/26/2013 07:03 PM, Felipe Balbi wrote:
> On Tue, Mar 26, 2013 at 06:36:01PM +0100, Roland Stigge wrote:
>> The current lpc32xx_defconfig breaks like this, caused by recent
>> phy restructuring:
>
> which commit actually
-BEGIN PGP SIGNED MESSAGE-
Hash: RIPEMD160
On 03/26/2013 08:24 PM, Felipe Balbi wrote:
> commit ?
1c2088812f095df77f4b3224b65db79d7111a300
Seems to be based on the assumption that only OTG needs a PHY.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG
e to `isp1301_get_client'
> drivers/built-in.o: In function `lpc32xx_udc_probe':
> drivers/usb/gadget/lpc32xx_udc.c:3071: undefined reference to
> `isp1301_get_client'
>
> Signed-off-by: Arnd Bergmann
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartm
-by: Roger Quadros
Acked-by: Roland Stigge
Tested-by: Roland Stigge
Thanks!
> CC: Roland Stigge
> ---
> drivers/usb/gadget/Kconfig |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index
37 matches
Mail list logo
