[PATCH 1/8] ARM OMAP2+ GPMC: don't undef DEBUG

OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily hard to turn DEBUG on. Remove the offending lines. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index

[PATCH 8/8] ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

gpmc_cs_show_timings for -CLKACTIVATIONTIME -WAITMONITORINGTIME -DEVICESIZE -ATTACHEDDEVICEPAGELENGTH Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 68 ++ 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/memory/omap

[PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were replaced with interval of values that produce the same number of clock ticks. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 35 ++- 1 file

[PATCH 2/8] ARM OMAP2+ GPMC: add bus children

This patch adds support for spawning buses as children of the GPMC. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 5cabac8..74a8c52

[PATCH 0/8] ARM OMAP2+ GPMC: fixes and bus children

. DEVICESIZE, ATTACHEDDEVICEPAGELENGTH, WAITMONITORINGTIME and CLKACTIVATIONTIME would not be marked as incorrect on DTS output. --> Fix all of these. [1]: https://lkml.org/lkml/2015/2/12/495 [2]: https://lkml.org/lkml/2015/2/16/337 [3]: https://lkml.org/lkml/2015/2/24/609 Robert ABEL (9):

[PATCH 4/8] ARM OMAP2+ GPMC: fix debug output alignment

GPMC debug output is aligned to 10 characters for field names. However, some fields have bigger names, screwing up the alignment. Consequently, alignment was changed to longest field name (17 chars) for now. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 2 +- 1 file changed, 1

[PATCH 7/8] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

WAITMONITORINGTIME delay. This patch correctly computes WAITMONITORINGTIME in GPMC_CLK cycles instead of GPMC_FCLK cycles, both during programming (gpmc_cs_set_timings) and during retrieval (gpmc_cs_show_timings). Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 126

[PATCH 5/8] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER

WAITMONITORINGTIME delay. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 9340e7a..4139f0d 100644 --- a/drivers/memory/omap-gpmc.c +++ b

[PATCH 6/8] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

WAITMONITORINGTIME delay. Calculate GPMCFCLKDIVIDER independent of gpmc,sync-clk-ps in DT for pure asynchronous accesses, i.e. both read and write asynchronous. Signed-off-by: Robert ABEL --- arch/arm/mach-omap2/gpmc-nand.c| 17 arch/arm/mach-omap2/gpmc-onenand.c | 4 +- arch/arm/mach

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

Hi Roger, On Fri, Feb 27, 2015 at 11:43 AM, Roger Quadros wrote: >> time_ns_min = gpmc_ticks_to_ns(l ? l - 1 : 0); > > should be > time_ns_min = l ? gpmc_ticks_to_ns(l - 1) + 1 : 0; That's a micro-optimization. > > + 1ns since we don't want to fall in

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

On Thu, Feb 26, 2015 at 4:06 PM, Sergei Shtylyov wrote: >Documentation/kernel-doc-nano-HOWTO.txt requires colons after the > parameter names, doesn't it? Jesus Christ, you guys are killing me... I've already spent way more time on this patch series than I intended to anyway... >> + mas

Re: [PATCH 2/8] ARM OMAP2+ GPMC: add bus children

Hi Roger, On Fri, Feb 27, 2015 at 11:24 AM, Roger Quadros wrote: >> + /* is child a common bus? */ >> + if (of_match_node(of_default_bus_match_table, child)) >> + /* create children and other common bus children */ >> + if (of_platform_populate(child, of_default_bu

[PATCH 3/8 v4] ARM OMAP2+ GPMC: fix debug output alignment

GPMC debug output is aligned to 10 characters for field names. However, some fields have bigger names, screwing up the alignment. Consequently, alignment was changed to longest field name (17 chars) for now. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 2 +- 1 file changed, 1

[PATCH 2/8 v4] ARM OMAP2+ GPMC: add bus children

This patch adds support for spawning buses as children of the GPMC. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 5cabac8..74a8c52

[PATCH 8/8 v4] ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

gpmc_cs_show_timings for -CLKACTIVATIONTIME -WAITMONITORINGTIME -DEVICESIZE -ATTACHEDDEVICEPAGELENGTH Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 68 ++ 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/memory/omap

[PATCH 4/8 v4] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were replaced with interval of values that produce the same number of clock ticks. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 38 -- 1 file

[PATCH 5/8 v4] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER

WAITMONITORINGTIME delay. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 432e638..02e5228 100644 --- a/drivers/memory/omap-gpmc.c +++ b

[PATCH 6/8 v4] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

WAITMONITORINGTIME delay. Calculate GPMCFCLKDIVIDER independent of gpmc,sync-clk-ps in DT for pure asynchronous accesses, i.e. both read and write asynchronous. Signed-off-by: Robert ABEL --- arch/arm/mach-omap2/gpmc-nand.c| 17 arch/arm/mach-omap2/gpmc-onenand.c | 4 +- arch/arm/mach

[PATCH 7/8 v4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

WAITMONITORINGTIME delay. This patch correctly computes WAITMONITORINGTIME in GPMC_CLK cycles instead of GPMC_FCLK cycles, both during programming (gpmc_cs_set_timings) and during retrieval (gpmc_cs_show_timings). Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 128

[PATCH 0/8 v4] ARM OMAP2+ GPMC: fixes and bus children

lkml.org/lkml/2015/2/24/609 [4]: https://lkml.org/lkml/2015/2/26/387 Robert ABEL (9): ARM OMAP2+ GPMC: don't undef DEBUG ARM OMAP2+ GPMC: add bus children ARM OMAP2+ GPMC: fix debug output alignment ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS ARM OMAP2+ GPMC: always

[PATCH 1/8 v4] ARM OMAP2+ GPMC: don't undef DEBUG

OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily hard to turn DEBUG on. Remove the offending lines. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index

Re: [PATCH 2/8] ARM OMAP2+ GPMC: add bus children

Hi Roger, On Tue, Mar 3, 2015 at 11:09 AM, Roger Quadros wrote: > If that is the case then I'd rather not check for return value of > of_platform_populate(). > Failure in populating GPMC child's children is already out of scope of GPMC > driver. Well, I'd rather leave it in for now. If somethi

Re: [PATCH 0/8] ARM OMAP2+ GPMC: fixes and bus children

Hi Roger, On Tue, Mar 3, 2015 at 1:55 PM, Roger Quadros wrote: > I'm OK with this version. > > Tony, after you ACK these I will queue them for v4.1. Please use v4 of my patches. The DTS output has been changed and the comments have their colon. Regards, Robert -- To unsubscribe from this list: