Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-09-14 Thread Richard Zhao
On Wed, Sep 12, 2012 at 01:47:54PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Tue, Sep 11, 2012 at 10:23:55AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Wed, Aug 29, 2012 at 12:48:15PM +0300, Alex

Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-14 Thread Richard Zhao
On Fri, Sep 14, 2012 at 04:56:13PM +0800, Chen Peter-B29397 wrote: > > > diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c > > index c1a67cb..6a03e97 100644 > > --- a/drivers/usb/otg/mxs-phy.c > > +++ b/drivers/usb/otg/mxs-phy.c > > @@ -97,12 +97,24 @@ static int mxs_phy_on_disco

[PATCH] USB: chipidea: use OTGSC_BSV to detect vbus valid

2012-09-17 Thread Richard Zhao
OTGSC_AVVIS cannot be set when vbus voltage goes valid or invalid on imx, so convert to use OTGSC_BSV. OTGSC_BSVIE and OTGSC_BSVIS is not cleared when hw_device_reset, so we don't need to call hw_enable_vbus_intr after hw_device_reset. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-09-17 Thread Richard Zhao
On Fri, Sep 14, 2012 at 01:25:25PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Wed, Sep 12, 2012 at 01:47:54PM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Tue, Sep 11, 2012 at 10:23:55AM +0300, Alex

[PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Richard Zhao
Signed-off-by: Richard Zhao Acked-by: Felipe Balbi --- Changes from v2: - assign host/gadget in mxs_phy_set_host/mxs_phy_set_peripheral drivers/usb/otg/mxs-phy.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs

Re: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-18 Thread Richard Zhao
On Mon, Sep 17, 2012 at 01:06:21PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > Signed-off-by: Richard Zhao > > Acked-by: Felipe Balbi > > Felipe said, > > > if you add a commit log you can add my: > > > > Acked-by: Felip

Re: [PATCH] USB: chipidea: use OTGSC_BSV to detect vbus valid

2012-09-18 Thread Richard Zhao
On Mon, Sep 17, 2012 at 04:52:59PM +0800, Chen Peter-B29397 wrote: > > > > > > > OTGSC_AVVIS cannot be set when vbus voltage goes valid or invalid on > > imx, so convert to use OTGSC_BSV. > > > > Not just on imx, from the IC guys, it is chipidea's feature. > the AVVIS will not go to 1 when

[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

2012-09-18 Thread Richard Zhao
Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 307651b..0942b9b 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c

Re: [PATCH v2 10/11] USB: chipidea: add set_vbus_power support

2012-09-18 Thread Richard Zhao
Alex, I find you dropped this too. Did you mean to add it after otg driver or any other reason? Thanks Richard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

2012-09-18 Thread Richard Zhao
On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote: > Dear Richard Zhao, > > You know, commit message would be nice to have. Yes, but for this one, the title shows obviously what it changed, doesn't it? Thanks Richard > > > Signed-off-by: Richard Zhao > &g

Re: [PATCH v8 06/14] USB: Chipidea: rename struct ci13xxx variables from udc to ci

2012-07-07 Thread Richard Zhao
On Fri, Jul 06, 2012 at 11:07:21AM -0700, Greg KH wrote: > On Fri, Jun 29, 2012 at 05:48:54PM +0800, Richard Zhao wrote: > > struct ci13xxx represent the controller, which may be device or host, > > so name its variables as ci. > > > > Signed-off-by: Richard Zhao &g

[PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree

2012-07-07 Thread Richard Zhao
controler works at host role Changes since last version: - Rebase patch that Greg failed to merge. Richard Zhao (9): USB: Chipidea: rename struct ci13xxx variables from udc to ci USB: Chipidea: add unified ci13xxx_{add,remove}_device for platform drivers USB: Chipidea: add ci13xxx

[PATCH v9 REBASE 2/9] USB: Chipidea: add unified ci13xxx_{add,remove}_device for platform drivers

2012-07-07 Thread Richard Zhao
Platform drivers do the similar things to add/remove ci13xxx device, so create a unified one. Signed-off-by: Richard Zhao Reviewed-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/ci13xxx_msm.c | 34 ++-- drivers/usb/chipidea/ci13xxx_pci.c

[PATCH v9 REBASE 3/9] USB: Chipidea: add ci13xxx device id management

2012-07-07 Thread Richard Zhao
We use ida_simple_get and ida_simple_remove to manage the ids. Signed-off-by: Richard Zhao Reviewed-by: Felipe Balbi Signed-off-by: Alexander Shishkin --- drivers/usb/chipidea/core.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/usb

[PATCH v9 REBASE 4/9] usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig

2012-07-07 Thread Richard Zhao
ci13xxx host needs Root Hub Transaction Translators. Reported-by: Shawn Guo Signed-off-by: Richard Zhao Acked-by: Felipe Balbi Signed-off-by: Alexander Shishkin Acked-by: Marek Vasut --- drivers/usb/chipidea/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea

[PATCH v9 REBASE 5/9] usb: otg: add notify_connect/notify_disconnect callback

2012-07-07 Thread Richard Zhao
This let usb phy driver has a chance to change hw settings when connect status change. Signed-off-by: Richard Zhao Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- include/linux/usb/otg.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/linux/usb/otg.h

[PATCH v9 REBASE 7/9] usb: chipidea: permit driver bindings pass phy pointer

2012-07-07 Thread Richard Zhao
Sometimes, the driver bindings may know what phy they use. For example, when using device tree, the usb controller may have a phandler pointing to usb phy. Signed-off-by: Richard Zhao Reviewed-by: Marek Vasut Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- drivers/usb/chipidea/ci.h

[PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-07 Thread Richard Zhao
Phy may need to change settings when port connect change. Signed-off-by: Richard Zhao Tested-by: Subodh Nijsure --- drivers/usb/core/hub.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 4cc8dc9..2ba9d84 100644 --- a/drivers

[PATCH v9 REBASE 8/9] usb: otg: add basic mxs phy driver support

2012-07-07 Thread Richard Zhao
mxs phy is used in Freescale i.MX SoCs, for example imx23, imx28, imx6Q. This patch adds the basic host support. Signed-off-by: Richard Zhao Signed-off-by: Marek Vasut Cc: Peter Chen Acked-by: Felipe Balbi Tested-by: Subodh Nijsure --- Documentation/devicetree/bindings/usb/mxs-phy.txt

[PATCH v9 REBASE 9/9] usb: chipidea: add imx platform driver

2012-07-07 Thread Richard Zhao
This patch supports only the host-mode functionality so far. Signed-off-by: Richard Zhao Signed-off-by: Marek Vasut Cc: Peter Chen Cc: Alexander Shishkin Cc: Felipe Balbi Cc: Greg Kroah-Hartman Tested-by: Subodh Nijsure --- .../devicetree/bindings/usb/ci13xxx-imx.txt| 18

Re: [PATCH v2 1/4] usb: chipidea: pci: make platformdata static

2012-07-08 Thread Richard Zhao
On Thu, Jun 28, 2012 at 10:06 PM, Richard Zhao wrote: > On Thu, Jun 28, 2012 at 03:53:46PM +0200, Marc Kleine-Budde wrote: >> Signed-off-by: Marc Kleine-Budde >> --- >> drivers/usb/chipidea/ci13xxx_pci.c |6 +++--- >> 1 file changed, 3 insertions(+), 3 dele

Re: [PATCH v2 1/4] usb: chipidea: pci: make platformdata static

2012-07-08 Thread Richard Zhao
On Sun, Jul 08, 2012 at 06:48:49PM +0100, Russell King - ARM Linux wrote: > On Sun, Jul 08, 2012 at 11:10:04PM +0800, Richard Zhao wrote: > > On Thu, Jun 28, 2012 at 10:06 PM, Richard Zhao wrote: > > > On Thu, Jun 28, 2012 at 03:53:46PM +0200, Marc Kleine-Budde wrote: > >

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-09 Thread Richard Zhao
On Mon, Jul 09, 2012 at 09:57:57AM -0700, Greg KH wrote: > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > Phy may need to change settings when port connect change. > > > > Signed-off-by: Richard Zhao > > Tested-by: Subodh Nijsure > > --- &

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-09 Thread Richard Zhao
On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > Phy may need to change settings when port connect change. > > Signed-off-by: Richard Zhao > Tested-by: Subodh Nijsure > --- > drivers/usb/core/hub.c |8 > 1 file changed, 8 insertions(+) > &g

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-10 Thread Richard Zhao
On Tue, Jul 10, 2012 at 05:22:20AM +0200, Marek Vasut wrote: > Dear Richard Zhao, > > > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > > Phy may need to change settings when port connect change. > > > > > > Signed-off-by: Richar

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-10 Thread Richard Zhao
On Tue, Jul 10, 2012 at 10:24:07AM -0400, Alan Stern wrote: > On Tue, 10 Jul 2012, Richard Zhao wrote: > > > > > @@ -4037,6 +4038,13 @@ static void hub_port_connect_change(struct > > > > usb_hub *hub, int port1, > > > > } > > >

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-10 Thread Richard Zhao
On Tue, Jul 10, 2012 at 11:07:14AM -0400, Alan Stern wrote: > On Tue, 10 Jul 2012, Richard Zhao wrote: > > > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > > Phy may need to change settings when port connect change. > > > > > > Signe

[PATCH v10] USB: notify phy when root hub port connect change

2012-07-10 Thread Richard Zhao
Phy may need to change settings when port connect change. Signed-off-by: Richard Zhao Tested-by: Subodh Nijsure --- Changes since last version: - remove unlikely drivers/usb/core/hub.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core

[PATCH] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-07-11 Thread Richard Zhao
From: Marc Kleine-Budde If udc_start() fails the qh_pool dma-pool cannot be closed because it's still in use. This patch factors out the dma_pool_free() loop into destroy_eps() and calls it in the error path of udc_start(), too. Signed-off-by: Marc Kleine-Budde Signed-off-by: Richard

<    1   2