On 01/22/2013 04:21 PM, kishon wrote:
> But it's better to check if deferred probing
> takes place whenever a new driver is bound to a device as you just mentioned.
Whenever you load (might be also when you unload) a driver the deferred
modules will try to probe again. This is to check back if the
On 01/25/2017 12:17 PM, Alexandre Bailon wrote:
> A pointer to musb is now present in the dma_controller structure.
> Remove the one present in tusb_omap_dma structure.
the subject line should be: usb: musb: tusb6010_omap: ...
> Signed-off-by: Alexandre Bailon
> ---
> drivers/usb/musb/tusb601
Tony,
since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb is
compiled in. The kernel will stuck printing:
** 206 printk messages dropped ** [8.926727] musb_bus_suspend 2584:
trying to suspend as a_idle while active
The bisect (log is [1]) points to:
d8e5f0eca1e8 usb: musb
Tony,
On 2017-04-05 03:36, Tony Lindgren wrote:
* Tony Lindgren [170404 07:06]:
* Bin Liu [170404 05:30]:
On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote:
Tony,
since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb
is compiled in. The kernel will stuck printing
On 2017-04-05 10:13, Peter Ujfalusi wrote:
I had similar hunch first, but did not worked. I have tested this patch
and did not helped.
To be precise this is what I have tried:
- boot w/o cable connected
- boot w/ board connected to PC (device mode)
- boot w/ OTG-A cable with USB keyboard
- boot
Currently it is possible to have:
USB_MUSB_OMAP2PLUS=m
TWL4030_USB=y
which would result compile time error due to missing symbols.
With this change USB_MUSB_OMAP2PLUS and TWL4030_USB will be in sync.
Reported-by: Vincent Stehle
Signed-off-by: Peter Ujfalusi
---
Hi Felipe,
I have also noticed
On 03/12/2013 04:20 PM, Roger Quadros wrote:
> Adding Peter to the loop. I faintly remember him mentioning this issue before
> for beagle. We really need the deferred probe mechanism or we need to resort
> to device registering order.
Yes, BeagleBoard is a good example. Long story short: we have e
To facilitate upcoming cleanup in twl stack.
No functional changes.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/otg/twl4030-usb.c | 46 ---
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg
Hi Felipe,
On 11/13/2012 10:47 AM, Felipe Balbi wrote:
> On Tue, Nov 13, 2012 at 10:43:38AM +0100, Peter Ujfalusi wrote:
>> To facilitate upcoming cleanup in twl stack.
>> No functional changes.
>>
>> Signed-off-by: Peter Ujfalusi
>
> I guess this one must
On 11/13/2012 11:37 AM, Felipe Balbi wrote:
> ok good. Unfortunately I have already sent this merge window's pull
> request to Greg so I'd have to delay this until v3.9. If that's ok with
> you, I can take it through my tree.
I hoped that this can go with 3.8 since in 3.9 I'm planning to remove al
go
>>>> through all of these files in order to see what does it mean:
>>
>> Yeah, 644 is "clear", but _RW() is even more clear. Ideally I want to
>> get rid of all of the "non-standard" users that set random modes of
>> sysfs files, as we g
Tony,
On 04/05/2017 06:29 PM, Tony Lindgren wrote:
* Tony Lindgren [170405 06:53]:
* Peter Ujfalusi [170405 00:15]:
To be precise this is what I have tried:
- boot w/o cable connected
- boot w/ board connected to PC (device mode)
- boot w/ OTG-A cable with USB keyboard
- boot w/ OTG-A cable
n this case just seems to completely confuse the musb state
machine.
Let's fix the issue by making musb_host_setup() attempt to force the
mode only if port_mode is configured for host mode.
Tested-by: Peter Ujfalusi
Fixes: d8e5f0eca1e8 ("usb: musb: Fix hardirq-safe hardirq-unsafe
urn false;
+// if (dma_addr & 0x2)
+// return false;
/*
* Because of HW issue #10, it seems like mixing sync DMA and async
Since this condition will almost all the time was true - effectively disabling
the DMA use.
Regards.
Peter
---
Peter Ujfalusi (4)
For the DMA we have ch (channel), dmareq and sync_dev parameters both
within the tusb_omap_dma_ch and tusb_omap_dma_ch struct.
By creating a common struct the code can be simplified when selecting
between the shared or multichannel DMA parameters.
Signed-off-by: Peter Ujfalusi
---
drivers/usb
to lock within the DMAengine API when requesting channel.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/tusb6010_omap.c | 184 +++
1 file changed, 92 insertions(+), 92 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb
With the port_window support in DMAengine and the sDMA driver we can
convert the driver to DMAengine.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/tusb6010_omap.c | 201 ---
1 file changed, 80 insertions(+), 121 deletions(-)
diff --git a/drivers/usb
urn false;
+// if (dma_addr & 0x2)
+// return false;
/*
* Because of HW issue #10, it seems like mixing sync DMA and async
Since this condition will almost all the time was true - effectively disabling
the DMA use.
Regards.
Peter
---
Peter Ujfalusi (4)
yet supports DT boot.
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/dma.c | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index e58c13a9bea5..0b77a0176018 100644
--- a/arch/arm/mach-omap2/dma.c
+++ b/arch
Sorry,
I have forgot to update the commit message for the last patch.
On 2017-05-03 13:54, Peter Ujfalusi wrote:
Hi,
With port_window support implemented in DMAengine and the sDMA DMAengine driver,
the tusb6010_omap driver can be converted away from the custom legacy omap-dma
API to generic
On 2017-05-04 17:31, Tony Lindgren wrote:
* Peter Ujfalusi [170503 04:00]:
Hi,
With port_window support implemented in DMAengine and the sDMA DMAengine driver,
the tusb6010_omap driver can be converted away from the custom legacy omap-dma
API to generic DMAengine.
The first two patch is to
Tony,
On 2017-05-05 00:05, Tony Lindgren wrote:
* Tony Lindgren [170504 12:43]:
Hi,
* Peter Ujfalusi [170503 04:00]:
With the port_window support in DMAengine and the sDMA driver we can
convert the driver to DMAengine.
Actually looks like this patch still has some issues.. Pinging
the
On 2017-05-05 16:37, Peter Ujfalusi wrote:
Tony,
On 2017-05-05 00:05, Tony Lindgren wrote:
* Tony Lindgren [170504 12:43]:
Hi,
* Peter Ujfalusi [170503 04:00]:
With the port_window support in DMAengine and the sDMA driver we can
convert the driver to DMAengine.
Actually looks like
Tony,
On 2017-05-06 01:55, Tony Lindgren wrote:
OK I verified that with the current mainline kernel using dma
and g_ether and your patches 1 to 3 I can run the variable size
ping test loop for few minutes before it just stops working and
I can see the legacy DMA interrupt increase depending on t
to lock within the DMAengine API when requesting channel.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/tusb6010_omap.c | 184 +++
1 file changed, 92 insertions(+), 92 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb
Having one musb_ep_select() instead the two calls in if/else is the same
thing, but makes the code a bit simpler to follow.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/tusb6010_omap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b
yet supports DT boot.
Signed-off-by: Peter Ujfalusi
---
arch/arm/mach-omap2/dma.c | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index e58c13a9bea5..0b77a0176018 100644
--- a/arch/arm/mach-omap2/dma.c
+++ b/arch
For the DMA we have ch (channel), dmareq and sync_dev parameters both
within the tusb_omap_dma_ch and tusb_omap_dma_ch struct.
By creating a common struct the code can be simplified when selecting
between the shared or multichannel DMA parameters.
Signed-off-by: Peter Ujfalusi
---
drivers/usb
are settings for the slave port while the omap_sg members
apply to the memory side of the sDMA setup.
Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support")
Signed-off-by: Peter Ujfalusi
Cc: Russell King
Cc: dmaeng...@vger.kernel.org
Cc: dan.j.willi...@intel.com
C
Handle the DMA TX in a similar way as we do for the RX: in the DMA
completion callback.
Since we are no longer using DMA completion interrupt for the TX we can as
wall keep these interrupts disabled, but keep the handler for debug
purposes.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb
We have one register for each EP to set the maximum packet size for both
TX and RX.
If for example an RX programming would happen before the previous TX
transfer finishes we would reset the TX packet side.
To fix this issue, only modify the TX or RX part of the register.
Signed-off-by: Peter
buffer.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/musb_core.c | 3 +++
drivers/usb/musb/musb_core.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 870da18f5077..87cbd56cc761 100644
--- a/drivers/usb/musb/musb_core.c
When using the g_ncm for networking this flag will make sure that the
buffer is alligned to 32bit so the DMA can be used to offload the data
movement.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/tusb6010.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb
e"
size=1
fi
done
echo "Test ran up to $size"
Regards,
Peter
CC: dmaeng...@vger.kernel.org
I only send the cover letter and the DMAengine patch for the dmaengine list, the
rest can be checked - if there is interest - via lkml
---
Peter Ujfalusi (10):
dmaengine: omap
With the port_window support in DMAengine and the sDMA driver we can
convert the driver to DMAengine.
Signed-off-by: Peter Ujfalusi
---
drivers/usb/musb/tusb6010_omap.c | 201 ---
1 file changed, 80 insertions(+), 121 deletions(-)
diff --git a/drivers/usb
On 2017-05-11 02:16, Joe Perches wrote:
On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote:
On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote:
We have one register for each EP to set the maximum packet size for both
TX and RX.
If for example an RX programming would happen before
Bin,
On 2017-05-11 17:12, Bin Liu wrote:
which is valid.
So will you update the patch to move the declaration to the beginning of
the function to avoid this WARNING. I would just fix it locally if you
prefer.
I was waiting for Vinod or someone from the DMAengine guys to say
something for th
("USB: Add MUSB and TUSB support")
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
Bin,
I have separated the patch from the tusb DMAengine conversion series and that
will depend on this patch.
Regards,
Peter
drivers/usb/musb/tusb6010_omap.c | 13 +
1 file
For the DMA we have ch (channel), dmareq and sync_dev parameters both
within the tusb_omap_dma_ch and tusb_omap_dma_ch struct.
By creating a common struct the code can be simplified when selecting
between the shared or multichannel DMA parameters.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony
are settings for the slave port while the omap_sg members
apply to the memory side of the sDMA setup.
Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support")
Signed-off-by: Peter Ujfalusi
Cc: Russell King
Cc: dmaeng...@vger.kernel.org
Cc: dan.j.willi...@intel.com
C
yet supports DT boot.
Signed-off-by: Peter Ujfalusi
Acked-by: Tony Lindgren
---
arch/arm/mach-omap2/dma.c | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index e58c13a9bea5..0b77a0176018 100644
--- a/arch/arm/mach
buffer.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/musb_core.c | 3 +++
drivers/usb/musb/musb_core.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 870da18f5077..87cbd56cc761 100644
--- a
Handle the DMA TX in a similar way as we do for the RX: in the DMA
completion callback.
Since we are no longer using DMA completion interrupt for the TX we can as
wall keep these interrupts disabled, but keep the handler for debug
purposes.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
With the port_window support in DMAengine and the sDMA driver we can
convert the driver to DMAengine.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010_omap.c | 201 ---
1 file changed, 80 insertions(+), 121 deletions
only send the cover letter and the DMAengine patch for the dmaengine list, the
rest can be checked - if there is interest - via lkml
---
Peter Ujfalusi (9):
dmaengine: omap-dma: port_window support correction for both direction
usb: musb: Add quirk to avoid skb reserve in gadget mode
usb:
to lock within the DMAengine API when requesting channel.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010_omap.c | 184 +++
1 file changed, 92 insertions(+), 92 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b
Having one musb_ep_select() instead the two calls in if/else is the same
thing, but makes the code a bit simpler to follow.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010_omap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
When using the g_ncm for networking this flag will make sure that the
buffer is alligned to 32bit so the DMA can be used to offload the data
movement.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
are settings for the slave port while the omap_sg members
apply to the memory side of the sDMA setup.
Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support")
Signed-off-by: Peter Ujfalusi
Cc: Russell King
Cc: dmaeng...@vger.kernel.org
Cc: dan.j.willi...@intel.com
C
With the port_window support in DMAengine and the sDMA driver we can
convert the driver to DMAengine.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010_omap.c | 201 ---
1 file changed, 80 insertions(+), 121 deletions
list, the
rest can be checked - if there is interest - via lkml
---
Peter Ujfalusi (9):
dmaengine: omap-dma: port_window support correction for both direction
usb: musb: Add quirk to avoid skb reserve in gadget mode
usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks
usb
Handle the DMA TX in a similar way as we do for the RX: in the DMA
completion callback.
Since we are no longer using DMA completion interrupt for the TX we can as
wall keep these interrupts disabled, but keep the handler for debug
purposes.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
yet supports DT boot.
Signed-off-by: Peter Ujfalusi
Acked-by: Tony Lindgren
---
arch/arm/mach-omap2/dma.c | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index e58c13a9bea5..0b77a0176018 100644
--- a/arch/arm/mach
to lock within the DMAengine API when requesting channel.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010_omap.c | 185 +++
1 file changed, 92 insertions(+), 93 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b
For the DMA we have ch (channel), dmareq and sync_dev parameters both
within the tusb_omap_dma_ch and tusb_omap_dma struct.
By creating a common struct the code can be simplified when selecting
between the shared or multichannel DMA parameters.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony
When using the g_ncm for networking this flag will make sure that the
buffer is aligned to 32bit so the DMA can be used to offload the data
movement.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
Having one musb_ep_select() instead the two calls in if/else is the same
thing, but makes the code a bit simpler to follow.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/tusb6010_omap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
buffer.
Signed-off-by: Peter Ujfalusi
Tested-by: Tony Lindgren
---
drivers/usb/musb/musb_core.c | 3 +++
drivers/usb/musb/musb_core.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 870da18f5077..87cbd56cc761 100644
--- a
n the channel, so clearing the pending list is the correct
thing to do.
With the fixed subject:
Reviewed-by: Peter Ujfalusi
I have one question:
> Fixes: 975faaeb9985 ("dma: cppi41: start tear down only if channel is busy")
> Cc: sta...@vger.kernel.org # v3.15+
> Sign
Hi,
On 28/11/2018 13.15, Peter Ujfalusi wrote:
forgot to fix up Vinod's email address.
>
>
> On 12/11/2018 17.40, Bin Liu wrote:
>
> Can you fix up the subject line to:
> dmaengine: ti: cppi4: delete channel from pending list when stop channel
>
>> The driver
rred probe loop, iow both of
the drivers returns -EPROBE_DEFER and they just spin?
If both is deferring, how this supposed to work?
If we revert 58b116bce13612e5aa6fcd49ecbd4cf8bb59e835, then you might be
hitting the very same issue as described by the commit:
s/davinci_evm sound.3/dwc3-pci
s/davinci-mcasp 4803c000.mcasp/extcon
Andy,
On 2018-11-14 10:45, Andy Shevchenko wrote:
> On Wed, Nov 14, 2018 at 2:34 AM Mark Brown wrote:
>>
>> On Mon, Nov 12, 2018 at 06:11:26PM +0200, Peter Ujfalusi wrote:
>>
>>> if we revert the commit then the original issue will re-surfaces. afaik
>>> it
gt; the phy being on a separate l4 interconnect from EHCI.
>
> And old kernels would need to be checked for "ehci-phy" property for
> this fix to avoid regressions.
Tested-by: Peter Ujfalusi
> Cc: Alan Stern
> Cc: Johan Hovold
> Cc: Ladislav Michl
> Cc: Peter
be required. So, if
> devm_usb_get_phy_by_phandle() gives us an error code other
> than -ENODEV (no PHY) then error out.
>
> This fixes USB Ethernet on omap5-uevm if PHY happens to
> probe after EHCI thus causing a -EPROBE_DEFER.
Thanks, it works.
Tested-by: Peter Ujfalusi
> Cc: Alan Stern
&g
Hi Tony,
On 10/23/19 6:31 PM, Tony Lindgren wrote:
> Yegor Yefremov reported that musb and ftdi
> uart can fail for the first open of the uart unless connected using
> a hub.
>
> This is because the first dma call done by musb_ep_program() must wait
> if cppi41 is PM runtime suspended. Otherwise
On 10/23/19 8:16 PM, Tony Lindgren wrote:
> * Peter Ujfalusi [191023 17:04]:
>> On 10/23/19 6:31 PM, Tony Lindgren wrote:
>>> diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c
>>> --- a/drivers/dma/ti/cppi41.c
>>> +++ b/drivers/dma/ti/cppi
66 matches
Mail list logo
