Re: [PATCH v7 0/4] Fix idle port disconnects and firmware downloading

2015-07-13 Thread Peter Berger
On Sun, 2015-06-28 at 13:28 -0500, Peter E. Berger wrote: > From: "Peter E. Berger" > > I found that when using newer Edgeport devices such as the EP/416, > idle ports are regularly bounced (disconnected and then reconnected). > I discussed this with the manufacturer (Digi International) and lear

Re: [PATCH v7 0/4] Fix idle port disconnects and firmware downloading

2015-07-14 Thread Peter Berger
On Tue, 2015-07-14 at 17:43 +0200, Johan Hovold wrote: > On Mon, Jul 13, 2015 at 01:45:48PM -0500, Peter Berger wrote: > > On Sun, 2015-06-28 at 13:28 -0500, Peter E. Berger wrote: > > > Thanks for all your help getting this patchset to this point. Could you > > advise m

Re: [PATCH v7 2/4] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-07-22 Thread Peter Berger
On Wed, 2015-07-15 at 11:21 +0200, Johan Hovold wrote: Hi Johan: Thanks for another thoughtful and helpful review. I think I have addressed all the issues you noted and have a v8 patchset just about ready to submit. First I'll respond to each of the specific points here and in your other v7 revi

Re: [PATCH v7 3/4] USB: io_ti: Add firmware image sanity checks

2015-07-22 Thread Peter Berger
On Wed, 2015-07-15 at 11:36 +0200, Johan Hovold wrote: > On Sun, Jun 28, 2015 at 01:28:20PM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > Do what we can to verify that the driver's firmware image is valid > > (before attempting to download it to the Edgeport) by adding a new >

Re: [PATCH v7 4/4] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

2015-07-22 Thread Peter Berger
On Wed, 2015-07-15 at 11:42 +0200, Johan Hovold wrote: > On Sun, Jun 28, 2015 at 01:28:21PM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > When using newer Edgeport devices such as the EP/416, idle ports are > > automatically bounced (disconnected and then reconnected) approxim

Re: [PATCH v7 1/4] USB: io_ti: Increase insufficient timeout for firmware downloads

2015-07-22 Thread Peter Berger
On Wed, 2015-07-15 at 11:47 +0200, Johan Hovold wrote: > On Sun, Jun 28, 2015 at 01:28:18PM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport devices such as > > the EP/416. One of the problems is that the default 1 second t

Re: [PATCH v8 2/4] USB: io_ti: Fix firmware version handling

2015-07-30 Thread Peter Berger
On Thu, 2015-07-30 at 15:44 +0200, Johan Hovold wrote: > On Wed, Jul 22, 2015 at 01:56:14PM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport > > devices such as the EP/416, even when the on-disk firmware image > > (/lib/firm

Re: [PATCH v9 4/4] USB: io_ti: Add heartbeat to keep idle EP/416 ports from disconnecting

2015-07-31 Thread Peter Berger
On Fri, 2015-07-31 at 12:21 +0200, Johan Hovold wrote: > On Fri, Jul 31, 2015 at 01:55:08AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > When using Edgeport/416 models with newer firmware (sometime after > > firmware version 4.80.0), idle ports are automatically bounced > > (

Re: [PATCH v2 0/6] USB: io_ti: Cleanup download_fw and related functions

2015-09-21 Thread Peter Berger
On Sat, 2015-09-19 at 13:32 -0700, Johan Hovold wrote: > On Wed, Sep 16, 2015 at 03:12:57AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > While working on a previous patchset for this driver [1] we were > > hampered by the facts that download_fw() is very long and its return >

Re: [PATCH v3 1/2] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

2015-06-08 Thread Peter Berger
On Fri, 2015-05-22 at 17:21 +0200, Johan Hovold wrote: > On Fri, May 15, 2015 at 12:09:53AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > When using newer Edgeport devices such as the EP/416, idle ports are > > automatically bounced (disconnected and then reconnected) approxim

Re: [PATCH v3 2/2] USB: io_ti: Fix Edgeport firmware download code

2015-06-08 Thread Peter Berger
On Fri, 2015-05-22 at 18:22 +0200, Johan Hovold wrote: > On Fri, May 15, 2015 at 12:09:54AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport devices such > > as the EP/416, even when the on-disk firmware image > > (/lib/firm

Re: [PATCH v3 2/2] USB: io_ti: Fix Edgeport firmware download code

2015-06-15 Thread Peter Berger
On Thu, 2015-06-11 at 11:10 +0200, Johan Hovold wrote: > On Mon, Jun 08, 2015 at 02:36:36PM -0500, Peter Berger wrote: > > On Fri, 2015-05-22 at 18:22 +0200, Johan Hovold wrote: > > > On Fri, May 15, 2015 at 12:09:54AM -0500, Peter E. Berger wrote: > > &g

Re: [PATCH v4 1/2] USB: io_ti: Fix Edgeport firmware download code

2015-06-15 Thread Peter Berger
Hi Johan: I think my v5 patchset to address your review comments (here and in the other messages) is just about ready to submit. I'll include some point-by-point description details below: On Thu, 2015-06-11 at 12:03 +0200, Johan Hovold wrote: > On Mon, Jun 08, 2015 at 02:51:36PM -0500, Peter E.

Re: [PATCH v4 2/2] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

2015-06-15 Thread Peter Berger
Hi Johan: Again, I think I'm about ready to post a v5 patchset that addresses your comments here and elsewhere. I'll include point-by-point response notes to your comments below. Thanks! --Peter On Thu, 2015-06-11 at 12:26 +0200, Johan Hovold wrote: > On Mon, Jun 08, 2015 at 02:51:37PM -0

Re: [PATCH v5 02/10] USB: io_ti: Add timeout parameter to ti_vsend_sync()

2015-06-18 Thread Peter Berger
On Wed, 2015-06-17 at 11:21 +0200, Johan Hovold wrote: > On Mon, Jun 15, 2015 at 10:47:25AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > Instead of having ti_vsend_sync() decide when to use non-default timeouts, > > make "timeout" a parameter and leave the decision to the cal

Re: [PATCH v6 2/3] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-06-23 Thread Peter Berger
On Mon, 2015-06-22 at 11:43 +0200, Johan Hovold wrote: > On Thu, Jun 18, 2015 at 06:43:35AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport > > devices such as the EP/416, even when the on-disk firmware image > > (/lib/firm

Re: [PATCH v6 1/3] USB: io_ti: Increase insufficient timeout for firmware downloads

2015-06-23 Thread Peter Berger
On Mon, 2015-06-22 at 10:45 +0200, Johan Hovold wrote: > On Thu, Jun 18, 2015 at 06:43:34AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport devices such as > > the EP/416. One of the problems is that the default 1 second t

Re: [PATCH v6 3/3] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

2015-06-23 Thread Peter Berger
On Mon, 2015-06-22 at 12:01 +0200, Johan Hovold wrote: > On Thu, Jun 18, 2015 at 06:43:36AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > When using newer Edgeport devices such as the EP/416, idle ports are > > automatically bounced (disconnected and then reconnected) approxim

Re: [PATCH v6 2/3] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-06-27 Thread Peter Berger
On Fri, 2015-06-26 at 09:31 +0200, Johan Hovold wrote: > On Wed, Jun 24, 2015 at 12:18:27AM -0500, Peter Berger wrote: > > On Mon, 2015-06-22 at 11:43 +0200, Johan Hovold wrote: > > > On Thu, Jun 18, 2015 at 06:43:35AM -0500, Peter E. Berger wrote: > > &g

Re: [PATCH v6 2/3] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-06-28 Thread Peter Berger
On Sun, 2015-06-28 at 14:49 +0200, Johan Hovold wrote: > On Sat, Jun 27, 2015 at 03:51:37PM -0500, Peter Berger wrote: > > On Fri, 2015-06-26 at 09:31 +0200, Johan Hovold wrote: > > > On Wed, Jun 24, 2015 at 12:18:27AM -0500, Peter Berger wrote: > > > > On Mon, 20