Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-14 Thread Pavel Machek
On Thu 2014-06-12 23:34:12, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in > MSI GT683R laptop Hi! > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r > @@ -0,0 +1,10 @@ > +What:/sys/class/hidraw//device

Re: [PATCH v4 1/5] gadget: Introduce the notifier functions

2015-10-08 Thread Pavel Machek
HI! > > + int ret; > > + > > + mutex_lock(&gadget->lock); > > + ret = raw_notifier_chain_unregister(&gadget->nh, nb); > > Greg, this is the kind of thing I wanted to avoid adding more of. > > I was wondering if you would accept subsystems using kdbus for > this sort of notification. I'm ok

Re: [Device-mainlining] [PATCH v2 2/3] gadget: Introduce the usb charger framework

2015-10-08 Thread Pavel Machek
Hi! > On 08/16/2015 08:03 PM, Baolin Wang via device-mainlining wrote: > > On 14 August 2015 at 23:27, Greg KH wrote: > >> On Fri, Aug 14, 2015 at 05:47:45PM +0800, Baolin Wang wrote: > >>> + * > >>> + * This program is free software; you can redistribute it and/or modify > >>> + * it under the t

Re: [PATCH v4 1/5] gadget: Introduce the notifier functions

2015-10-08 Thread Pavel Machek
Hi! > > What's the advantage of pushing this to userspace? By the time we > > provide enough discoverability to enable userspace to configure itself > > it seems like we'd have enough information to do the job anyway. > > you're going to be dealing with a setup where each vendor does one thing >

Re: [Device-mainlining] [PATCH v2 2/3] gadget: Introduce the usb charger framework

2015-10-08 Thread Pavel Machek
Hi! > > > * This program is free software; you can redistribute it and/or modify > > > * it under the terms of the GNU General Public License version 2 as > > > * published by the Free Software Foundation. > > > > Please, keep it V2 or later, if you can. It makes sharing code with U-Boot > > (fo

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-04 Thread Pavel Machek
On Tue 2015-02-03 13:18:59, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 00:15:19

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Pavel Machek
> > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > Rejected-by: Pali Rohár > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > on AM335x which has the same musb IP. > > > > > > > >

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Pavel Machek
On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > > > > > Re

Re: [PATCH 0/2] Allow twl4030_charger to find phy reliably.

2015-03-02 Thread Pavel Machek
that. Apart for dt documentation... Acked-by: Pavel Machek > -- > Signature Smiley -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe l

USB Modem support for Droid 4

2019-07-18 Thread Pavel Machek
From: Tony Lindgren Droid starts to have useful support in linux-next. Modem is tricky to play with, but this is enough to get basic support. Signed-off-by: Pavel Machek diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 613f91a..3ca9439 100644 --- a/drivers/usb

Re: USB Modem support for Droid 4

2019-07-19 Thread Pavel Machek
Hi! > * Pavel Machek [190718 20:17]: > > From: Tony Lindgren > > > > Droid starts to have useful support in linux-next. Modem is tricky to > > play with, but this is enough to get basic support. > > Below is a better patch using option driver adding support

Re: USB Modem support for Droid 4

2019-07-21 Thread Pavel Machek
On Fri 2019-07-19 19:27:48, Greg KH wrote: > On Thu, Jul 18, 2019 at 10:17:13PM +0200, Pavel Machek wrote: > > From: Tony Lindgren > > > > Droid starts to have useful support in linux-next. Modem is tricky to > > play with, but this is enough to get basic support. &g

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-07-21 Thread Pavel Machek
Hi! > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. I see you are using debugfs to select betwee

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-07-22 Thread Pavel Machek
Hi! > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel. > > >> > > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which > > >> can be instantiated as Dual-Role Device (DRD), Peripheral Only and > > >> Host Only (XHCI)configurations. > > > > > >I see you

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-07-22 Thread Pavel Machek
On Mon 2019-07-22 13:56:44, Pavel Machek wrote: > Hi! > > > > >> This patch introduce new Cadence USBSS DRD driver to linux kernel. > > > >> > > > >> The Cadence USBSS DRD Controller is a highly configurable IP Core which > > > >>

Re: KASAN: use-after-free Read in __pm_runtime_resume

2019-08-02 Thread Pavel Machek
On Fri 2019-08-02 05:58:05, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=146071b46

Re: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

2019-08-13 Thread Pavel Machek
Hi! > I think that I understand your concerns. My idea was not to expand the > supported > dr_mode. Rather I wanted to have possibility to limit this (only for > testing). > > Eg. > If cdns->dr_mode = USB_DR_MODE_OTG > then we can limit mode to HOST or DEVICE or DRD > if cdns->dr_mode == US

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Pavel Machek
Hi! > idle lcd off phy-mapphone-mdm6600ohci-platform > 153mW 284mW 344mW > > So it seems that MDM6600 is currently not yet idling even with it's > radio turned off, but that's something that is beyond the control of > this USB PHY driver. This patch does get us to t

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Pavel Machek
Hi! > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost$ > > sudo lsusb > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost$ > >

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-23 Thread Pavel Machek
Hi! > > > Do you have the related dts patches picked from next? > > > > > > fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming") > > > e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY") > > > > > > But yeah all you need to do is have phy-mapphone-mdm6600 and > > > ohc

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-23 Thread Pavel Machek
On Fri 2018-03-23 12:35:21, Sebastian Reichel wrote: > Hi, > > On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > > Hi! > > > > > > > Do you have the related dts patches picked from next? > > > > > > > > > &

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-24 Thread Pavel Machek
On Sat 2018-03-24 07:25:17, Tony Lindgren wrote: > * Dan Williams [180324 14:00]: > > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > > Does ofonod work for you? I could not get that one to work... > > > > Because it's looking for a Gobi modem but th

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Pavel Machek
Hi! > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > to react to AT commands, and in particular reacts to ADT123; (; is > > important). > > Is that to dial a voice call? Yes. And it is ATD123; not ATD. > > AT+CMGF=1 > > AT+CMGS="123" > > foo^Z > > > > Works for SMS

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Pavel Machek
Hi! > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > > > to react to AT commands, and in particular reacts to ADT123; (; is > > > > important). > > > > > > Is that to dial a voice call? > > > > Yes. And it is ATD123; not ATD. > > Strange, no semicolon is needed w

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-29 Thread Pavel Machek
Hi! > > Does ofonod work for you? I could not get that one to work... > > Because it's looking for a Gobi modem but the MDM6600 isn't one and > doesn't expose that layout (and doesn't really need to anyway). I > don't think ofono has a generic QMI driver, so you'd either need to for > ce it to u

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-09 Thread Pavel Machek
Hi! > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/usb/ and include/linux/usb* files with the correct > SPDX license identifier based on the license text in the file itself. > The SPDX identifier is a leg

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-09 Thread Pavel Machek
On Thu 2017-11-09 11:40:28, Greg Kroah-Hartman wrote: > On Thu, Nov 09, 2017 at 10:51:48AM +0100, Pavel Machek wrote: > > Hi! > > > > > It's good to have SPDX identifiers in all files to make it easier to > > > audit the kernel tree for correct licenses. &g

v4.15-rc5: resume took way too long, warning in syslog

2017-12-29 Thread Pavel Machek
Hi! v4.15-rc5.. resume took _way_ too long, and I have warn_on in dmesg as a bonus. It looks like USB problem...? I never seen this before. Pavel [42266.070103] PM: Syncing filesystems ... done. [42266.948883] Freezing user

Re: v4.15-rc5: resume took way too long, warning in syslog

2017-12-29 Thread Pavel Machek
On Fri 2017-12-29 11:23:36, Alan Stern wrote: > On Fri, 29 Dec 2017, Pavel Machek wrote: > > > Hi! > > > > v4.15-rc5.. resume took _way_ too long, and I have warn_on in dmesg as > > a bonus. It looks like USB problem...? I never seen this before. > > Is thi

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-09 Thread Pavel Machek
Hi! > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > It is used on some Motorola Mapphone series of phones and tablets such > as Droid 4. ... > So it seems that MDM6600 is currently not yet idling even with it's > radio turned off, but that's something that is beyond the

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

2017-04-15 Thread Pavel Machek
On Wed 2017-04-12 17:08:35, Frederic Weisbecker wrote: > On Mon, Apr 03, 2017 at 08:20:50PM +0200, Pavel Machek wrote: > > > > > > > ...1d.7: PCI fixup... pass 2 > > > > > > > ...1d.7: PCI fixup... pass 3 > > > > > > > ...1d.7: PC

v4.13-rc2: usb mouse stopped working?

2017-07-24 Thread Pavel Machek
Hi! On thinkpad x220, USB mouse stopped working in v4.13-rc2. v4.12 was ok, iirc. Now, USB mouse is so common hw that I may have something wrong in my config...? But I did not change anything there. In v4.9: [ 87.064408] input: Logitech USB Optical Mouse as /devices/pci:00/:00:1d.0/us

Re: v4.13-rc2: usb mouse stopped working?

2017-07-24 Thread Pavel Machek
Hi! > > On thinkpad x220, USB mouse stopped working in v4.13-rc2. v4.12 was > > ok, iirc. > > > > Now, USB mouse is so common hw that I may have something wrong in my > > config...? But I did not change anything there. > > Well, your particular USB mouse requires an always-poll quirk, so it's no

Re: v4.13-rc2: usb mouse stopped working?

2017-07-26 Thread Pavel Machek
Hi! > > In v4.9: > > > > [ 87.064408] input: Logitech USB Optical Mouse as > > /devices/pci:00/:00:1d.0/usb2/2-1/2-1.1/2-1.1.1/2-1.1.1.1/2-1.1.1.1:1.0/0003:046D:C05A.0005/input/input18 > > [ 87.065951] hid-generic 0003:046D:C05A.0005: input,hidraw0: USB HID > > v1.11 Mouse [Logitech U

Re: [PATCH 12/14] dt-bindings: ehci-mv: add bindings

2018-11-02 Thread Pavel Machek
see Rob's Ack anywhere. Is that expected? Anyway, Acked-by: Pavel Machek Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH 05/14] ARM: ttc_dkb: add an instance of pxa-usb-phy

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:42:58, Lubomir Rintel wrote: > This will replace the ttc_usb_pdata.phy_{de,}init()> ">" -> "."? > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > arch/arm/mach-mmp/ttc_dkb.c | 4 > 1 file changed, 4 insertions(+) >

Re: [PATCH 02/14] dt-bindings: phy-pxa-usb: add bindings

2018-11-05 Thread Pavel Machek
+ }; > +This document explains only the device tree data binding. For general > +information about PHY subsystem refer to Documentation/phy.txt Add empty space between last paragraph? Delete "only" and "data"? Acked-by: Pavel Machek

Re: [PATCH 09/14] USB: phy-mv-usb: use phy-pxa-usb

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:43:02, Lubomir Rintel wrote: > Use a proper PHY driver, instead of hooks to a board support package. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.

Re: [PATCH 06/14] ARM: aspenite: add an instance of pxa-usb-phy

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:42:59, Lubomir Rintel wrote: > This will replace the pxa168_sph_pdata.phy_{de,}init(). > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek I'd merge this with the previous patch if it is easy. Your patches are a

Re: [PATCH 13/14] DT: marvell,mmp2: add OTG PHY

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:43:06, Lubomir Rintel wrote: > The USB OTG PHY chip. To be used by the OTG controller. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > arch/arm/boot/dts/mmp2.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm

Re: [PATCH 10/14] USB: gadget: mv-udc: use phy-pxa-usb

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:43:03, Lubomir Rintel wrote: > Use a proper PHY driver, instead of hooks to a board support package. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > arch/arm/mach-mmp/devices.c | 11 +--- > drivers/usb/gadget/udc/

Re: [PATCH 14/14] DT: marvell,mmp2: add USB OTG host controller

2018-11-05 Thread Pavel Machek
On Wed 2018-08-22 22:43:07, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel > --- > arch/arm/boot/dts/mmp2.dtsi | 11 +++ > 1 file changed, 11 insertions(+) Again, I guess this could be merged with the previous patch. Anyway, it is also good to go as-is. Acked-by:

Re: [PATCHv2] USB: serial: option: Add Motorola modem UARTs

2019-08-15 Thread Pavel Machek
ould not in general > be added as they are typically part of a multi-interface function as > noted earlier by Bjørn Mork . Acked-by: Pavel Machek > Cc: Sebastian Reichel > Tested-by: Pavel Machek > Signed-off-by: Tony Lingren -- (english) http://www.live

Re: [PATCH 0/4] musb host improvments mostly for omap2430 glue

2019-09-02 Thread Pavel Machek
Hi! > So I ended up cleaning up omap2430 glue layer a bit for host mode with the > various reproducable errors I was seeing docking droid4 to a lapdock. There > are a few fixes, and then we end up removing all the devctl register tinkering > for omap2430 glue layer. I should have your recent patc

Re: [PATCH 0/4] musb host improvments mostly for omap2430 glue

2019-09-02 Thread Pavel Machek
On Mon 2019-09-02 11:23:44, Pavel Machek wrote: > Hi! > > > So I ended up cleaning up omap2430 glue layer a bit for host mode with the > > various reproducable errors I was seeing docking droid4 to a lapdock. There > > are a few fixes, and then we end up removing

Re: [PATCH 0/4] musb host improvments mostly for omap2430 glue

2019-09-03 Thread Pavel Machek
Hi! On Mon 2019-09-02 09:06:51, Tony Lindgren wrote: > * Pavel Machek [190902 09:44]: > > On Mon 2019-09-02 11:23:44, Pavel Machek wrote: > > Hmm. I guess CONFIG_USB_MUSB_DUAL_ROLE=y might be useful. > > > > And now... if I unplug/replug the usb after the boot

Re: [PATCH 3/7] usb: musb: omap2430: Handle multiple ID ground interrupts

2019-10-13 Thread Pavel Machek
eg > index" errors after enumerating. > > This is happening at least with cpcap phy where we get multiple ID ground > interrupts. Looks like it's VBUS keeps timing out and needs to be kicked > when the phy sends multiple ID ground interrupts during host mode.

Re: [PATCH 7/7] usb: musb: Get rid of omap2430_musb_set_vbus()

2019-10-13 Thread Pavel Machek
t once. > > And we want to disable VBUS unconditionally on disconnect even > without musb->gadget_driver, so let's drop that check too. > > Signed-off-by: Tony Lindgren 4-7: Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures

slab corruption in 5.3-rc3 while inserting an usb key

2019-08-07 Thread Pavel Machek
Hi! Machine is thinkpad x220. BFQ related? [ 8224.904413] usb 2-1.1.4: Product: Intenso Twister Line [ 8224.904421] usb 2-1.1.4: Manufacturer: Alcor Tech [ 8224.904428] usb 2-1.1.4: SerialNumber: 12102500210755 [ 8224.905778] usb-storage 2-1.1.4:1.0: USB Mass Storage device detected [ 8

Re: slab corruption in 5.3-rc3 while inserting an usb key

2019-08-07 Thread Pavel Machek
Hi! > I hope this has to do with the failure reported by Doug. I'm > finalizing my fix. I'd appreciate if you could retry with my fix > applied. Ok, just cc me with the fix ;-). This happened once so far, but I have other crash (when closing chromium) that happens a bit too often, might be rel

<    1   2