Re: [PATCH v5] USB: serial: add Moxa UPORT 11x0 driver

2015-12-28 Thread One Thousand Gnomes
> https://lkml.kernel.org/r/201102171210.03474.fr...@tennebo.com > > However, the TIOCSRS485-ioctl might not even be the right interface for > changing transceiver modes, and instead a sysfs-based > usb-serial-specific interface could be more appropriate for example. sysfs works out very ba

Re: [PATCH] usb:serial: Add Fintek F81532/534 driver

2016-07-29 Thread One Thousand Gnomes
O > +static int f81534_set_normal_register(struct usb_device *dev, u16 reg, u8 > data) > +{ > + size_t count = F81534_USB_MAX_RETRY; > + int status; > + u8 *tmp; > + > + tmp = kmalloc(sizeof(u8), GFP_KERNEL); > + if (!tmp) > + return -ENOMEM; You end up doing huge

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread One Thousand Gnomes
On Sun, 14 Aug 2016 17:34:18 +0800 Tom Yan wrote: > Since when it is expected that SATA disks will always be probed before > USB disks? We can't guarantee that even if we make sure all ata > drivers are loaded before usb-storage/uas. That's why we need > consistent namings (e.g. /dev/disk/by-id/*

Re: [PATCH v2 01/14] USB: ch341: improve documentation

2016-04-06 Thread One Thousand Gnomes
On Sat, 2 Apr 2016 19:07:10 +0200 Grigori Goronzy wrote: > Signed-off-by: Grigori Goronzy > --- > drivers/usb/serial/ch341.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c > index c73808f..43e4594 100644 > ---

Re: [PATCH v2 07/14] USB: ch341: add support for parity, frame length, stop bits

2016-04-06 Thread One Thousand Gnomes
On Sat, 2 Apr 2016 19:07:16 +0200 Grigori Goronzy wrote: > With the new reinitialization method, configuring parity, different > frame lengths and different stop bit settings work as expected on > both CH340G and CH341A. This has been extensively tested with a > logic analyzer. > > Tested-by:

Re: [PATCH v1 1/1] usb: gadget: NCM: NULL pointer dereference in eth_start_xmit

2016-04-25 Thread One Thousand Gnomes
On Mon, 25 Apr 2016 16:25:03 +0100 wrote: > From: Jim Baxter > > "Unable to handle kernel NULL pointer dereference at virtual address > 0078" is reported with "PC is at eth_start_xmit+0x19c/0x378 [u_ether]" > > The failure scenario is seen when closing the NCM connection while the > TCP/IP

Re: SPDX-License-Identifier

2014-02-25 Thread One Thousand Gnomes
On Mon, 24 Feb 2014 06:26:52 -0800 Greg Kroah-Hartman wrote: > On Mon, Feb 24, 2014 at 03:03:25PM +0100, Michal Simek wrote: > > > > BTW: Isn't this a good topic for kernel-summit? :-) > > No, lawyers don't go to the summit, developers do. More of a topic for the LF. Particularly as any attemp

Re: [PATCH] cdc-acm: some enhancement on acm delayed write

2014-04-08 Thread One Thousand Gnomes
> (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when > close. If acm resume callback run after ASYNCB_INITIALIZED flag > cleared, there will have no chance for delayed write to start. > That lead to acm_wb.use can't be cleared. If user space open > acm tty again and try to setd, tty will

Re: [RFC 1/2] n_tty: fix dropped output characters

2014-04-14 Thread One Thousand Gnomes
On Fri, 11 Apr 2014 11:41:24 +0200 Johan Hovold wrote: > Fix characters being dropped by n_tty_write() due to a failure to > check the return value of tty_put_char() in do_output_char(). > > Characters are currently being dropped by write if a tty driver claims > to have write room available, bu

Re: [RFC 1/2] n_tty: fix dropped output characters

2014-04-14 Thread One Thousand Gnomes
On Mon, 14 Apr 2014 15:05:49 +0200 Oliver Neukum wrote: > On Mon, 2014-04-14 at 13:53 +0100, One Thousand Gnomes wrote: > > On Fri, 11 Apr 2014 11:41:24 +0200 > > Johan Hovold wrote: > > > > > Fix characters being dropped by n_tty_write() due to a failure to &

Re: [PATCH] usb: pci-quirks: do not access OHCI_FMINTERVAL register on ULI hw

2014-05-29 Thread One Thousand Gnomes
> I don't know how linux usb subsystem should behave against such > "half-existing" hardware. Perhaps hanging is not the best idea... > but maybe it should be fixed elsewhere, e.g. by masking non-wired > devices in platform PCI setup. Perhaps controlled by some device-tree > key. Does it have a un

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-09 Thread One Thousand Gnomes
> #include > #include > +#ifdef CONFIG_GPIOLIB > +#include > +#endif Please create a new struct, a new file and put all the GPIO stuff in there rather than #if bombing the driver. You can then declare blank methods for the gpio stuff if GPIO is not compiled in - ie in the headers #ifdef C

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread One Thousand Gnomes
> > drivers/usb/serial/ftdi_sio.c | 111 > > +- > > drivers/usb/serial/ftdi_sio.h | 41 > > 2 files changed, 151 insertions(+), 1 deletion(-) > > Funny patch, you should have saved it for April 1, otherwise people > might have actually ta

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

2014-07-10 Thread One Thousand Gnomes
On Thu, 10 Jul 2014 14:37:37 + David Laight wrote: > From: Olivier Sobrie > ... > > The function put_rxbuf_data() is called from the urb completion handler. > > It puts the data of the urb transfer in the tty buffer with > > tty_insert_flip_string_flags() and schedules a work queue in order t

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

2014-07-10 Thread One Thousand Gnomes
> You really want to apply flow control back over the 'serial' link. > That may just cause data discards earlier on the local system. > But it is possible that not resubmitting the receive urb will cause the > modem to flow control back to the sender. > In which case there is some chance that data

Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

2014-07-14 Thread One Thousand Gnomes
xbuf_data() which is > called by the urb completion handler. > If there isn't enough room in the tty buffer, discards all the data > received in the URB. > > Cc: David Miller > Cc: David Laight > Cc: One Thousand Gnomes > Cc: Dan Williams > Cc: Jan Dumon > Si

Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-23 Thread One Thousand Gnomes
> --- a/drivers/usb/serial/pl2303.c > +++ b/drivers/usb/serial/pl2303.c > @@ -28,6 +28,9 @@ > #include > #include > #include > +#ifdef CONFIG_USB_SERIAL_PL2303_GPIO > +#include > +#endif > #include "pl2303.h" Just include the file anyway it does no harm > > > @@ -143,9 +146,27 @@ stru

Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-24 Thread One Thousand Gnomes
On Wed, 23 Jul 2014 09:21:29 -0700 Greg KH wrote: > On Wed, Jul 23, 2014 at 05:03:14PM +0100, One Thousand Gnomes wrote: > > > + if (gpiochip_remove(&spriv->gpio->gpio_chip)) > > > + dev_err(&serial->interface->d

Re: [PATCH v2 3/4] usb: serial: implement function for F81232

2015-01-21 Thread One Thousand Gnomes
> + if (cflag & PARENB) { > + if (cflag & PARODD) > + new_lcr |= UART_LCR_PARITY; /* odd */ > + else > + new_lcr |= SERIAL_EVEN_PARITY; /* even */ > + } If you don't support mark/space also clear CMSPAR in the passed termios