e why you need this now, but that is irrelevant to having a chip
>> specific
>> compatible string.
>
> Maybe a property is better.
It seems that it's not an issue to the binding that Rob is talking about
but the description that you used: "for SAMA5D2 which can force
su
+ * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +#ifndef __AT91_SFR_H__
> +#define __AT91_SFR_H__
> +
> +#define SFR_DDRCFG 0x04/* DDR Configuration Register */
> +/* 0x08 ~ 0x
0x0040 0x100000>;
> interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
> clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 08/06/2016 12:04, Nicolas Ferre a écrit :
> Le 08/06/2016 06:15, Wenyou Yang a écrit :
>> In order to the save power consumption, as a workaround, suspend
>> forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI
>> Interrupt Configuration Register in the SFRs w
tatic?
>
> Signed-off-by: Ben Dooks
> ---
> Cc: Alan Stern
> Cc: Greg Kroah-Hartman
> Cc: linux-usb@vger.kernel.org
> Cc: Nicolas Ferre
> Cc: Alexandre Belloni
Acked-by: Nicolas Ferre
> Cc: Jean-Christophe Plagniol-Villard
> ---
> drivers/usb/host/ohci-a
his workaround/feature... well, it's
simple, we don't look for the SFR, we don't use the bits, and we come
back to the situation that we've always experienced ; with the same
compatibility sting for OHCI as the IP never actually changed...
In conclusion: try Alexandre'
be done before the USB clock is disabled,
> resume after the USB clock is enabled.
>
> Signed-off-by: Wenyou Yang
Acked-by: Nicolas Ferre
Alan, can you take it as it doesn't have dependency on the at91 material
anymore.
Thanks, bye.
> ---
>
> Changes in v4:
> -
Only compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Andrew Victor
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc: Jean-Christophe Plagniol-Villard
> Cc: Felipe Balbi
> Cc: linux-usb@vger.kernel.org
> ---
> Please let me know how this patch should be routed. I can ta
On 12/23/2012 07:08 PM, Jean-Christophe PLAGNIOL-VILLARD :
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
Acked-by: Nicolas Ferre
> Cc: linux-usb@vger.kernel.org
> ---
> drivers/usb/gadget/at91_udc.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
Le 01/12/2016 à 11:26, Alexandre Belloni a écrit :
> Use devm_kasprintf instead of simple kasprintf to free the allocated memory
> when needed.
>
> Suggested-by: Peter Rosin
> Signed-off-by: Alexandre Belloni
Acked-by: Nicolas Ferre
> ---
> drivers/usb/gadget/udc
008078)
> ---[ end trace e7cf9dcebf4815a6 ]---
>
> Fixes: c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes")
> Reported-by: Richard Genoud
> Signed-off-by: Alexandre Belloni
Acked-by: Nicolas Ferre
Felipe, Greg,
It is clearly a regression and material for 4.8-fixe
Le 16/09/2016 à 10:36, Nicolas Ferre a écrit :
> Le 15/09/2016 à 17:07, Alexandre Belloni a écrit :
>> Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"),
>> atmel_usba_udc fails with:
>>
>> [ cut here ]
>>
rs/usb/gadget/function/u_serial.c | 4 ++--
> drivers/usb/gadget/udc/at91_udc.h | 2 +-
> drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
For AT91 and Atmel parts:
Acked-by: Nicolas Ferre
Thanks
> drivers/usb/gadget/udc/fsl_usb2_udc.h | 2 +-
> drivers/usb/gadget/
Le 28/09/2016 à 15:05, Felipe Balbi a écrit :
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc:
> Signed-off-by: Felipe Balbi
&g
Le 28/09/2016 à 15:05, Felipe Balbi a écrit :
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
>
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc:
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/gadget/udc/atme
Le 18/10/2016 à 13:05, Peter Rosin a écrit :
> Signed-off-by: Peter Rosin
Acked-by: Nicolas Ferre
We may take it in a future at91-x.y-dt branch which will go through arm-soc.
Thanks
> ---
> Documentation/devicetree/bindings/usb/atmel-usb.txt | 10 +-
> 1 file changed,
Le 26/09/2016 à 09:18, Felipe Balbi a écrit :
>
> Hi,
>
> Greg Kroah-Hartman writes:
>> On Fri, Sep 23, 2016 at 04:20:45PM +0200, Nicolas Ferre wrote:
>>> Le 16/09/2016 à 10:36, Nicolas Ferre a écrit :
>>>> Le 15/09/2016 à 17:07, Alexandre Belloni a écrit
Le 31/10/2016 à 11:48, Felipe Balbi a écrit :
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
>
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc:
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/gadget/udc/atmel_usb
Le 31/10/2016 à 11:48, Felipe Balbi a écrit :
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc:
> Signed-off-by: Felipe Balbi
&g
#ifdef and instead uses a __maybe_unused
> annotation to let the compiler know it can silently drop
> the function definition.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Nicolas Ferre
Thanks Arnd, bye.
> ---
> drivers/usb/host/ohci-at91.c | 8 +++-
> 1 file changed
#ifdef and instead uses a __maybe_unused
> annotation to let the compiler know it can silently drop
> the function definition.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Nicolas Ferre
> ---
> drivers/usb/host/ehci-atmel.c | 6 ++
> 1 file changed, 2 insertions(+), 4 de
Le 29/03/2016 11:28, Felipe Balbi a écrit :
> coccicheck found this pattern which could be
> converted to PTR_ERR_OR_ZERO(). No functional
> changes.
>
> Signed-off-by: Felipe Balbi
Acked-by: Nicolas Ferre
Thanks Felipe for having taken care of this!
Bye,
> ---
> d
t;= 8)
> + ep->ept_cfg = USBA_BF(EPT_SIZE,
> USBA_EPT_SIZE_8);
> + else
> + /* LSB is bit 1, not 0 */
> + ep->ept_cfg =
> + USBA_BF(EPT_SIZE, fls(ep->fifo_size - 1) - 3);
> +
> + ep->ept_cfg |= USBA_BF(BK_NUMBER, ep->nr_banks);
> + }
> +
> if (i)
> list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.h
> b/drivers/usb/gadget/udc/atmel_usba_udc.h
> index b03b2eb..9551b70 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.h
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.h
> @@ -275,6 +275,12 @@ struct usba_dma_desc {
> u32 ctrl;
> };
>
> +struct usba_fifo_cfg {
> + u8 hw_ep_num;
> + u16 fifo_size;
> + u8 nr_banks;
> +};
> +
> struct usba_ep {
> int state;
> void __iomem*ep_regs;
> @@ -293,7 +299,7 @@ struct usba_ep {
> unsigned intcan_isoc:1;
> unsigned intis_isoc:1;
> unsigned intis_in:1;
> -
> + unsigned long ept_cfg;
> #ifdef CONFIG_USB_GADGET_DEBUG_FS
> u32 last_dma_status;
> struct dentry *debugfs_dir;
> @@ -338,6 +344,8 @@ struct usba_udc {
> int vbus_pin;
> int vbus_pin_inverted;
> int num_ep;
> + int configured_ep;
> + struct usba_fifo_cfg *fifo_cfg;
> struct clk *pclk;
> struct clk *hclk;
> struct usba_ep *usba_ep;
>
Regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 27/01/2017 à 14:47, Cristian Birsan a écrit :
> I will send a fixup patch with updates based on the comments received from
> Nicolas.
>
> On 01/26/2017 05:02 PM, Nicolas Ferre wrote:
>> Le 23/01/2017 à 15:45, cristian.bir...@microchip.com a écrit :
>>> From: Cris
et/cadence/macb.h:862:2: error: unknown type name
> 'phy_interface_t'
> phy_interface_t phy_interface;
> ^~~
>
> Add linux/phy.h to macb.h
>
> Signed-off-by: Russell King
Acked-by: Nicolas Ferre
> ---
> drivers/net/ethernet/cadence/macb.h
bug output the same way as the other code.
>>
>> Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation
>> scheme")
>> Signed-off-by: Arnd Bergmann
> Acked-by: Alexandre Belloni
Acked-by: Nicolas Ferre
>
>> ---
>> dri
+---
> 2 files changed, 35 insertions(+), 17 deletions(-)
I'm okay with the whole series:
Acked-by: Nicolas Ferre
Thanks, regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; sleep and will not wakeup when an USB devices is inserted.
>
> Fixes: 2e2aa1bc7eff90ec ("usb: ohci-at91: Forcibly suspend ports while USB
> suspend")
> Signed-off-by: Jelle Martijn Kok
> Tested-by: Wenyou Yang
> Cc: Wenyou Yang
> Cc: Alexandre Belloni
> Cc:
patch
As for previous revision, the whole series:
Acked-by: Nicolas Ferre
Regards,
> Cristian Birsan (4):
> usb: gadget: udc: atmel: Check fifo configuration values against
> device tree
> usb: gadget: udc: atmel: Minor code cleanup
> usb: gadget: udc: atmel: Use dev_war
ipe,
I see mush more use of DMA_ADDR_INVALID in this driver... Is there
another patch series that I am missing?
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/14/2013 09:56 AM, Felipe Balbi :
> DMA_ADDR_INVALID isn't (and shouldn't) be used
> anymore, let's remove it.
>
> Signed-off-by: Felipe Balbi
Acked-by: Nicolas Ferre
Thanks Felipe. Bye.
> ---
> drivers/usb/gadget/atmel_usba_udc.h | 6 --
> 1 fi
0ee6d1e (USB: ohci-at91:
change maximum number of ports) that did not modified the associatd
board files.
Reported-by: Klaus Falkner
Signed-off-by: Nicolas Ferre
Cc: Alan Stern
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Cc: Stable [3.4+]
---
drivers/usb/host/ohci-at91.c | 10
On 08/29/2012 11:49 AM, Nicolas Ferre :
> If the number of ports present on the SoC/board is not the maximum
> and that the platform data is not filled with all data, there is
> an easy way to mess the PIO setup for this interface.
> This quick fix addresses mis-configuration in USB h
On 09/07/2012 03:27 PM, Fabio Porcedda :
> Don't fail the initialization check for the platform_data
> if there is avaiable an associated device tree node.
>
> Signed-off-by: Fabio Porcedda
Acked-by: Nicolas Ferre
Thanks, bye,
> ---
> drivers/usb/gadget/at91_udc.c |
pport").
>
> Tested on a at91sam9260 based board (PRO3-EVK).
>
> Signed-off-by: Fabio Porcedda
> Cc: Stable [v3.4+]
> Cc: Jean-Christophe PLAGNIOL-VILLARD
Acked-by: Nicolas Ferre
Felipe, Greg, can we queue this one for 3.6-final ?
Best regards,
> ---
> v2:
> -
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/12/2012 08:14 AM, Felipe Balbi :
> Hi,
>
> On Tue, Sep 11, 2012 at 02:20:19PM +0200, Nicolas Ferre wrote:
>> On 09/11/2012 02:07 PM, Fabio Porcedda :
>>> Don't fail the initialization check for the platform_dat
at91/clk-system.c
create mode 100644 drivers/clk/at91/clk-usb.c
create mode 100644 drivers/clk/at91/clk-utmi.c
rename arch/arm/mach-at91/include/mach/at91_pmc.h => include/linux/clk/at91.h
(76%)
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb&q
BREZILLON
Acked-by: Nicolas Ferre
---
drivers/usb/gadget/at91_udc.c | 17 -
drivers/usb/gadget/at91_udc.h |2 +-
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index fce8e4e..ae06585 100644
IS_ENABLED(CONFIG_COMMON_CLK) to isolate new at91 clk support
Signed-off-by: Boris BREZILLON
Well, for this v2 as well:
Acked-by: Nicolas Ferre
(even if it is too late)
Bye,
---
drivers/usb/host/ohci-at91.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions
On 12/08/2013 22:42, boris brezillon :
Hello Nicolas,
On 12/08/2013 15:52, Nicolas Ferre wrote:
On 01/08/2013 08:18, Boris BREZILLON :
The AT91 PMC (Power Management Controller) provides an USB clock used by
USB Full Speed host (ohci) and USB Full Speed device (udc).
The usb drivers (ohci and
Signed-off-by: Deepak Saxena
Acked-by: Alan Stern
Otherwise, seems correct.
Acked-by: Nicolas Ferre
Cc: Arnd Bergmann
Cc: Greg KH
Cc: linux-usb@vger.kernel.org
V3->V4:
- Removed extra space after "tristate".
- Removed extra space between function name and '('
the correct API.
Signed-off-by: Russell King
---
drivers/usb/chipidea/ci_hdrc_imx.c |5 +++--
drivers/usb/dwc3/dwc3-exynos.c |5 +++--
drivers/usb/gadget/lpc32xx_udc.c |4 +++-
drivers/usb/host/ehci-atmel.c |5 +++--
For Atmel driver:
Acked-by: Nicolas Ferre
On 20/09/2013 00:02, Russell King :
Signed-off-by: Russell King
---
drivers/usb/chipidea/ci_hdrc_imx.c |4 +---
drivers/usb/dwc3/dwc3-exynos.c |4 +---
drivers/usb/host/ehci-atmel.c |4 +---
For Atmel driver:
Acked-by: Nicolas Ferre
[..]
diff --git a/drivers/usb
ails.
Cc: Jean-Christophe PLAGNIOL-VILLARD
Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
Thanks Johan.
Signed-off-by: Johan Hovold
---
drivers/pcmcia/at91_cf.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.
-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
arch/arm/mach-at91/at91rm9200.c|2 +-
arch/arm/mach-at91/at91sam9260.c |2 +-
arch/arm/mach-at91/at91sam9261.c |2 +-
arch/arm/mach-at91/at91sam9263.c
Acked-by: Nicolas Ferre
Thanks
---
arch/arm/mach-at91/Kconfig| 21 +
arch/arm/mach-at91/Kconfig.non_dt |6 ++
arch/arm/mach-at91/Makefile |2 +-
arch/arm/mach-at91/generic.h |3 ++-
arch/arm/mach-at91/setup.c|6 --
*irqdomain;
+};
+
+static inline void pmc_lock(struct at91_pmc *pmc)
+{
+ spin_lock(&pmc->lock);
+}
+
+static inline void pmc_unlock(struct at91_pmc *pmc)
+{
+ spin_unlock(&pmc->lock);
+}
+
+static inline u32 pmc_read(struct at91_pmc *pmc, int offset)
+{
+ return r
On 11/10/2013 10:41, Boris BREZILLON :
This patch adds a new macro file for PMC macros.
This macro file includes the definitions of SR (status register) bit
offsets and will be use to reference PMC irqs.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
include/dt-bindings/clk
BREZILLON
Acked-by: Nicolas Ferre
---
drivers/clk/at91/Makefile |1 +
drivers/clk/at91/clk-main.c | 189 +++
drivers/clk/at91/pmc.c |5 ++
drivers/clk/at91/pmc.h |3 +
4 files changed, 198 insertions(+)
create mode 100644
clock output rate
These characteristics are checked during rate change to avoid
over/underclocking.
These characteristics are described in atmel's SoC datasheet in
"Electrical Characteristics" paragraph.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/cl
ned-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/clk/at91/Makefile |1 +
drivers/clk/at91/clk-system.c | 193 +
drivers/clk/at91/pmc.c|5 ++
drivers/clk/at91/pmc.h|3 +
4 files changed, 202 insertions(+
Electrical Characteristics" paragraph.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/clk/at91/Makefile |2 +-
drivers/clk/at91/clk-pll.c| 545 +
drivers/clk/at91/clk-plldiv.c | 137 +++
drivers
ff-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/clk/at91/Makefile |2 +-
drivers/clk/at91/clk-peripheral.c | 407 +
drivers/clk/at91/pmc.c|9 +
drivers/clk/at91/pmc.h|5 +
4 files changed
On 11/10/2013 11:53, Boris BREZILLON :
This patch adds the peripheral divisors macros (for sam9x5 compatible IPs)
which will be used by peripheral clk dt definitions.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
include/dt-bindings/clk/at91.h |6 ++
1 file changed
igned to the
appropriate peripheral (see atmel's datasheets).
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/clk/at91/Makefile |2 +
drivers/clk/at91/clk-programmable.c | 423 +++
drivers/clk/at91/pmc.c
On 11/10/2013 12:22, Boris BREZILLON :
This adds new at91 utmi clock implementation using common clk framework.
This clock is a pll with a fixed factor (x40).
It is used as a source for usb clock.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
arch/arm/mach-at91/Kconfig
0644
--- a/drivers/clk/at91/pmc.c
+++ b/drivers/clk/at91/pmc.c
@@ -279,6 +279,17 @@ static const struct of_device_id pmc_clk_ids[] __initdata
= {
.data = of_at91sam9x5_clk_utmi_setup,
},
#endif
+ /* USB clock */
+#if defined(CONFIG_HAVE_AT91_USB_CLK)
+ {
+
On 11/10/2013 13:27, Boris BREZILLON :
This patch adds at91 smd (Soft Modem) clock implementation using common clk
framework.
Not used by any driver right now.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
arch/arm/mach-at91/Kconfig |5 ++
drivers/clk/at91/Makefile
On 11/10/2013 13:38, Boris BREZILLON :
This patch adds new at91 clks dt bindings documentation.
Signed-off-by: Boris BREZILLON
It seems good
Acked-by: Nicolas Ferre
---
.../devicetree/bindings/clock/at91-clock.txt | 328
1 file changed, 328 insertions
On 17/10/2013 18:55, Boris BREZILLON :
This patch adds new at91 usb clock implementation using common clk framework.
This clock is used to clock usb ports (ohci, ehci and udc).
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Ok, this one is now replacing the older 13/17.
Thanks
include/dt-bindings/clk/at91.h
rename {arch/arm/mach-at91/include/mach => include/linux/clk}/at91_pmc.h (98%)
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info
configuration was formely done in mach-at91/clock.c, but will be
bypassed when moving to common clk framework.
This patch adds support for usb clock retrieval and configuration only if
CCF is enabled (CONFIG_COMMON_CLK).
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Greg, as this patch is
de 100644 drivers/clk/at91/pmc.h
create mode 100644 include/dt-bindings/clk/at91.h
rename {arch/arm/mach-at91/include/mach => include/linux/clk}/at91_pmc.h (98%)
--
1.7.9.5
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of
80 (e5903028)
> [7.81] ---[ end trace 85aa37ed128143b5 ]---
> [7.81] Kernel panic - not syncing: Fatal exception in interrupt
>
> Commit 6fffb77c (USB: ohci-at91: fix PIO handling in relation with number of
> ports) started setting unused pins to EINVAL. But this exposed a
On 09/24/2012 07:34 PM, Greg KH :
> On Mon, Sep 24, 2012 at 09:44:31AM +0200, Nicolas Ferre wrote:
>>> This patches fixed the issue by adding the gpio valid check.
>>>
>>> Signed-off-by: Joachim Eastwood
>>
>> Acked-by: Nicolas Ferre
>>
>
On 09/25/2012 03:40 PM, Greg KH :
> On Tue, Sep 25, 2012 at 11:48:43AM +0200, Nicolas Ferre wrote:
>> On 09/24/2012 07:34 PM, Greg KH :
>>> On Mon, Sep 24, 2012 at 09:44:31AM +0200, Nicolas Ferre wrote:
>>>>> This patches fixed the issue by adding the gpio valid
lves the bit HCD_FLAG_HW_ACCESSIBLE, which is now handled by
> ohci_resume().
>
> Signed-off-by: Florian Fainelli
> ---
> drivers/usb/host/ohci-at91.c |2 +-
Seems ok for AT91, so
Acked-by: Nicolas Ferre
Thanks Florian, bye,
> drivers/usb/host/ohci-ep93xx.c |
|2 +-
> arch/arm/configs/at91sam9g20_defconfig |2 +-
For AT91 related defconfigs:
Acked-by: Nicolas Ferre
> arch/arm/configs/corgi_defconfig |2 +-
> arch/arm/configs/davinci_all_defconfig |2 +-
> arch/arm/configs/h7202_de
ttempt to remove the files, Andrew said that it
was used internally in his former company. I had no serious reason to
remove it, so we kept it back then.
But now it seems the situation has evolved and we must consider the move
to a single kernel image and the will to clean the include/asm/mach
d
i-atmel.c| 2 +-
> drivers/usb/host/ohci-at91.c | 2 +-
For Atmel:
Acked-by: Nicolas Ferre
[..]
> diff --git a/drivers/usb/c67x00/c67x00-drv.c b/drivers/usb/c67x00/c67x00-drv.c
> index 6f3b6e2..855d538 100644
> --- a/drivers/usb/c67x00/c67x00-drv.c
> +++ b/drive
ost/Kconfig
>> index 01c1acb..8c564aa 100644
>> --- a/drivers/usb/host/ehci-atmel.c
>> +++ b/drivers/usb/host/ehci-atmel.c
I missed the patch itself but I reviewed it on the mailing-list archive.
So, here is my:
Acked-by: Nicolas Ferre
Thanks a lot for having taking c
On 06/05/2013 13:37, Sachin Kamat :
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat
Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
---
drivers/usb/gadget/atmel_usba_udc.c |2
On 23/05/2013 04:23, Bo Shen :
Hi J,
On 5/21/2013 00:25, Jean-Christophe PLAGNIOL-VILLARD wrote:
so we can have multiple usb gadget instance
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
Cc: Nicolas Ferre
Cc: linux-usb@vger.kernel.org
For this series, test OK on at91sam9m10g45ek and
On 03/12/2013 15:07, Boris BREZILLON :
Replace the request_mem_region + ioremap calls by the
devm_request_and_ioremap call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
Tested-by: Robert Nelson
Acked-by: Nicolas Ferre
---
drivers/usb/host
avoid resource type mismatch.
Signed-off-by: Boris BREZILLON
Tested-by: Robert Nelson
Acked-by: Nicolas Ferre
---
drivers/usb/host/ohci-at91.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci
On 03/12/2013 15:07, Boris BREZILLON :
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Tested-by: Robert Nelson
Acked-by: Nicolas Ferre
Thanks Boris for these fixes.
Alan, Greg, can you take the whole series as fixes for 3.13?
Thanks, best regards
gt;regs);
-
- err2:
- release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
-
err1:
usb_put_hcd(hcd);
return retval;
@@ -246,15 +224,7 @@ static void usb_hcd_at91_remove(struct usb_hcd *hcd,
{
usb_remove_hcd(hcd);
at91_stop_hc(pdev);
- iounmap(hcd
On 16/12/2013 07:13, Jingoo Han :
> Use devm_*() functions to make cleanup paths simpler.
>
> Signed-off-by: Jingoo Han
Acked-by: Nicolas Ferre
Thanks, bye,
> ---
> drivers/usb/gadget/atmel_usba_udc.c | 64
> ++-
> 1 file changed,
it be static?
>
> Signed-off-by: Jingoo Han
Acked-by: Nicolas Ferre
Thanks.
> ---
> drivers/usb/gadget/atmel_usba_udc.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c
> b/drivers/usb/gadget/atmel_
On 17/01/2014 03:59, Bo Shen :
> In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS
> is only 7. So, fix it for sama5d3 SoC using the udc->num_ep.
>
> Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
> ---
>
> drivers/usb/gadget/atmel_usba_udc.c | 2
On 17/01/2014 03:59, Bo Shen :
> When the SoC is earlier than sama5d3 SoC, which have the same number
> endpoints and DMAs. However for sama5d3 SoC, it has different number
> for endpoints and DMAs. So, define USBA_NR_DMAs for DMA channels
>
> Signed-off-by: Bo Shen
Acked-by
->num_ep;
> ---8<---
It seems to me pretty valid to use num_ep in this driver and not have to
rely on another compatibility string just for this.
The information is here, it is retrieved pretty cleanly so I vote for a
simple use of it: if we introduce another information we will have to
clock
preparation and setting clock rate into process context (at91udc_probe).
Signed-off-by: Ronald Wahl
Acked-by: Alexandre Belloni
Acked-by: Boris Brezillon
Acked-by: Nicolas Ferre
Cc: Felipe Balbi
Cc: # v3.17+
---
Hi Felipe,
I forgot to answer you on this patch. So I resend it now with the
Shen
Seems okay, even if I am not used to these aspects:
Acked-by: Nicolas Ferre
I would also add a "stable" tag to these patches, something like this:
Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver)
Cc: sta...@vger.kernel.org # always been there...
Felipe,
Can you take bo
ve_data() function, this bit RXRDY has been cleared.
> So, after the receive_data() function return, this bit should
> not be cleared again, or else it may cause the accessing FIFO
> corrupt, which will make the data loss.
>
> Signed-off-by: Bo Shen
Seems okay:
Acked-by: Nicolas Fe
Le 19/12/2014 15:02, Ronald Wahl a écrit :
> On 19.12.2014 14:51, Luis Henriques wrote:
>> Hi Felipe,
>>
>> On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote:
>>> On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote:
>>&g
g_cleanup [g_hid]) from []
(SyS_delete_module+0x118/0x19c)
[] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x30)
Code: bad PC value
Signed-off-by: Songjun Wu
[nicolas.fe...@atmel.com: reworked the commit message]
Signed-off-by: Nicolas Ferre
Fixes: 914a3f3b3754 ("USB: add atmel_usba_udc
er in commit message of patch 2
>
> Changes since v1:
> - cache INT_ENB value to speedup INT_ENB read operations
To the whole series:
Acked-by: Nicolas Ferre
Thanks.
> Boris Brezillon (5):
> usb: atmel_usba_udc: Rework at91sam9rl errata handling
> usb: atmel_usba_udc: Add
gadget: at91_udc: Remove non-DT handling code
> usb: gadget: at91_udc: Simplify probe and remove functions
> usb: gadget: at91_udc: Rework for multi-platform kernel support
> usb: gadget: at91_udc: Update DT binding documentation
> usb: gadget: at91_udc: Allocate udc instance
I
ILLON
Acked-by: Nicolas Ferre
Cc: stable # 3.4
---
drivers/usb/gadget/at91_udc.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index cea8c20a1425..1926925a52a9 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/driver
gt;num_ep, which get from platform data for non-dt kernel,
> or parse from dt node.
>
> Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
> ---
> Changes in v2:
> - Make the commit message more clearer.
>
> drivers/usb/gadget/atmel_usba_udc.c | 2 +-
> 1 file changed, 1 i
ints and DMA channels.
> So, define a new micro USBA_NR_DMAs for DMA channels. And the
s/micro/macro/
> USBA_NR_ENDPOINS is not used anymore, remove it at the same time.
>
> Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
> ---
> Changes in v2:
> - Make the commit message more
mel_udc_of_init(struct
> platform_device *pdev,
> i++;
> }
>
> + if (i == 0) {
> + dev_err(&pdev->dev, "of_probe: no endpoint specified\n");
> + ret = -EINVAL;
> + goto err;
> + }
> +
It
On 12/02/2014 14:03, Nicolas Ferre :
> From: Jean-Jacques Hiblot
>
> When using dt resources retrieval (interrupts and reg properties) there is
> no predefined order for these resources in the platform dev resource
> table. Also don't expect the number of resource to be alway
On 12/03/2014 16:31, Greg Kroah-Hartman :
> On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote:
>> On 12/02/2014 14:03, Nicolas Ferre :
>>> From: Jean-Jacques Hiblot
>>>
>>> When using dt resources retrieval (interrupts and reg properties) there
ILLON
Acked-by: Nicolas Ferre
Cc: stable # 3.4
---
drivers/usb/gadget/at91_udc.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index cea8c20a1425..1926925a52a9 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/driver
-by: Alexandre Belloni
Acked-by: Nicolas Ferre
Thanks,
> ---
> drivers/usb/gadget/atmel_usba_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c
> b/drivers/usb/gadget/atmel_usba_udc.c
> index 9f653
Le 07/07/2015 16:02, Robert Baldyga a écrit :
> Add missing return value check. In case of error print debug message
> and return error code.
>
> Signed-off-by: Robert Baldyga
Yes, it's indeed missing:
Acked-by: Nicolas Ferre
Thanks, bye.
> ---
> drivers/usb/gadget/u
Le 10/08/2015 16:29, Alexandre Belloni a écrit :
> Definitions from linux/platform_data/atmel.h are not used, remove the
> include.
>
> Signed-off-by: Alexandre Belloni
Acked-by: Nicolas Ferre
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 1 -
> 1 file changed, 1
Le 10/08/2015 16:46, Alexandre Belloni a écrit :
> struct at91_udc_data is now only used inside the driver, move it to its
> include.
>
> Signed-off-by: Alexandre Belloni
Acked-by: Nicolas Ferre
Thanks.
> ---
> drivers/usb/gadget/udc/at91_udc.h | 8
> includ
1 - 100 of 158 matches
Mail list logo
