le there is not users of both PHY types at the same time, drop this
limitation from the xhci-plat.c driver. Note that the tegra driver
probably has the same limitation and could definitely benefit from a
similar change.
Cc: Johan Hovold
Cc: Martin Blumenstingl
Signed-off-by: Miquel Raynal
---
dr
Hi Martin,
Martin Blumenstingl wrote on Tue,
26 Mar 2019 18:29:25 +0100:
> Hello Miquel,
>
> On Tue, Mar 26, 2019 at 9:39 AM Miquel Raynal
> wrote:
> >
> > In the past, USB PHY handling has been moved in the HCD core. Some
> > host controller drivers needing
Hi Martin,
Martin Blumenstingl wrote on Sat,
30 Mar 2019 13:53:29 +0100:
> Hi Miquel,
>
> On Fri, Mar 29, 2019 at 4:16 PM Miquel Raynal
> wrote:
> >
> > Hi Martin,
> >
> > Martin Blumenstingl wrote on Tue,
> > 26 Mar 2019 18:29:25 +0100:
> >
Hello,
I am reading the document named "xHCI interoperability testing v0.94"
available on usb.org. There is this paragraph:
Devices operating at Enhanced SuperSpeed GenX are allowed to
draw a maximum configured current of 900mA and unconfigured
current of 150mA. Devices op
Hello,
Adding Greg & Hans just in case they have an idea, or someone else to
ping in mind.
Miquel Raynal wrote on Wed, 3 Apr 2019
10:13:43 +0200:
> Hello,
>
> I am reading the document named "xHCI interoperability testing v0.94"
> available on usb.or
Hi Hans,
Hans de Goede wrote on Tue, 9 Apr 2019 09:38:01
+0200:
> Hi,
>
> On 09-04-19 09:26, Miquel Raynal wrote:
> > Hello,
> >
> > Adding Greg & Hans just in case they have an idea, or someone else to
> > ping in mind.
> >
> > Miquel Ra
le there is not users of both PHY types at the same time, drop this
limitation from the xhci-plat.c driver. Note that the tegra driver
probably has the same limitation and could definitely benefit from a
similar change.
Cc: Johan Hovold
Cc: Martin Blumenstingl
Signed-off-by: Miquel Raynal
Acked-by:
present
on the A3700 SoC.
Signed-off-by: Ofer Heifetz
[miquel.ray...@bootlin.com: Reword the commit message]
Signed-off-by: Miquel Raynal
---
drivers/usb/host/Kconfig | 2 +-
drivers/usb/host/xhci-mvebu.c | 11 +++
drivers/usb/host/xhci-mvebu.h | 6 ++
drivers/usb/host/xhci-plat.c
is updated (patch 3) to reference
the PHY. xHCI bindings already document the PHY so no update is needed
on this regard.
[1] http://code.bulix.org/s2ccd4-511198
[2]
http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/614527.html
Thanks,
Miquèl
Miquel Raynal (2):
usb: core
The USB3 node is wired to the first PHY of the COMPHY IP.
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
b/arch/arm64/boot/dts/marvell/armada
Current implementation of the USB core does not take into account the
new PHY framework. Correct the situation by adding a call to
phy_set_mode() before phy_power_on().
Signed-off-by: Miquel Raynal
---
drivers/usb/core/hcd.c | 5 +
drivers/usb/core/phy.c | 28
Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY.
Signed-off-by: Miquel Raynal
---
.../bindings/phy/phy-mvebu-utmi.txt | 37 +++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt
diff --git a/Documentation
Update the Armada 3700 PHY drivers entry with the recently added UTMI
PHY driver.
Signed-off-by: Miquel Raynal
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index abfd80f21b24..2a08a097e107 100644
--- a/MAINTAINERS
+++ b
the A3700 SoC in the USB Host Kconfig prompt
(not only in the help section).
* Rebased on top of v5.0-rc1.
Miquel Raynal (9):
usb: core: comply to PHY framework
usb: ehci-orion: avoid double PHY initialization
usb: ehci-orion: add S2RAM support
phy: add A3700 UTMI PHY driver
dt-bindings
the UTMI
PHY node. Section 3/ can be accessed by both the USB controller and
the PHY because of the miscaellaneous nature of the registers inside
so a specific node will be created to cover the area and a handle to
it will be added in both the USB controller and the PHY node.
Signed-off-by: Miquel
nd it.
Co-developed-by: Igal Liberman
Signed-off-by: Miquel Raynal
Signed-off-by: Igal Liberman
---
drivers/phy/marvell/Kconfig| 9 +
drivers/phy/marvell/Makefile | 1 +
drivers/phy/marvell/phy-mvebu-a3700-utmi.c | 297 +
3 files changed, 307
Current implementation of the USB core does not take into account the
new PHY framework. Correct the situation by adding a call to
phy_set_mode() before phy_power_on().
Signed-off-by: Miquel Raynal
---
drivers/usb/core/hcd.c | 5 +
drivers/usb/core/phy.c | 28
t than that, the following phy->power_on() at
resume time will be also skipped, failing the whole S2RAM operation.
Signed-off-by: Miquel Raynal
---
drivers/usb/host/ehci-orion.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/host/
PHY node.
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 26
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 5cfd1b920f31..d87db3d4cc3d 100644
Reference the PHY nodes from the USB controller nodes.
The USB3 host controller is wired to:
* the first PHY of the COMPHY IP
* the OTG-capable UTMI PHY
The USB2 host controller is wired to:
* the host-only UTMI PHY
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada
present
on the A3700 SoC.
Signed-off-by: Ofer Heifetz
[miquel.ray...@bootlin.com: Reword the commit message]
Signed-off-by: Miquel Raynal
---
drivers/usb/host/Kconfig | 4 ++--
drivers/usb/host/xhci-mvebu.c | 11 +++
drivers/usb/host/xhci-mvebu.h | 6 ++
drivers/usb/host/xhci
Add suspend/resume callbacks to reset the host controller properly
during S2RAM operation.
Signed-off-by: Miquel Raynal
---
drivers/usb/host/ehci-orion.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
Hi Rob,
Rob Herring wrote on Tue, 15 Jan 2019 15:44:29 -0600:
> On Fri, Jan 11, 2019 at 02:31:29PM +0100, Miquel Raynal wrote:
> > Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY.
> >
> > Signed-off-by: Miquel Raynal
> > ---
> > .../bindings/phy/
Hi Gregory,
Gregory CLEMENT wrote on Fri, 18 Jan 2019
17:25:30 +0100:
> Hi Miquel,
>
> On ven., janv. 11 2019, Miquel Raynal wrote:
>
> > No need to initialize the PHY from the driver's probe. It is done by
> > the core automatically and doing it twice woul
Hi Sergei,
Sergei Shtylyov wrote on Fri, 11
Jan 2019 21:03:01 +0300:
> Hello!
>
> On 01/11/2019 04:31 PM, Miquel Raynal wrote:
>
> > No need to initialize the PHY from the driver's probe. It is done by
> > the core automatically and doing it twice would incr
Hi Gregory,
Gregory CLEMENT wrote on Fri, 18 Jan 2019
17:36:36 +0100:
> Hi Miquel,
>
> I have only a few smallish remarks:
>
> On ven., janv. 11 2019, Miquel Raynal wrote:
>
> > Marvell Armada 3700 SoC has two USB controllers, each of them being
> > wired
Hi Kishon, Chunfeng,
Kishon Vijay Abraham I wrote on Wed, 16 Jan 2019
14:50:58 +0530:
> Hi,
>
> On 15/01/19 8:10 AM, Chunfeng Yun wrote:
> > Hi,
> > On Fri, 2019-01-11 at 14:31 +0100, Miquel Raynal wrote:
> >> Marvell Armada 3700 SoC has two USB controllers, ea
Hi Gregory,
Gregory CLEMENT wrote on Fri, 18 Jan 2019
17:04:01 +0100:
> Hi Miquel,
>
> On ven., janv. 11 2019, Miquel Raynal wrote:
>
> > From: Ofer Heifetz
> >
> > The mvebu xHCI host driver does not have suspend/resume support. Use of
> > the XHCI_R
e than that, the following phy->power_on() at
resume time will also be skipped, failing the whole S2RAM operation.
Signed-off-by: Miquel Raynal
---
drivers/usb/host/ehci-orion.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/host/
Reference the PHY nodes from the USB controller nodes.
The USB3 host controller is wired to:
* the first PHY of the COMPHY IP
* the OTG-capable UTMI PHY
The USB2 host controller is wired to:
* the host-only UTMI PHY
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada
the A3700 SoC.
* Updates to the OHCI Orion driver to avoid doing the PHY
initialization twice.
* Upgrade of the OHCI Orion driver with S2RAM callbacks.
* Added a reference to the A3700 SoC in the USB Host Kconfig prompt
(not only in the help section).
* Rebased on top of v5.0-rc1.
Miquel Rayna
the UTMI
PHY node. Section 3/ can be accessed by both the USB controller and
the PHY because of the miscaellaneous nature of the registers inside
so a specific node will be created to cover the area and a handle to
it will be added in both the USB controller and the PHY node.
Signed-off-by: Miquel
Update the Armada 3700 PHY drivers entry with the recently added UTMI
PHY driver.
Signed-off-by: Miquel Raynal
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index abfd80f21b24..2a08a097e107 100644
--- a/MAINTAINERS
+++ b
PHY node.
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 5cfd1b920f31..aeb2681428b3 100644
Add suspend/resume callbacks to reset the host controller properly
during S2RAM operation.
Signed-off-by: Miquel Raynal
---
drivers/usb/host/ehci-orion.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
present
on the A3700 SoC.
Signed-off-by: Ofer Heifetz
[miquel.ray...@bootlin.com: Reword the commit message]
Signed-off-by: Miquel Raynal
Reviewed-by: Gregory CLEMENT
---
drivers/usb/host/Kconfig | 4 ++--
drivers/usb/host/xhci-mvebu.c | 11 +++
drivers/usb/host/xhci-mvebu.h | 6
Current implementation of the USB core does not take into account the
new PHY framework. Correct the situation by adding a call to
phy_set_mode() before phy_power_on().
Signed-off-by: Miquel Raynal
---
drivers/usb/core/hcd.c | 5 +
drivers/usb/core/phy.c | 28
nd it.
Co-developed-by: Igal Liberman
Signed-off-by: Miquel Raynal
Signed-off-by: Igal Liberman
---
drivers/phy/marvell/Kconfig| 9 +
drivers/phy/marvell/Makefile | 1 +
drivers/phy/marvell/phy-mvebu-a3700-utmi.c | 278 +
3 files changed, 288
Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY.
Signed-off-by: Miquel Raynal
---
.../bindings/phy/phy-mvebu-utmi.txt | 38 +++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt
diff --git a/Documentation
Hello,
Rob Herring wrote on Tue, 22 Jan 2019 10:08:41 -0600:
> On Mon, Jan 21, 2019 at 9:49 AM Gregory CLEMENT
> wrote:
> >
> > Hi Rob,
> >
> > On lun., janv. 21 2019, Rob Herring wrote:
> >
> > > On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Ra
Hi Thomas,
Thomas Petazzoni wrote on Tue, 22 Jan
2019 18:38:33 +0100:
> Hello,
>
> On Mon, 21 Jan 2019 12:23:32 +0100, Miquel Raynal wrote:
>
> > +- compatible: Should be one of:
> > + * "marvell,a3700-utmi-host-phy" for the PHY connected to
Hi Alan,
Alan Stern wrote on Wed, 23 Jan 2019
14:58:44 -0500 (EST):
> On Mon, 21 Jan 2019, Miquel Raynal wrote:
>
> > Add suspend/resume callbacks to reset the host controller properly
> > during S2RAM operation.
> >
> > Signed-off-by: Miquel Raynal
> > --
present
on the A3700 SoC.
Signed-off-by: Ofer Heifetz
[miquel.ray...@bootlin.com: Reword the commit message]
Signed-off-by: Miquel Raynal
Reviewed-by: Gregory CLEMENT
---
drivers/usb/host/Kconfig | 4 ++--
drivers/usb/host/xhci-mvebu.c | 11 +++
drivers/usb/host/xhci-mvebu.h | 6
Current implementation of the USB core does not take into account the
new PHY framework. Correct the situation by adding a call to
phy_set_mode() before phy_power_on().
Signed-off-by: Miquel Raynal
---
drivers/usb/core/hcd.c | 5 +
drivers/usb/core/phy.c | 28
on twice.
* Upgrade of the OHCI Orion driver with S2RAM callbacks.
* Added a reference to the A3700 SoC in the USB Host Kconfig prompt
(not only in the help section).
* Rebased on top of v5.0-rc1.
Miquel Raynal (9):
usb: core: comply to PHY framework
usb: ehci-orion: avoid double PHY
Add bindings for Marvell Armada 3700 USB2 UTMI+ PHY.
Signed-off-by: Miquel Raynal
Reviewed-by: Rob Herring
---
.../bindings/phy/phy-mvebu-utmi.txt | 38 +++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt
nd it.
Co-developed-by: Igal Liberman
Signed-off-by: Miquel Raynal
Signed-off-by: Igal Liberman
---
drivers/phy/marvell/Kconfig| 9 +
drivers/phy/marvell/Makefile | 1 +
drivers/phy/marvell/phy-mvebu-a3700-utmi.c | 278 +
3 files changed, 288
e than that, the following phy->power_on() at
resume time will also be skipped, failing the whole S2RAM operation.
Signed-off-by: Miquel Raynal
Acked-by: Alan Stern
---
drivers/usb/host/ehci-orion.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git
Update the Armada 3700 PHY drivers entry with the recently added UTMI
PHY driver.
Signed-off-by: Miquel Raynal
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index abfd80f21b24..2a08a097e107 100644
--- a/MAINTAINERS
+++ b
Add suspend/resume callbacks to reset the host controller properly
during S2RAM operation.
Signed-off-by: Miquel Raynal
---
drivers/usb/host/ehci-orion.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index
PHY node.
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 5cfd1b920f31..d2d8ef00c592 100644
the UTMI
PHY node. Section 3/ can be accessed by both the USB controller and
the PHY because of the miscaellaneous nature of the registers inside
so a specific node will be created to cover the area and a handle to
it will be added in both the USB controller and the PHY node.
Signed-off-by: Miquel
Reference the PHY nodes from the USB controller nodes.
The USB3 host controller is wired to:
* the first PHY of the COMPHY IP
* the OTG-capable UTMI PHY
The USB2 host controller is wired to:
* the host-only UTMI PHY
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/marvell/armada
Hi Alan,
Alan Stern wrote on Fri, 25 Jan 2019
21:56:27 -0500 (EST):
> On Fri, 25 Jan 2019, Miquel Raynal wrote:
>
> > Add suspend/resume callbacks to reset the host controller properly
> > during S2RAM operation.
> >
> > Signed-off-by: Miquel Raynal
> > --
Hi Alan,
Alan Stern wrote on Mon, 28 Jan 2019
10:27:53 -0500 (EST):
> On Mon, 28 Jan 2019, Miquel Raynal wrote:
>
> > Hi Alan,
> >
> > Alan Stern wrote on Fri, 25 Jan 2019
> > 21:56:27 -0500 (EST):
> >
> > > On Fri, 25 Jan 2019, Miquel Rayn
e than that, the following phy->power_on() at
resume time will also be skipped, failing the whole S2RAM operation.
Signed-off-by: Miquel Raynal
Acked-by: Alan Stern
---
drivers/usb/host/ehci-orion.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git
doing the PHY
initialization twice.
* Upgrade of the OHCI Orion driver with S2RAM callbacks.
* Added a reference to the A3700 SoC in the USB Host Kconfig prompt
(not only in the help section).
* Rebased on top of v5.0-rc1.
Miquel Raynal (3):
usb: core: comply to PHY framework
usb: ehci-orion:
Add suspend/resume callbacks to reset the host controller properly
during S2RAM operation.
Signed-off-by: Miquel Raynal
Acked-by: Alan Stern
---
drivers/usb/host/ehci-orion.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb
Current implementation of the USB core does not take into account the
new PHY framework. Correct the situation by adding a call to
phy_set_mode() before phy_power_on().
Signed-off-by: Miquel Raynal
---
drivers/usb/core/hcd.c | 5 +
drivers/usb/core/phy.c | 28
present
on the A3700 SoC.
Signed-off-by: Ofer Heifetz
[miquel.ray...@bootlin.com: Reword the commit message]
Signed-off-by: Miquel Raynal
Reviewed-by: Gregory CLEMENT
---
drivers/usb/host/Kconfig | 4 ++--
drivers/usb/host/xhci-mvebu.c | 11 +++
drivers/usb/host/xhci-mvebu.h | 6
Hi Marek,
Marek Behun wrote on Sat, 28 Sep 2019 04:29:50
+0200:
> Hi Miquel,
>
> I am encountering a regression caused by your commit eb6c2eb6c7fb
> "usb: host: xhci-plat: Prevent an abnormally restrictive PHY init
> skipping" [1]
Sorry for the regression.
>
> In the Turris Mox device tree,
61 matches
Mail list logo
