Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-20 Thread Michal Simek
ease correct me if I am wrong. BTW: u-boot started to use SPDX-License-Identifier which will be nice to start to use. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/f

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
o Cc :) > Sundeep with CC devicetree list in next patch version. >>> + /* Map the registers */ >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> + udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start, >>> +

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
if kernel can work without interrupt-parent at all. I expect that it won't work and because we have interrupt parent in every node (which is generated) it is probably required in our setup. As you said it is just trivial detail for me too. Thanks, Michal -- Michal Simek, Ing. (M.Eng),

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
On 02/21/2014 04:42 PM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: >>>>> + /* Map the registers */ >>>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>>> + udc->b

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: >> BTW: u-boot started to use SPDX-License-Identifier >> which will be nice to start to use. > > I agree, feel free to start sending patches to use this typ

Re: SPDX-License-Identifier

2014-02-21 Thread Michal Simek
On 02/21/2014 05:12 PM, Felipe Balbi wrote: > On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: >> On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: >>> On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: >>>> BTW: u-boot started to use SPDX-Lice

Re: SPDX-License-Identifier

2014-02-21 Thread Michal Simek
On 02/21/2014 05:56 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 21, 2014 at 10:20:45AM -0600, Felipe Balbi wrote: >> Hi, >> >> On Fri, Feb 21, 2014 at 05:18:39PM +0100, Michal Simek wrote: >>> On 02/21/2014 05:12 PM, Felipe Balbi wrote: >>>> On Fri, Feb

Re: SPDX-License-Identifier

2014-02-24 Thread Michal Simek
lawyers > may have different opinions about what might happen if the question > was ever to be adjudicated in court. Thanks Ted. Aren't all these points already answered by SPDX project? I believe that they should know how this should be handled properly. Thanks, Michal -- Michal

Re: SPDX-License-Identifier

2014-02-24 Thread Michal Simek
On 02/24/2014 02:41 PM, Theodore Ts'o wrote: > On Mon, Feb 24, 2014 at 11:12:53AM +0100, Michal Simek wrote: >>> But of course, I'm not a lawyer, and if your company has is paying for >>> the development of the driver, the Golden Rule applies (he who has the >>

[PATCH] usb: phy: Add ulpi IDs for SMSC USB3320 and TI TUSB1210

2014-03-11 Thread Michal Simek
Add new ulpi IDs which are available on Xilinx Zynq boards. Signed-off-by: Michal Simek --- http://www.ti.com/lit/ds/symlink/tusb1210.pdf page 29 I don't know why but value is not written in smsc manual here. http://ww1.microchip.com/downloads/en/DeviceDoc/3320.pdf page 62 --- drivers/us

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-03 Thread Michal Simek
think so in connection to my experience with Xilinx soft IPs. Endian detection directly on IP itself came from my discussion on drivers/spi/spi-xilinx.c that this is only one way how to do it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p

Re: [PATCH v2 1/2] usb: doc: udc-xilinx: Add devicetree bindings

2014-04-03 Thread Michal Simek
;0x3>; phandle = <0x3>; }; ps7-scutimer@f8f00600 { clocks = <0x2 0x4>; compatible = "arm,cortex-a9-twd-timer"; interrupt-parent = <0x3>;

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-07 Thread Michal Simek
> /** > * ehci_xilinx_port_handed_over - hand the port out if failed to enable it > Acked-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.mon

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-22 Thread Michal Simek
Hi Alan and Greg, On 09/20/2014 06:19 AM, Chen Gang wrote: > Hello Maintainers: > > Please help check this patch, when you have time. > > Thanks. > > On 09/08/2014 01:20 PM, Michal Simek wrote: >> On 09/03/2014 05:50 PM, Chen Gang wrote: >>> Need includ

Re: [PATCH] usb: gadget: xudc: fix return value check in xudc_probe()

2015-04-16 Thread Michal Simek
s); > - if (!udc->addr) > - return -ENOMEM; > + if (IS_ERR(udc->addr)) > + return PTR_ERR(udc->addr); > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH] usb: gadget: udc-xilinx: compress return logic into one line

2017-07-09 Thread Michal Simek
sb_udc *udc; > - int frame; > > if (!gadget) > return -ENODEV; > > udc = to_udc(gadget); > - frame = udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET); > - return frame; > + > + return udc->read_fn(udc->addr + X