Register MII bus so that a phydev can attach to it. This works in
parallel with the existing MII bus accessors within the driver,
however the existing accessors will be removed in subsequent patch.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Use bit operations provided by bit.h instead of reimplementing them.
No functional change.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb
Replace the function with genphy_update_link(), since that's really
all that it is.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc9
Replace generic_mii_ioctl() with phydev compatible phy_mii_ioctl().
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c | 3 ++-
1 file
The mii_check_media() is called to read out the PHY status registers
and update the internal status reported by mii_ethtool_gset(), just
replace it with phydev compatible phy_read_status().
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc
Just replace smsc95xx_mdio_write() with generic phy_write() to reduce
usage of the ad-hoc accessors.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net
This is in fact genphy_restart_aneg(), just use the generic
phydev function.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c | 5
Just replace smsc95xx_mdio_read() with generic phy_read() to reduce
usage of the ad-hoc accessors.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net
preparation of phydev conversion, where the
code will connect to PHY between those two halves of the reset
function.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
These functions are now equal to smsc95xx_{read,write}_reg(),
deduplicate them.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c | 78
These functions are now equal to smsc95xx_mdio_{read,write}(),
deduplicate them.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c | 30
Inline those functions into smsc95xx_{read,write}_reg() to get
rid of the wrapper.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c
Inline those functions into smsc95xx_mdio_{read,write}() to get
rid of the wrapper.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c
In case reading of PHY register fails in smsc95xx_bind(), the private
data allocated earlier are not free()d. Free them before bailing out.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To
Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
Marek Vasut (19):
usbnet: smsc95xx: Fix memory leak in smsc95xx_bind
usbnet: smsc95xx: Stop propagation of in_pm
usbnet: smsc95xx
The carrier checking code is completely handled by the internal phydev
state machine, remove it.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb
Replace the ad-hoc reimplementation of genphy_soft_reset() and
genphy_config_aneg() with the generic functions.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
breakage. Some of the extra configuration is sorted out by
later patches in this series.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/smsc95xx.c | 29
Replace mii_ethtool_gset() with a phydev compatible function and
update the code to match.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb
} else if (mdix_ctrl == ETH_TP_MDI_AUTO) {
>> -buf = smsc95xx_mdio_read(dev->net, dev->mii.phy_id,
>> +buf = phy_read(pdata->phydev,
>> SPECIAL_CTRL_STS);
>> buf &= ~SPECIAL_CTRL_STS_OVR
On 1/3/19 2:22 PM, Andrew Lunn wrote:
> On Thu, Jan 03, 2019 at 02:10:30AM +0100, Marek Vasut wrote:
>> Add code to detect and connect to PHY. The internal PHY of the SMSC95xx
>> is a regular SMSC LAN8700 and the driver only supports the internal PHY,
>> so just use t
On 1/3/19 2:28 PM, Andrew Lunn wrote:
> On Thu, Jan 03, 2019 at 02:10:33AM +0100, Marek Vasut wrote:
>> Replace the ad-hoc reimplementation of genphy_soft_reset() and
>> genphy_config_aneg() with the generic functions.
>
> phylib will either call the phy driver specif
PHY driver has everything you need,
> then swap the MAC driver to use phylib.
I wonder, if I use the phylib functions instead of the ad-hoc ones in
the MAC driver, is there still a problem with synchronization ?
--
Best regards,
Marek Vasut
On 1/7/19 12:02 PM, Oliver Neukum wrote:
> On Do, 2019-01-03 at 02:10 +0100, Marek Vasut wrote:
>> The information whether the SMSC95xx is in_pm or not can be derived from
>> the usbdev->suspend_count. First thing called in smsc95xx_suspend() is
>> usbnet_suspend(), whi
101 - 124 of 124 matches
Mail list logo
