reg_vbus) {
> ret = regulator_enable(ci->platdata->reg_vbus);
> diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h
> index 7d39967..708bd11 100644
> --- a/include/linux/usb/chipidea.h
> +++ b/include/linux/usb/chipidea.h
> @@ -24,6 +24,7 @@ str
uct of_device_id ci_hdrc_imx_dt_ids[] = {
> - { .compatible = "fsl,imx27-usb", },
> - { /* sentinel */ }
> -};
> -MODULE_DEVICE_TABLE(of, ci_hdrc_imx_dt_ids);
> -
> static struct platform_driver ci_hdrc_imx_driver = {
> .probe = ci_hdrc_imx_prob
t seems to do something on the bus, which triggers an interrupt in
the udc, but the multiplexer in the chipidea core will call the host
role, due to the ID pin.
If the system boot without a cable or with a device type cable (attached
to another host or not doesn't matter), the ID pin stays floa
On 11/14/2013 02:17 PM, Fabio Estevam wrote:
> Hi Marc,
>
> On Thu, Nov 14, 2013 at 10:46 AM, Marc Kleine-Budde
> wrote:
>> Hello,
>>
>> I'm using Greg's linux-usb/next on mx28-evk with mxs-defconfig. I
>> switched on OTG support and ether gadget
it happens only if
>> a host type USB cable is plugged into the OTG port and connected to
>> another machine's host port.
>
> What your otg port looks like? It is a Micro-B-Female port?
> If ID pin is low, it will be considered as host role, when you
> co
Hello,
this series implements the suggested workaround for freescale's imx28 Errata,
"ENGR119653 USB: ARM to USB register error issue".
changes since v4:
- fix signature of imx28_ehci_writel(), don't use volatile, make use of __iomem
- avoid new #ifdef by using if (IS_ENABLED())
Marc
--
To uns
o/?l=linux-usb&m=137996395529294&w=2
Signed-off-by: Peter Chen
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci.h| 26 --
drivers/usb/chipidea/core.c | 2 ++
drivers/usb/chipidea/host.c | 1 +
include/linux/usb/chipidea.h | 1 +
4 files chan
inux-usb&m=137996395529294&w=2
Signed-off-by: Peter Chen
Acked-by: Alan Stern
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/host/ehci.h | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index e316058..e055234 10
From: Peter Chen
Due to imx28 needs ARM swp instruction for writing, we set
CI_HDRC_IMX28_WRITE_FIX for imx28.
Signed-off-by: Peter Chen
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci_hdrc_imx.c | 32 ++--
1 file changed, 26 insertions(+), 6
add stable on Cc for the final
>> patch?
>>
>> Tested on imx28-evk and custom board.
>>
>
> I go to send out a patch for it now.
Thanks, I have posted an inproved version of "ENGR119653 USB: ARM to USB
register error issue" in return :)
Thanks,
Marc
--
Pe
On 11/24/2013 11:57 AM, Peter Chen wrote:
> On Fri, Nov 22, 2013 at 10:53:53AM +0100, Marc Kleine-Budde wrote:
>> Hello,
>>
>> this series implements the suggested workaround for freescale's imx28 Errata,
>> "ENGR119653 USB: ARM to USB register error iss
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
On 11/26/2013 01:44 PM, Marc Kleine-Budde wrote:
> On 11/26/2013 01:11 PM, Peter Chen wrote:
>> Changes for v6:
>> - Add volatile for arm swp instruction, since we need io access
>> to fix this problem
>> - Add kernel style comment for imx28_write_fix
>
> Looks
eter Chens's and my final version of the patch. Can
you please have a look at it?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-512
ost mode due to id = 0. The ehci_irq
> can't handle suspend (USBi_SLI) interrupt which is enabled for
> peripheral mode, it causes no one will handle irq error.
>
> Cc: sta...@vger.kernel.org # 3.12
> Acked-by: Michael Grzeschik
> Reported-by: Marc Kleine-Budde
> Test
gt;>> +
>>> + node = of_parse_phandle(dev->of_node, phandle, 0);
BTW: Is the node freed somewhere?
>>> + if (!node) {
>>> + dev_dbg(dev, "failed to get %s phandle in %s node\n", phandle,
>>> +
@@ static int mxs_phy_probe(struct platform_device *pdev)
>>>
>>> mxs_phy->clk = clk;
>>>
>>> + otg = devm_kzalloc(&pdev->dev, sizeof(struct usb_otg), GFP_KERNEL);
In order to save some overhead you can embed the struct usb_otg in the
+#define PLL_REGM_F_MASK 0x0003
> +#define PLL_REGM_F_SHIFT0x0
> +#define PLL_REGN_MASK 0x01FE
> +#define PLL_REGN_SHIFT 0x1
> +#define PLL_SELFREQDCO_MASK 0x000E
> +#define PLL_SELFREQDCO_SHIFT0x1
> +#define
dev_err(&pdev->dev, "unable to get refclk960m\n");
>> +return PTR_ERR(phy->optclk);
>> +}
>> +clk_prepare(phy->optclk);
>> +}
>
> instead, can't you just always try to
On 09/19/2012 04:42 PM, Felipe Balbi wrote:
> On Wed, Sep 19, 2012 at 04:45:01PM +0200, Marc Kleine-Budde wrote:
>> On 09/19/2012 01:56 PM, Felipe Balbi wrote:
>>> On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote:
>>>> "usb_otg_ss_refclk960
On 09/20/2012 07:06 AM, Olivier Sobrie wrote:
> This driver provides support for several Kvaser CAN/USB devices.
> Such kind of devices supports up to three CAN network interfaces.
>
> It has been tested with a Kvaser USB Leaf Light (one network interface)
> connected to a pch_can interface.
> The
like this would be required for USB support
> on beagle bone (AM335X), which has 2 phy's of same type.
>
> Or is the plan to use generic phy framework instead ?
Yes, Kishon's patches look more generic than mine.
Marc
[2] https://patchwork.kernel.org/patch/1457801/
--
; + .data = (void *)TYPE_S3C64XX,
>> + }, {
>> + .compatible = "samsung,exynos4210-usbphy",
>> + .data = (void *)TYPE_EXYNOS4210,
>> + },
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(of, samsung_
On 09/26/2012 11:20 AM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Mon, Sep 17, 2012 at 3:03 PM, Marc Kleine-Budde
> wrote:
>> On 09/14/2012 03:06 PM, ABRAHAM, KISHON VIJAY wrote:
>>
>> [...]
>>
>>>>> diff --git a/drivers/phy/phy-core.c
ion I suggest to create a struct phy_res. For now
its only member will be a pointer to a struct phy.
>
> ...
>
>>> +
>>> + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL);
>>
>> Is this the right size?
>>
>> Because ptr is
ser binds to mulitple phys.
>
> PHY drivers should create the PHY by passing phy_descriptor that has
> describes the PHY (label, type etc..) and ops like init, exit, suspend,
> resume,
> poweron, shutdown.
>
> Cc: Felipe Balbi
> Cc: Marc Kleine-Budde
> Signed-off-b
never called from here.
> +
> spin_unlock(&ci->lock);
>
I'm not that deep into the OTG stuff to fix it properly.
regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertret
If it's ok with everyone this will go via at91
> with the patch serie than clean up the include/mach
Fine with me.
> For preparation to switch to arm multiarch kernel
Acked-by: Marc Kleine-Budde (for the CAN related changes)
Marc
--
Pengutronix e.K.
On 10/02/2012 09:16 AM, Olivier Sobrie wrote:
> This driver provides support for several Kvaser CAN/USB devices.
> Such kind of devices supports up to three CAN network interfaces.
>
> It has been tested with a Kvaser USB Leaf Light (one network interface)
> connected to a pch_can interface.
> The
On 11/13/2012 02:23 PM, Fabio Estevam wrote:
> Hi Marc,
>
> On Thu, Sep 6, 2012 at 12:18 PM, Marc Kleine-Budde
> wrote:
>> On 09/06/2012 05:15 PM, Richard Zhao wrote:
>>> Hi Marc,
>>>
>>> usbmisc_imx6q.c is only for imx6x. And for a certain runnin
the missing clock handling to the nop phy
driver, which isn't much better. What are other possible options?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund |
On 11/16/2012 11:06 AM, Alexander Shishkin wrote:
> Michael Grzeschik writes:
>
>> From: Marc Kleine-Budde
>>
>> Signed-off-by: Marc Kleine-Budde
>> Signed-off-by: Michael Grzeschik
>
> static yes, __devinitdata -- probably not. These structs are use
obably say: "makes using different
> phys possible", but this is fine too. :)
Granted, but later patches add support for different phy configurations. :D
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-28
y and adds
>> similar helperfunctions.
>>
>> Signed-off-by: Michael Grzeschik
>> Signed-off-by: Marc Kleine-Budde
>> ---
>> drivers/of/Kconfig|4
>> drivers/of/Makefile |1 +
>> drivers/of/of_usbphy.c| 49
>> +++
On 11/16/2012 12:53 PM, Alexander Shishkin wrote:
> Michael Grzeschik writes:
>
>> From: Marc Kleine-Budde
>>
>> Its necessary to limit a hostonly soc to its single role, since
>> debugging has shown that reading on the "CAP_DCCPARAMS" r
On 11/16/2012 02:41 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Nov 16, 2012 at 12:44:19PM +0100, Marc Kleine-Budde wrote:
>>>> diff --git a/drivers/of/of_usbphy.c b/drivers/of/of_usbphy.c
>>>> new file mode 100644
>>>> index 000..2e71f7b
>>
global_phy;
> struct usb_phy *transceiver;
> struct usb_hcd *hcd;
> + /* events handled at ci_role_work */
> +#define ID 0
> +#define B_SESS_VALID 1
Can you add a prefix (like CI_) to these constants?
> +
t; ---
What about your S-o-b?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://
return 0;
> +}
> diff --git a/drivers/usb/chipidea/otg.h b/drivers/usb/chipidea/otg.h
> new file mode 100644
> index 000..b4c6b3e
> --- /dev/null
> +++ b/drivers/usb/chipidea/otg.h
> @@ -0,0 +1,6 @@
> +#ifndef __DRIVERS_USB_CHIPIDEA_OTG_H
> +#define __DRIVERS_USB_CHIPIDEA_
>>> + err = usb_submit_urb(urb, GFP_ATOMIC);
>>> + if (unlikely(err)) {
>>> + can_free_echo_skb(netdev, context->echo_index);
>>> +
skb = NULL; /* +comment */
>>> + atomic_dec(&priv->active_tx_urbs)
On 11/20/2012 02:33 AM, Peter Chen wrote:
> On Mon, Nov 19, 2012 at 05:05:16PM +0100, Marc Kleine-Budde wrote:
>>> +int ci_hdrc_otg_init(struct ci13xxx *ci)
>>> +{
>>> + /* Useless at current */
>>> + ci->otg.set_peripheral = ci_otg_set_peripheral;
On 11/20/2012 02:40 PM, Peter Chen wrote:
> On Tue, Nov 20, 2012 at 12:41:03PM +0100, Marc Kleine-Budde wrote:
>> On 11/20/2012 02:33 AM, Peter Chen wrote:
>>> On Mon, Nov 19, 2012 at 05:05:16PM +0100, Marc Kleine-Budde wrote:
>>>>> +int ci
engutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
we want one kernel image
> to support as many as boards (of cos, DT is different).
>
> Kernel supports all functions, DT choose which one is used.
ACK, but this functionality is already supported by dr_mode.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
I
the driver will be totally unusable.
>
> What I see is patches that bring some parts of udc code in accordance
> with the spec, which is a good thing to do, but doesn't fix any "real
> bugs that bother people". Or does it?
Patch 1/7 is essential to make the udc sta
On 03/27/2013 05:37 PM, Marc Kleine-Budde wrote:
> On 03/27/2013 05:35 PM, Alexander Shishkin wrote:
>> Michael Grzeschik writes:
>>
>>> Hi,
>>>
>>> this series solve some issues with the chipidea udc.
>>>
>>> The series is based on
n arm) or is a byte-shift-or pattern used?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengut
gt;
> Reported-by: Fabio Estevam
> Signed-off-by: Michael Grzeschik
> Signed-off-by: Marc Kleine-Budde
> Signed-off-by: Alexander Shishkin
>
> Conflicts:
> drivers/usb/chipidea/usbmisc_imx.c
You've hopefully resolved the conflict before creating a this patch, s
On 03/30/2013 05:11 PM, Alexander Shishkin wrote:
> Marc Kleine-Budde writes:
>
>> On 03/30/2013 01:46 AM, Alexander Shishkin wrote:
>>> From: Michael Grzeschik
>>>
>>> This driver will be used for every Freescale SoC which has this misc
>>> mem
const u32 *val;
> +
> + val = of_get_property(dev->dev.of_node, name, &len);
> + if (!val)
> + return;
> +
> + if (len != sizeof(*val)) {
> + dev_warn(&dev->dev,
> + "Invalid value in devicetree for %s property, shoul
On 05/09/2013 11:22 PM, Svetoslav Neykov wrote:
> Hi Marc,
>
> Marc Kleine-Budde [mailto:m...@pengutronix.de] (On Thursday, March 28, 2013
> 4:16 PM)
>> On 03/28/2013 10:28 AM, Alexander Shishkin wrote:
>>> Svetoslav Neykov writes:
>>>
>>>> Con
gt; };
>
> +static inline bool is_imx6q_phy(struct mxs_phy *mxs_phy)
> +{
> + return mxs_phy->data == &imx6q_phy_data;
> +}
> +
> +static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)
> +{
> + return mxs_phy->data == &imx6sl_phy_data;
> +}
before? If
so, please squash into the patch. Don't add the broken code in the first
place.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917
n "messy state"?
> + * bus to suspend (set portsc.suspendM) but before setting PHY to low
> + * power mode (set portsc.phcd).
> + */
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertr
t 2/17, and use those two MACROs at this patch.
> Is it your point?
I was wondering if the driver looks more uniform if you use something
like this:
#define MXS_PHY_NEED_IP_FIX BIT(3)
> static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
> {
> int ret;
> @@ -123,6 +
;
> + else
> + writel(0x, x->io_priv + HW_USBPHY_PWD);
> writel(BM_USBPHY_CTRL_CLKGATE,
> x->io_priv + HW_USBPHY_CTRL_SET);
> clk_disable_unprepare(mxs_phy->clk);
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
gt;>
>> Is this also a fix for newly added code? If so please also squash.
> No, it is a workaround for new problem.
If this would be a fix, it's better to put this as first patch into a
series, so that it can be applied to the stable trees easier.
Marc
--
Pengutronix e.K.
ret = ci_role_start(ci, ci->role);
> if (ret) {
> dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924
t;>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -2137,7 +2137,7 @@ S: Maintained
>>>> F:Documentation/zh_CN/
>>>>
>>>> CHIPIDEA USB HIGH SPEED DUAL ROLE CONTROLLER
>>>> -M:Alexander Shishkin
Acked-by: Peter Chen
>>
>> Greg, below is my git tree, please help add it, thanks.
>> T: git://github.com/hzpeterchen/linux-usb.git
>
> Ugh, github, really? I'm not going to pull from a github tree, sorry.
> Can you apply for a kernel.org one?
github can be used
s will
> be there within one week.
The less rebasing the better for any downstream developer.
From my point of view you can already queue the series "reescale imx28
special write register method" and the patch "imx: set
CI_HDRC_IMX28_WRITE_FIX for imx28" for v3.13-rcX.
Marc
--
e have
> git.kernel.org for, which is "authenticated" a bit more than random
> github accounts.
Thanks for the clarification.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertr
ORT_RUNTIME_PM) {
Please squash into the correct patch.
> pdata.flags |= CI_HDRC_SUPPORTS_RUNTIME_PM;
> data->supports_runtime_pm = true;
> }
Marc
--
Pengutronix e.K.
*/
}
after:
if () {
/* code */
}
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www
Without this patch a seperate chunk of memory is allocated for the regmap
array. As the regmap is always used it makes no sense to allocate a seperate
memory block for it, this patch moves the regmap array directly into the struct
hw_bank.
Signed-off-by: Marc Kleine-Budde
---
drivers/usb
This patch makes the controller register map ci_regs_nolpm and ci_regs_lpm as
"const". Further, as all offset fit into a single byte, the type is changed
from uintptr_t to u8.
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/core.c | 80 ++
Hello Peter,
these patches are for your ci-for-usb-next branch. The repmap handling is
streamlined and the kernel shrinks by 706 bytes on i.MX28:
add/remove: 0/0 grow/shrink: 0/30 up/down: 0/-706 (-706)
function old new delta
hw_wait_reg
ound.
>
> We can't guarantee there is no other access on the AHB without disable
> interrupt, would you think below operation will be more efficient than swp,
> or any better solutions?
>
> local_irq_save(flags);
> readl(addr);
> writel(val, addr);
> local_irq_restore(flags);
On 12/06/2013 07:39 AM, Peter Chen wrote:
> On Thu, Dec 05, 2013 at 12:32:55PM +0100, Marc Kleine-Budde wrote:
>> Hello Peter,
>>
>> these patches are for your ci-for-usb-next branch. The repmap handling is
>> streamlined and the kernel shrinks by 706 bytes on i.MX28:
On 12/06/2013 07:45 AM, Peter Chen wrote:
> On Thu, Dec 05, 2013 at 12:32:56PM +0100, Marc Kleine-Budde wrote:
>> Without this patch a seperate chunk of memory is allocated for the regmap
>> array. As the regmap is always used it makes no sense to allocate a seperate
>> memo
On 12/06/2013 07:49 AM, Peter Chen wrote:
> On Thu, Dec 05, 2013 at 12:32:57PM +0100, Marc Kleine-Budde wrote:
>> This patch makes the controller register map ci_regs_nolpm and ci_regs_lpm as
>> "const". Further, as all offset fit into a single byte, the type is change
Hello Peter,
these patches are for your ci-for-usb-next branch. The repmap handling is
streamlined and the kernel shrinks by 706 bytes on i.MX28. Moving the regmap
into hw_bank saves on indirection instruction per register access.
add/remove: 0/0 grow/shrink: 0/30 up/down: 0/-706 (-706)
function
This patch makes the controller register map ci_regs_nolpm and ci_regs_lpm as
"const". Further, as all offset fit into a single byte, the type is changed
from uintptr_t to u8.
Signed-off-by: Marc Kleine-Budde
---
no changes since v1
drivers/usb/chipidea/c
Without this patch a seperate chunk of memory is allocated for the regmap
array. As the regmap is always used it makes no sense to allocate a seperate
memory block for it, this patch moves the regmap array directly into the struct
hw_bank.
Signed-off-by: Marc Kleine-Budde
---
changes since v1
quot;high" : "non-high");
> + dev_dbg(phy->dev, "%s device has connected\n",
> + (speed == USB_SPEED_HIGH) ? "HS" : "FS/LS");
What about creating a mxs_phy_dbg() function that adds the "HS" "FS/LS"
prefix when printing?
Marc
44,9 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
> BM_USBPHY_CTRL_ENUTMILEVEL3,
> base + HW_USBPHY_CTRL_SET);
>
> + if (mxs_phy->data->flags & MXS_PHY_NEED_IP_FIX)
> + writel(BM_USBPHY_IP_FIX, base + HW_USBPHY_IP_SE
an x be NULL?
> + return x->set_wakeup(x, enabled);
> + else
> + return 0;
> +}
> +
> +static inline int
> usb_phy_notify_connect(struct usb_phy *x, enum usb_device_speed speed)
> {
> if (x && x->notify_connect)
>
Marc
--
P
USBPHY_CTRL_SET);
> clk_disable_unprepare(mxs_phy->clk);
> } else {
> + mxs_phy_clock_switch();
> clk_prepare_enable(mxs_phy->clk);
> writel(BM_USBPHY_CTRL_CLKGATE,
> x->io_priv + HW_USBPHY_CTRL_CLR);
>
Ma
ion. So, we implement a special ehci_write
>> for imx28.
>>
>> Discussion for it at below:
>> http://marc.info/?l=linux-usb&m=137996395529294&w=2
>>
>> Signed-off-by: Peter Chen
>> Acked-by: Alan Stern
>> Signed-off-by: Marc K
On 12/09/2013 10:07 AM, Peter Chen wrote:
> On Mon, Dec 09, 2013 at 09:38:17AM +0100, Marc Kleine-Budde wrote:
>> On 12/09/2013 07:30 AM, Peter Chen wrote:
>>> Some PHY bugs are fixed by IC logic, but these bits are not
>>> enabled by default, so we enable them at d
On 12/09/2013 10:19 AM, Peter Chen wrote:
> On Mon, Dec 09, 2013 at 10:05:17AM +0100, Marc Kleine-Budde wrote:
>> On 12/09/2013 07:31 AM, Peter Chen wrote:
>>> After clear portsc.phcd, PHY needs 200us stable time for switch
>>> 32K clock to AHB clock.
>>
>> I
8.
>
> Discussion for it at below:
> http://marc.info/?l=linux-usb&m=137996395529294&w=2
>
> Signed-off-by: Peter Chen
> Acked-by: Alan Stern
> Signed-off-by: Marc Kleine-Budde
> Tested-by: Marc Kleine-Budde
please add stable on Cc for this and the next tw
ion. So, we implement a special ehci_write
>> for imx28.
>>
>> Discussion for it at below:
>> http://marc.info/?l=linux-usb&m=137996395529294&w=2
>>
>> Signed-off-by: Peter Chen
>> Acked-by: Alan Stern
>> Signed-off-by: Marc K
On 01/09/2014 04:22 AM, Greg KH wrote:
> On Thu, Jan 09, 2014 at 09:36:09AM +0800, Peter Chen wrote:
>> On Tue, Jan 07, 2014 at 04:20:25PM -0800, Greg KH wrote:
>>> On Mon, Jan 06, 2014 at 09:42:26AM +0100, Marc Kleine-Budde wrote:
>>>> Hello Peter and Greg,
>>&
ruct ci_otg_fsm_timer *a_wait_vrise_tmr, *a_wait_vfall_tmr,
> *a_wait_bcon_tmr,
> + *a_aidl_bdis_tmr, *a_bidl_adis_tmr, *b_ase0_brst_tmr,
> + *b_se0_srp_tmr, *b_srp_fail_tmr, *b_data_pulse_tmr;
IIRC the USB spec says there is only one OTG port per machi
On 01/10/2014 03:08 AM, Peter Chen wrote:
> On Thu, Jan 09, 2014 at 02:45:24PM +0100, Marc Kleine-Budde wrote:
>> On 01/08/2014 10:06 AM, Li Jun wrote:
>>> Add OTG HNP and SRP operation functions implementation:
>>> - charge vbus
>>> - drive vbus
>&g
n 3 and 4? If not, please re-arrange
the series. As this is a bug fix, patches 1, 2 and 4 will go via
net/master, 3 will go via net-next/master.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/D
On 01/12/2015 11:14 AM, Ahmed S. Darwish wrote:
> On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote:
>> On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote:
>>> From: Ahmed S. Darwish
>>>
>>> (This is a draft patch, I'm not sure if this f
ent versions.
> imx23/imx28 are the first version, more improvements are at
> later SoCs (like imx6x) version. Keep "fsl,imx23-usbphy" at
> imx6 dts will be user know it is from imx23's. If you think
> it does not need, I can delete "fsl,imx23-usbphy" from
/chipidea. It's maintained by Peter Chen (Cc'ed)
and is in better shape than the freescale driver.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +
t; +}
> +
> +static void imx_disable_unprepare_clks(struct device *dev)
> +{
> + struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
> +
> + if (data->need_three_clks) {
> + clk_disable_unprepare(data->clk_per);
> + clk_disable_unprepare(data->clk_ipg);
> + clk_disable_unprepare(data->clk_ahb);
nit: you enable in this order: ipg, ahb, per. Disabling should be inverse.
> + } else {
> + clk_disable_unprepare(data->clk);
> + }
> +}
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_le16 degrades
> to integer
> drivers/net/can/usb/kvaser_usb.c:1332:31: warning: restricted __le16 degrades
> to integer
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortm
n a 10-second
> window, leave the port permanently powered-off. (But then how would we
> recover?)
>
> On the other hand, how often do people encounter overcurrent
> situations? If the hardware is working properly, not very often.
>
> I'm open to suggestions...
One o
201 - 293 of 293 matches
Mail list logo
