ontext->data_len;
>
> /* prevent tx timeout */
> - netdev->trans_start = jiffies;
> + netif_trans_update(netdev);
> break;
>
> default:
> @@ -373,7 +373,7 @@ static netdev_tx_t peak_usb_ndo_start_xmit(struct sk_buff
R_USB_TSEG2_MIN,
> + .tseg2_max = KVASER_USB_TSEG2_MAX,
> + .sjw_max = KVASER_USB_SJW_MAX,
> + .brp_min = KVASER_USB_BRP_MIN,
> + .brp_max = KVASER_USB_BRP_MAX,
> + .brp_inc = KVASER_USB_BRP_INC,
> +};
I'm adding the consts while applying the patch.
Thank
it
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=32ec4576c3fb37316b1d11a04b220527822f3f0d
>
> Yes, that is all that is needed.
Thanks Greg. Olivier, you can post an incremental patch, I'll squash it
before sending the patches upstream.
regards,
M
On 11/23/2012 06:36 AM, Peter Chen wrote:
> On Wed, Nov 21, 2012 at 03:06:29PM +0100, Michael Grzeschik wrote:
>> From: Marc Kleine-Budde
>>
>> This fixes a potential race condition where the ci13xxx_imx glue code
>> could be fast enough to call one of the usbmisc_o
d-off-by: Michael Grzeschik
>> Signed-off-by: Marc Kleine-Budde
>> ---
>> Changes since v2:
>> * added defines for register offsets and bitmasks
>> * fixed disable_oc option for all ports
>>
>> drivers/usb/chipidea/usbmisc_imx.c | 51
>> +
msg = kmalloc(sizeof(*msg), GFP_KERNEL);
>> + if (!msg)
>> +return -ENOMEM;
>> +
>
> Doh! I removed by mistake the line "msg->id = msg_id"... grr
Please send a v2 version of this patch with this problem fixed.
MarcMarc
--
Pengutronix e.K.
into the original patch and pushed to
linux-can-next/for-davem
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HR
gt; +u32 version;
> +char buf[18];
> +struct usb_device *usbdev = interface_to_usbdev(intf);
> +
> +/* product id looks strange, better we also check iProdukt string */
> +if (usb_string(usbdev, usbdev->descriptor.iProduct, buf,
> + sizeof(buf)) &g
something here.
>
> The function usb_8dev_send_cmd copies the data to dev->cmd_msg_buffer
> (allocated with kzalloc, GFP_KERNEL).
Okay, then you might want to set outmsg via C99 initializers.
>>> +
>>> +/* BRP */
>>> +bebrp = cpu_to_be16((u16) bt->br
sions are printed when the
>>> device is probed.
>>
>> Systemadministrators often use versions for configuration scripts.
>> If you insist I will remove.
>
> Marc?
Are these values exported via lsusb -v (e.g. iSerial)?
Marc
--
Pengutronix e.K. |
M;
> +u32 version;
> +char buf[18];
where does this 18 come from?
> +struct usb_device *usbdev = interface_to_usbdev(intf);
> +
> +/* product id looks strange, better we also check iProdukt string */
iProduct?
> +if (usb_string(usbdev, usbdev->descriptor.iProduct, buf,
sion of
> drivers/net/can/usb/ems_usb.c
> + * and drivers/net/can/usb/esd_usb2.c
> + *
> + * Many thanks to Gerhard Bertelsmann (i...@gerhard-bertelsmann.de)
> + * for testing and fixing this driver. Also many thanks to "8 devices",
> + * who were very cooperative and
On 12/04/2012 11:11 PM, Marc Kleine-Budde wrote:
> On 12/04/2012 11:43 PM, Bernd Krumboeck wrote:
btw: your clock is wrong by about 1h :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2
> conjunction with the two lines below ( ..[1] ..[2] )
>
> The semantic has to be understood by humans ;-)
I think Wolfgang was talking about the round bracket not the square
bracket. :D
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux
_stats *stats = &netdev->stats;
> +struct can_frame *cf = (struct can_frame *) skb->data;
> +struct usb_8dev_tx_msg *msg;
> +struct urb *urb;
> +struct usb_8dev_tx_urb_context *context = NULL;
Marc
--
Pengutronix e.K. | Marc Kle
>>> +dev->netdev = netdev;
>>> +
>>> +dev->can.state = CAN_STATE_STOPPED;
>>> +dev->can.clock.freq = USB_8DEV_ABP_CLOCK;
>>> +dev->can.bittiming_const = &usb_8dev_bittiming_const;
>>> +dev->can.do_set_mode =
ct usb_device *usbdev = interface_to_usbdev(intf);
> +
> + /* product id looks strange, better we also check iProduct string */
> + if (usb_string(usbdev, usbdev->descriptor.iProduct, buf,
> +sizeof(buf)) > 0 && strcmp(buf, "USB2CAN converter")) {
> + dev_info(&usbdev->dev, "ignoring: not an USB2CAN converter\n");
> + return -ENODEV;
> + }
> +
> + netdev = alloc_candev(sizeof(struct usb_8dev_priv), MAX_TX_URBS);
> + if (!netdev) {
> + dev_err(&intf->dev, "Couldn't alloc candev\n");
> + return -ENOMEM;
> + }
> +
> + priv = netdev_priv(netdev);
> +
> + priv->udev = usbdev;
> + priv->netdev = netdev;
> +
> + priv->can.state = CAN_STATE_STOPPED;
> + priv->can.clock.freq = USB_8DEV_ABP_CLOCK;
> + priv->can.bittiming_const = &usb_8dev_bittiming_const;
> + priv->can.do_set_mode = usb_8dev_set_mode;
> + priv->can.do_get_berr_counter = usb_8dev_get_berr_counter;
> + priv->can.ctrlmode_supported = CAN_CTRLMODE_LOOPBACK |
> + CAN_CTRLMODE_LISTENONLY |
> + CAN_CTRLMODE_ONE_SHOT;
> +
> + netdev->netdev_ops = &usb_8dev_netdev_ops;
> +
> + netdev->flags |= IFF_ECHO; /* we support local echo */
> +
> + init_usb_anchor(&priv->rx_submitted);
> +
> + init_usb_anchor(&priv->tx_submitted);
> + atomic_set(&priv->active_tx_urbs, 0);
> +
> + for (i = 0; i < MAX_TX_URBS; i++)
> + priv->tx_contexts[i].echo_index = MAX_TX_URBS;
> +
> + priv->cmd_msg_buffer = kzalloc(sizeof(struct usb_8dev_cmd_msg),
> + GFP_KERNEL);
> + if (!priv->cmd_msg_buffer) {
> + netdev_err(netdev, "Couldn't alloc Tx buffer\n");
> + goto cleanup_candev;
> + }
> +
> + usb_set_intfdata(intf, priv);
> +
> + SET_NETDEV_DEV(netdev, &intf->dev);
> +
> + mutex_init(&priv->usb_8dev_cmd_lock);
> +
> + err = register_candev(netdev);
> + if (err) {
> + netdev_err(netdev,
> + "couldn't register CAN device: %d\n", err);
> + goto cleanup_cmd_msg_buffer;
> + }
> +
> + err = usb_8dev_cmd_version(priv, &version);
> + if (err) {
> + netdev_err(netdev, "can't get firmware version\n");
> + goto cleanup_cmd_msg_buffer;
> + } else {
> + netdev_info(netdev,
> + "firmware: %d.%d, hardware: %d.%d\n",
> + (version>>24) & 0xff, (version>>16) & 0xff,
> + (version>>8) & 0xff, version & 0xff);
> + }
> +
> + if (device_create_file(&intf->dev, &dev_attr_firmware))
> + netdev_err(netdev,
> + "Couldn't create device file for firmware\n");
> +
> + if (device_create_file(&intf->dev, &dev_attr_hardware))
> + netdev_err(netdev,
> + "Couldn't create device file for hardware\n");
> +
> + return 0;
> +
> +cleanup_cmd_msg_buffer:
> + kfree(priv->cmd_msg_buffer);
> +
> +cleanup_candev:
> + free_candev(netdev);
> +
> + return err;
> +
> +}
> +
> +/* Called by the usb core when driver is unloaded or device is removed */
> +static void usb_8dev_disconnect(struct usb_interface *intf)
> +{
> + struct usb_8dev_priv *priv = usb_get_intfdata(intf);
> +
> + device_remove_file(&intf->dev, &dev_attr_firmware);
> + device_remove_file(&intf->dev, &dev_attr_hardware);
> +
> + usb_set_intfdata(intf, NULL);
> +
> + if (priv) {
> + netdev_info(priv->netdev, "device disconnected\n");
> +
> + unregister_netdev(priv->netdev);
> + free_candev(priv->netdev);
> +
> + unlink_all_urbs(priv);
> + }
> +
> +}
> +
> +static struct usb_driver usb_8dev_driver = {
> + .name = "usb_8dev",
> + .probe =usb_8dev_probe,
> + .disconnect = usb_8dev_disconnect,
> + .id_table = usb_8dev_table,
> +};
> +
> +module_usb_driver(usb_8dev_driver);
> +
> +MODULE_AUTHOR("Bernd Krumboeck ");
> +MODULE_DESCRIPTION("CAN driver for 8 devices USB2CAN interfaces");
> +MODULE_LICENSE("GPL v2");
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
e_to_usbdev(intf);
> +
> + /* product id looks strange, better we also check iProduct string */
> + if (usb_string(usbdev, usbdev->descriptor.iProduct, buf,
> +sizeof(buf)) > 0 && strcmp(buf, "USB2CAN converter")) {
> + dev_info(&usbdev->dev, "ignoring: not an USB2CAN converter\n");
> + return -ENODEV;
> + }
> +
> + netdev = alloc_candev(sizeof(struct usb_8dev_priv), MAX_TX_URBS);
> + if (!netdev) {
> + dev_err(&intf->dev, "Couldn't alloc candev\n");
> + return -ENOMEM;
> + }
> +
> + priv = netdev_priv(netdev);
> +
> + priv->udev = usbdev;
> + priv->netdev = netdev;
> +
> + priv->can.state = CAN_STATE_STOPPED;
> + priv->can.clock.freq = USB_8DEV_ABP_CLOCK;
> + priv->can.bittiming_const = &usb_8dev_bittiming_const;
> + priv->can.do_set_mode = usb_8dev_set_mode;
> + priv->can.do_get_berr_counter = usb_8dev_get_berr_counter;
> + priv->can.ctrlmode_supported = CAN_CTRLMODE_LOOPBACK |
> + CAN_CTRLMODE_LISTENONLY |
> + CAN_CTRLMODE_ONE_SHOT;
> +
> + netdev->netdev_ops = &usb_8dev_netdev_ops;
> +
> + netdev->flags |= IFF_ECHO; /* we support local echo */
> +
> + init_usb_anchor(&priv->rx_submitted);
> +
> + init_usb_anchor(&priv->tx_submitted);
> + atomic_set(&priv->active_tx_urbs, 0);
> +
> + for (i = 0; i < MAX_TX_URBS; i++)
> + priv->tx_contexts[i].echo_index = MAX_TX_URBS;
> +
> + priv->cmd_msg_buffer = kzalloc(sizeof(struct usb_8dev_cmd_msg),
> + GFP_KERNEL);
> + if (!priv->cmd_msg_buffer) {
> + netdev_err(netdev, "Couldn't alloc Tx buffer\n");
> + goto cleanup_candev;
> + }
> +
> + usb_set_intfdata(intf, priv);
> +
> + SET_NETDEV_DEV(netdev, &intf->dev);
> +
> + mutex_init(&priv->usb_8dev_cmd_lock);
> +
> + err = register_candev(netdev);
> + if (err) {
> + netdev_err(netdev,
> + "couldn't register CAN device: %d\n", err);
> + goto cleanup_cmd_msg_buffer;
> + }
> +
> + err = usb_8dev_cmd_version(priv, &version);
> + if (err) {
> + netdev_err(netdev, "can't get firmware version\n");
> + goto cleanup_cmd_msg_buffer;
> + } else {
> + netdev_info(netdev,
> + "firmware: %d.%d, hardware: %d.%d\n",
> + (version>>24) & 0xff, (version>>16) & 0xff,
> + (version>>8) & 0xff, version & 0xff);
> + }
> +
> + if (device_create_file(&intf->dev, &dev_attr_firmware))
> + netdev_err(netdev,
> + "Couldn't create device file for firmware\n");
> +
> + if (device_create_file(&intf->dev, &dev_attr_hardware))
> + netdev_err(netdev,
> + "Couldn't create device file for hardware\n");
> +
> + return 0;
> +
> +cleanup_cmd_msg_buffer:
> + kfree(priv->cmd_msg_buffer);
> +
> +cleanup_candev:
> + free_candev(netdev);
> +
> + return err;
> +
> +}
> +
> +/* Called by the usb core when driver is unloaded or device is removed */
> +static void usb_8dev_disconnect(struct usb_interface *intf)
> +{
> + struct usb_8dev_priv *priv = usb_get_intfdata(intf);
> +
> + device_remove_file(&intf->dev, &dev_attr_firmware);
> + device_remove_file(&intf->dev, &dev_attr_hardware);
> +
> + usb_set_intfdata(intf, NULL);
> +
> + if (priv) {
> + netdev_info(priv->netdev, "device disconnected\n");
> +
> + unregister_netdev(priv->netdev);
> + free_candev(priv->netdev);
> +
> + unlink_all_urbs(priv);
> + }
> +
> +}
> +
> +static struct usb_driver usb_8dev_driver = {
> + .name = "usb_8dev",
> + .probe =usb_8dev_probe,
> + .disconnect = usb_8dev_disconnect,
> + .id_table = usb_8dev_table,
> +};
> +
> +module_usb_driver(usb_8dev_driver);
> +
> +MODULE_AUTHOR("Bernd Krumboeck ");
> +MODULE_DESCRIPTION("CAN driver for 8 devices USB2CAN interfaces");
> +MODULE_LICENSE("GPL v2");
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
our device fits best.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
eck
Thx. Fabio, can you queue this patch your tree and include it in your
series when you send the next iteration?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax:
On 12/18/2012 03:18 PM, Fabio Baltieri wrote:
> On Tue, Dec 18, 2012 at 03:05:12PM +0100, Marc Kleine-Budde wrote:
>> On 12/17/2012 10:19 PM, Bernd Krumboeck wrote:
>>> Add support for canbus activity led indicators on usb_8dev devices by
>>> calling appropriate can_l
driver_data = IMX51_UDC,
>> +}
>> +};
>
> I wonder if your driver-data is actually needed since you can use string
> comparisson to achieve the exact same outcome.
Why use a string compare, if the kernel infrastructure already does this
for you?
Marc
--
Pengutro
On 01/14/2013 11:24 AM, Felipe Balbi wrote:
> On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote:
>> On 01/14/2013 11:16 AM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote:
>>>> @@ -2
On 01/14/2013 11:39 AM, Felipe Balbi wrote:
> On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote:
>> On 01/14/2013 11:24 AM, Felipe Balbi wrote:
>>> On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote:
>>>> On 01/14/2013 11:16 AM
On 01/14/2013 11:53 AM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote:
>> On 01/14/2013 11:39 AM, Felipe Balbi wrote:
>>> On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote:
>>>> On 01/14/2013 11
same is unnecessary.
>
> b) you can't be expecting to add future SoCs support to fsl udc, I have
> already said and will repeat for the last time: move to chipidea ASAP.
>
> New SoCs cannot be added to fsl udc, you *must* use chipidea for
> anything new and move th
> [ 1343.875366] usb_8dev 2-1.4:1.0 can2: sending command message failed
> [ 1343.875371] usb_8dev 2-1.4:1.0 can2: couldn't stop device
>
>
> Tomorrow i will do some more testing.
>
> The LED handling of the device is really fine:
>
> - interface down -> red
>
On 01/15/2013 09:30 PM, Oliver Hartkopp wrote:
> On 15.01.2013 21:23, Marc Kleine-Budde wrote:
>
>> On 01/14/2013 09:59 PM, Oliver Hartkopp wrote:
>
>
>>
>> What do you suggest? Add the driver or fix the errors first?
>
>
> Hm.
>
> We're cu
off-by: Bernd Krumboeck
> Acked-by: Wolfgang Grandegger
> Tested-by: Oliver Hartkopp
Thanks for you patience :) Applied to can-next.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung W
On 01/22/2013 10:34 PM, Marc Kleine-Budde wrote:
> On 01/19/2013 07:30 AM, Bernd Krumboeck wrote:
>> Add device driver for USB2CAN interface from "8 devices"
>> (http://www.8devices.com).
>>
>> changes since v10:
>> * small cleanups
>>
>>
cially compared to the
> probability devicetree creators pick the wrong number.
>
> It also removes the (probably implicit) rule that the enum mustn't be
> modified since it is exported to users.
>
> Also, you could map the strings to the enum first and then switch-case
> o
> the devicetree.
>>
>> Signed-off-by: Michael Grzeschik
>> Signed-off-by: Marc Kleine-Budde
>> ---
>>
>> The properties and their values have been taken from the fsl-mph-dr driver.
>> This binding is also documented (though currently not used) for the
uct device *dev, struct usb_phy *x);
> +extern int usb_bind_phy(const char *dev_name, u8 index,
> + const char *phy_dev_name);
> #else
> static inline struct usb_phy *usb_get_phy(enum usb_phy_type type)
> {
> @@ -171,6 +188,11 @@ static inline void devm_usb
et_phy_dev().
Further the missing module_put() is added to usb_put_phy().
Signed-off-by: Marc Kleine-Budde
---
Hello,
this patch applies to Greg's usb-next tree. I hope the module counter is now
consistent.
Marc
drivers/usb/otg/otg.c | 10 +++---
1 file changed, 7 insertions(+), 3 del
On 02/01/2013 10:48 PM, Marc Kleine-Budde wrote:
> In patch "5d3c28b usb: otg: add device tree support to otg library"
> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
> phy driver in memory. The corresponding module_put() is missing in that pat
usb_phy *phy = NULL;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&phy_lock, flags);
> +
> + phy = __usb_find_phy_dev(dev, &phy_bind_list, index);
> + if (IS_ERR(phy)) {
You should probably lock the phy module in memory. See my patch "usb:
otg:
On 02/04/2013 02:59 PM, Roger Quadros wrote:
> On 02/04/2013 03:24 PM, Sascha Hauer wrote:
>> From: Marc Kleine-Budde
>>
>> In patch "5d3c28b usb: otg: add device tree support to otg library"
>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get(
> Removed now unused stack variables.
> Removed unnecessary parentheses.
> Neatened alignment.
>
> Signed-off-by: Joe Perches
> ---
> Let me know if you want multiple small patches instead.
>
> drivers/net/can/usb/ems_usb.c | 4 +-
For ems_us
cetree.
>>
>> Signed-off-by: Michael Grzeschik
>> Signed-off-by: Marc Kleine-Budde
>> Signed-off-by: Sascha Hauer
>> ---
>> drivers/usb/phy/Makefile |1 +
>> drivers/usb/phy/of.c | 47
>> ++
On 02/14/2013 10:58 AM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Feb 14, 2013 at 10:49:44AM +0100, Marc Kleine-Budde wrote:
>>>> diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c
>>>> index d29503e..ad4d87d 100644
>>>> --- a/drivers/usb/usb
it's good if he has a vision
>> how things should be lined out.
>>
>> In practice, there is little difference between a 'bus_type' and a 'class',
>> so just replace any instance of the former with the latter in your head
>> when reading the code
On 02/25/2013 05:54 PM, Felipe Balbi wrote:
>> Hello,
>>
>> this patch got lost somehow, it applies to current linus/master (pre
>> v3.9-rc1).
>> Please apply.
>
> I'll take it once v3.9-rc1 is tagged, thanks
tnx,
Marc
--
Pengutronix
ter's patches to current linus/master, see
this tree :
http://git.pengutronix.de/?p=mgr/linux.git;a=shortlog;h=refs/heads/chipidea-for-v3.10
The tree includes my patch we resent yesterday, as Sascha's series
depends on this.
Marc
--
Pengutronix e.K. | Marc Kleine-Bu
On 02/26/2013 02:25 PM, Alexander Shishkin wrote:
> Marc Kleine-Budde writes:
>
>> On 02/26/2013 11:56 AM, Alexander Shishkin wrote:
>>> Peter Chen writes:
>>>
>>>> Hi Alex,
>>>
>>> Hi,
>>>
>>>> Do we have a chipid
http://git.pengutronix.de/?p=mgr/linux.git;a=shortlog;h=refs/heads/chipidea-for-v3.10
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-
ce. You _do_ realize, however,
>>> that Greg has already closed all his trees for v3.9, right ? So anything
>>> from now on will be queued for v3.10.
>>
>> I'm fine with that. I'm just a bit insistent because the chipidea patches are
>> floating around for ha
the phy can be addressed as hardware implementation is designed.
>>
>> Signed-off-by: Michael Grzeschik
>> Signed-off-by: Marc Kleine-Budde
>> Signed-off-by: Sascha Hauer
>> ---
>> .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++
>> dri
_MODE_PERIPHERAL) {
>
> Can we change "USB_DR_MODE_PERIPHERAL" to "USB_DR_MODE_GADGET", since we
> always
> use gadget to stands for device or peripheral mode at code (like below
> CI_ROLE_GADGET), it may make code uniform.
Peripheral mode seems to be the more of
From: Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the
host/peripheral/otg mode. This is necessary for boards without proper
ID pin handling.
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
Documentation/devicetree
From: Michael Grzeschik
This patch removes the limitation of having only one instance of the
ci13xxx-imx platformdata and makes different configurations possible.
Reviewed-by: Peter Chen
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
Vijay Abraham I
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci13xxx_imx.c | 38
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/chipidea/ci13xxx_imx.c
b/drive
Signed-off-by: Marc Kleine-Budde
---
.../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++
drivers/usb/chipidea/bits.h| 14 ++-
drivers/usb/chipidea/ci13xxx_imx.c |3 ++
drivers/usb/chipidea/core.c| 39
From: Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework
to be able to find the phy from the USB driver.
Reviewed-by: Kishon Vijay Abraham I
Reviewed-by: Peter Chen
Acked-by: Felipe Balbi
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
From: Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows
to explicitly set the core to host/peripheral mode. Without these
flags the driver falls back to the old behaviour.
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea
et_phy_dev().
Further the missing module_put() is added to usb_put_phy().
Reviewed-by: Kishon Vijay Abraham I
Acked-by: Felipe Balbi
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/otg/otg.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
di
From: Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it
to the phy directory.
Cc: Felipe Balbi
Reported-by: Kishon Vijay Abraham I
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/otg/otg.c| 427
dr_mode and phy_type property and makes
use of them in the chipidea driver.
--------
Marc Kleine-Budde (1):
USB otg: use try_module_get in all usb_get_phy functions and add missing
module_put
Michael Grzeschik (3):
USB: add de
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the dr_mode
(host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
devicetree.
Cc: Felipe Balbi
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine
On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote:
> From: Sascha Hauer
>
> Most of otg/otg.c is not otg specific, but phy specific, so move it
> to the phy directory.
>
> Cc: Felipe Balbi
> Reported-by: Kishon Vijay Abraham I
> Signed-off-by: Sascha Hauer
> Signe
On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote:
> From: Michael Grzeschik
>
> This adds two little devicetree helper functions for determining the dr_mode
> (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
> devicetree.
>
> Cc: Felipe Balbi
>
On 02/27/2013 01:32 PM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote:
>> From: Michael Grzeschik
>>
>> This adds two little devicetree helper functions for determining the dr_mode
>
> it looks to me that "mode" is e
On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
>> In patch "5d3c28b usb: otg: add device tree support to otg library"
>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
>
On 02/27/2013 01:43 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
>> On 02/27/2013 01:31 PM, Felipe Balbi wrote:
>>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
>>>> In patch "
On 02/27/2013 01:47 PM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote:
>> On 02/27/2013 01:43 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
>>>
ainer needs to handle hundreds of emails
> a week (if not a day) and if patches are properly split and cleanly
> mention if it's a bugfix or not, things will go wrong.
That was just a proposal. You'll find these series in your inbox in a
few minutes.
Marc
--
Pengutronix e.K.
et_phy_dev().
Further the missing module_put() is added to usb_put_phy().
Reviewed-by: Kishon Vijay Abraham I
Acked-by: Felipe Balbi
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/otg/otg.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
di
t() is added to usb_put_phy()
--------
Marc Kleine-Budde (1):
USB otg: use try_module_get in all usb_get_phy functions and add missing
module_put
drivers/usb/otg/otg.c | 10 +++---
1 file changed, 7 insertions(+), 3 delet
Hello,
this series depends on the bugfix patch "USB otg: use try_module_get in all
usb_get_phy functions and add missing module_put" (a.k.a tags/otg-for-v3.9-v1)
posted earlier and is inteded for v3.10. It separates the phy from the otg code
and adds DT helper functions. Further mxs-phy uses the n
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the dr_mode
(host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
devicetree.
Cc: Felipe Balbi
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine
From: Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it
to the phy directory.
Cc: Felipe Balbi
Reported-by: Kishon Vijay Abraham I
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/otg/otg.c| 427
From: Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework
to be able to find the phy from the USB driver.
Reviewed-by: Kishon Vijay Abraham I
Reviewed-by: Peter Chen
Acked-by: Felipe Balbi
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde
---
.../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++
drivers/usb/chipidea/bits.h| 14 ++-
drivers/usb/chipidea/ci13xxx_imx.c |3 ++
drivers/usb/chipidea/core.c| 39
From: Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the
host/peripheral/otg mode. This is necessary for boards without proper
ID pin handling.
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
Documentation/devicetree
Hello,
this series depends on the series "[PATCH 0/3] otg-for-v3.10-v1: separate phy
code and add DT helper" (a.k.a. tags/otg-for-v3.10-v1) posted earlier and is
intended for v3.10. The chipidea driver is converted to make use of the DT
helper functions.
regards,
Marc
The following changes sinc
From: Michael Grzeschik
This patch removes the limitation of having only one instance of the
ci13xxx-imx platformdata and makes different configurations possible.
Reviewed-by: Peter Chen
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
Vijay Abraham I
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci13xxx_imx.c | 38
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/chipidea/ci13xxx_imx.c
b/drive
From: Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows
to explicitly set the core to host/peripheral mode. Without these
flags the driver falls back to the old behaviour.
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea
On 02/27/2013 02:55 PM, Marc Kleine-Budde wrote:
> On 02/27/2013 02:42 PM, Felipe Balbi wrote:
>>> That'll be these 3 branches then:
>>>
>>> otg-for-v3.9 (bugfix for v3.9):
>>> 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add
On 02/27/2013 05:21 PM, Greg KH wrote:
> On Wed, Feb 27, 2013 at 03:11:13PM +0100, Marc Kleine-Budde wrote:
>> In patch "5d3c28b usb: otg: add device tree support to otg library"
>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
>
On 02/28/2013 09:01 AM, Felipe Balbi wrote:
> hi,
>
> On Wed, Feb 27, 2013 at 03:16:30PM +0100, Marc Kleine-Budde wrote:
>> From: Sascha Hauer
>>
>> We now have usb_add_phy_dev(), so use it to register with the framework
>> to be able to find the phy from
On 02/28/2013 08:57 AM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 03:16:29PM +0100, Marc Kleine-Budde wrote:
>> From: Michael Grzeschik
>>
>> This adds two little devicetree helper functions for determining the dr_mode
>> (host, peripheral, otg, dual-role) and phy
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the dr_mode
(host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
devicetree.
Cc: Felipe Balbi
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine
From: Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework
to be able to find the phy from the USB driver.
Reviewed-by: Kishon Vijay Abraham I
Reviewed-by: Peter Chen
Acked-by: Felipe Balbi
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
to the plain readl(), writel() functions, which are available on all platforms.
This is done to enable compile time testing on non ARM platforms.
Reported-by: Alexander Shishkin
Signed-off-by: Marc Kleine-Budde
From: Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it
to the phy directory.
Cc: Felipe Balbi
Reported-by: Kishon Vijay Abraham I
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/otg/otg.c| 427
11:36:45 +0100)
USB otg, phy: separate phy and add DT helper
Move phy related code into separate file and add device tree helper functions.
--------
Marc Kleine-Budde (1):
USB mxs-phy: use readl(), writel() instead of the _rel
On 02/28/2013 10:40 AM, Alexander Shishkin wrote:
> Marc Kleine-Budde writes:
>
>> On 02/28/2013 09:01 AM, Felipe Balbi wrote:
>>> hi,
>>>
>>> On Wed, Feb 27, 2013 at 03:16:30PM +0100, Marc Kleine-Budde wrote:
>>>> From: Sascha Hauer
&g
Hello,
this series depends on the series "[PATCH 0/3] otg-for-v3.10-v2: separate phy
code and add DT helper" (a.k.a. tags/otg-for-v3.10-v2) posted earlier and is
intended for v3.10. The chipidea driver is converted to make use of the DT
helper functions.
No changes since v1, just rebased to otg-f
Vijay Abraham I
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci13xxx_imx.c | 38
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/chipidea/ci13xxx_imx.c
b/drive
From: Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the
host/peripheral/otg mode. This is necessary for boards without proper
ID pin handling.
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
Documentation/devicetree
From: Michael Grzeschik
This patch removes the limitation of having only one instance of the
ci13xxx-imx platformdata and makes different configurations possible.
Reviewed-by: Peter Chen
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde
---
.../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++
drivers/usb/chipidea/bits.h| 14 ++-
drivers/usb/chipidea/ci13xxx_imx.c |3 ++
drivers/usb/chipidea/core.c| 39
From: Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows
to explicitly set the core to host/peripheral mode. Without these
flags the driver falls back to the old behaviour.
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea
On 02/28/2013 12:16 PM, Alexander Shishkin wrote:
> Peter Chen writes:
>
>> On Tue, Feb 26, 2013 at 02:47:34PM +0100, Marc Kleine-Budde wrote:
>>> On 02/26/2013 02:25 PM, Alexander Shishkin wrote:
>>>> Marc Kleine-Budde writes:
>>>>
>>&
e:
> +
> + hsusb1_phy {
> + compatible = "usb-nop-xceiv";
> + clock-frequency = <1920>;
Why do you hardcode the clock frequency here? You should use
clk_get_rate() to get the frequency from the clock tree.
Marc
--
Pengutronix e.K.
On 03/08/2013 11:46 AM, Marc Kleine-Budde wrote:
> On 02/04/2013 04:58 PM, Roger Quadros wrote:
>> The PHY clock, clock rate, VCC regulator and RESET regulator
>> can now be provided via device tree.
>>
>> Signed-off-by: Roger Quadros
>> ---
>> .../de
On 02/28/2013 12:25 PM, Alexander Shishkin wrote:
> Marc Kleine-Budde writes:
>
>> This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
>> to the plain readl(), writel() functions, which are available on all
>> platforms.
>> This is done
On 03/08/2013 05:28 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Mar 08, 2013 at 05:05:58PM +0100, Marc Kleine-Budde wrote:
>> On 02/28/2013 12:25 PM, Alexander Shishkin wrote:
>>> Marc Kleine-Budde writes:
>>>
>>>> This patch converts the mxs-phy driv
On 03/08/2013 05:33 PM, Felipe Balbi wrote:
> On Thu, Feb 28, 2013 at 11:57:04AM +0100, Marc Kleine-Budde wrote:
>> @@ -147,19 +146,20 @@ static int ci13xxx_imx_probe(struct platform_device
>> *pdev)
>> return ret;
>> }
>>
>> -phy_
On 03/08/2013 05:46 PM, Alexander Shishkin wrote:
> On 8 March 2013 18:33, Felipe Balbi wrote:
>> Hi,
>>
>> On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote:
>>> @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev)
&g
1 - 100 of 293 matches
Mail list logo
