Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread Linus Walleij
t can be merged orthogonally to all the other patches, but I don't understand the patch or if it is correct. Hongzhou/Yingjoe, can either of you review this patch? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-24 Thread Linus Walleij
On Thu, May 12, 2016 at 4:55 AM, Hongzhou Yang wrote: > We find there are some other pins still have the same problem, so please > hold on it. Sorry for so much noise. It's OK. Get me a big patch fixing it all when you're combed through things and we can apply it for fixes/stabl

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-21 Thread Linus Walleij
On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij wrote: > From: Haipeng YU > > When a device is switched off by software, gserial_cleanup will > be called, and switch off will be blocked in this function > because wake_up_interruptible() in gs_close() can not wake_up > t

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-25 Thread Linus Walleij
the .inf file. > > Note that everything in the .inf gets stored in the registry. > Noone looks at the .inf again, once the driver has been installed. OK got it. >> So I could mimic this by starting to cache away any >> successfully initiated MTP devices in some /var/libmtp

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-27 Thread Linus Walleij
On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij wrote: > On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij > wrote: > >> From: Haipeng YU >> >> When a device is switched off by software, gserial_cleanup will >> be called, and switch off will be bl

Re: [PATCH] usb: gadget: fix switch off blocked in u_serial

2012-12-12 Thread Linus Walleij
On Tue, Nov 27, 2012 at 3:11 PM, Linus Walleij wrote: > On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij > wrote: >> On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij >> wrote: >> >>> From: Haipeng YU >>> >>> When a device is switched off by softw

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-10 Thread Linus Walleij
altieri Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Linus Walleij
On Thu, Jan 10, 2013 at 2:38 PM, Fabio Baltieri wrote: > On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote: >> On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri >> wrote: >> >> > This patch converts the module to use clk_prepare_enable and >> > clk

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-04 Thread Linus Walleij
; + + if (priv->gc.label) + gpiochip_remove(&priv->gc); +} Should not be needed with the devm_* call above doing garbage collection. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-10 Thread Linus Walleij
d acceptable? I'm pretty sure it's OK, I just want you to consider and think these things over. Your conclusion is as good as mine. I suspect I will just ACK your patch when you have it working. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v7 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-12 Thread Linus Walleij
> - Adding limited .set_single_ended() and direction support. > - Simplifying attach() and removing release() as it's no longer required. >From a GPIO point of view: Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscr

Re: [balbi-usb:testing/next 57/84] drivers/usb/dwc3/dwc3-st.c:328:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state'

2016-10-21 Thread Linus Walleij
t;>> 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration] >> pinctrl_pm_select_default_state(dev); >> ^~~ >>cc1: some warnings being treated as errors > > looks like a bug in . Something along the

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-25 Thread Linus Walleij
special function to name the lines from drivers like this that hang off a pluggable bus. Johan/Martyn what is your idea? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-26 Thread Linus Walleij
On Wed, Oct 26, 2016 at 11:09 AM, Johan Hovold wrote: > On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote: >> I was thinking on either reusing the .names field of the >> struct gpiochip to name the lines for the userspace >> chardev. With the sideeffect of the na

Re: [PATCH] usb: musb: ux500: Fix NULL pointer dereference at system PM

2016-01-28 Thread Linus Walleij
sb: musb: fail with error when no DMA...") > Signed-off-by: Ulf Hansson Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH v5 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-08-11 Thread Linus Walleij
input mode, though the state of the GPIO can be read > when used in open-drain mode. Like with pin use, the mode is configured in > the one-time programable PROM and can't be changed at runtime. > > Signed-off-by: Martyn Welch > Acked-by: Linus Walleij Still stands. > V2:

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-03-15 Thread Linus Walleij
and SuperSuperMegaUltraOrtonSpeed USB I wonder... or will we change the bindings again? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-03-15 Thread Linus Walleij
the pinctrl patches to me after v4.6-rc1 with the apropriate ACKs (hoping they will appear). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] pinctrl: Intel: add RX invertion config

2016-03-19 Thread Linus Walleij
On Wed, Mar 16, 2016 at 2:34 PM, Daniel Vetter wrote: > On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote: >> - What is a HPD interrupt? > > hotplug interrupt, fires when you plug in a cable. > >> - What is a Type-C DP HPD? > > usb type C connector can

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-22 Thread Linus Walleij
tree separately if possible, I encourage any DTS changes to go in orthogonally through ARM SoC. The DTS business I regard as kind of its own tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ke

Re: [PATCH v5 1/2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-03-31 Thread Linus Walleij
input mode, though the state of the GPIO can be read > when used in open-drain mode. Like with pin use, the mode is configured in > the one-time programable PROM and can't be changed at runtime. > > Signed-off-by: Martyn Welch Looking good from a GPIO point of view. Acked-by: Lin

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-04-18 Thread Linus Walleij
On Mon, Apr 18, 2016 at 1:12 PM, Thierry Reding wrote: > On Tue, Mar 15, 2016 at 10:01:25AM +0100, Linus Walleij wrote: >> On Fri, Mar 4, 2016 at 5:19 PM, Thierry Reding >> wrote: >> >> > From: Thierry Reding >> > >> > This is an old vers

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-26 Thread Linus Walleij
your Acked-by on > the binding apply to this part as well? Sure Acked-by: Linus Walleij Sorry for missing to reply to this, have been swamped. Basically I trust anything that you and Stephen agree on. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing

2017-02-10 Thread Linus Walleij
On Thu, Feb 9, 2017 at 3:20 PM, Hans Ulli Kroll wrote: > Add device tree probe for fotg2 driver > > v2: > fix in wrong MODULE_DEVICE_TABLE > > Signed-off-by: Hans Ulli Kroll Acked-by: Linus Walleij > + /* Right now device-tree probed devices don't get dma_ma

Re: [PATCH 3/3] DT: add Faraday Tec. as vendor

2017-02-10 Thread Linus Walleij
On Wed, Feb 8, 2017 at 9:00 PM, Hans Ulli Kroll wrote: > add Faraday Technology Corporation as vendor faraday for DT > > Signed-off-by: Hans Ulli Kroll Reviewed-by: Linus Walleij I think I should use this for the PCI block as well, looking over some code and the root hub is using

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

2017-02-10 Thread Linus Walleij
On Wed, Feb 8, 2017 at 9:00 PM, Hans Ulli Kroll wrote: > This adds DT bindings for the Faraday FOTG2 host controller. > > Signed-off-by: Hans Ulli Kroll Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb&quo

Re: [PATCH 0/3] usb: add device tree support for fotg2-hcd driver

2017-02-10 Thread Linus Walleij
abled"; and gemini-nas4220b.dts mainly just setting status = "okay"; I can merge this on top of the rest of the stuff in my tree that should go upstream to ARM SoC. Yours. Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH 3/3] DT: add Faraday Tec. as vendor

2017-02-12 Thread Linus Walleij
ick this patch directly to the DT tree so we need not worry about the vendor thing? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1] usb: dwc3: pci: Switch to devm_acpi_dev_add_driver_gpios()

2017-03-23 Thread Linus Walleij
see the cause of a potential issue. > > Signed-off-by: Andy Shevchenko > --- > > Linus, according to preliminary agreement with Felipe it may go through > GPIO subsystem instead of pulling from it. Patch applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe f

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

2017-03-29 Thread Linus Walleij
user choice and > shouldn't be part of DT. The latter should be implied by an SoC > specific compatible string. Using only a compatible string for a > licensed IP is not specific enough as vendors use differing versions > and integrate them in different ways. Hans can you add: co

Re: [rtc-linux] [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-08 Thread Linus Walleij
+ vt8500_chip->regoff); val = (u8) readl(...); usw > + val |= (1 << offset); Use val |= BIT(offset); Apart from these remarks it's looking good... Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [rtc-linux] [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-08 Thread Linus Walleij
rove readability a lot: /** * struct vt8500_gpio_bank_regoffsets * @en: offset to enable register in the bank * ... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [rtc-linux] [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-22 Thread Linus Walleij
t8500_chip->regs->en); BTW: have you considered [readl|writel]_relaxed? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [rtc-linux] [PATCHv4 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-23 Thread Linus Walleij
u32 to match register size. > > Signed-off-by: Tony Prisk Sweet! Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [rtc-linux] RE: [PATCHv4 0/9] *** ARM: Update arch-vt8500 to Devicetree ***

2012-08-23 Thread Linus Walleij
On Thu, Aug 23, 2012 at 2:58 PM, Tony Prisk wrote: > Linus W has provided some feedback on the gpio driver - I missed the > issues he raised the first time around so just waiting for him to take a look > at v4 when he's got time. Reviewed and OK:ed, looking good now. Yours, Linus

Re: [PATCH] usb: gadget: Add Interface Association Descriptor to ECM

2012-09-07 Thread Linus Walleij
On Fri, Sep 7, 2012 at 8:51 PM, Sebastian Andrzej Siewior wrote: > On Wed, Jan 25, 2012 at 11:02:03AM +0100, Linus Walleij wrote: >> static struct usb_descriptor_header *ecm_fs_function[] = { >> /* CDC ECM control descriptors */ >> + (struct

Re: [PATCH 05/39] ARM: ux500: Stop passing MMC's platform data for Device Tree boots

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 11:15 AM, Lee Jones wrote: > On Wed, 15 May 2013, Linus Walleij wrote: > >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > It was required to pass DMA channel configuration information to the >> > MMC driver before the new

Re: [PATCH 06/39] ARM: ux500: Move SDI (MMC) and UART devices under more descriptive heading

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 11:17 AM, Lee Jones wrote: > On Wed, 15 May 2013, Linus Walleij wrote: > >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > Now DMA DT bindings exist and are in use by he MMC and UART drivers, it >> > should be possible to re

Re: [Ksummit-2013-discuss] Topic: where should the border between userspace and kernel be?

2013-07-16 Thread Linus Walleij
onference this year.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: musb: name ux500 platforms more broadly

2013-09-06 Thread Linus Walleij
The Kconfig help text is talking about the U5500 which is no longer supported by the kernel. Name the help text after the config symbol which is more correct. Signed-off-by: Linus Walleij --- drivers/usb/musb/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] usb: gadget: fix pxa25x compilation problems

2013-11-18 Thread Linus Walleij
to compile. Fix this up by explicitly including the necessary header. Reported-by: Russell King Signed-off-by: Linus Walleij --- drivers/usb/gadget/pxa25x_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c index 0a

autodetect USB MTP device characteristics without libusb_open()

2012-11-05 Thread Linus Walleij
ok_closer = 0; dir = opendir(sysfspath); if (!dir) return -1; strcpy(dirbuf, sysfspath); dirbuf[len++] = '/'; /* Check for dirs that identify interfaces */ ret = regcomp(&r, "^[0-9]+-[0-9]+\\:[0-9]+\\.[0-9]+$", REG_EXTENDED | REG_NOSUB); if (ret) return -1;

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-06 Thread Linus Walleij
On Mon, Nov 5, 2012 at 11:31 PM, Bjørn Mork wrote: > Linus Walleij writes: > Excuse my lack of knowlegde here, but I have to ask why that is? > > I looked briefly at the MTP v1.1 spec from So all MTP devices manufactured before that spec, and numerous produced after that spec c

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-07 Thread Linus Walleij
On Wed, Nov 7, 2012 at 12:28 AM, Bjørn Mork wrote: > Linus Walleij writes: >> So all MTP devices manufactured before that spec, and numerous produced >> after that spec came out, and several still being produced don't use the >> class code, i.e. they violate the

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-07 Thread Linus Walleij
. But really, I need to see the debug log, and > usbmon output from when this happens would certainly also be nice. So we're not just doing this but also retieveing the descriptor, looping over configs, interfaces, and checking the number of endpoints. At this point if the endpoints !=

[PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-14 Thread Linus Walleij
wait_event(). Signed-off-by: Haipeng YU Signed-off-by: Linus Walleij --- drivers/usb/gadget/u_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c index f173952..2d074ba 100644 --- a/drivers/usb/gadget/u_serial.c +++ b

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-20 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:38 PM, Bjørn Mork wrote: > Linus Walleij writes: >> One of them is an MTP interface, and will respond to MTP traffic. >> I think the magic OS handshake make that come into play... >> So Linux erroneously tries to use MSC on it,

Re: [PATCH 01/10] usb: musb: ux500: move channel number knowledge into the driver

2013-04-25 Thread Linus Walleij
er.kernel.org > Signed-off-by: Lee Jones Looks good to me. Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/10] usb: musb: ux500: move the MUSB HDRC configuration into the driver

2013-04-25 Thread Linus Walleij
oting with either ATAGs or Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...

Re: [PATCH 03/10] usb: musb: ux500: take the dma_mask from coherent_dma_mask

2013-04-25 Thread Linus Walleij
driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones And makes it way more readable too! Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH 04/10 v2] usb: musb: ux500: harden checks for platform data

2013-04-25 Thread Linus Walleij
are present prior to using them. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: [PATCH 05/10 v2] usb: musb: ux500: attempt to find channels by name before using pdata

2013-04-25 Thread Linus Walleij
towards this. The next step will be to enable Device Tree > complete with name<->event_line mapping. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones Looking good, would be nice if Arnd checked it tho. Acked-by: Linus Walleij Yours, Linus Wa

Re: [PATCH 06/10 v2] usb: musb: ux500: add device tree probing support

2013-04-25 Thread Linus Walleij
> Signed-off-by: Lee Jones This patch needs to be CC: devicetree-discuss. But looks good to me! Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH 01/39] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-05-15 Thread Linus Walleij
500-dma40 branch. This lacks an ACK from Vinod... I cannot get any of this stack of patches up to ARM SoC before I have Vinod's ACK on all hitting drivers/dma/* Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message t

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-15 Thread Linus Walleij
ed-off-by: Lee Jones You forgot to update the commit message, but I saw that you fixed what I asked for so I just went in and edited the commit message and applied it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messa

Re: [PATCH 03/39] dmaengine: ste_dma40: Don't configure runtime configurable setup during allocate

2013-05-15 Thread Linus Walleij
t I amended it. Besides, when I amend commit messages I make sure I really understand what is going on so no big deal... > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones I still need Vinod's ACK on this before I send it anywh

Re: [PATCH 04/39] ARM: ux500: Stop passing UART's platform data for Device Tree boots

2013-05-15 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > It was required to pass DMA channel configuration information to the > UART driver before the new DMA API was in place. Now that it is, and > is fully compatible with Device Tree we can stop doing that. > > Reviewed-by: Linus Wa

Re: [PATCH 05/39] ARM: ux500: Stop passing MMC's platform data for Device Tree boots

2013-05-15 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > It was required to pass DMA channel configuration information to the > MMC driver before the new DMA API was in place. Now that it is, and > is fully compatible with Device Tree we can stop doing that. > > Reviewed-by: Linus Wa

Re: [PATCH 07/39] dmaengine: ste_dma40: Only use addresses passed as configuration information

2013-05-15 Thread Linus Walleij
levates a large burden from platform data in the way of a look-up > table. > > Signed-off-by: Lee Jones This should be the case even without patch 5 & 6 so patch tentatively applied. Waiting for Vinod's ACK on this though. Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH 08/39] dmaengine: ste_dma40: Remove redundant address fetching function

2013-05-15 Thread Linus Walleij
for Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/39] ARM: ux500: Move SDI (MMC) and UART devices under more descriptive heading

2013-05-15 Thread Linus Walleij
) call to do device name matching, which will fail due to the > fact that Device Tree naming differs somewhat do the more traditional > conventions. > > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Cannot be applied due to dependency on 5/39. Yours, Linus Walleij -- To unsub

Re: [PATCH 09/39] ARM: ux500: Remove DMA address look-up table

2013-05-15 Thread Linus Walleij
fit in well using Device Tree either. > > Signed-off-by: Lee Jones Good riddance. Patch tentatively applied. Awaiting Vinod's ACK for include/platform_data/*. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mes

Re: [PATCH 10/39] dmaengine: ste_dma40: Correct copy/paste error

2013-05-15 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > 'struct stedma40_half_channel_info's header comment says that it's > called 'struct stedma40_chan_cfg'. Let's straighten that out. > > Signed-off-by: Lee Jones Patch tentatively applied waiting fo

Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it

2013-05-15 Thread Linus Walleij
crypto tree? Else please convince Herbert to give his ACK on this before I apply it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/39] crypto: ux500/hash - Set DMA configuration though dma_slave_config()

2013-05-15 Thread Linus Walleij
Vinod's ACK for the previous patches I can send an initial pull request on that and then follow up with the rest. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/39] crypto: ux500/cryp - Prepare clock before enabling it

2013-05-15 Thread Linus Walleij
l.org > Acked-by: Ulf Hansson > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones This patch also looks like -rc series stuff for the crypto tree. BTW: these two clk_prepare_enable() patches are Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the l

Re: [PATCH 11/39] ARM: ux500: Remove unnecessary attributes from DMA channel request pdata

2013-05-15 Thread Linus Walleij
information are subsequently ignored by the driver, so we may > as well remove them. > > Signed-off-by: Lee Jones Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-15 Thread Linus Walleij
will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones I guess this stuff is dependent on the stuff Fabio has recently sent to Felipe f

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-16 Thread Linus Walleij
On Wed, May 15, 2013 at 10:14 PM, Fabio Baltieri wrote: > On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote: >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > For all ux500 based platforms the maximum number of end-points are used. >> > Mo

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-20 Thread Linus Walleij
: Vinod Koul >> > > That needs up update! >> > >> > Ah, where did I get that from that? >> > >> > Was that my mistake, or was this in the MAINTAINERS file? >> Certainly not in MAINTAINERS file :) > > My bad then, sorry. > > Linus,

Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it

2013-05-20 Thread Linus Walleij
.org > Acked-by: Arnd Bergmann > Acked-by: Ulf Hansson > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Herbert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...

Re: [PATCH 13/39] crypto: ux500/hash - Set DMA configuration though dma_slave_config()

2013-05-20 Thread Linus Walleij
ig() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-cry...@vger.kernel.org > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Herbert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: s

Re: [PATCH 14/39] ARM: ux500: Stop passing Hash DMA channel config information though pdata

2013-05-20 Thread Linus Walleij
ch applied now that the deps are in! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/39] crypto: ux500/cryp - Prepare clock before enabling it

2013-05-20 Thread Linus Walleij
l.org > Acked-by: Ulf Hansson > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applied with Herbert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-05-20 Thread Linus Walleij
ig() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-cry...@vger.kernel.org > Acked-by: Arnd Bergmann > Acked-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied with Herbert's ACK. Thanks, Linus Walleij -- To unsubscribe from t

Re: [PATCH 18/39] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog

2013-05-20 Thread Linus Walleij
; Cc: Andreas Westin > Cc: linux-cry...@vger.kernel.org > Acked-by: Arnd Bergmann > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied with Herbert's ACK. Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH 19/39] ARM: ux500: Register Cyrp and Hash platform drivers on Snowball

2013-05-20 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > These drivers are now operational and even use the latest common clk > and DMA APIs. There's no reason why we shouldn't start them up now. > > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-20 Thread Linus Walleij
will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones I have now gone over and collected ACKs etc for the patches up until here. No

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-29 Thread Linus Walleij
On Tue, May 28, 2013 at 6:27 PM, Felipe Balbi wrote: > On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote: >> I can't merge any of this without Felipes ACKs in any >> case. > > Do you want to take this yourself ? I haven't fully read the series yet, &

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Linus Walleij
will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Felipe's ACK. Thanks! Linus Walle

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Linus Walleij
tform data. This also removes quite a bit of complexity from the driver >> and will aid us when we come to enable the driver for Device Tree. >> >> Cc: Felipe Balbi >> Cc: linux-usb@vger.kernel.org >> Acked-by: Linus Walleij >> Acked-by: Fabio Baltieri >>

Re: [PATCH 21/39] usb: musb: ux500: move the MUSB HDRC configuration into the driver

2013-05-30 Thread Linus Walleij
oting with either ATAGs or Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 22/39] usb: musb: ux500: take the dma_mask from coherent_dma_mask

2013-05-30 Thread Linus Walleij
driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 23/39] usb: musb: ux500: harden checks for platform data

2013-05-30 Thread Linus Walleij
are present prior to using them. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH 24/39] usb: musb: ux500: attempt to find channels by name before using pdata

2013-05-30 Thread Linus Walleij
step towards this. The next step will be to enable Device Tree > complete with name<->event_line mapping. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Fe

Re: [PATCH 25/39] usb: musb: ux500: add device tree probing support

2013-05-30 Thread Linus Walleij
org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones Tentatively applied with Felipe's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH 26/39] ARM: ux500: Add an auxdata entry for MUSB for clock-name look-up

2013-05-30 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > The recently DT:ed MUSB driver will require clock-name by device-name > look-up capability, until common clk has is properly supported by the > ux500 platform. > > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Sig

Re: [PATCH 27/39] ARM: ux500: Remove ux500-musb platform registation when booting with DT

2013-05-30 Thread Linus Walleij
the musb stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 28/39] ARM: ux500: Remove empty function u8500_of_init_devices()

2013-05-30 Thread Linus Walleij
h. And this is looking real good now! Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 29/39] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s

2013-05-30 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > The aim is to make the code that little more readable. > > Acked-by: Vinod Koul > Acked-by: Arnd Bergmann > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Patch applied to my ux500-dma40 branch. Yours, L

Re: [PATCH 30/39] ARM: ux500: Replace ST-E's home-brew DMA direction definition with the generic one

2013-05-30 Thread Linus Walleij
ng your ACK on this patch, but have tentatively queued it anyway. Maybe you missed it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 31/39] dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones

2013-05-30 Thread Linus Walleij
c: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied to my dma40 branch with Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 32/39] ARM: ux500: Remove recently unused stedma40_xfer_dir enums

2013-05-30 Thread Linus Walleij
s, but it seems it was implicitly ACKed in the discussion on patch 31. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 33/39] dmaengine: ste_dma40_ll: Use the BIT macro to replace ugly '(1 << x)'s

2013-05-30 Thread Linus Walleij
On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > The aim is to make the code that little more readable. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied with Vinod's ACK. Yours, Linus Wall

Re: [PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value

2013-05-30 Thread Linus Walleij
_width (in Bytes) value. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied with what I interpret as Vinod's ACK ("okay..." statement on last reply.) Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 35/39] dmaengine: ste_dma40_ll: Replace meaningless register set with comment

2013-05-30 Thread Linus Walleij
gt; Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Tentatively applied. Missing Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 36/39] dmaengine: ste_dma40: Allow memcpy channels to be configured from DT

2013-05-30 Thread Linus Walleij
e will need to be tailored. Fortunately, these platforms will be DT > only, so this change has very little impact on platform data. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applie

Re: [PATCH 37/39] ARM: ux500: Stop passing DMA platform data though AUXDATA

2013-05-30 Thread Linus Walleij
nflict with all the AUXDATA changes in the devicetree branch. Oh well, I'll figure it out... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 38/39] dmaengine: ste_dma40: Fetch the number of physical channels from DT

2013-05-30 Thread Linus Walleij
so we may as well add the infrastructure. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Patch applied with Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 39/39] dmaengine: ste_dma40: Fetch disabled channels from DT

2013-05-30 Thread Linus Walleij
ely, so we may as well add the infrastructure. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Patch applied with Vinod's ACK. Yours, Linus Walleij -- To unsubscribe from this list: s

  1   2   >