[PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-22 Thread Kurt Garloff
keep me in copy for the discussion, my participation on LKML is mostly reading summaries from Jonathan and Thorsten these days, unfortunately. -- Kurt Garloff Cologne, Germany commit bc1e4e1ae1d5a4f9b2d263f22c651dd5ba4f8ff9 Author: Kurt Garloff Date: Sun Sep 22 11:54:59 2013 +0200 From

Re: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-22 Thread Kurt Garloff
Hi Alan, thanks for your review and your constructive comments! Alan Stern schrieb: >On Sun, 22 Sep 2013, Kurt Garloff wrote: > >> Hi, >> >> USB devio rejects control messages when the index does not have the >> direction bit set correctly. > >I wouldn&

Re: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-23 Thread Kurt Garloff
Hi Alan, On 09/23/2013 04:28 AM, Alan Stern wrote: > On Sun, 22 Sep 2013, Kurt Garloff wrote: > >> Well, this seems to be a question of terminology, no? >> I saw the endpoint byte as consisting of endpoint index plus the direction >> bit. > See the entry for &quo

Re: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-23 Thread Kurt Garloff
Hi Alan, Alan Stern schrieb: > On Mon, 23 Sep 2013, Kurt Garloff wrote: > > > >> that qualifies as a bug or not. Maybe it should not claim to be a > > >> HID device then? > > > Maybe not. This particular combination of bRequestType and > bRequest &

[PATCH] usb/core/devio.c: Don't reject control message to endpoint with wrong direction bit

2013-09-24 Thread Kurt Garloff
Hi, this has been discussed on linux-usb and Alan Stern provided very helpful feedback. Please merge this patch ... From: Kurt Garloff Date: Mon, 23 Sep 2013 14:19:02 +0200 Subject: Tolerate wrong direction bit in endpoint address for control messages Trying to read data from the Pegasus