Kukjin Kim wrote:
>
Re-sending due to e-mail client problem...
> Doug Anderson wrote:
> >
> > On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam
> > wrote:
> > > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam
> > wrote:
> > >>
> > >&g
Vivek Gautam wrote:
>
> Adding support to parse device node data in order to get
> required properties to set pmu isolation for usb-phy.
>
> Signed-off-by: Vivek Gautam
> Reviewed-by: Sylwester Nawrocki
> Reviewed-by: Doug Anderson
This looks good to me,
Acked-by: Kukj
Felipe Balbi wrote:
>
> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > > This patch-set enables the samsung-usbphy driver on exynos5250,
> > > which enables the support for USB2 type and USB3 type phys
+--
> include/linux/usb/samsung_usb_phy.h| 16 +
> 6 files changed, 635 insertions(+), 73 deletions(-)
> create mode 100644 include/linux/usb/samsung_usb_phy.h
>
> --
> 1.7.6.5
Looks good to me,
Felipe and Greg, I don't know who s
Sylwester Nawrocki wrote:
>
> On 12/24/2012 09:13 AM, Vivek Gautam wrote:
> These two changes look good to me. For both of them:
>
> Reviewed-by: Doug Anderson
> >>>
> >>> Well, I have another idea. Yes, I know, specific chip name should be
used.
> >> But
> >>> you know the specifi
Felipe Balbi wrote:
> Hi,
>
Hi Felipe,
[...]
> > Right, DWC has version number, but that being the kind of USB controller
> > (USB 2.0 and USB 3.0)
> >
> > DWC2: USB High Speed controller (as also indicated in the patch from
> > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver)
> > DWC3: USB
'm fine on this series, I'm still thinking we need to sort out the
chip name in compatible for IP though.
Felipe, please go ahead, if you want my ack, feel free to add:
Acked-by: Kukjin Kim
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-
Vivek Gautam wrote:
>
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 15 +++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dt
Vivek Gautam wrote:
>
> Adding usb3.0 phy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 +
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/
Vivek Gautam wrote:
>
> Moving register and structure definitions to header file,
> and keeping the generic functions to be used across
> multiple PHYs in common file "samsung-usbphy.c".
> Also renaming the usb 2.0 phy driver to "samsung-usb2.c"
Just in my opinion, Samsung-usb2phy is more clear?.
Vivek Gautam wrote:
>
> Adding PHY driver support for USB 3.0 controller for Samsung's
> SoCs.
>
> Signed-off-by: Vivek Gautam
> ---
>
> Changes from v3:
> - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY.
> - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since
>dwc3 controller a
Vivek Gautam wrote:
>
> Hi Tomasz,
>
>
> On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam
> wrote:
> > Hi Tomasz,
> >
> >
> > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa
> wrote:
> >> Hi Vivek,
> >>
> >> Don't you need also some clkdev lookup entry to make the clock
available
> >> in the driver?
Tomasz Figa wrote:
>
> Hi Vivek,
[...]
> > + usb@1212 {
> > + compatible = "samsung,exynos4210-ohci";
> > + reg = <0x1212 0x100>;
> > + interrupts = <0 71 0>;
>
> For Samsung platforms we decided per board enabling of nodes and so this
> node should also
Vivek Gautam wrote:
>
> Adding EHCI device tree node for Exynos5250 along with
> the device base adress and gpio line for vbus.
>
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> Acked-by: Grant Likely
> ---
>
> Changes from v4:
> - Added gpio line for VBUS of USB2.0 on snow board.
>
amsung stuff. In addition,
the isolation hook function also can be put in this by using platform_data
or dt parsing.
> code.This driver is tested with smdk6410 and Exynos4210(with DT).
>
I and my colleague, Yulgon will comment on this series soon.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senio
On 06/06/13 08:57, Tomasz Figa wrote:
This series is an attempt to move clock support on Samsung S3C64xx SoCs
to Common Clock Framework.
Looks good :)
First, support for PLL types present on S3C64xx SoCs is added to Samsung
Common Clock Framework driver. Then the main clock driver for mention
On 06/13/13 06:38, Tomasz Figa wrote:
[...]
Another thing is that it's unlikely for any new SoC from S3C64xx
series to show up, so basically the clock list is fixed.
Sure. I can take this into clk-next along with patch #1, or if you
prefer:
Acked-by: Mike Turquette
Thanks.
IMHO with all
Tomasz Figa wrote:
>
> This series is an attempt to move clock support on Samsung S3C64xx SoCs
> to Common Clock Framework.
>
> First, support for PLL types present on S3C64xx SoCs is added to Samsung
> Common Clock Framework driver. Then the main clock driver for mentioned
> SoCs is introduced.
On 07/23/13 08:49, Tomasz Figa wrote:
This series is an attempt to move clock support on Samsung S3C64xx SoCs
to Common Clock Framework.
First, support for PLL types present on S3C64xx SoCs is added to Samsung
Common Clock Framework driver. Then the main clock driver for mentioned
SoCs is introd
On 08/06/13 03:06, Mike Turquette wrote:
Quoting Kukjin Kim (2013-08-05 10:01:36)
On 07/23/13 08:49, Tomasz Figa wrote:
This series is an attempt to move clock support on Samsung S3C64xx SoCs
to Common Clock Framework.
First, support for PLL types present on S3C64xx SoCs is added to Samsung
On 08/07/13 07:06, Tomasz Figa wrote:
On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote:
Quoting Tomasz Figa (2013-08-05 16:42:16)
On Monday 05 of August 2013 12:02:16 Mike Turquette wrote:
Quoting Kukjin Kim (2013-08-05 11:13:55)
On 08/06/13 03:06, Mike Turquette wrote:
Quoting
Tomasz Figa wrote:
[...]
> > > > >
> > > > > Basically, this series looks good to me, but I'm not sure how this
> > > > > should be handled because of dependency with PWM cleanup and clk
> > > > > stuff
> > > > > in clk tree now...
> > > >
> > > > Patches 1-3 can go into the clk tree. 4-6 should
Mike Turquette wrote:
>
[...]
> > OK, if new branch is ready, I will replace with that or if re-merge is
> > required, I will. Either way, I'm fine and can handle. Mike, let me know
> > your choice :-)
>
> Since I have already published it let's just go with the delta patch. I
> can create ano
On 08/20/13 16:09, Kukjin Kim wrote:
Mike Turquette wrote:
[...]
OK, if new branch is ready, I will replace with that or if re-merge is
required, I will. Either way, I'm fine and can handle. Mike, let me know
your choice :-)
Since I have already published it let's just go with
On 08/27/13 10:14, Mike Turquette wrote:
Quoting Tomasz Figa (2013-08-20 17:33:21)
This patch modifies PLL6552 and PLL6553 clock drivers to use recently
added common Samsung PLL registration method.
Signed-off-by: Tomasz Figa
Sigh. This change won't apply on top of clk-next-s3c64xx since it
r
IS_ERR_OR_NULL(ref_clk)?
> + dev_err(sphy->dev, "Failed to get reference clock\n");
> + return PTR_ERR(ref_clk);
> + }
> +
> + switch (clk_get_rate(ref_clk)) {
> + case 12 * MHZ:
> + refclk_freq |= S3C_PHYCLK_CLKSEL_12M;
Just,
bject]' format.
So I preferred to use 'ARM: EXYNOS: Enabling samsung-usbphy driver for
EXYNOS4210' on that.
Please make sure your patch has no problem for kernel compilation before
submitting...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Developmen
Thomas Abraham wrote:
>
> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> calls as required by common clock framework.
>
> Signed-off-by: Thomas Abraham
(+ Alan Stern)
Acked-by: Kukjin Kim
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Seni
Thomas Abraham wrote:
>
> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> calls as required by common clock framework.
>
> Signed-off-by: Thomas Abraham
(+ Alan Stern)
Acked-by: Kukjin Kim
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Seni
Doug Anderson wrote:
>
> The ehci_vbus_gpio is requested but never freed. This can cause
> problems with deferred probes and would cause problems if
> s5p_ehci_remove was ever called. Use devm to fix this.
>
> Signed-off-by: Doug Anderson
Acked-by: Kukjin Kim
vers/usb/phy/phy-samsung-usb2.c:50:26:got void *
>
> Cc: Vivek Gautam
> Cc: Kukjin Kim
Looks good to me, if you want:
Acked-by: Kukjin Kim
Thanks.
- Kukjin
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/phy/phy-samsung-usb2.c | 2 +-
> 1 file changed, 1 insertio
Vivek Gautam wrote:
>
> Based on 'for-next' of linux-samsung tree with following patches
> from Doug on top:
> usb: Document clocks in samsung, exynos4210-ehci/ohci bindings
> ARM: dts: add usb 2.0 clock references to exynos5250 device tree
>
> Also depending upon following patch-series for Samsu
Vivek Gautam wrote:
>
> This patch-set is in continuation with patch-series:
> [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250
> out of which follwowing patches have been picked up:
> ARM: Exynos5250: Enabling ehci-s5p driver
> ARM: Exynos5250: Enabling ohci-exynos driver
>
> Base
cd to the driver data rather than s5p_ehci.
This fixes issues with null pointer dereferencing in
s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().
Signed-off-by: Vivek Gautam
CC: Manjunath Goudar
CC: Arnd Bergmann
CC: Jingoo Han
Acked-by: Kukjin Kim
Thanks.
- Kukjin
---
Based on &#
On 11/22/14 17:40, Kishon Vijay Abraham I wrote:
>
> On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote:
>> On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote:
>>> The series has dependency on
>>> a) "[PATCH v7 0/7] Enable support for Samsung Exynos7 SoC"
>>>http://www.spinics.n
+
3 files changed, 254 insertions(+), 47 deletions(-)
This series looks good to me, please feel free to add my ack on this series,
Acked-by: Kukjin Kim
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.
On 05/14/14 23:01, Vivek Gautam wrote:
From: Vivek gautam
Based on 'for-next' branch of Kgene's linux-samsung tree;
along with dts patches for USB 2.0 phy[1], and Exynos5800 [2].
Also based on the latest USB 3.0 DRD phy driver patches posted [3].
Changes from v5:
- Added node reference names
Vivek Gautam wrote:
>
> This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
> tree, to access System Register's registers using syscon driver.
>
> Signed-off-by: Kamil Debski
> [gautam.vi...@samsung.com: Split this syreg-syscon dts entry from
> dts: Add usb2phy to Exynos 5250
Vivek Gautam wrote:
>
> Add required fixed-regulator for VBUS supply for USB 3.0
> controller phy.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.
Vikas Sajjan wrote:
>
> Based on 'for-next' branch of Kgene's linux-samsung tree.
> These patches are as per discussions on the driver side patches
> which have already been acked. [1]
>
Sounds good. I will apply this whole series if dt guys have no objection to
add the exynos5-sysreg dt binding.
ones using the generic PHY layer.
Depends on:
- next-20140813 branch of linux-next kernel
this thread seems to have died, what do I need to do with these patches?
Please apply them (patches #3, #4 and #5). Patches #1 and #2
should be applied (or Acked-by) by Kukjin Kim.
I've applied #1 a
Marek Szyprowski wrote:
>
> All currently supported boards use hsotg/dwc2 controller in device
> ('peripheral') mode, so add property which sets correct operation mode.
> This patch fixes support in recent changes in dwc2 driver, which added
> support for dual-role devices.
>
> Suggested-by: Paul
Kukjin Kim wrote:
>
> Marek Szyprowski wrote:
> >
> > All currently supported boards use hsotg/dwc2 controller in device
> > ('peripheral') mode, so add property which sets correct operation mode.
> > This patch fixes support in recent changes in dwc2 drive
43 matches
Mail list logo
