Replaced magic numbers used in the CRTSCTS flag code with symbolic names
from the chip specification.
Signed-off-by: Konstantin Shkolnyy
---
v4:
Same series of patches, fixed names and defines by feedback.
v3:
Regenerated the patches correctly against the latest usb-next branch.
v2
Improved
The CRTSCTS flag code cleared (and inconsistently) bits unrelated to
CRTSCTS functionality. It was also harder than necessary to read.
Signed-off-by: Konstantin Shkolnyy
---
v4:
Same series of patches, fixed names and defines by feedback.
v3:
Regenerated the patches correctly against the latest
"
This only happened after first having enabled CRTSCTS.
Signed-off-by: Konstantin Shkolnyy
---
v4:
Same series of patches, fixed names and defines by feedback.
v3:
Regenerated the patches correctly against the latest usb-next branch.
v2
Improved CRTSCTS fix by feedback. Dropped get_termios error ha
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Johan Hovold
> Sent: Wednesday, May 04, 2016 02:29
> To: Konstantin Shkolnyy
> Cc: jo...@kernel.org; linux-usb@vger.kernel.org; linux-
> ker...@vger
> -Original Message-
> From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> Sent: Wednesday, May 04, 2016 07:55
> To: Konstantin Shkolnyy
> Cc: Johan Hovold; Konstantin Shkolnyy; linux-usb@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject:
The CRTSCTS flag code cleared (and inconsistently) bits unrelated to
CRTSCTS functionality. It was also harder than necessary to read.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 32 ++--
1 file changed, 10 insertions(+), 22 deletions
"
This only happened after first having enabled CRTSCTS.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index dd47823..fef7a51 100644
--- a/drivers/u
Replaced magic numbers used in the CRTSCTS flag code with symbolic names
from the chip specification.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 109 ++--
1 file changed, 84 insertions(+), 25 deletions(-)
diff --git a/drivers
.
v2
Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix.
Konstantin Shkolnyy (3):
USB: serial: cp210x: Fixed RTS mode setting by the CRTSCTS flag.
USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.
USB: serial: cp210x: Cleaned up CRTSCTS flag code
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Mario Limonciello
> Sent: Monday, June 06, 2016 12:19
> To: hayesw...@realtek.com
> Cc: LKML; Netdev; Linux USB; pali.ro...@gmail.com;
> anthony.w...@canonical.com; Greg KH;
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 16-bit values, instead of
the above functions.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 155 +++-
1 file
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 8 and 32-bit values, instead
of the above functions.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 92 ++---
1
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
switches large register access to use new block functions. The old
functions are removed because now they become unused.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 137
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
switches large register access to use new block functions. The old
functions are removed because now they become unused.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 137
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 8 and 32-bit values, instead
of the above functions.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 92 ++---
1
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 16-bit values, instead of
the above functions.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 155 +++-
1 file
Change to use new large register access functions instead of
cp210x_get_config and cp210x_set_config and remove the old functions since
they are now unused.
Signed-off-by: Konstantin Shkolnyy
---
change in v3: Presented new function addition as a separate patch #1,
to simplify code review
Change to use new 8-bit and 32-bit register access functions instead of
cp210x_get_config and cp210x_set_config.
Signed-off-by: Konstantin Shkolnyy
---
change in v3: Presented new function addition as a separate patch #1,
to simplify code review.
drivers/usb/serial/cp210x.c | 11 +--
1
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions to replace them. New functions
are not yet called - the switch is done gradually in following changes.
Signed-off-by: Konstantin Shkolnyy
---
change in v3: Presented new function
Change to use new 16-bit register access functions instead of
cp210x_get_config and cp210x_set_config.
Signed-off-by: Konstantin Shkolnyy
---
change in v3: Presented new function addition as a separate patch #1,
to simplify code review.
drivers/usb/serial/cp210x.c | 80
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
switches large register access to use new block functions. The old
functions are removed because now they become unused.
Signed-off-by: Konstantin Shkolnyy
---
change in v4: Instead of adding all new functions a one
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 16-bit values, instead of
the above functions.
Signed-off-by: Konstantin Shkolnyy
---
change in v4: Instead of adding all new functions a one separate patch, added
them with
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 8 and 32-bit values, instead
of the above functions.
Signed-off-by: Konstantin Shkolnyy
---
change in v4: Instead of adding all new functions a one separate patch, added
them
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 16-bit values, instead of
the above functions.
Signed-off-by: Konstantin Shkolnyy
---
change in v4: Instead of adding all new functions a one separate patch, added
them with
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 8 and 32-bit values, instead
of the above functions.
Signed-off-by: Konstantin Shkolnyy
---
change in v4: Instead of adding all new functions a one separate patch, added
them
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
switches large register access to use new block functions. The old
functions are removed because now they become unused.
Signed-off-by: Konstantin Shkolnyy
---
change in v4: Instead of adding all new functions a one
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 16-bit values, instead of
the above functions.
Signed-off-by: Konstantin Shkolnyy
---
change in v5: Same patch, regenerated against current usb-next branch.
change in v4
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
introduces new register access functions for 8 and 32-bit values, instead
of the above functions.
Signed-off-by: Konstantin Shkolnyy
---
change in v5: Same patch, regenerated against current usb-next branch.
change in v4
cp210x_get_config and cp210x_set_config are cumbersome to use. This change
switches large register access to use new block functions. The old
functions are removed because now they become unused.
Signed-off-by: Konstantin Shkolnyy
---
change in v5: Same patch, regenerated against current usb
A bug in the CRTSCT handling caused RTS to alternate between
CRTSCTS=0 => "RTS transmits active signal" and
CRTSCTS=1 => "RTS receives flow control"
instead of
CRTSCTS=0 => "RTS is statically active" and
CRTSCTS=1 => "RTS receives flow control"
Replaced several register write calls with one, to simplify adding error
handling.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index
Added error handling to register accesses made by open(), so it doesn't
succeed if anything goes wrong.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 41 -
1 file changed, 28 insertions(+), 13 deletions(-)
diff --git a/driver
Documented "magic numbers" used in the CRTSCT flag code in terms of
register bit names from the chip specification.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
di
The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
did it inconsistently. This change is non-functional for existing chips
because the driver never set the flag and it's clear by default.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 2 +-
1
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Valentin Yakovenkov
> Sent: Tuesday, March 22, 2016 11:12
> To: linux-usb@vger.kernel.org
> Subject: [PATCH] Add DCD line support to CP210x driver
You'll have to re-generat
> -Original Message-
> From: Konstantin Shkolnyy
> Sent: Wednesday, March 23, 2016 11:26
> To: 'Valentin Yakovenkov'; linux-usb@vger.kernel.org
> Subject: RE: [PATCH] Add DCD line support to CP210x driver
>
> > -Original Message-
> &g
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Valentin Yakovenkov
> Sent: Tuesday, March 22, 2016 11:12
> To: linux-usb@vger.kernel.org
> Subject: [PATCH] Add DCD line support to CP210x driver
[...]
> static struct us
> -Original Message-
> From: Valentin Yakovenkov [mailto:yakoven...@niistt.ru]
> Sent: Wednesday, March 23, 2016 11:52
> To: Konstantin Shkolnyy; linux-usb@vger.kernel.org
> Subject: Re: [PATCH] Add DCD line support to CP210x driver
>
> Here's regenerated patch
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of tilman
> Sent: Tuesday, March 29, 2016 04:02
> To: linux-usb@vger.kernel.org
> Subject: Re: driver migration
>
> Greg KH writes:
>
> Dear Greg
>
> > > I moved the initia
Added error handling to register accesses made by open(), so it doesn't
succeed if anything goes wrong.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 41 -
1 file changed, 28 insertions(+), 13 deletions(-)
diff --git a/driver
A bug in the CRTSCT handling caused RTS to alternate between
CRTSCTS=0 => "RTS transmits active signal" and
CRTSCTS=1 => "RTS receives flow control"
instead of
CRTSCTS=0 => "RTS is statically active" and
CRTSCTS=1 => "RTS receives flow control"
The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
did it inconsistently. This change is non-functional for existing chips
because the driver never set the flag and it's clear by default.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 2 +-
1
Documented "magic numbers" used in the CRTSCT flag code in terms of
register bit names from the chip specification.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
di
Replaced several register write calls with one, to simplify adding error
handling.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index
;
__le32 ulXoffLimit;
} __packed;
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Johan Hovold
> Sent: Monday, April 25, 2016 05:17
> To: Konstantin Shkolnyy
> Cc: jo...@kernel.org; linux-usb@vger.kernel
> -Original Message-
> From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> Sent: Tuesday, April 26, 2016 02:26
> To: Konstantin Shkolnyy
> Cc: Johan Hovold; Konstantin Shkolnyy; linux-usb@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject:
> -Original Message-
> From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> Sent: Friday, April 29, 2016 05:09
> To: Valentin Yakovenkov
> Cc: Konstantin Shkolnyy; linux-usb@vger.kernel.org
> Subject: [EXT] Re: [PATCH] Add DCD line support to CP210x
Replaced magic numbers used in the CRTSCTS flag code with symbolic names
from the chip specification.
Signed-off-by: Konstantin Shkolnyy
---
Changes in v2:
Improved CRTSCTS fix based on feedback. Dropped get_termios error handling.
drivers/usb/serial/cp210x.c | 93
The CRTSCTS flag code cleared (and inconsistently) bits unrelated to
CRTSCTS functionality. It was also harder than necessary to read.
Signed-off-by: Konstantin Shkolnyy
---
Changes in v2:
Improved CRTSCTS fix based on feedback. Dropped get_termios error handling.
drivers/usb/serial/cp210x.c
"
This only happened after first having enabled CRTSCTS.
Signed-off-by: Konstantin Shkolnyy
---
Changes in v2:
Improved CRTSCTS fix based on feedback. Dropped get_termios error handling.
drivers/usb/serial/cp210x.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drive
Replaced magic numbers used in the CRTSCTS flag code with symbolic names
from the chip specification.
Signed-off-by: Konstantin Shkolnyy
---
v3:
Regenerated the patches correctly against the latest usb-next branch.
v2
Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix
"
This only happened after first having enabled CRTSCTS.
Signed-off-by: Konstantin Shkolnyy
---
v3:
Regenerated the patches correctly against the latest usb-next branch.
v2
Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix.
drivers/usb/serial/cp210x.c | 3 +--
1 file c
The CRTSCTS flag code cleared (and inconsistently) bits unrelated to
CRTSCTS functionality. It was also harder than necessary to read.
Signed-off-by: Konstantin Shkolnyy
---
v3:
Regenerated the patches correctly against the latest usb-next branch.
v2
Improved CRTSCTS fix by feedback. Dropped
> -Original Message-
> From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> Sent: Sunday, May 01, 2016 10:20
> To: Konstantin Shkolnyy
> Cc: Johan Hovold; Valentin Yakovenkov; linux-usb@vger.kernel.org
> Subject: Re: [EXT] Re: [PATCH] Add DCD line
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of David Laight
> Sent: Tuesday, May 03, 2016 04:44
> To: 'Konstantin Shkolnyy'; jo...@kernel.org
> Cc: linux-usb@vger.kernel.org; linux-ker...@vge
.
Adding tx_empty() has no adverse effect on other cp210x devices.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index eac7cca..0189e64
.
In turn, this causes cp2108 respond with a stall. The stall sometimes doesn't
clear properly and cp2108 starts responding to following valid commands also
with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
.
In turn, this causes cp2108 respond with a stall. The stall sometimes doesn't
clear properly and cp2108 starts responding to following valid commands also
with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
Some host controllers just can't support so many pipes opened at once. Check
what the SoC spec says about that.
-Original Message-
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org]
On Behalf Of Yegor Yefremov
Sent: Monday, October 12, 2015 05:35
To: linux-usb
.
In turn, this causes cp2108 respond with a stall. The stall sometimes doesn't
clear properly and cp2108 starts responding to following valid commands also
with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
.
Adding tx_empty() has no adverse effect on other cp210x devices.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index eac7cca..0189e64
.
In turn, this causes cp2108 respond with a stall. The stall sometimes doesn't
clear properly and cp2108 starts responding to following valid commands also
with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
Hello,
On Fri, Oct 16, 2015 at 6:19 AM, Sergei Shtylyov
wrote:
[...]
>>
>> @@ -249,6 +251,16 @@ static struct usb_serial_driver * const
>> serial_drivers[] = {
>> #define CP210X_GET_CHARS 0x0E
>> #define CP210X_GET_PROPS 0x0F
>> #define CP210X_GET_COMM_STATUS0x10
>> +/* D
On Fri, Oct 16, 2015 at 7:55 AM, Johan Hovold wrote:
> On Thu, Oct 15, 2015 at 05:07:08PM -0500, Konstantin Shkolnyy wrote:
>> Occasionally, writing data and immediately closing the port makes cp2108
>> stop responding. The device had to be unplugged to clear the error.
>> T
On Fri, Oct 16, 2015 at 8:27 AM, Johan Hovold wrote:
> On Thu, Oct 15, 2015 at 06:23:31PM -0500, Konstantin Shkolnyy wrote:
>> cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped.
>> However, SET_LINE_CTL functions properly. When the driver tries to modify
>
On Fri, Oct 16, 2015 at 10:27 AM, Johan Hovold wrote:
> On Fri, Oct 16, 2015 at 10:11:12AM -0500, Konstantin Shkolnyy wrote:
>> On Fri, Oct 16, 2015 at 8:27 AM, Johan Hovold wrote:
>> > On Thu, Oct 15, 2015 at 06:23:31PM -0500, Konstantin Shkolnyy wrote:
>> >> cp21
On Mon, Oct 19, 2015 at 4:14 AM, Oliver Neukum wrote:
> On Thu, 2015-10-15 at 17:06 -0500, Konstantin Shkolnyy wrote:
>> cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped.
>> However, SET_LINE_CTL functions properly. When the driver tries to modify
>> the
Existing register access functions cp210x_get_config and cp210x_set_config
are cumbersome to use. This change introduces new functions specifically
for 16-bit registers that read and write simple u16 values.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 119
is condition is avoided by issuing PURGE command from
the close() callback.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 79 +++--
1 file changed, 77 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/
On Tue, Oct 20, 2015 at 1:45 AM, Oliver Neukum wrote:
> On Mon, 2015-10-19 at 17:01 -0500, Konstantin Shkolnyy wrote:
[...]
>> +static int cp210x_read_u16_reg(struct usb_serial *serial, u8 req, u16 *pval)
>> +{
>> + struct cp210x_serial_private *spriv = usb_g
On Tue, Oct 20, 2015 at 2:45 AM, Johan Hovold wrote:
[...]
> Instead of adding the new helpers to read u16 as a prerequisite for
> fixing the broken cp2108 support, just reuse the current config register
> helpers for now (in order to keep the fixes minimal and potentially
> backportable). Once th
On Tue, Oct 20, 2015 at 8:02 AM, Johan Hovold wrote:
> On Tue, Oct 20, 2015 at 07:52:31AM -0500, Konstantin Shkolnyy wrote:
>> On Tue, Oct 20, 2015 at 2:45 AM, Johan Hovold wrote:
>> [...]
>> > Instead of adding the new helpers to read u16 as a prerequisite for
>&
On Tue, Oct 20, 2015 at 11:22 AM, Johan Hovold wrote:
> On Tue, Oct 20, 2015 at 09:19:05AM -0500, Konstantin Shkolnyy wrote:
>> On Tue, Oct 20, 2015 at 8:02 AM, Johan Hovold wrote:
>> > On Tue, Oct 20, 2015 at 07:52:31AM -0500, Konstantin Shkolnyy wrote:
>> >> O
On Tue, Oct 20, 2015 at 11:22 AM, Johan Hovold wrote:
> On Tue, Oct 20, 2015 at 09:19:05AM -0500, Konstantin Shkolnyy wrote:
>> On Tue, Oct 20, 2015 at 8:02 AM, Johan Hovold wrote:
>> > On Tue, Oct 20, 2015 at 07:52:31AM -0500, Konstantin Shkolnyy wrote:
>> >> O
close() callback.
This change is applied to all cp210x devices. Clearing internal queues on
close is generally good.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb
trivial.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 43 +++
1 file changed, 23 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 8ba1005..352fe63 100644
--- a/drivers/usb
. In turn, this causes cp2108 respond with a stall. The stall
sometimes doesn't clear properly and cp2108 starts responding to following
valid commands also with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
. In turn, this causes cp2108 respond with a stall. The stall
sometimes doesn't clear properly and cp2108 starts responding to following
valid commands also with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
trivial.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 43 +++
1 file changed, 23 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 8ba1005..352fe63 100644
--- a/drivers/usb
close() callback.
This change is applied to all cp210x devices. Clearing internal queues on
close is generally good.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb
trivial.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 43 +++
1 file changed, 23 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 8ba1005..352fe63 100644
--- a/drivers/usb
. In turn, this causes cp2108 respond with a stall. The stall
sometimes doesn't clear properly and cp2108 starts responding to following
valid commands also with stalls, effectively failing.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
close() callback.
This change is applied to all cp210x devices. Clearing internal queues on
close is generally good.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb
27, 2015 at 04:53:34PM -0500, Konstantin Shkolnyy wrote:
>> > cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped.
>> > However, SET_LINE_CTL functions properly. When the driver tries to modify
>> > the register, it reads it, modifies some bits and writ
On Sat, Oct 31, 2015 at 7:16 AM, Johan Hovold wrote:
> [ Please avoid top-posting. ]
>
> On Thu, Oct 29, 2015 at 08:39:04AM -0500, Konstantin Shkolnyy wrote:
>> I tested it on cp2102, cp2105 and cp2108.
>> I'm a little worried about that extra PURGE command, so I did
[...]
Hi Johan,
I'd like to add tx_empty() and replace cp210x_get/set_config with
simpler functions, as we discussed before. While the tx_empty patch
could be made against the current kernel, the latter would have to be
made against my previous patch set. How should this be done?
Thanks,
Konstan
Without this function, when the port is closed the data in the chip's
transmit FIFO are lost. If the actual byte count is reported the close
can be delayed until all data are sent.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
The cp210x driver can't handle CP2110 , because its a HID device. cp210x is
designed for a different USB device interface, found on CP210x devices.
It's strange that the CP2110 ID 10c4 ea80 is listed inside cp210x.
A good place to start would be to ask your multimeter manufacturer for Linux
s/w.
> The cp210x driver can't handle CP2110 , because its a HID device. cp210x is
> designed for a different USB device interface, found on CP210x devices.
> It's strange that the CP2110 ID 10c4 ea80 is listed inside cp210x.
>
> A good place to start would be to ask your multimeter manufacturer for Li
CP2110 ID (0x10c4, 0xea80) doesn't belong here because it's a HID
and completely different from CP210x devices.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp21
Without this function, when the port is closed the data in the chip's
transmit FIFO are lost. If the actual byte count is reported the close
can be delayed until all data are sent.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c
-empty the close can be delayed until all data are sent.
Signed-off-by: Konstantin Shkolnyy
---
Code style corrections and using sizeof instead of a defined constant.
drivers/usb/serial/cp210x.c | 58 +
1 file changed, 58 insertions(+)
diff --git a/d
On Wed, Nov 25, 2015 at 2:26 PM, Andy Shevchenko
wrote:
> On Wed, Nov 25, 2015 at 12:28 AM, Konstantin Shkolnyy
> wrote:
>> +static bool cp210x_tx_empty(struct usb_serial_port *port)
>> +{
>> + int err;
>> + u32 count;
>> +
>> +
introduces separate register accessor functions for single
8, 16 and 32-bit values, with endian conversion, as well as "block"
access functions without conversion.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 314 ++--
1 fi
94 matches
Mail list logo
