Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-02 Thread Johannes Thumshirn
s > when the drive is powered down. > > Signed-off-by: Oliver Neukum Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 904

Re: [-next] BUG_ON in scsi_target_destroy()

2016-04-13 Thread Johannes Thumshirn
Hi Sergey, Xiong, Can you try below patch? On Montag, 11. April 2016 18:01:47 CEST Sergey Senozhatsky wrote: > Hello, > > commit 7b106f2de6938c31ce5e9c86bc70ad3904666b96 > Author: Johannes Thumshirn > Date: Tue Apr 5 11:50:44 2016 +0200 > > scsi: Add intermediate

Re: [-next] BUG_ON in scsi_target_destroy()

2016-04-13 Thread Johannes Thumshirn
On Mittwoch, 13. April 2016 23:47:04 CEST Sergey Senozhatsky wrote: > Hi, > > On (04/13/16 10:41), Johannes Thumshirn wrote: > > Hi Sergey, Xiong, > > > > Can you try below patch? > > it panics my system. > first it warn_on-s in lib/kobject.c:244 > &

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-06 Thread Johannes Thumshirn
The subject is wrong, should be something like "scsi: libfc convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390. Other than that Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-08 Thread Johannes Thumshirn
-after-free situations. The subject is wrong, should be something like "scsi: libfc convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390. Other than that Acked-by: Johannes Thumshirn Turns out that it is better that all these patches go through the respective mainta

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Johannes Thumshirn
>> >> This looks OK to me. >> >> Acked-by: Chris Leech > > Thank you for review! Do you have a tree that can take this change? Hi Elena, iscsi like fcoe should go via the SCSI tree. Byte, Johannes -- Johannes Thumshirn

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Johannes Thumshirn
r review! Do you have a tree that can take this change? >> >> Hi Elena, >> >> iscsi like fcoe should go via the SCSI tree. > > Thanks Johannes! Should I resend with "Acked-by" added in order for it to be > picked up? Yes I think this would be a good way

[PATCH] usb: hub: avoid possible division by zero

2013-11-23 Thread Johannes Thumshirn
Avoid possible division by zero in led_work, if hdev->maxchild is 0. See also: http://buildbot.llvm.linuxfoundation.org/checker/scan-build-latest/report-b65939.html#EndPath Signed-off-by: Johannes Thumshirn --- drivers/usb/core/hub.c | 3 ++- 1 file changed, 2 insertions(+), 1 delet

Re: [PATCH] usb: hub: avoid possible division by zero

2013-11-23 Thread Johannes Thumshirn
On Sat, Nov 23, 2013 at 09:20:10AM -0800, Greg Kroah-Hartman wrote: > On Sat, Nov 23, 2013 at 05:31:34PM +0100, Johannes Thumshirn wrote: > > Avoid possible division by zero in led_work, if hdev->maxchild is 0. > > > > See also: > > http://buildbot.llvm.linuxfou

[PATCH] cdc-acm: Destroy acm_minors IDR on module exit

2015-07-08 Thread Johannes Thumshirn
t.exit; @@ exit(void) { ... idr_destroy(&idr); ... } @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@ exit(void) { ... +idr_destroy(&idr); } Signed-off-

[PATCH] USB: serial: Destroy serial_minors IDR on module exit

2015-07-08 Thread Johannes Thumshirn
t.exit; @@ exit(void) { ... idr_destroy(&idr); ... } @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@ exit(void) { ... +idr_destroy(&idr); } Signed-off-

Re: broken TRIM support for JMS578 in uas mode

2018-08-02 Thread Johannes Thumshirn
t it? Generally speaking no. If the USB Adapter doesn't translate the Command it doesn't translate it. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX