)
USB-serial updates for v4.6-rc1
Here are some cp210x register-accessor updates and general usb-serial
code clean ups.
Signed-off-by: Johan Hovold
Konstantin Shkolnyy (3
On Tue, Mar 15, 2016 at 07:59:59AM +, Schemmel Hans-Christoph wrote:
> Added support for Gemalto's Cinterion PH8 and AHxx products
> with 2 RmNet Interfaces and products with 1 RmNet + 1 USB Audio interface.
> The RmNet and USB Audio interfaces are blacklisted because they will be
> handled by
On Thu, Mar 17, 2016 at 11:38:42AM +0100, Oliver Neukum wrote:
> An attack using the lack of sanity checking in probe
> is known. This patch checks for the existance of a
> second port.
> CVE-2016-3136
>
> Signed-off-by: Oliver Neukum
> CC: sta...@vger.kernel.org
> ---
> drivers/usb/serial/mct_u
On Wed, Mar 16, 2016 at 02:23:33PM +0100, Oliver Neukum wrote:
> An attack using the lack of sanity checking in probe
> is known. This patch checks for the existance of a
> second port.
> CVE-2016-3136
>
> Signed-off-by: Oliver Neukum
> CC: sta...@vger.kernel.org
> ---
> drivers/usb/serial/mct_u
On Thu, Mar 17, 2016 at 12:17:34PM +0100, Oliver Neukum wrote:
> On Wed, 2016-03-16 at 10:58 -0400, Johan Hovold wrote:
> > Note that this needs to be done for not just the port structure
> > (ds_oob_port) by making sure that the serial->num_ports is large
> > enough,
&
On Wed, Mar 16, 2016 at 03:19:49PM +0100, Oliver Neukum wrote:
> An attack using missing endpoints exists.
> CVE-2016-3137
>
> Signed-off-by: Oliver Neukum
> CC: sta...@vger.kernel.org
> ---
> drivers/usb/serial/cypress_m8.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/us
On Wed, Mar 16, 2016 at 02:43:02PM +0100, Oliver Neukum wrote:
> The driver can be crashed with devices that expose crafted
> descriptors with too few endpoints.
> See:
> http://seclists.org/bugtraq/2016/Mar/61
>
> Signed-off-by: Oliver Neukum
> ---
> drivers/usb/serial/digi_acceleport.c | 5 +++
On Thu, Mar 17, 2016 at 11:07:31AM +0100, Oliver Neukum wrote:
> An attack using missing endpoints exists.
> CVE-2016-3137
>
> Signed-off-by: Oliver Neukum
> CC: sta...@vger.kernel.org
> ---
> drivers/usb/serial/cypress_m8.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
On Wed, Mar 16, 2016 at 11:55:49AM -0400, Josh Boyer wrote:
> On Thu, Mar 10, 2016 at 9:48 AM, Josh Boyer wrote:
> > A Fedora user reports that the ftdi_sio driver works properly for the
> > ICP DAS I-7561U device. Further, the user manual for these devices
> > instructs users to load the driver
On Thu, Mar 31, 2016 at 09:56:34AM +0200, Oliver Neukum wrote:
> Hi,
>
> do I need to resubmit the serial fixes I submitted for
> the issues with the forged device descriptors leading
> to crashes?
No, that's not necessary. I'm on the road for another couple of days but
I'll forward these to Greg
On Mon, Mar 21, 2016 at 03:57:37PM +0100, Oliver Neukum wrote:
> The driver can be crashed with devices that expose crafted
> descriptors with too few endpoints.
> See:
> http://seclists.org/bugtraq/2016/Mar/61
>
> Signed-off-by: Oliver Neukum
>
> v1 - added sanity checks
> v2 - moved them to pr
From: Oliver Neukum
The driver can be crashed with devices that expose crafted descriptors
with too few endpoints.
See: http://seclists.org/bugtraq/2016/Mar/61
Signed-off-by: Oliver Neukum
[johan: fix OOB endpoint check and add error messages ]
Cc: stable
Signed-off-by: Johan Hovold
From: Oliver Neukum
An attack using missing endpoints exists.
CVE-2016-3137
Signed-off-by: Oliver Neukum
CC: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/usb
Greg,
These patches from Oliver add some sanity checks for missing endpoints
and should go into v4.6-rc2.
Would you mind picking these up directly? I expect to process the rest
of my queue early next week.
Note that this series has been compile-tested only.
Thanks,
Johan
Oliver Neukum (3):
From: Oliver Neukum
An attack using the lack of sanity checking in probe is known. This
patch checks for the existence of a second port.
CVE-2016-3136
Signed-off-by: Oliver Neukum
CC: sta...@vger.kernel.org
[johan: add error message ]
Signed-off-by: Johan Hovold
---
drivers/usb/serial
On Wed, Apr 06, 2016 at 07:58:36PM +0200, Grigori Goronzy wrote:
> On 04/02/2016 07:29 PM, Joe Perches wrote:
> > Most of the whitespace only changes are undesired.
>
> Well, the style wasn't very consistent. I think consistency is
> important. So I took the liberty of deciding for one style and
On Wed, Mar 16, 2016 at 12:11:35PM -0400, Johan Hovold wrote:
> On Wed, Mar 16, 2016 at 11:55:49AM -0400, Josh Boyer wrote:
> > On Thu, Mar 10, 2016 at 9:48 AM, Josh Boyer
> > wrote:
> > > A Fedora user reports that the ftdi_sio driver works properly for the
>
On Wed, Apr 06, 2016 at 03:20:03PM +, Schemmel Hans-Christoph wrote:
> Added support for Gemalto's Cinterion PH8 and AHxx products
> with 2 RmNet Interfaces and products with 1 RmNet + 1 USB Audio interface.
>
> The RmNet and USB Audio interfaces are blacklisted because they will be
> handled
On Mon, Mar 28, 2016 at 10:37:35PM +0200, Bjørn Mork wrote:
> Thomas reports:
> "Windows:
>
> 00 diagnostics
> 01 modem
> 02 at-port
> 03 nmea
> 04 nic
>
> Linux:
>
> T: Bus=02 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 4 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
On Tue, Mar 29, 2016 at 05:47:29PM +0100, Martyn Welch wrote:
> The CP2105 is used in the GE Healthcare Remote Alarm Box, with the
> Manufacturer ID of 0x1901 and Product ID of 0x0194.
>
> Signed-off-by: Martyn Welch
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
On Wed, Apr 06, 2016 at 03:20:03PM +, Schemmel Hans-Christoph wrote:
> Added support for Gemalto's Cinterion PH8 and AHxx products
> with 2 RmNet Interfaces and products with 1 RmNet + 1 USB Audio interface.
>
> The RmNet and USB Audio interfaces are blacklisted because they will be
> handled
On Thu, Apr 07, 2016 at 10:45:10AM +0100, Martyn Welch wrote:
>
>
> On 07/04/16 10:39, Johan Hovold wrote:
> > On Tue, Mar 29, 2016 at 05:47:29PM +0100, Martyn Welch wrote:
> >> The CP2105 is used in the GE Healthcare Remote Alarm Box, with the
> >> Manufactur
On Thu, Apr 07, 2016 at 09:48:27AM +, Schemmel Hans-Christoph wrote:
> This message and any attachments are intended solely for the addressees and
> may contain confidential information. Any unauthorized use or disclosure,
> either whole or partial, is prohibited.
> E-mails are susceptible
On Thu, Apr 07, 2016 at 12:09:17PM +0200, Bjørn Mork wrote:
> Thomas reports:
> "Windows:
>
> 00 diagnostics
> 01 modem
> 02 at-port
> 03 nmea
> 04 nic
>
> Linux:
>
> T: Bus=02 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 4 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
new device ids.
Signed-off-by: Johan Hovold
Bjørn Mork (1):
USB: option: add "D-Link DWM-221 B1" device id
Josh Boyer (1):
USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices
Martyn Welch (1):
On Tue, Apr 12, 2016 at 09:01:52AM +0100, Martyn Welch wrote:
> Johan,
>
> Thanks for reviewing the other patch in this series. I haven't seen any
> feedback regarding this patch, is it still in your queue?
It is, and I will get to it. I've managed to gather some review backlog
this past month t
On Mon, Apr 18, 2016 at 01:41:38PM +1000, Mike Manning wrote:
> Please find attached patch file for addition of Link G4 and Link G4+ Ecu's.
Thanks for the patch.
Try running your patch through scripts/checkpath.pl before submitting.
It would have let you know that the patch has some whitespace is
On Sun, Apr 10, 2016 at 04:35:04PM +0300, Jasem Mutlaq wrote:
> Adding VID:PID for Straizona Focusers to cp210x driver.
>
> Signed-off-by: Jasem Mutlaq
Thanks for the patch.
Try running your patch through checkpatch.pl before submitting. It would
have let you know that the patch has some white-
On Mon, Apr 18, 2016 at 12:13:23PM +, Mike Manning wrote:
> The Link ECU is an aftermarket ECU computer for vehicles that provides full
> tuning abilities as well as datalogging and displaying capabilities via the
> USB to Serial adapter built into the device.
>
> Signed-off-by: Mike Manning
On Tue, Apr 19, 2016 at 10:38:27AM +0300, Jasem Mutlaq wrote:
> From: Jasem Mutlaq
>
> Adding VID:PID for Straizona Focusers to cp210x driver. Fixed white space
> issue.
>
> Signed-off-by: Jasem Mutlaq
> ---
Thanks for the v2. I trimmed the changelog comment (about white space)
before applyin
On Fri, Apr 08, 2016 at 08:27:16AM +, Schemmel Hans-Christoph wrote:
> > -Original Message-
> > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> > Sent: Donnerstag, 7. April 2016 11:51
> > To: Schemmel Hans-Christoph
>
On Mon, Feb 29, 2016 at 04:11:20PM +0300, Maksim Salau wrote:
> The adaptor can be found on development boards for 78k, RL78 and V850
> microcontrollers produced by Renesas Electronics Corporation.
>
> This is not a full-featured USB to serial converter, however it allows
> basic communication and
On Wed, Mar 02, 2016 at 10:46:13AM +0100, Mathieu OTHACEHE wrote:
> Add support for :
>
> - UPort 1110 : 1 port RS-232 USB to Serial Hub.
> - UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
> - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> - UPort 1150 : 1 port RS-232/42
On Sun, Apr 24, 2016 at 12:08:55PM -0500, Konstantin Shkolnyy wrote:
> A bug in the CRTSCT handling caused RTS to alternate between
> CRTSCTS=0 => "RTS transmits active signal" and
> CRTSCTS=1 => "RTS receives flow control"
> instead of
> CRTSCTS=0 => "RTS is statically active" and
> CRTSCTS=1 => "
On Sun, Apr 24, 2016 at 12:09:10PM -0500, Konstantin Shkolnyy wrote:
> The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
> did it inconsistently. This change is non-functional for existing chips
> because the driver never set the flag and it's clear by default.
>
> Signed-o
On Sun, Apr 24, 2016 at 12:09:21PM -0500, Konstantin Shkolnyy wrote:
> Documented "magic numbers" used in the CRTSCT flag code in terms of
> register bit names from the chip specification.
Documenting these is long overdue. I even started adding defines just to
be able to review the first patch in
On Sun, Apr 24, 2016 at 12:09:30PM -0500, Konstantin Shkolnyy wrote:
> Replaced several register write calls with one, to simplify adding error
> handling.
>
> Signed-off-by: Konstantin Shkolnyy
> ---
> drivers/usb/serial/cp210x.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-
On Sat, Apr 09, 2016 at 01:02:28PM +0200, Julia Lawall wrote:
> The ftdi_sio_quirk structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Now applied, thanks.
Johan
--
To unsubscribe from this list: send the line "unsubscr
On Wed, Apr 20, 2016 at 02:26:58PM -0400, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
>
> Signed-off-by: Javier Martinez Canillas
Now applied, thanks.
Johan
On Mon, Apr 25, 2016 at 06:09:01PM +, Konstantin Shkolnyy wrote:
> I was planning to define all these bits in a separate future patch.
> Would you rather prefer the magic numbers defined before fixing the bugs?
Fixing the RTS bug (patch 1), which is the only "real" bug, should be
done before a
On Wed, Apr 27, 2016 at 08:06:32PM +, Konstantin Shkolnyy wrote:
> > -Original Message-
> > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> > Sent: Tuesday, April 26, 2016 02:26
> > To: Konstantin Shkolnyy
> > Cc: Johan Hovold;
)
USB-serial fixes for v4.6-rc6
Here are some new device ids.
Signed-off-by: Johan Hovold
Jasem Mutlaq (1):
USB: serial: cp210x: add Straizona Focusers device ids
Mike Manning (1):
USB: serial: cp210x: add
On Tue, Apr 26, 2016 at 03:24:53PM +0300, Maksim Salau wrote:
> Hi Johan,
>
> On Sun, 24 Apr 2016 15:36:35 +0200
> Johan Hovold wrote:
>
> > On Mon, Feb 29, 2016 at 04:11:20PM +0300, Maksim Salau wrote:
> > > The adaptor can be found on development
On Thu, Mar 24, 2016 at 10:53:27AM +0300, Valentin Yakovenkov wrote:
> Sorry, I missed the branch.
>
> Here it is.
Thanks for the patch. Please resubmit it on a format that can be applied
(i.e. without quoted text, etc). Remember to include a patch
revision in the Subject when resubmitting patche
On Fri, Apr 15, 2016 at 11:14:04PM +0200, Grigori Goronzy wrote:
> This may fail, do not assume it always works.
>
> Signed-off-by: Grigori Goronzy
> ---
> drivers/usb/serial/ch341.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/serial/ch341.c b/drivers
On Fri, Apr 15, 2016 at 11:14:05PM +0200, Grigori Goronzy wrote:
> BREAK2 seems to be a misnomer, the register configures various aspects
> of the UART configuration.
>
> Signed-off-by: Grigori Goronzy
Finally. Thanks for fixing this. :)
Johan
--
To unsubscribe from this list: send the line "un
On Fri, Apr 15, 2016 at 11:14:06PM +0200, Grigori Goronzy wrote:
No commit message?
> Signed-off-by: Grigori Goronzy
> ---
> drivers/usb/serial/ch341.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
> index 1ab
On Fri, Apr 15, 2016 at 11:14:07PM +0200, Grigori Goronzy wrote:
> Use the correct types and sizes.
>
> v2: use u8 shorthand for unsigned char.
Pleas place commit logs below the cut-off line (---).
> Signed-off-by: Grigori Goronzy
> ---
> drivers/usb/serial/ch341.c | 10 +-
> 1 file ch
On Fri, Apr 15, 2016 at 11:14:08PM +0200, Grigori Goronzy wrote:
> Changing the LCR register after initialization does not seem to be
> reliable on all chips (particularly not on CH341A). Restructure
> initialization and configuration to always reinit the chip on
> configuration changes instead an
On Fri, Apr 15, 2016 at 11:14:09PM +0200, Grigori Goronzy wrote:
> With the new reinitialization method, configuring parity, different
> frame lengths and different stop bit settings work as expected on
> both CH340G and CH341A. This has been extensively tested with a
> logic analyzer.
>
> v2: on
On Fri, Apr 15, 2016 at 11:14:10PM +0200, Grigori Goronzy wrote:
> There are at least two hardware revisions, this may be helpful in
> case compatibility issues need to be debugged.
>
> Signed-off-by: Grigori Goronzy
> ---
> drivers/usb/serial/ch341.c | 1 +
> 1 file changed, 1 insertion(+)
>
>
On Fri, Apr 15, 2016 at 11:14:11PM +0200, Grigori Goronzy wrote:
No commit message?
> v2: use correct flag variable.
> v3: fix compilation
>
> Signed-off-by: Grigori Goronzy
> ---
> drivers/usb/serial/ch341.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/usb/se
On Fri, Apr 15, 2016 at 11:14:12PM +0200, Grigori Goronzy wrote:
> No functional change. The following adjustments were made to be more in
> line with official coding style and to be more consistent.
>
> Stop mixing tabs and spaces for alignment. Stop putting labels and
> statements into the sam
On Fri, Apr 15, 2016 at 11:14:13PM +0200, Grigori Goronzy wrote:
> No functional change. Remove explicit function name printing, it's
> easy to use dynamic debug to print it every time, if required.
While that is true, we currently use __func__ in a lot of debug messages
as a compact form for a s
On Fri, Apr 15, 2016 at 11:14:14PM +0200, Grigori Goronzy wrote:
> Check for B0 in a more idiomatic way and make sure to not enable
> RTS/CTS hardware flow control in B0 as it may override the control
> lines. Also make sure to only enable RTS/DTR if there's a transition
> from B0.
Ah, here it is
On Fri, Apr 15, 2016 at 11:14:16PM +0200, Grigori Goronzy wrote:
> The status bit was found with USB captures of the Windows driver and
> some luck. Tested on CH340G and CH341A.
>
> v2: unify general status definitions
>
> Signed-off-by: Grigori Goronzy
Looks good too.
Thanks for doing all th
On Fri, Apr 15, 2016 at 11:14:15PM +0200, Grigori Goronzy wrote:
> If the serial port hasn't been opened yet, no baud rate should be
> set and RTS/DTR need to be deasserted.
But what about reset_resume?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the b
On Fri, Apr 29, 2016 at 04:37:49PM +, Konstantin Shkolnyy wrote:
> > -Original Message-
> > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> > Sent: Friday, April 29, 2016 05:09
> > To: Valentin Yakovenkov
> > Cc: Konstantin Shkol
# 4.5
Signed-off-by: Johan Hovold
---
Greg, Alan,
This patch for v4.6-rc7 fixes a 4.5-regression that broke system suspend
for a large class of devices, including USB-serial devices, for example
when USB persist is enabled.
We may be able to find a way around this, but since it's a
On Fri, Apr 29, 2016 at 05:11:13PM +0200, Grigori Goronzy wrote:
> On 2016-04-29 14:16, Johan Hovold wrote:
> > On Fri, Apr 15, 2016 at 11:14:04PM +0200, Grigori Goronzy wrote:
> >> This may fail, do not assume it always works.
> >>
> >> Signed-off-by: Grigori
On Mon, May 02, 2016 at 11:13:10AM -0400, Alan Stern wrote:
> On Mon, 2 May 2016, Johan Hovold wrote:
>
> > This reverts commit e3345db85068ddb937fc0ba40dfc39c293dad977, which
> > broke system resume for a large class of devices.
> >
> > Devices that after having be
On Mon, May 02, 2016 at 08:37:15PM +0200, Mathieu OTHACEHE wrote:
> Hi Johan,
>
> Thanks for your review.
>
> > Looks like this code could use a few vid/pid temporaries.
>
> > I'm not sure it makes sense to try to load a "ti_usb-v110a-p1150.fw"
> > firmware before requesting the moxa firmware. A
On Fri, Apr 29, 2016 at 08:51:06AM +, Schemmel Hans-Christoph wrote:
> Added support for Gemalto's Cinterion PH8 and AHxx products
> with 2 RmNet Interfaces and products with 1 RmNet + 1 USB Audio interface.
>
> In addition some minor renaming and formatting.
>
> Signed-off-by: Hans-Christoph
On Sat, Apr 30, 2016 at 09:49:38AM -0500, Konstantin Shkolnyy wrote:
> Replaced magic numbers used in the CRTSCTS flag code with symbolic names
> from the chip specification.
>
> Signed-off-by: Konstantin Shkolnyy
> ---
> v3:
> Regenerated the patches correctly against the latest usb-next branch.
On Tue, May 03, 2016 at 12:11:53PM +, Konstantin Shkolnyy wrote:
> > -Original Message-
> > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > ow...@vger.kernel.org] On Behalf Of David Laight
> > Sent: Tuesday, May 03, 2016 04:44
> > To: 'Konstantin Shkolnyy'; jo...@kernel.org
On Wed, Jan 25, 2017 at 10:21:59PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 25, 2017 at 06:22:53PM +0100, Johan Hovold wrote:
> > Clean up the ioctl handler and make sure to pass an unsigned-int rather
> > than serial_struct pointer to the TIOCSERGETLSR helper as this it wh
On Wed, Jan 25, 2017 at 11:40:40PM +0300, Maksim Salau wrote:
> The adaptor can be found on development boards for 78k, RL78 and V850
> microcontrollers produced by Renesas Electronics Corporation.
>
> This is not a full-featured USB to serial converter, however it allows
> basic communication and
5d03a2fd2292e71936c4235885c35ccc3c94695b:
USB: serial: option: add device ID for HP lt2523 (Novatel E371) (2017-01-24
12:07:28 +0100)
USB-serial fixes for v4.10-rc6
Just a couple of new device ids.
Signed-off-by: Johan Hovold
Use the port device rather than usb device in info and error messages.
This makes sure that driver and tty port is included in the messages,
while also making them more uniform.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 16 ++--
1 file changed, 6 insertions
Return -ENODEV rather than -EINVAL on probe errors due to a missing
endpoint.
Also clean up the endpoint sanity check somewhat and use the interface
device for logging a more compact error in case an expected endpoint is
missing.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c
Remove redundant check of num_interrupt_in which has already been
verified in probe (killing a NULL-urb would also have been fine).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c b
On Tue, Jan 31, 2017 at 03:35:54PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 31, 2017 at 11:51:07AM +0100, Johan Hovold wrote:
> > Return -ENODEV rather than -EINVAL on probe errors due to a missing
> > endpoint.
> >
> > Also clean up the endpoint sanity check som
Make sure the received data has the required headers before parsing it.
Also drop the redundant urb-status check, which has already been handled
by the caller.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold
---
drivers/usb/serial/digi_accelep
ot;)
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable # v2.6.30
Signed-off-by: Johan Hovold
---
drivers/usb/serial/digi_acceleport.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/digi_acceleport.c
b/drivers/usb/serial/dig
Make sure to check for short transfers before parsing the receive buffer
to avoid acting on stale data.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletion
On Mon, Jan 30, 2017 at 07:26:40PM +0100, Marcel J.E. Mol wrote:
>
> Seems that ATEN serial-to-usb devices using pl2303 exist with
> different device ids. This patch adds a missing device ID so it
> is recognised by the driver.
>
> Signed-off-by: Marcel J.E. Mol
> ---
Thanks for the patch. I dr
On Tue, Jan 31, 2017 at 05:38:58PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 31, 2017 at 05:17:27PM +0100, Johan Hovold wrote:
> > Make sure to check for short transfers to avoid underflow in a loop
> > condition when parsing the receive buffer.
> >
> > Also fix
On Tue, Jan 31, 2017 at 05:41:52PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 31, 2017 at 05:17:28PM +0100, Johan Hovold wrote:
> > Make sure the received data has the required headers before parsing it.
> >
> > Also drop the redundant urb-status check, which has alread
On Tue, Jan 31, 2017 at 05:55:17PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 31, 2017 at 05:46:02PM +0100, Johan Hovold wrote:
> > On Tue, Jan 31, 2017 at 05:41:52PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 31, 2017 at 05:17:28PM +0100, Johan Hovold wrote:
>
reported and NULL-characters inserted until
further data is received.
Reported-by: Michael Walle
Fixes: 72fda3ca6fc1 ("USB: serial: ftd_sio: implement sysrq handling on
break")
Fixes: 166ceb690750 ("USB: ftdi_sio: clean up line-status handling")
Cc: stable # v2.6.35
Signed-
On Wed, Jun 29, 2016 at 11:59:06PM +0200, Michael Walle wrote:
> Am 2016-05-27 20:02, schrieb Johan Hovold:
> > On Fri, May 13, 2016 at 12:17:24PM +0200, mich...@walle.cc wrote:
> >> Hi,
> >>
> >> if the internal buffer is full, a read() returns a steady
On Fri, Feb 03, 2017 at 09:11:15AM +0800, Ken Lin wrote:
> Add new USB IDs for cp2104/5 devices on Bx50v3 boards due to the design change
>
> Signed-off-by: Ken Lin
Thanks for the patch. Looks good except that your author (From) address
doesn't match your SoB. Please fix that up and resend.
Tha
: Johan Hovold
Marcel J.E. Mol (1):
USB: serial: pl2303: add ATEN device ID
drivers/usb/serial/pl2303.c | 1 +
drivers/usb/serial/pl2303.h | 1 +
2 files changed, 2 insertions(+)
--
To unsubscribe from this list: send the
On Sat, Feb 04, 2017 at 04:00:24AM +0800, Ken Lin wrote:
> Add new USB IDs for cp2104/5 devices on Bx50v3 boards due to the design change
>
> Signed-off-by: Ken Lin
> ---
> Change in v2:
> Fix the author (From) address doesn't match the SoB issue mentioned in the
> discussion thread
Now applied
On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote:
> On 17-02-06 09:28:22, Greg KH wrote:
> > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote:
> > > Random thought: isn't it better to add the alloc/free code in
> > > usb_control_msg() and avoid code duplication all over
On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote:
> On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote:
> > On 17-02-06 09:28:22, Greg KH wrote:
> > > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote:
>
> > > > Random thought:
On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote:
> On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote:
> > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote:
> > > On 17-02-06 09:28:22, Greg KH wrote:
> > > > On Mon, Feb 06, 2
river interface blacklisting")
Signed-off-by: Johan Hovold
---
drivers/usb/serial/sierra.c | 28 +---
1 file changed, 5 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index e1994e264cc0..465e851b2815 100644
--- a/d
On Mon, Feb 06, 2017 at 05:33:29PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 04:28:14PM +0100, Johan Hovold wrote:
> > Interface numbers do not change when enabling alternate settings as
> > comment and code in this driver suggested.
> >
> > Remov
These patches clean up the metro-usb driver somewhat by removing
redundant code and some unnecessary dev_dbgs.
Johan
Johan Hovold (4):
USB: serial: metro-usb: drop unused interrupt-out callback
USB: serial: metro-usb: drop redundant URB unlink
USB: serial: metro-usb: drop function-tracing
No need to reinitialise the interrupt-in URB with values that have not
changed before (some) resubmissions.
This also allows the interrupt-in callback to have a single path for URB
resubmission.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 20 ++--
1 file
Drop some unnecessary debug printks.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index b0c7746438df..f220a470197a 100644
--- a/drivers/usb/serial
Drop the unused interrupt-out callback.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index 39e683096e94..4f7cd30b5424 100644
--- a/drivers/usb/serial
Drop redundant URB unlink as there's no need to unlink an URB which is
about to be killed synchronously.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote:
> On 02/08/17 14:02, Greg KH wrote:
> > On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote:
> >> On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the
> >> connected USB mouse disconnects and connects again
On Wed, Feb 08, 2017 at 05:41:33PM +0100, Paul Menzel wrote:
> On 02/08/17 16:50, Johan Hovold wrote:
> > On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote:
> >> On 02/08/17 14:02, Greg KH wrote:
> >>> On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wr
pointers are stored in an array that is a member
of the serial struct so the address of the first member of the array
(which the array name decays to) is never NULL either.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/console.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
e sure to initialise the new lock also for the fake tty to address
this regression.
Yes, this code is a mess, but cleaning it up is left for another day.
Fixes: 4a510969374a ("tty: Make tty_files_lock per-tty")
Cc: stable # 4.6
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cons
Testing a simple clean-up patch resulted in a lockdep splat, which
turned out to be due to an uninitialised spin lock after a tty change
that went into 4.6. Makes you wonder how many people actually use this
code...
Johan
Johan Hovold (2):
USB: serial: console: fix uninitialised spinlock
On Wed, Feb 08, 2017 at 07:05:50PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 08, 2017 at 01:49:19PM +0100, Johan Hovold wrote:
> > No need to reinitialise the interrupt-in URB with values that have not
> > changed before (some) resubmissions.
> >
> > This a
401 - 500 of 3156 matches
Mail list logo
