Re: ftdi_sio bug: setting two custom baud rates in a row fails

2016-01-01 Thread Johan Hovold
On Thu, Dec 31, 2015 at 04:38:29PM -0500, Edwin Olson wrote: > Hi, > > When setting custom baud rates with the ftdi_sio module using "method > #3" (setting the custom_divisor via TIOCSSERIAL), subsequent changes > to *another custom baud rate* do not take effect. For example, if I > change from

Re: [PATCH] usb: serial: return -ENODEV if disconnected during TIOCMIWAIT

2016-01-03 Thread Johan Hovold
On Mon, Dec 21, 2015 at 02:17:22PM +0100, Oliver Neukum wrote: > Disconnecting a device is not just a hang up. The device is gone. > We should tell user space the truth immediately. I'm not sure about this one. The usb-serial drivers have always returned -EIO on hangup, whatever the reason, and th

Re: [PATCH 1/3] USB: mxu11x0: fix memory leak on usb_serial private data

2016-01-03 Thread Johan Hovold
On Sun, Jan 03, 2016 at 03:25:59PM +0100, Mathieu OTHACEHE wrote: > On nominal execution, private data allocated on port_probe and attach > are never freed. Add port_remove and release callbacks to free them > respectively. Ouch. I thought I'd vetted the driver for further memleaks but apparently

Re: [PATCH 2/3] USB: mxu11x0: clean device control commands

2016-01-03 Thread Johan Hovold
On Sun, Jan 03, 2016 at 03:26:00PM +0100, Mathieu OTHACEHE wrote: > Sending OPEN and START commands twice is not necessary for this driver. > Also send STOP command at close. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/mxu11x0.c | 31 +++ > 1 file c

Re: [PATCH 3/3] USB: mxu11x0: move firmware download and endpoint testing to probe callback

2016-01-03 Thread Johan Hovold
On Sun, Jan 03, 2016 at 03:26:01PM +0100, Mathieu OTHACEHE wrote: > Move interrupt in endpoint test and firmware download to a new probe > callback. This avoids unnecessary memory allocations done by core > before port_probe callback is called. > > If the device has to be reseted (firmware downloa

Re: [PATCH V7 1/1] usb:serial: Add Fintek F81532/534 driver

2016-01-03 Thread Johan Hovold
On Wed, Dec 02, 2015 at 03:18:59PM +0800, Peter Hung wrote: > This driver is for Fintek F81532/F81534 USB to Serial Ports IC. Do you have a pointer to datasheets and/or information about these devices? Can't seem to find anything on Fintek's homepage. > Features: > 1. F81534 is 1-to-4 & F81532 is

Re: [PATCH] usb: serial: return -ENODEV if disconnected during TIOCMIWAIT

2016-01-04 Thread Johan Hovold
On Mon, Jan 04, 2016 at 09:09:55AM +0100, Oliver Neukum wrote: > On Sun, 2016-01-03 at 17:22 +0100, Johan Hovold wrote: > > On Mon, Dec 21, 2015 at 02:17:22PM +0100, Oliver Neukum wrote: > > > Disconnecting a device is not just a hang up. The device is gone. > > > We

Re: ftdi_sio bug: setting two custom baud rates in a row fails

2016-01-04 Thread Johan Hovold
On Sun, Jan 03, 2016 at 06:11:07PM -0500, Edwin Olson wrote: > Hi Johan et al, > > Now that I understand the behavior, and know how to work-around the > issue, I won't press too hard for functionality changes. But perhaps > the documentation can be improved by suggesting that the custom > divisor

Re: [PATCH] USB: cp210x: add ID for IAI USB to RS485 adaptor

2016-01-25 Thread Johan Hovold
On Fri, Jan 08, 2016 at 01:06:47PM +0100, Johan Hovold wrote: > On Fri, Jan 08, 2016 at 12:34:41PM +0100, Peter Dedecker wrote: > > Added the USB serial console device ID for IAI Corp. RCB-CV-USB > > USB to RS485 adaptor. > > > > Signed-off-by: Peter Dedecker >

Re: [PATCH] USB: visor: fix null-deref at probe

2016-01-25 Thread Johan Hovold
On Tue, Jan 12, 2016 at 12:05:20PM +0100, Johan Hovold wrote: > Fix null-pointer dereference at probe should a (malicious) Treo device > lack the expected endpoints. > > Specifically, the Treo port-setup hack was dereferencing the bulk-in and > interrupt-in urbs without first makin

Re: [PATCH v3] usb: serial: visor: fix crash on detecting device without write_urbs

2016-01-25 Thread Johan Hovold
On Tue, Jan 12, 2016 at 03:10:50PM +0100, Vladis Dronov wrote: > The visor driver crashes in clie_5_attach() when a specially crafted USB > device without bulk-out endpoint is detected. This fix adds a check that > the device has proper configuration expected by the driver. > > Reported-by: Ralf S

Re: [PATCH 1/1] usb: serial: option: Adding support for Telit LE922

2016-01-25 Thread Johan Hovold
On Tue, Jan 12, 2016 at 05:22:06PM +0100, Daniele Palmas wrote: > This patch adds support for two PIDs of LE922. > > Signed-off-by: Daniele Palmas Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

Re: [PATCH] USB: serial: ftdi_sio: add support for Yaesu SCU-18 cable

2016-01-25 Thread Johan Hovold
On Tue, Jan 19, 2016 at 11:43:13PM -0800, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > Harald Linden reports that the ftdi_sio driver works properly for the > Yaesu SCU-18 cable if the device ids are added to the driver. So let's > add them. > > Reported-by: Harald Linden > Cc: sta

Re: [PATCH] USB: option: add support for SIM7100E

2016-01-25 Thread Johan Hovold
On Wed, Jan 20, 2016 at 03:05:56PM +0300, Andrey Skvortsov wrote: > $ lsusb: > Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option > > $ usb-devices: > T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=101 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 2 > P: Vendor=1e0e

Re: [PATCH] usb: option.c: Fix Cinterion AHxx enumeration.

2016-01-25 Thread Johan Hovold
[ Please avoid top-posting. ] On Thu, Jan 07, 2016 at 08:52:38AM +, John Ernberg wrote: > Hi Johan, > > Apologies for the late reply, I was out of office. > > Below is the 'lsusb -v' output for the AH3 modem. Thanks for the info. I believe your fix is the right one, but it seems you forgot

Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data

2016-01-25 Thread Johan Hovold
On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote: > On nominal execution, private data allocated on port_probe and attach > are never freed. Add port_remove and release callbacks to free them > respectively. > > Signed-off-by: Mathieu OTHACEHE I've applied this one for 4.5-rc2 no

Re: [PATCH v2 1/1] usb: option.c: Fix Cinterion AHxx enumeration.

2016-01-25 Thread Johan Hovold
On Mon, Jan 25, 2016 at 12:27:17PM +, John Ernberg wrote: > From: John Ernberg > > In certain kernel configurations where the cdc_ether and option drivers > are compiled as modules there can occur a race condition in enumeration. > This causes the option driver to enumerate the ethernet(wwan)

[GIT PULL] USB-serial fixes for v4.5-rc2

2016-01-28 Thread Johan Hovold
es of crashes in the visor driver that could be triggered using bad (malicious) descriptors, a fix for two memory leaks in the new mxu11x0 driver, and an interface-blacklist fix for the option driver. Included are also some new device ids. Signed-off-by: Johan H

Re: [PATCH v4] USB: serial: cp210x: Adding GPIO support for CP2105

2016-01-31 Thread Johan Hovold
On Mon, Jan 18, 2016 at 02:14:37PM +, Martyn Welch wrote: > This patch adds support for the GPIO found on the CP2105. Unlike the GPIO > provided by some of the other devices supported by the cp210x driver, the > GPIO on the CP2015 is muxed on pins otherwise used for serial control > lines. The

Re: [PATCH v2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-01-31 Thread Johan Hovold
On Thu, Jan 14, 2016 at 10:23:11AM +, Martyn Welch wrote: > On 14/01/16 00:27, Konstantin Shkolnyy wrote: > >> static struct usb_serial_driver cp210x_device = { > >> @@ -219,6 +229,7 @@ static struct usb_serial_driver cp210x_device = { > >>.tx_empty = cp210x_tx_empty, > >>

Re: [PATCH v1 1/1] cp210x: convert open coded pieces to DIV_ROUND_UP

2016-01-31 Thread Johan Hovold
On Tue, Jan 19, 2016 at 01:31:18PM +0200, Andy Shevchenko wrote: > There are places where DIV_ROUND_UP() functionaly is open coded. Replace it by > macro call. > > Signed-off-by: Andy Shevchenko Thanks for the patch. Konstantin has been working on a series that cleans up the accessor functions

Re: [PATCH 00/14] USB: serial: Fix coccinelle warnings

2016-01-31 Thread Johan Hovold
On Sat, Jan 30, 2016 at 06:44:33PM +0100, Mathieu OTHACEHE wrote: > This series of patches fixes all coccinelle warnings in > USB serial subsystem > > Mathieu OTHACEHE (14): > USB: serial: safe_serial: fix assignment of bool to 0/1 > USB: serial: safe_serial: fix assignment of bool to non 0/1

Re: [PATCH v2] USB: option: add support for SIM7100E

2016-01-31 Thread Johan Hovold
On Fri, Jan 29, 2016 at 12:07:30AM +0300, Andrey Skvortsov wrote: > $ lsusb: > Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option > > $ usb-devices: > T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=101 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 2 > P: Vendor=1e0e

Re: [PATCH v2] USB: option: add support for SIM7100E

2016-02-18 Thread Johan Hovold
On Sun, Jan 31, 2016 at 09:13:19PM +0100, Johan Hovold wrote: > On Fri, Jan 29, 2016 at 12:07:30AM +0300, Andrey Skvortsov wrote: > > $ lsusb: > > Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option > > > > $ usb-devices: > > T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=0

Re: [PATCH] USB: cp210x: add IDs for GE B650V3 and B850V3 boards

2016-02-18 Thread Johan Hovold
On Mon, Feb 01, 2016 at 02:57:25PM -0500, Akshay Bhat wrote: > From: Ken Lin > > Add USB ID for cp2104/5 devices on GE B650v3 and B850v3 boards. > > Signed-off-by: Ken Lin > Signed-off-by: Akshay Bhat Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe lin

Re: Spansion's CMSIS-DAP + COM Port

2016-02-18 Thread Johan Hovold
[ +CC: Oliver ] On Tue, Feb 09, 2016 at 09:27:39PM +0530, Thorsten Wilmer wrote: > Hi, > > I have a Starter Kit SK-FM4-176L-S6SE2CC > modprobe usbserial vendor=0x1a6a product=0x2000 > > makes the USB Port appear nicely (works with gtkterm) and at the same > time one can use the CMIS-DAP adapte

Re: [PATCH] USB: option: add "4G LTE usb-modem U901"

2016-02-18 Thread Johan Hovold
On Fri, Feb 12, 2016 at 04:40:00PM +0100, Bjørn Mork wrote: > Thomas reports: > > T: Bus=01 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 4 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=05c6 ProdID=6001 Rev=00.00 > S: Manufacturer=USB Modem > S: Product=USB

[GIT PULL] USB-serial fixes for v4.5-rc5

2016-02-19 Thread Johan Hovold
device ids. Signed-off-by: Johan Hovold Andrey Skvortsov (1): USB: option: add support for SIM7100E Bjørn Mork (1): USB: option: add "4G LTE usb-modem U901" Ken Lin (1): USB: cp210x: add IDs for GE B650

Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data

2016-02-28 Thread Johan Hovold
On Sat, Jan 30, 2016 at 06:40:30PM +0100, Mathieu OTHACEHE wrote: > On Mon, Jan 25, 2016 at 01:01:59PM +0100, Johan Hovold wrote: > > On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote: > > > On nominal execution, private data allocated on port_probe and attach >

Re: [PATCH v4] USB: serial: cp210x: Adding GPIO support for CP2105

2016-02-28 Thread Johan Hovold
On Mon, Feb 01, 2016 at 12:43:12PM +, Martyn Welch wrote: > On 31/01/16 19:54, Johan Hovold wrote: > > On Mon, Jan 18, 2016 at 02:14:37PM +, Martyn Welch wrote: > >> This patch adds support for the GPIO found on the CP2105. Unlike the GPIO > >> provided b

Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

2016-02-28 Thread Johan Hovold
On Mon, Feb 01, 2016 at 01:37:33PM +0100, Bjørn Mork wrote: > Mathieu OTHACEHE writes: > > On Sun, Jan 31, 2016 at 10:33:54PM +0100, Bjørn Mork wrote: > > > >> I feel I'm missing something here, so I have to ask the stupid question: > >> What could possibly be the benefit here? Is it faster? Safe

Re: [PATCH v2 1/4] USB: serial: fix compare_const_fl.cocci warnings

2016-02-28 Thread Johan Hovold
On Thu, Feb 04, 2016 at 07:01:27PM +0100, Mathieu OTHACEHE wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Mathieu OTHACEHE > --- > Move constants to the right improve readability in my opinion. > But i

Re: [PATCH v2 4/4] USB: serial: fix semicolon.cocci warnings

2016-02-28 Thread Johan Hovold
On Thu, Feb 04, 2016 at 07:01:30PM +0100, Mathieu OTHACEHE wrote: > Remove unneeded semicolons. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Signed-off-by: Mathieu OTHACEHE > --- Rest of the series now applied as well. Thanks, Johan -- To unsubscribe from this list: send the l

Re: [PATCH] Support HP lt4114 LTE Module (Huawei ME206V-561)

2016-02-28 Thread Johan Hovold
On Fri, Feb 19, 2016 at 12:02:04AM -0800, Daniel Patrick Johnson wrote: > Adds HP lt4114 LTE module USB ID as a Huawei device. > > Currently 4 ttyUSB devices are detected, but only the second two respond to > AT commands. The first two serial ports may be falsely detected. > > Of the two responsi

Re: ftdi_sio: ftdi_set_termios

2016-02-28 Thread Johan Hovold
On Fri, Feb 19, 2016 at 01:55:34PM +0300, Matwey V. Kornilov wrote: > Dear Bill and all, > > I am facing an issue with ftdi_sio module and FTDI FT232-based > devices. Now I am trying to understand where the origin is. > By indirect evidences, I think that there is a small time gap between > return

Re: [PATCH] Add Dell Wireless 5809e Gobi 4G HSPA+ Mobile Broadband Card (rev3) to qcserial

2016-02-28 Thread Johan Hovold
On Sat, Feb 20, 2016 at 06:49:56PM +0100, Patrik Halfar wrote: > New revison of Dell Wireless 5809e Gobi 4G HSPA+ Mobile Broadband Card has > new idProduct Next time make sure to wrap your commit messages at around 72 cols or so, and also include a "USB: qcserial:" prefix to a shortened patch sum

Re: [PATCH 1/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045

2016-02-28 Thread Johan Hovold
On Fri, Feb 26, 2016 at 01:35:27PM +0100, Daniele Palmas wrote: > This patch adds support for 0x1045 PID of Telit LE922. > > Signed-off-by: Daniele Palmas > --- > drivers/usb/serial/option.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/u

Re: [PATCH v4 1/3 RESEND] USB: serial: cp210x: New 16-bit register access functions.

2016-02-28 Thread Johan Hovold
> --- > change in v4: Instead of adding all new functions a one separate patch, added > them with patches that actually start using them. Also amended the cp210x_open > change as directed by Johan Hovold. > > change in v3: Presented new function addition as a separate patch #1

Re: [PATCH v2] USB: cp210x: Add ID for Parrot NMEA GPS Flight Recorder

2016-02-28 Thread Johan Hovold
On Sun, Feb 28, 2016 at 02:40:24PM +0100, Vittorio Alfieri wrote: > The Parrot NMEA GPS Flight Recorder is a USB composite device > consisting of hub, flash storage, and cp210x usb to serial chip. > It is an accessory to the mass-produced Parrot AR Drone 2. > The device emits standard NMEA messages

Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data

2016-02-29 Thread Johan Hovold
On Sun, Feb 28, 2016 at 05:30:54PM +0100, Mathieu OTHACEHE wrote: > On Sun, Feb 28, 2016 at 01:20:16PM +0100, Johan Hovold wrote: > So, I could post a patch serie : > > 1. Removing mxu11x0 driver > 2. Patching ti_usb_3410_5052 > 3. Cleaning up ti_usb_3410_5052 the same as we

Re: [PATCH v2] USB: cp210x: Add ID for Parrot NMEA GPS Flight Recorder

2016-02-29 Thread Johan Hovold
On Sun, Feb 28, 2016 at 05:51:23PM +0100, Vittorio Alfieri wrote: > On Sun, Feb 28, 2016 at 05:23:17PM +0100, Johan Hovold wrote: > > On Sun, Feb 28, 2016 at 02:40:24PM +0100, Vittorio Alfieri wrote: > > > The Parrot NMEA GPS Flight Recorder is a USB composite device > > &g

Re: [PATCH v5 3/3] USB: serial: cp210x: New access functions for large registers

2016-02-29 Thread Johan Hovold
On Sun, Feb 28, 2016 at 03:51:56PM -0600, Konstantin Shkolnyy wrote: > cp210x_get_config and cp210x_set_config are cumbersome to use. This change > switches large register access to use new block functions. The old > functions are removed because now they become unused. > > Signed-off-by: Konstant

[PATCH] Revert "USB: serial: add Moxa UPORT 11x0 driver"

2016-02-29 Thread Johan Hovold
he mxu11x0 driver, add support for these Moxa devices to the TI driver, and then clean that driver up instead. Signed-off-by: Johan Hovold --- drivers/usb/serial/Kconfig | 16 - drivers/usb/serial/Makefile |1 - drivers/usb/serial/mxu11x0.c | 1006 -

Re: [PATCH v2 1/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045

2016-02-29 Thread Johan Hovold
On Mon, Feb 29, 2016 at 03:36:11PM +0100, Daniele Palmas wrote: > This patch adds support for 0x1045 PID of Telit LE922. > > Signed-off-by: Daniele Palmas Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vge

Re: [PATCH v2] USB: serial: option: add support for Quectel UC20

2016-02-29 Thread Johan Hovold
On Mon, Feb 29, 2016 at 04:39:57PM +0100, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Blacklist the QMI interface. > > Signed-off-by: Yegor Yefremov > --- > Changes: > v2: blacklist QMI interface Now applied with an amended commit message. Thanks, Johan -- To unsubscrib

Re: [PATCH] Revert "USB: serial: add Moxa UPORT 11x0 driver"

2016-03-01 Thread Johan Hovold
On Mon, Feb 29, 2016 at 10:46:51PM +, Greg Kroah-Hartman wrote: > On Mon, Feb 29, 2016 at 06:56:02PM +0100, Johan Hovold wrote: > > This reverts commit 0b2b093ad405b56a9e6f4f20a25da77ebfa9549c. > > > > Turns out the MOXA vendor driver was basically just a copy of the

Re: [PATCH] USB: qcserial: add Sierra Wireless EM74xx device ID

2016-03-02 Thread Johan Hovold
On Tue, Mar 01, 2016 at 02:36:32PM +0100, Bjørn Mork wrote: > The MC74xx and EM74xx modules use different IDs by default, according > to the Lenovo EM7455 driver for Windows. > > Cc: > Signed-off-by: Bjørn Mork Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubsc

Re: pl2303_read_int_callback - usb_submit_urb failed with result -19

2016-07-05 Thread Johan Hovold
On Mon, Jul 04, 2016 at 10:22:04PM +0530, Malith Yapa wrote: > Continuously polling registers with the PL2303 usb serial adapter > eventually results in usb_subimit_urb failed with result -19 (ENODEV) > but reconnects immediately. > occurrences are random. > tried with two different PL2303 devices

Re: pl2303_read_int_callback - usb_submit_urb failed with result -19

2016-07-06 Thread Johan Hovold
he normal tty interface (e.g. through libmodbus) to access some external entity (and its registers). Something is causing the pl2303 device to be reset. Perhaps an electrical issue. > On Tue, Jul 5, 2016 at 6:09 PM Johan Hovold wrote: > > > On Mon, Jul 04, 2016 at 10:22:04PM +0530,

Re: pl2303_read_int_callback - usb_submit_urb failed with result -19

2016-07-06 Thread Johan Hovold
[ +CC: linux-usb, for real this time ;) ] On Wed, Jul 06, 2016 at 02:40:25PM +0530, Malith Yapa wrote: > On Wed, Jul 6, 2016 at 2:13 PM, Johan Hovold wrote: > > [ Please avoid top-posing. ] > > > > On Wed, Jul 06, 2016 at 03:49:15AM +, Malith Yapa wrote: > >>

Re: [PATCH v2 2/5] usb: serial: removing redundant __func__

2016-07-15 Thread Johan Hovold
On Fri, Jul 15, 2016 at 10:45:36AM +0200, Oliver Neukum wrote: > On Fri, 2016-07-15 at 08:14 +0900, Greg KH wrote: > > Doh, nevermind, that's what I get for writing emails early in the > > morning while jet-lagged. > > > > Sorry for the noise, you are correct. > > No problem. Do you want me to re

Re: [PATCH 00/36] usb: serial: ti_usb_3410_5052: clean driver

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:32AM +0200, Mathieu OTHACEHE wrote: > Hi, > > The now reverted mxu11x0 turned out to be a copy of ti_usb_3410_5052 driver. > This aim of this serie is to apply all of the cleanups we did in mxu11x0 to > ti_usb_3410_5052. I apologise for the late review of this one. I

Re: [PATCH 03/36] usb: serial: ti_usb_3410_5052: Remove ti_usb_3410_5052.h

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:35AM +0200, Mathieu OTHACEHE wrote: > The definitions in ti_usb_3410_5052.h are only used in > ti_usb_3410_5052.c. > The content of the header is copied in ti_usb_3410_5052.c. > > Also correct a typo in macro TI_PIPE_MODE_CONTINOUS. > > Signed-off-by: Mathieu OTHACEH

Re: [PATCH 04/36] usb: serial: ti_usb_3410_5052: Use inline functions rather than macro

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 03:00:39PM +0300, Sergei Shtylyov wrote: > Hello. > > On 5/12/2016 11:48 AM, Mathieu OTHACEHE wrote: > > > Inline functions are preferable to macros resembling functions. > > > > Signed-off-by: Mathieu OTHACEHE > > --- > > drivers/usb/serial/ti_usb_3410_5052.c | 16 +

Re: [PATCH 05/36] usb: serial: ti_usb_3410_5052: Remove unused data structures

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:37AM +0200, Mathieu OTHACEHE wrote: > ti_read_data_request, ti_read_data_bytes and ti_interrupt are unused. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 21 - > 1 file changed, 21 deletions(-) > > diff --gi

Re: [PATCH 06/36] usb: serial: ti_usb_3410_5052: Do not use __uX types

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:38AM +0200, Mathieu OTHACEHE wrote: > __uX types should only be used for user-space interactions. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 66 > ++- > 1 file changed, 34 insertions(+), 32 de

Re: [PATCH 07/36] usb: serial: ti_usb_3410_5052: Remove closing_wait module parameter

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:39AM +0200, Mathieu OTHACEHE wrote: > Closing wait delay is configurable per device using TIOCSSERIAL. Please try to make the commit messages self-contained and not rely on the commit summary to make sense. > Also initialise tty_port closing_wait in port_probe with d

Re: [PATCH 08/36] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:40AM +0200, Mathieu OTHACEHE wrote: > Remove useless or redundant dev_dbg messages. > Fix debug-message typos. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 28 +--- > 1 file changed, 9 insertions(+), 19

Re: [PATCH 12/36] usb: serial: ti_usb_3410_5052: Use generic read/write callbacks

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:44AM +0200, Mathieu OTHACEHE wrote: > Remove read_bulk_callback, write_bulk_callback, write, write_room, > chars_in_buffer, throttle and unthrottle callbacks who uselessly > reimplements generic functions. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/seri

Re: [PATCH 16/36] usb: serial: ti_usb_3410_5052: Use bulk_out_size in TIOCGSERIAL

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:48AM +0200, Mathieu OTHACEHE wrote: > Use bulk_out_size instead of recalculate it with kfifo_size > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/

Re: [PATCH 17/36] usb: serial: ti_usb_3410_5052: Remove useless tty_wakeup

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:49AM +0200, Mathieu OTHACEHE wrote: > The generic driver doesn't call tty_wakeup in > usb_serial_generic_msr_changed so this tty_wakeup seems useless. While we strive to have the generic implementation as complete as possible, it not doing something does not mean it m

Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:50AM +0200, Mathieu OTHACEHE wrote: > Remove useless ti_device pointer, and change addr to u32. > Move function upper to avoid function prototyping. That's just noise. Having an occasional prototype is just fine. You may want to consider reordering functions for the f

Re: [PATCH v2 2/5] usb: serial: removing redundant __func__

2016-07-15 Thread Johan Hovold
On Fri, Jul 15, 2016 at 08:26:25PM +0900, Greg Kroah-Hartman wrote: > On Fri, Jul 15, 2016 at 08:14:26PM +0900, Greg KH wrote: > > On Fri, Jul 15, 2016 at 12:40:45PM +0200, Oliver Neukum wrote: > > > On Fri, 2016-07-15 at 11:35 +0200, Johan Hovold wrote: > > > > whi

Re: [PATCH 21/36] usb: serial: ti_usb_3410_5052: Use generic close function

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:53AM +0200, Mathieu OTHACEHE wrote: > Use usb_serial_generic_close in close callback. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb

Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial_info function arguments

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:54AM +0200, Mathieu OTHACEHE wrote: > It is sufficient to pass usb_serial_port structure to ti_get_serial_info > and ti_set_serial_info. > > Also move functions above ioctl to avoid function prototyping > and use unsigned int instead of unsigned for cwait variable. A

Re: [PATCH 24/36] usb: serial: ti_usb_3410_5052: Use usb_serial_generic_open

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:56AM +0200, Mathieu OTHACEHE wrote: > Use usb_serial_generic_open in open callback to start read urb. > Also remove useless usb_device pointer. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 21 - > 1 file cha

Re: [PATCH 25/36] usb: serial: ti_usb_3410_5052: Check old_termios parameter in set_termios

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:48:57AM +0200, Mathieu OTHACEHE wrote: > The old_termios parameter is never used in set_termios callback. There we go. :) > Add a check to old_termios to see if we can return right away because > there is nothing to change. > Add a check to old_termios CBAUD to see if w

Re: [PATCH 35/36] usb: serial: ti_usb_3410_5052: Remove function prototypes

2016-07-15 Thread Johan Hovold
On Thu, May 12, 2016 at 10:49:07AM +0200, Mathieu OTHACEHE wrote: > Declare functions in a the right order to avoid prototyping. > There is no functional change here. I'm not sure this is needed. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH 00/36] usb: serial: ti_usb_3410_5052: clean driver

2016-07-15 Thread Johan Hovold
On Fri, Jul 15, 2016 at 12:48:25PM +0200, Johan Hovold wrote: > On Thu, May 12, 2016 at 10:48:32AM +0200, Mathieu OTHACEHE wrote: > > Hi, > > > > The now reverted mxu11x0 turned out to be a copy of ti_usb_3410_5052 driver. > > This aim of this serie is to apply al

Re: [PATCH] USB: serial: cp210x: use kmemdup

2016-07-15 Thread Johan Hovold
On Thu, May 19, 2016 at 07:34:36PM +0530, Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. > > Signed-off-by: Muhammad Falak R Wani Now applied, thank

Re: [PATCH 1/1] USB: serial: option: add support for Telit LE910 PID 0x1206

2016-07-15 Thread Johan Hovold
On Mon, Jun 06, 2016 at 12:38:17PM +0200, Daniele Palmas wrote: > This patch adds support for 0x1206 PID of Telit LE910. > > Since the interfaces positions are the same than the ones for > 0x1043 PID of Telit LE922, telit_le922_blacklist_usbcfg3 is used. > > Signed-off-by: Daniele Palmas Now ap

Re: [PATCH v2 1/5] usb: serial: use variable for status

2016-07-15 Thread Johan Hovold
On Thu, Jul 14, 2016 at 03:01:40PM +0200, Oliver Neukum wrote: > This patch turns status in a variable read once from the URB. > The long term plan is to deliver status to the callback. > In addition it makes the code a bit more elegant. > > Signed-off-by: Oliver Neukum I've applied this one, an

[GIT PULL] USB-serial updates for v4.8-rc1

2016-07-25 Thread Johan Hovold
- USB-serial updates for v4.8-rc1 Mostly clean ups, including the first few patches of a major overhaul of the ti_usb_3410_5052 driver. Included is also a new option-driver device id. Signed-off-by: Johan Hovold Daniele Palm

Re: [PATCH] USB: serial: option: add D-Link DWM-156/A3

2016-08-08 Thread Johan Hovold
On Sun, Jul 24, 2016 at 01:53:30PM +0200, Lubomir Rintel wrote: > The device has three interfaces; the three serial ports ought to be I assumed you meant "four interfaces" above and updated the commit message before applying. > handled by this driver: > > 00 Diagnostic interface serial port > 01

Re: [PATCH] USB: ftdi_sio: Added custom PIDs for Ivium Technologies electrochemical interface products

2016-08-08 Thread Johan Hovold
On Thu, Jul 28, 2016 at 06:52:55PM +, Robert Deliën wrote: > Ivium Technologies uses the FTDI VID with custom PIDs for their line of > electrochemical interfaces and the PalmSens they developed for PalmSens BV. > > PIDs are kept in numerical order, entries in id_table_combined[] are at > the s

Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

2016-08-08 Thread Johan Hovold
On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote: > BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO > IC. > > To support BCM920706V2_EVAL dev board for WICED development on Linux. Add > the VID(0a5c) and > PID(6422) to ftdi_sio driver to allow loadi

Re: [PATCH 1/1] USB: serial: option: add support for Telit LE920A4

2016-08-08 Thread Johan Hovold
On Tue, Aug 02, 2016 at 11:29:25AM +0200, Daniele Palmas wrote: > This patch adds a set of compositions for Telit LE920A4. > > Compositions in short are: > > 0x1207: tty + tty > 0x1208: tty + adb + tty + tty > 0x1211: tty + adb + ecm > 0x1212: tty + adb > 0x1213: ecm + tty > 0x1214: tty + adb + e

Re: [PATCH] USB: serial: fix memleak on error path in usb-serial

2016-08-08 Thread Johan Hovold
On Mon, Aug 08, 2016 at 02:34:46AM +0100, Alexey Klimov wrote: > udriver struct allocated by kzalloc() will not be freed > if usb_register() and next calls fail. This patch fixes this > by adding one more step with kfree(udriver) in error path. > > Cc: Alan Stern > Signed-off-by: Alexey Klimov

[GIT PULL] USB-serial fixes for v4.8-rc2

2016-08-12 Thread Johan Hovold
v4.8-rc2 Here is a fix of a memory leak in a driver-registration error path, and some new device ids. Signed-off-by: Johan Hovold Alexey Klimov (1): USB: serial: fix memleak in driver-registration error path Daniele Palm

Re: [PATCH 2/2] USB: mos7840: fix non-atomic allocation in write path

2016-08-15 Thread Johan Hovold
On Fri, Aug 12, 2016 at 01:05:09AM +0300, Alexey Khoroshilov wrote: > There is an allocation with GFP_KERNEL flag in mos7840_write(), > while it may be called from interrupt context. > > Follow-up for commit 191252837626 ("USB: kobil_sct: fix non-atomic allocation > in write path") > > Found by

Re: [Umap2][9/11][05c5:0002] NULL pointer dereference

2016-08-16 Thread Johan Hovold
On Tue, Aug 16, 2016 at 10:47:44AM -0400, Alan Stern wrote: > On Tue, 16 Aug 2016, Binyamin Sharet wrote: > > > Kernel version: raspberrypi 4.4.6-v7+ #871 > > Driver source file: drivers/usb/serial/digi_acceleport.c > > Umap2 command line: umap2vsscan -P -s 05c5:0002 > > > > After connecting suc

Re: [Umap2][9/11][05c5:0002] NULL pointer dereference

2016-08-16 Thread Johan Hovold
On Wed, Aug 17, 2016 at 09:37:02AM +0300, Binyamin Sharet wrote: > Hi > > On 08/16/2016 06:04 PM, Johan Hovold wrote: > > On Tue, Aug 16, 2016 at 10:47:44AM -0400, Alan Stern wrote: > >> On Tue, 16 Aug 2016, Binyamin Sharet wrote: > >> > >>> Kernel ver

Re: [RESEND PATCH v5 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-08-18 Thread Johan Hovold
On Thu, Aug 18, 2016 at 09:52:22AM +0100, Martyn Welch wrote: > Johan, back in May you said: > > I have three patches in my queue that didn't make the cut due to lack > off time on my side. They're at the top of the list. > > Sorry about the delay. > > Yet I've heard nothing since. Is there some

Re: [RESEND PATCH v5 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-08-20 Thread Johan Hovold
[ +CC: Karl and Konstantin ] On Fri, Jul 22, 2016 at 11:33:15AM +0100, Martyn Welch wrote: > This patch adds support for the GPIO found on the CP2105. Unlike the GPIO > provided by some of the other devices supported by the cp210x driver, the > GPIO on the CP2015 is muxed on pins otherwise used fo

Re: [patch] USB: serial: option: add WeTelecom WM-D200

2016-08-20 Thread Johan Hovold
On Sat, Aug 20, 2016 at 01:29:41PM +0300, Aleksandr Makarov wrote: > From: Aleksandr Makarov > > USB: serial: option: add WeTelecom WM-D200 This does not belong in the commit message (mail body). > Add support for WeTelecom WM-D200. > > T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=12

Re: [PATCH 3/3] USB: serial: use IS_ENABLED() instead of checking for built-in or module

2016-08-22 Thread Johan Hovold
On Thu, Aug 18, 2016 at 09:45:06AM -0400, Javier Martinez Canillas wrote: > The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > built-in or as a module, use that macro instead of open coding the same. > > Using the macro makes the code more readable by helping abstract away

Re: [PATCH V9 1/1] usb:serial: Add Fintek F81532/534 driver

2016-08-22 Thread Johan Hovold
On Tue, May 31, 2016 at 09:51:20AM +0800, Ji-Ze Hong (Peter Hong) wrote: > This driver is for Fintek F81532/F81534 USB to Serial Ports IC. > > F81532 spec: > https://drive.google.com/file/d/0B8vRwwYO7aMFOTRRMmhWQVNvajQ/view? > usp=sharing > > F81534 spec: > https://drive.google.com/file/d/0B8vRww

Re: [PATCH v2 01/22] usb: serial: ti_usb_3410_5052: Do not use __uX types

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:41PM +0200, Mathieu OTHACEHE wrote: > __uX types should only be used for user-space interactions. > > Signed-off-by: Mathieu OTHACEHE > --- > > Changelog: > v2: > * Replace cpu_to_be16s calls by cpu_to_be16 > * Remove other useless casts You should have mentioned t

Re: [PATCH v2 02/22] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:42PM +0200, Mathieu OTHACEHE wrote: > Remove useless or redundant dev_dbg messages. > Fix debug-message typos. You never fix any typos, and forgot to mention the added NULL-check for oldtermios, which is currently not needed and really should go in its own patch. > S

Re: [PATCH v2 03/22] usb: serial: ti_usb_3410_5052: Use kzalloc instead of kmalloc

2016-08-23 Thread Johan Hovold
On Wed, Jul 27, 2016 at 02:46:32PM +0200, Mathieu OTHACEHE wrote: > > > in that case, where is the initialisation to 0 you avoid and hence > > can remove from the code? > > Hi, > > In v1, kzalloc was useful to avoid wFlags initialisation to 0 : > > https://lkml.org/lkml/2016/5/12/139 > > In v2

Re: [PATCH v2 04/22] usb: serial: ti_usb_3410_5052: Remove useless NULL-testing

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:44PM +0200, Mathieu OTHACEHE wrote: > It is useless to check the return of usb_get_serial_port_data. Please be more specific in your commit messages in general. In this case it should mention that there's no need to check for NULL private data in the tty or tty-port c

Re: [PATCH v2 07/22] usb: serial: ti_usb_3410_5052: Use macros instead of magic values

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:47PM +0200, Mathieu OTHACEHE wrote: > Use macros to define 3410 and 5052 baud bases. > Use macro to define usb download timeout. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 22 +++--- > 1 file changed, 15 inser

Re: [PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:46PM +0200, Mathieu OTHACEHE wrote: > Remove variables affected but never read. This commit message is also incomplete. The tp_flags variable was indeed read, even if it was always ANDed with 0. I applied it anyway this time, and also dropped the now unused TI_SET_SE

Re: [PATCH v3] usb: serial: mos7840.c Support TIOCGRS485 and TIOCSRS485 ioctls()

2016-08-23 Thread Johan Hovold
On Mon, Apr 11, 2016 at 02:27:20PM -0700, Aaron Marburg wrote: > > Add callbacks to handle TIOCGRS485 and TIOCSRS485 ioctl > calls in mos7840.c, allowing configuration of the chip's > "scratchpad" register to strobe the DTR line while transmitting. > > This functionality is required for R

Re: [PATCH V9 1/1] usb:serial: Add Fintek F81532/534 driver

2016-08-23 Thread Johan Hovold
On Tue, Aug 23, 2016 at 04:23:44PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2016/8/22 下午 09:14 寫道: > >> +{ > >> + size_t count = F81534_USB_MAX_RETRY; > >> + int status; > >> + u8 *tmp; > >> + > >

Re: [PATCH] USB: serial: option: add WeTelecom 0x6802 and 0x6803 products

2016-08-24 Thread Johan Hovold
On Wed, Aug 24, 2016 at 01:06:22PM +0300, Aleksandr Makarov wrote: > These product IDs are listed in Windows driver. > 0x6803 corresponds to WeTelecom WM-D300. > 0x6802 name is unknown. > > Signed-off-by: Aleksandr Makarov Now applied, thanks. Johan -- To unsubscribe from this list: send the li

[GIT PULL] USB-serial fixes for v4.8-rc4

2016-08-25 Thread Johan Hovold
+0200) USB-serial fixes for v4.8-rc4 Here are a couple of fixes for non-atomic allocations in write paths, and some new option device ids. Signed-off-by: Johan Hovold Aleksandr Makarov (2):

Re: [PATCH v4 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG

2016-08-26 Thread Johan Hovold
On Tue, Aug 09, 2016 at 09:55:16AM -0500, Andrew F. Davis wrote: > The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter. > Add MFD core support. > > Signed-off-by: Andrew F. Davis > --- > drivers/mfd/Kconfig | 9 +++ > drivers/mfd/Makefile| 2 + > drivers/mfd/ti-s

Re: [PATCH] usb: serial: mos7840.c Support RS485 mode in B&B Electronics USOPTL4-4P and USOPTL4-2P

2016-03-03 Thread Johan Hovold
On Wed, Mar 02, 2016 at 09:36:55AM -0800, Aaron Marburg wrote: > On Wed, 2 Mar 2016, Oliver Neukum wrote: > > > On Tue, 2016-03-01 at 09:54 -0800, amarb...@apl.washington.edu wrote: > >> From: Aaron Marburg > >> > >> The USOPTL4-4P and USOPTL4-2P USB-to-quad/dual RS-485/422 hubs use the > >> Mosc

[GIT PULL] USB-serial fixes for v4.5-rc7

2016-03-03 Thread Johan Hovold
e new device ids and a patch removing the mxu11x0 driver, which turned out not to be needed. Signed-off-by: Johan Hovold Bjørn Mork (1): USB: qcserial: add Sierra Wireless EM74xx device ID Daniele Palmas (1): USB: s

<    1   2   3   4   5   6   7   8   9   10   >