TS=0 => "RTS is statically active" and
CRTSCTS=1 => "RTS is used for receive flow control"
This only happened after first having enabled CRTSCTS.
Signed-off-by: Konstantin Shkolnyy
Fixes: 39a66b8d22a3 ("[PATCH] USB: CP2101 Add support for flow control")
[joha
On Fri, Sep 30, 2016 at 12:00:30AM +0300, Stas Sergeev wrote:
> 29.09.2016 13:09, Johan Hovold пишет:
> > On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote:
> >> The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
> >> a correct behaviour of th
On Thu, Sep 01, 2016 at 09:56:01AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
>
> F81532 spec:
> https://drive.google.com/file/d/0B8vRwwYO7aMFOTRRMmhWQVNvajQ/view?usp=
> sharing
>
> F81534 spec:
> https://drive.google.com/file/d/0B8vRww
On Thu, Sep 15, 2016 at 04:57:34PM +0100, Aidan Thornton wrote:
> Changing the LCR register after initialization does not seem to be
> reliable on all chips (particularly not on CH341A). Restructure
> initialization and configuration to always reinit the chip on
> configuration changes instead and
On Tue, Oct 11, 2016 at 12:04:48PM +0100, Martyn Welch wrote:
> This patch adds support for the GPIO found on the CP2105. Unlike the GPIO
> provided by some of the other devices supported by the cp210x driver, the
> GPIO on the CP2015 is muxed on pins otherwise used for serial control
> lines. The
On Thu, Oct 06, 2016 at 06:40:11PM +0200, Stefan Tauner wrote:
> This adds support to ftdi_sio for the Infineon TriBoard TC2X7
> engineering board for first-generation Aurix SoCs with Tricore CPUs.
> Mere addition of the device IDs does the job.
>
> Signed-off-by: Stefan Tauner
Now applied, than
On Sun, Oct 16, 2016 at 05:09:24PM +0100, Aidan Thornton wrote:
> On Mon, Oct 10, 2016 at 8:56 PM, Grigori Goronzy wrote:
> > On 2016-10-08 23:07, Aidan Thornton wrote:
> >>
> >> On Fri, Oct 7, 2016 at 12:30 PM, Johan Hovold wrote:
> >>>
> >>>
On Tue, Oct 18, 2016 at 12:39:23PM -, Karl Palsson wrote:
>
> Johan Hovold wrote:
> > On Sun, Oct 16, 2016 at 05:09:24PM +0100, Aidan Thornton wrote:
> > > On Mon, Oct 10, 2016 at 8:56 PM, Grigori Goronzy
> > > wrote:
> > > > On 2016-10-08 23:07,
On Wed, Oct 19, 2016 at 09:26:39AM +0200, Grigori Goronzy wrote:
> On 2016-10-18 15:45, Johan Hovold wrote:
> > On Tue, Oct 18, 2016 at 12:39:23PM -, Karl Palsson wrote:
> >> Perhaps it needs to be repeated more, but the current driver is
> >> so badly broken for
On Tue, Oct 11, 2016 at 12:04:48PM +0100, Martyn Welch wrote:
> This patch adds support for the GPIO found on the CP2105. Unlike the GPIO
> provided by some of the other devices supported by the cp210x driver, the
> GPIO on the CP2015 is muxed on pins otherwise used for serial control
> lines. The
On Wed, Oct 19, 2016 at 03:20:57PM +0100, Ben White wrote:
> Hi,
>
> I'm playing with some Juniper SRX devices, which have built in usb-serial.
> They don't come up automatically when plugging in, however I've found I can
> add the Vendor/ProductID to the cp210x module and this fixes it.
>
> Some
CSIZE is two-bit wide and only CS5 through CS8 are possible values.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cp210x.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f61477bed3a8..be0a2ca06bfb
Return -EIO on short control transfers rather than -EPROTO which is used
for lower-level transfer errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cp210x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial
The current tiocmget implementation would fail to report errors up the
stack and instead leaked a few bits from the stack as a mask of
modem-status flags.
Fixes: 39a66b8d22a3 ("[PATCH] USB: CP2101 Add support for flow control")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/
On Thu, Oct 20, 2016 at 09:13:41AM +0100, Martyn Welch wrote:
> This patch adds support for the GPIO found on the CP2105. Unlike the GPIO
> provided by some of the other devices supported by the cp210x driver, the
> GPIO on the CP2015 is muxed on pins otherwise used for serial control
> lines. The
Hi Tony,
I'm getting the splat below when booting 4.9-rc1 on a BBB and
tracked it down to 65b3f50ed6fa ("usb: musb: Add PM runtime support for
MUSB DSPS glue layer") which added a synchronous RPM get in a timer
callback:
[6.466226] BUG: sleeping function called from invalid context at
/home/
On Fri, Oct 21, 2016 at 12:08:49AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161020 08:38]:
> > Hi Tony,
> >
> > I'm getting the splat below when booting 4.9-rc1 on a BBB and
> > tracked it down to 65b3f50ed6fa ("usb: musb: Add PM runtime support for
>
ial: make minor allocation dynamic")
Cc: stable # 3.11
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index d213cf44a7e4..4a037b4a79cf
On Fri, Oct 21, 2016 at 02:49:05AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161021 02:26]:
> > On Fri, Oct 21, 2016 at 12:08:49AM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161020 08:38]:
> > > > Hi Tony,
> > > >
> > > > I'
7;s a fix for a NULL-deref during probe which could be triggered by a
malicious device, and a fix for some missing error handling in cp210x
that also leaked some bits from the stack. Included is also a new device
id for ftdi_sio.
Signed-off-by: Johan H
On Sat, Oct 22, 2016 at 03:24:56PM +0100, Aidan Thornton wrote:
> On 19 Oct 2016 09:42, "Johan Hovold" wrote:
> >
> > On Wed, Oct 19, 2016 at 09:26:39AM +0200, Grigori Goronzy wrote:
> > > So let's just undo the change to the initialization sequence and get
On Thu, Oct 20, 2016 at 03:13:54PM +0100, Martyn Welch wrote:
> This patch adds support for the GPIO found on the CP2105. Unlike the GPIO
> provided by some of the other devices supported by the cp210x driver, the
> GPIO on the CP2015 is muxed on pins otherwise used for serial control
> lines. The
Use bool rather than u8 for the gpio-chip-registered flag.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cp210x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 213ed3868fed..ef7f1c01c2cc 100644
On Sat, Oct 22, 2016 at 10:14:21PM +0100, Aidan Thornton wrote:
> On 22 Oct 2016 15:56, "Johan Hovold" wrote:
> >
> > On Sat, Oct 22, 2016 at 03:24:56PM +0100, Aidan Thornton wrote:
> > > On 19 Oct 2016 09:42, "Johan Hovold" wrote:
> > &g
On Sun, Oct 23, 2016 at 04:14:25PM +0200, Oliver Neukum wrote:
> On Sat, 2016-10-22 at 22:02 +0100, Aidan Thornton wrote:
> > This is an attempt to clean-up and resubmit some patches by Grigori
> > Goronzy a few months back adding support for parity, frame length, and
> > 2 stop bits to the CH340/1
On Sat, Oct 22, 2016 at 10:02:22PM +0100, Aidan Thornton wrote:
> This is an attempt to clean-up and resubmit some patches by Grigori
> Goronzy a few months back adding support for parity, frame length, and
> 2 stop bits to the CH340/1 driver and cleaning up some magic constants.
> His later patche
On Mon, Oct 24, 2016 at 10:35:38AM -0700, Tony Lindgren wrote:
> From: Tony Lindgren
> Date: Mon, 24 Oct 2016 09:18:02 -0700
> Subject: [PATCH] usb: musb: Fix sleeping function called from invalid
> context for hdrc glue
>
> Commit 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS
On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote:
> Good work on this patch, nice that it got merged.
>
> I was just thinking that as an add-on, you may want to name
> the gpio lines so they have meaningful names in userspace
> when you use this with the chardev (I have reasons to bel
On Wed, Oct 26, 2016 at 01:50:14PM +0200, Linus Walleij wrote:
> On Wed, Oct 26, 2016 at 11:09 AM, Johan Hovold wrote:
> > On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote:
>
> >> I was thinking on either reusing the .names field of the
> >> struct gpio
On Tue, Oct 25, 2016 at 08:11:10AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161025 01:33]:
> > On Mon, Oct 24, 2016 at 10:35:38AM -0700, Tony Lindgren wrote:
> >
> > > From: Tony Lindgren
> > > Date: Mon, 24 Oct 2016 09:18:02 -0700
> > > Subject
ck_status() and then register a
> callback with musb_runtime_resume() so it gets called only when musb core
> and it's parent devices are awake. Note that we don't want to do this from
> PM runtime resume in musb_dsps.c as musb core is not awake yet at that
> point as noted by Joh
On Thu, Oct 27, 2016 at 10:40:17AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161027 09:45]:
> > On Thu, Oct 27, 2016 at 08:14:46AM -0700, Tony Lindgren wrote:
> > > * Tony Lindgren [161026 07:32]:
> >
> > > 8< ---
>
On Thu, Oct 27, 2016 at 12:15:52PM -0700, Tony Lindgren wrote:
> * Johan Hovold [161027 11:46]:
> > On Thu, Oct 27, 2016 at 10:40:17AM -0700, Tony Lindgren wrote:
> > > diff --git a/drivers/usb/musb/musb_gadget.c
> > > b/drivers/usb/musb/musb_gadget.c
> > >
On Fri, Oct 28, 2016 at 11:13:19AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161028 02:45]:
> > On Thu, Oct 27, 2016 at 12:15:52PM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161027 11:46]:
> > > > But then this looks like it could trigger an ABBA deadlock
: 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver")
Signed-off-by: Johan Hovold
---
drivers/usb/phy/phy-am335x-control.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/phy/phy-am335x-control.c
b/drivers/usb/phy/phy-am335x-control.c
index 42a1afe36a90..5f5f19813fde 10
stack (core files)")
Signed-off-by: Johan Hovold
---
drivers/uwb/lc-rc.c | 16 +---
drivers/uwb/pal.c | 2 ++
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/uwb/lc-rc.c b/drivers/uwb/lc-rc.c
index d059ad4d0dbd..97ee1b46db69 100644
--- a/drivers/uwb/lc-
On Tue, Nov 01, 2016 at 12:33:45PM +0100, Meindert Sprang wrote:
> Hello all,
>
> I am the developer of the ShipModul (CustomWare) MiniPlex products where
> we use FTDI chips for USB communications.
> I see that even the latest PID we use (FD4B) is already in the
> ftdi_sio.c driver and I'm glad
/drive.google.com/file/d/0B8vRwwYO7aMFV29pQWJqbVBNc00/view?usp=
> sharing
>
> Features:
> 1. F81532 is 1-to-2 & F81534 is 1-to-4 serial ports IC
> 2. Support Baudrate from B50 to B115200.
>
> Reviewed-by: Johan Hovold
You must never add other peoples' Reviewed-by tags u
On Thu, Nov 03, 2016 at 02:26:35PM -0700, Tony Lindgren wrote:
> * Johan Hovold [161031 04:50]:
> > On Fri, Oct 28, 2016 at 11:13:19AM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161028 02:45]:
> > > > On Thu, Oct 27, 2016 at 12:15:52PM -0700, Tony Lindgren w
Remove comments about resume signalling being stopped from
GetPortStatus, something which is no longer the case.
Fixes: 8ed1fb790ea2 ("usb: musb: finish suspend/reset work...")
Signed-off-by: Johan Hovold
---
drivers/usb/musb/musb_core.c| 5 +
drivers/usb/musb/musb_virthub.
On Fri, Nov 04, 2016 at 09:18:20PM -0700, Doug Brown wrote:
> This patch adds support for the TI CC3200 LaunchPad board, which uses a
> custom USB vendor ID and product ID. Channel A is used for JTAG, and
> channel B is used for a UART.
>
> Signed-off-by: Doug Brown
Now applied.
Thanks,
Johan
-
: 5a6a62bdb925 ("cdc-acm: add TIOCMIWAIT")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 78f0f85bebdc..c2da3811915a 100644
--- a/drivers/usb/class/cdc-a
Drop invalid user-pointer checks from ioctl handlers.
A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 5 -
drivers/usb/serial/io_edgeport.c | 3 ---
drivers/usb/serial
Use the tty get_icount operation instead of implementing TIOCGICOUNT
directly.
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc
Drop invalid user-pointer check from TIOCGSERIAL handler.
A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b
On Tue, Nov 08, 2016 at 03:13:13PM +0100, Oliver Neukum wrote:
> On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote:
> > Drop invalid user-pointer checks from ioctl handlers.
> >
> > A NULL-pointer can be valid in user space and copy_to_user() takes
> >
the same problem.
>
> Let's fix the issue by using a list of delayed work then call it on
> resume. Note that we want to do this only when musb core and it's
> parent devices are awake as noted by Johan Hovold .
>
> Also note that we now also need to get rid of static
On Mon, Nov 07, 2016 at 02:50:17PM -0700, Tony Lindgren wrote:
> We can't use static variable first for checking when musb is
> initialized when we have multiple musb instances like on am335x.
>
> Signed-off-by: Tony Lindgren
Reviewed-by: Johan Hovold
Thanks,
Johan
--
To unsu
On Tue, Nov 08, 2016 at 10:34:13AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161108 10:09]:
> > On Mon, Nov 07, 2016 at 02:50:18PM -0700, Tony Lindgren wrote:
> > > @@ -2604,6 +2669,9 @@ static int musb_resume(struct device *dev)
> > > mask = MUSB_DEVCTL_
On Wed, Nov 09, 2016 at 11:58:31AM +0100, Oliver Neukum wrote:
> On Tue, 2016-11-08 at 16:41 +0100, Johan Hovold wrote:
> > On Tue, Nov 08, 2016 at 03:13:13PM +0100, Oliver Neukum wrote:
> > > On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote:
> > > > Drop in
On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony Lindgren wrote:
> * Johan Hovold [161108 12:03]:
> > On Tue, Nov 08, 2016 at 10:34:13AM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161108 10:09]:
> > > > On Mon, Nov 07, 2016 at 02:50:18PM -0700, Tony Lindgr
On Wed, Nov 09, 2016 at 08:34:10AM -0700, Tony Lindgren wrote:
> * Tony Lindgren [161108 18:26]:
> > * Johan Hovold [161108 12:03]:
> > +int musb_queue_resume_work(struct musb *musb,
> > + int (*callback)(struct musb *musb, void *data),
> > +
On Wed, Nov 09, 2016 at 04:39:53PM +0100, Johan Hovold wrote:
> On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony Lindgren wrote:
> > @@ -2065,6 +2147,7 @@ musb_init_controller(struct device *dev, int nIrq,
> > void __iomem *ctrl)
> > }
> >
> &g
On Wed, Nov 09, 2016 at 10:54:38AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161109 08:40]:
> > On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161108 12:03]:
> > > > On Tue, Nov 08, 2016 at 10:34:13AM -0700, Tony Lindgren w
On Thu, Nov 10, 2016 at 11:02:35AM -0700, Tony Lindgren wrote:
> * Tony Lindgren [161110 10:50]:
> > * Johan Hovold [161110 09:04]:
> > > Yes, and make sure to stop polling in musb_suspend(). Would it be
> > > possible to use the enable and disable ops for this until
On Thu, Nov 10, 2016 at 10:41:50AM -0700, Tony Lindgren wrote:
> * Johan Hovold [161110 09:04]:
> > On Wed, Nov 09, 2016 at 10:54:38AM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161109 08:40]:
> > > > On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony Lindgren w
On Thu, Nov 10, 2016 at 12:40:03PM -0700, Tony Lindgren wrote:
> * Johan Hovold [161110 11:43]:
> > On Thu, Nov 10, 2016 at 10:41:50AM -0700, Tony Lindgren wrote:
> > > * Johan Hovold [161110 09:04]:
> > > > I'm afraid that won't work as pm_runtime_get(
On Fri, Nov 11, 2016 at 07:42:50AM -0800, Tony Lindgren wrote:
> * Johan Hovold [16 04:03]:
> > On Thu, Nov 10, 2016 at 12:40:03PM -0700, Tony Lindgren wrote:
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren
> Date: Wed, 2 Nov 2016 19:59:05 -0700
> Subject: [
On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote:
> If we return early on pm_runtime_get() error, we need to also call
> pm_runtime_put_noidle() as pointed out in a musb related thread
> by Johan Hovold . This is to keep the PM runtime
> use counts happy.
>
> F
On Mon, Nov 14, 2016 at 03:34:54PM +0100, Johan Hovold wrote:
> On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote:
> > If we return early on pm_runtime_get() error, we need to also call
> > pm_runtime_put_noidle() as pointed out in a musb related thread
> > by Joha
On Mon, Nov 14, 2016 at 06:47:31AM -0800, Tony Lindgren wrote:
> Hi,
>
> * Johan Hovold [161114 06:35]:
> > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote:
> > > If we return early on pm_runtime_get() error, we need to also call
> > > pm_runtime
[] (omap2430_remove+0x38/0x58)
[] (omap2430_remove) from [] (platform_drv_remove+0x34/0x4c)
> - pm_runtime_dont_use_autosuspend(glue->dev);
> pm_runtime_disable(glue->dev);
>
> return 0;
This might be worth mentioning in the commit message, but feel free to
rm_device *pdev)
> platform_device_unregister(glue->musb);
>
> /* disable usbss clocks */
Perhaps also drop this comment which no longer applies.
> - pm_runtime_dont_use_autosuspend(&pdev->dev);
> - pm_runtime_put_sync(&pdev->dev);
> pm_runti
On Wed, Nov 16, 2016 at 10:13:49AM +, Paul Jakma wrote:
> The BRIM Brothers Zone DPMX is a bicycle powermeter. This ID is for the
> USB serial interface in its charging dock for the control pods, via
> which some settings for the pods can be modified.
>
> Signed-off-by: Paul Jakma
> Cc: Bar
[ +CC: Tony ]
On Thu, Nov 17, 2016 at 08:10:55AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 16, 2016 at 01:21:21PM -0600, Bin Liu wrote:
> > Hi Greg,
> >
> > Hope this is not too late for -rc6. This set fixes a long standing musb
> > regression introduced in v4.8. Please let me know if any c
On Wed, Nov 16, 2016 at 10:03:52PM +0100, Giuseppe Lippolis wrote:
> Dear All,
> thanks for the very interesting discussion.
>
> > > This will make option grab all the ports, as shown by your dmesg
> > > output. But USB interfaces 0 and 1 are actually cdc-ether and should
> > > *not* be grabbed b
On Wed, Nov 11, 2015 at 10:35:47AM +0100, Mathieu OTHACEHE wrote:
> Add a driver which supports :
>
> - UPort 1110 : 1 port RS-232 USB to Serial Hub.
> - UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
> - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> - UPort 1150 : 1 po
On Mon, Nov 30, 2015 at 04:50:38PM -0600, Konstantin Shkolnyy wrote:
> cp210x_get_config and cp210x_set_config were hard to use. They required
> the buffer as an array of 32-bit values even for smaller values, and did
> endian conversions on per-32-bit value basis, which is wrong for some
> cp210x
On Wed, Nov 25, 2015 at 09:54:58AM -0600, Dan Williams wrote:
> On Wed, 2015-11-25 at 13:13 +0100, M. Hrdlička wrote:
> > Hello,
> > log script told me, that I may to tell you about add this device to
> > propper linux driver.
> >
> > Device is combo USB modem Celot CTD-200, manufacturing date in
On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
>
> - (!A || (A && B)) is the same as (!A || B).
> - (length && length > 5) can be reduced to a single evaluation.
>
> Caught by: cppcheck
>
> Signed-off-by: Geyslan G. Bem
> ---
> driv
On Thu, Dec 10, 2015 at 05:50:09PM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
>
> (!A || (A && B)) is the same as (!A || B).
> (length && length > 5) can be reduced to a single evaluation.
>
> Tested by compilation only.
> Caught by cppcheck.
>
> Signed-off-by: Gey
On Fri, Dec 11, 2015 at 06:46:41AM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
>
> (!A || (A && B)) is the same as (!A || B).
>
> Tested by compilation only.
> Caught by cppcheck.
>
> Signed-off-by: Geyslan G. Bem
You forgot to update the commit summary (to include
Dan and Björn,
On Thu, Dec 10, 2015 at 04:42:52PM +0100, yegorsli...@googlemail.com wrote:
> From: Yegor Yefremov
>
> Signed-off-by: Yegor Yefremov
> ---
> drivers/usb/serial/option.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/opt
On Fri, Dec 11, 2015 at 07:25:51AM -0300, Geyslan G. Bem wrote:
> 2015-12-11 7:13 GMT-03:00 Johan Hovold :
> > On Fri, Dec 11, 2015 at 06:46:41AM -0300, Geyslan G. Bem wrote:
> >> This patch removes redundant conditions.
> >>
> >> (!A || (A && B)) i
[ +CC: linux-usb ]
On Tue, Dec 22, 2015 at 10:51:32AM +, John Ernberg wrote:
> From: John Ernberg
>
> In certain kernel configurations where the cdc_ether and option drivers
> are compiled as modules there can occur a race condition in enumeration.
> This causes the option driver to enumerat
On Sun, Dec 27, 2015 at 08:49:22PM +0100, Oliver Freyermuth wrote:
> Dear kernel-hackers,
>
> this adds the PID and VID for the ELV Marble Sound Board which uses a
> CP2102 as USB-serial converter.
> I hope linux-usb is the correct list for this patch, otherwise please
> redirect me.
>
> Details
On Sun, Dec 06, 2015 at 12:29:43PM +0100, Mathieu OTHACEHE wrote:
> Add a driver which supports :
>
> - UPort 1110 : 1 port RS-232 USB to Serial Hub.
> - UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
> - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> - UPort 1150 : 1 po
On Mon, Dec 28, 2015 at 02:39:44PM +, One Thousand Gnomes wrote:
> > https://lkml.kernel.org/r/201102171210.03474.fr...@tennebo.com
> >
> > However, the TIOCSRS485-ioctl might not even be the right interface for
> > changing transceiver modes, and instead a sysfs-based
> > usb-serial-speci
On Mon, Dec 28, 2015 at 05:03:19PM +0100, Oliver Freyermuth wrote:
> Dear kernel-hackers, dear Johan,
>
> thanks for your assistance, and the hint to the documentation,
> as you may have guessed, that's my first patch -
> I hereby resend it inline and added the signed-off-by statement.
Thanks
On Mon, Dec 28, 2015 at 06:37:38PM +0100, Oliver Freyermuth wrote:
> Add the USB device ID for ELV Marble Sound Board 1.
>
> Signed-off-by: Oliver Freyermuth
> ---
> Dear kernel-hackers, dear Johan,
>
> thanks for all the help!
> This is v3, now sent with git-send-email which I found astonishing
On Mon, Dec 28, 2015 at 09:21:25PM +0100, Mathieu OTHACEHE wrote:
> Add a driver which supports :
>
> - UPort 1110 : 1 port RS-232 USB to Serial Hub.
> - UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
> - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> - UPort 1150 : 1 po
Fix memory leak in port-probe error path by verifying the interrupt-in
urb before allocating the private data.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb
Make sure to release the private data before returning -ENODEV after
having downloaded the firmware during first probe.
Clean up the error paths while at it.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 25 ++---
1 file changed, 14 insertions(+), 11
Make sure to raise DTR and RTS on transitions from B0 and leave the
other bits unchanged.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index
Fix memory leak in port-probe error path by verifying the interrupt-in
urb before allocating the private data.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb
Make sure to release the private data before returning -ENODEV after
having downloaded the firmware during first probe.
Clean up the error paths while at it.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 25 ++---
1 file changed, 14 insertions(+), 11
Drop redundant function name from a few error messages.
Drop redundant error message when generic open fails.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial
Rename the usb-serial driver "mxu11x0" to match the USB driver name.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index c4
Drop redundant function name from a few error messages.
Drop redundant error message when generic open fails.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial
Make sure to raise DTR and RTS on transitions from B0 and leave the
other bits unchanged.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index
Fix a couple of debug-message typos, and do some minor clean ups.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index 73cc8564a562
Here are a few fixes and clean ups of issues found during a last review
of the new driver.
Johan
Johan Hovold (6):
USB: mxu11x0: fix memory leak in port-probe error path
USB: mxu11x0: fix memory leak on firmware download
USB: mxu11x0: fix modem-control handling on B0-transitions
USB
Fix a couple of debug-message typos, and do some minor clean ups.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index 73cc8564a562
Here are a few fixes and clean ups of issues found during a last review
of the new driver.
Johan
Johan Hovold (6):
USB: mxu11x0: fix memory leak in port-probe error path
USB: mxu11x0: fix memory leak on firmware download
USB: mxu11x0: fix modem-control handling on B0-transitions
USB
Rename the usb-serial driver "mxu11x0" to match the USB driver name.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mxu11x0.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index c4
On Tue, Dec 29, 2015 at 01:36:17PM +0100, Johan Hovold wrote:
> Here are a few fixes and clean ups of issues found during a last review
> of the new driver.
Bah, sorry about the double post.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body
On Tue, Dec 29, 2015 at 01:36:10PM +0100, Johan Hovold wrote:
> Here are a few fixes and clean ups of issues found during a last review
> of the new driver.
> Johan Hovold (6):
> USB: mxu11x0: fix memory leak in port-probe error path
> USB: mxu11x0: fix memory leak on fi
f7d7f59ab124748156ea551edf789994f05da342:
USB: cp210x: add ID for ELV Marble Sound Board 1 (2015-12-28 19:07:35 +0100)
USB-serial fixes for v4.4-rc8
Here's another device id for cp210x.
Signed-off-by: Johan H
+0100)
USB-serial fixes for v4.4-rc8
Here's another device id for cp210x.
Signed-off-by: Johan Hovold
Oliver Freyermuth (1):
USB: cp210x: add ID for ELV Marble Sound Board 1
drivers/usb/serial/cp210x.c | 1
couple of firmware bugs, and generic wait-until-sent support
(e.g. for tcdrain) is also added.
Included are also some general clean ups.
Signed-off-by: Johan Hovold
Geyslan G. Bem (2):
USB: io_edgeport: remove redundant
201 - 300 of 3156 matches
Mail list logo
