On Tue, May 03, 2016 at 02:44:19PM -0700, Greg Kroah-Hartman wrote:
> From: lei liu
>
> More ZTE device ids.
>
> Signed-off-by: lei liu
> Cc: stable
> [properly sort them - gregkh]
> Signed-off-by: Greg Kroah-Hartman
Thanks for the patch, and for the amendment.
Now applied.
Johan
--
To uns
On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote:
> Replaced magic numbers used in the CRTSCTS flag code with symbolic names
> from the chip specification.
>
> Signed-off-by: Konstantin Shkolnyy
This patch does not even compile. Please be more careful when
resubmitting. There
On Tue, May 03, 2016 at 01:46:51PM +0200, Mathieu OTHACEHE wrote:
> > No, I was trying to say that the we should not attempt to load a
> > firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa
> > firmware.
>
> For MTS devices (mts_*.fw) and for devices using generic firmware (ti_
On Wed, May 04, 2016 at 04:34:22PM +0800, 刘磊 wrote:
> dear all:
> thank you very much.
> Excuse me for last submit mail, i missed some device ID. we need to add
> some other device ID to linux kernel, that has been already used in our
> corporation's device.
> we need some help from yours
On Wed, May 04, 2016 at 12:46:17PM +, Konstantin Shkolnyy wrote:
> > -Original Message- From: linux-usb-ow...@vger.kernel.org
> > [mailto:linux-usb- ow...@vger.kernel.org] On Behalf Of Johan Hovold
> > Sent: Wednesday, May 04, 2016 02:29 To: Konstantin Shkolnyy Cc:
&g
On Wed, May 04, 2016 at 01:17:26PM +, Konstantin Shkolnyy wrote:
> > -Original Message-
> > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold
> > Sent: Wednesday, May 04, 2016 07:55
> > To: Konstantin Shkolnyy
> > Cc: Johan Hovold;
On Wed, May 04, 2016 at 04:56:38PM -0500, Konstantin Shkolnyy wrote:
> This patch series fixes bugs and replaces magic numbers with symbolic
> names in CRTSCTS flag code.
>
> v5:
> Fixed 2 compile errors in PATCH 2/3, otherwise no change.
> v4:
> Same series of patches, fixed names and defines by
:16:05 +0200)
USB-serial fixes for v4.6-rc7
Here are some more new device ids.
Signed-off-by: Johan Hovold
Lei Liu (1):
USB: serial: option: add even more ZTE
Private data, URBs and buffers allocated for Epic devices during
attach were never released on errors (e.g. missing endpoints).
Fixes: 6e8cf7751f9f ("USB: add EPIC support to the io_edgeport driver")
Cc: stable # v2.6.21
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgep
A driver must not rely on the URB status field to try to determine if an
URB is active.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial
with unbound interfaces with active URBs.
Included is also a couple of minor fixes and clean ups of the keyspan
driver, and a fix of how we deal with minor-number exhaustion in core.
Johan
Johan Hovold (8):
USB: serial: io_edgeport: fix memory leaks in attach error path
USB: serial
be freed while the URBs are still in use. We'd also end up
with active URBs for an unbound interface.
Fixes: f9c99bb8b3a1 ("USB: usb-serial: replace shutdown with disconnect,
release")
Cc: stable # v2.6.31
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c |
The URB status is signed and should be printed using %d rather than %x.
Also print endpoint addresses consistently using %x rather than %d, and
merge a broken-up error message string.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 42
up with active URBs for an
unbound interface. This in turn could lead to deallocated memory being
dereferenced in the completion callbacks.
Fixes: ee467a1f2066 ("USB: serial: add Moxa UPORT 12XX/14XX/16XX
driver")
Cc: stable # v3.14
Signed-off-by: Johan Hovold
---
drivers/
Due to a missing upper bound, invalid minor numbers could be assigned to
ports. Such devices would later fail to register, but let's catch this
early as intended and avoid having devices with only a subset of their
ports registered (potentially the empty set).
Signed-off-by: Johan H
memory being
dereferenced in the completion callback.
Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Cc: stable # v3.5: 40d04738491d
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/
("USB: usb-serial: replace shutdown with disconnect,
release")
Cc: stable # v2.6.31
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgeport.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/
On Sat, May 07, 2016 at 07:46:14PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 05, 2016 at 12:13:11PM +0200, Johan Hovold wrote:
> > Hi Greg,
> >
> > Here are some new modem device ids for the option driver. These have all
> > been in linux-next over night and co
On Mon, May 09, 2016 at 07:26:27AM +0200, Greg Kroah-Hartman wrote:
> On Sun, May 08, 2016 at 08:08:03PM +0200, Johan Hovold wrote:
> > Due to a missing upper bound, invalid minor numbers could be assigned to
> > ports. Such devices would later fail to register, but let's cat
On Tue, May 10, 2016 at 09:08:48AM +0200, Mathieu OTHACEHE wrote:
> Add support for :
>
> - UPort 1110 : 1 port RS-232 USB to Serial Hub.
> - UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
> - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> - UPort 1150 : 1 port RS-232/42
some general code clean ups.
Signed-off-by: Johan Hovold
Javier Martinez Canillas (1):
USB: serial: use IS_ENABLED() instead of checking for FOO || FOO_MODULE
Johan Hovold (8):
USB: serial: io_edgeport: fix memory
On Fri, May 13, 2016 at 01:55:40PM +0200, Johannes Hofmann wrote:
No commit message?
> Signed-off-by: Johannes Hofmann
> ---
> drivers/usb/serial/pl2303.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index e3b7af8..60a9
On Mon, May 16, 2016 at 10:50:56AM +0100, Martyn Welch wrote:
> On 12/04/16 09:15, Martyn Welch wrote:
> > On 12/04/16 09:08, Johan Hovold wrote:
> >> On Tue, Apr 12, 2016 at 09:01:52AM +0100, Martyn Welch wrote:
> >>> Johan,
> >>>
> >>>
On Fri, May 13, 2016 at 12:17:24PM +0200, mich...@walle.cc wrote:
> Hi,
>
> if the internal buffer is full, a read() returns a steady stream of
> zeros until one valid character is received. According to my experiments
> this happens if the FT232 receives characters while the device is not
> op
On Tue, Dec 18, 2012 at 05:53:38PM +0500, Den Ladin wrote:
> Very simple, but very necessary.
> Suitable for all versions of the kernel > 2.6
Your patch looks good (included below for reference), but could you
please resubmit it inline to linux-usb@vger.kernel.org?
Have a look at Documentation/Su
On Mon, Dec 24, 2012 at 12:41:14PM +0500, Den Ladin wrote:
> Adding support "PSC Scanning, Magellan 800i" in cdc-acm
>
> Very simple, but very necessary.
> Suitable for all versions of the kernel > 2.6
Please submit your patch (the latest one against v3.7.1) as an inline
attachment. You also need
On Thu, Jan 03, 2013 at 11:21:08PM +0100, Wolfgang Frisch wrote:
> The attached patch fixes the symptom.
>
> The NULL dereference is caused by "chase_port" in
> drivers/usb/serial/io_ti.c as tty == NULL.
> Unfortunately I'm not familiar with the usb-serial system.
> I guess the tty is already clea
Move write-fifo flushing from chase_port to close where it belongs.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 58184f3..596f8c9 100644
trees. This series could then be applied on top of
that minimal fix.
Johan
Johan Hovold (5):
USB: io_ti: move write-fifo flushing to close
USB: io_ti: use tty-port drain delay
USB: serial: grab disconnect mutex in chars_in_buffer
USB: io_ti: query hardware-buffer status in chars_in_buffer
Grab disconnect mutex in chars_in_buffer before checking disconnected
flag or calling driver specific function.
This allows subdrivers to query any hardware buffer status without
having to handle the locking themselves.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 14
Query hardware-buffer status in chars_in_buffer should the write fifo be
empty.
This is needed to make the tty layer wait for hardware buffers to drain
on close.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb
Use tty-port drain delay rather than custom implementation in
chase_port.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 596f8c9..3abbdaa
Kill custom closing_wait implementation and let the tty layer handle it
instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 57 --
1 file changed, 9 insertions(+), 48 deletions(-)
diff --git a/drivers/usb/serial/io_ti.c b/drivers
On Thu, Jan 17, 2013 at 01:07:02AM +0100, Wolfgang Frisch wrote:
> The tty is NULL when the port is hanging up.
> chase_port() needs to check for this.
>
> This patch is intended for stable series.
> The behavior was observed and tested in Linux 3.2 and 3.7.1.
>
> Johan Ho
On Thu, Jan 17, 2013 at 01:08:41AM +0100, Wolfgang Frisch wrote:
> On 14/01/13 16:37, Johan Hovold wrote:
> > I've prepared a patch series which removes the custom chase_port
> > function and replaces it with the corresponding generic implementations
> > instead (whic
a couple of new device ids.
Signed-off-by: Johan Hovold
Doug Brown (1):
USB: serial: ftdi_sio: add support for TI CC3200 LaunchPad
Paul Jakma (1):
USB: serial: cp210x: add ID for the Zone DPMX
drivers/usb/serial
On Mon, Nov 21, 2016 at 01:19:31PM +0100, Geert Uytterhoeven wrote:
> On sparc32, tcflag_t is unsigned long, unlike all other architectures:
>
> drivers/usb/serial/cp210x.c: In function 'cp210x_get_termios':
> drivers/usb/serial/cp210x.c:717:3: warning: passing argument 2 of
> 'cp210x_get
On Mon, Nov 14, 2016 at 01:37:59PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
>
> F81532 spec:
> https://drive.google.com/file/d/0B8vRwwYO7aMFOTRRMmhWQVNvajQ/view?usp=
> sharing
>
> F81534 spec:
> https://drive.google.com/file/d/0B8vRww
On Tue, Nov 29, 2016 at 10:33:16AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi Johan,
>
> Johan Hovold 於 2016/11/24 下午 11:04 寫道:
> > On Mon, Nov 14, 2016 at 01:37:59PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> >> This driver is for Fintek F81532/F8153
On Tue, Nov 29, 2016 at 08:53:35PM +0800, Pan Bian wrote:
> Function klsi_105_open() calls usb_control_msg() and checks its return
> value. When the return value is unexpected, it only assigns the error
> code to the return variable retval, but does not terminate the exception
> path. This patch fi
inserting
"goto err_generic_close;" when the call to usb_control_msg() fails.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Pan Bian
[johan: rebase on prerequisite fix and amend commit message]
Signed-off-by: Johan Hovold
---
drivers/usb/serial/kl5kusb105.c | 2 ++
o
retrieve the line status.
I fixed up the latter and rebased the Pan Bian's patch on top.
Johan
Johan Hovold (1):
USB: serial: kl5kusb105: fix open error path
Pan Bian (1):
USB: serial: kl5kusb105: abort on open exception path
drivers/usb/serial/kl
Kill urbs and disable read before returning from open on failure to
retrieve the line state.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/kl5kusb105.c | 33 -
1 file changed, 24 insertions(+), 9
On Tue, Nov 29, 2016 at 04:55:00PM +0100, Johan Hovold wrote:
> Pan Bian found an issue with the kl5kusb105 open error handling, which
> would not abort an open attempt when a vendor command to "enable read"
> failed.
>
> Turns out there were more issues with this f
updates include a new driver for Fintek F8153x devices, support
for the GPIO functionality on CP2105 devices, and improved support for
CH34X devices.
Included are also some clean ups and fixes for various minor issues.
Signed-off-by: Johan Hovold
On Thu, Dec 01, 2016 at 04:38:39PM +0100, Daniele Palmas wrote:
> This patch adds support for PIDs 0x1040, 0x1041 of Telit LE922A.
>
> Since the interface positions are the same than the ones used
> for other Telit compositions, previous defined blacklists are used.
>
> Signed-off-by: Daniele Pal
On Sat, Dec 03, 2016 at 07:47:11PM +0100, Giuseppe Lippolis wrote:
> Dear All,
>
> > If possible you want to tell the option driver which interfaces to
> > bind to (white-listing) rather than specifying which not to bind to
> > (black-listing). The latter typically means probing all interfaces,
On Tue, Dec 06, 2016 at 09:24:19PM +0100, Giuseppe Lippolis wrote:
> I try to attach the file.
This still wouldn't apply without some manual intervention. Next time,
try sending the patch to yourself first (e.g. using git-send-email) and
make sure you can apply the result with git-am.
> Adding re
On Wed, Dec 07, 2016 at 04:42:21AM -0800, Russell Senior wrote:
> I just bought a bag of usb-serial converters off of ebay, from china for
> super low price (~$2/each). I just plugged a couple of them in,
> connected together through a null-modem adapter. When I plug them, on
> both stock ubuntu
On Wed, Dec 07, 2016 at 09:51:50PM +0100, Giuseppe Lippolis wrote:
> Dear Johan,
> Thanks for the tips.
>
> Here is the patch.
> Bye.
>
> ---
Great, this one would have applied fine (but of course lacks a commit
message and Signed-off-by).
I already applied your previous submission. Also note tha
[ +CC: Adain, Grigori, Karl ]
On Wed, Dec 07, 2016 at 05:51:33PM -0800, Russell Senior wrote:
> >>>>> "Johan" == Johan Hovold writes:
>
> >> I attach the tty's with GNU screen (but I have also tried microcom
> >> and minicom with the sam
On Thu, Dec 08, 2016 at 10:37:28AM +0100, Johan Hovold wrote:
> [ +CC: Adain, Grigori, Karl ]
>
> On Wed, Dec 07, 2016 at 05:51:33PM -0800, Russell Senior wrote:
> > I still suspect shoddy hardware. It would be nice to hear someone else
> > with the ch341-based hardware to
On Thu, Dec 08, 2016 at 04:41:44AM -0800, Russell Senior wrote:
> >>>>> "Johan" == Johan Hovold writes:
>
> [...]
>
> Johan> Ok, and you were using a terminal program such as minicom that
> Johan> properly configures the port for say 8-bit
+0100)
USB-serial fixes for v4.10-rc1
Here are some new device ids for the option driver.
Signed-off-by: Johan Hovold
Daniele Palmas (1):
USB: serial: option: add
On Fri, Dec 09, 2016 at 11:45:06AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 09, 2016 at 11:00:27AM +0100, Johan Hovold wrote:
> > Hi Greg,
> >
> > Here are some more device ids that could go into v4.10-rc1 unless you
> > prefer I resend these after rc1 is out
On Thu, Dec 08, 2016 at 07:26:26PM -0800, Russell Senior wrote:
> On Thu, Dec 8, 2016 at 10:02 AM, Johan Hovold wrote:
> > On Thu, Dec 08, 2016 at 04:41:44AM -0800, Russell Senior wrote:
> >> >>>>> "Johan" == Johan Hovold writes:
> >>
> >
On Fri, Dec 09, 2016 at 10:21:32AM +, Aidan Thornton wrote:
> On Fri, Dec 9, 2016 at 3:26 AM, Russell Senior
> wrote:
> > On Thu, Dec 8, 2016 at 10:02 AM, Johan Hovold wrote:
> >> On Thu, Dec 08, 2016 at 04:41:44AM -0800, Russell Senior wrote:
> >>> >
On Fri, Dec 09, 2016 at 07:14:02AM -0800, Russell Senior wrote:
> >> Okay, I built your usb-linus
> >>
> >> 46490c347df406b3368680dd911620e52dc7bfa4
> >>
> >> with the line:
> >>
> >>r = ch341_control_out(dev, 0x9a, 0x2518, 0x0050);
> >>
> >> commented out. More precisely:
> >
> >> Loopback wo
On Fri, Dec 09, 2016 at 07:38:51AM -0800, Russell Senior wrote:
> > Also, when the above change makes usb-linus works, does changing the
> > word size appear to work after probe?
>
> I'm not sure what changing the word size is supposed to do. The
> usb-linus + previous patch in loopback seems to
On Mon, Dec 12, 2016 at 04:36:54AM -0800, Russell Senior wrote:
> On Mon, Dec 12, 2016 at 1:54 AM, Johan Hovold wrote:
>
> > If you connect the ch340 you have in loopback mode, with the removed
> > initial LCR write that fixed the 5-bit behaviour, can you get that
> > beh
On Mon, Dec 12, 2016 at 07:09:34AM -0800, Russell Senior wrote:
> On Mon, Dec 12, 2016 at 1:54 AM, Johan Hovold wrote:
>
> > Ok, so maybe your device simply does not support changing the line
> > settings more than once. That is, the initial settings chosen are used
> >
On Mon, Dec 12, 2016 at 07:51:59AM -0800, Russell Senior wrote:
> On Mon, Dec 12, 2016 at 7:40 AM, Johan Hovold wrote:
> > On Mon, Dec 12, 2016 at 07:09:34AM -0800, Russell Senior wrote:
> >> On Mon, Dec 12, 2016 at 1:54 AM, Johan Hovold wrote:
> >>
> >> &g
On Mon, Dec 12, 2016 at 10:55:14AM -0500, Alan Stern wrote:
> On Mon, 12 Dec 2016, Johan Hovold wrote:
>
> > Ok, so that seems to confirm the suspicion that changing settings after
> > the initial configuration is failing (even though the device does indeed
> > support 5
below diagnostics patch applied?
Thanks,
Johan
>From b5cff496d8a900af50039e3fc43c6e2ae4d2750c Mon Sep 17 00:00:00 2001
From: Johan Hovold
Date: Mon, 12 Dec 2016 19:02:20 +0100
Subject: [PATCH] USB: serial: ftdi_sio: add set_termios instrumentation
---
drivers/usb/serial/ftdi_sio.c | 10 ++
1 file changed, 6 ins
On Mon, Dec 12, 2016 at 08:03:03AM -0800, Russell Senior wrote:
> On Mon, Dec 12, 2016 at 7:54 AM, Johan Hovold wrote:
> > On Mon, Dec 12, 2016 at 07:51:59AM -0800, Russell Senior wrote:
> >> On Mon, Dec 12, 2016 at 7:40 AM, Johan Hovold wrote:
> >> > On Mon, De
Please do not drop the linux-usb list from CC.
Resending my reply to the list and dropping that (private) sourceforge
list you added from CC.
On Tue, Dec 13, 2016 at 01:47:45PM +0100, Sylvain LG wrote:
> Hello Johan,
>
> I am using the 4.9 kernel provided by Robert C Nelson, from
> Beagleboard
>
ned-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index d133e72fe888..6279df905c14 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -35
R/RTS/CTS")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 6279df905c14..0cc5056b304d 100644
--- a/drivers/usb/serial/ch3
DTR and RST will be asserted by the tty-layer when the port is opened
and deasserted on close (if HUPCL is set). Make sure the initial state
is not-asserted before the port is first opened as well.
Fixes: 6ce76104781a ("USB: Driver for CH341 USB-serial adaptor")
Cc: stable
Signed-off
with testing the quirky class of CH340 devices (which Russel and
possibly also Eddie has), and any other devices which you may have
access too.
The series is against my usb-next branch
git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
Thanks,
Johan
Johan Hovold (13
Rename the shadow modem-status register currently named "line_status" to
the less confusing "msr".
Also rename the helper function used to parse the interrupt data.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 16
1 file changed, 8 insert
mentioned buffering effect.
Let's use the init vendor command only for CH341 devices to be able to
support also such (quirky?) CH340 devices.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 46 +++---
1 file changed, 35 insertions(+), 11 dele
Clean up the control-transfer debug messages by dropping redundant
information and unnecessary casts.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
Rename the shadow modem-control register currently named "line_control"
to the less confusing "mcr".
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/seri
A short control transfer would currently fail to be detected, something
which could lead to stale buffer data being used as valid input.
Check for short transfers, and make sure to log any transfer errors.
Fixes: 6ce76104781a ("USB: Driver for CH341 USB-serial adaptor")
Signed-off
: serial: ch341: remove reset_resume callback")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 8f41d4385f1c..cbe91
(reset-resume).
Fix this by dropping the redundant reconfiguration of the port at every
open, and only read the MSR after the interrupt URB has been submitted.
Fixes: 664d5df92e88 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch
more reasonable
8N1 default instead.
Note that we also need to set the ENABLE_RX bit or receive will be
disabled after a reset during resume.
Also drop a redundant LCR-register read.
Fixes: 6ce76104781a ("USB: Driver for CH341 USB-serial adaptor")
Cc: stable
Signed-off-by: Johan Hovold
-
On Mon, Dec 12, 2016 at 04:15:29PM -0800, Russell Senior wrote:
> On Mon, Dec 12, 2016 at 10:19 AM, Johan Hovold wrote:
> > Can you try also the below diagnostics patch on top of usb-next (not
> > usb-linus this time)?
> >
> > It seems we should be able to revert to s
Make sure to stop the interrupt URB before returning on errors during
open.
Fixes: 664d5df92e88 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletion
reopened.
Fixes: ba781bdf8662 ("USB: serial: ch341: add support for parity, frame
length, stop bits")
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/
On Wed, Dec 14, 2016 at 12:18:53PM +0100, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
>
> drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’:
> drivers/usb/serial/f81534.c:1250: warning: comparison is always false due
> to limited range of data type
>
> f81534_logic_to_phy_port
On Wed, Dec 14, 2016 at 04:28:07PM +0100, Johan Hovold wrote:
> Some CH341 devices appear to require the use of the init vendor command
> to set the baud rate and line-control register. Specifically, while
> using direct register updates for speed and LCR seem to update those
> settin
On Fri, Dec 16, 2016 at 12:39:45PM +, Aidan Thornton wrote:
> On Thu, Dec 15, 2016 at 3:58 PM, Johan Hovold wrote:
> > On Wed, Dec 14, 2016 at 04:28:07PM +0100, Johan Hovold wrote:
> >> Some CH341 devices appear to require the use of the init vendor command
> >> to
On Fri, Dec 16, 2016 at 01:19:05PM +, Aidan Thornton wrote:
> On Wed, Dec 14, 2016 at 3:28 PM, Johan Hovold wrote:
> > The ch341 driver is based on reverse-engineering and contains some bits
> > which appear to be redundant and some which appear incompatible which
>
On Fri, Dec 16, 2016 at 08:04:18AM -0800, Russell Senior wrote:
> Sorry, I got distracted. I'm back now. Do you want me to test your
> 13 patch series? And what is that on top of?
Yes, please. It's against my usb-next branch.
I'll send you a couple of diagnostics patches as well shortly.
Than
On Fri, Dec 16, 2016 at 05:13:50PM +0100, Johan Hovold wrote:
> On Fri, Dec 16, 2016 at 08:04:18AM -0800, Russell Senior wrote:
> > Sorry, I got distracted. I'm back now. Do you want me to test your
> > 13 patch series? And what is that on top of?
>
> Yes, please
On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote:
> All testing is with minicom.
Thanks for this through report.
> Starting with 00013-gc510871:
>
> In 8-bit mode, interoperates correctly with pl2303. Switching to
> 5-bit mode on both sides (I get unicode boxes of indeterminate
On Sun, Dec 18, 2016 at 10:29:27PM +, Sudip Mukherjee wrote:
> The variable havedata was only being set but never used afterwards.
>
> Signed-off-by: Sudip Mukherjee
Thanks, I'll queue this up for 4.11.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the bod
On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
>
> drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’:
> drivers/usb/serial/f81534.c:1250: warning: comparison is always false due
> to limited range of data type
>
> f81534_logic_to_phy_port
On Mon, Dec 19, 2016 at 08:40:53AM -0800, Russell Senior wrote:
> On Mon, Dec 19, 2016 at 2:58 AM, Johan Hovold wrote:
> > On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote:
> >> All testing is with minicom.
> >
> > Thanks for this through report
but it seems it would
not be supported by the vendor (whose version of this driver also uses
the init-command).
Perhaps you could give the attached vendor driver a quick spin just to
confirm that? It's a rebased version against usb-next.
I've also pushed a commit that tries to dump the reg
On Tue, Dec 20, 2016 at 07:31:55AM -0800, Russell Senior wrote:
> On Tue, Dec 20, 2016 at 1:13 AM, Johan Hovold wrote:
> > Perhaps you could give the attached vendor driver a quick spin just to
> > confirm that? It's a rebased version against usb-next.
>
> This is pla
On Tue, Dec 20, 2016 at 04:38:19AM -0800, Russell Senior wrote:
> > I'm not sure what device we're dealing with here, but it seems it would
> > not be supported by the vendor (whose version of this driver also uses
> > the init-command).
> >
> > Perhaps you could give the attached vendor driver a q
On Tue, Dec 20, 2016 at 05:07:48PM +0100, Johan Hovold wrote:
> On Tue, Dec 20, 2016 at 04:38:19AM -0800, Russell Senior wrote:
> > > I'm not sure what device we're dealing with here, but it seems it would
> > > not be supported by the vendor (whose version of this
On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote:
> On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold wrote:
>
> > Perhaps we should determine what else is working or broken first,
> > though.
> >
> > Russel, could you test if break-signalling works
On Mon, Dec 19, 2016 at 12:11:15PM +0100, Johan Hovold wrote:
> On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote:
> > With gcc 4.1.2:
> >
> > drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’:
> > drivers/usb/serial/f81534.c:1250: wa
On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote:
> On Sun, Dec 18, 2016 at 10:29:27PM +, Sudip Mukherjee wrote:
> > The variable havedata was only being set but never used afterwards.
> >
> > Signed-off-by: Sudip Mukherjee
>
> Thanks, I'll queu
On Mon, Jan 02, 2017 at 10:41:03AM +0100, Johan Hovold wrote:
> On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote:
> > On Sun, Dec 18, 2016 at 10:29:27PM +, Sudip Mukherjee wrote:
> > > The variable havedata was only being set but never used afterwards.
> >
Since commit b69578df7e98 ("USB: usbserial: mos7720: add support for
parallel port on moschip 7715"), the interrupt urb is no longer
submitted at first port open and the endpoint-address initialisation at
port-probe is no longer used.
Signed-off-by: Johan Hovold
---
drivers/usb/serial
1 - 100 of 3156 matches
Mail list logo
