[PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-19 Thread Joel Pepper
automatically assign ascending indices when the format is linked into the streaming header, but the user space gadget application would need a way to check or predict the indices so that it can properly interpret PROBE/COMMIT CONTROL requests. Signed-off-by: Joel Pepper --- drivers/usb/gadget/fun

[PATCHv2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-19 Thread Joel Pepper
tos in Documentation/ABI, with note that it was added only in a later kernel version Signed-off-by: Joel Pepper --- Documentation/ABI/testing/configfs-usb-gadget-uvc | 17 + drivers/usb/gadget/function/uvc_configfs.c| 3 +++ 2 files changed, 20 insertions(+) diff --git

Re: [PATCHv2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-20 Thread Joel Pepper
Hi Lauren, On 20.03.2018 10:02, Laurent Pinchart wrote: > Hi Joel, > > (CC'ing Paul Elder who is working on the UVC gadget driver) > > Thank you for the patch. > > On Monday, 19 March 2018 21:36:41 EET Joel Pepper wrote: >> Add bFrameIndex as a UVCG_FRAME_ATTR fo

[PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-20 Thread Joel Pepper
was added only in a later kernel version v3: Changed from simply allowing user to set the value for bFrameIndex to automatically assigning correct distinct frame indexes. Changed bFrameIndex from RW to RO Signed-off-by: Joel Pepper --- Documentation/ABI/testing/configfs

[PATCH v4] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
was added only in a later kernel version v3: Changed from simply allowing user to set the value for bFrameIndex to automatically assigning correct distinct frame indexes. Changed bFrameIndex from RW to RO v4: Actually include updated patch Signed-off-by: Joel Pepper --- Documentation/ABI/

Re: [PATCH v4] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
Please disregard this version, I discovered a different bug which needs to be fixed before the -EBUSY behaviour can implemented, both will come in v5 On 21.03.2018 11:20, Joel Pepper wrote: > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. > - Automatically assign asc

[PATCH v5 2/2] usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into streaming header

2018-03-21 Thread Joel Pepper
While checks are in place to avoid attributes and children of a format being manipulated after the format is linked into the streaming header, the linked flag was never actually set, invalidating the protections. Signed-off-by: Joel Pepper --- drivers/usb/gadget/function/uvc_configfs.c | 3

[PATCH v5 0/2] usb/gadget/uvc-configfs usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
is bug has farther reaching implications, I have included the relevant fix as an independent patch Joel Pepper (2): usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into

[PATCH v5 1/2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

2018-03-21 Thread Joel Pepper
mt is not linked yet Signed-off-by: Joel Pepper --- Documentation/ABI/testing/configfs-usb-gadget-uvc | 18 +++ drivers/usb/gadget/function/uvc_configfs.c| 64 +++ 2 files changed, 82 insertions(+) diff --git a/Documentation/ABI/testing/configfs-usb-gadget-uvc b/Docum

[PATCH v6 2/2] usb/gadget/uvc-configfs Fix host unable to negotiate framesizes other than first

2018-04-26 Thread Joel Pepper
ld frame descriptors and assign ascending indices. The automatically assigned indices can be read from the new read only bFrameIndex configsfs attribute in each frame descriptor item. Signed-off-by: Joel Pepper --- v2: Add the new attribute to both MJPEG and uncompressed frame descriptors in Doc

[PATCH v6 1/2] usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into streaming header

2018-04-26 Thread Joel Pepper
While checks are in place to avoid attributes and children of a format being manipulated after the format is linked into the streaming header, the linked flag was never actually set, invalidating the protections. Signed-off-by: Joel Pepper --- drivers/usb/gadget/function/uvc_configfs.c | 3

[PATCH v6 0/2] Fix host unable to negotiate framesizes other than first

2018-04-26 Thread Joel Pepper
esubmit of v5 which got buried ahead of the last merge window and never got reviewed. The addition to the Documentation has been updated to reflect this. Also moved version comments out of the actual commit message (Thanks, Felipe.) Joel Pepper (2): usb/gadget/uvc-configfs Fix linked flag i

[RFC PATCH] usb: gadget: composite Allow for larger configuration descriptors

2018-04-26 Thread Joel Pepper
other functions. Joel Pepper (1): usb: gadget: composite Allow for larger configuration descriptors include/linux/usb/composite.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

[RFC PATCH] usb: gadget: composite Allow for larger configuration descriptors

2018-04-26 Thread Joel Pepper
to 4096. Signed-off-by: Joel Pepper --- include/linux/usb/composite.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb/composite.h b/include/linux/usb/composite.h index 4b6b928..8675e14 100644 --- a/include/linux/usb/composite.h +++ b/include/linux/usb

Re: [RFC PATCH] usb: gadget: composite Allow for larger configuration descriptors

2018-04-26 Thread Joel Pepper
And here is the actual packet capture that should have been attached in the last mail On 26.04.2018 20:26, Joel Pepper wrote: > I have been doing some work with uvc gadgets, which mirrors the > capabilities of actual webcams attached to a host port. > During testing I ran into -EPIPE er

[RESEND][PATCH v6 2/2] usb/gadget/uvc-configfs Fix host unable to negotiate framesizes other than first

2018-05-29 Thread Joel Pepper
ld frame descriptors and assign ascending indices. The automatically assigned indices can be read from the new read only bFrameIndex configsfs attribute in each frame descriptor item. Signed-off-by: Joel Pepper --- v2: Add the new attribute to both MJPEG and uncompressed frame descriptors in Doc

[RESEND][PATCH v6 0/2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first​

2018-05-29 Thread Joel Pepper
resend got buried too.) Joel Pepper (2): usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into streaming header usb/gadget/uvc-configfs Fix host unable to negotiate framesizes other than first Documentation/ABI/testing/configfs-usb-gadge

[RESEND][PATCH v6 1/2] usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into streaming header

2018-05-29 Thread Joel Pepper
While checks are in place to avoid attributes and children of a format being manipulated after the format is linked into the streaming header, the linked flag was never actually set, invalidating the protections. Signed-off-by: Joel Pepper --- drivers/usb/gadget/function/uvc_configfs.c | 3

Re: [PATCH 2/2] usb: gadget: uvc: configfs: Add bFrameIndex attributes

2018-06-10 Thread Joel Pepper
@Laurent, I accidentally hit "Reply" instead of "Reply All", please disregard the previous copy of this email Hi Laurent and Paul, On 08.06.2018 21:16, Laurent Pinchart wrote: > Hi Joel and Paul, > > On Friday, 8 June 2018 22:12:56 EEST Laurent Pinchart wrote: >> From: Paul Elder >> >> The UVC

Re: [PATCH v7] usb: gadget: uvc: configfs: Add bFrameIndex attributes

2018-06-12 Thread Joel Pepper
Hi Laurent, looks good to me; I have no complaints. On 13.06.2018 00:58, Laurent Pinchart wrote: > From: Joel Pepper > > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. > - Automatically assign ascending bFrameIndex to each frame in a format. > > Befor

uvc-gadget created with configfs sets all bFrameIndex to 1

2018-03-14 Thread Joel Pepper
I am currently working on an application for my master thesis that does transparent inline modification of frames received from a uvc webcam which are served to the actual host through a uvc gadget mimicking the underlying webcam. I recently noticed that the host side v4l2 driver would only ever r

Re: Error reading USB camera in BeagleBone with ARM Debian

2018-10-24 Thread Joel Pepper
ndary, but I'm still reading into the code. If you would like to investigate that further, the C270 is rather affordable, but I will gladly provide any details, usbmon captures etc. that you require. Cheers, Joel Pepper On 19.10.2018 20:06, Josep M. Mirats Tur wrote: > Hi Bin, > >&g