[PATCH 00/16] Fix checkpatch issues in wl_netdev.c

2014-03-17 Thread Jelena Bjelja
This patchset resolves most of checkpatch.pl issues in wlags49_h2/wl_netdev.c Jelena Bjelja (16): staging: wlags49_h2: Use tabs for indentation staging: wlags49_h2: Delete space after open parenthesis staging: wlags49_h2 : Delete space before close parenthesis staging: wlags49_h2: Add

[PATCH 02/16] staging: wlags49_h2: Delete space after open parenthesis

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 628 1 file changed, 314 insertions(+), 314 deletion

[PATCH 03/16] staging: wlags49_h2: Delete space before close parenthesis

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 628 1 file changed, 314 insertions(+), 314

[PATCH 04/16] staging: wlags49_h2: Add space before parenthesis

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: space required before the open parenthesis '(' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 170 1 file changed, 85 insertions(+), 85 deletion

[PATCH 05/16] staging: wlags49_h2: Fix C99 style commenting

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: do not use C99 // comments Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 150 1 file changed, 75 insertions(+), 75 deletions(-) diff --git a/drivers/staging

[PATCH 06/16] staging: wlags49_h2: Enclose macro in a do-while loop

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 12/16] staging: wlags49_h2: Do not use assignment in if condition

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issue in wl_netdev.c: ERROR: do not use assignment in if condition Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2

[PATCH 13/16] staging: wlags49_h2: Remove space between function name and open parenthesis

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issue in wl_netdev.c: WARNING: space prohibited between function name and open parenthesis Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 14/16] staging: wlags49_h2: Fix indentation for conditional statement

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: WARNING: suspect code indent for conditional statements Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff

[PATCH 08/16] staging: wlags49_h2: Move open brace to a previous line

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: that open brace { should be on the previous line Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a

[PATCH 10/16] staging: wlags49_h2: Fix pointer declaration

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issue in wl_netdev.c: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags

[PATCH 15/16] staging: wlags49_h2: Fix multi-line commenting

2014-03-17 Thread Jelena Bjelja
This patch adjusts multi-line comments to “net/” kernel coding style in wl_netdev.c, since the driver depends on WLAN. Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 351 ++-- 1 file changed, 203 insertions(+), 148 deletions(-) diff --git

[PATCH 07/16] staging: wlags49_h2: Remove unnecessary braces

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 35 1 file changed, 9 insertions(+), 26 deletions

[PATCH 09/16] staging: wlags49_h2: Fix 'else should follow close brace'

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issues in wl_netdev.c: ERROR: else should follow close brace '}' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/

[PATCH 11/16] staging: wlags49_h2: Add space around '='

2014-03-17 Thread Jelena Bjelja
This patch fixes the following checkpatch.pl issue in wl_netdev.c: ERROR: spaces required around that '=' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2/wl_n

[PATCH 16/16] staging: wlags49_h2: Fix lines over 80 characters

2014-03-17 Thread Jelena Bjelja
This patch fixes some lines that exceed 80 characters in wl_netdev.c WARNING: line over 80 characters Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 62 +++- 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/drivers/staging

[PATCH v2 00/16] staging: wlags49_h2: Fix checkpatch issues in wl_netdev.c

2014-03-18 Thread Jelena Bjelja
* Use imperative form in a commit log Jelena Bjelja (16): staging: wlags49_h2: Use tabs for indentation staging: wlags49_h2: Delete space after open parenthesis staging: wlags49_h2 : Delete space before close parenthesis staging: wlags49_h2: Add space before parenthesis staging: wlags49_h2

[PATCH v2 03/16] staging: wlags49_h2: Delete space before close parenthesis

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 628 1 file changed, 314 insertions(+), 314 deletions(-) di

[PATCH v2 02/16] staging: wlags49_h2: Delete space after open parenthesis

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 628 1 file changed, 314 insertions(+), 314 deletions(-) di

[PATCH v2 06/16] staging: wlags49_h2: Enclose macro in a do-while loop

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 07/16] staging: wlags49_h2: Remove unnecessary braces

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 35 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a

[PATCH v2 09/16] staging: wlags49_h2: Fix 'else should follow close brace'

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: else should follow close brace '}' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_n

[PATCH v2 08/16] staging: wlags49_h2: Move open brace to a previous line

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: that open brace { should be on the previous line Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/staging

[PATCH v2 04/16] staging: wlags49_h2: Add space before parenthesis

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: space required before the open parenthesis '(' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 170 1 file changed, 85 insertions(+), 85 deletions(-) diff --git

[PATCH v2 11/16] staging: wlags49_h2: Add space around '='

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issue in wl_netdev.c: ERROR: spaces required around that '=' Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drive

[PATCH v2 12/16] staging: wlags49_h2: Do not use assignment in if condition

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issue in wl_netdev.c: ERROR: do not use assignment in if condition Signed-off-by: Jelena Bjelja --- Changes in v2: Delete unnecessary line added in a previous version, noted by Julia Lawall drivers/staging/wlags49_h2/wl_netdev.c |3 ++- 1

[PATCH v2 10/16] staging: wlags49_h2: Fix pointer declaration

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issue in wl_netdev.c: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.

[PATCH v2 13/16] staging: wlags49_h2: Remove space between function name and open parenthesis

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issue in wl_netdev.c: WARNING: space prohibited between function name and open parenthesis Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2

[PATCH v2 16/16] staging: wlags49_h2: Fix lines over 80 characters

2014-03-18 Thread Jelena Bjelja
Where possible, fix lines that exceed 80 characters in wl_netdev.c WARNING: line over 80 characters Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 62 +++- 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/drivers/staging

[PATCH v2 15/16] staging: wlags49_h2: Fix multi-line commenting

2014-03-18 Thread Jelena Bjelja
Adjust multi-line comments to “net/” kernel coding style in wl_netdev.c. Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 351 ++-- 1 file changed, 203 insertions(+), 148 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b

[PATCH v2 14/16] staging: wlags49_h2: Fix indentation for conditional statement

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: WARNING: suspect code indent for conditional statements Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers

[PATCH v2 05/16] staging: wlags49_h2: Fix C99 style commenting

2014-03-18 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: do not use C99 // comments Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 150 1 file changed, 75 insertions(+), 75 deletions(-) diff --git a/drivers/staging/wlags49_h2

[PATCH 1/5] staging: wlags49_h2: Enclose macro in a do-while loop

2014-03-19 Thread Jelena Bjelja
Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 0/5] staging: wlags49_h2: Fix checkpatch issues in wl_netdev.c

2014-03-19 Thread Jelena Bjelja
This patchset fixes most of the checkpatch.pl issues in wl_netdev.c Jelena Bjelja (5): staging: wlags49_h2: Enclose macro in a do-while loop Delete unnecessary spaces Remove trailing whitespace staging: wlags49_h2: Do not use assignment in if condition staging: wlags49_h2: Delete

[PATCH 3/5] Remove trailing whitespace

2014-03-19 Thread Jelena Bjelja
Remove trailing whitespace in wl_netdev.c Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index 8e571b2..eb428ae 100644

[PATCH 2/5] Delete unnecessary spaces

2014-03-19 Thread Jelena Bjelja
:116: Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index 0e553ae..8e571b2 100644 --- a/drivers/staging/wlags49_h2/wl_ne

[PATCH 4/5] staging: wlags49_h2: Do not use assignment in if condition

2014-03-19 Thread Jelena Bjelja
Fix the following checkpatch.pl issue in wl_netdev.c: ERROR: do not use assignment in if condition Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers

[PATCH 5/5] staging: wlags49_h2: Delete unnecessary braces

2014-03-19 Thread Jelena Bjelja
Fix the following checkpatch.pl warnings in wl_netdev.c: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jelena Bjelja --- drivers/staging/wlags49_h2/wl_netdev.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a