[RFC/PATCH] make usbnet work with rndis_host

2008-02-08 Thread Jean-Christophe Dubois
changing rndis_host.c with the wm5 patch). Any comment is welcome. JC Signed-off-by: Jean-Christophe Dubois <[EMAIL PROTECTED]> --- diff -ruN linux-source-2.6.24/drivers/net/usb/usbnet.c linux-source-2.6.24.new/drivers/net/usb/usbnet.c --- linux-source-2.6.24/drivers/net/usb/usbnet.c

Re: [RFC/PATCH] make usbnet work with rndis_host

2008-02-09 Thread Jean-Christophe Dubois
On Saturday 09 February 2008 10:51:06 David Brownell wrote: > A less intrusive fix would make rndis_host.c set dev->maxpacket before > using it, and after calling usbnet_generic_cdc_bind().  That would > be a one-line fix, affecting only the relevant driver ... much safer! > > The problem I have wi

Re: [RFC/PATCH] make usbnet work with rndis_host

2008-02-11 Thread Jean-Christophe Dubois
On Tuesday 12 February 2008 04:07:00 David Brownell wrote: > > So here is the new proposal. > > Which presumably works for your device ... yest it does. > it's looks mostly > OK, other than what scripts/checkpatch.pl will say and the added > > whitespace, but: > > + /* now we need to comput

Re: [RFC/PATCH] make usbnet work with rndis_host

2008-02-11 Thread Jean-Christophe Dubois
On Saturday 09 February 2008 13:44:22 David Brownell wrote: > > > > > In the end it seems to me that dev->in, dev->out and dev->maxpacket are > > generic enough values to be computed in one place whatever driver (bind() > > or not) attach to usbnet. > > > > Plus, as I noted, in the case of CDC-de

Re: [RFC/PATCH] make usbnet work with rndis_host

2008-02-11 Thread Jean-Christophe Dubois
On Saturday 09 February 2008 10:51:06 David Brownell wrote: > So I'd rather see a one-line fix to the RNDIS host code, instead of > this more elaborate approach.  Could you give that a try? So here is the new proposal. Signed-off-by: Jean-Christophe Dubois <[EMAIL PROTECTED]&g

Re: [RFC/PATCH] make usbnet work with rndis_host

2008-02-11 Thread Jean-Christophe Dubois
On Monday 11 February 2008 11:53:12 David Brownell wrote: > They use two interfaces (and potentially more): > >   - Control ... the one passed to probe(), possibly with one interrupt >     endpoint used to send status to the host.  Descriptors are coupled >     to this interface, including the "uni

Re: [RFC/PATCH] make usbnet work with rndis_host

2008-02-14 Thread Jean-Christophe Dubois
Just for my information, is this patch accepted or are you expecting some other changes? Thanks JC On Monday 11 February 2008 17:52:13 Jean-Christophe Dubois wrote: > On Saturday 09 February 2008 10:51:06 David Brownell wrote: > > So I'd rather see a one-line fix to the R