Re: [PATCH] usb-core bInterval quirks

2014-07-22 Thread James Michels
I do believe that I did. + /* Razer - Razer Blade Keyboard */ + { USB_DEVICE(0x1532, 0x0116), .driver_info = + USB_QUIRK_INTERVAL_AS_MICROFRAMES }, + Am I missing something still? Regards Jim On Tue, Jul 22, 2014 at 8:17 PM, Greg KH wrote: > On Tue, Jul 22, 2

Re: [PATCH] usb-core bInterval quirks

2014-07-22 Thread James Michels
I think I understand your concern now. You mean that I am only adding a quirk for the devices with their interval reported as microframes. After reading the code comments about many other vendors having similar issues, I thought it was more complete, and potentially less confusing, for the bInterva

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread James Michels
The Razer reports a bInterval of 8 which the current driver ultimately interprets as 16ms. The keyboard is an anti-ghosting gaming keyboard and needs to be polled at 1ms. This corresponds to a corrected bInterval of 4. I'm not sure why this doesn't make sense to you, but I do agree that there is r

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread James Michels
I must disagree, the device driver most certainly does guess. See the code snipet below. Particularly the part about "guessed" and "try to fix". FWIW, it's the "try to fix" part that doesn't catch this scenario. /* Fix up bInterval values outside the legal range. Use 32 ms if no * proper value can

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread James Michels
OK, will do. Thanks Jim -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] usb-core bInterval quirk

2014-07-27 Thread James Michels
I'll fix it and resubmit. There is no reason I can't get a closing brace right. Sorry. Jim On Sat, Jul 26, 2014 at 9:53 PM, Alan Stern wrote: > On Sat, 26 Jul 2014, James P Michels III wrote: > >> This patch adds a usb quirk to support devices with interupt endpoints >> and bInterval values exp