My name is Jack, from the US. I'm in Syria right now fighting IS. I want to get
to know you better, if I may be so bold. I consider myself an easy-going man,
and I am currently looking for a relationship in which I feel loved.
Please tell me more about yourself, if you don't m
: New USB device found, idVendor=1b1c, idProduct=1b13
usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
Signed-off-by: JackStocker
I need a "real" name here please.
thanks,
greg k-h
As in 'Jack Stocker' is t
Hi Dear, my name is Jack and i am seeking for a relationship in which i will
feel loved after a series of failed relationships.
I am hoping that you would be interested and we could possibly get to know each
other more if you do not mind. I am open to answering questions from you as i
think
ART.
Signed-off-by: Jack Pham
---
drivers/usb/dwc3/debugfs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index d4a30f1..be4eff7 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -56,7 +5
sb-next. I think it would be
good to rebase.
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
sing xhci-hcd
usb 2-1: device descriptor read/8, error -11
usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd
usb 2-1: device descriptor read/8, error -11
Thanks,
Jack
[1] https://lkml.org/lkml/2016/12/9/240
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a
bEndpointAddress 0x04 EP 4 OUT
> bmAttributes2
> Transfer TypeBulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0400 1x 1024 bytes
> bInterval 0
> bMaxBurst 0
> Command pipe (0x01)
What would cause the missing interface descriptor? Looking at
unusual_uas.h, I can see this device's USB product id listed with some
quirks, but if my understanding is correct, it should still work, and
given the presence of the exact ID, I imagine that this device is indeed
supported by the current kernel, but I don't understand why it's not
working as it should. Is this a hardware issue with the JMS567-based
enclosure, or is it a kernel issue?
[1] http://www.jmicron.com/PDF/brief/jms567.pdf
Kind regards,
Jack
signature.asc
Description: OpenPGP digital signature
y to get in contact
with the manufacturer.
Cheers,
Jack
signature.asc
Description: OpenPGP digital signature
iption in your patch).
I believe we chose 6 because it was the first reserved value for the
selector field of the set port feature request. It's simply passed from
the ehset.c driver to the code in ehci-hub.c that eventually handles
this request.
Thanks,
Jack
--
Employee of Qualcomm Innova
PATCH 1/2 is a device driver supporting the Embedded Host High-Speed
Electrical Test (EHSET) test fixture. This driver supports the set of
VID/PIDs specified in the EHSET and activates the various test (TEST_J,
TEST_K, et al) modes by issuing a USB_PORT_FEAT_TEST SetFeature request
to the hub, or b
between.
Signed-off-by: Manu Gautam
Signed-off-by: Jack Pham
---
drivers/usb/host/ehci-hub.c | 144 ++-
drivers/usb/host/ehci-q.c | 101 ++
drivers/usb/misc/ehset.c| 20 ++-
3 files changed, 263 insertions(+), 2
/onthego/EHSET_v1.01.pdf
Signed-off-by: Manu Gautam
[ja...@codeaurora.org: imported from commit 073c9409 on codeaurora.org;
minor cleanup and updated author email]
Signed-off-by: Jack Pham
---
drivers/usb/misc/Kconfig | 13
drivers/usb/misc/Makefile |1 +
drivers/usb/misc/ehset.c | 134
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote:
> The USB Embedded High-speed Host Electrical Test (EHSET) defines the
> SINGLE_STEP_SET_FEATURE test as follows:
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index 2b70277..8e6dc09 100644
> --
between.
Signed-off-by: Manu Gautam
Acked-by: Alan Stern
[ja...@codeaurora.org: imported from commit c2084930 on codeaurora.org;
minor cleanup and updated author email]
Signed-off-by: Jack Pham
---
Changes from RFC:
- replaced reference to non-existent root_hub->children with call
. I kept the
sequence numbering in the subject as it was in response to the RFC
version I originally sent which was the 2/2. Should I resend this as a
standalone (i.e. with a revised subject tag) instead?
Jack
--
Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a
On Mon, Aug 12, 2013 at 05:03:17PM -0400, Alan Stern wrote:
> Okay, I was a little too late and Greg has merged the patch.
>
> Jack or Manu, can you write a follow-on patch that adds a Kconfig
> option to enable test modes in the HCDs, and then avoids compiling the
> new code ad
xHCI/OHCI, etc.) HCD users to code bloat by conditionally
compiling the EHSET-specific additions with a new Kconfig option,
CONFIG_USB_HCD_TEST_MODE.
Cc: Alan Stern
Signed-off-by: Jack Pham
---
drivers/usb/host/Kconfig| 15 +++
drivers/usb/host/ehci-hub.c |8 +++-
driver
xHCI/OHCI, etc.) HCD users to code bloat by conditionally
compiling the EHSET-specific additions with a new Kconfig option,
CONFIG_USB_HCD_TEST_MODE.
Cc: Alan Stern
Signed-off-by: Jack Pham
---
drivers/usb/host/Kconfig| 17 +
drivers/usb/host/ehci-hub.c |8 +++-
d
xHCI/OHCI, etc.) HCD users to code bloat by conditionally
compiling the EHSET-specific additions with a new Kconfig option,
CONFIG_USB_HCD_TEST_MODE.
Cc: Alan Stern
Signed-off-by: Jack Pham
---
Resending with 'v2' in subject tag.
v2: Updated Kconfig description per Alan's comments
re test suite?
>
> I haven't looked at USB??CV spec for a while, maybe Jack knows better ?
I've been going off of
http://www.usb.org/developers/onthego/EHSET_v1.01.pdf which is specific
to OTG and Embedded hosts, but I think it overlaps pretty close with
with what US
On Wed, Aug 14, 2013 at 10:10:23AM -0400, Alan Stern wrote:
> On Tue, 13 Aug 2013, Jack Pham wrote:
>
> > > > In addition, we may want some of the work (though at this point I'm
> > > > not still clear on exactly what parts) to be moved into usbcore.
> >
else
> + desc_idx = 0;
> +
> + ds = ep->descs[desc_idx];
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe
er set". What if actual_length _was_ previously
> set, but it was set to 0?
Alan, your analysis is consistent with our findings as well. We are
seeing that if actual_length got set to 0 in the data stage, then when
the status stage is processed the above else clause ends up overwriting
th
Hi Sarah,
Have you had a chance to look at Alan's response, and my patch below?
Jack
On Tue, Oct 08, 2013 at 07:02:31PM -0700, Jack Pham wrote:
> Hi Sarah, Alan,
>
> I'm taking over reporting of this issue for Hemant while he is out on
> vacation.
>
> On Mon, Oct
d-off-by: Hemant Kumar
Signed-off-by: Jack Pham
---
Hi Sarah,
Here's an RFC I'm hoping will revive this thread:
http://marc.info/?l=linux-usb&m=138128415812207&w=2
The discussion was left hanging after Alan asked:
> } else {
>
ommit 52fb61250a7a132b0cfb9f4a1060a1f3c49e5a25
"xhci-plat: Don't enable legacy PCI interrupts."
Signed-off-by: Jack Pham
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 4265b48..
figured out that the fix was to hang on to the ep0 file handle, and
not always close it, which Michal corroborated in his previous reply.
Hope this helps in your case as well.
Jack
--
Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted b
nge-Id: I07f711bfd380dce212e86b59cf417f84ca7eb006
Signed-off-by: Jack Pham
---
Hi Felipe,
This was found when testing on a virtual simulation platform in
which the DWC3 IP was configured with only a handful of endpoints
as opposed to 32. Do you think this is worthy of cc:stable?
Thanks,
Jack
drivers/usb/dwc3/gadget.c
On Tue, Mar 25, 2014 at 03:39:09PM -0700, Greg KH wrote:
> On Tue, Mar 25, 2014 at 02:11:01PM -0700, Jack Pham wrote:
> > Make dwc3_gadget_resize_tx_fifos() iterate only over IN
> > endpoints that are actually present, based on the
> > num_in_eps parameter. This termina
Make dwc3_gadget_resize_tx_fifos() iterate only over IN
endpoints that are actually present, based on the
num_in_eps parameter. This terminates the loop so as to
prevent dereferencing a potential NULL dwc->eps[i] where
i >= (num_in_eps + num_out_eps).
Signed-off-by: Jack Pham
---
v2: R
number of patches for our "dwc3-msm"
layer to the list for review, but I think they were still held up in the
feedback process. Ivan, what is the status of this?
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To un
Make dwc3_gadget_resize_tx_fifos() iterate only over IN
endpoints that are actually present, based on the
num_in_eps parameter. This terminates the loop so as to
prevent dereferencing a potential NULL dwc->eps[i] where
i >= (num_in_eps + num_out_eps).
Signed-off-by: Jack Pham
---
v3:
Make dwc3_gadget_resize_tx_fifos() iterate only over IN
endpoints that are actually present, based on the
num_in_eps parameter. This terminates the loop so as to
prevent dereferencing a potential NULL dwc->eps[i] where
i >= (num_in_eps + num_out_eps).
Signed-off-by: Jack Pham
---
v3:
ranges;
> +
> + status = "ok";
> +
> + dwc3@1000 {
> + compatible = "snps,dwc3";
> + reg = <0x1000 0xcd00>;
> + interrupts = <
IP to behave in
XHCI rev 1.0. In which case, shouldn't it be done in the glue driver?
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the
memset correctly after
assignment of the trb_link pointer.
Fixes: f6bafc6a1c ("usb: dwc3: convert TRBs into bitshifts")
Signed-off-by: Jack Pham
Cc: sta...@vger.kernel.org
---
drivers/usb/dwc3/gadget.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/dwc
On Thu, Oct 23, 2014 at 09:10:03AM -0500, Felipe Balbi wrote:
> > Fixes: f6bafc6a1c ("usb: dwc3: convert TRBs into bitshifts")
> > Signed-off-by: Jack Pham
> > Cc: sta...@vger.kernel.org
>
> you should add a # v3.4+ after stable email, I'll add that mys
FLAG_POLL_RH, &hcd->flags);
usb_hcd_poll_rh_status(hcd);
+ set_bit(HCD_FLAG_POLL_RH, &xhci->shared_hcd->flags);
+ usb_hcd_poll_rh_status(xhci->shared_hcd);
Thanks,
Jack
--
Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a me
pened to this patch? Looks like [1/3] & [2/3] made it in during
the 3.18 merge, but did this one not get picked up by Kishon?
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list:
y be
intentional, as there isn't any additional handling to be done. So the
case statement can simply be omitted entirely. I'll check with the
original author internally and send a patch.
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux
>
> Any comments are appreciated.
A stab in the dark here but what is the value of GTXFIFOSIZ(X)[15:0]
for epXin on your device? Is it at least wMaxPacketSize? Depending on
the default hardware values it might be deficient as compared to the
working endpoint that gets assigned in your 2-function
idually?
For bisectability would it be better to fix-up Patch 1 to also convert
these two flags to req->needs_extra_trb in one shot? Alternatively you
could sandwich Patch 1 between Patch 8 & 9.
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Hi Bin,
On Tue, Jul 02, 2019 at 09:48:42AM -0500, Bin Liu wrote:
> Hi,
>
> Sorry for the delay getting back on this. I was offline for quite some
> time.
>
> On Thu, Apr 25, 2019 at 03:44:57PM -0700, Jack Pham wrote:
> > Hi Bin,
> >
> > On Mon, Apr 22, 201
/prev pointers are already LIST_POISON1/2. If r->trb is
NULL it should simply exit to 'out0'.
Fixes: cf3113d893d4 ("usb: dwc3: gadget: properly increment dequeue pointer on
ep_dequeue")
Cc: sta...@vger.kernel.org
Signed-off-by: Mayank Rana
Signed-off-by: Jack Pham
---
dr
Hi Felipe,
On Fri, Mar 23, 2018 at 10:05:33AM -0700, Jack Pham wrote:
> dwc3_ep_dequeue() waits for completion of End Transfer command
> using wait_event_lock_irq(), which will release the dwc3->lock
> while waiting and reacquire after completion. This allows a
> potential race
Hi Felipe,
Just wondering if you had a chance to look at this. This fixes a
potential double-delete error which was caught when CONFIG_DEBUG_LIST=y
&& CONFIG_BUG_ON_DATA_CORRUPTION==y.
On Fri, Mar 23, 2018 at 10:05:33AM -0700, Jack Pham wrote:
> From: Mayank Rana
>
> dwc3_e
iption in the bindings doc in PATCH 1/3. And if so, would it be
a duplicate of the child node's extcon binding? Then again, the
alternative would be to grab it directly from the child (i.e.
qcom->dwc3->dev.of_node) which I'm not sure is ok to do or not.
Jack
--
The Qualcomm Inn
On Fri, Apr 13, 2018 at 11:32:04PM +0530, Manu Gautam wrote:
> On 4/13/2018 11:03 PM, Jack Pham wrote:
> > Are the extcon phandles bound to the glue node? I don't see the
> > description in the bindings doc in PATCH 1/3. And if so, would it be
> > a duplicate of the c
ci: rework command timeout and cancellation,")
Signed-off-by: Mayank Rana
Signed-off-by: Jack Pham
---
drivers/usb/host/xhci-hub.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index a
age header
> + * @payload: PD message payload
> + * @ext_msg: PD message extended message data
> + */
> struct pd_message {
> __le16 header;
> - __le32 payload[PD_MAX_PAYLOAD];
> + union {
> + __le32 payload[PD_MAX_PAYLOAD];
> +
sson
> Acked-by: Andy Gross
> ---
> -#include
This file and ehci-msm.c were the last consumers of this header, so it
too can now be deleted. Has your series been picked up yet? If so I or
someone can send a follow-up patch.
Jack
--
The Qualcomm Innovation Center, Inc. is a member of
The last two remaining drivers (ehci-msm.c and phy-msm-usb.c) that
needed this header were recently removed, so delete this now-unused
file.
Signed-off-by: Jack Pham
---
include/linux/usb/msm_hsusb_hw.h | 77
1 file changed, 77 deletions(-)
delete mode
ptors unconditionally,
so remove the checks for gadget speed.
Fixes: f0175ab51993 ("usb: gadget: f_fs: OS descriptors support")
Cc: sta...@vger.kernel.org
Co-Developed-by: Mayank Rana
Signed-off-by: Mayank Rana
Signed-off-by: Jack Pham
---
drivers/usb/gadget/function/f_fs.c | 6 ++
1
d descriptor lookup since
config_ep_by_speed() does that already using the ones found
in struct usb_function.
Fixes: 2bfa0719ac2a ("usb: gadget: function: f_fs: pass companion descriptor
along")
Cc: sta...@vger.kernel.org
Signed-off-by: Jack Pham
---
drivers/usb/gadget/function/f_fs.c | 38 ++
esc = (struct usb_ss_ep_comp_descriptor *)
> + ((u8 *)ds + USB_DT_ENDPOINT_SIZE);
> ep->ep->maxburst = comp_desc->bMaxBurst + 1;
> ep->ep->comp_desc = comp_desc;
> }
Please see my alternativ
, SerialNumber=3
usb 3-3: Product: Corsair K70 RGB Gaming Keyboard
Signed-off-by: Jack Stocker
---
Changes in v4:
- Corrected 'real' name.
Changes in v3:
- Added correct v1 commit message.
Changes in v2:
- Moved K70 entry above Strafe to preserve ascending order.
drivers/usb/core/qu
nufacturer of my
enclosure stating JMS567 has issues with UAS when multiple disks are
involved, but further details weren't provided.
Cheers,
Jack
On 19/05/17 00:30, Christoph Gohle wrote:
> Hi,
>
> I have seen several reports around the internet regarding failing io on
> USB-S
dma_unmap_*()
unless it was peviously mapped. The host core does this already by way
of flags such as URB_DMA_MAP_SINGLE and URB_DMA_MAP_SG which are applied
to urb->transfer_flags and used in the urb map/unmap routines in
hcd.c. Perhaps we can add something similar to udc/core.c?
Thanks,
Jack
Hi Felipe,
On Thu, Jun 29, 2017 at 08:48:17AM +0300, Felipe Balbi wrote:
> Hi Jack,
>
> Jack Pham writes:
> > On Wed, May 17, 2017 at 01:31:12PM +0300, Felipe Balbi wrote:
> >> Some functions might want to have very, very long request queues. We
> >> can'
conditionally called only when req->trb
is non-NULL.
Fixes: cdb55b39fab8 ("usb: dwc3: gadget: lazily map requests for DMA")
Signed-off-by: Jack Pham
---
drivers/usb/dwc3/gadget.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b
dma_addr_t handle. Hence add
a flag 'dma_mapped' to struct usb_request and use this to
determine the need to call dma_unmap_single(). Otherwise, if a
request is not DMA mapped then the result of calling
usb_request_unmap_request() would safely be a no-op.
Signed-off-by: Jack Pham
---
Hi F
Hi Felipe,
Do you have any comments on this?
Thanks,
Jack
On Tue, Aug 01, 2017 at 02:00:56AM -0700, Jack Pham wrote:
> In the SG case this is already handled since a non-zero
> request->num_mapped_sgs is a clear indicator that dma_map_sg()
> had been called. While it would be ni
test which invokes it.
Thanks,
Jack
Jack Pham (2):
usb: xhci: Support enabling of compliance mode for xhci 1.1
usb: misc: lvstest: add entry to place port in compliance mode
Documentation/ABI/testing/sysfs-bus-usb-lvstest | 13
drivers/usb/host/xhci-hub.c
liance tests such as electrical and eye diagram
testing which require CPn patterns to be transmitted.
Signed-off-by: Jack Pham
---
Documentation/ABI/testing/sysfs-bus-usb-lvstest | 13
drivers/usb/misc/lvstest.c | 41 +
2 files changed, 54 inse
s if needed, allow
a test driver (such as drivers/usb/misc/lvstest.c) to send a
SET_FEATURE(PORT_LINK_STATE) control message to the root hub to
update the link state prior to connecting to the port. Subsequently,
placing the port in warm reset would then disable the flag.
Signed-off-by: Jack Pham
-
_map_single(&dev->pdev->dev, ep0out_buf,
> UDC_EP0OUT_BUFF_SIZE * 4,
> DMA_FROM_DEVICE);
> + if (dma_mapping_error(&dev->pdev->dev, dev->dma_addr)) {
> + dev->dma_addr =
On Thu, Sep 07, 2017 at 02:20:17AM +, Thinh Nguyen wrote:
> Hi,
>
> On 6/29/2017 12:54 AM, Jack Pham wrote:
> > A recent optimization was made so that a request put on the
> > pending_list wouldn't get mapped for DMA until just before
> > preparing a TRB for i
it would need to be an additional notifier on top of
dwc3/drd.c which already handles extcon for host/device mode.
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "
initialization.
Clarify "DP" as DisplayPort here?
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to major
On Wed, Sep 27, 2017 at 10:57:41AM -0700, Jack Pham wrote:
> Hi Manu,
>
> On Wed, Sep 27, 2017 at 02:29:10PM +0530, Manu Gautam wrote:
> > VBUS signal coming from PHY must be asserted in device for
> > controller to start operation or assert pull-up. For some
> > platf
Hi Manu,
On Thu, Sep 28, 2017 at 09:30:38AM +0530, Manu Gautam wrote:
> On 9/28/2017 12:46 AM, Jack Pham wrote:
> > On Wed, Sep 27, 2017 at 10:57:41AM -0700, Jack Pham wrote:
> >> On Wed, Sep 27, 2017 at 02:29:10PM +0530, Manu Gautam wrote:
> >>> VBUS signal comin
a no-op
Since usb_put_hcd() doesn't get called for shared_hcd, we end up
with one additional kref count and hence a leak.
Wondering if we need to also remove the xhci->shared_hcd = NULL from
xhci_stop(), in addition to your patches. Thoughts?
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Hi Mathias,
On Wed, Sep 26, 2018 at 02:51:40PM +0300, Mathias Nyman wrote:
> Hi Jack, Peter
>
> On 24.09.2018 19:37, Jack Pham wrote:
> >Hi Peter,
> >
> >On Fri, Sep 21, 2018 at 09:48:43AM +0800, Peter Chen wrote:
> >>Type-C-to-A cable, and the USB3 HC
On Wed, Sep 26, 2018 at 06:34:30PM -0700, Jack Pham wrote:
> Hi Mathias,
>
> On Wed, Sep 26, 2018 at 02:51:40PM +0300, Mathias Nyman wrote:
> > Hi Jack, Peter
> >
> > On 24.09.2018 19:37, Jack Pham wrote:
> > >Hi Peter,
> > >
> > >On F
e_port_status(struct xhci_hcd *xhci,
> > hcd = xhci_to_hcd(xhci);
> > if ((major_revision == 0x03) != (hcd->speed >= HCD_USB3))
> > hcd = xhci->shared_hcd;
> > -
> > + if (!hcd) {
For testing on 4.14 I also added the de
reate both
> HCDs before adding them")
>
> Fixes: fe190ed0d602 ("xhci: Do not halt the host until both HCD have
> disconnected their devices.")
> Cc: Joel Stanley
> Cc: Chunfeng Yun
> Cc: Thierry Reding
> Cc: Jianguo Sun
> Cc:
> Reported-by: Jack
VBUS is momentarily 0V, so at least it is in preparation for when VBUS
turns back on? Or would it be safer to do it during the
SNK_HARD_RESET_SINK_ON state after we know VBUS is back to vSafe5V?
> + else
> + tcpm_set_charge(port, false);
Regards,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan
wrote:
>
> On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote:
> >
> > Hello Badhri,
> >
> > On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote:
> > > During hard reset, TCPM turn
Hi Badhri,
On Thu, Sep 13, 2018 at 04:38:10PM -0700, Badhri Jagan Sridharan wrote:
> On Thu, Sep 13, 2018 at 10:07 AM Jack Pham wrote:
> > On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan
> > > Yeah thats for the source. But for sink, Say if the source isnt PD, then,
&g
b-phy" which already exists then?
Uh, apparently only the bindings doc is there but the driver never
landed. I guess it fell through the cracks nearly 4 years ago.
https://lore.kernel.org/patchwork/patch/499502/
Jorge, does Andy's version of this driver at all resemble what can be
used for QCS404?
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
that the flag is cleared
before it is given back to the function driver. A good place
to do that is in dwc3_gadget_del_and_unmap_request().
Signed-off-by: Jack Pham
---
Hi Felipe,
There's probably zero chance this is making it to 4.20, so if you take
this after 4.21-rc1 so be it. But shou
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
discussed here: https://github.com/ckb-next/ckb-next/issues/42.
Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
Signed-off-by: Jack
control quirk for Corsair Strafe RGB:
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
Previous K70 RGB patch to add delay-init quirk:
7a1646d92257 ("Add delay-init quirk for Corsair K70 RGB keyboards")
Signed-off-by: Jack Stocker
---
Changes in v2:
-
e: compatible list, contains
> "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996,
> +"qcom,msm8998-qusb2-phy" for 10nm PHY on msm8996,
should be 8998.
Thanks,
Jack
--
The Qu
Hi Jorge,
Sorry for the late reply as I was out during the holiday break.
On Fri, Dec 28, 2018 at 01:38:59PM +0100, Jorge Ramirez wrote:
> On 12/20/18 18:37, Jack Pham wrote:
> >Hi Rob, Jorge,
> >
> >On Thu, Dec 20, 2018 at 11:05:31AM -0600, Rob Herring wrote:
> >>
that the flag is cleared
before it is given back to the function driver. A good place
to do that is in dwc3_gadget_del_and_unmap_request().
Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: sta...@vger.kernel.org
Signed-off-by: Jack Pham
---
v2: Added F
. Did you mean to s/ret/len/ in the
snprintf() calls below?
Alternatively couldn't you just use 'ret' as an accumulator each time
snprintf() is called to keep count of the bytes written to the buffer
instead of needing to call strlen() [O(n) each time] multiple times?
Thank
freeing the SG list is premature and incorrect, as it will get freed in
either the tx_complete/tx_done path or upon URB submission failure.
> spin_unlock_irqrestore(&dev->txq.lock, flags);
> netdev_dbg(dev->net, "Delaying transmission for resumption\n");
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
d. The
mac in this case is a 2013 macbook pro. Any pointers in the right
direction would be greatly appreciated.
Regards,
Jack.
[ 141.300412] dwc2 ff58.usb: ep1in: req 58615452: 337@a3ab679a, noi=0,
zero=1, snok=0
[ 141.300418] dwc2 ff58.usb: dwc2_hsotg_handle_unaligned_buf_start: ep1in:
On 22/08/2019 17:06, Jack Mitchell wrote:
> I'm having issues on a Firefly rk3288 board when trying to use USB
> gadget ethernet on macOS. The dr_mode is set to "otg" and it works fine
> with my Linux desktop.
>
> If I set the dr_mode to "peripheral" macO
uld be fine.
Signed-off-by: Jack Pham
---
drivers/usb/gadget/composite.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index e1db94d1fe2e..92ce3018f482 100644
--- a/drivers/usb/gadget/compos
which uses 2mA units.
Replace the switch with a simple if/else.
Fixes: eae5820b852f ("usb: gadget: composite: Write SuperSpeedPlus config
descriptors")
Cc: sta...@vger.kernel.org
Signed-off-by: Jack Pham
---
drivers/usb/gadget/composite.c | 8 +++-
1 file changed, 3 insertions(+), 5
On Tue, Oct 22, 2019 at 11:57:53PM -0700, Jack Pham wrote:
> USB 3.x SuperSpeed peripherals can draw up to 900mA of VBUS power
> when in configured state. However, if a configuration wanting to
> take advantage of this is added with MaxPower greater than 500
> (currently possibl
93 matches
Mail list logo
