Hi,
On Tue, Jan 15, 2013 at 02:12:51PM +0530, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
>
> Writing to
On Thu, Jan 17, 2013 at 04:44:52PM +0530, kishon wrote:
> >>@@ -171,6 +188,11 @@ static inline void devm_usb_put_phy(struct device
> >>*dev, struct usb_phy *x)
> >> {
> >> }
> >>
> >>+static inline struct usb_phy_bind *usb_bind_phy(const char *dev_name, u8
> >>index,
> >>+
On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote:
> New platforms are being added which has multiple PHY's (of same type) and
> which has multiple USB controllers. The binding information has to be
> present in the PHY library (otg.c) in order for it to return the
> appropriat
Hi,
On Fri, Jan 18, 2013 at 03:10:42PM +0530, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
>
> Writing to
On Fri, Jan 18, 2013 at 03:10:43PM +0530, Kishon Vijay Abraham I wrote:
> A seperate driver has been added to handle the usb part of control
> module. A device for the above driver is created here, using the register
> address information to be used by the driver for powering on the PHY and
> for w
Hi,
On Fri, Jan 18, 2013 at 03:10:45PM +0530, Kishon Vijay Abraham I wrote:
> Start using the control module driver for powering on the PHY and for
> writing to the mailbox instead of writing to the control module
> registers on their own.
>
> Signed-off-by: Kishon Vijay Abraham I
> ---
> Docum
On Fri, Jan 18, 2013 at 07:48:14PM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget
> head: 7620f5f22e9317ab26c0fdbdd15c5e9ed972ef89
> commit: 84b140524c107fb4f4fe618509bc067245c9d878 [19/61] usb: phy: mv_usb2:
> add PHY driver for marv
Hi,
On Fri, Jan 18, 2013 at 05:40:04PM +0530, kishon wrote:
> >>+void omap_control_usb_host_mode(struct device *dev)
> >>+{
> >>+ u32 val;
> >>+ struct omap_control_usb *control_usb = dev_get_drvdata(dev);
> >>+
> >>+ val = AVALID | VBUSVALID;
> >>+
> >>+ writel(val, control_usb->otghs_con
Hi,
On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> This patch-set enables the samsung-usbphy driver on exynos5250,
> which enables the support for USB2 type and USB3 type phys.
> The corresponding phy driver patches are available at:
> 1) https://lkml.org/lkml/2012/12/18/201
> 2
On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote:
> > This patch-set enables the samsung-usbphy driver on exynos5250,
> > which enables the support for USB2 type and USB3 type phys.
>
On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote:
> Adding the phy driver to ehci-s5p. Keeping the platform data
> for continuing the smooth operation for boards which still uses it
>
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
Missing Alan's Acked-by here.
--
balbi
sig
Hi,
On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote:
> This patch adds host phy support to samsung-usbphy driver and
> further adds support for samsung's exynos5250 usb-phy.
>
> Signed-off-by: Praveen Paneri
> Signed-off-by: Vivek Gautam
Missing Kukjim's Acked-by here
--
balbi
On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote:
> >> This patch adds host phy support to
On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote:
> HI Balbi,
>
>
> On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote:
> > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote:
> >> Hi Felipe,
> >>
> >>
> >> On Fri, J
Hi Greg,
Here are my latest fixes for this -rc cycle. Unless something
extremely important shows up, we should be ready for a final
v3.8 ;-)
Hopefully no surprises will come.
ps: You will notice a few changes on arch/arm/mach-imx/ but they're needed to
make fsl build and work again. We _do_ have
On Fri, Jan 18, 2013 at 10:28:38AM -0700, Stephen Warren wrote:
> On 01/18/2013 08:30 AM, Alan Stern wrote:
> > On Fri, 18 Jan 2013, Venu Byravarasu wrote:
> >
> >> As Tegra PHY driver needs to access one of the Host registers,
> >> added few APIs.
> >>
> >> Signed-off-by: Venu Byravarasu
> >> --
ram to get this info and
> processed accordingly.
>
> Signed-off-by: Venu Byravarasu
Acked-by: Felipe Balbi
> ---
> drivers/usb/phy/tegra_usb_phy.c | 32 +++-
> include/linux/usb/tegra_usb_phy.h |1 +
> 2 files changed, 16 insertions(+
;
> Signed-off-by: Venu Byravarasu
Acked-by: Felipe Balbi
> ---
> drivers/usb/phy/tegra_usb_phy.c | 23 +--
> include/linux/usb/tegra_usb_phy.h |1 +
> 2 files changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/usb/phy/tegra_usb_
Hi,
On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
> Changes from v8:
> Resending this patch series after rebasing to the latest usb-next branch.
> Rewording inline comments for better readability.
> Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check for dt
> s
Hi,
On Thu, Jan 17, 2013 at 04:23:48PM +0530, Bhupesh Sharma wrote:
> This patchset tries to enhance the UVC webcam gadget driver and
> is based on Laurent's git tree available here (head uvc-gadget):
> git://linuxtv.org/pinchartl/uvcvideo.git
>
> Note that to ease review and integration of these
Hi,
On Sun, Dec 02, 2012 at 05:33:36PM +0200, Dmitry Lifshitz wrote:
> Hi,
>
> We are running kernel v3.5.7 on am3517 based hardware (CM-T3517 module).
> Recently we faced with the following issue: am35x MUSB module fails
> when trying to reinsert it.
> It fails with the message "musb-hdrc.0: fai
On Fri, Jan 18, 2013 at 11:23:08AM -0800, Greg KH wrote:
> On Fri, Jan 18, 2013 at 10:24:39AM +0200, Felipe Balbi wrote:
> > regset is a generic implementation of regdump
> > utility through debugfs.
> >
> > Signed-off-by: Felipe Balbi
> > ---
> >
> &g
Hi,
On Fri, Jan 18, 2013 at 03:56:12PM -0500, Shane Whalen wrote:
> I am having problems with the 3.6 musb kernel driver. I am running
> testusb.c and test.sh to try and diagnose where the problem may live.
> Here are the outputs from the 'unlink' and 'control' tests.
>
> Host setup: 3.6.5-rt14-d
On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> Signed-off-by: Pali Rohár
NAK for two reasons:
a) the original Nokia kernel used a separate g_file_storage gadget to
use Mass Storage mode, use that
b) there is no commit log
--
balbi
signature.asc
Description: Digital si
Hi,
On Fri, Jan 18, 2013 at 03:43:59PM -0800, Greg KH wrote:
> On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote:
> >
> > From: fangxiaozhi
> >
> > 1. Optimize the matching rules with new macro for Huawei USB storage
> >devices, to avoid to load USB storage driver for the
Hi,
On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote:
> On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> > On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> > > Signed-off-by: Pali Rohár
> >
> > NAK for two reasons:
> >
>
Hi,
On Mon, Jan 21, 2013 at 01:32:09PM +0800, victor yeo wrote:
> >> > This log looks oddly incomplete. A lot of debugging messages are
> >> > missing.
> >> >
> >> >> g_file_storage gadget: ep0-setup, length 8:
> >> >> : 80 06 00 01 00 00 40 00
> >> >> g_file_storage gadget: get device de
Hi,
On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote:
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, January 18, 2013 8:05 PM
> To: kbuild test robot
> Cc: Chao Xie; linux-usb@vger.kernel.org; Felipe Balbi
> Subject: Re: [balb
Hi,
On Mon, Jan 21, 2013 at 04:15:32PM +0800, victor yeo wrote:
> Hi,
>
> >> >> >> g_file_storage gadget: ep0-setup, length 8:
> >> >> >> : 80 06 00 01 00 00 40 00
> >> >> >> g_file_storage gadget: get device descriptor
> >> >> >
> >> >> > For example, right here we should see the device
Hi,
On Mon, Jan 21, 2013 at 04:51:28PM +0900, Norbert Preining wrote:
> Hi everyone,
> (please Cc)
>
> I am currently running 3.8.0-rc4 and see the following behaviour:
> When I plug/eject my kindle a few times, suddenly the kernel does
> not see any USB activity any more. Nothing. PLugging in th
Hi,
On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam
> wrote:
> > Changes from v2:
> > - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating
> >usb 2.0 phy controller's driver for Samsung's SoCs.
>
Hi,
On Mon, Jan 21, 2013 at 04:38:32PM +0800, Fengguang Wu wrote:
> On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote:
> > On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote:
> [snip]
> > > I am formatting and re-test the patches. I will send ou
On Mon, Jan 21, 2013 at 04:45:03PM +0800, victor yeo wrote:
> Hi,
>
> >> > ep0_complete() should be called by your UDC driver. Seriously dude, read
> >> > the documentation and read other drivers to figure out how things should
> >> > be called. A quick look in the storage drivers would have shown
Hi,
On Mon, Jan 21, 2013 at 07:13:03PM +0800, victor yeo wrote:
> >> >> Yes, ep0_complete() is called in UDC driver queue function, i just
> >> >> added it in and ep0_complete() is called now. The dmesg output is
> >> >> below.
> >> >
> >> > not in queue function, you should call it when completin
esult of devm_kzalloc() call to
the 'config' variable but then checks for NULL the 'data' variable (already
checked after previous call). Thus we risk a kernel oops further when data
pointed by 'config' is written to by subsequent of_property_read_u32() call
On Mon, Jan 21, 2013 at 11:14:19PM +0800, victor yeo wrote:
> Hi,
>
> >> >> >> Yes, ep0_complete() is called in UDC driver queue function, i just
> >> >> >> added it in and ep0_complete() is called now. The dmesg output is
> >> >> >> below.
> >> >> >
> >> >> > not in queue function, you should cal
ination
> with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless
> someone has an better solution.
>
> Without this patch, building allyesconfig results in:
>
> drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such
> file or directory
>
> S
On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote:
> In linux-3.8-rc1 it became possible to build the imx and
> mvebu platforms together in a single kernel, which clashes
> in the ehci driver.
>
> Manjunath Goudar is already working on a patch to convert
> both the imx and the mvebu gl
icit
> error messages can be removed from the failure code paths.
>
> Signed-off-by: Thierry Reding
> Cc: Greg Kroah-Hartman
> Cc: Alan Stern
> Cc: Felipe Balbi
> Cc: linux-usb@vger.kernel.org
For drivers/usb/renenas, drivers/usb/otg, drivers/usb/phy,
drivers/usb/musb and driv
On Mon, Jan 21, 2013 at 10:57:16AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote:
> > > Both the fsl_mxc gadget and the imx_ud
Hi,
On Tue, Jan 22, 2013 at 11:47:09AM +0800, victor yeo wrote:
> >> > >> Some progress, now i am able to see the dump_msg from ep0_complete().
> >> > >> It looks like the enumeration is ok, but the SCSI Inquiry command is
> >> > >> not received by the UDC driver. The do_scsi_command() in
> >> > >
Hi,
On Tue, Jan 22, 2013 at 11:18:55AM +0530, Vivek Gautam wrote:
> On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim wrote:
> > Sylwester Nawrocki wrote:
> >>
> >> On 12/24/2012 09:13 AM, Vivek Gautam wrote:
> >> These two changes look good to me. For both of them:
> >>
> >> Reviewed-
HI,
On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote:
> Vivek Gautam wrote:
> >
> > Changes from v5:
> > - Rebased on top of latest patches:
> > usb: phy: samsung: Introducing usb phy driver for hsotg (v9)
> > usb: phy: samsung: Add support to set pmu isolation (v6)
> >
Hi,
On Tue, Jan 22, 2013 at 10:52:41AM +0900, Norbert Preining wrote:
> Hi Felipe, hi all,
>
> On Mo, 21 Jan 2013, Felipe Balbi wrote:
> > Can you try rebuilding your kernel with CONFIG_USB_DEBUG=y and run your
> > test again ? Maybe it gives us more information of what&#
HI,
On Tue, Jan 22, 2013 at 06:04:53PM +0900, Norbert Preining wrote:
> Hi
>
> > I need to see what happens before the problem shows up. Your log starts
> > after the problem has already triggered.
>
> It is a cycle, it repeats after the lsusb -v when it is back to
> normal. So reading from *aft
Hi,
On Tue, Jan 22, 2013 at 05:22:58PM +0800, victor yeo wrote:
> >> >> > Is there any way to to further debug into why do_scsi_command() is
> >> >> > not called?
> >> >>
> >> >> usbmon, printk(), trace_printk(), kernel function tracer, there are many
> >> >> ways choose one and spend some time d
On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote:
> > HI,
> >
> > On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote:
> >> Vivek Gautam wrote:
> >> >
HI,
On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote:
> On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote:
> > Hi Felipe,
> >
> >
> > On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote:
> > > HI,
> > >
> > > On M
HI,
On Tue, Jan 22, 2013 at 04:26:50PM +0530, Venu Byravarasu wrote:
> As drivers/usb/otg/otg.c contains most of the PHY related APIs
> which are not OTG specific, moving them to more logical place
> under driver/usb/phy.
>
> Signed-off-by: Venu Byravarasu
> ---
> drivers/usb/otg/otg.c| 18
Hi,
On Tue, Jan 22, 2013 at 04:31:11PM +0530, Venu Byravarasu wrote:
> As drivers/usb/otg/otg.c contains most of the PHY related APIs
> which are not OTG specific, moving them to more logical place
> under driver/usb/phy.
>
> Signed-off-by: Venu Byravarasu
> ---
> delta from v1:
> Missed adding
On Tue, Jan 22, 2013 at 10:49:50PM +0800, victor yeo wrote:
> Hi,
>
> >> >> > It sounds like the UDC driver now works okay for control transfers but
> >> >> > not for bulk transfers.
> >> >> >
> >> >>
> >> >> Some code in file_storage.c that i cannot understand. In
> >> >> ep0_complete(), the code
Hi,
On Tue, Jan 22, 2013 at 12:03:09PM +0100, Pali Rohár wrote:
> On Monday 21 January 2013 09:05:06 Felipe Balbi wrote:
> > Hi,
> >
> > On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote:
> > > On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> &g
Hi,
On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote:
> Felipe Balbi wrote:
> > Hi,
> >
> Hi Felipe,
>
> [...]
>
> > > Right, DWC has version number, but that being the kind of USB controller
> > > (USB 2.0 and USB 3.0)
> > >
&g
Hi,
On Wed, Jan 23, 2013 at 03:10:50PM +0800, victor yeo wrote:
> >> >> Ok, rephrase the question, is this the flow for bulk transfer?
> >> >>
> >> >> 1) data is received by Usb mass storage HW, the UDC driver ISR is
> >> >> called to read the data to usb_request buffer
> >> >> 2) bulk_out_complet
Hi,
On Wed, Jan 23, 2013 at 06:04:55PM +0800, victor yeo wrote:
> Hi,
>
> >> >> >> Ok, rephrase the question, is this the flow for bulk transfer?
> >> >> >>
> >> >> >> 1) data is received by Usb mass storage HW, the UDC driver ISR is
> >> >> >> called to read the data to usb_request buffer
> >> >
Hi,
On Wed, Jan 23, 2013 at 07:17:44PM +0800, victor yeo wrote:
> >> >> In fsg_dev structure, there are 3 usb_ep: bulk_in, bulk_out, and
> >> >> intr_in. Why is the intr_out endpoint not defined?
> >> >
> >> > because it's not needed. Read the USB Mass Storage Class specification
> >> > from usb.o
Hi,
On Mon, Jan 21, 2013 at 07:38:26PM +0530, Kishon Vijay Abraham I wrote:
> A seperate driver has been added to handle the usb part of control
> module. A device for the above driver is created here, using the register
> address information to be used by the driver for powering on the PHY and
>
Hi,
On Wed, Jan 23, 2013 at 07:35:41PM +0800, victor yeo wrote:
> Hi,
>
> >> >> Ok. In the gadget driver, it keeps on receiving the same bulk_out
> >> >> data, maybe because the data is not processed. The get_next_command is
> >> >> not called.
> >> >>
> >> >> g_file_storage gadget: bulk-out, len
Hi,
On Tue, Jan 22, 2013 at 10:51:32AM +0800, Chao Xie wrote:
> On Mon, Jan 21, 2013 at 11:51 PM, Russell King - ARM Linux
> wrote:
> > On Mon, Jan 21, 2013 at 05:07:36AM -0500, Chao Xie wrote:
> >> + mv_phy->extern_chip.head = devm_kzalloc(&pdev->dev,
> >> +
Hi,
On Mon, Jan 21, 2013 at 05:07:18AM -0500, Chao Xie wrote:
> The patches are divied into 4 parts
> 1. bug fixes
> usb: gadget: mv_udc: use udc_start and udc_stop functions
> usb: gadget: mv_udc: use devm_xxx for probe
> usb: gadget: mv_udc: fix the warning of mv_udc_remove
> usb: otg: m
Hi,
On Wed, Jan 23, 2013 at 08:24:36PM +0800, victor yeo wrote:
> >> >> In my udc driver, i set the req->length to the number of bytes i
> >> >> received from HW, which is 31 bytes. Is it necessary to do that? How
> >> >
> >> > you shouldn't touch req->lenght, you should only update req->actual.
>
Hi,
On Wed, Jan 23, 2013 at 11:20:56PM +0800, victor yeo wrote:
> Hi,
>
> >> Here are the last two setup data and CBW data received. the
> >> get_next_command() is not called when CBW data is received. the
> >> bulk_out_complete() wakes up the thread, however, get_next_command()
> >> still sleeps
On Thu, Jan 24, 2013 at 02:37:32PM +0800, victor yeo wrote:
> Hi,
>
> >> >> Here are the last two setup data and CBW data received. the
> >> >> get_next_command() is not called when CBW data is received. the
> >> >> bulk_out_complete() wakes up the thread, however, get_next_command()
> >> >> still
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/amd5536udc.c | 59 ++---
drivers/usb/gadget/amd5536udc.h | 2 ++
2 files changed, 16 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fusb300_udc.c | 65 +++-
drivers/usb/gadget/fusb300_udc.h | 2 ++
2 files changed, 20 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/goku_udc.c | 70 +--
drivers/usb/gadget/goku_udc.h | 1 +
2 files changed, 15 insertions(+), 56
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fsl_udc_core.c | 58 ---
1 file changed, 11 insertions(+), 47 deletions(-)
diff --git a/drivers/usb
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/m66592-udc.c | 70 +++--
drivers/usb/gadget/m66592-udc.h | 1 +
2 files changed, 20 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pch_udc.c | 67 +---
1 file changed, 14 insertions(+), 53 deletions(-)
diff --git a/drivers/usb
Those have been deprecated for a long time and
previous patches just converted all remaining
users of those.
Since there are no in-tree users and we don't
want any new users for them, let's obliterate
every piece of code related to those calls.
Signed-off-by: Felipe Balbi
---
d
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/omap_udc.c | 49 +++
1 file changed, 12 insertions(+), 37 deletions(-)
diff --git a/drivers/usb
Hi,
On Thu, Jan 24, 2013 at 04:25:24PM +0800, victor yeo wrote:
> Hi,
>
> >> > you should an interrupt handler to handle interrupts from your device.
> >> > Also, there are way too many mistakes on your driver, run checkpatch.pl,
> >> > compile it with sparse, don't hardcode addresses, don't reim
Hi,
On Thu, Jan 24, 2013 at 01:38:31AM -0500, Chao Xie wrote:
> Only ARCH_PXA and ARCH_MMP will use mv_udc.
>
> Signed-off-by: Chao Xie
NAK, you should fix your transceiver dependency. I want these gadget
drivers to compile cleanly on all arches so we make proper use of
linux-next. I have appli
code has been wrong forever, so
this should be backported as far back as
possible.
Cc:
Signed-off-by: Felipe Balbi
---
It's getting late for v3.8-rc cycle, so I'll send
this on v3.9 merge window with backport for stable
tree.
drivers/usb/dwc3/gadget.c | 7 +--
1 file change
Hi,
On Thu, Jan 24, 2013 at 06:23:08PM +0800, victor yeo wrote:
> Hi,
>
> >> >> > Also, you shouldn't requeue the request yourself, gadget driver owns
> >> >> > the
> >> >> > request.
> >> >> which request do i requeue? please kindly point that out. Thanks!
> >> >
> >> > look at your code. Look
Hi,
On Thu, Jan 24, 2013 at 08:14:25PM +0800, victor yeo wrote:
> Hi,
>
> >> >> is it this code? i will remove the redundant code after complete.
> >> >>
> >> >> ka_ep_p->req.complete(&ka_ep_p->ep, &req->req);
> >> >> if (num == 0) {
> >> >> ka_ep_p->req.length = 0
Hi,
On Thu, Jan 24, 2013 at 03:57:03PM +0530, Venu Byravarasu wrote:
> As pointer to PHY structure can be stored in struct usb_hcd
> making use of it, to call Tegra PHY APIs.
>
> Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(),
> so that to avoid dereferencing of hcd after its freed
On Thu, Jan 24, 2013 at 03:35:58PM +0100, Michael Grzeschik wrote:
> On Thu, Jan 24, 2013 at 03:21:37PM +0100, Laurent Pinchart wrote:
> > Hi Michael,
> >
> > On Thursday 24 January 2013 14:54:01 Michael Grzeschik wrote:
> > > On Thu, Jan 24, 2013 at 12:02:12PM +0100, Laurent Pinchart wrote:
> > >
HI,
On Thu, Jan 24, 2013 at 11:01:24AM +0200, Felipe Balbi wrote:
> Mechanical change making use of the new (can we
> still call it new ?) interface for registering
> UDC drivers.
>
> Signed-off-by: Felipe Balbi
I'll resend this series, my grep missed pxa folks.
--
b
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/amd5536udc.c | 59 ++---
drivers/usb/gadget/amd5536udc.h | 2 ++
2 files changed, 16 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fusb300_udc.c | 65 +++-
drivers/usb/gadget/fusb300_udc.h | 2 ++
2 files changed, 20 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/goku_udc.c | 70 +--
drivers/usb/gadget/goku_udc.h | 1 +
2 files changed, 15 insertions(+), 56
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/fsl_udc_core.c | 58 ---
1 file changed, 11 insertions(+), 47 deletions(-)
diff --git a/drivers/usb
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/m66592-udc.c | 70 +++--
drivers/usb/gadget/m66592-udc.h | 1 +
2 files changed, 20 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/omap_udc.c | 49 +++
1 file changed, 12 insertions(+), 37 deletions(-)
diff --git a/drivers/usb
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pch_udc.c | 67 +---
1 file changed, 14 insertions(+), 53 deletions(-)
diff --git a/drivers/usb
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pxa25x_udc.c | 62 ++---
drivers/usb/gadget/pxa25x_udc.h | 1 +
2 files changed, 15 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/pxa27x_udc.c | 58 +++--
drivers/usb/gadget/pxa27x_udc.h | 1 +
2 files changed, 16 insertions
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/s3c2410_udc.c | 65
drivers/usb/gadget/s3c2410_udc.h | 1 +
2 files changed, 13 insertions
Those have been deprecated for a long time and
previous patches just converted all remaining
users of those.
Since there are no in-tree users and we don't
want any new users for them, let's obliterate
every piece of code related to those calls.
Signed-off-by: Felipe Balbi
---
d
Mechanical change making use of the new (can we
still call it new ?) interface for registering
UDC drivers.
Signed-off-by: Felipe Balbi
---
Had missed a trailing gadget->disconnect() call.
drivers/usb/gadget/pxa27x_udc.c | 61 ++---
drivers/usb/gad
On Thu, Jan 24, 2013 at 04:05:16PM +0100, Laurent Pinchart wrote:
> Hi Felipe,
>
> On Thursday 24 January 2013 16:42:50 Felipe Balbi wrote:
> > On Thu, Jan 24, 2013 at 03:35:58PM +0100, Michael Grzeschik wrote:
> > > On Thu, Jan 24, 2013 at 03:21:37PM +0100, Laurent Pi
, we're adding
a flag which will be set by UDC driver once
it removes the code for registering the
gadget device.
Once all are converted, the new flag will
be removed.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc-core.c | 23 +++
include/linux/usb/gadget.h
By simply setting a flag, we can delete a little
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_gadget.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index 8767874..1c4a8e8
By simply setting a flag, we drop some boilerplate
code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/omap_udc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index d0c87b1..234e82b 100644
By simply setting a flag, we can drop some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/bcm63xx_udc.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c
index 47a4993..10b0475
By simply setting a flag, we can remove some
boilerplate code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/at91_udc.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 10f45fa..177b56d
We don't need to register that device ourselves
if we simply set gadget->register_my_device.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/
Hi folks,
Please comment on this series as I need help testing it
on all UDC controllers so we can send it for v3.10 merge
window.
NOTE: I will queue this series for v3.10 merge window, so
make sure to test and comment.
cheers
Felipe Balbi (32):
usb: gadget: udc-core: allow udc class
By simply setting a flag, we drop some boilerplate
code.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/amd5536udc.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index 3dac001..1827d4c 100644
501 - 600 of 8014 matches
Mail list logo
