[PATCH 1/1 linux-next] usb: isp1301-omap: don't opencode IS_REACHABLE()

Signed-off-by: Fabian Frederick --- drivers/usb/phy/phy-isp1301-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c index 8d111ec..042c5a8 100644 --- a/drivers/usb/phy/phy-isp1301-omap.c +++ b/drivers

[PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772_unbind

inline this one line function used in driver_info structure Cc: "David S. Miller" Cc: Emil Goode Cc: linux-usb@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/net/usb/asix_devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/asix

[PATCH 1/2] drivers/net/usb/asix_devices.c: remove null test before kfree

Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: "David S. Miller" Cc: Emil Goode Cc: linux-usb@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/net/usb/asix_devices.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH 1/1] drivers/usb/host/fhci-dbg.c: remove unnecessary null test before debugfs_remove

This fixes checkpatch warning: "WARNING: debugfs_remove(NULL) is safe this check is probably not required" Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/usb/host/fhci-dbg.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletion

[PATCH 1/1] drivers/usb/serial/mos7840.c: remove unnecessary null test before kfree

Cc: Johan Hovold Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/usb/serial/mos7840.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 393be56..3d88eef

[PATCH 09/10 linux-next] USB: ftdi_sio: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/serial/ftdi_sio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index b9035c3..bb45c71 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -2414,7

[PATCH 05/10 linux-next] usb: gadget: remove unnecessary break after goto

Signed-off-by: Fabian Frederick --- drivers/usb/gadget/function/f_hid.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index a95290a..21c4b9c 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb

[PATCH 08/10 linux-next] USB: serial: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/serial/iuu_phoenix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c index 5ad4a0f..705e9dd 100644 --- a/drivers/usb/serial/iuu_phoenix.c +++ b/drivers/usb/serial

[PATCH 06/10 linux-next] xhci: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/host/xhci-mem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 8056d90..aa5eb64 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -1129,7 +1129,6 @@ int

[PATCH 07/10 linux-next] usb: storage: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/storage/freecom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/storage/freecom.c b/drivers/usb/storage/freecom.c index ef16068..e6f8c1f 100644 --- a/drivers/usb/storage/freecom.c +++ b/drivers/usb/storage/freecom.c @@ -417,7

[PATCH 04/10 linux-next] usb: gadget: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/legacy/tcm_usb_gadget.c b/drivers/usb/gadget/legacy/tcm_usb_gadget.c index 6cdb7a5..fb7cbb4 100644 --- a/drivers/usb/gadget/legacy

[PATCH 03/10 linux-next] usb: dcw3: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/dwc3/ep0.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 21a3520..927dad3 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -422,7 +422,6 @@ static int

[PATCH 01/10 linux-next] USB: iowarrior: remove unnecessary break after goto

Signed-off-by: Fabian Frederick --- drivers/usb/misc/iowarrior.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index c6bfd13..17ce9a4 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -381,7 +381,6

[PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Fabian Frederick (10): USB: iowarrior: remove unnecessary break after goto USB: usblcd: remove unnecessary break after return usb: dcw3: remove unnecessary break after return usb: gadget: remove

[PATCH 02/10 linux-next] USB: usblcd: remove unnecessary break after return

Signed-off-by: Fabian Frederick --- drivers/usb/misc/usblcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 1184390..5085d69 100644 --- a/drivers/usb/misc/usblcd.c +++ b/drivers/usb/misc/usblcd.c @@ -190,7 +190,6 @@ static long

[PATCH 10/10 linux-next] USB: microtek: remove unnecessary break after goto

Signed-off-by: Fabian Frederick --- drivers/usb/image/microtek.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c index 37b44b0..5cf2111 100644 --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -294,7 +294,6

Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

> On 24 July 2014 at 13:37 Oliver Neukum wrote: > > > On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: > > Small patchset addressing break redundancy on drivers/usb branch > > (suggested by Joe Perches). > > Frankly, that is not a good idea. Somebody wil

[PATCH 4/5 linux-next] fotg210-hcd: remove unneccessary message level.

KERN_WARNING is implicitely declared in pr_warn() Signed-off-by: Fabian Frederick --- drivers/usb/host/fotg210-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 475b21f..98b0d05 100644 --- a/drivers

[PATCH 5/7 linux-next] hso: replace current->state by __set_current_state()

Use helper functions to access current->state. Direct assignments are prone to races and therefore buggy. Thanks to Peter Zijlstra for the exact definition of the problem. Suggested-By: Peter Zijlstra Signed-off-by: Fabian Frederick --- drivers/net/usb/hso.c | 2 +- 1 file changed

[PATCH 00/35 linux-next] constify of_device_id array

This small patchset adds const to of_device_id arrays in drivers branch. Fabian Frederick (35): ata: constify of_device_id array regulator: constify of_device_id array thermal: constify of_device_id array tty/hvc_opal: constify of_device_id array tty: constify of_device_id array power

[PATCH 11/35 linux-next] usb: gadget: constify of_device_id array

of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick --- drivers/usb/gadget/udc/pxa27x_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc