[PATCH] usb: gadget: storage: Remove warning message

2019-05-07 Thread EJ Hsu
guration" when it handles the signal from fsg_disable(). In this case, it will handle this request as well. So, when fsg_main_thread tries to handle the signal sent from "set configuration" later, there will nothing left to do and warning message "Unexpected call" is printe

RE: [PATCH] usb: gadget: storage: Remove warning message

2019-05-08 Thread EJ Hsu
Thanks for the info. Will remove it in the V2. Regards, EJ -Original Message- From: Greg KH Sent: Wednesday, May 8, 2019 2:40 PM To: EJ Hsu Cc: ba...@kernel.org; linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: gadget: storage: Remove warning message On Wed, May 08, 2019 at 11:24

[V2] usb: gadget: storage: Remove warning message

2019-05-08 Thread EJ Hsu
guration" when it handles the signal from fsg_disable(). In this case, it will handle this request as well. So, when fsg_main_thread tries to handle the signal sent from "set configuration" later, there will nothing left to do and warning message "Unexpected call" is p

RE: [V2] usb: gadget: storage: Remove warning message

2019-05-09 Thread EJ Hsu
> > You forgot to change fsg_unbind() to use FSG_STATE_DISCONNECT. And when > that's done, it will no longer need to set common->new_fsg to NULL either. > Yes, we should change fsg_unbind() as well. > This is sort of a band-aid approach. The real problem is that the original > design > of th

[PATCH V3] usb: gadget: storage: Remove warning message

2019-05-10 Thread EJ Hsu
guration" when it handles the signal from fsg_disable(). In this case, it will handle this request as well. So, when fsg_main_thread tries to handle the signal sent from "set configuration" later, there will nothing left to do and warning message "Unexpected call" is p

RE: [PATCH V3] usb: gadget: storage: Remove warning message

2019-07-03 Thread EJ Hsu
EJ Hsu wrote: > Thinh Nguyen wrote: > > Alan Stern wrote: > >> On Tue, 2 Jul 2019, Thinh Nguyen wrote: > >> > >>> Hi, > >>> > >>> Alan Stern wrote: > >>>> On Fri, 10 May 2019, EJ Hsu wrote: &g

RE: [PATCH V3] usb: gadget: storage: Remove warning message

2019-07-04 Thread EJ Hsu
Based on my initial debugging, USB CV TD 9.13 will consecutively set device to configuration #1 by sending "Set Configuration" transfer. So, in set_config() function, it will try to disable each interface first and then set up each interface. That is, the fsg_disable() will be called first and t

RE: [PATCH V3] usb: gadget: storage: Remove warning message

2019-07-05 Thread EJ Hsu
Alan Stern wrote: > On Thu, 4 Jul 2019, EJ Hsu wrote: > > > Based on my initial debugging, USB CV TD 9.13 will consecutively set device > to configuration #1 by sending "Set Configuration" transfer. > > So, in set_config() function, it will try to disable each inte