Re: [PATCH] usbatm: fix potential NULL pointer dereference

2013-04-19 Thread Duncan Sands
Signed-off-by: Duncan Sands On 19/04/13 04:18, Wei Yongjun wrote: From: Wei Yongjun The dereference to 'instance' in the debug code should be moved below the NULL test. Signed-off-by: Wei Yongjun --- drivers/usb/atm/usbatm.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH] Usb: atm: usbatm: fixed a pointer variable format issue

2013-12-06 Thread Duncan Sands
On 06/12/13 04:59, learc83 wrote: Fixed a pointer variable format issue. This is obviously OK. Ciao, Duncan. Signed-off-by: Seth Archer Brown --- drivers/usb/atm/usbatm.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/us

Re: [PATCH] Usb: atm: usbatm: fixed a pointer variable format issue

2013-12-06 Thread Duncan Sands
Hi Seth, On 06/12/13 15:24, Seth Archer wrote: Sorry, but do you mean the patch is OK, or the original is OK and no patch necessary? I meant that the patch is obviously OK. Ciao, Duncan. -Seth On Fri, Dec 6, 2013 at 3:24 AM, Duncan Sands mailto:duncan.sa...@gmail.com>> wrote:

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-06 Thread Duncan Sands
Hi, > The problem is that I couldn't find the maintainer for the code > in drivers/usb/atm/. that would be me (though since I haven't used this modem in years I would be more than happy to hand it off to someone else). > Besides, I don't have a proper hardware to test this. I will try to find

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-07 Thread Duncan Sands
Hi Pavel, > >> @@ -1014,11 +1015,7 @@ static int usbatm_do_heavy_init(void *arg) > >>struct usbatm_data *instance = arg; > >>int ret; > >> > >> - daemonize(instance->driver->driver_name); > >>allow_signal(SIGTERM); > >> - instance->thread_pid = current->pid; > >> - > >> - complete

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-10 Thread Duncan Sands
Hi Pavel, > Oh, I see. You're right - this race is possible... I'll fix that up > if this patch works. it seems to work fine. Thanks again for doing this! Best wishes, Duncan. - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] M

Re: [PATCH][USBATM]: convert heavy init dances to kthread API

2008-02-11 Thread Duncan Sands
On Monday 11 February 2008 12:22:27 Pavel Emelyanov wrote: > Duncan Sands wrote: > > Hi Pavel, > > > >> Oh, I see. You're right - this race is possible... I'll fix that up > >> if this patch works. > > > > it seems to work fine. Thanks

Re: [PATCH] Usbatm: convert heavy init dances to kthread API

2008-02-11 Thread Duncan Sands
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > Tested-by: Duncan Sands <[EMAIL PROTECTED]> Signed-off-by: Duncan Sands <[EMAIL PROTECTED]> Thanks again for doing this! Best wishes, Duncan. - To unsubscribe from this list: send the line "unsubscribe linux-