Re: [PATCH 1/2] Documentation: dt-bindings: dwc2: add the resets and reset-names property

2016-06-03 Thread Dinh Nguyen
Hi Rob, On 04/14/2016 11:40 AM, Rob Herring wrote: > On Wed, Apr 13, 2016 at 05:44:01PM -0500, dingu...@opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> Document the optional 'resets' and 'reset-names' property for the DWC2 usb >> co

Re: [RESEND PATCH] usb: dwc2: Add reset control to dwc2

2016-06-21 Thread Dinh Nguyen
On 06/21/2016 02:15 PM, John Youn wrote: > > Can you resend this to Philipp Zabel. > > Hi Philipp, > > Could you take this in your reset/next tree? It depends on the > following patch there: > > http://marc.info/?l=linux-usb&m=146473891018262&w=2 > I've resent that patch to Philipp. Thanks,

[PATCH] usb: dwc2: Add reset control to dwc2

2016-08-10 Thread Dinh Nguyen
From: Dinh Nguyen Allow for platforms that have a reset controller driver in place to bring the USB IP out of reset. Signed-off-by: Dinh Nguyen Acked-by: John Youn Tested-by: Stefan Wahren --- Hi Felipe, Can you please take this patch through your USB tree? This patch was dependent on

Re: [PATCH] usb: dwc2: Add reset control to dwc2

2016-08-11 Thread Dinh Nguyen
On 08/09/2016 02:05 PM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Allow for platforms that have a reset controller driver in place to bring > the USB IP out of reset. > > Signed-off-by: Dinh Nguyen > Acked-by: John Youn > Tested-by: Stefan W

Re: usb: dwc2: Kernel 4.5 and socfpga problem

2016-03-20 Thread Dinh Nguyen
On 03/17/2016 09:35 PM, Phil Reid wrote: > G'day, > > Has anyone successful run the usb dwc2 from kenerl 4.5 on an socfpga. > Yes. I just tested on the devkit and USB is working fine: [0.655761] ffb4.usb supply vusb_d not found, using dummy regulator [0.662384] ffb4.usb supply

Re: [PATCH 1/2] usb: dwc2: Add reset control to dwc2

2016-04-11 Thread Dinh Nguyen
On Thu, 7 Apr 2016, John Youn wrote: > Can you move into the lowlevel_hw_init()? The probe is a bit bloated > and we have these existing "lowlevel" functions where we consolidate > stuff like this. Same with the assert/deassert if possible. Yes, I can do that. Thanks for the review. BR, Dinh --

Re: [PATCHv3] usb: dwc2: Add reset control to dwc2

2016-04-13 Thread Dinh Nguyen
On 04/13/2016 11:23 AM, Stefan Wahren wrote: >> +hsotg->reset = devm_reset_control_get(hsotg->dev, "dwc2"); > > shouldn't this be documented in > Documentation/devicetree/bindings/usb/dwc2.txt ? > Sure, I can document it. >> +if (IS_ERR(hsotg->reset)) { >> +dev_info(hsotg-

Re: [PATCHv3 2/2] usb: dwc2: Add reset control to dwc2

2016-04-14 Thread Dinh Nguyen
On 04/14/2016 01:23 PM, John Youn wrote: > On 4/13/2016 7:04 PM, Arnd Bergmann wrote: >> On Thursday 14 April 2016, dingu...@opensource.altera.com wrote: >>> @@ -337,6 +338,17 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg >>> *hsotg) >>> { >>> int i, ret; >>> >>> + hsotg->

staging:DWC2 USB driver issues

2013-08-26 Thread Dinh Nguyen
Hi, I was wondering if anyone has come across the problem I am experiencing with the staging DWC2 driver. The problem is that the driver is failing to detect a device when connected. I know that HW works because I have an older version of the driver for this IP and it seems to work OK, barring a

Re: staging:DWC2 USB driver issues

2013-08-27 Thread Dinh Nguyen
On Tue, 2013-08-27 at 14:13 +0200, ZY - pavel wrote: > On Tue 2013-08-27 12:22:59, Matthijs Kooijman wrote: > > Hi Dinh, > > > > > Any chance anyone has a similar experience with this DWC2 driver, any > > > help will greatly appreciated. Of course, I will go back and verify the > > > initializatio

Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

2013-09-30 Thread Dinh Nguyen
Hi Dan, On Tue, 2013-10-01 at 01:25 +0300, Dan Carpenter wrote: > On Mon, Sep 30, 2013 at 05:05:23PM -0500, dingu...@altera.com wrote: > > From: Dinh Nguyen > > > > The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding > > a 1 to a 0xf results in

Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

2013-09-30 Thread Dinh Nguyen
On Tue, 2013-10-01 at 01:25 +0300, Dan Carpenter wrote: > On Mon, Sep 30, 2013 at 05:05:23PM -0500, dingu...@altera.com wrote: > > From: Dinh Nguyen > > > > The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding > > a 1 to a 0xf results in a 0 f

Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

2013-10-01 Thread Dinh Nguyen
Hi Dan, On 10/1/13 3:23 AM, Dan Carpenter wrote: On Tue, Oct 01, 2013 at 09:51:07AM +0200, Matthijs Kooijman wrote: On Tue, Oct 01, 2013 at 10:05:17AM +0300, Dan Carpenter wrote: On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote: From: Dan Carpenter [mailto:dan.carpen...@oracle.c

Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

2013-10-01 Thread Dinh Nguyen
Hi Matthijs, On 10/1/13 6:08 AM, Matthijs Kooijman wrote: Hi Dinh, Somehow I assumed that was fixed by the hardware, but I see now that you are right. Yes, making the definition larger is better than moving the + 1. This was my original fix to the problem, but I thought that it would be conf

Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

2013-10-01 Thread Dinh Nguyen
Hi Matthijs, On 10/1/13 6:08 AM, Matthijs Kooijman wrote: Hi Dinh, Somehow I assumed that was fixed by the hardware, but I see now that you are right. Yes, making the definition larger is better than moving the + 1. This was my original fix to the problem, but I thought that it would be conf

Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

2013-10-01 Thread Dinh Nguyen
On 10/1/13 6:29 AM, Dan Carpenter wrote: On Tue, Oct 01, 2013 at 06:22:35AM -0500, Dinh Nguyen wrote: Hi Matthijs, On 10/1/13 6:08 AM, Matthijs Kooijman wrote: Hi Dinh, Somehow I assumed that was fixed by the hardware, but I see now that you are right. Yes, making the definition larger is

staging: dwc2: Issue with isochronous transfers through a hub?

2013-10-01 Thread Dinh Nguyen
Hi, Just wondering if anyone tried using a webcam with the DWC2 driver? The webcam works great when plugged in directly to the USB port, but appears to have alot of dropped frames when used with a HS hub. I'll debug it of course, but just wondering if anyone has had a similar experience? Thanks,

Re: [PATCH] staging: dwc2: Make dwc2_hw_params.host_channels large enough

2013-10-01 Thread Dinh Nguyen
: Dinh Nguyen Can you please use: Dinh Nguyen Signed-off-by: Matthijs Kooijman --- drivers/staging/dwc2/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dwc2/core.h b/drivers/staging/dwc2/core.h index f7ba34b..fab718d 100644 --- a/drivers/staging/dwc2

Re: [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms

2013-12-12 Thread Dinh Nguyen
Hi Matt, On 12/12/13 7:26 AM, Matt Porter wrote: > Remove unused Samsung-specific machine include and Kconfig > dependency on S3C. > > Signed-off-by: Matt Porter > Reviewed-by: Markus Mayer > Reviewed-by: Tim Kryger > --- > drivers/usb/gadget/Kconfig | 7 +++ > drivers/usb/gadget/s3c-h

Re: [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms

2013-12-12 Thread Dinh Nguyen
On 12/12/13 4:07 PM, Matt Porter wrote: > On Thu, Dec 12, 2013 at 03:51:31PM -0600, Dinh Nguyen wrote: >> Hi Matt, >> >> On 12/12/13 7:26 AM, Matt Porter wrote: >>> Remove unused Samsung-specific machine include and Kconfig >>> dependency on S3C. >>&

Re: [RFC PATCH 0/2] dwc2/s3c-hsotg: Initial steps to combine the 2 driver

2014-01-14 Thread Dinh Nguyen
On Tue, 2014-01-14 at 06:21 -0800, Greg KH wrote: > On Tue, Jan 14, 2014 at 05:01:00AM -0600, dingu...@altera.com wrote: > > From: Dinh Nguyen > > > > Hi, > > > > I'm starting work downstream on combining the DWC2 host driver and the > > s3c-hsotg &

Re: [RFC PATCH 0/2] dwc2/s3c-hsotg: Initial steps to combine the 2 driver

2014-01-14 Thread Dinh Nguyen
On Tue, 2014-01-14 at 13:14 -0800, Greg KH wrote: > On Tue, Jan 14, 2014 at 08:57:12PM +, Paul Zimmerman wrote: > > > From: Dinh Nguyen [mailto:dingu...@altera.com] > > > Sent: Tuesday, January 14, 2014 12:46 PM > > > > > > On Tue, 2014-01-14 at 06:21 -0

RE: [PATCH] usb: dwc2: Handle the Host Port Interrupt when it occurs in device mode

2014-02-03 Thread Dinh Nguyen
apter, the PRTINT interrupt fires when the DWC2 is in device mode > > and is never cleared. > > > > This patch adds the function to read the HPRT0 register when the PRTINT > > fires > > and the dwc2 IP has already transitioned to device mode. This function is &g

RE: dwc2: commit beb7e592bc is causing a disconnected device to not get detected again

2014-02-03 Thread Dinh Nguyen
On Mon, 2014-02-03 at 23:10 +, Paul Zimmerman wrote: > > From: Dinh Nguyen [mailto:dingu...@altera.com] > > Sent: Monday, February 03, 2014 2:53 PM > > > > While I was testing my patch to combine the dwc2/s3c-hsotg into a DRD > > driver, I found that after disco

usb: dwc2: commit beb7e592bc is causing a disconnected device to not get detected again

2014-02-03 Thread Dinh Nguyen
Hello, While I was testing my patch to combine the dwc2/s3c-hsotg into a DRD driver, I found that after disconnecting a USB HDD from an OTG A-connector, then reconnecting it, the driver would no longer detect the USB device. I was able to track this issue down to this commit: commit beb7e592bcfd

RE: dwc2: commit beb7e592bc is causing a disconnected device to not get detected again

2014-02-03 Thread Dinh Nguyen
On Mon, 2014-02-03 at 23:10 +, Paul Zimmerman wrote: > > From: Dinh Nguyen [mailto:dingu...@altera.com] > > Sent: Monday, February 03, 2014 2:53 PM > > > > While I was testing my patch to combine the dwc2/s3c-hsotg into a DRD > > driver, I found that after disco

RE: dwc2: commit beb7e592bc is causing a disconnected device to not get detected again

2014-02-04 Thread Dinh Nguyen
On Tue, 2014-02-04 at 02:22 +, Paul Zimmerman wrote: > > From: Dinh Nguyen [mailto:dingu...@altera.com] > > Sent: Monday, February 03, 2014 3:42 PM > > > > On Mon, 2014-02-03 at 23:10 +, Paul Zimmerman wrote: > > > > From: Dinh Nguyen [mailto:dingu

RE: [PATCHv2] usb: dwc2: Handle the Host Port Interrupt when it occurs in device mode

2014-02-04 Thread Dinh Nguyen
interrupt fires when the DWC2 is in device mode > > and is never cleared. > > > > This patch adds the function to read the HPRT0 register when the PRTINT > > fires > > and the dwc2 IP has already transitioned to device mode. This function is > > only > >

RE: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-04 Thread Dinh Nguyen
On Wed, 2014-02-05 at 00:42 +, Paul Zimmerman wrote: > > From: dingu...@altera.com [mailto:dingu...@altera.com] > > Sent: Tuesday, February 04, 2014 1:46 PM > > > > From: Dinh Nguyen > > > > This means that the driver can be in host or peripheral mode whe

Re: [PATCHv6 2/8] usb: dwc2: Move gadget probe function into platform code

2014-10-31 Thread Dinh Nguyen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/30/2014 08:57 AM, Felipe Balbi wrote: > On Tue, Oct 28, 2014 at 06:25:43PM -0500, > dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> This patch will aggregate the probing of gadget/hcd driver into &

Re: [PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-10-31 Thread Dinh Nguyen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/30/2014 09:00 AM, Felipe Balbi wrote: > Hi, > > On Tue, Oct 28, 2014 at 06:25:45PM -0500, > dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Make dwc2_handle_common_intr call the gadget interrupt

Re: [PATCHv6 5/8] usb: dwc2: Add call_gadget functions for perpheral mode interrupts

2014-10-31 Thread Dinh Nguyen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/30/2014 09:01 AM, Felipe Balbi wrote: > On Tue, Oct 28, 2014 at 06:25:46PM -0500, > dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Update the dwc2 wakeup and suspend interrupt functions to use >>

Re: [PATCHv6 1/8] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-10-31 Thread Dinh Nguyen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/30/2014 08:54 AM, Felipe Balbi wrote: > On Tue, Oct 28, 2014 at 06:25:42PM -0500, > dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Adds the gadget data structure and appropriate data structure &

Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-31 Thread Dinh Nguyen
On 10/30/2014 09:04 AM, Felipe Balbi wrote: > Hi, > > On Tue, Oct 28, 2014 at 06:25:47PM -0500, dingu...@opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> Since the dwc2 hcd driver is currently not looking for a clock node during >> init, we should

Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-31 Thread Dinh Nguyen
On 10/31/2014 12:42 PM, Felipe Balbi wrote: > Hi, > > On Fri, Oct 31, 2014 at 10:20:06AM -0500, Dinh Nguyen wrote: >>>> @@ -339,7 +339,8 @@ static void dwc2_handle_wakeup_detected_intr(struct >>>> dwc2_hsotg *hsotg) >>>>} >>>>

Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-31 Thread Dinh Nguyen
On 10/31/2014 02:31 PM, Dinh Nguyen wrote: > On 10/31/2014 12:42 PM, Felipe Balbi wrote: >> Hi, >> >> On Fri, Oct 31, 2014 at 10:20:06AM -0500, Dinh Nguyen wrote: >>>>> @@ -339,7 +339,8 @@ static void dwc2_handle_wakeup_detected_

Re: [PATCH] usb: dwc2: allow dwc2 to get built when USB_GADGET=m

2014-11-03 Thread Dinh Nguyen
Hi Felipe, On 10/22/2014 01:29 PM, Paul Zimmerman wrote: >> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] >> Sent: Tuesday, October 21, 2014 1:32 PM >> >> From: Dinh Nguyen >> >> This patch allows the gadget portion of the DW

Re: usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-24 Thread Dinh Nguyen
+CC: Felipe Balbi On 11/24/2014 04:48 AM, Dan Carpenter wrote: > On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote: >> Hello Dinh Nguyen, >> >> The patch 8d736d8a9c44: "usb: dwc2: gadget: Do not fail probe if >> there isn't a clock node"

RE: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-05 Thread Dinh Nguyen
On Mon, 5 Jan 2015, Paul Zimmerman wrote: > Adding Dinh to CC. > > Robert, Dinh, I would like to have your tested-bys for this series, please. > I'll try to test this by the end of this week. Dinh > > > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > > Sent: Friday, January 02, 20

Re: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-06 Thread Dinh Nguyen
On 01/06/2015 05:47 PM, Dinh Nguyen wrote: > On 01/05/2015 01:16 PM, Paul Zimmerman wrote: >> Adding Dinh to CC. >> >> Robert, Dinh, I would like to have your tested-bys for this series, please. >> > > This patch series is producing this error on the SOCFPGA pl

Re: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-06 Thread Dinh Nguyen
On 01/05/2015 01:16 PM, Paul Zimmerman wrote: > Adding Dinh to CC. > > Robert, Dinh, I would like to have your tested-bys for this series, please. > This patch series is producing this error on the SOCFPGA platform. I'll try to bisect to a specific patch. root@socfpga_cyclone5:~# [ 47.929743]

Re: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-07 Thread Dinh Nguyen
On 01/07/2015 09:34 AM, Kaukab, Yousaf wrote: > Hi, > >> -Original Message----- >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] >> Sent: Wednesday, January 7, 2015 1:01 AM >> To: Paul Zimmerman; Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@

Re: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-07 Thread Dinh Nguyen
Hi Yousaf, On 01/07/2015 09:47 AM, Kaukab, Yousaf wrote: >> -Original Message- >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] >> Sent: Wednesday, January 7, 2015 4:39 PM >> To: Kaukab, Yousaf; Paul Zimmerman; linux-usb@vger.kernel.org; ba...@ti.com

Re: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-07 Thread Dinh Nguyen
On 01/05/2015 09:02 PM, Paul Zimmerman wrote: >> From: Kever Yang [mailto:kever.y...@rock-chips.com] >> Sent: Monday, January 05, 2015 5:42 PM >> >> Hi Paul, >> >> I think you need this patch to fix the problem: >> >> usb: dwc2: resume root hub when device detect with suspend state >> https://patch

Re: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-11 Thread Dinh Nguyen
On 2/11/14 11:56 PM, Jingoo Han wrote: > On Wednesday, February 12, 2014 2:34 PM, Stephen Warren wrote: >> On 02/04/2014 02:45 PM, dingu...@altera.com wrote: >>> From: Dinh Nguyen >>> >>> This means that the driver can be in host or peripheral mode when the &

RE: [PATCH 0/7] usb: dwc2/s3c-hsotg: Combine drivers into a single DRD

2014-02-18 Thread Dinh Nguyen
-0600, dingu...@altera.com wrote: > > > > From: Dinh Nguyen > > > > > > > > Hello, > > > > > > > > This patch series combines the dwc2 host driver and the s3c-hsotg > > > > peripheral > > > > driver into a single

Re: [PATCH] Remove fifo sizes from dwc2 usb driver from socfpga.dtsi

2014-03-03 Thread Dinh Nguyen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 3/3/14 8:42 PM, Felipe Balbi wrote: > Hi, > > On Mon, Mar 03, 2014 at 05:09:27PM -0600, dingu...@altera.com wrote: >> From: Dinh Nguyen >> >> Remove reading the fifo sizes from dts in platform.c >> &

Re: [PATCHv2 2/3] usb: s3c-hsotg: Move s3c-hsotg into dwc2 folder

2014-03-03 Thread Dinh Nguyen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Felipe, On 3/3/14 8:46 PM, Felipe Balbi wrote: > On Mon, Mar 03, 2014 at 05:09:28PM -0600, dingu...@altera.com wrote: >> From: Dinh Nguyen >> >> Moves the s3c-hsotg driver into the dwc2 folder and use the dwc2 defines in &

Re: [PATCHv2 0/3] usb: dwc2/s3c-hsotg: Move the s3c-hsotg driver into dwc2

2014-03-03 Thread Dinh Nguyen
On 3/3/14 5:09 PM, dingu...@altera.com wrote: > From: Dinh Nguyen > > Hi, > > This is a shortened version of the v1 patch to combine the dwc2/s3c-hsotg into > a single dual-role driver. The series will only move the s3c-hsotg driver into > the dwc2 folder, use the defines

Re: [PATCH] usb: dwc2: Add function to calculate correct FIFO sizes

2014-03-03 Thread Dinh Nguyen
Hi Paul, On 3/3/14 9:14 PM, Paul Zimmerman wrote: >> From: dingu...@altera.com [mailto:dingu...@altera.com] >> Sent: Monday, March 03, 2014 2:20 PM >> >> From: Dinh Nguyen >> >> The dwc2 IP on the SOCFPGA cannot use the default HW configured >> FIF

Re: [PATCHv2] usb: dwc2: Add function to calculate correct FIFO sizes

2014-03-04 Thread Dinh Nguyen
On Tue, 2014-03-04 at 09:18 -0600, Felipe Balbi wrote: > On Mon, Mar 03, 2014 at 09:25:13PM -0600, dingu...@altera.com wrote: > > From: Dinh Nguyen > > > > The dwc2 IP on the SOCFPGA cannot use the default HW configured > > FIFO sizes. The total FIFO depth as read fro

Re: [PATCH] Remove fifo sizes from dwc2 usb driver from socfpga.dtsi

2014-03-04 Thread Dinh Nguyen
On 03/03/2014 08:42 PM, Felipe Balbi wrote: Hi, On Mon, Mar 03, 2014 at 05:09:27PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen Remove reading the fifo sizes from dts in platform.c Add dwc2_calculate_dynamic_fifo Conflicts: arch/arm/boot/dts/socfpga.dtsi drivers

Trouble with stephen warren's wwwdotorg email

2014-03-06 Thread Dinh Nguyen
Hi Stephen, I tried sending you this patch series to swar...@wwwdotorg.org, but it's bouncing. http://thread.gmane.org/gmane.linux.usb.general/104611 Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCHv4 4/4] usb: dwc2: Edit the Kconfig and Makefile to build dwc2_gadget driver

2014-03-10 Thread Dinh Nguyen
From: Dinh Nguyen Modify the dwc2 Kconfig and Makefile so that it will build the dwc2_gadget driver when peripheral only mode is selected. The dwc_platform.ko and dwc2.ko will get built then dynamic linked modules are selected for Host mode. For peripheral mode only dwc2_gadget.ko will get built

[PATCHv4 2/4] usb: s3c-hsotg: Move s3c-hsotg into dwc2 folder

2014-03-10 Thread Dinh Nguyen
From: Dinh Nguyen Moves the s3c-hsotg driver into the dwc2 folder and use the dwc2 defines in hw.h. Renamed the s3c-hsotg.c to gadget.c. Signed-off-by: Dinh Nguyen Tested-by: Jingoo Han Cc: Greg Kroah-Hartman Cc: Paul Zimmerman Cc: Felipe Balbi Cc: Ben Dooks Cc: Matt Porter Cc: Kukjin

[PATCHv4 3/4] usb: s3c-hsotg: Move s3c-hsotg data structures

2014-03-10 Thread Dinh Nguyen
From: Dinh Nguyen This patch moves the data structures that are in the s3c-hsotg source into core.h. This is a necessary step towards unifying the s3c-hsotg and dwc2 into a single DRD. Signed-off-by: Dinh Nguyen Tested-by: Jingoo Han Cc: Greg Kroah-Hartman Cc: Paul Zimmerman Cc: Felipe

[PATCHv4 1/4] usb: dwc2: Add defines to support the s3c-hsotg driver

2014-03-10 Thread Dinh Nguyen
From: Dinh Nguyen In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver, the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can use them. Signed-off-by: Dinh Nguyen Tested-by: Jingoo Han Cc: Greg Kroah-Hartman Cc: Paul Zimmerman Cc: Felipe

RE: [PATCHv4 1/4] usb: dwc2: Add defines to support the s3c-hsotg driver

2014-03-13 Thread Dinh Nguyen
On Tue, 2014-03-11 at 22:42 +, Paul Zimmerman wrote: > > From: Dinh Nguyen [mailto:dinh.li...@gmail.com] > > Sent: Monday, March 10, 2014 5:52 AM > > > > In preparation of combining the dwc2/s3c-hsotg driver in a single DRD > > driver, > > the defines

Re: [PATCHv5 4/4] usb: dwc2: Edit the Kconfig and Makefile to build dwc2_gadget driver

2014-04-10 Thread Dinh Nguyen
On 04/10/2014 09:02 PM, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Friday, March 14, 2014 11:52 AM From: Dinh Nguyen Modify the dwc2 Kconfig and Makefile so that it will build the dwc2_gadget driver when peripheral only mode is selected. The

Re: [RESEND PATCHv5] usb: dwc2: Add function to calculate correct FIFO sizes

2014-04-28 Thread Dinh Nguyen
On 4/14/14 4:11 PM, dingu...@altera.com wrote: > From: Dinh Nguyen > > The dwc2 IP on the SOCFPGA cannot use the default HW configured > FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064 > 32-bit words. But the GRXFSIZ, GNPTXFSIZ, and HPTXFSIZ registe

Re: [PATCH 1/2] usb: dwc2: Option to disable dma descriptor mode

2014-05-06 Thread Dinh Nguyen
On Tue, 2014-05-06 at 19:39 +0400, Sergei Shtylyov wrote: > Hello. > > On 05/06/2014 02:23 AM, dingu...@altera.com wrote: > > > From: Dinh Nguyen > > > Even though the IP supports Descriptor DMA mode, it does not support SPLIT > > transactions in this m

RE: [PATCH 1/2] usb: dwc2: Option to disable dma descriptor mode

2014-05-06 Thread Dinh Nguyen
On Tue, 2014-05-06 at 18:21 +, Paul Zimmerman wrote: > > From: dingu...@altera.com [mailto:dingu...@altera.com] > > Sent: Monday, May 05, 2014 3:23 PM > > > > Even though the IP supports Descriptor DMA mode, it does not support SPLIT > > transactions in this mode. Since the driver can get the

Re: [PATCH v2 00/32] usb: dwc2: various bug fixes

2015-09-22 Thread Dinh Nguyen
esting/next branch in Felipe's git. > > Thank you, > I tested this series on 2.93a and 3.20a versions of the IP and did not see any issues. Tested-by: Dinh Nguyen Thanks, Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Dinh Nguyen
Hi Paul, On 09/08/2014 05:50 PM, Greg KH wrote: > On Tue, Aug 26, 2014 at 11:19:54AM -0500, dingu...@opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> Adds the gadget data structure and appropriate data structure pointers >> to the common dwc2_hsotg data

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Dinh Nguyen
On 09/09/2014 02:06 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] >> Sent: Tuesday, September 09, 2014 9:26 AM >> >> On 09/08/2014 05:50 PM, Greg KH wrote: >>> On Tue, Aug 26, 2014 at 11:19:54AM -0500, dingu...@opensource

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-09 Thread Dinh Nguyen
On 09/09/2014 02:56 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] >> Sent: Tuesday, September 09, 2014 12:13 PM >> >> On 09/09/2014 02:06 PM, Paul Zimmerman wrote: >>>> From: Dinh Nguyen [mailto:dingu...@opensource.alter

Re: [PATCHv4 00/12] usb: dwc2: Add support for dual role

2014-09-12 Thread Dinh Nguyen
On 09/12/2014 11:44 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:51 AM dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Hello, >> >> This is version 4 o

Re: [RFC PATCH 0/2] usb: dwc2: Enable URB giveback in a tasklet context

2014-09-15 Thread Dinh Nguyen
On 09/15/2014 11:08 AM, Alan Stern wrote: > On Mon, 15 Sep 2014 dingu...@opensource.altera.com wrote: > >> From: Dinh Nguyen >> >> Hi Ming-Lei, >> >> Thanks for your patch to enable the URB giveback in a tasklet context for >> the EHCI driver. I fo

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-17 Thread Dinh Nguyen
Hi Robert, On 9/12/14, 7:13 AM, Robert Baldyga wrote: > Hi Dinh, > > On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Add the proper init calls for either host, gadget or both in platform.c >> >> Signed-off-by: D

Re: [PATCHv4 06/12] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-09-17 Thread Dinh Nguyen
On 9/12/14, 7:50 AM, Robert Baldyga wrote: > Hi, > > On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Make dwc2_handle_common_intr call the gadget interrupt function when >> operating >> in peripheral mode. Remove

Re: [PATCHv4 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-09-17 Thread Dinh Nguyen
On 9/12/14, 8:09 AM, Robert Baldyga wrote: > Hi, > > On 08/26/2014 06:20 PM, dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Move spin_lock_init to common location for both host and gadget. >> >> Signed-off-by: Dinh Nguyen >> -

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-18 Thread Dinh Nguyen
Hi Robert, On 09/17/2014 03:52 PM, Stephen Warren wrote: > On 09/17/2014 02:47 PM, Dinh Nguyen wrote: >> Hi Robert, >> >> On 9/12/14, 7:13 AM, Robert Baldyga wrote: >>> Hi Dinh, >>> >>> On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote:

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-18 Thread Dinh Nguyen
On Thu, Sep 18, 2014 at 10:17 AM, Dinh Nguyen wrote: > Hi Robert, > > On 09/17/2014 03:52 PM, Stephen Warren wrote: >> On 09/17/2014 02:47 PM, Dinh Nguyen wrote: >>> Hi Robert, >>> >>> On 9/12/14, 7:13 AM, Robert Baldyga wrote: >>>

Re: [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-18 Thread Dinh Nguyen
Hi Bartlomiej, On 09/12/2014 10:49 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:52 AM dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Update DWC2 kconfig and mak

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-18 Thread Dinh Nguyen
On 09/12/2014 11:18 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:55 AM dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Add the proper init calls for eithe

Re: [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-09-19 Thread Dinh Nguyen
On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:59 AM dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Since the dwc2 hcd driver is currently not loo

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-21 Thread Dinh Nguyen
On 10/20/2014 02:42 PM, Paul Bolle wrote: > dingu...@opensource.altera.com schreef op ma 20-10-2014 om 13:52 > [-0500]: >> From: Dinh Nguyen >> >> Update DWC2 kconfig and makefile to support dual-role mode. The platform >> file will always get compiled for th

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Dinh Nguyen
On 10/22/2014 03:27 PM, Paul Bolle wrote: > On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote: >> On 10/20/2014 02:42 PM, Paul Bolle wrote: >>> (Side note: drivers/usb/dwc2/Kconfig is sourced (in drivers/usb/Kconfig) >>> even if USB is _not_ set. But USB_DCW2 s

Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Dinh Nguyen
On 10/23/2014 01:28 PM, Paul Zimmerman wrote: >> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] >> Sent: Wednesday, October 22, 2014 5:26 AM >> >> On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: >>> F

Re: [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-29 Thread Dinh Nguyen
tionality, move >> the call the host portion for the DWC2 driver. >> >> Signed-off-by: Dinh Nguyen >> --- >> drivers/usb/dwc2/hcd.c | 3 +++ >> drivers/usb/dwc2/platform.c | 3 --- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> di

RE: [RESEND PATCH 00/15] usb: dwc2: Add support for dual-role

2014-06-23 Thread Dinh Nguyen
On Fri, 2014-06-20 at 23:10 +, Paul Zimmerman wrote: > > From: dingu...@altera.com [mailto:dingu...@altera.com] > > Sent: Friday, June 20, 2014 8:35 AM > > > > From: Dinh Nguyen > > > > Apologies for the noise, but I got Paul Zimmerman's address

dwc2: usb/ethernet dongle does not work

2014-06-25 Thread Dinh Nguyen
Hi Paul, I was wondering if you have ever tested this driver with a USB/ethernet dongle? I'm using the apple usb/ethernet dongle, which is basically just the ASIX AX88xxx Based Ethernet Adapter. From brief debugging, it appears that Bulk and Interrupt endpoint data are getting corrupted durin

Re: dwc2: usb/ethernet dongle does not work

2014-07-14 Thread Dinh Nguyen
Hi Paul, On 6/25/14, 1:24 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> Sent: Wednesday, June 25, 2014 8:52 AM >> >> I was wondering if you have ever tested this driver with a USB/ethernet >> dongle? I'm using the apple usb/

RE: [PATCH 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-07-21 Thread Dinh Nguyen
ompiled for the case where the controller is directly > > connected to the CPU. So for loadable modules, only dwc2.ko is needed. > > > > Signed-off-by: Dinh Nguyen > > --- > > drivers/usb/dwc2/Kconfig | 59 > > ++--- &

Re: [PATCH 03/12] usb: dwc2: update gadget portion to use common dwc2_hsotg structure

2014-07-23 Thread Dinh Nguyen
will be handled by either the platform or pci code. - Change the gadget probe function into gadget_init. - Move the allocation of the core_params to a share place for use by both host and gadget. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core.h | 61 ++- drivers/usb/dwc2

Re: [PATCH 04/12] usb: dwc2: Add DTS compatible string to dwc2_of_match_table

2014-07-23 Thread Dinh Nguyen
On 07/16/2014 04:27 PM, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Wednesday, July 16, 2014 1:33 PM Puts back "samsung,s3c6400-hsotg" into the dwc2_of_match_table[]. Why? This compatible binding was originally in the gadget driver. Don't I want to

Re: [PATCH 04/12] usb: dwc2: Add DTS compatible string to dwc2_of_match_table

2014-07-23 Thread Dinh Nguyen
On 7/23/14, 1:03 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> Sent: Wednesday, July 23, 2014 8:12 AM >> >> On 07/16/2014 04:27 PM, Paul Zimmerman wrote: >>>> From: dingu...@altera.com [mailto:dingu...@altera.com] >>

Re: dwc2: usb/ethernet dongle does not work

2014-07-28 Thread Dinh Nguyen
n in decscriptor DMA mode the USB/ethernet is only able to get an IP address from DHCP, pings sometime work and when pings work, it is extremely slow. I still cannot mount an NFS using a the adapter. Does it work perfectly for you? Would you care to share a patch? Thanks, Dinh > 发自我的 iPad > &g

Re: [PATCHv2 02/13] usb: dwc2: Moves s3c_hsotg gadget data structure into dwc2_hsotg

2014-07-31 Thread Dinh Nguyen
data structure and appropriate data structure pointers >>> to the common dwc2_hsotg data structure. This is needed so that the >>> dwc2_hsotg data structure can be used by the hcd and gadget drivers. >>> >>> Signed-off-by: Dinh Nguyen >>> --- >>>

RE: [PATCHv2 02/13] usb: dwc2: Moves s3c_hsotg gadget data structure into dwc2_hsotg

2014-08-01 Thread Dinh Nguyen
o:dingu...@altera.com] > > > Sent: Wednesday, July 30, 2014 8:21 AM > > > > > > Adds the gadget data structure and appropriate data structure pointers > > > to the common dwc2_hsotg data structure. This is needed so that the > > > dwc2_hsotg data structure can

RE: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-01 Thread Dinh Nguyen
to support dual-role mode. The platform > > file will always get compiled for the case where the controller is directly > > connected to the CPU. So for loadable modules, only dwc2.ko is needed. > > > > Signed-off-by: Dinh Nguyen > > --- > > v2: Remove refe

Re: [PATCH v4 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-06 Thread Dinh Nguyen
On Wed, Aug 6, 2014 at 5:24 PM, Doug Anderson wrote: > Kever, > > On Tue, Aug 5, 2014 at 6:01 PM, Kever Yang wrote: >> According to the "dr_mode", the otg controller can work as >> device role and host role. Some boards always want to use host mode >> and some other boards want to use gadget mode

Re: [PATCH v4 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-06 Thread Dinh Nguyen
gusbcfg, hsotg->regs + GUSBCFG); >>> + } else if (hsotg->dr_mode == USB_DR_MODE_OTG) { >>> + gusbcfg = readl(hsotg->regs + GUSBCFG); >>> + gusbcfg &= ~GUSBCFG_FORCEHOSTMODE; >>> + gusbcfg &= ~G

Re: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Dinh Nguyen
On 8/1/14, 4:41 PM, Dinh Nguyen wrote: > On Fri, 2014-08-01 at 20:42 +, Paul Zimmerman wrote: >>> From: linux-usb-ow...@vger.kernel.org >>> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of dingu...@altera.com >>> Sent: Wednesday, July 30, 2014 8:21 AM &

Re: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Dinh Nguyen
On Thu, Aug 7, 2014 at 3:55 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> Sent: Thursday, August 07, 2014 5:12 AM >> >> On 8/1/14, 4:41 PM, Dinh Nguyen wrote: >> > On Fri, 2014-08-01 at 20:42 +, Paul Zimmerman

Re: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Dinh Nguyen
On Thu, Aug 7, 2014 at 4:04 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> Sent: Thursday, August 07, 2014 2:01 PM >> >> On Thu, Aug 7, 2014 at 3:55 PM, Paul Zimmerman >> wrote: >> >> From: Dinh Nguyen [mailto:dinh.li...@

Re: [PATCHv2 07/13] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-08-08 Thread Dinh Nguyen
gadget interrupt function when >> operating >> in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as >> dwc2_handle_common_intr() already has the spinlocks. >> >> Remove duplicate interrupt conditions that was in gadget, as those are >> handled >

Re: [PATCHv2 10/13] usb: dwc2: initialize the spin_lock for both host and gadget

2014-08-25 Thread Dinh Nguyen
t to common location for both host and gadget. >>> >>> Signed-off-by: Dinh Nguyen >>> --- >>> drivers/usb/dwc2/hcd.c |1 - >>> drivers/usb/dwc2/platform.c |1 + >>> 2 files changed, 1 insertion(+), 1 deletion(-) >>> >>>

Re: [PATCH 00/13] usb: second series of updates for dwc2 driver

2015-01-21 Thread Dinh Nguyen
On 01/21/2015 02:54 AM, Kaukab, Yousaf wrote: > Hi John, > >> -Original Message- >> From: Kaukab, Yousaf >> Sent: Thursday, January 15, 2015 6:09 PM >> To: linux-usb@vger.kernel.org; ba...@ti.com >> Cc: john.y...@synopsys.com; Herrero, Gregory; pa...@synopsys.com; >> r.bald...@samsung.com;

[PATCH] usb: dwc2: disable erroneous overcurrent condition

2017-10-16 Thread Dinh Nguyen
abling the over-current condition. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core.h | 4 drivers/usb/dwc2/hcd.c| 5 + drivers/usb/dwc2/params.c | 3 +++ 3 files changed, 12 insertions(+) diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h index 8367d4f9..730d

  1   2   >