Re: [PATCH net-next v3 0/2] r8152: random MAC address

2014-09-05 Thread David Miller
From: Hayes Wang Date: Thu, 4 Sep 2014 16:15:40 +0800 > If the interface has invalid MAC address, it couldn't > be used. In order to let it work normally, give a > random one. > > v3: > Remove > ether_addr_copy(dev->perm_addr, dev->dev_addr); > > v2: > Use "%pM" format specifier for p

Re: [PATCH net-next] r8152: use usleep_range

2014-09-09 Thread David Miller
From: Hayes Wang Date: Tue, 9 Sep 2014 11:40:28 +0800 > Replace mdelay with usleep_range to avoid busy loop. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH net-next] r8152: support VLAN

2014-09-11 Thread David Miller
From: Hayes Wang Date: Thu, 11 Sep 2014 20:16:24 +0800 > - ocp_data = ocp_read_word(tp, MCU_TYPE_PLA, PLA_CPCR); > - ocp_data &= ~CPCR_RX_VLAN; > - ocp_write_word(tp, MCU_TYPE_PLA, PLA_CPCR, ocp_data); > + if (tp->netdev->features & NETIF_F_HW_VLAN_CTAG_RX) > + rtl_rx_

Re: [PATCH net-next v2] r8152: support VLAN

2014-09-13 Thread David Miller
From: Hayes Wang Date: Fri, 12 Sep 2014 10:43:11 +0800 > Support hw VLAN for tx and rx. And enable them by default. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH net] r8152: disable ALDPS

2014-09-22 Thread David Miller
From: Hayes Wang Date: Fri, 19 Sep 2014 15:17:18 +0800 > If the hw is in ALDPS mode, the hw may have no response for accessing > the most registers. Therefore, the ALDPS should be disabled before > accessing the hw in rtl_ops.init(), rtl_ops.disable(), rtl_ops.up(), > and rtl_ops.down(). Regardle

Re: [PATCH net] r8152: fix the carrier off when autoresuming

2014-09-26 Thread David Miller
From: Hayes Wang Date: Tue, 23 Sep 2014 16:31:47 +0800 > netif_carrier_off would be called when autoresuming, even though > the cable is plugged. This causes some applications do relative > actions when detecting the carrier off. Keep the status of the > carrier, and let it be modified when the l

Re: [PATCH net-next 0/3] r8152: support setting eee by ethtool

2014-09-28 Thread David Miller
From: Hayes Wang Date: Thu, 25 Sep 2014 20:53:59 +0800 > Modify some definitions about EEE, and add the support of setting > the EEE through ethtool. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: [PATCH net] r8152: fix setting RTL8152_UNPLUG

2014-09-30 Thread David Miller
From: Hayes Wang Date: Tue, 30 Sep 2014 16:48:01 +0800 > The flag of RTL8152_UNPLUG should only be set when the device is > unplugged, not each time the rtl8152_disconnect() is called. > Otherwise, the device wouldn't be stopped normally. > > Signed-off-by: Hayes Wang Applied, thanks. -- To un

Re: [PATCH net 0/2] r8152: patches about firmware

2014-10-01 Thread David Miller
From: Hayes Wang Date: Wed, 1 Oct 2014 13:25:09 +0800 > The patches fix the issues when the firmware exists. > > For the multiple OS, the firmware may be loaded by the > driver of the other OS. And the Linux driver has influences > on it. Series applied, thanks. -- To unsubscribe from this list

Re: [PATCH net-next] r8152: nway reset after setting eee

2014-10-03 Thread David Miller
From: Hayes Wang Date: Thu, 2 Oct 2014 16:01:22 +0800 > @@ -3480,6 +3480,9 @@ rtl_ethtool_set_eee(struct net_device *net, struct > ethtool_eee *edata) > > ret = tp->rtl_ops.eee_set(tp, edata); > > + if (ret == 0) > + ret = mii_nway_restart(&tp->mii); Please test this c

Re: [PATCH net v2] r8152: autoresume before setting MAC address

2014-10-03 Thread David Miller
From: Hayes Wang Date: Thu, 2 Oct 2014 17:03:12 +0800 > Resume the device before setting the MAC address. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH net-next v2] r8152: nway reset after setting eee

2014-10-06 Thread David Miller
From: Hayes Wang Date: Mon, 6 Oct 2014 10:36:04 +0800 > Restart autonegotiation is necessary after setting EEE. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH net-next] r8152: use mutex for hw settings

2014-10-08 Thread David Miller
From: Hayes Wang Date: Tue, 7 Oct 2014 13:36:30 +0800 > Use mutex to avoid that the serial hw settings would be interrupted > by other settings. Although there is no problem now, it makes the > driver more safe. > > Signed-off-by: Hayes Wang I think a much simpler fix is to take rtnl_lock() in

Re: [PATCH v3] Add support for GPIOs for SMSC LAN95xx chips.

2014-10-09 Thread David Miller
From: Evgeny Boger Date: Thu, 9 Oct 2014 02:14:58 +0400 > There might be 11 GPIOs in total. > Last three GPIOs (offsets 8-10, 0-based) are shared with FDX, LNKA, SPD > LEDs respectively. The LEDs are driven by chip by default at startup time. > Once the corresponding GPIO is requested, the chip

Re: [PATCH net-next] r8152: use mutex for hw settings

2014-10-09 Thread David Miller
From: Hayes Wang Date: Thu, 9 Oct 2014 07:59:35 + > If I use the rtnl_lock(), I get a dead lock when enabling autosuspend. > > Case 1: >autosuspend before calling open. >rtnl_lock() >call open >try to autoresume and rtl8152_resume is called. >dead lock occurs. > > Case 2

Re: [PATCH net-next v2 0/3] r8152: use mutex for hw settings

2014-10-09 Thread David Miller
From: Hayes Wang Date: Thu, 9 Oct 2014 18:00:23 +0800 > v2: > Make sure the autoresume wouldn't occur inside the mutex, otherwise > the dead lock would happen. For the purpose, adjust some code about > autosuspend/autoresume. > > v1: > Use mutex to avoid that the serial hw settings would be inte

Re: [PATCH net] r8152: return -EBUSY for runtime suspend

2014-10-17 Thread David Miller
From: Hayes Wang Date: Fri, 17 Oct 2014 16:55:08 +0800 > Remove calling cancel_delayed_work_sync() for runtime suspend, > because it would cause dead lock. Instead, return -EBUSY to > avoid the device enters suspending if the net is running and > the delayed work is pending or running. The delaye

Re: [PATCH net-next 0/2] r8152: support nway_reset

2014-10-29 Thread David Miller
From: Hayes Wang Date: Tue, 28 Oct 2014 14:05:50 +0800 > Fix the CHECK from checkpatch.pl and support nway_reset. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [PATCH net,stable] net: huawei_cdc_ncm: increase command buffer size

2014-06-21 Thread David Miller
From: Bjørn Mork Date: Wed, 18 Jun 2014 14:21:24 +0200 > Messages from the modem exceeding 256 bytes cause communication > failure. > > The WDM protocol is strictly "read on demand", meaning that we only > poll for unread data after receiving a notification from the modem. > Since we have no way

Re: [PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.

2014-06-23 Thread David Miller
Please do not post updated patches in this way. Instead, make a new, fresh, list posting with a formal commit message and signoff just as you would otherwise properly submit a new change. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...

Re: [PATCH] net: qmi_wwan: Add ID for Telewell TW-LTE 4G v2

2014-07-07 Thread David Miller
From: Bernd Wachter Date: Tue, 01 Jul 2014 22:01:09 +0300 > There's a new version of the Telewell 4G modem working with, but not > recognized by this driver. > > Signed-off-by: Bernd Wachter Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH net-next] r8152: increase the tx timeout

2014-07-08 Thread David Miller
From: Hayes Wang Date: Thu, 3 Jul 2014 11:55:48 +0800 > When the system is too busy to complete the urb, the tx timout function > would be called. This causes the other tx urbs would be killed, too. > Increase the tx timeout to avoid it. > > Signed-off-by: Hayes Wang Applied, thank you. -- To

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

2014-07-08 Thread David Miller
From: Olivier Sobrie Date: Mon, 7 Jul 2014 11:06:07 +0200 > When the module sends bursts of data, sometimes a deadlock happens in > the hso driver when the tty buffer doesn't get the chance to be flushed > quickly enough. > > To avoid this, first, we remove the endless while loop in > put_rx_bu

Re: [PATCH net] r8152: wake up the device before dumping the hw counter

2014-07-08 Thread David Miller
From: Hayes Wang Date: Tue, 8 Jul 2014 14:49:28 +0800 > The device should be waked up from runtime suspend before dumping > the hw counter. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord.

Re: [PATCH net-next] r8152: support jumbo frame for RTL8153

2014-07-09 Thread David Miller
From: Hayes Wang Date: Wed, 9 Jul 2014 16:07:02 +0800 > +static int rtl8152_change_mtu(struct net_device *dev, int new_mtu) > +{ > + struct r8152 *tp = netdev_priv(dev); > + > + if (dev->mtu == new_mtu) > + return 0; This method will never be invoked if the MTU is actually no

Re: [PATCH] usbnet: smsc95xx: add reset_resume function with reset operation

2014-07-10 Thread David Miller
From: Joonyoung Shim Date: Thu, 10 Jul 2014 11:49:42 +0900 > The smsc95xx needs to resume with reset operation. Otherwise it causes > system hang by network error like below after resume. This case appears > on odroid u3 board. > > [9.727600] smsc95xx 1-2:1.0 eth0: kevent 2 may have been dro

Re: [PATCH net-next v2] r8152: support jumbo frame for RTL8153

2014-07-10 Thread David Miller
From: Hayes Wang Date: Thu, 10 Jul 2014 10:58:54 +0800 > The maximum jumbo frame size for RTL8153 is 9K bytes. > Change the max rx packet size to 9K. > Change the use of the shared fifo from 6K (default) to 12K for tx. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: se

Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

2014-07-11 Thread David Miller
When posting new versions of patches, you must resubmit the entire series, not just the patch which is changing. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

Re: [PATCH net] r8152: fix r8152_csum_workaround function

2014-07-11 Thread David Miller
From: Hayes Wang Date: Fri, 11 Jul 2014 16:48:27 +0800 > The transport offset of the IPv4 packet should be fixed and wouldn't > be out of the hw limitation, so the r8152_csum_workaround() should > be used for IPv6 packets. > > Signed-off-by: Hayes Wang Applied and queued up for -stable, but th

Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

2014-07-14 Thread David Miller
xbuf_data() which is > called by the urb completion handler. > If there isn't enough room in the tty buffer, discards all the data > received in the URB. > > Cc: David Miller > Cc: David Laight > Cc: One Thousand Gnomes > Cc: Dan Williams > Cc: Jan Dumon &g

Re: [PATCH v2 1/2] hso: remove unused workqueue

2014-07-14 Thread David Miller
From: Olivier Sobrie Date: Mon, 14 Jul 2014 12:08:49 +0200 > The workqueue "retry_unthrottle_workqueue" is not scheduled anywhere > in the code. So, remove it. > > Signed-off-by: Olivier Sobrie Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a me

Re: [PATCH net,stable] net: qmi_wwan: add two Sierra Wireless/Netgear devices

2014-07-17 Thread David Miller
From: Bjørn Mork Date: Thu, 17 Jul 2014 13:33:51 +0200 > Add two device IDs found in an out-of-tree driver downloadable > from Netgear. > > Signed-off-by: Bjørn Mork Applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mess

Re: [PATCH net,stable] net: huawei_cdc_ncm: add "subclass 3" devices

2014-07-17 Thread David Miller
From: Bjørn Mork Date: Thu, 17 Jul 2014 13:34:09 +0200 > Huawei's usage of the subclass and protocol fields is not 100% > clear to us, but there appears to be a very strict system. > > A device with the "shared" device ID 12d1:1506 and this NCM > function was recently reported (showing only defa

Re: [PATCH net] r8152: fix the checking of the usb speed

2014-07-24 Thread David Miller
From: Hayes Wang Date: Thu, 24 Jul 2014 16:37:43 +0800 > When the usb speed of the RTL8152 is not high speed, the USB_DEV_STAT[2:1] > should be equal to [0 1]. That is, the STAT_SPEED_FULL should be equal > to 2. > > There is a easy way to check the usb speed by the speed field of the > struct u

Re: [PATCH 1/1] AX88179_178A: Add ethtool ops for EEE support

2014-07-31 Thread David Miller
From: fre...@asix.com.tw Date: Thu, 31 Jul 2014 19:06:35 +0800 > From: Freddy Xin > > Add functions to support ethtool EEE manipulating, and the EEE > is disabled in default setting to enhance the compatibility > with certain switch. > > Signed-off-by: Freddy Xin Applied, thanks. -- To unsubs

Re: [PATCH] net/usb/hso: Add support for Option GTM671WFS

2014-08-05 Thread David Miller
From: Ricardo Ribalda Delgado Date: Mon, 4 Aug 2014 11:11:49 +0200 > After this patch: > > [ 32.985530] hso: drivers/net/usb/hso.c: Option Wireless > [ 33.000452] hso 2-1.4:1.7: Not our interface > [ 33.001849] usbcore: registered new interface driver hso > > root@qt5022:~# ls /dev/ttyHS

Re: [PATCH net-next 1/1] net: reduce USB network driver config options.

2014-08-05 Thread David Miller
From: Francois Romieu Date: Tue, 5 Aug 2014 23:10:52 +0200 > From: Francois Romieu > > USB network drivers are already handled in drivers/net/usb/Kconfig. > Let's save the maintenance burden of dependencies in drivers/net/Makefile. > > The newly introduced USB_NET_DRIVERS umbrella config optio

Re: [PATCH 1/1] net: fix USB network driver config option.

2014-08-06 Thread David Miller
From: Francois Romieu Date: Thu, 7 Aug 2014 00:36:40 +0200 > From: Francois Romieu > > It must be tristate to avoid broken dependencies with kernel built-in > usb network drivers when usb support is module only. > > When net config option is set, least surprize default should match usb. > > W

Re: [PATCH] rtl8150: Check if RSR is already defined

2014-08-06 Thread David Miller
From: Nick Krause Date: Thu, 7 Aug 2014 07:24:54 +0200 > I am getting the following warn > > drivers/net/usb/rtl8150.c:30:0: warning: "RSR" redefined > arch/xtensa/include/asm/processor.h:189:0: note: this is the location of the > previous definition > > I wanted to remove RSR as it is not be

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-22 Thread David Miller
From: Hayes Wang Date: Wed, 20 Aug 2014 16:58:35 +0800 > Parsing, checking, and writing the firmware. You haven't told us why you need to do this. These are just programming registers in the chip, and I see no reason to not keep these in the driver with real code. I'm not applying this series,

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-24 Thread David Miller
From: Hayes Wang Date: Mon, 25 Aug 2014 03:43:04 + > From: David Miller [mailto:da...@davemloft.net] > [...] >> You haven't told us why you need to do this. >> >> These are just programming registers in the chip, and I see no reason >> to not keep

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-25 Thread David Miller
From: Hayes Wang Date: Mon, 25 Aug 2014 06:43:02 + > Except the step 3, 4, 6 and 7, the other steps depend on the > context of the firmware. That is, for different firmware, some > actions would be removed or added, and some settings would be > different. Especially the step 8, it often diffe

Re: [PATCH net-next] r8152: check code with checkpatch.pl

2014-08-25 Thread David Miller
From: Hayes Wang Date: Mon, 25 Aug 2014 15:53:00 +0800 > 626: CHECK: Alignment should match open parenthesis > 646: CHECK: Alignment should match open parenthesis > 655: CHECK: Alignment should match open parenthesis > 695: CHECK: Alignment should match open parenthesis > 729: CHECK: Alignme

Re: [PATCH net-next] r8152: replace strncpy with strlcpy

2014-08-27 Thread David Miller
From: Hayes Wang Date: Tue, 26 Aug 2014 10:08:23 +0800 > Replace the strncpy with strlcpy, and use sizeof to determine the > length. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: net: Add ops->ndo_xmit_flush()

2014-08-27 Thread David Miller
From: Dan Carpenter Date: Tue, 26 Aug 2014 15:21:37 +0300 > Hello David S. Miller, > > The patch 4798248e4e02: "net: Add ops->ndo_xmit_flush()" from Aug 22, > 2014, leads to the following static checker warning: > > drivers/usb/gadget/function/f_ncm.c:1104 ncm_tx_tasklet() > error:

Re: [PATCH] cx82310_eth: fix semicolon.cocci warnings

2015-03-24 Thread David Miller
From: kbuild test robot Date: Tue, 24 Mar 2015 09:51:32 +0800 > drivers/net/usb/cx82310_eth.c:175:2-3: Unneeded semicolon > > Removes unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Ondrej Zary > Signed-off-by: Fengguang Wu Applied, thanks. -- To unsub

Re: [PATCH] usbnet: Fix tx_bytes statistic running backward in cdc_ncm

2015-03-29 Thread David Miller
From: Bjørn Mork Date: Wed, 25 Mar 2015 21:41:33 +0100 > From: Ben Hutchings > > cdc_ncm disagrees with usbnet about how much framing overhead should > be counted in the tx_bytes statistics, and tries 'fix' this by > decrementing tx_bytes on the transmit path. But statistics must never > be de

Re: [PATCH-2] drivers/net/usb: Add support for 'Lenovo OneLink Pro Dock'

2015-05-09 Thread David Miller
From: Vasily Titskiy Date: Wed, 6 May 2015 10:31:21 -0400 > This device is sold as 'Lenovo OneLink Pro Dock'. > Chipset is RTL8153 and works with r8152. > > Signed-off-by: Vasily Titskiy Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a m

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread David Miller
From: Bjørn Mork Date: Fri, 22 May 2015 13:15:22 +0200 > The tx_curr_frame_payload field is u32. When we try to calculate a > small negative delta based on it, we end up with a positive integer > close to 2^32 instead. So the tx_bytes pointer increases by about > 2^32 for every transmitted frame

Re: [Patch v1] ax88179_178a: add reset functionality in reset_resume

2015-06-23 Thread David Miller
From: Vivek Bhagat Date: Sun, 21 Jun 2015 11:41:43 +0530 > From d178065c9e3cfa8a45ef537fae7412775339beb0 Mon Sep 17 00:00:00 2001 > From: Vivek Kumar Bhagat > Date: Thu, 11 Jun 2015 07:23:46 -0700 > Subject: [PATCH] ax88179_178a: add reset functionality in reset_resume > > Without reset functio

Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure

2015-10-05 Thread David Miller
From: "David B. Robins" Date: Wed, 30 Sep 2015 16:20:04 -0400 > If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will return > but not clear rx->size. rx points to driver private data. A later call > assumes that nonzero size means ax_skb was allocated and passes a null > ax_skb to sk

Re: [PATCH v2 0/5] Improve ASIX RX memory allocation error handling

2015-10-05 Thread David Miller
From: Dean Jenkins Date: Fri, 2 Oct 2015 14:29:03 +0100 > The ASIX RX handler algorithm is weak on error handling. > There is a design flaw in the ASIX RX handler algorithm because the > implementation for handling RX Ethernet frames for the DUB-E100 C1 can > have Ethernet frames spanning multipl

Re: [PATCH] net: asix: add support for the Billionton GUSB2AM-1G-B USB adapter

2015-10-15 Thread David Miller
From: Date: Thu, 15 Oct 2015 18:51:38 +0800 > * > This email message, including any attachments, is for the sole > use of the intended recipient(s) and may contain confidential and > privileged information. Any unauthorized r

Re: [PATCH] net: asix: add support for the Billionton GUSB2AM-1G-B USB adapter

2015-10-18 Thread David Miller
From: changch...@gmail.com Date: Fri, 16 Oct 2015 02:00:21 +0800 > From: Chia-Sheng Chang > > Just another AX88178-based 10/100/1000 USB-to-Ethernet dongle. This one > shows up in lsusb as: "ID 08dd:0114 Billionton Systems, Inc". > > Signed-off-by: Chia-Sheng Chang > Cc: "David S. Miller" Ap

Re: [PATCH net,stable] qmi_wwan: add Sierra Wireless MC74xx/EM74xx

2015-10-22 Thread David Miller
From: Bjørn Mork Date: Thu, 22 Oct 2015 14:15:58 +0200 > New device IDs shamelessly lifted from the vendor driver. > > Signed-off-by: Bjørn Mork Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH net,stable] qmi_wwan: fix entry for HP lt4112 LTE/HSPA+ Gobi 4G Module

2015-11-02 Thread David Miller
From: Bjørn Mork Date: Sun, 1 Nov 2015 01:34:50 +0100 > The lt4112 is a HP branded Huawei me906e modem. Like other Huawei > modems, it does not have a fixed interface to function mapping. > Instead it uses a Huawei specific scheme: functions are mapped by > subclass and protocol. > > However, t

Re: [PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread David Miller
From: Petr Štetiar Date: Thu, 5 Nov 2015 12:55:01 +0100 > This device has same vendor and product IDs as G2K devices, but it has > different number of interfaces(4 vs 5) and also different interface > layout where EC20 has QMI on interface 4 instead of 0. > > lsusb output: ... > Signed-off-by:

Re: [PATCH 1/1] net: usb: cdc_ether: add Dell DW5580 as a mobile broadband adapter

2015-11-16 Thread David Miller
From: Daniele Palmas Date: Fri, 13 Nov 2015 18:01:21 +0100 > Since Dell DW5580 is a 3G modem, this patch adds the device as a > mobile broadband adapter > > Signed-off-by: Daniele Palmas Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message t

Re: [PATCH net,stable] net: qmi_wwan: add XS Stick W100-2 from 4G Systems

2015-11-18 Thread David Miller
From: Bjørn Mork Date: Wed, 18 Nov 2015 21:13:07 +0100 > Thomas reports ... > Reported-by: Thomas Schäfer > Signed-off-by: Bjørn Mork Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.k

Re: [PATCH] net: cdc_ncm: fix NULL pointer deref in cdc_ncm_bind_common

2015-11-24 Thread David Miller
From: Bjørn Mork Date: Mon, 23 Nov 2015 14:32:10 +0100 > Commit 77b0a099674a ("cdc-ncm: use common parser") added a dangerous > new trust in the CDC functional descriptors presented by the device, > unconditionally assuming that any device handled by the driver has > a CDC Union descriptor. > >

Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy

2015-11-29 Thread David Miller
From: Anup Limbu Date: Wed, 25 Nov 2015 15:37:21 +0530 > replace kmalloc + memset with kmemdup > > Signed-off-by: Anup Limbu I agree with Bjorn that this microturfing cleanup misses the real higher level opportunity to use the usbnet_read_cmd() and usbnet_write_cmd() helpers that already exist

Re: [PATCH 2/2] Minor improvement for smsc95xx netusb driver performance.

2015-11-29 Thread David Miller
From: Ameen Date: Wed, 25 Nov 2015 23:55:26 +0200 > if (csum) > - tx_cmd_b |= TX_CMD_B_CSUM_ENABLE; > - cpu_to_le32s(&tx_cmd_b); > - memcpy(skb->data, &tx_cmd_b, 4); > + tx_cmds.cmd_b |= TX_CMD_B_CSUM_ENABLE; You've corrupted the indentation here. -- To unsubscrib

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-19 Thread David Miller
From: Scott Feldman Date: Mon, 19 Jan 2015 00:03:42 -0800 > On Sun, Jan 18, 2015 at 11:13 PM, Hayes Wang wrote: >> @@ -1746,7 +1746,18 @@ find_next_rx: >> } >> >> submit: >> - r8152_submit_rx(tp, agg, GFP_ATOMIC); >> + if (!ret) { >> +

Re: [PATCH net 0/2] r8152: couldn't read OCP_SRAM_DATA

2015-01-19 Thread David Miller
From: Hayes Wang Date: Mon, 19 Jan 2015 17:02:44 +0800 > Read OCP_SRAM_DATA would read additional bytes and may let > the hw abnormal. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-19 Thread David Miller
From: Hayes Wang Date: Tue, 20 Jan 2015 02:48:50 + >> >> + urb->actual_length = 0; >> >> + list_add_tail(&agg->list, next); >> > >> > Do you need a spin_lock_irqsave(&tp->rx_lock, flags) around this? >> >> Indeed, and rtl_start_rx() seems to also

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-24 Thread David Miller
From: Hayes Wang Date: Tue, 20 Jan 2015 03:24:52 + > David Miller [mailto:da...@davemloft.net] >> Sent: Tuesday, January 20, 2015 10:52 AM > [...] >> agg->list is not local, you have to use a spinlock to protect >> modifications to it, some other sites which modi

Re: [PATCH v2 00/11] hso: fix some problems in the disconnect path

2015-02-01 Thread David Miller
From: Olivier Sobrie Date: Fri, 30 Jan 2015 13:21:52 +0100 > These patches attempt to fix some problems I observed when the hso > device is disconnected. > Several patches of this serie are fixing crashes or memleaks when a > hso device is disconnected. > This serie of patches is based on v3.18.

Re: [PATCH] net: usb: sr9700: Use 'SR_' prefix for the common register macros

2015-02-04 Thread David Miller
From: Chen Gang S Date: Tue, 03 Feb 2015 05:00:40 +0800 > The commone register macors (e.g. RSR) is too commont to drivers, it may > be conflict with the architectures (e.g. xtensa, sh). > > The related warnings (with allmodconfig under xtensa): > > CC [M] drivers/net/usb/sr9700.o > In f

Re: [PATCH] hso: Use static attribute groups for sysfs entry

2015-02-05 Thread David Miller
From: Takashi Iwai Date: Wed, 4 Feb 2015 14:39:33 +0100 > Pass the static attribute groups and the driver data via > tty_port_register_device_attr() instead of manual device_create_file() > and device_remove_file() calls. > > Signed-off-by: Takashi Iwai This does not apply cleanly to the net-

Re: [PATCH v2] hso: Use static attribute groups for sysfs entry

2015-02-05 Thread David Miller
From: Takashi Iwai Date: Thu, 5 Feb 2015 11:15:24 +0100 > Pass the static attribute groups and the driver data via > tty_port_register_device_attr() instead of manual device_create_file() > and device_remove_file() calls. > > Signed-off-by: Takashi Iwai > --- > v1->v2: rebased to linux-next A

Re: [PATCH net-next v2 0/7] r8152: adjust the code

2015-02-07 Thread David Miller
From: Hayes Wang Date: Fri, 6 Feb 2015 11:30:44 +0800 > V2: > Correct the subject of patch #5. Replace "link feed" with "line feed". > > v1: > Code adjustment. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@v

Re: [trivial PATCH] treewide: Remove unnecessary BCMA_CORETABLE_END macro

2015-02-11 Thread David Miller
From: Joe Perches Date: Tue, 10 Feb 2015 12:55:03 -0800 > Use the normal {} instead of a macro to terminate an array. > > Remove the macro too. > > Signed-off-by: Joe Perches I've applied both of your FOO_END removal patches, thanks Joe. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] hso: fix rx parsing logic when skb allocation fails

2015-02-13 Thread David Miller
From: Aleksander Morgado Date: Fri, 13 Feb 2015 14:51:02 +0100 > If skb allocation fails once the IP header has been received, the rx state is > being set to WAIT_SYNC. The logic, though, shouldn't directly return, as the > buffer may contain a full packet, and therefore the WAIT_SYNC state needs

Re: [PATCH net] r8152: restore hw settings

2015-02-14 Thread David Miller
From: Hayes Wang Date: Thu, 12 Feb 2015 16:20:46 +0800 > There is a capability which let the hw could change the settings > automatically when the power change to ON. However, the USB reset > would reset the settings to the hw default, so the driver has to > restore the relative settings. Otherwi

Re: [PATCH net-next v2 0/3] Adjust the settings about USB_RX_EARLY_AGG

2015-02-19 Thread David Miller
From: Hayes Wang Date: Thu, 12 Feb 2015 14:33:45 +0800 > v2: > For patch #1, replace > > u32 ocp_data; > ocp_data = tp->coalesce / 8; > > with > > u32 ocp_data = tp->coalesce / 8; > > And replace > > struct net_device *dev = tp->netdev; > u32 ocp_data; > o

Re: [PATCH] usb: plusb: Add support for National Instruments host-to-host cable

2015-02-20 Thread David Miller
From: Ben Shelton Date: Mon, 16 Feb 2015 13:47:06 -0600 > The National Instruments USB Host-to-Host Cable is based on the Prolific > PL-25A1 chipset. Add its VID/PID so the plusb driver will recognize it. > > Signed-off-by: Ben Shelton Applied, thanks. -- To unsubscribe from this list: send t

Re: [PATCH] hso: always read interface number from the current altsetting

2015-02-20 Thread David Miller
From: Aleksander Morgado Date: Tue, 17 Feb 2015 11:31:29 +0100 > Always read bInterfaceNumber from the current altsetting, not from the first > one > available in the altsetting array. This is coming from code review, not > related > to any specific bug. > > Signed-off-by: Aleksander Morgado

Re: [PATCH 5/7 linux-next] hso: replace current->state by __set_current_state()

2015-02-22 Thread David Miller
From: Fabian Frederick Date: Fri, 20 Feb 2015 19:12:55 +0100 > Use helper functions to access current->state. > Direct assignments are prone to races and therefore buggy. > > Thanks to Peter Zijlstra for the exact definition of the problem. > > Suggested-By: Peter Zijlstra > Signed-off-by: Fab

Re: [PATCH] net: asix: add support for the Sitecom LN-028 USB adapter

2015-02-27 Thread David Miller
From: Luca Ceresoli Date: Thu, 26 Feb 2015 00:58:12 +0100 > Just another AX88178-based 10/100/1000 USB-to-Ethernet dongle. This one > shows up in lsusb as: "Sitecom Europe B.V. LN-028 Network USB 2.0 Adapter". > > Signed-off-by: Luca Ceresoli Applied, thanks. -- To unsubscribe from this list:

Re: [PATCH] usb: plusb: Add support for National Instruments host-to-host cable

2015-02-27 Thread David Miller
From: Ben Shelton Date: Fri, 27 Feb 2015 15:26:32 -0600 > On 02/20, David Miller wrote: >> From: Ben Shelton >> Date: Mon, 16 Feb 2015 13:47:06 -0600 >> >> > The National Instruments USB Host-to-Host Cable is based on the Prolific >> > PL-25A1 chipset. A

Re: [PATCH net-next] usbnet: Fix tx_packets stat for FLAG_MULTI_FRAME drivers

2015-02-28 Thread David Miller
From: Ben Hutchings Date: Thu, 26 Feb 2015 19:34:37 + > Currently the usbnet core does not update the tx_packets statistic for > drivers with FLAG_MULTI_PACKET and there is no hook in the TX > completion path where they could do this. > > cdc_ncm and dependent drivers are bumping tx_packets

Re: [PATCH] usb: plusb: Add support for National Instruments host-to-host cable

2015-03-02 Thread David Miller
From: Ben Shelton Date: Mon, 2 Mar 2015 10:00:14 -0600 > On 02/27, David Miller wrote: >> From: Ben Shelton >> Date: Fri, 27 Feb 2015 15:26:32 -0600 >> >> > On 02/20, David Miller wrote: >> >> From: Ben Shelton >> >> Date: Mon,

Re: linux-next: manual merge of the net-next tree with the vfs tree

2015-03-12 Thread David Miller
From: Al Viro Date: Fri, 13 Mar 2015 03:56:09 + > On Thu, Mar 12, 2015 at 11:24:26PM -0400, David Miller wrote: >> From: Stephen Rothwell >> Date: Fri, 13 Mar 2015 13:15:43 +1100 >> >> > Today's linux-next merge of the net-next tree got a conflict i

Re: [PATCH v2] usbnet: fix kernel crash after disconnect

2019-05-20 Thread David Miller
From: Kloetzke Jan Date: Thu, 16 May 2019 07:10:30 + > Am Montag, den 06.05.2019, 10:17 +0200 schrieb Oliver Neukum: >> On So, 2019-05-05 at 00:45 -0700, David Miller wrote: >> > From: Kloetzke Jan >> > Date: Tue, 30 Apr 2019 14:15:07 + >> > >&

Re: [PATCH v3] usbnet: fix kernel crash after disconnect

2019-05-21 Thread David Miller
From: Kloetzke Jan Date: Tue, 21 May 2019 13:18:40 + > When disconnecting cdc_ncm the kernel sporadically crashes shortly > after the disconnect: ... > The crash happens roughly 125..130ms after the disconnect. This > correlates with the 'delay' timer that is started on certain USB tx/rx > e

Re: [PATCH net,stable] qmi_wwan: Fix out-of-bounds read

2019-06-24 Thread David Miller
From: Bjørn Mork Date: Mon, 24 Jun 2019 18:45:11 +0200 > The syzbot reported > > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0xca/0x13e lib/dump_stack.c:113 > print_address_description+0x67/0x231 mm/kasan/report.c:188 > __kasan_report.cold+0x1a/0x32 mm/kasan/rep

Re: [PATCH] ISDN: hfcsusb: checking idx of ep configuration

2019-07-15 Thread David Miller
From: Phong Tran Date: Mon, 15 Jul 2019 22:08:14 +0700 > The syzbot test with random endpoint address which made the idx is > overflow in the table of endpoint configuations. > > this adds the checking for fixing the error report from > syzbot > > KASAN: stack-out-of-bounds Read in hfcsusb_prob

Re: [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 device ID

2019-07-18 Thread David Miller
From: Rogan Dawes Date: Wed, 17 Jul 2019 11:14:33 +0200 > Signed-off-by: Rogan Dawes Applied.

Re: [PATCH] net: lan78xx: Merge memcpy + lexx_to_cpus to get_unaligned_lexx

2019-07-22 Thread David Miller
From: Chuhong Yuan Date: Fri, 19 Jul 2019 15:36:15 +0800 > Merge the combo use of memcpy and lexx_to_cpus. > Use get_unaligned_lexx instead. > This simplifies the code. > > Signed-off-by: Chuhong Yuan Applied.

Re: [PATCH] usbnet: smsc75xx: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-22 Thread David Miller
From: Chuhong Yuan Date: Fri, 19 Jul 2019 16:27:31 +0800 > Merge the combo use of memcpy and le32_to_cpus. > Use get_unaligned_le32 instead. > This simplifies the code. > > Signed-off-by: Chuhong Yuan Applied.

Re: [PATCH] ax88179_178a: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-22 Thread David Miller
From: Chuhong Yuan Date: Fri, 19 Jul 2019 17:07:15 +0800 > Merge the combo use of memcpy and le32_to_cpus. > Use get_unaligned_le32 instead. > This simplifies the code. > > Signed-off-by: Chuhong Yuan Applied.

Re: [PATCH] net: usb: Merge cpu_to_le32s + memcpy to put_unaligned_le32

2019-07-22 Thread David Miller
From: Chuhong Yuan Date: Mon, 22 Jul 2019 15:41:34 +0800 > Merge the combo uses of cpu_to_le32s and memcpy. > Use put_unaligned_le32 instead. > This simplifies the code. > > Signed-off-by: Chuhong Yuan Isn't the skb->data aligned to 4 bytes in these situations? If so, we should use the aligne

Re: [PATCH] net: usb: Merge cpu_to_le32s + memcpy to put_unaligned_le32

2019-07-22 Thread David Miller
From: Chuhong Yuan Date: Tue, 23 Jul 2019 10:16:27 +0800 > David Miller 于2019年7月23日周二 上午9:22写道: >> >> From: Chuhong Yuan >> Date: Mon, 22 Jul 2019 15:41:34 +0800 >> >> > Merge the combo uses of cpu_to_le32s and memcpy. >> > Use put_unaligne

Re: [PATCH 2/2] net: usb: qmi_wwan: Add the BroadMobi BM818 card

2019-07-26 Thread David Miller
From: "Angus Ainslie (Purism)" Date: Wed, 24 Jul 2019 07:52:27 -0700 > From: Bob Ham > > The BroadMobi BM818 M.2 card uses the QMI protocol > > Signed-off-by: Bob Ham > Signed-off-by: Angus Ainslie (Purism) Applied, thanks.

Re: [PATCH v5 12/29] compat_ioctl: move drivers to compat_ptr_ioctl

2019-07-30 Thread David Miller
From: Arnd Bergmann Date: Tue, 30 Jul 2019 21:50:28 +0200 > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg Kroah-Hartma

Re: [PATCH] NFC: nfcmrvl: fix gpio-handling regression

2019-08-05 Thread David Miller
From: Johan Hovold Date: Mon, 5 Aug 2019 12:00:55 +0200 > Fix two reset-gpio sanity checks which were never converted to use > gpio_is_valid(), and make sure to use -EINVAL to indicate a missing > reset line also for the UART-driver module parameter and for the USB > driver. > > This specifical

Re: [PATCH net-next 5/5] r8152: change rx_frag_head_sz and rx_max_agg_num dynamically

2019-08-08 Thread David Miller
From: Hayes Wang Date: Fri, 9 Aug 2019 03:38:53 + > Jakub Kicinski [jakub.kicin...@netronome.com] > [..]> The kernel could support it. And I has finished it. >> > However, when I want to test it by ethtool, I couldn't find suitable >> > command. >> > I couldn't find relative feature in the s

Re: [PATCH] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

2018-03-25 Thread David Miller
From: Torsten Hilbrich Date: Fri, 23 Mar 2018 14:26:18 +0100 > This is needed to support the modem found in HP EliteBook 820 G3. > > Signed-off-by: Torsten Hilbrich This patch was corrupted by your email client, it transformed TAB characters into sequence of spaces. Please email the patch to

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

2018-03-26 Thread David Miller
From: Joe Perches Date: Fri, 23 Mar 2018 15:54:39 -0700 > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe Perches

Re: [PATCH] net: qmi_wwan: add BroadMobi BM806U 2020:2033

2018-03-26 Thread David Miller
From: Pawel Dembicki Date: Sat, 24 Mar 2018 22:08:14 +0100 > BroadMobi BM806U is an Qualcomm MDM9225 based 3G/4G modem. > Tested hardware BM806U is mounted on D-Link DWR-921-C3 router. > The USB id is added to qmi_wwan.c to allow QMI communication with > the BM806U. > > Tested on 4.14 kernel and

<    1   2   3   4   5   6   7   8   >