Re: [PATCH net v4 3/4] r8152: support stopping/waking tx queue

2013-11-19 Thread David Miller
From: Hayes Wang Date: Tue, 19 Nov 2013 11:25:10 +0800 > The maximum packet number which a tx aggregation buffer could contain > is the buffer size / (packet size + descriptor size). > > If the tx buffer is empty and the tx queue length is more than the > maximum value which is defined above, st

Re: [PATCH net v4 3/4] r8152: support stopping/waking tx queue

2013-11-19 Thread David Miller
From: hayeswang Date: Wed, 20 Nov 2013 11:28:46 +0800 > David Miller [mailto:da...@davemloft.net] > [...] >> This is racy. >> >> You have nothing which synchronizes r8152_tx_agg_fill() and >> rtl8152_start_xmit(), >> therefore: >>

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

2013-11-19 Thread David Miller
From: fre...@asix.com.tw Date: Wed, 20 Nov 2013 10:11:36 +0800 > From: Freddy Xin > > This patch adds a workaroud to solve Suspend/Resume issue that AX88772B turns > off its Ethernet PHY power in the case that REMOTE_WAKEUP feature doesn't > be set when system suspend. In this case, the PHY powe

Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

2013-11-20 Thread David Miller
From: Grant Grundler Date: Wed, 20 Nov 2013 09:42:42 -0800 > While this patch raises a new issue, can you apply this patch anyway > since in most cases (default settings) it improves "the user > experience" for most users? I'm not applying a patch which knowingly is not implemented correctly. --

Re: [PATCH] asix: Support DLink DUB-E100 H/W Ver C1

2012-09-17 Thread David Miller
From: Søren Holm Date: Thu, 13 Sep 2012 15:45:40 +0200 > Signed-off-by: Søren Holm > Cc: sta...@vger.kernel.org Networking patches should be submitted to net...@vger.kernel.org -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ker

Re: [RFC PATCH 0/3] usbnet: support runtime PM triggered by link change

2012-09-20 Thread David Miller
There seems to be some discussion about the legitimacy of doing things this way, and in any event the patches were an RFC. Please resubmit as a non-RFC once all the issues have been worked out, if appropriate. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: [RFC PATCH v1 1/3] usbnet: introduce usbnet_link_change API

2012-09-20 Thread David Miller
From: Ming Lei Date: Tue, 18 Sep 2012 22:23:19 +0800 > +void usbnet_link_change(struct usbnet *dev, int link, int need_reset) Please use 'bool' for link and need_reset. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org M

Re: [RFC PATCH 0/3] usbnet: support runtime PM triggered by link change

2012-09-20 Thread David Miller
From: Oliver Neukum Date: Thu, 20 Sep 2012 23:04:38 +0200 > On Thursday 20 September 2012 17:02:27 David Miller wrote: >> >> There seems to be some discussion about the legitimacy of doing things >> this way, and in any event the patches were an RFC. >> >> Plea

Re: [PATCH v2] USB: remove dbg() usage in USB networking drivers

2012-09-20 Thread David Miller
From: Greg Kroah-Hartman Date: Wed, 19 Sep 2012 20:46:14 +0100 > From: Greg Kroah-Hartman > > The dbg() USB macro is so old, it predates me. The USB networking drivers are > the last hold-out using this macro, and we want to get rid of it, so replace > the usage of it with the proper netdev_db

Re: [PATCH net] net: qmi_wwan: call subdriver with control intf only

2012-09-20 Thread David Miller
From: Bjørn Mork Date: Mon, 10 Sep 2012 22:15:50 +0200 > This fixes a hang on suspend due to calling wdm_suspend on > the unregistered data interface. The hang should have been > a NULL pointer reference had it not been for a logic error > in the cdc_wdm code. > > commit 230718bd net: qmi_wwan

Re: [PATCH net-next] net1080: Neaten netdev_dbg use

2012-09-20 Thread David Miller
From: Joe Perches Date: Thu, 20 Sep 2012 17:10:23 -0700 > Remove unnecessary temporary variable and #ifdef DEBUG block. > > Signed-off-by: Joe Perches Applied, thanks Joe. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: [PATCH net-next] net: qmi_wwan: adding Huawei E367, ZTE MF683 and Pantech P4200

2012-09-21 Thread David Miller
From: Bjørn Mork Date: Thu, 20 Sep 2012 09:18:05 +0200 > This is the net-next version of the previously posted patch with the > same title. I totally forgot that I had messed with the .driver_info > fields, making it impossible to apply the same patch to both net and > net-next. > > Sorry abou

Re: [PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread David Miller
All networking patches must be submitted to net...@vger.kernel.org Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] Adds support for Lenovo 10/100 USB dongle.

2012-10-01 Thread David Miller
From: Quinlan Pfiffer Date: Fri, 28 Sep 2012 22:58:44 -0700 > This dongle ships with the X1 Carbon, and has an AX88772B > usb to ethernet chip in it. > > Signed-off-by: Quinlan Pfiffer Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] kaweth: print correct debug ptr

2012-10-11 Thread David Miller
From: Alan Cox Date: Thu, 11 Oct 2012 17:22:03 +0100 > From: Alan Cox > > We nowdays copy the buffer and free fw->data, so make the debug printk use > the right thing. > > Signed-off-by: Alan Cox Applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net] net: qmi_wwan: adding more ZTE devices

2012-10-18 Thread David Miller
From: Bjørn Mork Date: Thu, 18 Oct 2012 17:11:29 +0200 > Analyzed a few Windows driver description files, supporting > this long list of devices: ... > Adding the ones we were missing. > > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH net-next 00/14] Adding a USB CDC MBIM driver

2012-10-18 Thread David Miller
I didn't see patch #14, where is it? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net-next 00/13] Adding a USB CDC MBIM driver

2012-10-22 Thread David Miller
From: Bjørn Mork Date: Mon, 22 Oct 2012 22:56:27 +0200 > The USB Communications Device Class "Mobile Broadband Interface Model" > (MBIM) is the USB-IFs alternative to the current chipset/vendor > specific solutions to "Mobile Broadband" device management. The > specification, including the manage

Re: [PATCH v1 00/11] usbnet: usb_control_msg cleanup

2012-10-23 Thread David Miller
From: Ming Lei Date: Tue, 23 Oct 2012 17:19:29 +0800 > On Mon, Oct 15, 2012 at 2:30 PM, Oliver Neukum wrote: >>> >>> v1: >>> - drop previous patch 12, and let net/core handle >>> runtime PM in ioctl path >> >> Acked-by: Oliver Neukum > > David, could you queue the patchset on net-n

Re: [PATCH] bas_gigaset: fix pre_reset handling

2012-10-25 Thread David Miller
From: Tilman Schmidt Date: Wed, 24 Oct 2012 20:44:32 +0200 > The delayed work function int_in_work() may call usb_reset_device() > and thus, indirectly, the driver's pre_reset method. Trying to > cancel the work synchronously in that situation would deadlock. > Fix by avoiding cancel_work_sync()

Re: [PATCH v2 00/11] usbnet: usb_control_msg cleanup

2012-10-26 Thread David Miller
From: Ming Lei Date: Thu, 25 Oct 2012 13:46:53 +0800 > This patch set introduces 3 helpers for handling usb read, write > and write_async command, and replaces the low level's implemention > with the generic ones. > > This patchset is a cleanup and about 300 lines code is saved. > > Also, the p

Re: [PATCH] net: usb: Fix memory leak on Tx data path

2012-10-26 Thread David Miller
From: Oliver Neukum Date: Fri, 26 Oct 2012 09:39:16 +0200 > On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote: >> Driver anchors the tx urbs and defers the urb submission if >> a transmit request comes when the interface is suspended. >> Anchoring urb increments the urb reference count. The

Re: [PATCH] qmi_wwan/cdc_ether: move Novatel 551 and E362 to qmi_wwan

2012-10-26 Thread David Miller
From: Dan Williams Date: Wed, 24 Oct 2012 17:10:34 -0500 > These devices provide QMI and ethernet functionality via a standard CDC > ethernet descriptor. But when driven by cdc_ether, the QMI > functionality is unavailable because only cdc_ether can claim the USB > interface. Thus blacklist the

Re: [PATCH net-next] net: cdc_ncm: error path lock fix

2012-10-28 Thread David Miller
From: Bjørn Mork Date: Fri, 26 Oct 2012 09:44:09 +0200 > Fixes the sparse warning > > drivers/net/usb/cdc_ncm.c:836:9: warning: context imbalance in > 'cdc_ncm_txpath_bh' - different lock contexts for basic block > > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send

Re: [PATCH net-next] net: cdc_ncm: big endian fix

2012-10-28 Thread David Miller
From: Bjørn Mork Date: Fri, 26 Oct 2012 09:44:08 +0200 > Probably doesn't matter much since the value is used as a > boolean anyway, but it removes the sparse warning: > > drivers/net/usb/cdc_ncm.c:1090:32: warning: incorrect type in assignment > (different base types) > drivers/net/usb/cdc_n

Re: [PATCH net-next] net: sierra: shut up sparse restricted type warnings

2012-10-28 Thread David Miller
From: Bjørn Mork Date: Fri, 26 Oct 2012 09:44:07 +0200 > Removes the warnings > > drivers/net/usb/sierra_net.c:343:45: warning: incorrect type in assignment > (different base types) > drivers/net/usb/sierra_net.c:343:45:expected unsigned short [unsigned] > [short] [usertype] > drivers/

Re: [PATCH V2 0/3] Removing the use of VLAIS from USB Gadget and netfilter

2012-10-31 Thread David Miller
I'm not pulling this crap into my tree to deal with limitations of a non-gcc compiler. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread David Miller
From: Felipe Balbi Date: Thu, 1 Nov 2012 09:21:16 +0200 > then we can merge to net tree and handle the conflicts when merging to > Linus, that'd be fine by me as long as people know how to solve the > conflict properly ;-) Like Herbert with the crypto tree, I'm simply not merging this absolute c

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread David Miller
From: Bjørn Mork Date: Thu, 01 Nov 2012 14:38:29 +0100 > Felipe Balbi writes: > >> btw, only alpha and x86 seem to be providing all of those, but if you >> look into our documentation, it's said that drivers are supposed to use >> write/read{b,w,l,q} for all memory-mapped io. I'd expect all pla

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread David Miller
From: Max Filippov Date: Thu, 1 Nov 2012 16:47:14 +0300 > Strange, AFAICS architectures that use asm-generic/io.h (blackfin, openrisc, > score, unicore32 and xtensa) also provide those functions. They define HAVE_IOMEM, s390 does not, therefore you must protect the driver Kconfig with HAVE_IOMEM

Re: [PATCH 0/4] usbnet: avoiding access auto-suspended device

2012-11-03 Thread David Miller
From: Ming Lei Date: Mon, 29 Oct 2012 15:45:05 +0800 > Thip patchset avoids accessing auto-suspended device in ioctl path, > which is generally triggered by some network utility(ethtool, ifconfig, > ...) > > Most of network devices have the problem, but as discussed in the > thread: > > h

Re: [PATCH v1 2/5] usbnet: smsc75xx: apply the introduced usbnet_read[write]_cmd_nopm

2012-11-03 Thread David Miller
From: Ming Lei Date: Sun, 4 Nov 2012 09:29:51 +0800 > This patch applies the introduced usbnet_read_cmd_nopm() and > usbnet_write_cmd_nopm() in the callback of resume and suspend > to avoid deadlock if USB runtime PM is considered into > usbnet_read_cmd() and usbnet_write_cmd(). > > Cc: Steve G

Re: [PATCH v1 0/5] usbnet: avoiding access auto-suspended device

2012-11-05 Thread David Miller
From: Oliver Neukum Date: Mon, 05 Nov 2012 10:24:57 +0100 > On Sunday 04 November 2012 09:29:49 Ming Lei wrote: >> Thip patchset avoids accessing auto-suspended device in ioctl path, >> which is generally triggered by some network utility(ethtool, ifconfig, >> ...) >> >> Most of network devices

Re: [PATCH v4 0/5] usbnet: avoiding access auto-suspended device

2012-11-07 Thread David Miller
From: Ming Lei Date: Tue, 6 Nov 2012 22:53:03 +0800 > This patchset avoids accessing auto-suspended device in ioctl path, > which is generally triggered by some network utility(ethtool, ifconfig, > ...) > > Most of network devices have the problem, but as discussed in the > thread: > >

Re: [PATCH 0/2] Fix CDC_EEM with 802.1Q VLAN and 1500 MTU

2012-11-07 Thread David Miller
Patch #2 does not apply cleanl to the net tree. Please respin and repost this entire series again. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH v2 0/2] Fix CDC_EEM with 802.1Q VLAN and 1500 MTU

2012-11-07 Thread David Miller
From: Ian Coolidge Date: Wed, 7 Nov 2012 16:39:17 -0800 > cdc_eem USB host driver and gadget driver both are broken in 1500 MTU > case while using 802.1Q VLANs. In both cases, this is due to the > assumption of standard Ethernet frame length. > > v2: rebase against Dave Miller's 'net/master' tr

Re: [PATCH v2 0/2] Fix CDC_EEM with 802.1Q VLAN and 1500 MTU

2012-11-08 Thread David Miller
From: Felipe Balbi Date: Thu, 8 Nov 2012 15:37:36 +0200 > Hi, > > On Wed, Nov 07, 2012 at 09:27:52PM -0500, David Miller wrote: >> From: Ian Coolidge >> Date: Wed, 7 Nov 2012 16:39:17 -0800 >> >> > cdc_eem USB host driver and gadget driver both are brok

Re: [PATCH v4 3/5] usbnet: smsc95xx: fix memory leak in smsc95xx_suspend

2012-11-08 Thread David Miller
From: Maulik Mankad Date: Fri, 9 Nov 2012 12:28:17 +0530 > We don't need memset() here. > May be command[2] = {0}; offset[2] = {0}; crc[4] = {0}; is enough. The compiler can see this an will eliminate the unnecessary clears. So it's better to use memset and make the code much clearer and easier

Re: [PATCH] net: cdc_ncm: add Huawei devices

2012-11-13 Thread David Miller
From: Bjørn Mork Date: Tue, 13 Nov 2012 14:19:43 +0100 > A number of Huawei 3G and LTE modems implement a CDC NCM function, > including the necessary functional descriptors, but using a non > standard interface layout and class/subclass/protocol codes. > > These devices can be handled by this dr

Re: [PATCH v4 0/6] Generic PHY Framework

2013-03-28 Thread David Miller
You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

2013-03-29 Thread David Miller
From: Dan Williams Date: Thu, 28 Mar 2013 11:30:07 -0500 > + if (test_bit (EVENT_DEV_ASLEEP, &dev->flags)) > + return -EINVAL; > + > + mutex_lock (&dev->interrupt_mutex); Please do not put a space between a function name and the openning parenthesis in the call. These are no

Re: [PATCH 2/2 v3] sierra_net: keep status interrupt URB active

2013-03-29 Thread David Miller
Please respin this along with patch #1 when you fix the coding style issues I mentioned, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next] cdc_ncm: return -ENOMEM if kzalloc fails

2013-03-30 Thread David Miller
From: Devendra Naga Date: Sat, 30 Mar 2013 14:33:22 +0530 > return -ENOMEM instead if kzalloc of cdc_ncm_ctx structure is failed. > > and also remove the comparision of ctx structure with NULL and make > it as !ctx. > > Signed-off-by: Devendra Naga Applied. -- To unsubscribe from this list: s

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread David Miller
From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 11:29:53 +0530 > Hi, > > On Friday 29 March 2013 12:01 AM, David Miller wrote: >> >> You really need to CC: net...@vger.kernel.org rather than me >> explicitly >> on this patch set. > > I was CC'

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-03 Thread David Miller
From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 12:05:30 +0530 > This patch series is about drivers/phy which will be used for now by > usb, sata and maybe some video PHY's. Network itself has a > comprehensive PHY in drivers/net/phy which we'd like to merge it with > drivers/phy so that we ha

Re: [PATCH net-next] net: cdc_ncm: demote "unexpected notification" to debug level

2013-04-08 Thread David Miller
From: Bjørn Mork Date: Mon, 8 Apr 2013 20:26:23 +0200 > Receiving unhandled notifications is most certainly not an error > and should not be logged as one. Knowing that the device sends > notifications we don't handle is useful for developers, but there > is very little a user can do about this

Re: [PATCH 00/11] usbnet: usbnet: handle link change

2013-04-11 Thread David Miller
From: Ming Lei Date: Thu, 11 Apr 2013 22:40:29 +0800 > This patch set introduces usbnet_link_change() API and applies > it on all usbnet drivers, then handle the link change centrally > to stop bulk transfer when link becomes off and restart bulk > transfer when link becomes on. > > With the cha

Re: [PATCH 11/11] usbnet: handle link change

2013-04-11 Thread David Miller
From: Ming Lei Date: Thu, 11 Apr 2013 22:52:29 +0800 > On Thu, Apr 11, 2013 at 10:40 PM, Ming Lei wrote: >> dd if=/dev/sda iflag=direct of=/dev/null bs=1M count=500 > > Sorry, the above should be: > > dd if=/dev/sda iflag=direct of=/dev/null bs=1M count=800 I'll fix this up wh

Re: [PATCH net,stable-3.8] net: cdc_mbim: remove bogus sizeof()

2013-04-16 Thread David Miller
From: Bjørn Mork Date: Tue, 16 Apr 2013 12:17:07 +0200 > The intention was to test against the constant, not the size of > the constant. > > Signed-off-by: Bjørn Mork Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@

Re: [PATCH net,stable 0/3] qmi_wwan: working around 3 serious firmware bugs

2013-04-19 Thread David Miller
From: Bjørn Mork Date: Fri, 19 Apr 2013 00:57:08 +0200 > This series adds workarounds for 3 different firmware bugs, each > preventing the affected devices from working at all. I therefore > humbly request that these fixes go to stable-3.8 (if still > maintained) and 3.9 (either via net if still

Re: [PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread David Miller
From: Bjørn Mork Date: Wed, 01 May 2013 20:33:10 +0200 > Dan Williams writes: > >> A rebranded Novatel E371 for AT&T's LTE bands. > > I don't think we're handling the Novatel branded E371 yet? I tried > googling for ID of that, but were unable to find it. I guess you don't > know either...

Re: [PATCH 1/2 v5 RESEND] usbnet: allow status interrupt URB to always be active

2013-05-01 Thread David Miller
For a patch set that you've submitted 5 times, I'm incredibly surprised how whitespace damaged it is. Do not resubmit these patches until you can email the patches to yourself and successfully apply what you receive. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb

Re: [PATCH v2 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread David Miller
From: Greg KH Date: Thu, 2 May 2013 07:12:39 -0700 > On Fri, May 03, 2013 at 03:48:07AM +0800, Hayes Wang wrote: >> +#define PATENTS "This product is covered by one or more of the >> " \ >> +"following patents:\n" \ >> +"\t\tUS6,570,884, US6,11

Re: [PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread David Miller
From: 'Greg KH' Date: Thu, 2 May 2013 20:23:15 -0700 > On Fri, May 03, 2013 at 11:11:47AM +0800, hayeswang wrote: >> Greg KH [mailto:gre...@linuxfoundation.org] >> > Sent: Friday, May 03, 2013 10:33 AM >> > To: Hayeswang >> > Cc: oli...@neukum.org; net...@vger.kernel.org; >> > linux-ker...@vger

Re: [patch] usbnet: pegasus: endian bug in write_mii_word()

2013-05-03 Thread David Miller
From: Dan Carpenter Date: Fri, 3 May 2013 09:44:20 +0300 > We're only passing the two high bits of an integer. It works for little > endian but not for big endian. > > Signed-off-by: Dan Carpenter s/bits/bytes/, applied, and queued up for stable, thanks -- To unsubscribe from this list: send

Re: [PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-06 Thread David Miller
From: Hayes Wang Date: Fri, 3 May 2013 10:01:25 +0800 > Add new driver for supporting Realtek RTL8152 Based USB 2.0 Ethernet Adapters > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

Re: [PATCH 1/2 v6 RESEND] usbnet: allow status interrupt URB to always be active

2013-05-08 Thread David Miller
From: Dan Williams Date: Mon, 06 May 2013 16:29:23 -0500 > Some drivers (sierra_net) need the status interrupt URB > active even when the device is closed, because they receive > custom indications from firmware. Add functions to refcount > the status interrupt URB submit/kill operation so that

Re: [PATCH 2/2 v6 RESEND] sierra_net: keep status interrupt URB active

2013-05-08 Thread David Miller
From: Dan Williams Date: Mon, 06 May 2013 16:34:56 -0500 > The driver and firmware sync up through SYNC messages, and the > firmware's affirmative reply to these SYNC messages appears to be the > "Reset" indication received via the status interrupt endpoint. Thus the > driver needs the status in

Re: [PATCH Resend 1/2] net/usb: r8152: Remove redundant version.h header inclusion

2013-05-17 Thread David Miller
From: Sachin Kamat Date: Fri, 17 May 2013 09:18:07 +0530 > version.h header inclusion is not necessary as detected by > checkversion.pl. > > Signed-off-by: Sachin Kamat Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.k

Re: [PATCH Resend 2/2] net/usb: r8152: Use module_usb_driver()

2013-05-17 Thread David Miller
From: Sachin Kamat Date: Fri, 17 May 2013 09:18:08 +0530 > module_usb_driver() eliminates boilerplate and simplifies the code. > > Signed-off-by: Sachin Kamat Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] net/usb/r8152: Use module_usb_driver to register driver

2013-05-20 Thread David Miller
From: Peter Huewe Date: Mon, 20 May 2013 22:28:16 +0200 > Removing some boilerplate by using module_usb_driver instead of calling > register and unregister in the otherwise empty init/exit functions. > > Signed-off-by: Peter Huewe This driver has already been converted like this. Please make

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-20 Thread David Miller
From: Libo Chen Date: Tue, 21 May 2013 10:42:00 +0800 > I find a lot of mistakes using struct platform_driver without owner. > So I pick up some of them including usb and net modules Instead of doing it this way, which is obviously error prone and easy to forget, make platform_driver_register()

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread David Miller
From: Thomas Petazzoni Date: Tue, 21 May 2013 08:41:08 +0200 > Dear David Miller, > > On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: >> From: Libo Chen >> Date: Tue, 21 May 2013 10:42:00 +0800 >> >> > I find a lot of mistakes using struct pl

Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface

2013-05-22 Thread David Miller
From: Bjørn Mork Date: Tue, 21 May 2013 15:19:43 +0200 > Schmiedl Christian writes: > >> From: Hans-Christoph Schemmel >> >> Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF >> with >> Cinterion's Vendor ID as well as Product ID and WWAN Interface Number. >> >> Signe

Re: [PATCH v2] net/usb/kalmia: use %*phC to dump small buffers

2013-05-29 Thread David Miller
From: Andy Shevchenko Date: Wed, 29 May 2013 10:22:30 +0300 > Instead of dereferencing pointer and put values on stack we could use nice > %*phC specifier. > > Signed-off-by: Andy Shevchenko Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [GIT PULL] xhci: Regression fix for 3.13.

2013-12-06 Thread David Miller
Sarah, calm down. Let Greg merge the XHCI fix and let's have people test it. The whole holdup is because the USB subsystem is taking forever to merge the XHCI patch. I would have merged it in 24-48 hours if it were my subsystem. :) -- To unsubscribe from this list: send the line "unsubscribe l

Re: [GIT PULL] xhci: Regression fix for 3.13.

2013-12-06 Thread David Miller
From: Greg Kroah-Hartman Date: Fri, 6 Dec 2013 09:29:47 -0800 > On Fri, Dec 06, 2013 at 09:03:25AM -0800, Sarah Sharp wrote: >> On Fri, Dec 06, 2013 at 12:55:23AM -0500, Mark Lord wrote: >> > On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote: >> > > On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sh

Re: [PATCH 1/1] AX88179_178A: Enable the hardware pseudo header in case of the NET_IP_ALIGN equals 0

2013-12-09 Thread David Miller
From: fre...@asix.com.tw Date: Fri, 6 Dec 2013 17:58:18 +0800 > From: Freddy Xin > > The AX88179_178A has a hardware feature that it can insert a 2-bytes pseudo > header in front of each received frame by setting the AX_RX_CTL_IPE bit. > This feature is used to let the IP header be aligned on a

Re: [PATCH 1/1] AX88179_178A: Enable the hardware pseudo header in case of the NET_IP_ALIGN equals 0

2013-12-11 Thread David Miller
From: Freddy Xin Date: Wed, 11 Dec 2013 14:17:59 +0800 > I think there is no way of undoing the reservation in the driver. Then you should add a flag that, indeed, tells usbnet not to do the reservation in the first place. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" i

Re: [PATCH net-next 4/6] r8152: add rtl_ops

2013-12-27 Thread David Miller
From: Hayes Wang Date: Fri, 27 Dec 2013 10:34:08 +0800 > > +static int rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id) ... > > + if (rtl_ops_init(tp, id)) { > + netif_err(tp, probe, netdev, "Unknown Device"); > + return -ENODEV; You're completely i

Re: [PATCH] usbnet: mcs7830: rework link state detection

2013-12-31 Thread David Miller
From: Octavian Purdila Date: Mon, 23 Dec 2013 19:06:31 +0200 > Even with the quirks in commit dabdaf0c (mcs7830: Fix link state > detection) there are still spurious link-down events for some chips > where the false link-down events count go over a few hundreds. > > This patch takes a more conse

Re: [PATCH net-next v2 0/6] support new chip

2014-01-01 Thread David Miller
From: Hayes Wang Date: Thu, 2 Jan 2014 11:22:38 +0800 > Remove the trailing "/* CRC */" for patch #3. > > Change the return value type of rtl_ops_init() from int to boolean > for patch #4. > > Replace VENDOR_ID_SAMSUNG with SAMSUNG_VENDOR_ID for patch #6. Series applied, thank you. -- To unsub

Re: [PATCH net-next] r8152: fix the wrong return value

2014-01-03 Thread David Miller
From: Hayes Wang Date: Fri, 3 Jan 2014 11:21:56 +0800 > The return value should be the boolean value, not the error code. > > Signed-off-by: Hayes Wang > Spotted-by: Dan Carpenter Applied, but I agree with others that it's more canonical to have the function return either an error code, or ze

Re: [PATCH net-next v2 0/3] adjust the code of r8152

2014-01-06 Thread David Miller
From: Hayes Wang Date: Mon, 6 Jan 2014 17:08:40 +0800 > Replace some tabs and modify the return value of rtl_ops_init(). > > v2: add the terminating newline for the message of patch #3. Series applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mess

Re: [PATCH] hso: fix handling of modem port SERIAL_STATE notifications

2014-01-06 Thread David Miller
From: Dan Williams Date: Mon, 06 Jan 2014 10:07:29 -0600 > The existing serial state notification handling expected older Option > devices, having a hardcoded assumption that the Modem port was always > USB interface #2. That isn't true for devices from the past few years. > > hso_serial_state_

Re: [PATCH] hso: fix handling of modem port SERIAL_STATE notifications

2014-01-06 Thread David Miller
From: Dan Williams Date: Mon, 06 Jan 2014 15:39:40 -0600 > If the driver ever gets to that callback for any !Modem port, something > is horribly wrong, which the BUG_ON() was attempting to make explicit. > The driver only enables that callback for the Modem port, so yeah, it's > somewhat defensiv

Re: [PATCH net] r8152: correct some messages

2014-01-06 Thread David Miller
From: Hayes Wang Date: Tue, 7 Jan 2014 11:18:22 +0800 > - Replace pr_warn_ratelimited() with net_ratelimit() and netdev_warn(). > - Adjust the algnment of some messages. > - Remove the peroid. > - Fix some messages don't have terminating newline. > > Signed-off-by: Hayes Wang I only want m

Re: [PATCH net-next 3/3] r8152: add supporting the vendor mode only

2014-01-13 Thread David Miller
From: Hayes Wang Date: Thu, 9 Jan 2014 14:50:32 +0800 > Remove the limitation that the ecm and r8152 drivers couldn't coexist. > Besides, add the feature to support the vendor mode only. This let > someone who doesn't want to use ecm driver easy to use the vendor > driver without creating the ude

Re: [PATCH net-next v2 0/3] r8152: remove limitation

2014-01-14 Thread David Miller
From: Hayes Wang Date: Wed, 15 Jan 2014 10:42:13 +0800 > Remove the limitation between ecm mode and vendor mode. > > v2: replace the patch #3 with "ecm and vendor modes coexist". This looks better, series, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH net,stable] net: qmi_wwan: add Netgear Aircard 340U

2014-02-04 Thread David Miller
From: Bjørn Mork Date: Tue, 4 Feb 2014 13:04:33 +0100 > This device was mentioned in an OpenWRT forum. Seems to have a "standard" > Sierra Wireless ifnumber to function layout: > 0: qcdm > 2: nmea > 3: modem > 8: qmi > 9: storage > > Signed-off-by: Bjørn Mork Applied and queued up for -

Re: [PATCH net] r8152: fix the submission of the interrupt transfer

2014-02-06 Thread David Miller
From: Hayes Wang Date: Thu, 6 Feb 2014 11:55:48 +0800 > The submission of the interrupt transfer should be done after setting > the bit of WORK_ENABLE, otherwise the callback function would have > the opportunity to be returned directly. > > Clear the bit of WORK_ENABLE before killing the interr

Re: [patch] hso: remove some dead code

2014-02-06 Thread David Miller
From: Dan Carpenter Date: Thu, 6 Feb 2014 15:53:19 +0300 > It seems like this function was intended to have special handling for > urb statuses of -ENOENT and -ECONNRESET. But now it just prints some > debugging and returns at the start of the function. > > I have removed the dead code, it's st

Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-02-09 Thread David Miller
From: liujunliang_...@163.com Date: Fri, 7 Feb 2014 14:42:45 +0800 > +MODULE_AUTHOR("Liu Junliang +MODULE_VERSION(DRIVER_VERSION); > +MODULE_DESCRIPTION("SR9800 USB 2.0 USB2NET Dev : > http://www.corechip-sz.com";); > +MODULE_LICENSE("GPL"); > + Please do not add empty lines at the end of file

Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-02-10 Thread David Miller
From: liujunliang_...@163.com Date: Mon, 10 Feb 2014 14:31:42 +0800 > From: Liu Junliang > > > Signed-off-by: Liu Junliang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 21:18:28 -0800 > But is the usage of this semaphore in the class code really a problem? > Has it been seen to cause issues anywhere? Does it show up on any > benchmarks as being something that really needs to be replaced? It's a question of

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 23:00:08 -0800 > I'm very open to potential patches to do this, just don't ignore the > issues that others have run into in the past when attempting this. Fair enough. - To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: USB OOPS 2.6.25-rc2-git1

2008-02-19 Thread David Miller
From: Andre Tomt <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 16:19:08 +0100 > Got this on a serial console today, using 2.6.25-rc2-git1. Machine was > not doing anything interesting at the time, but has its / and kernel on > a usb-storage device (usb pen drive). > > Intel ICH8R chipset (and USB

Re: USB OOPS 2.6.25-rc2-git1

2008-02-19 Thread David Miller
From: David Brownell <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 16:19:54 -0800 > On Tuesday 19 February 2008, David Miller wrote: > > From: Andre Tomt <[EMAIL PROTECTED]> > > Date: Tue, 19 Feb 2008 16:19:08 +0100 > > > > > Got this on a serial console

Re: [PATCH net 0/3] r8152: patches for autosuspend

2014-10-30 Thread David Miller
From: Hayes Wang Date: Wed, 29 Oct 2014 11:12:14 +0800 > There are unexpected processes when enabling autosuspend. > These patches are used to fix them. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.k

Re: [PATCH net-next] r8152: set RTL8152_UNPLUG when finding -ENODEV

2014-10-30 Thread David Miller
From: Hayes Wang Date: Thu, 30 Oct 2014 11:46:40 +0800 > Set RTL8152_UNPLUG when finding -ENODEV. This could accelerate > unloading the driver when the device is unplugged. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bod

Re: [PATCH net] r8152: stop submitting intr for -EPROTO

2014-10-31 Thread David Miller
From: Hayes Wang Date: Fri, 31 Oct 2014 13:35:57 +0800 > For Renesas USB 3.0 host controller, when unplugging the usb hub which > has the RTL8153 plugged, the driver would get -EPROTO for interrupt > transfer. There is high probability to get the information of "HC died; > cleaning up", if the dr

Re: [PATCH net-next v2 2/3] r8152: clear the flag of SCHEDULE_TASKLET in tasklet

2014-10-31 Thread David Miller
From: Hayes Wang Date: Fri, 31 Oct 2014 17:56:41 +0800 > Clear the flag of SCHEDULE_TASKLET in bottom_half() to avoid > re-schedule the tasklet again by workqueue. > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers

Re: [PATCH net-next] r8152: disable the tasklet by default

2014-11-05 Thread David Miller
From: Hayes Wang Date: Wed, 5 Nov 2014 10:17:02 +0800 > Let the tasklet only be enabled after open(), and be disabled for > the other situation. The tasklet is only necessary after open() for > tx/rx, so it could be disabled by default. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsu

Re: [PATCH net-next 0/3] r8152: rtl_ops_init modify

2014-11-06 Thread David Miller
From: Hayes Wang Date: Thu, 6 Nov 2014 12:47:37 +0800 > Initialize the ops through tp->version. This could skip checking > each VID/PID. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] asix: Do full reset during ax88772_bind

2014-11-07 Thread David Miller
From: "Stam, Michel [FINT]" Date: Fri, 7 Nov 2014 09:27:26 +0100 > Please add; > > Tested-by: Michel Stam You're making two critical mistakes here in how you are replying to this patch. First, do not top post. Quote the commit message, then add your Tested-by or other tag afterwards. And m

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-07 Thread David Miller
From: Hayes Wang Date: Fri, 7 Nov 2014 17:55:11 +0800 > Submit all the rx buffers, even though a error occurs. Otherwise > the buffers which are not submitted would be lost until next > rtl_start_rx() is called. Besides, the fail buffer could be > re-submitted later. > > Signed-off-by: Hayes Wan

Re: [PATCH] asix: Do full reset during ax88772_bind

2014-11-07 Thread David Miller
From: Charles Keepax Date: Thu, 6 Nov 2014 15:49:41 + > commit 3cc81d85ee01 ("asix: Don't reset PHY on if_up for ASIX 88772") > causes the ethernet on Arndale to no longer function. This appears to > be because the Arndale ethernet requires a full reset before it will > function correctly, h

Re: [PATCH] usbnet: smsc95xx: dereferencing NULL pointer

2014-11-10 Thread David Miller
From: Sudip Mukherjee Date: Fri, 7 Nov 2014 18:52:40 +0530 > we were dereferencing dev to initialize pdata. but just after that we > have a BUG_ON(!dev). so we were basically dereferencing the pointer > first and then tesing it for NULL. > > Signed-off-by: Sudip Mukherjee You didn't even comp

Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread David Miller
From: Jeff Kirsher Date: Tue, 11 Nov 2014 09:28:24 -0800 > On Tue, 2014-11-11 at 09:26 -0800, Alexander Duyck wrote: >> The Intel drivers were pretty much just using the plain vanilla GFP >> flags >> in their calls to __skb_alloc_page so this change makes it so that >> they use >> dev_alloc_page

Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread David Miller
From: Jeff Kirsher Date: Tue, 11 Nov 2014 09:56:34 -0800 > On Tue, 2014-11-11 at 12:48 -0500, David Miller wrote: >> I think this entire series will need to go via my tree, because the >> conversions are all required for patch #5 which removes the replaced >> interface alt

<    1   2   3   4   5   6   7   8   >