Re: [PATCH net] net: sierra_net: replace whitelist with ifnumber match

2012-08-14 Thread David Miller
From: Bjørn Mork Date: Sun, 12 Aug 2012 21:53:38 +0200 > Signed-off-by: Bjørn Mork Applied to 'net' -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net] net: qmi_wwan: new devices: UML290 and K5006-Z

2012-08-20 Thread David Miller
From: Bjørn Mork Date: Wed, 15 Aug 2012 15:42:57 +0200 > Newer firmware versions for the Pantech UML290 use a different > subclass ID. The Windows driver match on both IDs, so we do > that as well. > > The ZTE (Vodafone) K5006-Z is a new device. > > Cc: Dan Williams > Cc: Thomas Schäfer > Si

Re: [PATCH] net: qmi_wwan: new device: Foxconn/Novatel E396

2012-08-31 Thread David Miller
From: Bjørn Mork Date: Wed, 29 Aug 2012 09:03:34 +0200 > Aleksander Morgado writes: > >> Foxconn-branded Novatel E396, Gobi3k modem. >> >> Cc: Dan Williams >> Cc: Bjørn Mork >> Cc: Ben Chan >> Signed-off-by: Aleksander Morgado ... > If it matters to anyone: > > Acked-by: Bjørn Mork Appl

Re: [PATCH] net: qmi_wwan: add several new Gobi devices

2012-09-01 Thread David Miller
From: Bjørn Mork Date: Sat, 1 Sep 2012 15:47:26 +0200 > Gobi devices are composite, needing both the qcserial and > qmi_wwan drivers to support all functions. Re-syncing the > list of supported devices with qcserial. > > Cc: Aleksander Morgado > Cc: Thomas Tuttle > Signed-off-by: Bjørn Mork

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-03 Thread David Miller
From: Bjørn Mork Date: Mon, 3 Sep 2012 10:26:18 +0200 > Suspending an open usbnet device results in constant > rescheduling of usbnet_bh. > > commit 65841fd5 "usbnet: handle remote wakeup asap" > refactored the usbnet_bh code to allow sharing the > urb allocate and submit code with usbnet_resum

Re: [PATCH net-next] net: cx82310_eth: use common match macro

2012-09-03 Thread David Miller
From: Bjørn Mork Date: Mon, 3 Sep 2012 11:20:31 +0200 > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 1/2] net: sierra_net: make private symbols static

2012-09-03 Thread David Miller
From: Bjørn Mork Date: Mon, 3 Sep 2012 11:20:32 +0200 > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 2/2] net: sierra_net: rx_urb_size is constant

2012-09-03 Thread David Miller
From: Bjørn Mork Date: Mon, 3 Sep 2012 11:20:33 +0200 > The rx_urb_size is set to the same value for every device > supported by this driver. No need to keep a per-device > data structure to do that. Replacing with a macro constant. > > This was the last device specific info, and removing it >

Re: [PATCH 1/10] drivers/net/usb/sierra_net.c: removes unnecessary semicolon

2012-09-07 Thread David Miller
From: Peter Senna Tschudin Date: Thu, 6 Sep 2012 18:09:08 +0200 > From: Peter Senna Tschudin > > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin Applied, thanks. -- To unsubscribe from this list: send the line "unsub

Re: [PATCH net-next 0/2] qmi_wwan changes intended for 3.7

2012-09-07 Thread David Miller
From: Bjørn Mork Date: Fri, 7 Sep 2012 19:36:05 +0200 > Just a couple of minor improvements for 3.7. The QMI > message size issue is not considered important enough for > stable. It does not affect the primary device function > at all, and I consider it more of a feature enhancement > than a f

Re: [PATCH net v2] net: qmi_wwan: call subdriver with control intf only

2012-09-13 Thread David Miller
From: Bjørn Mork Date: Thu, 13 Sep 2012 08:44:35 +0200 > This fixes a hang on suspend due to calling wdm_suspend on > the unregistered data interface. The hang should have been > a NULL pointer reference had it not been for a logic error > in the cdc_wdm code. > > commit 230718bd net: qmi_wwan

Re: [PATCH] qmi_wwan/cdc_ether: let qmi_wwan handle the Huawei E1820

2013-06-11 Thread David Miller
From: Bjørn Mork Date: Thu, 6 Jun 2013 12:57:02 +0200 > Another QMI speaking Qualcomm based device, which should be > driven by qmi_wwan, while cdc_ether should ignore it. ... > Reported-by: Graham Inggs > Signed-off-by: Bjørn Mork Applied, thanks. -- To unsubscribe from this list: send the

Re: [PATCH 2/2 net-next] usbnet: ax88179_178a: add .reset_resume hook

2013-06-28 Thread David Miller
From: David Chang Date: Thu, 27 Jun 2013 17:16:43 +0800 > I tested with the AX88179 usb dongle, if without .reset_resume hook, > after S3/S4 resume you have to enable network interface or reload the > dirver module manually otherwise the network interface can not work. > > Signed-off-by: David C

Re: [PATCH 1/2 net-next] usbnet: ax88179_178a: Correct a typo in description

2013-06-28 Thread David Miller
From: David Chang Date: Thu, 27 Jun 2013 17:16:42 +0800 > > Correct a typo in description of driver_info, it should be Gigabit > > Signed-off-by: David Chang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 3/3] net: qmi_wwan: add TP-LINK MA260

2013-07-01 Thread David Miller
From: Bjørn Mork Date: Fri, 28 Jun 2013 17:17:51 +0200 > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] net: qmi_wwan: fixup Sierra Wireless MC8305 entry

2013-07-01 Thread David Miller
From: Bjørn Mork Date: Fri, 28 Jun 2013 17:17:49 +0200 > The MC8305 module got an additional entry added based solely on > information from a Windows driver *.inf file. We now have the > actual descriptor layout from one of these modules, and it > consists of two alternate configurations where cf

Re: [PATCH 2/3] net: qmi_wwan: add Option GTM681W

2013-07-01 Thread David Miller
From: Bjørn Mork Date: Fri, 28 Jun 2013 17:17:50 +0200 > A standard Gobi 3000 reference design module. > > Reported-by: Richard Weinberger > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ke

Re: [PATCH v2] net: cdc_ether: allow combined control and data interface

2013-07-01 Thread David Miller
From: Bjørn Mork Date: Sat, 29 Jun 2013 12:03:06 +0200 > Some Icera based Huawei modems handled by this driver are not > completely CDC ECM compliant, using the same USB interface for both > control and data. The CDC functional descriptors include a Union > naming this interface as both master an

Re: [PATCH V2] qmi_wwan: add ONDA MT689DC device ID (fwd)

2013-07-01 Thread David Miller
From: Bjørn Mork Date: Sat, 29 Jun 2013 16:01:04 +0200 > Enrico Mioso writes: > >> Another QMI-speaking device by ZTE, re-branded by ONDA! >> >> I'm connected ovr this device's QMI interface right now, so I can say I >> tested >> it! :) >> >> Note: a follow-up patch was posted to the linux-usb

Re: [PATCH] net: ipheth: Add USB ID for iPad mini

2013-07-02 Thread David Miller
From: Aaron Marburg Date: Tue, 2 Jul 2013 10:00:06 +1200 > Adds the USB device ID (0x12ab) to the ipheth network-over-USB-tethering > driver for iOS devices. Applied and tested against mainline tag v3.10 > (as well as 3.8.x and 3.6.y kernel for Raspbian on Raspberry pi) > > > Signed-off-by: Aa

Re: [PATCH v2] net: cdc_ether: allow combined control and data interface

2013-07-02 Thread David Miller
From: Oliver Neukum Date: Tue, 02 Jul 2013 10:17:51 +0200 > On Saturday 29 June 2013 12:03:06 Bjørn Mork wrote: >> Some Icera based Huawei modems handled by this driver are not >> completely CDC ECM compliant, using the same USB interface for both >> control and data. The CDC functional descripto

Re: [PATCH net-next] net/usb: add relative mii functions for r815x

2013-07-11 Thread David Miller
From: Hayes Wang Date: Mon, 8 Jul 2013 10:41:21 +0800 > Base on cdc_ether, add the mii functions for RTL8152 and RTL8153. > The RTL8152 and RTL8153 support ECM mode which use the driver of > cdc_ether. Add the mii functions. Then, the basic PHY access is > possible. > > Signed-off-by: Hayes Wang

Re: [PATCH net 1/2] usb/net/r8152: fix integer overflow in expression

2013-07-12 Thread David Miller
From: Hayes Wang Date: Fri, 12 Jul 2013 16:26:15 +0800 > config: make ARCH=avr32 allyesconfig > drivers/net/usb/r8152.c: In function 'rtl8152_start_xmit': > drivers/net/usb/r8152.c:956: warning: integer overflow in expression > >955memset(tx_desc, 0, sizeof(*tx_desc)); > > 956

Re: [PATCH net 2/2] usb/net/r815x: fix cast to restricted __le32

2013-07-12 Thread David Miller
From: Hayes Wang Date: Fri, 12 Jul 2013 16:26:16 +0800 >>> drivers/net/usb/r815x.c:38:16: sparse: cast to restricted __le32 >>> drivers/net/usb/r815x.c:67:15: sparse: cast to restricted __le32 >>> drivers/net/usb/r815x.c:69:13: sparse: incorrect type in assignment >>> (different base types) >

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-23 Thread David Miller
From: Eric Dumazet Date: Mon, 22 Jul 2013 23:10:27 -0700 > On Mon, 2013-07-22 at 20:47 +0100, Ben Hutchings wrote: >> The real solution would be for someone to add SG support to the usbnet >> core. Trying to support 1GbE with only linear skbs is not a great >> idea... and it can only be a matter

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-23 Thread David Miller
From: Eric Dumazet Date: Tue, 23 Jul 2013 17:05:10 -0700 > On Tue, 2013-07-23 at 16:56 -0700, Eric Dumazet wrote: > >> > A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have >> > this problem. >> > >> > Instead of the patch starting this thread, I'd like to see one that >> > hi

Re: [PATCH 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-24 Thread David Miller
From: hayeswang Date: Tue, 23 Jul 2013 17:26:04 +0800 > diff --git a/drivers/net/usb/r815x.c b/drivers/net/usb/r815x.c > index 8523922..e9b99ba 100644 > --- a/drivers/net/usb/r815x.c > +++ b/drivers/net/usb/r815x.c > @@ -24,34 +24,43 @@ > > static int pla_read_word(struct usb_device *udev, u16

Re: [PATCH] usbnet: do not pretend to support SG/TSO

2013-07-26 Thread David Miller
From: Eric Dumazet Date: Tue, 23 Jul 2013 17:15:54 -0700 > From: Eric Dumazet > > usbnet doesn't support yet SG, so drivers should not advertise SG or TSO > capabilities, as they allow TCP stack to build large TSO packets that > need to be linearized and might use order-5 pages. > > This adds

Re: [PATCH 0/2] USBNET: max rx/tx qlen change

2013-07-27 Thread David Miller
From: Ming Lei Date: Thu, 25 Jul 2013 13:47:52 +0800 > There are two patches on computing max rx/tx qlen, and fix one > performance problem on USB3 NIC. Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-27 Thread David Miller
From: Hayes Wang Date: Thu, 25 Jul 2013 15:59:02 +0800 > Some USB buffers use stack which may not be DMA-able. > Use the buffers from kmalloc to replace those one. > > Signed-off-by: Hayes Wang I don't think it's reasonable to kmalloc() a small integer every time you want to use a USB message

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-29 Thread David Miller
From: Oliver Neukum Date: Mon, 29 Jul 2013 07:20:24 +0200 > On Sat, 2013-07-27 at 20:21 -0700, David Miller wrote: >> From: Hayes Wang >> Date: Thu, 25 Jul 2013 15:59:02 +0800 >> >> > Some USB buffers use stack which may not be DMA-able. >> > Use the bu

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread David Miller
From: Greg KH Date: Tue, 30 Jul 2013 07:00:59 -0700 > This call is so slow, you can afford to make a call to kmalloc for the > data, as it sure just did for other structures it needed :) I told him to implement things this way, to avoid calling kmalloc every single register access. Using kmallo

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread David Miller
From: Joe Perches Date: Tue, 30 Jul 2013 11:41:17 -0700 > On Tue, 2013-07-30 at 11:33 -0700, David Miller wrote: >> From: Greg KH >> Date: Tue, 30 Jul 2013 07:00:59 -0700 >> >> > This call is so slow, you can afford to make a call to kmalloc for the >> &

Re: [PATCH v4 3/5] net/usb/r815x: change the return value for bind functions

2013-07-31 Thread David Miller
From: Hayes Wang Date: Wed, 31 Jul 2013 17:21:24 +0800 > Replace 0 with the result from usbnet_cdc_bind(). > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v4 4/5] net/usb/r8152: make sure the USB buffer is DMA-able

2013-07-31 Thread David Miller
From: Hayes Wang Date: Wed, 31 Jul 2013 17:21:25 +0800 > Allocate the required memory before calling usb_control_msg. And > the additional memory copy is necessary. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a m

Re: [PATCH v4 5/5] net/usb/r8152: adjust relative ocp function

2013-07-31 Thread David Miller
From: Hayes Wang Date: Wed, 31 Jul 2013 17:21:26 +0800 > - fix the conversion between cpu and __le32 > - replace some pla_ocp and usb_ocp functions with generic_ocp function > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: [PATCH v4 2/5] net/usb/r815x: avoid to call mdio functions for runtime-suspended device

2013-07-31 Thread David Miller
From: Hayes Wang Date: Wed, 31 Jul 2013 17:21:23 +0800 > Don't replace the usb_control_msg() with usbnet_{read,write}_cmd() > which couldn't be called inside suspend/resume callback. Keep the > basic functions unlimited. Instead, using usb_autopm_get_interface() > and usb_autopm_put_interface() i

Re: [PATCH v4 1/5] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-31 Thread David Miller
From: Hayes Wang Date: Wed, 31 Jul 2013 17:21:22 +0800 > Some USB buffers use stack which may not be DMA-able. > Use the buffers from kmalloc to replace those one. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a me

Re: [PATCH V3 0/3] networking: Use ETH_ALEN where appropriate

2013-08-02 Thread David Miller
From: Joe Perches Date: Thu, 1 Aug 2013 16:17:46 -0700 > Convert the uses mac addresses to ETH_ALEN so > it's easier to find and verify where mac addresses > need to be __aligned(2) Series applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in th

Re: [PATCH v1 3/4] USBNET: support DMA SG

2013-08-03 Thread David Miller
From: Oliver Neukum Date: Sat, 03 Aug 2013 07:56:53 +0200 > On Sat, 2013-08-03 at 10:46 +0800, Ming Lei wrote: > >> @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, >> entry = (struct skb_data *) skb->cb; >> entry->urb = urb; >> entry->dev = dev; >> -

Re: [PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-03 Thread David Miller
From: Eric Dumazet Date: Thu, 01 Aug 2013 06:52:45 -0700 > On Thu, 2013-08-01 at 06:49 -0700, Eric Dumazet wrote: >> From: Eric Dumazet >> >> ax88179_tx_fixup() has quite complex code trying to push 8 bytes >> of control data (len/mss), but fails to do it properly for TCP packets, >> incurring

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread David Miller
From: Eric Dumazet Date: Fri, 09 Aug 2013 10:50:36 -0700 > Some compiler folk decided 'extern' were not mandatory for code, but its > really adding confusion and endless discussions. I certainly stopped talking about it, you could too :-) -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 1/2] net/usb: catc: allocate URB setup_packet as separate buffer

2013-08-09 Thread David Miller
From: Jussi Kivilinna Date: Wed, 07 Aug 2013 16:26:29 +0300 > URB setup packet must not be allocated as part of larger structure > because DMA coherence issues. > > Patch changes catc to allocate ctrl_dr member as separate buffer. > > Patch is only compile tested. > > Cc: > Signed-off-by: Jus

Re: [PATCH v4 0/4] USB & USBNET: loose SG check and support usbnet DMA SG

2013-08-09 Thread David Miller
From: Ming Lei Date: Thu, 8 Aug 2013 21:48:21 +0800 > This patchset allows drivers to pass sg buffers which size can't be divided > by max packet size of endpoint if the host controllers(such ax xHCI) support > this kind of sg buffers. > > Previously we added check[1] on the situation and don't

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-13 Thread David Miller
From: Mark Brown Date: Fri, 9 Aug 2013 18:31:22 +0100 > From: Mark Brown > > Ensure that the definition of ax88172a_info matches the declaration seen > by users and silence sparse warnings about symbols without declarations > in the global namespace by moving the declaration into the shared he

Re: [PATCH 1/2] net: asix: Staticise non-exported symbols

2013-08-13 Thread David Miller
From: Mark Brown Date: Fri, 9 Aug 2013 18:31:21 +0100 > From: Mark Brown > > Make functions that are only referenced from ops structures static, they > do not need to be in the global namespace and sparse complains about this. > > Signed-off-by: Mark Brown Applied. -- To unsubscribe from th

Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation

2013-08-13 Thread David Miller
From: Oliver Neukum Date: Tue, 13 Aug 2013 17:17:10 +0200 > On Tue, 2013-08-13 at 20:32 +0800, hayeswang wrote: >> Oliver Neukum [mailto:oneu...@suse.de] >> > Sent: Tuesday, August 13, 2013 4:49 PM >> > To: Hayeswang >> > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; >> > linux-usb

Re: [PATCH net-next v2 2/3] net/usb/r8152: enable tx checksum

2013-08-15 Thread David Miller
From: Hayes Wang Date: Wed, 14 Aug 2013 20:54:39 +0800 > Enable tx checksum. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH net-next v2 3/3] net/usb/r8152: enable interrupt transfer

2013-08-15 Thread David Miller
From: Hayes Wang Date: Wed, 14 Aug 2013 20:54:40 +0800 > Use the interrupt transfer to replace polling link status. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread David Miller
From: Hayes Wang Date: Wed, 14 Aug 2013 20:54:38 +0800 > Enable the tx/rx aggregation which could contain one or more packets > for each bulk in/out. This could reduce the loading of the host > controller by sending less bulk transfer. > > The rx packets in the bulk in buffer should be 8-byte al

Re: [PATCH net-next 1/7] r8152: remove clearing the memory to zero for netdev priv

2013-08-20 Thread David Miller
Series applied, thanks. Please, in the future, provide an initial "[PATCH 0/N] " posting which gives a general overview to the series, and to which I can apply when I have something to say about the series as a whole. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb

Re: [PATCH] Fix stack corruption on some architectures

2013-08-20 Thread David Miller
Please submit this with a more appropriate subject line. After '[PATCH] ' there should be a subsystem or driver name prefix, followed up a semicolon. Here it could be "hso: ", so something like: [PATCH] hso: Fix stack corruption on some architectures. -- To unsubscribe from this list: send the

Re: [PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread David Miller
From: Greg KH Date: Wed, 21 Aug 2013 09:25:07 -0700 > On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote: >> There is no need to get an interface specification if we know it's the >> wrong one. >> >> Signed-off-by: Daniel Gimpelevich > > Acked-by: Greg Kroah-Hartman Applied.

Re: [PATCH 2/2] hso: Fix stack corruption on some architectures

2013-08-21 Thread David Miller
From: Greg KH Date: Wed, 21 Aug 2013 09:24:47 -0700 > On Wed, Aug 21, 2013 at 01:43:19AM -0700, Daniel Gimpelevich wrote: >> As Sergei Shtylyov explained in the #mipslinux IRC channel: >> [Mon 2013-08-19 12:28:21 PM PDT] guys, are you sure it's not "DMA >> off stack" case? >> [Mon 2013-08-19 1

Re: [PATCH 2/2] fs: use inode_set_user to set uid/gid of inode

2013-08-22 Thread David Miller
From: Rui Xiang Date: Fri, 23 Aug 2013 10:48:38 +0800 > Use the new interface to set i_uid/i_gid in inode struct. > > Signed-off-by: Rui Xiang For the networking bits: Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message t

Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-26 Thread David Miller
From: Enrico Mioso Date: Fri, 23 Aug 2013 09:56:29 +0200 > + if ((on && atomic_add_return(1, &drvstate->pmcount) == 1) || (!on && > atomic_dec_and_test(&drvstate->pmcount))) { These line significantly exceeds 80 columns. > + subdriver = usb_cdc_wdm_register(ctx->control, > +

Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-26 Thread David Miller
From: Joe Perches Date: Mon, 26 Aug 2013 13:45:13 -0700 > I think the premise of local variable > declaration by line length is flawed. I disagree. > It can't work when local variables are > dependent on initialization order as > above. Move the initialization below the declarations. -- To uns

Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-26 Thread David Miller
From: Joe Perches Date: Mon, 26 Aug 2013 14:05:55 -0700 > On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote: >> From: Joe Perches >> Date: Mon, 26 Aug 2013 13:45:13 -0700 >> >> > I think the premise of local variable >> > declaration by line length is

Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700 Device Driver Support

2013-08-28 Thread David Miller
From: liujunliang_...@163.com Date: Sat, 24 Aug 2013 19:26:00 +0800 > From: liujl Your proper name is not "liujl", please put something more reasonable here and also in your Signoff. Also, integrate Joe Perches's white space fixes into this patch as part of your resubmission. Thank you. -- To

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner Date: Sun, 25 Aug 2013 18:29:13 -0600 > From 018343ce2e679d97283fb51da25c43aa876d087a Mon Sep 17 00:00:00 2001 > From: Rob Gardner > Date: Sun, 25 Aug 2013 16:02:23 -0600 > Subject: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception > table > > This patch adds

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner Date: Wed, 28 Aug 2013 17:18:12 -0600 > Bjørn says it could have a minor performance impact, but should not > cause any loss of functionality. I don't think there's any hard data on > what the performance cost might be but I know he would eventually like > to get rid of the exce

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner Date: Wed, 28 Aug 2013 18:40:22 -0600 > The exception list means "usb_device_id entries for specific devices > that are known to need the workaround." There are just two such entries. > There isn't even a separate list. So maybe we just have a nomenclature > problem, and we coul

Re: [PATCH] net: usbnet: update addr_assign_type if appropriate

2013-08-30 Thread David Miller
From: Bjørn Mork Date: Fri, 30 Aug 2013 20:18:58 +0200 > Bjørn Mork writes: > >> This module generates a common default address on init, >> using eth_random_addr. Set addr_assign_type to let >> userspace know the address is random unless it was >> overridden by the minidriver. >> >> Signed-off-

Re: [PATCH] net: usbnet: update addr_assign_type if appropriate

2013-08-30 Thread David Miller
From: Bjørn Mork Date: Fri, 30 Aug 2013 20:56:15 +0200 > David Miller writes: >> From: Bjørn Mork >> Date: Fri, 30 Aug 2013 20:18:58 +0200 >> >>> Bjørn Mork writes: >>> >>>> This module generates a common default address on init, >

Re: [PATCH] USB2NET : SR9700 : One Chip USB 1.1 USB2NET SR9700 Device Driver Support

2013-08-30 Thread David Miller
Please integrate the fixes Francois has proposed. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support

2013-09-03 Thread David Miller
From: liujunliang_...@163.com Date: Sun, 1 Sep 2013 19:38:08 +0800 > From: Liu Junliang > > Signed-off-by: Liu Junliang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [PATCH RESEND net-next] net: usbnet: update addr_assign_type if appropriate

2013-09-05 Thread David Miller
From: Bjørn Mork Date: Wed, 4 Sep 2013 09:42:32 +0200 > This module generates a common default address on init, > using eth_random_addr. Set addr_assign_type to let > userspace know the address is random unless it was > overridden by the minidriver. > > Signed-off-by: Bjørn Mork > Acked-by: Ol

Re: [PATCH] net: qmi_wwan: add new Qualcomm devices

2013-09-11 Thread David Miller
From: Bjørn Mork Date: Tue, 10 Sep 2013 15:06:20 +0200 > Adding the device list from the Windows driver description files > included with a new Qualcomm MDM9615 based device, "Alcatel-sbell > ASB TL131 TDD LTE", from China Mobile. This device is tested > and verified to work. The others are ass

Re: [PATCH 0/3] net: usb: cdc_ether: improve telit support and code cleanups

2013-09-16 Thread David Miller
From: Fabio Porcedda Date: Mon, 16 Sep 2013 11:47:49 +0200 > Some patches to improve telit modules support and to cleanup the code. Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH] USBNET: fix handling padding packet

2013-09-17 Thread David Miller
From: Ming Lei Date: Tue, 17 Sep 2013 17:10:02 +0800 > Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG > if the usb host controller is capable of building packet from > discontinuous buffers, but missed handling padding packet when > building DMA SG. > > This patch attachs the pre

Re: [PATCH] USBNET: fix handling padding packet

2013-09-18 Thread David Miller
From: Bjørn Mork Date: Wed, 18 Sep 2013 17:52:42 +0200 > Ming Lei writes: > >> There is no reason to forbid DMA SG for one driver which requires >> padding, right? > > Yes there is: Added complexity for everybody, based on a combination of > features which just does not make any sense. > > No

Re: [PATCH v1] USBNET: fix handling padding packet

2013-09-28 Thread David Miller
From: Ming Lei Date: Mon, 23 Sep 2013 20:59:35 +0800 > Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG > if the usb host controller is capable of building packet from > discontinuous buffers, but missed handling padding packet when > building DMA SG. > > This patch attachs the pre

Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

2013-09-30 Thread David Miller
From: Bjørn Mork Date: Wed, 25 Sep 2013 15:31:39 +0200 > Sorry, I really don't see the point of this. Yes, the lines are longer > than 80 columns, but breaking them don't improve the readability at > all. On the contrary, IMHO. > > So NAK from me for this part. Sorry, breaking things up like

Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

2013-09-30 Thread David Miller
From: Fabio Porcedda Date: Wed, 25 Sep 2013 11:21:26 +0200 > Signed-off-by: Fabio Porcedda Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH 1/2] net: qmi_wwan: add Telit LE920 newer firmware support

2013-09-30 Thread David Miller
From: Fabio Porcedda Date: Wed, 25 Sep 2013 11:21:25 +0200 > Newer firmware use a new pid and a different interface. > > Signed-off-by: Fabio Porcedda Applied to net-next -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.o

Re: [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID

2013-09-30 Thread David Miller
From: Schmiedl Christian Date: Thu, 26 Sep 2013 16:02:13 +0200 > Aleksander Morgado writes: > >> Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1. >> >> The blacklisting in the serial/option driver does actually use the >> correct PID, as per commit 8ff10bdb14a52e3f25d4ce09e0582a

Re: [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN

2013-10-02 Thread David Miller
From: Joe Perches Date: Tue, 01 Oct 2013 19:04:40 -0700 > Convert the memset/memcpy uses of 6 to ETH_ALEN > where appropriate. > > Also convert some struct definitions and u8 array > declarations of [6] to ETH_ALEN. > > Signed-off-by: Joe Perches Looks fine, applied, thanks Joe. -- To unsubsc

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-10-03 Thread David Miller
From: "Dr. H. Nikolaus Schaller" Date: Wed, 2 Oct 2013 09:00:18 +0200 > From f5c7e15b61f2ce4fe3105ff914f6bfaf5d74af0d Mon Sep 17 00:00:00 2001 > From: "H. Nikolaus Schaller" > Date: Thu, 15 Nov 2012 14:40:57 +0100 > Subject: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION > G

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-10-03 Thread David Miller
From: "Dr. H. Nikolaus Schaller" Date: Thu, 3 Oct 2013 21:40:34 +0200 > I have made the bug observation from debug log that this bit is set in a > response > each time the modem has a RING message. It might be specific to this modem > and firmware version, i.e. a firmware bug. But we have no mea

Re: [PATCH] usbnet: fix error return code in usbnet_probe()

2013-10-17 Thread David Miller
From: Wei Yongjun Date: Sat, 12 Oct 2013 14:24:08 +0800 > From: Wei Yongjun > > Fix to return -ENOMEM in the padding pkt alloc fail error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Applied, thanks Wei. -- To unsubscribe from this list: se

Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

2013-10-17 Thread David Miller
From: Enrico Mioso Date: Tue, 15 Oct 2013 15:06:48 +0200 > This is a QMI device, manufactured by TCT Mobile Phones. > A companion patch blacklisting this device's QMI interface in the option.c > driver has been sent. > > Signed-off-by: Enrico Mioso > Signed-off-by: Antonella Pellizzari Applie

Re: [PATCH 1/1] [PATCH] ax88179_178a: Correct the RX error definition in RX header

2013-10-21 Thread David Miller
From: fre...@asix.com.tw Date: Mon, 21 Oct 2013 14:37:40 +0800 > From: Freddy Xin > > Correct the definition of AX_RXHDR_CRC_ERR and > AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr > seperately. > Add VID:DID for Samsung USB Ethernet Adapter. > > Signed-off-by: Freddy Xin Do not do t

Re: [PATCH 1/1] [PATCH resubmit] ax88179_178a: Correct the RX error definition in RX header

2013-10-21 Thread David Miller
Submit these, not individually as single patches, but as a patch set, the first one with subject "[PATCH 1/2]" and the second with subject "[PATCH 2/2]" You have to do this, because it is absolutely essentially to let me know which patch gets applies first and which one gets applied second. The

Re: [PATCH 1/2] [PATCH] ax88179_178a: Correct the RX error definition in RX header

2013-10-22 Thread David Miller
From: fre...@asix.com.tw Date: Tue, 22 Oct 2013 15:32:10 +0800 > From: Freddy Xin > > Correct the definition of AX_RXHDR_CRC_ERR and > AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr > seperately. > > Signed-off-by: Freddy Xin Applied. -- To unsubscribe from this list: send the line "u

Re: [PATCH 2/2] [PATCH] ax88179_178a: Add VID:DID for Samsung USB Ethernet Adapter

2013-10-22 Thread David Miller
From: fre...@asix.com.tw Date: Tue, 22 Oct 2013 15:32:11 +0800 > From: Freddy Xin > > Add VID:DID for Samsung USB Ethernet Adapter. > > Signed-off-by: Freddy Xin Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: [PATCH 1/1] ax88179_178a: Remove AX_MEDIUM_ALWAYS_ONE bit in AX_MEDIUM_STATUS_MODE register to avoid TX throttling

2013-10-25 Thread David Miller
From: fre...@asix.com.tw Date: Thu, 24 Oct 2013 14:58:25 +0800 > From: Freddy Xin > > Remove AX_MEDIUM_ALWAYS_ONE in AX_MEDIUM_STATUS_MODE register. > Setting this bit may cause TX throttling in Half-Duplex mode. > > Signed-off-by: Freddy Xin Applied. -- To unsubscribe from this list: send th

Re: [PATCH 0/5] r8152 bug fixes

2013-10-28 Thread David Miller
From: Hayes Wang Date: Mon, 28 Oct 2013 19:58:09 +0800 > These could fix some driver issues. > > Hayes Wang (5): > net/usb/r8152: fix tx/rx memory overflow > net/usb/r8152: make sure the tx checksum setting is correct > net/usb/r8152: modify the tx flow > net/usb/r8152: fix incorrect typ

Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
From: Hayes Wang Date: Tue, 29 Oct 2013 15:56:16 +0800 > Support stopping and waking tx queue. The maximum tx queue length > is 60. What is so special about the number 60? It seems arbitrary, and if it isn't arbitrary you haven't described why this value was choosen. I've asked you politely la

Re: [PATCH] net/cdc_ncm: fix null pointer panic at usbnet_link_change

2013-10-29 Thread David Miller
From: "Du, ChangbinX" Date: Tue, 29 Oct 2013 03:30:42 + > In cdc_ncm_bind() function, it call cdc_ncm_bind_common() to setup usb. > But cdc_ncm_bind_common() may meet error and cause usbnet_disconnect() > be called which calls free_netdev(net). Thus usbnet structure(alloced > with net_device

Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
From: hayeswang Date: Wed, 30 Oct 2013 11:03:55 +0800 > David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, October 30, 2013 5:50 AM >> To: Hayeswang >> Cc: net...@vger.kernel.org; nic_swsd; >> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org >

Re: [PATCH net v2 2/3] r8152: modify the tx flow

2013-10-30 Thread David Miller
From: Hayes Wang Date: Wed, 30 Oct 2013 15:13:39 +0800 > Remove the code for sending the packet in the rtl8152_start_xmit(). > Let rtl8152_start_xmit() to queue the packet only, and schedule a > tasklet to send the queued packets. This simplify the code and make > sure all the packet would be sen

Re: [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes

2013-11-01 Thread David Miller
From: Bjørn Mork Date: Fri, 1 Nov 2013 11:16:37 +0100 > This series ended up longer than expected, and it is still not > complete. There is more to come when time allows... > > Most changes are trivial. Notable non-trivial changes are > - removed filtering of identical speed notifications > -

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-04 Thread David Miller
From: Govindarajulu Varadarajan Date: Sat, 2 Nov 2013 19:17:43 +0530 > @@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int > csr0) > } > > #ifdef XMT_VIA_SKB > - if(p->tmd_skb[p->tmdlast]) { > - dev_kfree_skb_irq(p->tmd_

Re: [PATCH net-next 0/5] cdc_mbim + qmi_wwan trivial fixes

2013-11-04 Thread David Miller
From: Bjørn Mork Date: Fri, 1 Nov 2013 14:18:51 +0100 > This series fixes three problems Oliver pointed out during the > review of the new huawei_cdc_ncm driver: > http://patchwork.ozlabs.org/patch/278903/ > > That innocent driver only used cdc_mbim as a blueprint, and > all the blame should re

Re: [PATCH net v2 2/3] r8152: modify the tx flow

2013-11-04 Thread David Miller
From: hayeswang Date: Thu, 31 Oct 2013 13:52:38 +0800 > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, October 31, 2013 5:05 AM >> >> From: Hayes Wang >> Date: Wed, 30 Oct 2013 15:13:39 +0800 > [...] >> Basically, your driver will now queue

Re: [PATCH net-next v6 0/3] The huawei_cdc_ncm driver

2013-11-05 Thread David Miller
From: Bjørn Mork Date: Mon, 4 Nov 2013 09:50:46 +0100 > Enrico has been kind enough to let me repost his driver with the changes > requested by Oliver Neukum during the last review of this series. > > The changes I have made from Enricos original v5 series to this version > are: > > v6: > - f

Re: [PATCH] usbnet: fix status interrupt urb handling

2013-11-13 Thread David Miller
From: Felix Fietkau Date: Tue, 12 Nov 2013 16:34:41 +0100 > Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf > "sierra_net: keep status interrupt URB active", sierra_net triggers > status interrupt polling before the net_device is opened (in order to > properly receive the sync message respo

Re: [PATCH] net: cdc_ncm: cleanup a type issue in cdc_ncm_setup()

2013-11-14 Thread David Miller
From: Dan Carpenter Date: Wed, 13 Nov 2013 10:42:34 +0300 > This is harmless but cdc_ncm_setup() returns negative error codes > truncated to u8 values. There is only one caller and treats all > non-zero returns as errors but doesn't store the the return code. So > the code works correctly but i

Re: [PATCH net v3 1/4] r8152: fix tx/rx memory overflow

2013-11-15 Thread David Miller
From: Hayes Wang Date: Fri, 15 Nov 2013 15:57:56 +0800 > + unsigned pkt_len; Please fully specify the type as "unsigned int". Please check for this problem in the rest of your patches too. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in th

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-18 Thread David Miller
From: Govindarajulu Varadarajan Date: Tue, 19 Nov 2013 00:56:48 +0530 (IST) > Did you have a chance to look at this? Let me know how you want me to > fix this. I said clearly that I don't want this change to be made, because in many cases the "= NULL" assignment in the driver is desirable to eli

<    1   2   3   4   5   6   7   8   >