Re: [PATCH] rndis_host: Set random MAC for ZTE MF910

2016-07-16 Thread David Miller
From: Bjørn Mork Date: Fri, 15 Jul 2016 19:42:28 +0200 > David Laight writes: >> From: Bjørn Mork >> Not only that, there certainly used to be manufacturers that used 'locally >> administered' addresses on all their cards (as well as those that used >> unallocated >> address blocks). > > Sure.

Re: [PATCH] net: usb: ax88172x: use phy_ethtool_{get|set}_link_ksettings

2016-07-16 Thread David Miller
From: Philippe Reynes Date: Fri, 15 Jul 2016 15:25:36 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied. -- To unsubscribe from this list: send the line

Re: [PATCH net-next v3] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-20 Thread David Miller
From: Kristian Evensen Date: Tue, 19 Jul 2016 16:54:11 +0200 > The firmware in several ZTE devices (at least the MF823/831/910 > modems/mifis) use OS fingerprinting to determine which type of device to > export. In addition, these devices export a REST API which can be used to > control the type

Re: [PATCH net-next v4] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-24 Thread David Miller
nd MAC addresses. > > This patch tries to improve the handling of ZTE devices by doing the > following: ... > v3->v4: > * Forgot to remove unused variables, sorry about that (thanks David > Miller). Applied, thanks. -- To unsubscribe from this list: send the lin

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread David Miller
Please correct the problems Grant Grundler mentioned in all of these patches, and resubmit this entire series freshly. Also, please include a proper "[PATCH 0/3] ..." introduction posting for the series which explains what this series is about, how it implements what it is doing, and why it is do

Re: [PATCH 00/16] net: don't print error when allocating urb fails

2016-08-14 Thread David Miller
From: Wolfram Sang Date: Thu, 11 Aug 2016 23:05:19 +0200 > This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses > kmalloc which already prints enough information on failure. So, let's simply > remove those "allocation failed" messages from drivers like we did already for

Re: [PATCH v2 0/2]fixes to kaweth in response to Umap2 testing

2016-08-18 Thread David Miller
From: Oliver Neukum Date: Wed, 17 Aug 2016 15:51:54 +0200 > These patches fix an oops in firmware downloading and an oops due > to a memory allocation failure Series applied, thanks Oliver. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord

Re: [PATCH 4/5] r8152: constify ethtool_ops structures

2016-08-31 Thread David Miller
From: Julia Lawall Date: Thu, 1 Sep 2016 00:21:22 +0200 > Check for ethtool_ops structures that are only stored in the ethtool_ops > field of a net_device structure or passed as the second argument to > netdev_set_default_ethtool_ops. These contexts are declared const, so > ethtool_ops structur

Re: [PATCH v3 0/5] net/usb: asix driver improvements

2016-08-31 Thread David Miller
From: robert.f...@collabora.com Date: Mon, 29 Aug 2016 09:32:14 -0400 > This is a resubmission of v3, since the netdev > mailinlist was not sent the previous submission. > > This series improves power management of the asix driver. ... Series applied, thanks. -- To unsubscribe from this list: s

Re: [PATCH net-next] r8152: fix the coding style with checkpatch.pl

2016-09-01 Thread David Miller
From: Hayes Wang Date: Thu, 1 Sep 2016 17:01:42 +0800 > check the coding style with checkpatch.pl and fix the warnings and errors. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.or

Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue

2016-09-01 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 30 Aug 2016 22:02:47 +0530 > The workqueue "pegasus_workqueue" queues a single work item per pegasus > instance and hence it doesn't require execution ordering. Hence, > alloc_workqueue has been used to replace the deprecated > create_singlethread_workqueue i

Re: [PATCH 0/2] hso: neatening

2016-09-06 Thread David Miller
From: Joe Perches Date: Fri, 2 Sep 2016 15:58:00 -0700 > This seems to be the only code in the kernel that uses > macro defines with a trailing underscore. Fix that. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: [PATCH] lan78xx: mark symbols static where possible

2016-09-06 Thread David Miller
From: Baoyou Xie Date: Tue, 6 Sep 2016 16:19:02 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/usb/lan78xx.c:1182:6: warning: no previous prototype for > 'lan78xx_defer_kevent' [-Wmissing-prototypes] > drivers/net/usb/lan78xx.c:1409:5: warning: no previous prototype

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-07 Thread David Miller
From: Hayes Wang Date: Wed, 7 Sep 2016 16:12:19 +0800 > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB > configuration value which they want. The default is to support vendor mode > only.

Re: [PATCH net,stable] qmi_wwan: add Sierra Wireless EM74xx device ID

2016-03-03 Thread David Miller
From: Bjørn Mork Date: Tue, 1 Mar 2016 14:31:02 +0100 > The MC74xx and EM74xx modules use different IDs by default, according > to the Lenovo EM7455 driver for Windows. > > Signed-off-by: Bjørn Mork Applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] asix: do not free array priv->mdio->irq

2016-03-06 Thread David Miller
From: Colin King Date: Thu, 3 Mar 2016 13:27:56 + > From: Colin Ian King > > Used to be allocated and required freeing, but now > priv->mdio->irq is now a fixed sized array and should no longer be > free'd. > > Issue detected using static analysis with CoverityScan > > Fixes: e7f4dc3536a

Re: [PATCH] usbnet: cleanup after bind() in probe()

2016-03-07 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Mar 2016 11:31:10 +0100 > In case bind() works, but a later error forces bailing > in probe() in error cases work and a timer may be scheduled. > They must be killed. This fixes an error case related to > the double free reported in > http://www.spinics.net/lists

Re: Possible double-free in the usbnet driver

2016-03-07 Thread David Miller
From: Linus Torvalds Date: Mon, 7 Mar 2016 10:13:09 -0800 > On Sat, Mar 5, 2016 at 11:53 AM, Bjørn Mork wrote: >> >> >> Definitely. The patch is so obviously correct that we can only wonder how >> it was possible to miss it it the first place :) >> >> Will take a look to see if we could do a b

Re: [PATCH net,stable] cdc_ncm: toggle altsetting to force reset before setup

2016-03-07 Thread David Miller
From: Bjørn Mork Date: Thu, 3 Mar 2016 22:20:53 +0100 > Some devices will silently fail setup unless they are reset first. > This is necessary even if the data interface is already in > altsetting 0, which it will be when the device is probed for the > first time. Briefly toggling the altsettin

Re: Possible double-free in the usbnet driver

2016-03-07 Thread David Miller
From: Andrey Konovalov Date: Mon, 7 Mar 2016 22:50:41 +0300 > On Mon, Mar 7, 2016 at 10:11 PM, David Miller wrote: >> From: Linus Torvalds >> Date: Mon, 7 Mar 2016 10:13:09 -0800 >> >>> On Sat, Mar 5, 2016 at 11:53 AM, Bjørn Mork wrote: >>>> >&g

Re: [PATCH] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-03-07 Thread David Miller
From: Bjørn Mork Date: Mon, 7 Mar 2016 21:15:36 +0100 > usbnet_link_change will call schedule_work and should be > avoided if bind is failing. Otherwise we will end up with > scheduled work referring to a netdev which has gone away. > > Instead of making the call conditional, we can just defer >

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-15 Thread David Miller
From: Bjørn Mork Date: Tue, 15 Mar 2016 13:27:03 +0100 > Schemmel Hans-Christoph writes: > >> If you are not the intended recipient of this message, please delete it and >> notify the sender. > > OK. Deleted. I've also deleted it and therefore won't look at this patch. -- To unsubscribe fro

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-19 Thread David Miller
From: Schemmel Hans-Christoph Date: Thu, 17 Mar 2016 10:07:56 + > Added support for Gemalto's Cinterion PHxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > PHxx can have: > 2 RmNet Interfaces (PID 0x0082) or > 1 RmNet + 1 USB Audio interface (PID 0x0083). > >

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-20 Thread David Miller
From: Eric Dumazet Date: Sun, 20 Mar 2016 09:35:52 -0700 > On Sun, 2016-03-20 at 11:43 +0100, Geert Uytterhoeven wrote: >> If CONFIG_PM=n: >> >> drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’: >> drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no >> member

Re: [PATCH TRIVIAL] drivers/net/usb/plusb.c: Fix typo

2016-03-27 Thread David Miller
From: Diego Viola Date: Sun, 27 Mar 2016 20:58:15 -0300 > Signed-off-by: Diego Viola Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net,stable] qmi_wwan: add "D-Link DWM-221 B1" device id

2016-03-28 Thread David Miller
From: Bjørn Mork Date: Mon, 28 Mar 2016 22:38:16 +0200 > Thomas reports: > "Windows: ... > Linux: ... > Reported-by: Thomas Schäfer > Signed-off-by: Bjørn Mork Applied and queued up for -stable, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH 1/1] net: usb: cdc_ncm: adding Telit LE910 V2 mobile broadband card

2016-03-31 Thread David Miller
From: Daniele Palmas Date: Thu, 31 Mar 2016 15:16:47 +0200 > Telit LE910 V2 is a mobile broadband card with no ARP capabilities: > the patch makes this device to use wwan_noarp_info struct > > Signed-off-by: Daniele Palmas Bjorn, can you take a quick look at this? Thank you. -- To unsubscribe

Re: [PATCH 1/1] net: usb: cdc_ncm: adding Telit LE910 V2 mobile broadband card

2016-03-31 Thread David Miller
From: Bjørn Mork Date: Thu, 31 Mar 2016 23:07:30 +0200 > David Miller writes: >> From: Daniele Palmas >> Date: Thu, 31 Mar 2016 15:16:47 +0200 >> >>> Telit LE910 V2 is a mobile broadband card with no ARP capabilities: >>> the patch makes th

Re: [PATCH net,stable] cdc_mbim: apply "NDP to end" quirk to all Huawei devices

2016-04-14 Thread David Miller
From: Bjørn Mork Date: Tue, 12 Apr 2016 16:11:12 +0200 > We now have a positive report of another Huawei device needing > this quirk: The ME906s-158 (12d1:15c1). This is an m.2 form > factor modem with no obvious relationship to the E3372 (12d1:157d) > we already have a quirk entry for. This is

Re: [PATCH] net/smscx5xx: use the device tree for mac address

2016-05-01 Thread David Miller
From: Lubomir Rintel Date: Fri, 29 Apr 2016 09:05:59 +0200 > From: Arnd Bergmann > > This takes the MAC address for smsc75xx/smsc95xx USB network devices > from a the device tree. This is required to get a usable persistent > address on the popular beagleboard, whose hardware designers > accide

Re: [PATCH net v2 0/4] r8152: fix scheduling napi

2017-01-25 Thread David Miller
From: Hayes Wang Date: Thu, 26 Jan 2017 03:04:45 + > May you apply these patches first, until I find another way to replace > current one? Yes, I will. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH net v3 0/4] r8152: fix scheduling napi

2017-01-25 Thread David Miller
From: Hayes Wang Date: Thu, 26 Jan 2017 09:38:30 +0800 > v3: > simply the argument for patch #3. Replace &tp->napi with napi. > > v2: > Add smp_mb__after_atomic() for patch #1. > > v1: > Scheduling the napi during the following periods would let it be ignored. > And the events wouldn't be handl

Re: [PATCH net 0/4] Fix on-stack USB buffers

2017-02-07 Thread David Miller
From: Ben Hutchings Date: Sat, 4 Feb 2017 16:54:51 + > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). This > series fixes all the instances I could find where USB networking > drivers do that. Series applied and

Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread David Miller
From: Stefan Brüns Date: Mon, 6 Feb 2017 21:20:33 +0100 > > /* Validate the protocol - only support UMTS for now */ > - if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) { > + if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) { ... > + } else if (lsi->protocol == SIERRA_NET_PROTOC

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread David Miller
From: David Miller Date: Tue, 07 Feb 2017 13:53:12 -0500 (EST) > From: Stefan Brüns > Date: Tue, 7 Feb 2017 03:33:16 +0100 > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly different indica

Re: [PATCH v2 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs

2017-02-07 Thread David Miller
From: Stefan Brüns Date: Tue, 7 Feb 2017 03:33:17 +0100 > When the context is deactivated, the link_type is set to 0xff, which > triggers a warning message, and results in a wrong link status, as > the LSI is ignored. > > Signed-off-by: Stefan Brüns Applied. -- To unsubscribe from this list: s

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread David Miller
From: Stefan Brüns Date: Tue, 7 Feb 2017 03:33:16 +0100 > If a context is configured as dualstack ("IPv4v6"), the modem indicates > the context activation with a slightly different indication message. > The dual-stack indication omits the link_type (IPv4/v6) and adds > additional address fields.

Re: [PATCH v3 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-08 Thread David Miller
From: Bjørn Mork Date: Wed, 08 Feb 2017 10:55:50 +0100 > Stefan Brüns writes: > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly different indication message. >> The dual-stack indication omits the link_type (IPv4/v6) and adds

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-08 Thread David Miller
From: Florian Fainelli Date: Tue, 7 Feb 2017 15:02:53 -0800 > I'm hoping this doesn't conflict with what's already in net-next... > > David, this should probably go via your tree considering the diffstat. I think you need one more respin. Are you doing an allmodconfig build? If not, for somet

Re: [PATCH v3 0/2] Fixes for sierra_net driver

2017-02-09 Thread David Miller
From: Stefan Brüns Date: Wed, 8 Feb 2017 02:46:31 +0100 > When trying to initiate a dual-stack (ipv4v6) connection, a MC7710, FW > version SWI9200X_03.05.24.00ap answers with an unsupported LSI. Add support > for this LSI. > Also the link_type should be ignored when going idle, otherwise the mode

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-10 Thread David Miller
From: Kalle Valo Date: Thu, 09 Feb 2017 16:10:06 +0200 > Florian Fainelli writes: > If not, for something like this it's a must: drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’ module_param(disable_ap_sme, bool, 0444);

Re: [PATCH] MAINTAINERS: Orphan usb/net/hso driver

2017-02-28 Thread David Miller
From: Baruch Siach Date: Tue, 28 Feb 2017 10:39:48 +0200 > The email address of Jan Dumon bounces, and there is not relevant information > in the linked website. > > Signed-off-by: Baruch Siach This patch is fine and I will apply it later, however I will make a general statement that we list U

Re: [PATCH] MAINTAINERS: Orphan usb/net/hso driver

2017-03-01 Thread David Miller
From: Baruch Siach Date: Tue, 28 Feb 2017 10:39:48 +0200 > The email address of Jan Dumon bounces, and there is not relevant information > in the linked website. > > Signed-off-by: Baruch Siach Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a me

Re: [PATCH] net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode

2017-03-01 Thread David Miller
From: Colin King Date: Tue, 28 Feb 2017 11:58:22 + > From: Colin Ian King > > The call to asix_write_medium_mode is not updating the return code ret > and yet ret is being checked for an error. Fix this by assigning ret to > the return code from the call asix_write_medium_mode. > > Detecte

Re: [PATCH] isdn/gigaset: fix NULL-deref at probe

2017-03-13 Thread David Miller
From: Johan Hovold Date: Mon, 13 Mar 2017 13:39:01 +0100 > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer should a malicious device lack endpoints. > > Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers - > direct USB connection") > Cc: stable

Re: [PATCH] net: wimax/i2400m: fix NULL-deref at probe

2017-03-13 Thread David Miller
From: Johan Hovold Date: Mon, 13 Mar 2017 13:42:03 +0100 > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > The endpoints are specifically dereferenced in

Re: [PATCH] net: usb: catc: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Mar 2017 22:08:26 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCH] net: usb: r8152: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Mar 2017 22:41:58 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Mar 2017 18:02:36 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

2017-03-13 Thread David Miller
From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 > An insert/remove stress test generated the following log message sequence. ... > Use netdev_dbg() instead of netdev_warn() for the repeating messages > to reduce logging noise. > > Signed-off-by: Guenter Roeck The problem I have with

Re: [PATCH v2 net-next] r8152: simply the arguments

2017-03-16 Thread David Miller
From: Hayes Wang Date: Thu, 16 Mar 2017 14:32:22 +0800 > Replace &tp->napi with napi and tp->netdev with netdev. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH net] r8152: fix the list rx_done may be used without initialization

2017-03-21 Thread David Miller
From: Hayes Wang Date: Tue, 14 Mar 2017 14:15:20 +0800 > The list rx_done would be initialized when the linking on occurs. > Therefore, if a napi is scheduled without any linking on before, > the following kernel panic would happen. > > BUG: unable to handle kernel NULL pointer dereference

Re: [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Mar 2017 23:18:46 +0100 > The ethtool api {get|set}_settings is deprecated. On usbnet, it > was often implemented with usbnet_{get|set}_settings. > > In this serie, I add usbnet_{get|set}_link_ksettings > in the first patch, then I update all the driver to > u

Re: [PATCH 01/11] net: usb: usbnet: add new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread David Miller
From: Oliver Neukum Date: Tue, 21 Mar 2017 12:33:03 +0100 > Am Donnerstag, den 16.03.2017, 23:18 +0100 schrieb Philippe Reynes: >> The ethtool api {get|set}_settings is deprecated. >> We add the new api {get|set}_link_ksettings to this driver. >> >> As I don't have the hardware, I'd be very plea

Re: [PATCH net-next] r8152: check hw version first

2017-03-21 Thread David Miller
From: Hayes Wang Date: Fri, 17 Mar 2017 11:20:13 +0800 > Check hw version first in probe(). Do nothing if the driver doesn't > support the chip. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to ma

Re: [PATCH net,stable] qmi_wwan: add Dell DW5811e

2017-03-21 Thread David Miller
From: Bjørn Mork Date: Fri, 17 Mar 2017 17:20:48 +0100 > This is a Dell branded Sierra Wireless EM7455. It is operating in > MBIM mode by default, but can be configured to provide two QMI/RMNET > functions. > > Signed-off-by: Bjørn Mork > --- > Note regarding stable backports: > > This device

Re: [PATCH net 0/2] r8152: fix the rx settings of RTL8153

2017-03-22 Thread David Miller
From: Hayes Wang Date: Mon, 20 Mar 2017 16:13:43 +0800 > The RMS and the rx early size should base on the same rx size. However, > the RMS is set to 9K bytes now and the rx early depends on mtu. For using > the rx buffer effectively, sync the two settings according to the mtu. Series applied. -

Re: [PATCH net-next 0/7] Clean up PHY MMD accessors

2017-03-22 Thread David Miller
From: Russell King - ARM Linux Date: Tue, 21 Mar 2017 16:35:55 + > This series cleans up phylib's MMD accessors, so that we have a common > way of accessing the Clause 45 register set. > > The current situation is far from ideal - we have phy_(read|write)_mmd() > which accesses Clause 45 reg

Re: [PATCH net] r8152: prevent the driver from transmitting packets with carrier off

2017-03-24 Thread David Miller
From: Hayes Wang Date: Thu, 23 Mar 2017 19:14:19 +0800 > The linking status may be changed when autosuspend. And, after > autoresume, the driver may try to transmit packets when the device > is carrier off, because the interrupt transfer doesn't update the > linking status, yet. And, if the devic

Re: [PATCH 0/2] net: usb: qmi_wwan: add qmap mux protocol support

2017-03-25 Thread David Miller
From: Daniele Palmas Date: Fri, 24 Mar 2017 14:22:44 +0100 > This patch adds support for qmap mux protocol available in recent > Qualcomm based modems. > > The qmap mux protocol can be used for multiplexing data packets in > order to have multiple ip streams through the same physical device. >

Re: [PATCHv4] net: usbnet: support 64bit stats

2017-04-03 Thread David Miller
From: Greg Ungerer Date: Mon, 3 Apr 2017 15:50:03 +1000 > Add support for the net stats64 counters to the usbnet core. With that > in place put the hooks into every usbnet driver to use it. > > This is a strait forward addition of 64bit counters for RX and TX packet > and byte counts. It is don

Re: [PATCH] net: cdc_ncm: use IAD provided by the USB core

2013-01-27 Thread David Miller
From: Bjørn Mork Date: Sat, 26 Jan 2013 10:36:59 +0100 > commit 9992c2e (net: cdc_ncm: workaround for missing CDC Union) > added code to lookup an IAD for the interface we are probing. > This is redundant. The USB core has already done the lookup > and saved the result in the USB interface struc

Re: [PATCH net v2] net: usbnet: prevent buggy devices from killing us

2013-01-30 Thread David Miller
From: Oliver Neukum Date: Wed, 30 Jan 2013 08:44:35 +0100 > On Tuesday 29 January 2013 10:51:28 Bjørn Mork wrote: >> A device sending 0 length frames as fast as it can has been >> observed killing the host system due to the resulting memory >> pressure. >> >> Temporarily disable RX skb allocatio

Re: [PATCH v2] NET: qmi_wwan: add Telit LE920 support

2013-01-30 Thread David Miller
From: Bjørn Mork Date: Wed, 30 Jan 2013 14:50:46 +0100 > Daniele Palmas writes: > >> Add VID, PID and fixed interface for Telit LE920 >> >> Signed-off-by: Daniele Palmas >> --- >> v2: >> - rebased against net tree > > Excellent! Thanks. Looks like an interesting device BTW. > > Acked-by: B

Re: [PATCH net] net: usbnet: fix tx_dropped statistics

2013-02-04 Thread David Miller
From: Bjørn Mork Date: Thu, 31 Jan 2013 19:36:05 +0100 > It is normal for minidrivers accumulating frames to return NULL > from their tx_fixup function. We do not want to count this as a > drop, or log any debug messages. A different exit path is > therefore chosen for such drivers, skipping the

Re: [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages

2013-02-04 Thread David Miller
From: Joe Perches Date: Sun, 3 Feb 2013 19:28:07 -0800 > Remove all the OOM messages that follow kernel alloc > failures as there is already a generic equivalent to > these messages in the mm subsystem. > > Joe Perches (8): > caif: Remove unnecessary alloc/OOM messages > can: Remove unneces

Re: [PATCH] net: cdc_ncm: add another Huawei vendor specific device

2013-02-06 Thread David Miller
From: Bjørn Mork Date: Wed, 6 Feb 2013 16:21:53 +0100 > Adding a new vendor specific class/subclass/protocol combination > for CDC NCM devices based on information from a GPLed out-of-tree > driver from Huawei. > > Signed-off-by: Bjørn Mork Applied. -- To unsubscribe from this list: send the

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-02-07 Thread David Miller
From: Ben Hutchings Date: Thu, 7 Feb 2013 20:02:55 + > On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote: >> From: Freddy Xin >> >> This is a resubmission. >> Added "const" to ethtool_ops structure and fixed the coding style of >> AX88179_BULKIN_SIZE array. >> Fixed the issue that the de

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-02-08 Thread David Miller
From: "David Laight" Date: Fri, 8 Feb 2013 10:23:08 - > It is much better to define constants for the bit values and > explicitly mask them as required. Yes, __be32/__le32 along with bit define macros is the only reasonable way to do this kind of stuff. -- To unsubscribe from this list: send

Re: [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-08 Thread David Miller
From: Joe Perches Date: Thu, 07 Feb 2013 13:46:27 -0800 > alloc failures already get standardized OOM > messages and a dump_stack. > > For the affected mallocs around these OOM messages: > > Converted kmallocs with multiplies to kmalloc_array. > Converted a kmalloc/memcpy to kmemdup. > Removed

Re: [PATCH] net: qmi_wwan: add Yota / Megafon M100-1 4g modem

2013-02-12 Thread David Miller
From: Bjørn Mork Date: Tue, 12 Feb 2013 13:42:50 +0100 > Interface layout: ... > Signed-off-by: Bjørn Mork Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH] net: cdc_ncm: fix probing of devices with multiple control interface altsettings

2013-02-14 Thread David Miller
From: Bjørn Mork Date: Wed, 13 Feb 2013 23:09:52 +0100 > commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices") > added a test for a CDC MBIM altsetting, implementing the cdc_ncm part of > MBIM backward compatibility support. This intentionally made the driver > behave diffe

Re: [PATCH v2] qmi_wwan, cdc-ether: add ADU960S

2013-02-18 Thread David Miller
From: Dan Williams Date: Mon, 18 Feb 2013 21:25:09 -0600 > It advertises a standard CDC-ETHER interface, which actually should be > driven by qmi_wwan. > > Signed-off-by: Dan Williams Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to m

Re: [PATCH 0/3] usbnet: smsc95xx: fix smsc95xx_suspend

2013-02-25 Thread David Miller
From: Ming Lei Date: Fri, 22 Feb 2013 21:05:02 +0800 > The 1st two patches fix smsc95xx_suspend, and the 1st one should > be backported to 3.8. > > The last one is to rename the misleading FEATURE_AUTOSUSPEND. All applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-25 Thread David Miller
From: Greg Kroah-Hartman Date: Mon, 25 Feb 2013 20:23:43 -0800 > On Tue, Feb 26, 2013 at 02:47:12PM +1030, Glen Turner wrote: >> This USB ethernet adapter was purchased in anodyne packaging >> marked "USB2.0 to LAN" from the computer store adjacent to >> linux.conf.au 2013 in Canberra (Australia)

Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-25 Thread David Miller
From: Greg KH Date: Mon, 25 Feb 2013 21:03:11 -0800 > On Mon, Feb 25, 2013 at 11:45:29PM -0500, David Miller wrote: >> From: Greg Kroah-Hartman >> Date: Mon, 25 Feb 2013 20:23:43 -0800 >> >> > On Tue, Feb 26, 2013 at 02:47:12PM +1030, Glen Turner wrote: >&

Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-26 Thread David Miller
From: Glen Turner Date: Tue, 26 Feb 2013 14:47:12 +1030 > This USB ethernet adapter was purchased in anodyne packaging > marked "USB2.0 to LAN" from the computer store adjacent to > linux.conf.au 2013 in Canberra (Australia). A web search > shows other recent purchasers in Lancaster (UK) and Seat

Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-26 Thread David Miller
From: David Miller Date: Tue, 26 Feb 2013 17:28:56 -0500 (EST) > Applied, thanks Glen. Actually, I had to revert, this doesn't even compile against current sources: CC [M] drivers/net/usb/asix_devices.o drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here (

Re: [PATCH] net: cdc_ncm: tag Huawei devices (e.g. E5331) with FLAG_WWAN

2013-02-27 Thread David Miller
From: Bjørn Mork Date: Wed, 27 Feb 2013 14:08:58 +0100 > Tag all Huawei NCM devices as WWAN modems, as we don't know of any which > are not. This is necessary for userspace clients to know that the device > requires further setup on e.g. an AT-capable serial ports before > connectivity is availa

Re: [PATCHv2] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-27 Thread David Miller
From: Glen Turner Date: Thu, 28 Feb 2013 01:02:36 +1030 > This USB ethernet adapter was purchased in anodyne packaging > from the computer store adjacent to linux.conf.au 2013 in > Canberra (Australia). A web search shows other recent > purchasers in Lancaster (UK) and Seattle (USA). Just like an

Re: [PATCH resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-03-01 Thread David Miller
From: Freddy Xin Date: Wed, 27 Feb 2013 20:01:58 +0800 > + eeprom_buff = kmalloc(sizeof(u16) * (last_word - first_word + 1), > + GFP_KERNEL); > + if (!eeprom_buff) > + return -ENOMEM; > + > + /* ax88179/178A returns 2 bytes from eeprom on read */

Re: [PATCH resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-03-02 Thread David Miller
From: Freddy Xin Date: Sat, 2 Mar 2013 18:41:11 +0800 > From: Freddy Xin > > This is a resubmission. > Added kfree() in ax88179_get_eeprom to prevent memory leakage. > Modified "__le16 rxctl" to "u16 rxctl" in "struct ax88179_data" and removed > pointless casts. > Removed asix_init and asix_e

Re: [PATCH 3.8-stable] usbnet: smsc95xx: fix suspend failure

2013-03-04 Thread David Miller
From: Ming Lei Date: Mon, 4 Mar 2013 18:07:13 +0800 > The three below functions: > > smsc95xx_enter_suspend0() > smsc95xx_enter_suspend1() > smsc95xx_enter_suspend2() > > return > 0 in case of success, so they will cause smsc95xx_suspend() > to return > 0 and suspend fa

Re: [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep

2013-03-07 Thread David Miller
From: Ming Lei Date: Fri, 8 Mar 2013 00:15:17 +0800 > This patch adds comments on interface driver suspend callback > to emphasize that the failure return value is ignored by > USB core in system sleep context, so do not try to recover > device for this case, otherwise the recovery things may co

Re: [PATCH net,stable-3.8] net: qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-13 Thread David Miller
From: Dan Williams Date: Wed, 13 Mar 2013 08:43:36 -0500 > On Wed, 2013-03-13 at 13:25 +0100, Bjørn Mork wrote: >> commit bd877e4 ("net: qmi_wwan: use a single bind function for >> all device types") made Gobi 1K devices fail probing. >> >> Using the number of endpoints in the default altsetting

Re: [PATCH net,stable-3.8] net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility

2013-03-17 Thread David Miller
From: Bjørn Mork Date: Thu, 14 Mar 2013 12:05:13 +0100 > commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices") > introduced a new policy, preferring MBIM for dual NCM/MBIM functions if > the cdc_mbim driver was enabled. This caused a regression for users > wanting to use NC

Re: [patch -next] smsc95xx: signedness bug in get_regs()

2012-07-12 Thread David Miller
From: Dan Carpenter Date: Wed, 11 Jul 2012 09:32:51 +0300 > "retval" has to be a signed integer for the error handling to work. > > Signed-off-by: Dan Carpenter Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.or

Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

2012-07-16 Thread David Miller
From: Felipe Balbi Date: Mon, 16 Jul 2012 13:14:38 +0300 > if you're really renaming the function, then this patch alone will break > all of the below users. That should all be a single patch, I'm afraid. It would help if you actually read his patches before saying what they might or might not d

Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

2012-07-16 Thread David Miller
From: Felipe Balbi Date: Mon, 16 Jul 2012 14:12:19 +0300 > Acked-by: Felipe Balbi You need to provide this in a reply to the patch you actually want to ACK, so that the patch tracking system attaches your ACK to the proper patch. Thank you. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

2012-07-16 Thread David Miller
From: Joe Perches Date: Thu, 12 Jul 2012 22:33:04 -0700 > net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr") > added a new style API. Rename random_ether_addr to eth_random_addr to > create some API symmetry. Series applied, thanks Joe. -- To unsubscribe from this list: se

Re: [PATCH net-next] net: qmi_wwan: make dynamic device IDs work

2012-07-18 Thread David Miller
From: Bjørn Mork Date: Tue, 17 Jul 2012 23:14:32 +0200 > The usbnet API use the device ID table to store a pointer to > a minidriver. Setting a generic pointer for dynamic device > IDs will in most cases make them work as expected. usbnet > will otherwise treat the dynamic IDs as blacklisted. Th

Re: [PATCH] net: qmi_wwan: add ZTE MF821D

2012-07-18 Thread David Miller
From: Bjørn Mork Date: Thu, 12 Jul 2012 13:18:26 +0200 > Sold by O2 (telefonica germany) under the name "LTE4G" > > Tested-by: Thomas Schäfer > Signed-off-by: Bjørn Mork Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messa

Re: [PATCH] USB: plusb: Add support for PL-2501

2012-07-23 Thread David Miller
From: kyak Date: Mon, 23 Jul 2012 15:44:11 +0400 (MSK) > From: Mikhail Peselnik > > This patch adds support for PL-2501 by adding the appropriate USB > ID's. This chip is used in several USB 'Easy Trasfer' Cables. > > Signed-off-by: Mikhail Peselnik > Tested-by: Mikhail Peselnik This does n

Re: [PATCH] USB: plusb: Add support for PL-2501

2012-07-23 Thread David Miller
From: kyak Date: Tue, 24 Jul 2012 09:39:40 +0400 (MSK) > This patch was created against linux-3.5, but it applies perfectly > against net-next tree, i just checked.. > > I'm sorry for not being able to submit the correct patch from the > first attempt (and not even from the third attempt). Could

Re: [PATCH] cdc-ncm: tag Ericsson WWAN devices (eg F5521gw) with FLAG_WWAN

2012-07-24 Thread David Miller
From: Dan Williams Date: Tue, 24 Jul 2012 13:43:22 -0500 > Tag Ericsson NCM devices as WWAN modems, since they almost certainly all > are. This way userspace clients know that the device requires further > setup on the AT-capable serial ports before connectivity is available. > > Signed-off-by:

Re: [patch] USB: kaweth.c: use GFP_ATOMIC under spin_lock

2012-07-27 Thread David Miller
From: Dan Carpenter Date: Fri, 27 Jul 2012 14:46:51 +0300 > The problem is that we call this with a spin lock held. The call tree > is: > kaweth_start_xmit() holds kaweth->device_lock. > -> kaweth_async_set_rx_mode() > -> kaweth_control() > -> kaweth_internal_con

Re: [PATCH] cdc-ncm: tag Ericsson WWAN devices (eg F5521gw) with FLAG_WWAN

2012-08-03 Thread David Miller
From: Peter Meiser Date: Thu, 02 Aug 2012 14:30:20 +0200 > looking at > http://sourceforge.net/apps/mediawiki/mbm/index.php?title=Main_Page#Supported_devices, > there are branded Ericsson devices from Dell and Toshiba. > > The to-be-added vendor IDs are 0x413c for Dell and 0x0930 for Toshiba.

Re: [PATCH] cdc-phonet: Don't leak in usbpn_open

2012-08-08 Thread David Miller
From: "Rémi Denis-Courmont" Date: Wed, 8 Aug 2012 10:12:06 +0300 > Le mercredi 8 août 2012 00:56:26 Jesper Juhl, vous avez écrit : >> We allocate memory for 'req' with usb_alloc_urb() and then test >> 'if (!req || rx_submit(pnd, req, GFP_KERNEL | __GFP_COLD))'. >> If we enter that branch due to '

Re: [PATCH net] net: sierra_net: replace whitelist with ifnumber match

2012-08-12 Thread David Miller
From: Bjørn Mork Date: Sun, 12 Aug 2012 21:53:38 +0200 > Please apply to "net". Simplifications and cleanups are not appropriate for the 'net' tree. I would say that all of the patches you posted today are 'net-next' material. -- To unsubscribe from this list: send the line "unsubscribe linux-u

Re: [PATCH net 0/3] qmi_wwan: simplify device matching and add a few new devices

2012-08-14 Thread David Miller
From: Bjørn Mork Date: Sun, 12 Aug 2012 21:16:29 +0200 > The home cooked whitelisting code can be removed now that > the USB core supports interface number matching. > > The second patch adds a few new devices. > > The third patch improves device list readability by using > existing macros whe

<    1   2   3   4   5   6   7   8   >