Re: [PATCH 1/3] brcm80211: correct speed testing

2016-05-03 Thread David Miller
From: Oliver Neukum Date: Mon, 2 May 2016 13:06:12 +0200 > Allow for SS+ USB > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [PATCH 3/3] rtl8152: correct speed testing

2016-05-03 Thread David Miller
From: Oliver Neukum Date: Mon, 2 May 2016 13:06:14 +0200 > Allow for SS+ USB > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [PATCH 2/3] usbnet: correct speed testing

2016-05-03 Thread David Miller
From: Oliver Neukum Date: Mon, 2 May 2016 13:06:13 +0200 > Allow for SS+ USB > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [patch] usbnet/smsc75xx: silence uninitialized variable warning

2016-05-04 Thread David Miller
From: Dan Carpenter Date: Wed, 4 May 2016 09:21:02 +0300 > If the fn() calls fail then "buf" is uninitialized. Just return early > in that situation. > > Signed-off-by: Dan Carpenter Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to m

Re: [patch] usbnet: smsc95xx: silence an uninitialized variable warning

2016-05-04 Thread David Miller
From: Dan Carpenter Date: Wed, 4 May 2016 09:22:01 +0300 > If the call to fn() fails then "buf" is uninitialized. Just return the > error code in that case. > > Signed-off-by: Dan Carpenter Applied. Please, in the future, use a consistent subsystem prefixing scheme. In these two patches you

Re: [PATCH] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-17 Thread David Miller
From: John Stultz Date: Mon, 16 May 2016 20:36:15 -0700 > In testing with HiKey, we found that since > commit 3f30b158eba5 ("asix: On RX avoid creating bad Ethernet > frames"), > we're seeing lots of noise during network transfers: ... > And network throughput ends up being pretty bursty and slo

Re: [PATCH 1/1] net: pegasus: remove dead coding

2016-05-19 Thread David Miller
From: Heinrich Schuchardt Date: Wed, 18 May 2016 02:13:30 +0200 > (!count || count < 4) is always true. > So let's remove the coding which is dead at least since 2005. > > Signed-off-by: Heinrich Schuchardt Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: [PATCH] net: pegasus: remove unused variables and labels

2016-05-20 Thread David Miller
From: Arnd Bergmann Date: Fri, 20 May 2016 10:22:30 +0200 > The latest dead-code removal was slightly incomplete and > left a few things behind that we now get compiler warnings > for: > > drivers/net/usb/pegasus.c: In function 'read_bulk_callback': > drivers/net/usb/pegasus.c:475:1: error: labe

Re: [PATCH 1/1] net: pegasus: remove dead coding

2016-05-20 Thread David Miller
From: Petko Manolov Date: Fri, 20 May 2016 10:33:47 +0300 > On 16-05-19 11:35:42, David Miller wrote: >> From: Heinrich Schuchardt >> Date: Wed, 18 May 2016 02:13:30 +0200 >> >> > (!count || count < 4) is always true. >> > So let's remo

Re: [PATCH net,stable v2] net: cdc_ncm: update datagram size after changing mtu

2016-05-20 Thread David Miller
From: Robert Dobrowolski Date: Thu, 19 May 2016 11:56:09 +0200 > From: Rafal Redzimski > > Current implementation updates the mtu size and notify cdc_ncm > device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram > size change instead of changing rx_urb_size. > > Whenever mtu is being

Re: [PATCH] net: usb: ch9200: use kmemdup

2016-05-20 Thread David Miller
From: Muhammad Falak R Wani Date: Thu, 19 May 2016 19:26:50 +0530 > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. > > Signed-off-by: Muhammad Falak R Wani Applied. -- To unsubs

Re: [PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-23 Thread David Miller
From: Heinrich Schuchardt Date: Wed, 18 May 2016 20:40:51 +0200 > If !count is true, count < 4 is also true. > > Signed-off-by: Heinrich Schuchardt Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH net-next] r8152: replace netdev_alloc_skb_ip_align with napi_alloc_skb

2016-06-09 Thread David Miller
From: Hayes Wang Date: Wed, 8 Jun 2016 14:52:33 +0800 > Replace netdev_alloc_skb_ip_align() with napi_alloc_skb() which can save > several CPU cycles by avoiding having to disable and re-enable IRQs. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-10 Thread David Miller
From: Mario Limonciello Date: Tue, 7 Jun 2016 13:22:37 -0500 > The RTL8153-AD supports a persistent system specific MAC address. > This means a device plugged into two different systems with host side > support will show different (but persistent) MAC addresses. > > This information for the sys

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-11 Thread David Miller
From: Andrew Lunn Date: Sat, 11 Jun 2016 17:39:21 +0200 > What is still open is do we want to accept it at all? Do we accept the > concept of putting the same MAC address on multiple interfaces at > hotplug time? Do we trust BIOS vendors to not keep changing DSDT > property name, since it is not

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread David Miller
From: Pali Rohár Date: Tue, 14 Jun 2016 18:47:36 +0200 > You have never seen two ethernet cards with same MAC addresses? Right I > have not seen two USB, but there is non zero chance that could happen. It would be an error scenerio, and something to be avoided. It is a valid and correct assum

Re: [PATCH net-next 0/3] r8152: code adjustment for PHY

2016-06-14 Thread David Miller
From: Hayes Wang Date: Mon, 13 Jun 2016 17:49:35 +0800 > These patches are for adjusting the code about PHY and setting speed. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH net 0/3] r8152: fix known issues

2016-06-15 Thread David Miller
From: Hayes Wang Date: Thu, 16 Jun 2016 10:55:16 +0800 > These patches fix some known issues. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH net-next] r8152: modify the check of the flag of PHY_RESET in set_speed function

2016-06-16 Thread David Miller
From: Hayes Wang Date: Thu, 16 Jun 2016 14:08:29 +0800 > In set_speed(), BMCR_RESET would be set when the flag of PHY_RESET > is set. Use BMCR_RESET to replace testing the flag of PHY_RESET. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH net] r8152: clear LINK_OFF_WAKE_EN after autoresume

2016-07-01 Thread David Miller
From: Hayes Wang Date: Thu, 30 Jun 2016 15:33:35 +0800 > LINK_OFF_WAKE_EN should be cleared after autoresume, otherwise after > system suspend, the system would wake up when linking off occurs. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 1/1 v2] asix: use ramdom hw addr if the one read is not valid

2012-11-23 Thread David Miller
From: Jean-Christophe PLAGNIOL-VILLARD Date: Thu, 22 Nov 2012 08:35:17 +0100 > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] smsc: Add logging message newlines

2012-11-25 Thread David Miller
From: Joe Perches Date: Sat, 24 Nov 2012 03:27:49 -0800 > Avoid any possible message logging interleaving by adding > missing newlines. > > Align arguments. > > Signed-off-by: Joe Perches Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [PATCH] net: qmi_wwan: add Huawei E173

2012-11-28 Thread David Miller
From: Bjørn Mork Date: Sun, 25 Nov 2012 17:03:59 +0100 > The Huawei E173 is a QMI/wwan device which normally appear > as 12d1:1436 in Linux. The descriptors displayed in that > mode will be picked up by cdc_ether. But the modem has > another mode with a different device ID and a slightly > diffe

Re: [PATCH net] net: qmi_wwan: add ZTE MF880

2012-12-19 Thread David Miller
From: Bjørn Mork Date: Wed, 19 Dec 2012 15:15:51 +0100 > The driver description files gives these names to the vendor specific > functions on this modem: > > diag: VID_19D2&PID_0284&MI_00 > nmea: VID_19D2&PID_0284&MI_01 > at: VID_19D2&PID_0284&MI_02 > mdm: VID_19D2&PID_0284&MI_03 > net:

Re: [PATCH] net: qmi_wwan: add Telekom Speedstick LTE II

2012-12-28 Thread David Miller
From: Bjørn Mork Date: Fri, 28 Dec 2012 17:30:55 +0100 > also known as Alcatel One Touch L100V LTE > > The driver description files gives these names to the vendor specific > functions on this modem: > > Application1: VID_1BBB&PID_011E&MI_00 > Application2: VID_1BBB&PID_011E&MI_01 > Modem:

Re: [PATCH] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-10 Thread David Miller
From: Ming Lei Date: Fri, 11 Jan 2013 10:45:38 +0800 > Cc netdev and usb lists. That doesn't work for patches, sorry. It will have to be submitted freshly and cleanly to the appropriate lists, not as a quoted reply. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-12 Thread David Miller
From: Wei Shuai Date: Sat, 12 Jan 2013 19:34:39 +0800 > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I > introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in > driver_info:data. so later on, if more such buggy devices are found, > they could use same flag to handle

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread David Miller
From: Dan Williams Date: Mon, 14 Jan 2013 11:19:13 -0600 > On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: >> From: Wei Shuai >> Date: Sat, 12 Jan 2013 19:34:39 +0800 >> >> > Infineon(now Intel) HSPA Modem platform NCM cannot support A

Re: [PATCH] usbnet: dm9601: Fix incorrect command

2013-01-16 Thread David Miller
From: Tushar Behera Date: Tue, 15 Jan 2013 11:09:01 +0530 > commit 24b1042c4eb2 ("usbnet: dm9601: apply introduced usb command > APIs") removes the distiction between DM_WRITE_REG and DM_WRITE_REGS > command. The distiction is reintroduced to the driver so that the > functionality of the driver r

Re: [PATCH net] net: qmi_wwan: add TP-LINK HSUPA Modem MA180

2013-01-16 Thread David Miller
From: Bjørn Mork Date: Tue, 15 Jan 2013 10:19:50 +0100 > The driver description files gives these names to the vendor specific > functions on this modem: > > Diagnostics VID_2357&PID_0201&MI_00 > NMEAVID_2357&PID_0201&MI_01 > Modem VID_2357&PID_0201&MI_03 > Networkcard VID_2357

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-16 Thread David Miller
From: Bjørn Mork Date: Tue, 15 Jan 2013 09:34:07 +0100 > The main problem is that these devices don't support ethernet. They > support IP (v4 and _maybe_ v6) with an ethernet header. Many of them > will do ARP (and IPv6 ND) as well to complete the picture, but some of > them don't and that's wh

Re: [PATCH v3 1/2] net: asix: init ASIX AX88772B MAC from EEPROM

2013-01-18 Thread David Miller
From: Lucas Stach Date: Wed, 16 Jan 2013 15:24:06 +0100 > The device comes up with a MAC address of all zeros. We need to read the > initial device MAC from EEPROM so it can be set properly later. > > Signed-off-by: Lucas Stach Applied. -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH v3 2/2] net: asix: handle packets crossing URB boundaries

2013-01-18 Thread David Miller
From: Lucas Stach Date: Wed, 16 Jan 2013 15:24:07 +0100 > ASIX AX88772B started to pack data even more tightly. Packets and the ASIX > packet > header may now cross URB boundaries. To handle this we have to introduce > some state between individual calls to asix_rx_fixup(). > > Signed-off-by: L

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-18 Thread David Miller
From: Freddy Xin Date: Thu, 17 Jan 2013 17:32:54 +0800 > +struct ax88179_rx_pkt_header { > + > + u8 l4_csum_err:1, Get rid of such extraneous empty lines. They do not add clarity, rather they just take up space. > + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | > +

Re: [PATCH 1/2] introduce flag FLAG_NOARP for usb net devices which cannot do ARP

2013-01-19 Thread David Miller
Why did you submit this _4_ times? I'm deleteing everything, I'm not even going to try and guess why you submitted this so many times and what might be different between each copy. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.k

Re: [PATCH net] net: qmi_wwan: add ONDA MT8205 4G LTE

2013-01-19 Thread David Miller
From: Bjørn Mork Date: Fri, 18 Jan 2013 15:26:34 +0100 > The driver description files gives these names to the vendor specific > functions on this modem: > > Diag VID_19D2&PID_0265&MI_00 > NMEA VID_19D2&PID_0265&MI_01 > AT cmd VID_19D2&PID_0265&MI_02 > Modem VID_19D2&PID_0265&MI_03 > N

Re: [PATCH 1/2] usbnet: introduce flag FLAG_NOARP for usb net devices

2013-01-19 Thread David Miller
When any patch is discarded, the whole series is tossed. Therefore you must resubmit the entire series, not just one part of it. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread David Miller
From: Wei Shuai Date: Mon, 21 Jan 2013 10:20:22 +0800 > The main problem is that these devices don't support ethernet. He's saying your comment is referring to the wrong thing, rather than saying anything against what your change is doing. Read his feedback carefully: >>> +/* Same as wwan_info

Re: [PATCH] usbnet: pegasus: set wakeup enable in set_wol

2013-01-20 Thread David Miller
From: Ming Lei Date: Sat, 19 Jan 2013 19:32:01 +0800 > This patch calls device_set_wakeup_enable() inside set_wol > callback, so that turning on WOL from user mode utility > can make the 'wakeup' of pegasus device to be enabled, then > remote wakeup may be enabled before putting into sleep. > >

Re: [PATCH net 0/3] cdc_ncm and cdc_mbim fixes for 3.8

2013-01-21 Thread David Miller
From: Bjørn Mork Date: Mon, 21 Jan 2013 16:50:37 +0100 > The 2 first patches in this series are required to make the Sierra > Wireless MC7710 card work in MBIM mode. They may also be > required for other Qualcomm firmware based MBIM devices. > > Patch #1 was previously posted as a standalone pa

Re: [PATCH 1/2] usbnet: add new flag FLAG_NOARP for usb net devices

2013-01-21 Thread David Miller
From: Wei Shuai Date: Tue, 22 Jan 2013 00:00:31 +0800 > We do have some USB net devices, which cannot do ARP. > so we can introduce a new flag FLAG_NOARP, then client drivers > can easily handle this kind of devices > > Signed-off-by: Wei Shuai Applied. -- To unsubscribe from this list: send

Re: [PATCH 2/2] cdc_ncm: add support FLAG_NOARP for Infineon modem platform

2013-01-21 Thread David Miller
From: Wei Shuai Date: Tue, 22 Jan 2013 00:00:32 +0800 > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. > we can define a new common structure wwan_noarp_info. > Then more similiar NO ARP devices can be handled easily > > Signed-off-by: Wei Shuai Applied. -- To unsubscribe from

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-22 Thread David Miller
From: Freddy Xin Date: Wed, 23 Jan 2013 10:32:17 +0800 > Fixed coding style errors. There are still many style issues remaining, you have a lot more work to do, for example: > + return fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, > +value, index, data, size); >

Re: [PATCH net] net: cdc_mbim: send ZLP only for the specific buggy device

2013-01-23 Thread David Miller
From: Bjørn Mork Date: Wed, 23 Jan 2013 11:57:02 +0100 > Reverting 328d7b8 and instead adding an exception for the > Sierra Wireless MC7710. > > commit 328d7b8 (net: cdc_mbim: send ZLP after max sized NTBs) > added a workaround for an issue observed on one specific device. > Concerns were raised

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread David Miller
From: Hayes Wang Date: Thu, 24 Nov 2016 13:26:55 + > I don't think the garbage results from our driver or device. This is my impression with what has been presented so far as well. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@v

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread David Miller
From: Mark Lord Date: Thu, 24 Nov 2016 07:31:17 -0500 > Any way we look at it though, the chip/driver are simply unreliable, > and relying upon hardware checksums (which fail due to the driver > looking at garbage rather than the checksum bits) leads to data > corruption. If the cpu/DMA implemen

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread David Miller
From: Mark Lord Date: Thu, 24 Nov 2016 11:43:53 -0500 > So even if this were a platform memory coherency issue, one should > still never see ASCII data at the beginning of an rx buffer. I'm not so convinced, since this is the kind of random corruption one would expect to see when dealing with vi

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread David Miller
From: Mark Lord Date: Thu, 24 Nov 2016 12:00:15 -0500 > It seems I am being overly helpful here. Either you want to cry or you want to keep helping us track down this problem. It is your choice, and your choice alone. Please do not pretend otherwise, everyone else in this thread is operating w

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-25 Thread David Miller
From: Mark Lord Date: Fri, 25 Nov 2016 07:49:35 -0500 > On 16-11-25 04:53 AM, Greg KH wrote: >> On Thu, Nov 24, 2016 at 10:49:33PM -0500, Mark Lord wrote: >>> There is no possibility for them to be used for anything other than >>> USB receive buffers, for this driver only. Nothing in the driver

Re: [PATCH] net: asix: Fix AX88772_suspend() USB vendor commands failure issues

2016-12-01 Thread David Miller
From: "ASIX_Allan [Office]" Date: Wed, 30 Nov 2016 16:29:08 +0800 > The change fixes AX88772_suspend() USB vendor commands failure issues. > > Signed-off-by: Allan Chou > Tested-by: Allan Chou > Tested-by: Jon Hunter Patch applied, thanks. -- To unsubscribe from this list: send the line "uns

Re: [PATH net v2] cdc_ether: Fix handling connection notification

2016-12-02 Thread David Miller
From: Kristian Evensen Date: Thu, 1 Dec 2016 14:23:17 +0100 > Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") > introduced a work-around in usbnet_cdc_status() for devices that exported > cdc carrier on twice on connect. Before the commit, this behavior caused > the link st

Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 19:24:48 +0800 > In function lan78xx_probe(), variable ret takes the errno code on > failures. However, when the call to usb_alloc_urb() fails, its value > will keeps 0. 0 indicates success in the context, which is inconsistent > with the execution result. Th

Re: [PATCH 0/1] NET: usb: cdc_mbim: add quirk for supporting Telit LE922A

2016-12-08 Thread David Miller
From: Daniele Palmas Date: Wed, 7 Dec 2016 14:07:47 +0100 > Telit LE922A MBIM based composition does not work properly > with altsetting toggle done in cdc_ncm_bind_common. > > This patch adds CDC_MBIM_FLAG_AVOID_ALTSETTING_TOGGLE quirk > to avoid this procedure that, instead, is mandatory for

Re: [PATCH 1/1] net: usb: asix_devices: add .reset_resume for USB PM

2017-01-04 Thread David Miller
From: Peter Chen Date: Tue, 3 Jan 2017 17:22:20 +0800 > The USB core may call reset_resume when it fails to resume asix device. > And USB core can recovery this abnormal resume at low level driver, > the same .resume at asix driver can work too. Add .reset_resume can > avoid disconnecting after b

Re: [PATCH net 0/2] r8152: fix autosuspend issue

2017-01-10 Thread David Miller
From: Hayes Wang Date: Tue, 10 Jan 2017 17:04:05 +0800 > Avoid rx is split into two parts when runtime suspend occurs. Series applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH net] r8152: fix the sw rx checksum is unavailable

2017-01-11 Thread David Miller
From: Hayes Wang Date: Wed, 11 Jan 2017 16:25:34 +0800 > Fix the hw rx checksum is always enabled, and the user couldn't switch > it to sw rx checksum. > > Note that the RTL_VER_01 only support sw rx checksum only. Besides, > the hw rx checksum for RTL_VER_02 is disabled after > commit b9a321b48

Re: [PATCH net-next] cdc-ether: usbnet_cdc_zte_status() can be static

2017-01-12 Thread David Miller
From: Wei Yongjun Date: Thu, 12 Jan 2017 13:43:47 + > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/usb/cdc_ether.c:469:6: warning: > symbol 'usbnet_cdc_zte_status' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Applied. -- To unsubscr

Re: [PATCH net] r8152: fix rtl8152_post_reset function

2017-01-20 Thread David Miller
From: Hayes Wang Date: Fri, 20 Jan 2017 14:33:55 +0800 > The rtl8152_post_reset() should sumbit rx urb and interrupt transfer, > otherwise the rx wouldn't work and the linking change couldn't be > detected. > > Signed-off-by: Hayes Wang Applied, thank you. -- To unsubscribe from this list: sen

Re: [PATCH net] r8152: don't execute runtime suspend if the tx is not empty

2017-01-24 Thread David Miller
From: Hayes Wang Date: Mon, 23 Jan 2017 14:18:43 +0800 > Runtime suspend shouldn't be executed if the tx queue is not empty, > because the device is not idle. > > Signed-off-by: Hayes Wang Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe l

Re: [RESENT PATCH net,stable] qmi_wwan/cdc_ether: add device ID for HP lt2523 (Novatel E371) WWAN card

2017-01-24 Thread David Miller
From: Bjørn Mork Date: Tue, 24 Jan 2017 10:45:38 +0100 > Another rebranded Novatel E371. qmi_wwan should drive this device, while > cdc_ether should ignore it. Even though the USB descriptors are plain > CDC-ETHER that USB interface is a QMI interface. Ref commit 7fdb7846c9ca > ("qmi_wwan/cdc_

Re: [PATCH net-next] r8152: fix the wrong spelling

2017-01-25 Thread David Miller
From: Hayes Wang Date: Wed, 25 Jan 2017 13:41:45 +0800 > Replace rumtime with runtime. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH net v2 0/4] r8152: fix scheduling napi

2017-01-25 Thread David Miller
From: Hayes Wang Date: Wed, 25 Jan 2017 16:13:17 +0800 > v2: > Add smp_mb__after_atomic() for patch #1. > > v1: > Scheduling the napi during the following periods would let it be ignored. > And the events wouldn't be handled until next napi_schedule() is called. > > 1. after napi_disable and be

Re: NAPI on USB network drivers

2017-01-25 Thread David Miller
From: Oliver Neukum Date: Wed, 25 Jan 2017 10:34:41 +0100 > looking at r8152 I noticed that it uses NAPI. I never considered > this for the generic USB networking code as you cannot disable > interrupts for USB. Is it still worth it? What are the benefits? I think it's not a good approach for ge

Re: [PATCH net 0/5] r8152: correct the flow of PHY

2016-09-20 Thread David Miller
From: Hayes Wang Date: Tue, 20 Sep 2016 16:22:04 +0800 > First, to enable the PHY as early as possible. Some settings may fail if the > PHY is power down. > > Move the other PHY settings to hw_phy_cfg() to make sure the order is correct. > > Finally, disable ALDPS and EEE before updating the PH

Re: [PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-24 Thread David Miller
From: Chris Roth Date: Sat, 24 Sep 2016 10:59:04 -0600 > Due to my lack of familiarity with the how git send-email works, I've > unintentionally had my name listed as the first 'from' whereas I > intended Allan Chou to be listed as the first 'from' in the patch. If > anyone can correct this on my

Re: [PATCH v3] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-27 Thread David Miller
From: Date: Tue, 27 Sep 2016 09:57:50 -0600 > From: Chris Roth > > From Allan Chou > From: Chris Roth Three From lines, it's actually quite amazing how you were able to achieve this. Please take some time, and carefully craft your patch emails but don't send them to the list. Instead, emai

Re: [PATCH] net: usb: lan78xx: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sun, 9 Oct 2016 12:07:04 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: HSO driver patch again [2/2]

2016-10-11 Thread David Miller
"HSO driver patch again ..." is not an appropriate Subject line when submitting patches. Please read Documentation/SubmittingPatches for how to do things properly, and in a way that will actually lead to your patches being applied. Thanks. -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH net] qmi_wwan: add support for Quectel EC21 and EC25

2016-10-13 Thread David Miller
From: Bjørn Mork Date: Mon, 10 Oct 2016 21:12:49 +0200 > The Quectel EC21 and EC25 need the same "set DTR" request as devices > based on the MDM9230 chipset, but has no USB3 support. Our best guess > is that the "set DTR" functionality depends on chipset and/or > baseband firmware generation. But

Re: [PATCH] net: asix: Avoid looping when the device does not respond

2016-10-14 Thread David Miller
From: Guenter Roeck Date: Thu, 13 Oct 2016 16:43:16 -0700 > Check answers from USB stack and avoid re-sending the request > multiple times if the device does not respond. > > This fixes the following problem, observed with a probably flaky adapter. ... > Since the USB timeout is 5 seconds, and

Re: [PATCH net-next] r8152: add new products of Lenovo

2016-10-18 Thread David Miller
From: Hayes Wang Date: Tue, 18 Oct 2016 11:41:48 +0800 > Add the following four products of Lenovo and sort the order of the list. > > VID PID > 0x17ef 0x3062 > 0x17ef 0x3069 > 0x17ef 0x720c > 0x17ef 0x7214 > > Signed

Re: [PATCH] kalmia: avoid potential uninitialized variable use

2016-10-27 Thread David Miller
From: Arnd Bergmann Date: Mon, 24 Oct 2016 17:54:18 +0200 > The kalmia_send_init_packet() returns zero or a negative return > code, but gcc has no way of knowing that there cannot be a > positive return code, so it determines that copying the ethernet > address at the end of kalmia_bind() will ac

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-31 Thread David Miller
From: Ville Syrjälä Date: Fri, 28 Oct 2016 19:33:32 +0300 > On Fri, Oct 28, 2016 at 01:16:13PM +0300, Felipe Balbi wrote: >> Yeah, I'm guessing we're gonna need some help from networking folks. The >> only thing we did since v4.7 was actually respect req->no_interrupt flag >> coming from u_ether

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread David Miller
From: Peter Chen Date: Wed, 2 Nov 2016 14:02:02 +0800 > Felipe, it may increase cpu utilization since more interrupts will be there, > it may affect the SoC which has lower cpu frequency. This code existed > many years, why this problem has only reported at dwc3 recently? It's a bug, and it's go

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-03 Thread David Miller
From: Felipe Balbi Date: Thu, 03 Nov 2016 09:04:54 +0200 > What Dave Miller is saying is that it's ALWAYS a bug to delay > completion of SKBs. The only thing you're doing with chipidea is > delaying interrupt by up to 125us; which is still a bug from the > point of view of the networking layer, b

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-07 Thread David Miller
From: Felipe Balbi Date: Mon, 07 Nov 2016 14:39:21 +0200 > > Hi, > > David Miller writes: >> From: Felipe Balbi >> Date: Thu, 03 Nov 2016 09:04:54 +0200 >> >>> What Dave Miller is saying is that it's ALWAYS a bug to delay >>> completion

Re: [PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-11-09 Thread David Miller
From: Date: Tue, 8 Nov 2016 16:08:01 -0600 > From: Allan Chou > > Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet > Bridge Controller (Vendor=04b4 ProdID=3610). > > Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems > with the Kensington SD4600P USB-C Universal Dock wi

Re: [PATCH] r8152: Fix error path in open function

2016-11-13 Thread David Miller
From: Guenter Roeck Date: Wed, 9 Nov 2016 19:51:25 -0800 > If usb_submit_urb() called from the open function fails, the following > crash may be observed. ... > Clean up error handling to avoid registering the notifier if the open > function is going to fail. > > Signed-off-by: Guenter Roeck

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread David Miller
From: Hayes Wang Date: Fri, 11 Nov 2016 15:15:41 +0800 > For some platforms, the data in memory is not the same with the one > from the device. That is, the data of memory is unbelievable. The > check is used to find out this situation. > > Signed-off-by: Hayes Wang I'm all for adding consiste

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-14 Thread David Miller
From: Hayes Wang Date: Mon, 14 Nov 2016 07:23:51 + > Mark Lord [mailto:ml...@pobox.com] >> Sent: Monday, November 14, 2016 4:34 AM > [...] >> Perhaps the driver >> is somehow accessing the buffer space again after doing usb_submit_urb()? >> That would certainly produce this kind of behaviour.

Re: [GIT PULL] USB fixes for v4.9-rc4

2016-11-15 Thread David Miller
From: Peter Chen Date: Wed, 16 Nov 2016 11:41:15 +0800 > I just notice that you submitted the "usb: gadget: u_ether: remove > interrupt throttling", and cc stable tree too, but we can't get > the agreement that it is suitable for all USB controllers, and David > added this comment later that the

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

2015-12-04 Thread David Miller
From: Bjørn Mork Date: Thu, 3 Dec 2015 19:24:17 +0100 > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra Wireless MC

Re: [PATCH net,stable] net: cdc_mbim: add "NDP to end" quirk for Huawei E3372

2015-12-05 Thread David Miller
From: Bjørn Mork Date: Sat, 5 Dec 2015 13:01:50 +0100 > The Huawei E3372 (12d1:157d) needs this quirk in MBIM mode > as well. Allow this by forcing the NTB to contain only a > single NDP, and add a device specific entry for this ID. > > Due to the way Huawei use device IDs, this might be applie

Re: [PATCH net-next] net: qmi_wwan: should hold RTNL while changing netdev type

2015-12-06 Thread David Miller
From: Bjørn Mork Date: Sun, 6 Dec 2015 21:25:50 +0100 > The notifier calls were thrown in as a last-minute fix for an > imagined "this device could be part of a bridge" problem. That > revealed a certain lack of locking. Not to mention testing... > > Avoid this splat: ... > Fixes: 32f7adf633b

Re: [PATCH net-next] net: cdc_ncm: add "ndp_to_end" sysfs attribute

2015-12-06 Thread David Miller
From: Bjørn Mork Date: Sun, 6 Dec 2015 22:47:15 +0100 > Adding a writable sysfs attribute for the "NDP to end" > quirk flag. > > This makes it easier for end users to test new devices for > this firmware bug. We've been lucky so far, but we should > not depend on reporters capable of rebuildin

Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-08 Thread David Miller
From: Peter Wu Date: Tue, 8 Dec 2015 12:17:42 +0100 > When an interface is brought up which was previously suspended (via > runtime PM), it would hang. This happens because napi_disable is called > before napi_enable. > > Solve this by avoiding napi_enable in the resume during open function > (

Re: [PATCH net-next] net: qmi_wwan: ignore bogus CDC Union descriptors

2015-12-17 Thread David Miller
From: Bjørn Mork Date: Thu, 17 Dec 2015 12:44:04 +0100 > The CDC descriptors found on these vendor specific functions should > not be considered authoritative. They seem to be ignored by drivers > for other systems, and the quality is therefore low. > > One device (1e0e:9001) has been reported

Re: [PATCH v2 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-18 Thread David Miller
From: Daniele Palmas Date: Fri, 18 Dec 2015 14:43:32 +0100 > This patch series add support in the cdc_ncm driver for two devices > based on the same platform, that are different only for carrier > customization. > > V2: Added comment for highlighting FLAG_NOARP usage for those devices Series ap

Re: [PATCH net,stable] net: cdc_ncm: avoid changing RX/TX buffers on MTU changes

2015-12-23 Thread David Miller
From: Bjørn Mork Date: Wed, 23 Dec 2015 13:42:43 +0100 > NCM buffer sizes are negotiated with the device independently of > the network device MTU. The RX buffers are allocated by the > usbnet framework based on the rx_urb_size value set by cdc_ncm. A > single RX buffer can hold a number of MTU

Re: [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver()

2016-01-02 Thread David Miller
From: Bjørn Mork Date: Sat, 02 Jan 2016 22:30:48 +0100 > SF Markus Elfring writes: > >> From: Markus Elfring >> Date: Fri, 1 Jan 2016 17:35:03 +0100 >> >> Omit explicit initialisation at the beginning for one local variable >> that is redefined before its first use. > > > This patch is unnec

Re: [PATCH net] r8152: add reset_resume function

2016-01-04 Thread David Miller
From: Hayes Wang Date: Mon, 4 Jan 2016 14:38:46 +0800 > When the reset_resume() is called, the flag of SELECTIVE_SUSPEND should be > cleared and reinitialize the device, whether the SELECTIVE_SUSPEND is set > or not. If reset_resume() is called, it means the power supply is cut or the > device is

Re: [PATCH net,stable] qmi_wwan: add "4G LTE usb-modem U901"

2016-02-16 Thread David Miller
From: Bjørn Mork Date: Fri, 12 Feb 2016 16:42:14 +0100 > Thomas reports: > > T: Bus=01 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 4 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=05c6 ProdID=6001 Rev=00.00 > S: Manufacturer=USB Modem > S: Product=USB Mod

Re: [PATCH] USB: cdc_subset: only build when one driver is enabled

2016-02-18 Thread David Miller
From: Arnd Bergmann Date: Wed, 17 Feb 2016 23:25:11 +0100 > This avoids a harmless randconfig warning I get when USB_NET_CDC_SUBSET > is enabled, but all of the more specific drivers are not: > > drivers/net/usb/cdc_subset.c:241:2: #warning You need to configure some > hardware for this driver

Re: [PATCH net] r8152: fix runtime function for RTL8152

2016-07-05 Thread David Miller
From: Hayes Wang Date: Tue, 5 Jul 2016 16:11:46 +0800 > The RTL8152 doesn't have U1U2 and U2P3 features, so use different > runtime functions for RTL812 and RTL8153 by adding autosuspend_en() > to rtl_ops. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send th

Re: [PATCH net] r8152: remove the setting of LAN_WAKE_EN

2016-07-08 Thread David Miller
From: Hayes Wang Date: Wed, 6 Jul 2016 17:03:29 +0800 > The LAN_WAKE_EN is not used to determine if the device could support > WOL. It is used to sigal a GPIO pin when a WOL event occurs. The WOL > still works even though it is disabled. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe

Re: [PATCH net-next 0/3] r8152: remove the redundant code

2016-07-09 Thread David Miller
From: Hayes Wang Date: Thu, 7 Jul 2016 15:09:17 +0800 > Remove the unnacessary code. Series applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-07-11 Thread David Miller
From: Date: Mon, 11 Jul 2016 21:54:07 + > Please let me know what else can be done for this patch to make it > acceptable so we can have parity for Linux. Just resubmit it and I'll apply it, I'm so tired of hearing about this... -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v6 RESEND] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-07-11 Thread David Miller
From: Mario Limonciello Date: Mon, 11 Jul 2016 19:58:04 -0500 > The RTL8153-AD supports a persistent system specific MAC address. > This means a device plugged into two different systems with host side > support will show different (but persistent) MAC addresses. > > This information for the sys

Re: [PATCH 0 / 5] move the common CDC parser

2016-07-15 Thread David Miller
From: Oliver Neukum Date: Thu, 14 Jul 2016 15:41:29 +0200 > Experience has shown that making all CDC drivers depend on usbnet > is not practical, because some of them are not network drivers. > So this patch moves the common parser from usbnet into the messages > helpers of usbcore. > The rest of

Re: [PATCH] r8152: add MODULE_VERSION

2016-07-15 Thread David Miller
From: Grant Grundler Date: Thu, 14 Jul 2016 11:27:16 -0700 > ethtool -i provides a driver version that is hard coded. > Export the same value via "modinfo". > > Signed-off-by: Grant Grundler Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messa

  1   2   3   4   5   6   7   8   >