[RFC PATCH 16/20] xhci: refactor prepare_transfer()

2014-08-22 Thread Dan Williams
boundary. Signed-off-by: Dan Williams --- drivers/usb/host/xhci-ring.c | 122 -- 1 files changed, 70 insertions(+), 52 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 27d271e26445..3a9ed6543dfe 100644 --- a

[RFC PATCH 18/20] xhci: add xhci_ring_reap_td() helper

2014-08-22 Thread Dan Williams
TDs from endpoint rings are open-coded cleaned up in a duplicate fashion in two places. Provide common helper. This is later used to as a place to inject ring-type-specific post-reap operations. Signed-off-by: Dan Williams --- drivers/usb/host/xhci-ring.c | 17 + 1 files

[RFC PATCH 14/20] xhci: power-of-2 ring sizes

2014-08-22 Thread Dan Williams
dequeue pointer? The open coded "num_trbs alignment" statement in xhci_ring_expansion() is replaced with the standard ALIGN macro. Signed-off-by: Dan Williams --- drivers/usb/host/xhci-mem.c | 45 ++- drivers/usb/host/xhci.c |2 +- d

[RFC PATCH 15/20] xhci: kill ->num_trbs_free_temp in struct xhci_ring

2014-08-22 Thread Dan Williams
This can simply be done inline in xhci_queue_isoc_tx(). Signed-off-by: Dan Williams --- drivers/usb/host/xhci-ring.c |6 +++--- drivers/usb/host/xhci.h |1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c

[RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-22 Thread Dan Williams
f segments. MBP: Max Burst Packet, is the minimum amount of data hardware expects to transfer before the end of a segment (assuming the TD spans a segment boundary). Signed-off-by: Dan Williams --- drivers/usb/host/xhci-mem.c | 17 + drivers/usb/host/xhci-rin

[RFC PATCH 20/20] xhci: unit test ring enqueue/dequeue routines

2014-08-22 Thread Dan Williams
that the infrastructure is custom rather than generic. That said, it serves its purpose of exercising the corner cases of the scatterlist parsing implementation in xhci. Cc: Rusty Russell Signed-off-by: Dan Williams --- drivers/usb/host/Kconfig| 13 + drivers/usb/host/Mak

Re: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-22 Thread Dan Williams
On Fri, Aug 22, 2014 at 10:57 AM, Alan Stern wrote: > On Fri, 22 Aug 2014, Dan Williams wrote: > >> v1.0 hosts require that TD-fragments (portions of a TD that do not end >> on a MPB boundary) not cross a TRB segment boundary. This constraint is >> in addition to the c

Re: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 3:37 AM, David Laight wrote: > From: Dan Williams >> It's confusing (to me at least) to keep on remembering the differences >> between event rings (managed by the hardware) and non-event rings >> managed by the host. Replace "if (ring->t

Re: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 3:55 AM, David Laight wrote: > From: Dan Williams >> v1.0 hosts require that TD-fragments (portions of a TD that do not end >> on a MPB boundary) not cross a TRB segment boundary. This constraint is >> in addition to the constraint that a TRB may n

Re: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 9:21 AM, David Laight wrote: > From: Dan Williams [mailto:dan.j.willi...@intel.com] >> On Tue, Aug 26, 2014 at 3:37 AM, David Laight >> wrote: >> > From: Dan Williams >> >> It's confusing (to me at least) to keep on remembering

Re: [xhci] BUG: unable to handle kernel NULL pointer dereference at (null)

2014-08-27 Thread Dan Williams
s-v1 > > commit e65e21a542cab81d794db4e5fe919c4e1d624ea7 > Author: Dan Williams > AuthorDate: Tue Jul 22 00:08:51 2014 -0700 > Commit: Dan Williams > CommitDate: Fri Aug 22 10:06:50 2014 -0700 > > xhci: unit test ring enqueue/dequeue routines > > Given the complexity of satisfying

Re: cdc_acm / cdc_wdm issue. Connection to device lost (Sony Ericsson w660)

2015-06-20 Thread Dan Williams
On Fri, 2015-06-19 at 19:43 +0200, Fab Stz wrote: > Oh ! I just realized my mistake. Actually it is not the kernel that is faulty > but my configuration (since I migrated from debian wheezy to jessie). > > I had connection/disconnection issues because of conflicts between gammu and > ModemManage

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Dan Williams
On Thu, 2015-07-02 at 15:43 +0200, Oliver Neukum wrote: > On Thu, 2015-07-02 at 20:33 +0700, Lars Melin wrote: > > On 2015-07-02 20:01, Oliver Neukum wrote: > > > On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: > > >> On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: > > >> > > >>> Then

Re: Resetting USB modems and USB to serial converters increases ttyUSBXX counter

2015-10-22 Thread Dan Williams
On Thu, 2015-10-22 at 10:39 +0200, Erwin Van de Velde wrote: > Hi all, > > Thank you for your helpful answers! I have investigated it further, > stopping potential culprits in userspace and I have found the issue: > it is modemmanager that seems to keep the devices open somewhere and > thus causes

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Dan Williams
On Wed, 2015-11-04 at 16:57 +0100, Bjørn Mork wrote: > Petr Štetiar writes: > > > Bjørn Mork [2015-11-04 13:15:10]: > > > >> Based on that, I wonder if it wouldn't be more appropriate to simply do > >> this as a device specific quirk in the qmi_wwan probe? > > > > So rather something like this?

Re: Obtaining USB vendor/product ID in C language given a modem file path

2015-11-18 Thread Dan Williams
On Wed, 2015-11-18 at 18:56 -0800, ToddA wrote: > Hi, > > If this isn't the correct mailing list for this question, do let me > know > if there's a better one where I could ask. > > I have a C language program that talks to modems and these days it is > almost always a USB modem. For diagnostic

Re: Celot modem driver

2015-11-25 Thread Dan Williams
On Wed, 2015-11-25 at 13:13 +0100, M. Hrdlička wrote: > Hello, > log script told me, that I may to tell you about add this device to > propper linux driver. > > Device is combo USB modem Celot CTD-200, manufacturing date in > September 2010, it´s combinated GSM (GPRS/UMTS/HSPA) and CDMA modem. > I

Re: [PATCH] usb: Quiet down false peer failure messages

2015-11-30 Thread Dan Williams
On Tue, Nov 17, 2015 at 1:00 PM, Don Zickus wrote: > My recent Intel box is spewing these messages: > > xhci_hcd :00:14.0: xHCI Host Controller > xhci_hcd :00:14.0: new USB bus registered, assigned bus number 2 > usb usb2: New USB device found, idVendor=1d6b, idProduct=0003 > usb usb2: New

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

2015-12-03 Thread Dan Williams
On Thu, 2015-12-03 at 19:24 +0100, Bjørn Mork wrote: > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra Wireless MC7455

Re: [PATCH v2] usb: Quiet down false peer failure messages

2015-12-03 Thread Dan Williams
t1 of the XHCI hub, each following matching peer will generate the > above warning. > > These warnings seem to be harmless for this scenario as I don't think it > matters that unused ports could not create a peer link. > > The attached patch utilizes that assumption and just tu

Re: [PATCH 04/11] hso: fix memory leak in hso_create_rfkill()

2015-01-20 Thread Dan Williams
On Tue, 2015-01-20 at 14:13 +0100, Oliver Neukum wrote: > On Tue, 2015-01-20 at 13:29 +0100, Olivier Sobrie wrote: > > When the rfkill interface was created, a buffer containing the name > > of the rfkill node was allocated. This buffer was never freed when the > > device disappears. > > > > To fi

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-26 Thread Dan Williams
On Mon, 2015-01-26 at 19:17 +0100, Johan Hovold wrote: > On Mon, Jan 26, 2015 at 04:00:26PM +0100, Henri Manson wrote: > > Hello, > > > > I performed the test using VirtualBox and live cd iso images, so > > mixing different version of kernel and user-space programs does not > > happen. > > You'd

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-26 Thread Dan Williams
plug it in again, ModemManager will then ignore it. What is the VID/PID again so that we can add it to the upstream blacklist? Dan > On Mon, Jan 26, 2015 at 10:20 PM, Dan Williams wrote: > > On Mon, 2015-01-26 at 19:17 +0100, Johan Hovold wrote: > >> On Mon, Jan 26, 2015 at 04

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-26 Thread Dan Williams
On Mon, 2015-01-26 at 23:33 +0100, Henri Manson wrote: > From lsusb: > > Bus 008 Device 013: ID 0830:0002 Palm, Inc. m505 I've blacklisted anything driven by 'visor' upstream in ModemManager, since most of those appear to be non-phone devices. Yes, 3 are phones (Samsung and Acer) but they are so

Re: difference in option.ko and sierra.ko Linux drivers

2015-01-29 Thread Dan Williams
On Thu, 2015-01-29 at 06:23 -0800, Greg KH wrote: > On Thu, Jan 29, 2015 at 02:50:13PM +0530, temp sha wrote: > > Can any one let me know the difference in option and sierra kernel > > modules ? looks like both drivers support GSM modem. And from the > > source code perspective both look similar. I

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Dan Williams
counter that is incremented each time a new rfkill interface is > added. > > Suggested-by: Dan Williams > Signed-off-by: Olivier Sobrie > --- > drivers/net/usb/hso.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/usb/hso.c b/driv

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Dan Williams
On Fri, 2015-01-30 at 17:15 +0100, Olivier Sobrie wrote: > Hello Dan, > > On Fri, Jan 30, 2015 at 09:47:59AM -0600, Dan Williams wrote: > > On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote: > > > By using only the usb interface number for the rfkill name, we

Re: difference in option.ko and sierra.ko Linux drivers

2015-02-05 Thread Dan Williams
On Thu, 2015-02-05 at 07:33 -0800, Greg KH wrote: > On Thu, Feb 05, 2015 at 07:36:40PM +0530, temp sha wrote: > > You mean to say only Sierra has its own proprietary commands and no one > > else ? > > What is so special about Sierra that requires a dedicated driver in > > Linux while rest of > > a

Re: usbserial option driver newid

2015-03-05 Thread Dan Williams
On Wed, 2015-03-04 at 22:00 -0500, Rick Farina wrote: > On 03/04/15 13:01, Greg KH wrote: > > And again, a kernel patch is the real way to fix it for everyone. > > > Okay, got a lot of things figured out and have everything working now. > Glad I spent the extra time because I found some neat thin

Re: PROBLEM: HUAWEI E3531 HSPA+ USB Stick "please report the device ID to the Linux USB developers"

2019-03-18 Thread Dan Williams
On Sun, 2019-03-17 at 14:25 +0100, Peter Schüller wrote: > [1.] One line summary of the problem: > > Plugging in HUAWEI E3531 USB Modem causes "report the device ID to > the > Linux USB developers" and device can only be used with a workaround [removing netdev list...] With the modem plugged in,

Re: PROBLEM: HUAWEI E3531 HSPA+ USB Stick "please report the device ID to the Linux USB developers"

2019-03-18 Thread Dan Williams
On Mon, 2019-03-18 at 18:50 +0100, Peter Schüller wrote: > [corrected email of Kai-Heng Feng] > > Am Mo., 18. März 2019 um 15:39 Uhr schrieb Dan Williams < > d...@redhat.com>: > > [removing netdev list...] > > > > With the modem plugged in, could you grab the

Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID

2019-07-16 Thread Dan Williams
On Tue, 2019-07-16 at 21:12 +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: sta...@vger.kernel.org > --- > Also add the qmi_wwan entry, since it was blacklisted already in option > > Apologies for the spam! > > drivers/net/usb/qmi_wwan.c | 1 + > drivers/usb/serial/option

Re: [PATCH v5 13/29] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-07-30 Thread Dan Williams
ctl = dimm_ioctl, > - .compat_ioctl = dimm_ioctl, > + .compat_ioctl = compat_ptr_ioctl, > .llseek = noop_llseek, > }; Acked-by: Dan Williams

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Dan Williams
On Thu, 2018-03-22 at 20:28 +0100, Pavel Machek wrote: > Hi! > > > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost > > > $ > > > sudo lsusb > > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > > Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-24 Thread Dan Williams
On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > On Fri 2018-03-23 12:35:21, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > > > Do you have the related dts patches picked from next? > > > > > > > > > > > > fd

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-26 Thread Dan Williams
On Sun, 2018-03-25 at 13:52 -0700, Tony Lindgren wrote: > * Pavel Machek [180325 19:00]: > > Hi! > > > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it > > > > seems > > > > to react to AT commands, and in particular reacts to ADT123; (; > > > > is > > > > important). > > > >

Re: [PATCH] usb:serial:optrion: fix dwm-158 3g modem interface

2018-04-23 Thread Dan Williams
On Mon, 2018-04-23 at 14:14 +0700, Lars Melin wrote: > On 4/23/2018 14:03, Giuseppe Lippolis wrote: > > The dwm-158 interface 4 and 5 doesn't answer to the AT commands > > and doesn't appears a option interface. > > Tested on openwrt distribution (kernel 4.14 using the old blacklist > > definitions

Re: [PATCH] usb:serial:optrion: fix dwm-158 3g modem interface

2018-04-23 Thread Dan Williams
On Tue, 2018-04-24 at 09:55 +0700, Lars Melin wrote: > On 4/23/2018 23:54, Dan Williams wrote: > > > > MI_00 D-Link Mobile Broadband Device (cdc_ether) > > > MI_02 D-Link HSPA+DataCard Diagnostics Interface (also ppp m > > > MI_03 D-Link HSPA+DataCard NMEA Device

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Dan Williams
On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote: > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > > On 4/26/2018 23:12, Johan Hovold wrote: > > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > > > > On 4/26/2018 18:39, Lars Melin wrote: > > > > > On 4/26/2018 18:

Re: [PATCH] USB: cdc-wdm: ignore -EPIPE from GetEncapsulatedResponse

2017-10-02 Thread Dan Williams
On Fri, 2017-09-22 at 22:18 +0200, Bjørn Mork wrote: > The driver will forward errors to userspace after turning most of > them > into -EIO. But all status codes are not equal. The -EPIPE (stall) in > particular can be seen more as a result of normal USB signaling than > an actual error. The state

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > Hi Johan, > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold > > wrote: > > > This will probably have to do for now, but we already have > > > another > > > blacklist

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Wed, 2018-01-31 at 16:32 -0600, Dan Williams wrote: > On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > > Hi Johan, > > > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold >

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-04 Thread Dan Williams
ersion and it's safe to > get rid of it. > > The conversion fixes a potential bug in int340x_thermal as well since > we have to use memcmp() on binary data. > > Cc: Rafael J. Wysocki > Cc: Mika Westerberg > Cc: Borislav Petkov > Cc: Dan Williams > Cc: Amir Goldste

Re: [PATCH v2] usb: serial: Add support for Qivicon USB ZigBee dongle

2017-07-03 Thread Dan Williams
On Mon, 2017-07-03 at 10:16 +0200, Frans Klaver wrote: > On Mon, Jul 3, 2017 at 10:13 AM, Johan Hovold > wrote: > > On Fri, Jun 30, 2017 at 02:49:55PM +0200, Frans Klaver wrote: > > > On Fri, Jun 30, 2017 at 2:44 PM, Stefan Triller > > ller.de> wrote: > > > > The German Telekom offers a ZigBee US

Re: AW: new usb LTE modem device

2017-08-08 Thread Dan Williams
On Tue, 2017-08-08 at 22:22 +0200, Giuseppe Lippolis wrote: > > The option driver use interface blacklists instead of multiple > > match entries. > > You should probably follow the same style there. But this is up to > > Johan... > > Can I ask what ist he difference between .sendsetup and .reserve

Re: new usb LTE modem device

2017-08-09 Thread Dan Williams
On Wed, 2017-08-09 at 11:19 +0700, Lars Melin wrote: > On 8/9/2017 02:33, Bjørn Mork wrote: > > > > The qmi_wwan part looks fine to me. But you > > will need to split it in two patches since the two > > drivers are parts of different subsystems. > > > > The option driver use interface blacklists

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-10 Thread Dan Williams
values as the diag > interface. However, the two interfaces have different number of > endpoints, QMI has three and diag two. I have added a check for > number > of interfaces if VID/PID matches the EP06, and we ignore the device > if > number of interfaces equals three (and subclass

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-12 Thread Dan Williams
On Thu, 2018-09-13 at 01:25 +0700, Lars Melin wrote: > On 9/12/2018 23:57, Kristian Evensen wrote: > > On Wed, Sep 12, 2018 at 6:32 PM Lars Melin > > wrote: > > > You have chosen a platform which has limited usb resources and > > > want to > > > solve that problem by adjusting the device driver? >

Re: TL-MR3420 with OpenWRT with a huawei E353 usb dongle

2019-08-19 Thread Dan Williams
On Wed, 2019-08-14 at 22:09 +0200, Greg KH wrote: > On Wed, Aug 14, 2019 at 11:42:53AM -0300, Francisco Ferreiro wrote: > > Hi guys, this is me trying to setup a tp-link TL-MR3420 with > > OpenWRT > > with a huawei E353 usb dongle > > > > hopefully I will try to setup a multiwan along with this t

Re: [PATCH 3/3] net: cdc_ncm: Add ACPI MAC address pass through functionality

2019-09-06 Thread Dan Williams
On Fri, 2019-09-06 at 09:59 +0200, Bjørn Mork wrote: > writes: > > > + if (strstr(dev->udev->product, "D6000")) { > > Huh? Can you please test that on all USB devices ever made? Yeah. Can't VID/PID be used as the filter here instead? Dan

<    2   3   4   5   6   7